[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #4 from Victor Grousset/tuxayo --- (In reply to Lucas Gass from comment #3) > Are you attempting to hide/show the columns by using the column > configuration tool? Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 --- Comment #12 from Victor Grousset/tuxayo --- BTW, how does one makes "phone" and "SMS" tickable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Failed QA --- Comment #11 from Victor Grousset/tuxayo --- > 6) Editor should behave as it did before Everything was fine until this step: > Could not compile /kohadevbox/koha/tools/overduerules.pl: > syntax error at /kohadevbox/koha/tools/overduerules.pl line 169, near "};" > BEGIN not safe after errors--compilation aborted at > /kohadevbox/koha/tools/overduerules.pl line 313. > at /usr/share/perl5/CGI/Compile.pm line 132 It's a missing parenthesis: }; ↓ }); Even after fixing there is an issue. "Email" and "print" aren't saved when ticked, they disappear after saving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603 --- Comment #5 from David Cook --- But in any case... I think there's a difference between the Koha 001 and 003... and the original 001 and 003. I think we abuse the 001 and 003 in Koha, and I'm not sure we should develop functionality to further entrench that abuse. But I would be interested in a table that tracks record imports better, so that it would be easier to find a local Koha identifier (ie biblionumber / 999$c) that was created during an import using the 001 and 003 (or OAI-PMH identifier and baseUrl). However, how likely is it for source MARC data to have the 001 and 003 properly filled out? Looks like import_biblios has a control_number field, but cleanup_database.pl deletes all the records from the import_* tables periodically, so that's not useful. Anyway, I'll stop spamming now. I think that I'm probably just being too idealistic. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603 --- Comment #4 from David Cook --- I'm trying to think how we could do this in a more extensible way... and I might have an idea. MARC: 001 - Control Number 003 - Control Number Identifier 005 - Date and Time of Latest Transaction OAI-PMH: identifier baseURL datestamp These two schemas actually overlap pretty much perfectly, and those are the 3 criteria I use when I'm matching for my OAI-PMH imports. It's basically a record number, a record origin, and a last modified date. When matching, if the record number and origin match and the inbound record is newer, update the record. Easy. Thinking about other metadata schemas... - Unqualified Dublin Core wouldn't fit that pattern, but that's partially because it's too simplistic of a schema. Qualified Dublin Core could. - I don't know BIBFRAME well enough. Looking at https://www.loc.gov/bibframe/implementation/register.html, I see a bf:changeDate. I suppose maybe their "Control Number Identifier" or "baseURL" could be empty since the BIBFRAME URI should be globally unique. Although BIBFRAME is just a whole other ball game anyway... -MODS has a recordIdentifier for 001, and recordIdentifier "source" attribute for 003, and recordChangeDate for 005... I suppose the reality is that we just support MARC for the time being, and we have no idea what a post-MARC world will actually look like, so maybe we should just develop against a MARC world. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603 --- Comment #3 from David Cook --- (In reply to Magnus Enger from comment #0) > Koha itself does not care too much about these fields, but sometimes they > are used when importing/syncing in records from external sources, and then > it can be work intensive to match on WHERE ExtractValue( > metadata,\'//controlfield[@tag="001"]\' ). This would be much easier if the > 001 and 003 fields from the record had their own database columns we could > match on. > > Similar to: Bug 11529 - Add subtitle, medium and part fields to biblio table I'm trying to wrap my head around how we'd do this in practice. In theory, Koha should be resetting the 001 and 003, but it doesn't do that currently. I guess you'd be relying on that? Trying to match off the original 001 and 003 to improve the ease of matching records from external sources. I can see the logic there for sure. Personally, I wish that we'd move the 001 and 003 to the 035 during import, although that would present its own matching problems, plus the 035 is a repeatable field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- (In reply to Andreas Jonsson from comment #1) > It would be nice to have one table for control fields and one table for > data-fields. I don't think that's ever going to happen, as we're (slowly) trying to get away from MARC. > We could make it configurable which fields that should be > indexed in these tables if storage space would be an issue. We wouldn't make the database schema configurable, and it would be the database indexing that would be valuable here. Indexing database columns for identifiers like 001 and 003 would be very reasonable though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25571] "Bibliographic record not found" when click on Edit item table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25571 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 --- Comment #8 from David Cook --- (In reply to Aaron Sakovich from comment #7) > The FIDO alliance has published a new website promoting FIDO2 for both > consumers and providers. FIDO2 includes Yubikey and other key vendor > support, as well as biometrics (facial scans and fingerprint), and personal > PINs. > > https://loginwithfido.com/provider/ > > This is an established and well-supported standard, defined by both the FIDO > Alliance and W3C's webauthn. Just dropping this here as I think it might be > a better, all-encompassing approach to authentication in general, beyond > just adding 2FA, and is way easier for the end-user with its multiple > supported authenticators, not just a single vendor's hardware key. Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #42 from David Cook --- (In reply to Tomás Cohen Arazi from comment #41) > I think this implementation is simple and covers the use case it is intended > to. If we happen to have a task scheduler in a future, we could replace this > and many other things we do with cron with it. > Agreed. With one of my OAI-PMH plugins, I'm writing a custom task scheduler, but it's a complex piece of work, so I'd be happy to use the plugin nightly hook in the meantime (especially if it were backported to 19.11). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25613] Broken workflow on CAS login with wrong permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25613 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25613] New: Broken workflow on CAS login with wrong permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25613 Bug ID: 25613 Summary: Broken workflow on CAS login with wrong permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org If you set to login through CAS, and don't have enough permissions for the admin interface, you get into a loop in which you cannot re-try with other credentials, unless you clean the CAS cookies. This also happens when the user doesn't match any user in Koha's DB. This can be very problematic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 --- Comment #3 from Lucas Gass --- I wasn't sure if we should turn those options into a dropdown like we do on the OPAC results page. https://snipboard.io/4xMOz8.jpg Or maybe that is for another patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #3 from Lucas Gass --- Victor, Thanks for testing. Are you attempting to hide/show the columns by using the column configuration tool? The only reason I said 'open a new tab' is so the tester can have the column configuration tool open in one tab and the table in another. To make it easier to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #6 from Lucas Gass --- Created attachment 105405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105405=edit Bug 22672: Change to and to in templates, includes, xslt This patch attempts to replace with AND with in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use . I found templates, includes and XSLT by using 'git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of or that I could have missed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #32 from Katrin Fischer --- > Hi, > > I tested it on 19.05.04 and i have same problem. > > Items not for loan (authorized value <>0) are still displayed in search > results. > > I miss something? > > Regards, > > Marjorie I Marjorie - I believe this is not a bug for (or not false behaviour) for all libraries. Available != checked out. You might still be able to use the reference collection marked not for loan in the library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 --- Comment #4 from Katrin Fischer --- A bug in the installation or a bug we should have a patch for? :) If we start (or already do) rely on permanent location we should fix the data for existing installations I think. It looks like Item CRUD operations were only moved to Koha::Object recently - could it be that we had places where it was not set before? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25612] New: When adding a file of records to a basket in Acquisitions - and a match is found, all values that had been set has been cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25612 Bug ID: 25612 Summary: When adding a file of records to a basket in Acquisitions - and a match is found, all values that had been set has been cleared Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When adding a file of records to a basket in Acquisitions - and a match is found, all values that had been set has been cleared. Steps: 1.Create a basket add titles from a file 2. Input quantity, fund, price for each title. 3. Hit Save- Koha gives an error if the titles match existing titles and removes all the values that had previously been entered. Can this not happen so that values can stay and the library can evaluate what is matching and change the matching rule? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #2 from Victor Grousset/tuxayo --- > 1. Go to Acquisitions and look at basket.pl Is and individual basket? "Home › Acquisitions › My Vendor › Basket My Basket (1) for My Vendor " Assuming yes. > 2. Open another tab and go to column configuration and try to hide some > columns like Quantity. > 3. See that the wrong columns are being hidden. Can't reproduce. I tried to hide and show most of the columns and nothing seemed wrong. (not sure if relevant, Quantity is hidden by default, no idea where the setting is) What is the role of opening another tab? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25571] "Bibliographic record not found" when click on Edit item table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25571
--- Comment #7 from Marjorie Barry-Vila ---
(In reply to Jonathan Druart from comment #6)
> 1. Do you see a JS error in the console?
>
> 2. Does the "Delete item" work?
>
> 3. The biblionumber value is retrieved in JS:
> 18 var biblionumber = $("input[name='biblionumber']").attr("value");
> from koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js
>
> Can you edit the source code of the page and search for
>
> (for me at line 866)
>
> You can also copy the whole source code and attach it here.
Hi,
Sorry to have bothered you for nothing!
Looking at the javascript codes in the intranetuserjs system preference, I saw
that the code that I had adapted from this
https://wiki.koha-community.org/wiki/JQuery_Library#Add_ability_to_search_authority_records_through_ID
for this page brought the problem.
This code worked very well before 19.05.
if (location.pathname.indexOf('cataloguing/addbooks.pl')>-1 ||
location.pathname.indexOf('cataloguing/additem.pl')>-1) {
$('#breadcrumbs').before('Rechercher
par numéro de notice: ');
$('#biblionumber').css('margin-left','200px');
}
I will modify it so that it no longer brings the error.
thanks again
Marjorie
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25611] New: Changing the vendor when creating the Basket does not keep that new vendor.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Bug ID: 25611 Summary: Changing the vendor when creating the Basket does not keep that new vendor. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When creating a basket, the vendor has the ability to be altered from the original chosen vendor. Currently: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor 4. This new vendor is not changed, it is still on the first vendor that was chosen. If the vendor can not be changed after initially choosing the vendor, the field should not be a dropdown, where it would appear that a change in vendor can be made. If the vendor can be changed during the creation of the basket, then this is not currently working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 didier changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #9 from didier --- (In reply to Marcel de Rooy from comment #7) > QA Comment: > When testing with LOC SRU, I am having two records producing the cryptic > error code '500' on the search title=vermeer with your patch. While without > your patch, I do not get this error. > I found some ZOOM error codes in the range 1 - 10018 or so; i can't > place the returned 500. > The dialog alert contains: > LIBRARY OF CONGRESS SRU record 19: 500 > LIBRARY OF CONGRESS SRU record 20: 500 > > Also please provide more feedback as to your statement: "This is used in > some other places of code, its a trick." > What kind of trick is this? Please give the other code locations? > > Changed status. I get LIBRARY OF CONGRESS SRU error without the patch, sometime. I captured the network traffic and it's an http server error 500, way before Koha. Maybe an overloaded server? As far I can tell there's no difference in requests to server in error and in no error cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 Aaron Sakovich changed: What|Removed |Added CC||asakov...@hmcpl.org --- Comment #7 from Aaron Sakovich --- The FIDO alliance has published a new website promoting FIDO2 for both consumers and providers. FIDO2 includes Yubikey and other key vendor support, as well as biometrics (facial scans and fingerprint), and personal PINs. https://loginwithfido.com/provider/ This is an established and well-supported standard, defined by both the FIDO Alliance and W3C's webauthn. Just dropping this here as I think it might be a better, all-encompassing approach to authentication in general, beyond just adding 2FA, and is way easier for the end-user with its multiple supported authenticators, not just a single vendor's hardware key. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #11 from Victor Grousset/tuxayo --- It works! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105181|0 |1 is obsolete|| --- Comment #10 from Victor Grousset/tuxayo --- Created attachment 105404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105404=edit Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25568] Allow multiple non-patron guarantors on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25568 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25610] Inconsistent display of 856$3 in OPAC between brief result and full record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25610 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #31 from David Gustafsson --- Created attachment 105403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105403=edit Bug 20551: Improve documentation and make compatible with more options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25592] Add Devinim to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592 --- Comment #8 from Devinim --- Thanks all ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25592] Add Devinim to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|tomasco...@gmail.com --- Comment #41 from Tomás Cohen Arazi --- I think this implementation is simple and covers the use case it is intended to. If we happen to have a task scheduler in a future, we could replace this and many other things we do with cron with it. I don't think the Koha::Logger follow-up should be pushed along with this, as we don't have a 'cron' entry in log4perl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 105401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105401=edit Bug 25245: (follow-up) Use Koha::Logger Update script to use Koha::Logger to capture method failures. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 105402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105402=edit Bug 25245: Add plugins_nightly.pl to the default cron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #30 from David Gustafsson --- (In reply to Jonathan Druart from comment #26) > 1. Doesn't it make sense to have this for authority records as well? > > 2. Why is --date mandatory? > > 3. POD does not tell that --deleted_only and --include_deleted is only > available for bibs > > 4. --id_list_file does not work with --deleted_only > > 5. Items are not exported, I guess that's expected but maybe we should have > it noted somewhere? 2) I think I just assumed it was required since included in the SQL-query, also before the patch. Did not realize that "SELECT * FROM biblio_metadata WHERE timestamp > ''" is equivalent with "SELECT * FROM biblio_metadata" if every timestamp entry has a value. So with that in mind an empty timestamp is ok, though the code is a real eyesore :) 3) I think it's already pretty clear since will produce an error message is --included_deleted or --deleted_only is used in conjunction with record_type other than 'bibs'. But I clarified this in the usage documentation for said options. 4) Did not work since have to add special case for @deleted_record_ids, fixed this. 5). There actually is a "deleteditems" table so I guess it would be possible to include these, even though it's hard to imagine why you would want to do this. Since the default is to include items perhaps it would be best to leave this as is and never include items for deleted biblios, or you will get more data than you probably want by default. It would also increase code complexity, probably with little benefit. If someone requests this it can be fixed later perhaps. Will point it out in the documentation that items are not included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 105400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105400=edit Bug 25245: Add plugins_nightly.pl cronjob script This script simply iterates through installed plugins that impliment a cronjob_nightly method and runs said method. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103775|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103774|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #31 from Marjorie Barry-Vila --- Created attachment 105399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105399=edit available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #30 from Marjorie Barry-Vila --- (In reply to Margaret from comment #29) > Hello, > It looks like this might be solved by the patch in bug 11677. Is that the > case? Hi, I tested it on 19.05.04 and i have same problem. Items not for loan (authorized value <>0) are still displayed in search results. I miss something? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #52 from Kyle M Hall --- Created attachment 105398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105398=edit Bug 15985: Remove Koha::Old::Checkout::claim_returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 105397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105397=edit Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 This patch removes version-specific packages from the debian/control file, which fixes a bug where koha-common can only be installed on the debian version that the package was built on Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105326|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 --- Comment #3 from Kyle M Hall --- > I checked an installation continually updates from 3.2 - and the > permanent_location is definitely empty there. I don't think we ever did a > global change for that to clean up existing data. That feels like a bug, would you agree? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 --- Comment #10 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #9) > > 0) Create some overdue rules with invalid branchcodes and categorycodes > > Does it means: > - Home › Tools › Overdue notice/status triggers > - create triggers > - check the overduerules table > - delete the branch > - check that the overduerules are still there Yes, that would work. I was lazy and just inserted them directly from the mysql cli :) > > 6) Editor should behave as it did before > > Does it means checking that "Home › Tools › Overdue notice/status triggers" > still works? Yes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #5 from Lucas Gass --- I will have a patch very soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25592] Add Devinim to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105289|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25592] Add Devinim to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25592] Add Devinim to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25592 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 105396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105396=edit Bug 25592: Add Devinim to about page This adds Devinim to the 'Contributing companis and institutions' section on Koha's about page. https://bugs.koha-community.org/show_bug.cgi?id=25592 Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 105395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105395=edit Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON This patch removes a problematic integer casting happening in TO_JSON. The original need for this cast (a DBD::mysql bug) is now fixed. We remove the cast as it is causing random failures. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail with select high values (i.e. casting gives wrong results) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105394|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 105394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105394=edit Bug 25513: Fix random failure from acquisitions_orders.t No idea if this is correct, but the tests pass without that condition See bug 17932 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 105393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105393=edit Bug 25513: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105317|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Summary|acquisitions_orders.t is|Integer casting in |failing randomly|Koha::Object->TO_JSON ||causes random test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] acquisitions_orders.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #25 from Tomás Cohen Arazi --- This bug is related to an original bug we reported to DBD::mysql RT: https://rt.cpan.org/Public/Bug/Display.html?id=119904 which is now migrated to: https://github.com/perl5-dbi/DBD-mysql/issues/212 The basic idea is that under some circumstances DBD::mysql output failed the looks_like_number test because of wrong flags set on the scalar variable. This bug is removing our workaround under the assumption current DBD::mysql versions on our supported OS are patched. This is the case in Stretch, Buster and Focal. But as the Github link suggests, there's still questions about this being really fixed for good. I'm adding a regression test based on Jonathan's DO NOT PUSH patch, so our CI can catch any issues now and in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 --- Comment #9 from Victor Grousset/tuxayo --- > 0) Create some overdue rules with invalid branchcodes and categorycodes Does it means: - Home › Tools › Overdue notice/status triggers - create triggers - check the overduerules table - delete the branch - check that the overduerules are still there > 6) Editor should behave as it did before Does it means checking that "Home › Tools › Overdue notice/status triggers" still works? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] acquisitions_orders.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25601] Error when unsetting default checkout, hold and return policy for a specific library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25601 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 105392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105392=edit Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" returnbranch has to pass an itemtype key when setting the rule (here setting it to unlimited for any item types) Test plan: 1. Go the "Circulation and fine rules" admin page 2. Set a rule for "Default checkout, hold and return policy" 3. Unset it 4. Select a library 5. Set a rule for "Default checkout, hold and return policy" 6. Unset it Display should be consistent with what you selected Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25601] Error when unsetting default checkout, hold and return policy for a specific library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25601 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25601] Error when unsetting default checkout, hold and return policy for a specific library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25601 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105372|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25601] Error when unsetting default checkout, hold and return policy for a specific library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25601 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25608] (regression) Inventory is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25608] (regression) Inventory is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 105391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105391=edit Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart Amended commit title. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25608] (regression) Inventory is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105377|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25608] (regression) Inventory is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #50 from Kyle M Hall --- Created attachment 105390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105390=edit Bug 6918: Add syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #43 from Tomás Cohen Arazi --- *** Bug 23223 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |DUPLICATE Status|ASSIGNED|RESOLVED --- Comment #16 from Tomás Cohen Arazi --- I didn't know about bug 23233, which got pushed in December. So you are right, Jonathan. The original bug got solved by two different reports: - bug 23640 - bug 23233 Closing as duplicate *** This bug has been marked as a duplicate of bug 23233 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 --- Comment #2 from Katrin Fischer --- (In reply to Kyle M Hall from comment #1) > (In reply to Jonathan Druart from comment #0) > > Initially the course reserves used "location", since bug 21446 it uses > > "permanent location". > > > > It leads to a display problem if permanent location is not set, but location > > is. > > > > Reported initially on bug 25444 comment 14. > > That leads to an interesting question; How is it possible to have permanent > location not set while location is? Koha::Item::store sets > permanent_location to location if it doesn't have one in nearly all > scenarios. I checked an installation continually updates from 3.2 - and the permanent_location is definitely empty there. I don't think we ever did a global change for that to clean up existing data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > Hum? What are we doing here? What is suppose to do this patch? We obsoleted the patch that dealt with caching as it overlapped with bug 23640, but forgot to extract from it the portion that makes SIP use the new syspref. > It adds a syspref that already exists... The new syspref does not yet exist, this patch adds the ability to have different behaviours for SIP than (say) SCO. It is just we missed the fact that the obsolete patch introduced the use of it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25610] New: Inconsistent display of 856$3 in OPAC between brief result and full record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25610 Bug ID: 25610 Summary: Inconsistent display of 856$3 in OPAC between brief result and full record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Currently, if a record has an 856$3, this will show in the brief results and not in the full results. It should be consistent between the two views. And what is the opinion that the $3 should show or should not? For decisions like these, it would be nice for the library to decide what is displayed and allow for changes to be made through the staff client vs XSLT stylesheets. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Attachment #105146|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 105389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105389=edit Bug 25552: Add missing Claims Returned option to MarkLostItemsAsReturned Marking an item as a return claim checks MarkLostItemsAsReturned to see if claim_returned is a value in MarkLostItemsAsReturned. However, this option was never added to MarkLostItemsAsReturned so an a return claim can never be automatically removed from the patron record, even if they wanted such behavior. Test Plan: 1) Apply this patch 2) Restart all the things 3) Note the new return claims option on MarkLostItemsAsReturned in the system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 --- Comment #1 from Kyle M Hall --- (In reply to Jonathan Druart from comment #0) > Initially the course reserves used "location", since bug 21446 it uses > "permanent location". > > It leads to a display problem if permanent location is not set, but location > is. > > Reported initially on bug 25444 comment 14. That leads to an interesting question; How is it possible to have permanent location not set while location is? Koha::Item::store sets permanent_location to location if it doesn't have one in nearly all scenarios. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What|Removed |Added Attachment #105387|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 105388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105388=edit Bug 18086: Add FK constraints for branchcode and categorycode The overduerules table has no foreign key constraints to any for the related tables. The columns for branchcode, categorycode, letter1, letter2, and letter3 should all be foreign keys. Test Plan: 0) Create some overdue rules with invalid branchcodes and categorycodes 1) Apply this patch 2) Restart all the things! 3) Run updatedatabase.pl 4) Note the invalid rules are deleted 5) Note Default codes are NULL now instead of empty strings 6) Editor should behave as it did before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > > Maps (Books) > > Fiction (Reference) > > Unchanged => WRONG Should be Unchanged (General Stacks) > > Riverside (Fairview) > > Unchanged (Fairview) > > I thought you said we would be dealing with this here: > > >Will be fixed by the follow-up I have just attached to bug 22630: > >Bug 22630: Display correct "in storage" value It was a problem with the homebranch only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25609] New: Use of permanent location instead of location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 Bug ID: 25609 Summary: Use of permanent location instead of location Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 25444, 21446 Initially the course reserves used "location", since bug 21446 it uses "permanent location". It leads to a display problem if permanent location is not set, but location is. Reported initially on bug 25444 comment 14. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 [Bug 25444] Course reserve settings are not saved on edit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Blocks||25609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 [Bug 25609] Use of permanent location instead of location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #25 from Jonathan Druart --- (In reply to Kyle M Hall from comment #20) > (In reply to Kyle M Hall from comment #18) > > (In reply to Jonathan Druart from comment #15) > > > The template is displaying permanent_location, is that correct? > > > In C4::CourseReserves we always play with items.location. > > > I have, in DB: > > > homebranch: RPL > > > holdingbranch: FPL > > > location: GEN > > > permanent_location: NULL > > > > > > I guess that's why I don't see the "location". > > > What is the expected behaviour here? > > > > That was a change made on bug 21446, which doesn't really justify the > > change. In my original code, everything operates on the 'location' column. > > The code has never touch permanent location. I would suggest reverting the > > behavior of 21446. > > I think we should also move this particular visual issue to a new bug. The > description of this bug is "Course reserve settings are not saved on edit", > and these patches fix that issue. This discussion relates to a visual bug > and seems out of scope for this bug report. Agreed, I opened bug 25609. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Jonathan Druart changed: What|Removed |Added Blocks||25609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 [Bug 25609] Use of permanent location instead of location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #23 from Jonathan Druart --- Created attachment 105385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105385=edit Bug 25444: Simplify the code using a loop In order to prevent typos or further regressions it is better (I think) to have this code into a loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #24 from Jonathan Druart --- Created attachment 105386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105386=edit Bug 25444: More minor improvements to simplified loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What|Removed |Added Attachment #105382|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 105387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105387=edit Bug 18086: Add FK constraints for branchcode and categorycode The overduerules table has no foreign key constraints to any for the related tables. The columns for branchcode, categorycode, letter1, letter2, and letter3 should all be foreign keys. Test Plan: 0) Create some overdue rules with invalid branchcodes and categorycodes 1) Apply this patch 2) Restart all the things! 3) Run updatedatabase.pl 4) Note the invalid rules are deleted 5) Note Default codes are NULL now instead of empty strings 6) Editor should behave as it did before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Attachment #105370|0 |1 is obsolete|| Attachment #105371|0 |1 is obsolete|| Attachment #105378|0 |1 is obsolete|| Attachment #105379|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 105383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105383=edit Bug 25444: Add unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25444] Course reserve settings are not saved on edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25444 --- Comment #22 from Jonathan Druart --- Created attachment 105384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105384=edit Bug 25444: Backup/restore course items fields correctly This patch makes the code set the *_storage fields when adding new fields to an existing course item. And reverts those fields correctly when removing the item from the course. If a new field is enabled on an existing course reserve, the storage field is not given a value, so when the item goes off reserve, the item field will always be updated to NULL. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/CourseReserves/CourseItems.t => FAIL: Tests fail, data is not reverted correctly 3. Apply this patch and repeat 2 => SUCCESS: Tests pass! Data is correctly reverted 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What|Removed |Added Attachment #105380|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 105382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105382=edit Bug 18086: Add FK constraints for branchcode and categorycode The overduerules table has no foreign key constraints to any for the related tables. The columns for branchcode, categorycode, letter1, letter2, and letter3 should all be foreign keys. Test Plan: 0) Create some overdue rules with invalid branchcodes and categorycodes 1) Apply this patch 2) Restart all the things! 3) Run updatedatabase.pl 4) Note the invalid rules are deleted 5) Note Default codes are NULL now instead of empty strings 6) Editor should behave as it did before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + Adjustments + Shipment cost (Column Tax. inc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
