[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

--- Comment #5 from didier  ---
Hi,

Other available checkbox options (withdrawn, lost and damaged) weren't in the
list in the original functionality. 

This patch only restore the previous behaviour, at least I hope so.

On the other hand not testing withdrawn, lost and so on doesn't seem to make
sense.

Regards
Didier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25378] Fix search on publication date in elasticsearch

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25378

anne-cecile.bor...@iepg.fr changed:

   What|Removed |Added

 CC||anne-cecile.bor...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25376] Use LANG authorised values for language facet

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25376

anne-cecile.bor...@iepg.fr changed:

   What|Removed |Added

 CC||anne-cecile.bor...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

anne-cecile.bor...@iepg.fr changed:

   What|Removed |Added

 CC||anne-cecile.bor...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

anne-cecile.bor...@iepg.fr changed:

   What|Removed |Added

 CC||anne-cecile.bor...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

--- Comment #10 from Victor Grousset/tuxayo  ---
(In reply to Katrin Fischer from comment #8)
> I am not sure what the best way to check would be

To have someone fall into the rabbit hole.
Soo, it's done ^^"
There shouldn't be missing file types and cases from union of the 4 sections of
the above report.
(search for "==" to find them)

The idea that lead to the greps was to
- not risk letting cases unnoticed
- don't have to learn non-trivial XML parsing and find how to run it on
type-mixed files

At the expense of letting noise (99.9% by font awesome and class="caret")
through.
And then check a lot of noise manually before sending the results above.


> but can we rule out that
> these tags are used as selectors in Javascript/jQuery and or CSS?

I guess that's to be expected to have a few selectors vulnerable to that.
Hmmm, would there be a way to search for them?
Here comes another rabbit hole! :o

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

--- Comment #10 from David Cook  ---
(In reply to Katrin Fischer from comment #8)
> Hm, using ExtractValue is slow, especially on big databases. As Magnus says
> in lot of use cases a quick access to 001 and 003 for matching is really
> helpful. We have started to map the biblioitems.ean to 001 for use in
> reports etc. as the 001 is so important to us. The column is indexed and not
> mapped by default in MARC21 - but it remains a bit of a workaround and I'd
> be happy about a real controlnumber column.

Hmm, ok, I think I'm convinced.

We're still living in a MARC centric world, so there's no reason not to add it.

And I doubt Koha will ever use the 001 instead of the 999$c, so even if it
isn't ideal from a MARC perspective, it does seem like a practical move. 

I know I hate using ExtractValue in databases in the hundreds of thousands or
millions of records O_O.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

--- Comment #9 from David Cook  ---
(In reply to Magnus Enger from comment #6)
> (In reply to David Cook from comment #5)
> > But in any case... I think there's a difference between the Koha 001 and
> > 003... and the original 001 and 003. 
> 
> Could you expand on this? I thought Koha left these alone, pretty much? 
> 

It does but it shouldn't 🤣.

> > However, how likely is it for source MARC data to have the 001 and 003
> > properly filled out? 
> 
> In the case of Sweden and Norway: very. And I bet the Germans do it properly
> too?

I'm sure that's true, but I suppose I'm thinking about all the libraries (like
all the ones I support) that don't use it.

But I suppose if it's unused that doesn't really create a problem. And if the
database columns were there, maybe we would more highly recommend them to use
the 001 and 003...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #8 from Katrin Fischer  ---
Ok, so with bug 25599 fixing neworderempty, we can now move this one on as
well. It applies cleanly on top and I have verified it works. Moving to blocked
until the dependency moves to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #96113|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 105430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105430&action=edit
Bug 24134: Add placeholder for 2 digit years to allow autogeneration of dates
in 008

This patch modifies the code for parsing MARC framework configurations
so that the placeholder "<>" translates to a two-year date.

To test, apply the patch and modify a framework to include placeholders.
For example, in MARC21:

 - Administration -> MARC structure -> 952 -> Edit subfields -> d
 - Expand "Advanced constraints" and add a default value:
   <> <> <> <> <>
 - Save your configuration and go to Cataloging.
 - Go to the add/edit items page for a record which uses the framework
   you edited.
 - In the "Add item" form, in the "Date aquired" field, you should see
   the correct values. For example: '2019 19 12 03 Leonard'

Perform the same test when adding an item during the Acquisitions
process (depending on your AcqCreateItem setting).

Note that acqui/neworderempty.pl has been modified because the
placeholder-replacement code is repeated there, but I couldn't discover
how to test it (if it is used at all?)

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #55 from David Cook  ---
(In reply to Katrin Fischer from comment #54)
> I'd still love to see this fixed.

Me too. It's on my TODO list 😅.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||24134


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134
[Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates
in 008
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||25599


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599
[Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used
creating new record (UseACQFrameworkForBiblioRecords)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105350|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 105429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105429&action=edit
Bug 25599: Fix default value placeholders for UseACQFrameworkForBiblioRecords

The feature was there but a condition disabled it.

Test plan:
- modify the default value for 008@ or another subfield in the ACQ framework
using one or more of the placeholders above
- activate UseACQFrameworkForBiblioRecords
- create a basket
- create an order from a new record
- verify the values have been replaced

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105354|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 105428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105428&action=edit
Bug 23276: Do not display tag if pref TagsEnabled is off

If the pref TagsEnabled is off we should not display the tags at the
OPAC.
There is a message to tell that tags system is disabled, but the tags
are displayed.

We should redirect to 404 like we do in opac-topissues.pl and
opac-suggestions.pl.

Test plan:
- Turn TagsEnabled on
- Add some tags
- Turn TagsEnabled off
- Hit /cgi-bin/koha/opac-tags.pl
=> Without this patch you see a warning messaging saying that the tag
system is disabled, but the tags are displayed
=> With this patch you get a 404 redirect

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105358|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 105427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105427&action=edit
Bug 25492: Your Account Menu button does nothing on mobile devices

This patch removes some redundant code from the OPAC JavaScript which
was causing problems with the show/hide action on two controls which are
shown only at narrower browser widths: The "Your account" menu shown
when the user is on a user-related page, and the "Refine your search"
menu shown on the search results page.

To test, apply the patch and go to the OPAC. Narrow your browser width
to below 768 pixels.

 - Perform a search.
 - On the search results page you should see a "Refine your search"
   link at the top of the results. Clicking it should expand and
   collapse the facets menu.
 - Log in to the OPAC.
 - On the "Your summary" page there should be a "Your account menu" link
   at the top of the main part of the page. Clicking it should expand
   and collapse the account menu.
 - Verify that these menus display correctly when you widen and narrow
   the browser window.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167

--- Comment #4 from Katrin Fischer  ---
I am looking at the code, but not understanding it well enough to see if this
is the right fix. I wonder why we need no extra treatment for the other
available checkbox options (withdrawn, lost and damaged). 

Leaving this for someone more familiar with inventory code in the QA team.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Katrin Fischer  ---
This includes the fixes I asked for, but is otherwise exactly the same as the
patch that didn't work for me and it still doesn't :(

I believe the test plan to be incomplete - adding a new option alone is not
enough, it should work as well.

What I've done:
- checked the new option in the pref
- Marked an item as claim returned
- Lost status was set, but item remains on the account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15985] Include checkout library in fines

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #53 from Katrin Fischer  ---
Hi Kyle, 

I am sorry, but this doesn't quite work as expected. Possibly the table
structure changed a bit since this was originally written.

1) Total columns at the end of table are off by at least one column:

Outstanding credits could be applied:   
Total due if credit applied:

2) Hiding columns in column configuration doesn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25611] Changing the vendor when creating the Basket does not keep that new vendor.

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25612] When adding a file of records to a basket in Acquisitions - and a match is found, all values that had been set has been cleared

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25612

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #1 from Katrin Fischer  ---
It looks like a bug to me - you have to enter the values before saving... and
are then forced to reenter. Changing Importance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

--- Comment #8 from Katrin Fischer  ---
I am not sure what the best way to check would be, but can we rule out that
these tags are used as selectors in Javascript/jQuery and or CSS?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434

--- Comment #4 from Katrin Fischer  ---
I am not sure how these would look in a pull down. Jonathan's suggestion looks
good at first clance. This is set to NEW still - something missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105421|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 105426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105426&action=edit
Bug 25557: Correct basket.pl column config

This patch corrects the column configuration tool for basket.pl
TO TEST:
1. Go to Acquisitions and look at basket.pl
2. Open another tab and go to column configuration and try to hide some columns
like Quantity.
3. See that the wrong columns are being hidden.
4. Apply patch
5. Trying hiding each column in the table and make sure the correct one is
being hidden.
6. Rejoice!

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

--- Comment #8 from Katrin Fischer  ---
Created attachment 105425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105425&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

--- Comment #8 from Katrin Fischer  ---
Hm, using ExtractValue is slow, especially on big databases. As Magnus says in
lot of use cases a quick access to 001 and 003 for matching is really helpful.
We have started to map the biblioitems.ean to 001 for use in reports etc. as
the 001 is so important to us. The column is indexed and not mapped by default
in MARC21 - but it remains a bit of a workaround and I'd be happy about a real
controlnumber column.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25609] Use of permanent location instead of location

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609

--- Comment #6 from Katrin Fischer  ---
I have dug a bit deeper:

$DBversion = '3.01.00.043';
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$dbh->do('ALTER TABLE items ADD COLUMN permanent_location VARCHAR(80)
DEFAULT NULL AFTER location');
$dbh->do('UPDATE items SET permanent_location = location');

So if a database set up with a later version shows empty permanent_location
entries, while location is set, this must have happened somewhere after this
updatedatabase entry. Maybe by not setting the permanent_location correctly in
import, editing, adding...?

So maybe we need to make sure that it's now handled correctly everywhere before
we try to get to a clean state again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

--- Comment #15 from Victor Grousset/tuxayo  ---
Thanks!

Should the following problem be fixed?

> "Email" and "print" aren't saved when ticked, they disappear after saving.

It seems the lasted patch only fixed the compilation error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo  ---
> I found templates, includes and XSLT by using 'git grep ‘’ 
> koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘’ 
> koha-tmpl/opac-tmpl/bootstrap/en/

Case not caugh by the grep:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
298:[% IF (
ISSUE.onsite_checkout ) %] (On-site checkout)[%
END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25609] Use of permanent location instead of location

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609

--- Comment #5 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #4)
> A bug in the installation or a bug we should have a patch for? :)
> If we start (or already do) rely on permanent location we should fix the
> data for existing installations I think.
> 
> It looks like Item CRUD operations were only moved to Koha::Object recently
> - could it be that we had places where it was not set before?

I presume the functionality moved intact. The permanent location is primarily
used by the Cart to Shelf feature, and UpdateItemLocationOnCheckin can use it
as well.

It seems to me that it certainly would not hurt anything to have a database
update to populate permanent_location from location.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

Hans PÃ¥lsson  changed:

   What|Removed |Added

 CC||hans.pals...@hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

--- Comment #14 from Kyle M Hall  ---
(In reply to Victor Grousset/tuxayo from comment #12)
> BTW, how does one makes "phone" and "SMS" tickable?

You can set the SMS::Send driver syspref to 'Email', and enable the talking
tech itiva syspref iirc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105388|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 105424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105424&action=edit
Bug 18086: Add FK constraints for branchcode and categorycode

The overduerules table has no foreign key constraints to any for the
related tables. The columns for branchcode, categorycode, letter1,
letter2, and letter3 should all be foreign keys.

Test Plan:
0) Create some overdue rules with invalid branchcodes and categorycodes
1) Apply this patch
2) Restart all the things!
3) Run updatedatabase.pl
4) Note the invalid rules are deleted
5) Note Default codes are NULL now instead of empty strings
6) Editor should behave as it did before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Nick Clemens  changed:

   What|Removed |Added

 Attachment #105418|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 105422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105422&action=edit
Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0

There was an error in the precedent code, in 12hr format, 12PM is
actually 00:00

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

--- Comment #10 from Nick Clemens  ---
Created attachment 105423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105423&action=edit
Bug 25617: (QA follow-up) Add responses to tests

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Victor Grousset/tuxayo  ---
(In reply to Lucas Gass from comment #5)
> No, I am referring to the Configure columns tool at Koha Admin > Configure
> columns.
> 
> /cgi-bin/koha/admin/columns_settings.pl
> 
> https://snipboard.io/Hk0N7V.jpg

Hooo


> 3. See that the wrong columns are being hidden.

Indeed, nonsense can happen!


> 6. Rejoice!

It works! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #105235|0   |1
is obsolete||

--- Comment #6 from Victor Grousset/tuxayo  ---
Created attachment 105421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105421&action=edit
Bug 25557: Correct basket.pl column config

This patch corrects the column configuration tool for basket.pl
TO TEST:
1. Go to Acquisitions and look at basket.pl
2. Open another tab and go to column configuration and try to hide some columns
like Quantity.
3. See that the wrong columns are being hidden.
4. Apply patch
5. Trying hiding each column in the table and make sure the correct one is
being hidden.
6. Rejoice!

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Deb  changed:

   What|Removed |Added

 CC||dstep...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25619] New: Add ability to adjust expiration date for waiting holds

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619

Bug ID: 25619
   Summary: Add ability to adjust expiration date for waiting
holds
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There are times when an item that is waiting for pickup needs to have the
expiration date extended. This would give staff the ability to modify one by
one, as needed, the reserves.expirationdate for a given item awaiting pickup.

If possible, this should be a separate permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25487] Bulk Edit Hold Tool

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25487

Kelly McElligott  changed:

   What|Removed |Added

Summary|Hold Tool   |Bulk Edit Hold Tool
 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #10 from Abbey Holt  ---
This sounds really slick. I'm looking forward to testing it! I tried creating a
sandbox with this bug number to see what the development looks like in action,
but the staff client won't load for me right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Holly  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||h...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105419|0   |1
is obsolete||

--- Comment #17 from ByWater Sandboxes  ---
Created attachment 105420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105420&action=edit
Bug 25322: fix for don't default "relationship" dropdown to father

When you create a patron's guarantor on cgi-bin/koha/members/memberentry.pl but
don't select the relationship from a dropdown, the relationship defaults to
first default value, which in this case is father that may or may not be
correct as that is not a conscious choice from the user.
The solution is to make the "Relationship" field mandatory, starting with an
empty option but not allowing the user to save empty, so choice will be
conscious.

To reproduce:
1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
3) Observe that relationship is set as "father".
4) Apply the patch.
5) Repeat steps 1 and 2.
6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

Mentored-by: Andrew Nugged 

Signed-off-by: Holly Cooper 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #54 from Katrin Fischer  ---
I'd still love to see this fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

--- Comment #16 from Peter Vashchuk  ---
Created attachment 105419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105419&action=edit
Bug 25322: fix for don't default "relationship" dropdown to father

When you create a patron's guarantor on cgi-bin/koha/members/memberentry.pl but
don't select the relationship from a dropdown, the relationship defaults to
first default value, which in this case is father that may or may not be
correct as that is not a conscious choice from the user.
The solution is to make the "Relationship" field mandatory, starting with an
empty option but not allowing the user to save empty, so choice will be
conscious.

To reproduce:
1) Create a new patron who is assumed to have a guarantor or modify the
existing one.
2) Under "Guarantor Information" click on "Search to add" button. After
performing the search, select a user to act as guarantor. Don't use the
dropdown menu to select a relationship. Save your changes.
3) Observe that relationship is set as "father".
4) Apply the patch.
5) Repeat steps 1 and 2.
6) Observe that it doesn't allow you to save the form until you pick a
relationship type.

Mentored-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Peter Vashchuk  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

--- Comment #4 from Jonathan Druart  
---
dev install was not working.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |critical

--- Comment #8 from Jonathan Druart  
---
Upping severity, not sure how big this is for TimeFormat=12hr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #105417|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 105418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105418&action=edit
Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0

There was an error in the precedent code, in 12hr format, 12PM is
actually 00:00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #105412|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 105417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105417&action=edit
Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0

There was an error in the precedent code, in 12hr format, 12PM is
actually 00:00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #59 from Mason James  ---
Created attachment 105416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105416&action=edit
Bug 17084: add ilibcpan-meta-perl (>= 2.150010-1) control.in file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #58 from Victor Grousset/tuxayo  ---
Thanks for the clarifications, I'll double check.


conflict in debian/control

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|25617   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617
[Bug 25617] Error on about page when TimeFormat preference is set to 12hr
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25617


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617
[Bug 25617] Error on about page when TimeFormat preference is set to 12hr
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
   Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|18674   |25133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674
[Bug 18674] Show timezone for Perl and MySQL on the About Koha page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133
[Bug 25133] Specify Due date changes from PM to AM if library has their
TimeFormat set to 12hr
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

--- Comment #5 from Lucas Gass  ---
> Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png

Victor, 

No, I am referring to the Configure columns tool at Koha Admin > Configure
columns.

/cgi-bin/koha/admin/columns_settings.pl

https://snipboard.io/Hk0N7V.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #105414|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 105415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105415&action=edit
Bug 25618: Fix wrong package install path for misc dir

root@koha-debian9:/# koha-z3950-responder --start d9
[] Starting Z39.50/SRU daemon for d9:Can't open perl script
"/usr/share/koha/bin/z3950_responder.pl/z3950_responder.pl": Not a directory
 failed!

Test plan:
On a dev install, copy the debian script and run it
Same on a package install

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

--- Comment #4 from Jonathan Druart  
---
Maybe something else actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

--- Comment #5 from Jonathan Druart  
---
It's only happening when hour=12. I am working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi  ---
What OS? I cannot reproduce on Stretch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

--- Comment #2 from Jonathan Druart  
---
Template process failed: undef error - Validation failed for type named Hour
declared in package DateTime::Types
(/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Types.pm) at line 101 in sub
named (eval) with valu
e 24
Trace begun at Specio::Exception->new line 57  
   
  
Specio::Exception::throw('Specio::Exception', 'message', 'Validation failed for
type named Hour declared in package DateTime::Types
(/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Types.pm) at line 101 in sub nam
ed (eval) with value 24', 'type',
'Specio::Constraint::Simple=HASH(0x5602f411a6f8)', 'value', 24) called at (eval
217) line 126  
DateTime::_check_new_params('month', 05, 'day', 28, 'second', 0, 'year', 2020,
'minute', 49, 'hour', 24, 'time_zone', 'floating') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime.pm line 165
DateTime::new('DateTime', 'month', 05, 'day', 28, 'second', 0, 'year', 2020,
'minute', 49, 'hour', 24, 'time_zone', 'floating') called at
/kohadevbox/koha/Koha/DateUtils.pm line 200  
Koha::DateUtils::dt_from_string('2020-05-28 12:49 PM', 'iso') called at
/kohadevbox/koha/Koha/Template/Plugin/KohaDates.pm line 34  
Koha::Template::Plugin::KohaDates::filter('Koha::Template::Plugin::KohaDates=HASH(0x560309b36c28)',
'2020-05-28 12:49 PM', 'ARRAY(0x5603099fe908)', 'HASH(0x5603098a3928)') called
at /usr/lib/x86_64-linux-gnu/per
l5/5.24/Template/Plugin/Filter.pm line 82   
Template::Plugin::Filter::__ANON__('2020-05-28 12:49 PM') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt line 127  
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
line 18 
Template::Provider::__ANON__('Template::Context=HASH(0x56030151f128)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line 163   
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x560309b36880)',
'Template::Context=HASH(0x56030151f128)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x56030151f128)',
'Template::Document=HASH(0x560309b36880)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 91  
Template::Service::process('Template::Service=HASH(0x5602fe764610)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt',
'HASH(0x5603097ff4b0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Te
mplate.pm line 66   
Template::process('Template=HASH(0x560301521550)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt',
'HASH(0x5603097ff4b0)', 'SCALAR(0x5602f7c2a138)') called at
/kohadevbox/koha/C4/Templates.p
m line 122

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 105414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105414&action=edit
Bug 25618: Fix wrong package install path for misc dir

root@koha-debian9:/# koha-z3950-responder --start d9
[] Starting Z39.50/SRU daemon for d9:Can't open perl script
"/usr/share/koha/bin/z3950_responder.pl/z3950_responder.pl": Not a directory
 failed!

Test plan:
On a dev install, copy the debian script and run it
Same on a package install

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #105413|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||18674
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674
[Bug 18674] Show timezone for Perl and MySQL on the About Koha page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25617


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617
[Bug 25617] Error on about page when TimeFormat preference is set to 12hr
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25613] Broken workflow on CAS login with wrong permissions

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25613

--- Comment #1 from Tomás Cohen Arazi  ---
The only solution I find, is providing a message with a logout from CAS
button/option:
- In case the user is not a valid Koha user 'The CAS user is not a valid Koha
user, please logout if you want to try another user'
- In case the user does not have the right permissions 'The CAS user doesn't
have the required permissions, please logout if you want to try another user'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10205] koha-create error handling

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25618


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618
[Bug 25618] Upgrading Koha to packages made of latest master version breaks
Z3950
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_05_candidate
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||13937
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

--- Comment #1 from Jonathan Druart  
---
Created attachment 105413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105413&action=edit
Bug 25618: Fix wrong package install path for misc dir

root@koha-debian9:/# koha-z3950-responder --start d9
[] Starting Z39.50/SRU daemon for d9:Can't open perl script
"/usr/share/koha/bin/z3950_responder.pl/z3950_responder.pl": Not a directory
 failed!

Test plan:
On a dev install, copy the debian script and run it
Same on a package install

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25618] New: Upgrading Koha to packages made of latest master version breaks Z3950

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25618

Bug ID: 25618
   Summary: Upgrading Koha to packages made of latest master
version breaks Z3950
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

When upgrading Koha a package made out of latest master version Z3950 daemon
doesn't work anymore, the error message in koha-common service log is the
following:

> Can't open perl script "/usr/share/koha/lib/misc/z3950_responder.pl": No such 
> file or

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

--- Comment #1 from Owen Leonard  ---
Created attachment 105412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105412&action=edit
Bug 25617: Pass 24hr to output_pref

This patch changes the date formatting function used to create the
current_date_and_time variable by adding '24hr' as the timeformat
parameter. This avoids an error when the TimeFormat preference is set to
12hr.

To test, apply the patch and go to the "About" page in the staff
interface. It should work correctly. The "Date and time" information
under the "Server information" tab should be correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25617] New: Error on about page when TimeFormat preference is set to 12hr

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617

Bug ID: 25617
   Summary: Error on about page when TimeFormat preference is set
to 12hr
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: rel_20_05_candidate
  Severity: major
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If the  TimeFormat system preference is set to 12-hour format the about page
explodes with an error, "Template process failed: undef error - Validation
failed for type named Hour declared in package DateTime::Types
(/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Types.pm) at line 101 in sub
named (eval) with value 24"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197

--- Comment #11 from David Gustafsson  ---
Created new issue for this (Bug 25616).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616

David Gustafsson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616

--- Comment #2 from David Gustafsson  ---
Regarding how to test. I have tested the fix in bulkmarimport.pl but regarding
the others I am not all that familiar with Koha from a user-perspective and it
would take me too long to write an how to test for all of them. One thing that
could go wrong is that operator precedence for AND/OR is not what you expect
and parentheses needs to be used for queries mixing them both. I tried to
review all replacements and i THINK that AND/OR is not mixed in those places so
should be ok and no extra precedence tweaking needed. Also think this will fix
more than it could potentially break, but help in writing an how to test would
otherwise be appreciated if this feels to risky to merge without one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616

--- Comment #1 from David Gustafsson  ---
Created attachment 105411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105411&action=edit
Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch

Uppercase occurances of all (hopefully) lowercase "and"
used in ElasticSearch Query String Query contexts

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25616] New: Uppercase hard coded lower case boolean operators for Elasticsearch

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616

Bug ID: 25616
   Summary: Uppercase hard coded lower case boolean operators for
Elasticsearch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com

Since valid boolean operators in the Elasticsearch mini language for Query
String Queries needs to be upper case, there some occurrences of queries in
Koha left that needs changing. I think I found most of them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25615] Empty select in "Holds to pull" filters

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25615] Empty select in "Holds to pull" filters

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25615

Nick Clemens  changed:

   What|Removed |Added

 Attachment #105407|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 105410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105410&action=edit
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull"

On the "Holds to pull" view there are filters that are built on the
value of the cells.
Bug 22536 improved the ergonomic by adding a ul list, but the filters
are now broken, the ul and li tags are retrieved and put in the filter
list.

The idea of this patch is to remove the HTML tags and skip if the value
is then empty.

Test plan:
Place a hold on an item
Go to Home › Circulation › Holds to pull
Open the "libraries" filter
=> Without this patch you see empty entries
=> With this patch the filter contain only the libraries

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #57 from Mason James  ---
(In reply to Victor Grousset/tuxayo from comment #55)
> How should this be signed off? Like double checking that the changes here
> match the changes on bug 25591?
> 
> So, the removal of perl-modules, perl-modules-5.XX, perl

yes, perl-modules and perl-modules-5.XX will be removed, and libperl-5.XX too

> There are also changes from other recent patches. Like
> - libpdf-api2-simple-perl
> - libtest-harness-perl
> - tinymce

yes, this is expected and correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23322] Elasticsearch - Record matching fails when multiple keys exist

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #10 from David Gustafsson  ---
*** Bug 19197 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197

David Gustafsson  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE

--- Comment #10 from David Gustafsson  ---


*** This bug has been marked as a duplicate of bug 23322 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197

David Gustafsson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04

2020-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591

Mason James  changed:

   What|Removed |Added

 Attachment #105408|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >