[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #55 from David Cook  ---
At Tomas's request, I've attached a patch I've done for a local customization
to use RabbitMQ. 

It's very simple. I don't have any time-based "task scheduling" per se. It's
just FIFO. The mq_scheduler.pl script is problematic in a number of ways, but
it's just an experiment. 

Early testing is good. You submit a form on the Koha web UI, it sends a message
to RabbitMQ, the mq_scheduler.pl receives the message from RabbitMQ, the
mq_scheduler.pl loads a module and runs some code (which in this case also
sends an email), and then it marks the message complete/acknowledged in
RabbitMQ. 

This patch does require a person to run "add_vhost" and "set_permissions"
manually using rabbitmqctl on the host running RabbitMQ. However, as I'm
defining the queues in koha-conf.xml, the root vhost could be used, and the
queues could be prefixed with __DB_NAME__. At this point, I'm fairly
indifferent to the method. I like vhosts for the logical separation of the
messages, but if it's not practical for a package installation, then maybe we
should just use the prefixed queues. 

The systemd service is *very* package installation friendly. We'd need to
update the debian/* files accordingly, but it would be so easy. I haven't done
that yet, as I'm testing on non-package installations first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #54 from David Cook  ---
Created attachment 105543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105543=edit
[Local Prosentient] Create experimental support for RabbitMQ-based background
tasks

This patch includes a koha-mq-scheduler service which creates
a mq_scheduler.pl daemon, which listens to RabbitMQ queues.

This patch also includes an audit-authorities.pl web script,
which sends a message to RabbitMQ.

The mq_scheduler.pl daemon loads Koha::Prosentient::MQ::AuditAuthorities.pm,
and runs a class method which does a background task to audit
bib-auth linkages.

Koha community work:
https://bugs.koha-community.org/bugzilla3//show_bug.cgi?id=22417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

David Cook  changed:

   What|Removed |Added

 Attachment #105542|1   |0
   is patch||
 Attachment #105542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #53 from David Cook  ---
Created attachment 105542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105542=edit
[Prosentient] Create experimental support for RabbitMQ-based background tasks

This patch includes a koha-mq-scheduler service which creates
a mq_scheduler.pl daemon, which listens to RabbitMQ queues.

This patch also includes an audit-authorities.pl web script,
which sends a message to RabbitMQ.

The mq_scheduler.pl daemon loads Koha::Prosentient::MQ::AuditAuthorities.pm,
and runs a class method which does a background task to audit
bib-auth linkages.

Koha community work:
https://bugs.koha-community.org/bugzilla3//show_bug.cgi?id=22417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #18 from Agustín Moyano  ---
(In reply to Abbey Holt from comment #16)
> This is great! There is one area where my matching preferences would not
> stick when I created a profile. If I select "No" under "Check for embedded
> item record data" and click "Add profile", No switches back to Yes. My
> selection for "how to process items" is remembered. It is just the yes-no
> button that isn't being saved.

Hi Abbey, thanks so much for pointing that out.. could you please try again?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #105540|0   |1
is obsolete||

--- Comment #17 from Agustín Moyano  ---
Created attachment 105541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105541=edit
Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages

This patch adds the logic and the needed UI elements to be able to pre-load an
import profile. It also displays which profile was used to stage an import in
staged import manager.

To test:
1. Apply all patches
2. Updatedatabase
3. Go to Stage MARC records for Import tool in admin, and upload a file with
MARC records.
CHECK => after uploading, there is a fieldset with the legend “Profile
settings”
  => inside the fieldset there is a select labeled “Pre fill values
with profile”. The only value it has is “Do not use profile”.

4. Change some settings, and set “profile 1” as profile name and click on “Add
profile”
SUCCESS => The select now has the new profile selected

5. Change profile select to “Do not use profile”
SUCCESS => Default values are now displayed in the form

6. Reload the page and upload the file again
SUCCESS => the select still has the profile recently added

7. Select the profile, change some parameter in the form and set the profile
name to “profile 2”, and click add profile
SUCCESS => there are two profiles now, and if you toggle between them, the
parameter changes

8. Select profile 1, change one parameter and click on update profile
SUCCESS => if you toggle that profile with the other, the new parameter of the
value is shown when you select profile 1

9. Select profile 2, change some parameter and click Add profile (leaving the
name as profile 2)
SUCCESS => the page complains there is another profile with the same name, and
asks if you want to replace it.

10. Click on accept
SUCCESS => profile 2 now has the new value in the parameter

11. Select profile 2 and change the name to profile 1
SUCCESS => the page complains there is another profile with that name, and asks
if you want to replace it

12. Click on accept
SUCCESS => in profile select there is only one profile called profile 1 that
has the values of profile 2

13. Select profile 1 and click remove profile
SUCCESS => there is no profile in profile select.

14. Create a profile and click on “Stage for import”
15. Go to Staged MARC management page
SUCCESS => Improt should have the name of the profile in profile column, and
when you click on the file name, there should be the name of the profile in the
details.

16. prove t/db_dependent/ImportBatch.t
t/db_dependent/api/v1/import_batch_profiles.t
17. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671

--- Comment #1 from David Cook  ---
It would also be interesting to use "koha-plugin-install 
"

That could make plugin management even easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25672

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side and enable server-side plugin management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23191

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25672] New: Administrators should be able to disable client-side and enable server-side plugin management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

Bug ID: 25672
   Summary: Administrators should be able to disable client-side
and enable server-side plugin management
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Administrators should be able to prevent Koha web users from
uploading/installing/uninstalling Koha plugins, and instead allow
uploading/installing/uninstalling Koha plugins on the server-side from the CLI.

This would allow Koha web users to "use" plugins, but it would require plugins
to be vetted and managed by a server sysadmin. 

This should improve stability and maintainability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25672

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side and enable server-side plugin management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25671

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25671] New: Administrators should be able to add/upload plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671

Bug ID: 25671
   Summary: Administrators should be able to add/upload plugins
from the command line
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

I want to create the following:

koha-plugin-install  

You'd have 1 KPZ package, and you'd be able to add/upload/install it into an
instance from the command line.

This would allow a sysadmin to easily automate the installation of plugins
across Koha instances from the server side.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23191

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191

--- Comment #25 from David Cook  ---
(In reply to Martin Renvoize from comment #23)
> (In reply to David Cook from comment #22)
> > I like the sound of this but the implementation seems very different to what
> > I would have expected.
> > 
> > I thought it would be something like "misc/devel/install_plugin.pl
> > ".
> 
> Feel free to add such this additional functionality in a new bug ;)

I'm thinking "koha-plugin-install  ". Then if you wanted all
your instances to be running one plugin, it would be trivial...

Ok I'll open a bug report now but probably won't work on for a while (although
you never know :O)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660

--- Comment #3 from David Cook  ---
(In reply to Caroline Cyr La Rose from comment #2)
> Hi David,
> 
> No I'm not using docker nor devbox.
> 
> Caroline

Ok. That's what you meant by "vintage" git install hehe. Well, I primarily use
a "vintage" git install as well.

I haven't tested master recently with that particular install. I'll try to
remember to take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #52 from David Cook  ---
Oh and in the JSON message I specify "class" and "method" (much like the
Koha::Plugin::Handler). It also provides "args". So it loads the "class", and
runs the "method" with the "args". It's pretty simple. 

If I were to record results, I'd probably have a "result_callback_method" or
something too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22417] Delegate background jobs execution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #51 from David Cook  ---
(In reply to David Cook from comment #50)
> We use RabbitMQ for some other projects, and I think I'm going to start
> looking at using it with some of our local Koha extensions. 
> 

With my own code, I've added a local tool to tools-home.pl, and I have that add
a JSON message to RabbitMQ with Net::Stomp.

I have a background worker using Net::Stomp to get the JSON message, do the
long-running task, and then email a user with the result. 

It does the bare minimum of what I need it to do, and I'll be looking to roll
it out soon as an experimental feature to select Koha instances.

Both the web app and daemon worker rely on configuration in koha-conf.xml to
know not only the RabbitMQ server address, username, and password, but also
what queues to use. (I rather use a YAML file for this, but koha-conf.xml
already has caching support, so it's so easy to use.)

Things to think about:
- Installing RabbitMQ and plugins are easy, but you need enable the stomp
plugin and create virtual hosts as the RabbitMQ administrator... which is only
possible if they're running on the same machine
- Technically, all Koha instances could use the root vhost, and we could prefix
the queue names. (I'm going to be running into this issue when I roll out my
experimental work more widely.)
- Flow control for the background worker. Should it do 1 task at a time, or
should it fork off workers? If it forks workers, you can easily exhaust your
system's resources if you don't have any artificial limits, but you can also do
more work. (Alternatively, we could create the facility to run X background
workers, so sysadmins would determine the limits.)
- How best to store the results of background tasks? Should it be in 1 central
store, or should it be more task specific?

Most of those are sysadmin type questions except for the last one. For the last
one, I'm thinking task specific might be best, especially when it comes to
background tasks done by Koha Plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191

--- Comment #24 from David Cook  ---
(In reply to Martin Renvoize from comment #23)
> (In reply to David Cook from comment #22)
> > I like the sound of this but the implementation seems very different to what
> > I would have expected.
> > 
> > I thought it would be something like "misc/devel/install_plugin.pl
> > ".
> 
> Feel free to add such this additional functionality in a new bug ;)

It's on my mind! Heh. I just have so much going on at the moment. I haven't
even been working on plugins, as I've just needed the free time to decompress.

(I'm just about to roll out some experimental work with RabbitMQ to select
production instances, so I might have more to say on Bug 22417 at least.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #16 from Abbey Holt  ---
This is great! There is one area where my matching preferences would not stick
when I created a profile. If I select "No" under "Check for embedded item
record data" and click "Add profile", No switches back to Yes. My selection for
"how to process items" is remembered. It is just the yes-no button that isn't
being saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #15 from Agustín Moyano  ---
Created attachment 105540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105540=edit
Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages

This patch adds the logic and the needed UI elements to be able to pre-load an
import profile. It also displays which profile was used to stage an import in
staged import manager.

To test:
1. Apply all patches
2. Updatedatabase
3. Go to Stage MARC records for Import tool in admin, and upload a file with
MARC records.
CHECK => after uploading, there is a fieldset with the legend “Profile
settings”
  => inside the fieldset there is a select labeled “Pre fill values
with profile”. The only value it has is “Do not use profile”.

4. Change some settings, and set “profile 1” as profile name and click on “Add
profile”
SUCCESS => The select now has the new profile selected

5. Change profile select to “Do not use profile”
SUCCESS => Default values are now displayed in the form

6. Reload the page and upload the file again
SUCCESS => the select still has the profile recently added

7. Select the profile, change some parameter in the form and set the profile
name to “profile 2”, and click add profile
SUCCESS => there are two profiles now, and if you toggle between them, the
parameter changes

8. Select profile 1, change one parameter and click on update profile
SUCCESS => if you toggle that profile with the other, the new parameter of the
value is shown when you select profile 1

9. Select profile 2, change some parameter and click Add profile (leaving the
name as profile 2)
SUCCESS => the page complains there is another profile with the same name, and
asks if you want to replace it.

10. Click on accept
SUCCESS => profile 2 now has the new value in the parameter

11. Select profile 2 and change the name to profile 1
SUCCESS => the page complains there is another profile with that name, and asks
if you want to replace it

12. Click on accept
SUCCESS => in profile select there is only one profile called profile 1 that
has the values of profile 2

13. Select profile 1 and click remove profile
SUCCESS => there is no profile in profile select.

14. Create a profile and click on “Stage for import”
15. Go to Staged MARC management page
SUCCESS => Improt should have the name of the profile in profile column, and
when you click on the file name, there should be the name of the profile in the
details.

16. prove t/db_dependent/ImportBatch.t
t/db_dependent/api/v1/import_batch_profiles.t
17. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #13 from Agustín Moyano  ---
Created attachment 105538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105538=edit
Bug 23019: Add ImportBatchesProfile schema and set is_boolean to parse_items
column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #14 from Agustín Moyano  ---
Created attachment 105539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105539=edit
Bug 23019: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #104972|0   |1
is obsolete||
 Attachment #104973|0   |1
is obsolete||
 Attachment #104974|0   |1
is obsolete||
 Attachment #104975|0   |1
is obsolete||
 Attachment #104976|0   |1
is obsolete||

--- Comment #11 from Agustín Moyano  ---
Created attachment 105536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105536=edit
Bug 23019: Update database structure and add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #12 from Agustín Moyano  ---
Created attachment 105537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105537=edit
Bug 23019: Add koha_object_class and koha_objects_class methods to
ImportBatch.pm schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Agustín Moyano  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 105535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105535=edit
Bug 25670: Add Koha::Acquisition::Orders->filter_by_id_including_transfers

This patch introduces a method to filter on the ordernumber, looking for
it on the aqorders_transfers table ('ordernumber_from' field).

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Orders.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 105534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105534=edit
Bug 25670: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||20212
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25670] New: Add a method to search by ordernumber on transfered ones as well to K:A:Orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670

Bug ID: 25670
   Summary: Add a method to search by ordernumber on transfered
ones as well to K:A:Orders
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

This is something that happens in C4::Acquisition::SearchOrders and is needed
to be used on the API controller.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||25670


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670
[Bug 25670] Add a method to search by ordernumber on transfered ones as well to
K:A:Orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|normal  |critical
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #0)
> The "maxreserves" syspref is only checked in opac/opac-reserve.pl and
> reserve/request.pl

Why isn't maxreserves checked in CanItemBeReserved?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Victor Grousset/tuxayo  changed:

   What|Removed |Added

Summary|ElasticSearch 6 |ElasticSearch 6: [types
   |deprecation: [types |removal] Specifying types
   |removal] Specifying types   |in put mapping requests is
   |in put mapping requests is  |deprecated (incompatible
   |deprecated (incompatible|with 7)
   |with 7) |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

--- Comment #2 from Magnus Enger  ---
When I run those same updates manually they work:

MariaDB [koha_hkr]> ALTER TABLE borrowers
-> ADD COLUMN flgAnonymized tinyint DEFAULT 0
-> AFTER overdrive_auth_token;
Query OK, 0 rows affected (0.006 sec)
Records: 0  Duplicates: 0  Warnings: 0

MariaDB [koha_hkr]> ALTER TABLE deletedborrowers
-> ADD COLUMN flgAnonymized tinyint DEFAULT 0
-> AFTER overdrive_auth_token;
Query OK, 0 rows affected (0.006 sec)
Records: 0  Duplicates: 0  Warnings: 0

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #111 from Michal Denar  ---
Hi Aleisha,
it need to be rebase on top of master.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
I got a similar error when upgrading a straight package install from 18.11.06
to 19.11.06: 

DBD::mysql::db do failed: Row size too large. The maximum row size for the used
table type, not counting BLOBs, is 8126. This includes storage overhead, check
the manual. You have to change some columns to TEXT or BLOBs [for Statement "
ALTER TABLE borrowers
ADD COLUMN flgAnonymized tinyint DEFAULT 0
AFTER overdrive_auth_token
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
18071.
DBD::mysql::db do failed: Row size too large. The maximum row size for the used
table type, not counting BLOBs, is 8126. This includes storage overhead, check
the manual. You have to change some columns to TEXT or BLOBs [for Statement "
ALTER TABLE deletedborrowers
ADD COLUMN flgAnonymized tinyint DEFAULT 0
AFTER overdrive_auth_token
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
18077.
Upgrade to 18.12.00.049 done (Bug 21336 - Add field flgAnonymized)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on||25669


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
[Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in
put mapping requests is deprecated (incompatible with 7)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Blocks||25439


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439
[Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on||25668


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668
[Bug 25668] ElasticSearch 6 deprecation: the default number of shards will
change in version 7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Blocks||25439


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439
[Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25669] New: ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Bug ID: 25669
   Summary: ElasticSearch 6 deprecation: [types removal]
Specifying types in put mapping requests is deprecated
(incompatible with 7)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vic...@tuxayo.net

This happens in koha-testing-docker with ES 6.8.8
When indexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d

Here are both deprecation messages that are outputted and related:


[DEPRECATION] [types removal] Specifying types in put mapping requests is
deprecated.
To be compatible with 7.0, the mapping definition should not be nested under
the type name, and the parameter include_type_name must be provided and set to
false.
- In request: {body => {data => {properties => {abstract => {analyzer =>
"analyzer_standard",fields => {ci_raw => {normalizer =>
"icu_folding_normalizer",type => "keyword"},phrase => {analyzer =>
"analyzer_phrase",search_analyzer => "analyzer_phrase",type => "text"},raw =>
{normalizer => "nfkc_cf_normalizer",type => "keyword"}},search_analyzer =>
"analyzer_standard",type => "text"},abstract__sort => {index => "false",numeric
=> "true",type => "icu_collation_keyword"},acqsource =>
$VAR1->{body}{data}{properties}{abstract},acqsource__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},arl =>
$VAR1->{body}{data}{properties}{abstract},arl__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},arp =>
$VAR1->{body}{data}{properties}{abstract},arp__sort =>
$VAR1->{body}{data}{properties}{abstract_
_sort},author => $VAR1->{body}{data}{properties}{abstract},"author-in-order" =>
$VAR1->{body}{data}{properties}{abstract},"author-in-order__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"author-name-corporate" =>
$VAR1->{body}{data}{properties}{abstract},"author-name-corporate__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"author-name-personal" =>
$VAR1->{body}{data}{properties}{abstract},"author-name-personal__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"author-personal-bibliography"
=>
$VAR1->{body}{data}{properties}{abstract},"author-personal-bibliography__sort"
=> $VAR1->{body}{data}{properties}{abstract__sort},"author-title" =>
$VAR1->{body}{data}{properties}{abstract},"author-title__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},author__facet => {type =>
"keyword"},author__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},author__suggestion => {analyzer
=> "simple",max_input_length => 100,search_analyzer => "simple",type =>
"completion"},barcode =>
$VAR1->{body}{data}{properties}{abstract},barcode__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},"bgf-number" =>
$VAR1->{body}{data}{properties}{abstract},"bgf-number__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"bib-level" =>
$VAR1->{body}{data}{properties}{abstract},"bib-level__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},biblioitemnumber =>
$VAR1->{body}{data}{properties}{abstract},biblioitemnumber__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},bio =>
$VAR1->{body}{data}{properties}{abstract},bio__sort => $VAR
1->{body}{data}{properties}{abstract__sort},"bnb-card-number" =>
$VAR1->{body}{data}{properties}{abstract},"bnb-card-number__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},ccode =>
$VAR1->{body}{data}{properties}{abstract},ccode__facet =>
$VAR1->{body}{data}{properties}{author__facet},ccode__sort =>
$VAR1->{body}{data}{properties}{abstract__sort},"classification-source" =>
$VAR1->{body}{data}{properties}{abstract},"classification-source__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-bib-sort" => $V
AR1->{body}{data}{properties}{abstract},"cn-bib-sort__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-bib-source" =>
$VAR1->{body}{data}{properties}{abstract},"cn-bib-source__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-class" =>
$VAR1->{body}{data}{properties}{abstract},"cn-class__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-item" =>
$VAR1->{body}{data}{properties}{abstract},"cn-item__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-prefix" =>
$VAR1->{body}{data}{properties}{abstract},"cn-prefix__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-sort" =>
$VAR1->{body}{data}{properties}{abstract},"cn-sort__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"cn-suffix" =>
$VAR1->{body}{data}{properties}{abstract},"cn-suffix__sort" =>
$VAR1->{body}{data}{properties}{abstract__sort},"code-geographic" =>
$VAR1->{body}{data}{properties}{abstract},"code-geographic__sort" =>

[Koha-bugs] [Bug 25668] New: ElasticSearch 6 deprecation: the default number of shards will change in version 7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668

Bug ID: 25668
   Summary: ElasticSearch 6 deprecation: the default number of
shards will change in version 7
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vic...@tuxayo.net

This happens in koha-testing-docker with ES 6.8.8
When indexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d

Here are both deprecation messages that are outputted and related:

[DEPRECATION] the default number of shards will change from [5] to [1] in
7.0.0; if you wish to continue using the default of [5] shards, you must manage
this on the create index request or with an index template - In request: {body
=> {settings => {index => {analysis => {analyzer => {analyzer_phrase =>
{char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer =>
"keyword"},analyzer_standard => {filter => ["icu_folding"],tokenizer =>
"icu_tokenizer"},analyzer_stdno => {char_filter => ["punctuation"],filter =>
["icu_folding"],tokenizer => "whitespace"}},char_filter => {punctuation =>
{pattern =>
"([\\x00-\\x1F,\\x21-\\x2F,\\x3A-\\x40,\\x5B-\\x60,\\x7B-\\x89,\\x8B,\\x8D,\\x8F,\\x90-\\x99,\\x9B,\\x9D,\\xA0-\\xBF,\\xD7,\\xF7])",replacement
=> "",type => "pattern_replace"}},normalizer => {icu_folding_normalizer =>
{filter => ["icu_folding"],type => "custom"},nfkc_cf_normalizer => {char_filter
=> "icu_normalizer",type => "custom","index.mapping.total_fields.limit" =>
1}},ignore => [],method => "PUT",mime_type => "application/json",path =>
"/koha_kohadev_biblios",qs => {},serialize => "std"}


[DEPRECATION] the default number of shards will change from [5] to [1] in
7.0.0; if you wish to continue using the default of [5] shards, you must manage
this on the create index request or with an index template - In request: {body
=> {settings => {index => {analysis => {analyzer => {analyzer_phrase =>
{char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer =>
"keyword"},analyzer_standard => {filter => ["icu_folding"],tokenizer =>
"icu_tokenizer"},analyzer_stdno => {char_filter => ["punctuation"],filter =>
["icu_folding"],tokenizer => "whitespace"}},char_filter => {punctuation =>
{pattern =>
"([\\x00-\\x1F,\\x21-\\x2F,\\x3A-\\x40,\\x5B-\\x60,\\x7B-\\x89,\\x8B,\\x8D,\\x8F,\\x90-\\x99,\\x9B,\\x9D,\\xA0-\\xBF,\\xD7,\\xF7])",replacement
=> "",type => "pattern_replace"}},normalizer => {icu_folding_normalizer =>
{filter => ["icu_folding"],type => "custom"},nfkc_cf_normalizer => {char_filter
=> "icu_normalizer",type => "custom","index.mapping.total_fields.limit" =>
1}},ignore => [],method => "PUT",mime_type => "application/json",path =>
"/koha_kohadev_authorities",qs => {},serialize => "std"}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

--- Comment #11 from Lucas Gass  ---
I changed how this patch functions so I am reseting to Needs Sign-off, I also
removed Victor's sign-off line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

Lucas Gass  changed:

   What|Removed |Added

 Attachment #105446|0   |1
is obsolete||

--- Comment #10 from Lucas Gass  ---
Created attachment 105533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105533=edit
Bug 25349: Add checkEnter function and apply it to SCO page

This patch adds the checkEnter function to the OPAC global.js and then applies
it to the SCO login page.
TO TEST:
1. Go to SCO login and try entering something in the "Login:" input amd
"Password:" input.
2. Pressing enter while in either will automatically submit the form.
3. Apply patch.
4. Type something into the Login: field and press enter, the form should NOT
submit.
5. Type something into the Password: field and pess enter, this SHOULD submit
the form.
6. Change the syspref SelfCheckoutByLogin to 'Cardnumber'
7. TType something into the Please enter your card number: field, the form
should NOT submit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25666] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25666] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666

Owen Leonard  changed:

   What|Removed |Added

 Attachment #105532|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25666] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666

Owen Leonard  changed:

   What|Removed |Added

Summary|yasmin  |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657

--- Comment #3 from Elaine Bradtke  ---
(In reply to Jonathan Druart from comment #1)
> Hi Elaine,
> 
> I have tried on 19.11.06, I am not sure I understand what the problem is.
> If I use the import patron tool to create new patrons and the csv file does
> not contain a userid (either no value in the cell, or no header at all),
> then the userid is automatically built concatenating firstname and surname.
> 
> Can you detail a bit more?

Are you saying it would work if there was a column userid, but no data in it?
We've never had a userid field empty or not, in previous imports and it worked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25667] New: Add field for items.notforloan_on to record when a notforloan status is applied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667

Bug ID: 25667
   Summary: Add field for items.notforloan_on to record when a
notforloan status is applied
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We record lost_on and damaged_on. Can we record notforloan_on, too? It'd be
helpful for various reports.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25666] New: yasmin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666

Bug ID: 25666
   Summary: yasmin
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: yp897...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 105532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105532=edit
Hahaha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #5 from Victor Grousset/tuxayo  ---
TODO use Time::Fake to reproduce instead of changing date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #18 from Victor Grousset/tuxayo  ---
Info: patch of comment 1 is still in 19.05.x and isn't not the cause of bug
25665 (test t/db_dependent/Circulation.t fails on a specific date)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #4 from Victor Grousset/tuxayo  ---
Patch of bug 24881 comment 1 is still in 19.05.x and isn't not the cause of
this bug. A revert doesn't make the test output change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #3 from Victor Grousset/tuxayo  ---
failure message:

kohadev-koha@04fc7d250165:/kohadevbox/koha$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 43/46 
#   Failed test 'Hourly rental charge calculated correctly with
finesCalendar = noFinesWhenClosed and closed Wednesdays (168h - 24h * 0.25u)'
#   at t/db_dependent/Circulation.t line 3245.
#  got: '30'
# expected: '36'
# Looks like you failed 1 test of 20.
t/db_dependent/Circulation.t .. 44/46 
#   Failed test 'Incremented fee tests'
#   at t/db_dependent/Circulation.t line 3270.
t/db_dependent/Circulation.t .. 45/46 # Looks like you failed 1 test of 46.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/46 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 256 Tests: 46 Failed: 1)
  Failed test:  44
  Non-zero exit status: 1
Files=1, Tests=46, 30 wallclock secs ( 0.10 usr  0.02 sys + 22.21 cusr  4.17
csys = 26.50 CPU)
Result: FAIL
kohadev-koha@04fc7d250165:/kohadevbox/koha$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25665

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #6 from Owen Leonard  ---
Work in progress:

https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4

If you test, you'll need to run 'yarn install' before running 'yarn build
--view opac'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24881

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #2 from Victor Grousset/tuxayo  ---
Severity: minor but it will also depend of the underlying cause.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #1 from Victor Grousset/tuxayo  ---
I tried very quickly to find if the test suite mentioned mocking time (to have
a clean way to test) but I haven't found such thing. (will continue searching)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25665] New: test t/db_dependent/Circulation.t fails on a specific date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

Bug ID: 25665
   Summary: test t/db_dependent/Circulation.t fails on a specific
date
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org

2020-06-02

== Test plan ==
Warning: changing the system time to something too far in the past will disrupt
HTTPS & TLS so you will have errors if you try to browse the web in parallel.
And other software(like email clients) might pop errors.
Nothing to worry about.

1. Set system date to 2020-06-01 (time: somewhere during that day)
2. prove t/db_dependent/Circulation.t
3. "All tests successful."
4. Set system date to 2020-06-02 (time: somewhere during that day)
5. prove t/db_dependent/Circulation.t
6. Fail
7. Set system date to 2020-06-03 (time: somewhere during that day)
8. "All tests successful."


master : doesn't happen
19.11.x: doesn't happen
19.05.x: happens (v19.05.11)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657

Elaine Bradtke  changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #2 from Elaine Bradtke  ---
This happened in 19.11.05.   I upload and overwrite the patron data on a
quarterly basis (it's derived from a spreadsheet of membership data). 
The error message I got was:
"Userid elaine.bradtke is already used by another patron" repeated for all
2000+ records.  I went back to the spreadsheet, gave everyone arbitrary userids
and it worked.
Just to test this wasn't a fluke, I've gone back to the spreadsheet, removed
the userid column and tried the upload again.  It failed:
 mport results :
0 imported records
0 overwritten
0 not imported because already in borrowers table and overwrite disabled
2124 not imported because they are not in the expected format
2124 records parsed
Back to Tools


Feedback:
headerrow : cardnumber, title, firstname, surname, address, address2, city,
state, zipcode, country, dateexpiry, email, phone, branchcode, categorycode,
Content-Disposition : form-data; name="uploadborrowers"; filename="EFDSS -
Membership Export 2020-06-02.csv"
Content-Type : application/octet-stream
Parsing upload file EFDSS - Membership Export 2020-06-02.csv


Error analysis:
Userid elaine.bradtke is already used by another patron. (repeated 2000+ times)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #9 from Martin Renvoize  ---
Current state.. 'Refund, 'Refund and Charge' should both be working as expected
at this point.. I am still working on 'Refund and Restore'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #8 from Martin Renvoize  ---
Created attachment 105531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105531=edit
Bug 23091: Add handling for new lostreturn rules

This patch adds circulation handling for two new lost item return rules.
These new rules allow for the new options of refund lost item charge
plus charge a freshly calculated overdue fine and refind of lost item
charge plus charge a new fine matching the amount from the original
overdue fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #96217|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #7 from Martin Renvoize  ---
Created attachment 105530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105530=edit
Bug 23091: Update unit test

This patch updates the unit test for get_lostreturn_policy to reflect
the rule_name and return code changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #6 from Martin Renvoize  ---
Created attachment 105529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105529=edit
Bug 23091: Database update

This patch updates the 'refund' circulation rule to be called
'lostreturn' and populates the value with 'refund' where appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo  ---
It doesn't apply cleanly on 19.05.x and the conflict isn't simple to solve.
If there is an interest in having this backported, feel free to submit a patch
for 19.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14848] Fund level user restriction is not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14848

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #1 from Kelly McElligott  ---
This is still relevant in 19.05.  Creating a fund restricting to the owner,
users and library all seem to be not applying when using a fund logged in (as
not the owner, user or library)

In addition, the funds that are specific to a library (through the Fund setup)
are still showing to Baskets created at other libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21565] SCO checkout confirm should be modal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24390] Add item total to rotating collections (addItems.tt)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858
Bug 24858 depends on bug 22381, which changed state.

Bug 22381 Summary: Wording on Calendar-related system preferences not 
standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24497] CodeMirror indentation problems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldoldstable  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23694] Author "By" should have its own class

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23694

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23720] Add div wrapper to search results to make moving cover images easier

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434

Lucas Gass  changed:

   What|Removed |Added

   Assignee|lu...@bywatersolutions.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #120 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #119)
> Sponsoring library has approved, removing discussion status

Could you share a summary of what has been tested and discussed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105507|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 105528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105528=edit
Bug 25526: Allow write off selected of less than or equal to amount

TEST PLAN:
1. Have a fine on a Patron's account.
2. Choose the "Write off Selected" button
3.  Enter an amount less than the amount owed by the patron.
4. Koha will give a yellow box with a note "You must collect a value greater
than or equal to 2.00." The $2.00 is the amount that is attempted to write off
(the amount less than the amount owed).
5. Apply patch
6. Again try to pay an amount less than the amount owed.
7. You should be able to pay it off.
8. Try paying an amount more than owed, you should still get an error. You
shouldn't be able to write off more than the amount.
9. Make sure 'Pay selected' still works as it should.

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/