[Koha-bugs] [Bug 25428] Escaped HTML shows in authority detail view when subfield is a link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.07
released in||
 CC||alei...@catalyst.net.nz
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25452] Alternate email contact not displayed

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||alei...@catalyst.net.nz

--- Comment #7 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25506] Perl undef warning on the "About Koha" page

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.07
released in||
 Status|Pushed to master|Pushed to stable
 CC||alei...@catalyst.net.nz

--- Comment #5 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #71 from Aleisha Amohia  ---
Hi all, the tests fail in Jenkins in 19.11. Output below: 

10:41:09 koha_1   | DBD::mysql::st execute failed: Unknown column 'name' in
'where clause' [for Statement "SELECT COUNT( * ) FROM `cities` `me` WHERE (
`name` LIKE ? )" with ParamValues: 0="manuel%"] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test '200 OK'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | #  got: '500'
10:41:09 koha_1   | # expected: '200'
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'has value for JSON Pointer "/0"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'has value for JSON Pointer "/1"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'has value for JSON Pointer "/2"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'exact match for JSON Pointer
"/0/name"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | #  got: undef
10:41:09 koha_1   | # expected: 'Manuel'
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'exact match for JSON Pointer
"/1/name"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | #  got: undef
10:41:09 koha_1   | # expected: 'Manuela'
10:41:09 koha_1   | 
10:41:09 koha_1   | #   Failed test 'exact match for JSON Pointer
"/2/name"'
10:41:09 koha_1   | #   at t/db_dependent/Koha/REST/Plugin/Objects.t
line 155.
10:41:09 koha_1   | #  got: undef
10:41:09 koha_1   | # expected: 'Manuelab'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
Hmm the ICU files don't look like they've changed in 5 years, so nothing on
that end.

Without more detail, this might be considered a support report rather than a
bug report. (I'd suggest turning up the verbosity on the Zebra server logging,
and comparing ICU vs CHR call number searching to see what differences are
happening at the Zebra server level.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

--- Comment #23 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #22)
> I'm surprised by this, as I recall some bug excluding 999 from this, or
> maybe it was a comment on the tests because now I cannot find it in bugzilla.

I see a comment in ./Koha/Filter/MARC/ViewPolicy.pm about how hiding the LDR
causes "the MARCXML->MARC::Record->MARCXML transformation blows up"?

I imagine the fix would be to have a hash containing critical fields based on
the MARC schema (I don't recall if Unimarc uses 999$c as well or not), and then
just consult that in _filter_field()?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168

ciarebaha  changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

--- Comment #17 from ciarebaha  ---
(In reply to Jonathan Druart from comment #16)
> The problematic line is:
> 
> 1118 var FldsRequired = [ARRAY(0x66dd688)];
> 
> Can you open your file opac-suggestions.tt and copy what you have line 346
> please?
> 
> It must be
> 
> 346 var FldsRequired = ['[% mandatoryfields.join("','") | html
> %]'];


The purchase suggestion already working now after we add .join (",") to
opac.suggestion.tt. Thank you all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

--- Comment #6 from Hayley Mapley  ---
The main reason for wanting the 'Skip to main content' link in Koha I think is
to bypass all the elements in the header such as the Cart, Lists, and Search
bars.

So for example we would not need it in opac-basket.tt, and in the opac-main.tt
we'd want it around the .main div where all the text from News items and main
user block are.

Happy to defer to an expert as I am not one, if anyone else has thoughts!

On the patch, it would be good to make it a bit brighter and bolder so it's
more obvious, as it's not only visually impaired users who are keyboard only.
Also, when I tested, the behaviour was weird and I'm not sure why, could be my
internet? So will need another tester. But when I hit tab and then enter it
wouldn't register for a bit, then I'd spam hit enter a couple of times and it
would jump down.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25704] New: With ICU chains on, searching by callnumbers does not produce accurate results

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704

Bug ID: 25704
   Summary: With ICU chains on, searching by callnumbers does not
produce accurate results
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com

This seems to be a change in functionality around the 19.05.09 version, with
ICU chains turned on, the ability to search using the "Call Number" option from
the staff client or the OPAC search, is not working accurately.

It will pull results but not all good results and certainly not find all the
results for that particular search.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

--- Comment #22 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #17)
> I'm glad to see this change go in, but it appears that it caused Bug 25686,
> because the visibility for the 999$c was set to hide. 
> 
> I don't think that it's a bug or regression, but rather we should let people
> know somehow that they may need to update their MARC bibliographic
> frameworks, since they won't be automatically updated.
> 
> I suppose that the release notes would've been the place for that, but
> perhaps it's too late for that?
> 
> I think Koha should probably automatically update the "Default Framework" on
> upgrades. The first time we do it could be problematic, since people's
> changes would disappear (although we could back them up in an "Old Default
> Framework"), but I figure we need to have some strategy for delivering
> framework updates automatically.

I'm surprised by this, as I recall some bug excluding 999 from this, or maybe
it was a comment on the tests because now I cannot find it in bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25703] AllowItemsOnHoldCheckoutSCO behavior.

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25703

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #10 from David Cook  ---
I'm not familiar with the Elasticsearch configurable facet code, but I wonder
how easy it would be to adapt this Zebra code to work with it too.

(Although these days I think it would make more sense just to work towards
fully deprecating Zebra to be honest.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #249 from David Cook  ---
Not sure if this needed a sign off but did one anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

David Cook  changed:

   What|Removed |Added

 Attachment #105667|0   |1
is obsolete||

--- Comment #248 from David Cook  ---
Created attachment 105672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105672=edit
Bug 11529: Do not update marc mappings, print old mappings to upgrade log

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #247 from David Cook  ---
(In reply to Kyle M Hall from comment #246)
> (In reply to Kyle M Hall from comment #245)
> > Created attachment 105667 [details] [review] [review]
> > Bug 11529: Do not update marc mappings, print old mappings to upgrade log
> 
> Nick and I have been looking into this and this patch seems to be the only
> reasonable solution. In a nutshell, what Nick was trying to accomplish with
> that update query just isn't possible anymore.

Agreed. Your patch is the same thing I've already implemented locally, and I
haven't had any issues since.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

--- Comment #21 from David Cook  ---
(In reply to Jonathan Druart from comment #18)
> David, What about adding a check in search_for_data_inconsistencies.pl?

Yeah maybe. I wasn't familiar with search_for_data_inconsistencies.pl, so I
just took a look. (It actually looks like it would benefit from Bug 25661.)

I suppose /cgi-bin/koha/admin/checkmarc.pl would be the best place for a user
initiated check. 

Maybe a Koha::Check::* or Koha::Validate::* module that could be used in both
places. 

Alternatively, I suppose we could make ViewPolicy skip critical MARC fields...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25703] New: AllowItemsOnHoldCheckoutSCO behavior.

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25703

Bug ID: 25703
   Summary: AllowItemsOnHoldCheckoutSCO behavior.
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ev...@mckinneytexas.org
QA Contact: testo...@bugs.koha-community.org

The AllowItemsOnHoldCheckoutSCO syspref allows all items on hold to be checkout
within the selfcheck module. It seems to me that the preference would be more
useful if it only allowed items with "Pending" holds not "confirmed and
waiting" holds. 

Ed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25702] Actions button on Search results from Z39.50 is displayed incorrectly

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702

Ján Kniez  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25702] New: Actions button on Search results from Z39.50 is displayed incorrectly

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702

Bug ID: 25702
   Summary: Actions button on Search results from Z39.50 is
displayed incorrectly
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jkn...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 105671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105671=edit
Screenshot of the wrong position of the menu launched by Actions button

When clicking on the Actions button in the Z39.50 Search Results window,
sometimes the menu is not displayed correctly (actually it is displayed under
or next to the table with Results and it is not visible in the displayed area).
Usually it happens after clicking on the table row and then on the Actions
button.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9750] Bring routing lists into notices & slips

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750

Donna  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

--- Comment #5 from Donna  ---
This is still a commonly requested enhancement that would give users a great
amount of flexibility.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25701] Facets display in random order

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701

Owen Leonard  changed:

   What|Removed |Added

  Component|OPAC|MARC Bibliographic data
   ||support
Version|19.11   |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687

--- Comment #1 from Owen Leonard  ---
Created attachment 105670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105670=edit
Bug 25687: Switch Y/N in EDI accounts table for Yes and No for better
translatability

This patch changes the list of EDI accounts shown in EDI administration
so that columns which previously used "Y" or "N" now show "Yes" or "No."

To test, apply the patch and go to Administration -> EDI accounts.

If necessary, add an EDI account. In the table of information about the
EDI account, the columns with information about quotes, orders,
invoices, responses, and auto-ordering should show "Yes" or "No" based
on the account's settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25687


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687
[Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better
translatability
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||25677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677
[Bug 25677] Checkbox options for EDI accounts cannot be enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582

Owen Leonard  changed:

   What|Removed |Added

 Attachment #105668|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 105669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105669=edit
Bug 25582: Don't show OPAC problems entry on dashboard when there are no
reports

This patch makes a minor correction to the template to correct the check
on outstanding OPAC problem reports. An error was preventing the check
from working correctly.

To test, apply the patch and enable the OPACReportProblem system
preference.

 - On the staff interface home page, check the area showing pending
   operations (suggestions, tags, etc.).
 - If you have no pending OPAC problem reports there should be no line
   for OPAC problem reports.
   - If necessary, mark all pending OPAC problem reports closed and
 confirm that when there are no outstanding reports the link is
 hidden.
   - Also test when there are no other outstanding reports in that
 section (suggestions, tags, patron modifications), nothing appears
 at all, not even the surrounding border.
  - If necessary, test that the link appears when you have one or more
OPAC problem reports.
- Go to the OPAC and use the "Report a problem" to submit a test
  report.
- Check that the staff interface home page reflects that there is
  now a pending report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582

Owen Leonard  changed:

   What|Removed |Added

 Attachment #105482|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 105668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105668=edit
Bug 25582: Don't show OPAC problems entry on dashboard when there are no
reports

This patch makes a minor correction to the template to correct the check
on outstanding OPAC problem reports. An error was preventing the check
from working correctly.

To test, apply the patch and enable the OPACReportProblem system
preference.

 - On the staff interface home page, check the area showing pending
   operations (suggestions, tags, etc.).
 - If you have no pending OPAC problem reports there should be no line
   for OPAC problem reports.
   - If necessary, mark all pending OPAC problem reports closed and
 confirm that when there are no outstanding reports the link is
 hidden.
   - Also test when there are no other outstanding reports in that
 section (suggestions, tags, patron modifications), nothing appears
 at all, not even the surrounding border.
  - If necessary, test that the link appears when you have one or more
OPAC problem reports.
- Go to the OPAC and use the "Report a problem" to submit a test
  report.
- Check that the staff interface home page reflects that there is
  now a pending report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #246 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #245)
> Created attachment 105667 [details] [review]
> Bug 11529: Do not update marc mappings, print old mappings to upgrade log

Nick and I have been looking into this and this patch seems to be the only
reasonable solution. In a nutshell, what Nick was trying to accomplish with
that update query just isn't possible anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #245 from Kyle M Hall  ---
Created attachment 105667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105667=edit
Bug 11529: Do not update marc mappings, print old mappings to upgrade log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25698] Curbside Pickup

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
This would be super helpful. 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.12
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #20 from Victor Grousset/tuxayo  ---
Backported to 19.05.x branch for 19.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22699] Remove documentation on Keywords to MARC mapping

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699
Bug 22699 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15972] Make it possible to include additional title information in notices (such as 245$b)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972
Bug 15972 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265
Bug 8265 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7074] Show subtitle, part and number of a record in list of checkins

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074
Bug 7074 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166
Bug 4166 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953
Bug 10953 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164
Bug 4164 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
Bug 14911 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
Bug 22569 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7384] Improve title display in cart and list emails by displaying subtitles, number and part information

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384
Bug 7384 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #244 from Liz Rea  ---
We have seen this exact thing, and it's rather a huge problem for upgrading
libraries going to 19.11





(In reply to David Cook from comment #243)
> Turns out the database update for this change causes unexpected changes to
> the "Koha to MARC mapping" (via the MARC frameworks) if you had additional
> non-standard "Koha to MARC mapping" entries.
> 
> Personally, I wouldn't have updated the marc_subfield_structure
> automatically.
> 
> Here's the query used:
> UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND
> subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE
> fieldmapping.frameworkcode=''"
> 
> This would be a better query:
> UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND
> subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE
> fieldmapping.frameworkcode=''" and field='subtitle'
> 
> Now I have a lot of different MARC fields mapped to biblio.subtitle 
> 
> Of course, even the modified query wouldn't be great, because in my case
> 245$h would get mapped to biblio.title too which isn't what we'd want.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00, 19.05.12
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|20.05.00, 19.11.06  |20.05.00, 19.11.06,
released in||19.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

--- Comment #5 from Martin Renvoize  ---
Right.. so what this now needs is a consensus on each page as to what we should
mark as 'maincontent'..

So far these pages are missing such a class:

opac-alert-subscribe.tt
opac-sendbasket.tt
opac-basket.tt
clubs/clubs-tab.tt
clubs/enroll.tt
sco/printslip.tt
sco/sco-main.tt
sco/help.tt
opac-results-grouped.tt
errors/errorpage.tt
opac-course-details.tt
opac-downloadcart.tt
opac-showreviews-rss.tt
opac-memberentry-update-submitted.tt
opac-registration-invalid.tt
opac-imageviewer.tt
opac-mymessages.tt
ilsdi.tt
opac-reserve.tt
opac-main.tt
sci/sci-main.tt
opac-addbybiblionumber.tt
opac-memberentry.tt
opac-idref.tt
opac-blocked.tt
opac-password-recovery.tt
opac-browser.tt
opac-registration-confirmation.tt
opac-browse.tt
opac-serial-issues.tt
opac-patron-consent.tt
opac-tags_subject.tt
text/explodedterms.tt
opac-sendshelf.tt
opac-request-article.tt
opac-retrieve-file.tt
opac-sendshelfform.tt
opac-course-reserves.tt
svc/shelfbrowser.tt
svc/suggestion.tt
opac-shelves-rss.tt
opac-privacy.tt
opac-registration-email-sent.tt
opac-ics.tt
opac-messaging.tt
opac-opensearch.tt
opac-review.tt
opac-passwd.tt
opac-sendbasketform.tt
opac-discharge.tt
maintenance.tt
opac-showmarc.tt
opac-readingrecord.tt
opac-news-rss.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10205] koha-create error handling

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25701] New: Facets display in random order

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701

Bug ID: 25701
   Summary: Facets display in random order
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fiona.borthw...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

This issue has been raised by our customers following an upgrade to 19.11 but I
can still reproduce at 20.05.

It is also apparent on both the OPAC and the staff interface.

Search the catalogue and see the results page. Facets on the left appear in one
order.
Repeat the same search immediately and the facets appear in a different order.

There is no consistency to this random order.

For example - search one:

Holding Libraries
Series
Topics
Authors
Item types
Places 
Locations

Search two:

Holding Libraries
Topics
Item types
Series
Authors
Places
Locations

Each search we carry out seems to yield different facet orders.

Whilst possibly cosmetic, our customers would like to see consistency -
especially for the OPAC as it can cause confusion for end users.

We have toggled use_zebra_facets between 0 and 1 in koha-conf.xml but makes no
difference.

Testing on a live server at 18.11, we can confirm that the order the facets
appear remains consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

--- Comment #21 from Tomás Cohen Arazi  ---
The bug in stable is that any API interaction (the route /patrons changing data
from an external source) ends with action_logs having the responsible for the
action not set => bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 105666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105666=edit
Bug 24003: (follow-up) Add all userenv parameters

This patch makes the API set more userenv params than just the
borrowernumber. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_*
=> SUCCESS: All tests pass
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

--- Comment #19 from Victor Grousset/tuxayo  ---
(In reply to Tomás Cohen Arazi from comment #16)
> It was because I wrote one before the other, and the tests initially
> depended on on setup of the mocked things.

Ok, so I'll backport only this patchset.
Since it's for a major bug, the conflicts are reliable to solve and IIUC there
is no strong dependency that could cause undetected regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544

Alexander Borkowski  changed:

   What|Removed |Added

 CC||alexander.borkow...@kau.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25638] API related tests failing on comparing floats

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|jonathan.dru...@bugs.koha-c |ch...@bigballofwax.co.nz
   |ommunity.org|

--- Comment #15 from Jonathan Druart  
---
Pushing this last patch to turn Jenkins green and move on.

However this still need to be addressed in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25638] API related tests failing on comparing floats

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638

--- Comment #14 from Jonathan Druart  
---
Created attachment 105665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105665=edit
Bug 25638: Make the tests pass - ignoring the actual issue

The API related tests still don't pass with the previous modifications.
They pass on D10 but fail on U18 and I did not manage to find where the
problems come from.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25638] API related tests failing on comparing floats

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638

Jonathan Druart  changed:

   What|Removed |Added

 Status|Pushed to master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105663|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 105664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105664=edit
Bug 22807: Add 'Skip to content' option

This patch adds a 'Skip to content' link to the header bar which will
only appear upon the first use of 'tab' to navigate after any fresh page
load in the OPAC.

Test plan
1/ Load any page in the OPAC
2/ Hit the `tab` key
3/ Note the new 'Skip to main content' link appears at the top left of
the screen.
4/ Hit `Enter`
5/ Note the page scrolls to the area of the page that has the #maincontent id.
6/ Note that the link has been hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

--- Comment #3 from Martin Renvoize  ---
Initial submission; could probably do with some refinement.. please test and
let me know what you think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

--- Comment #2 from Martin Renvoize  ---
Created attachment 105663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105663=edit
Bug 22807: Add 'Skip to content' option

This patch adds a 'Skip to content' link to the header bar which will
only appear upon the first use of 'tab' to navigate after any fresh page
load in the OPAC.

Test plan
1/ Load any page in the OPAC
2/ Hit the `tab` key
3/ Note the new 'Skip to main content' link appears at the top left of
the screen.
4/ Hit `Enter`
5/ Note the page scrolls to the area of the page that has the #maincontent id.
6/ Note that the link has been hidden
7/ Try tabbing around and note that the 'Skip to main content' option
does not reapper
8/ Reload the page
9/ The 'Skip to main content' should appear again upon first use of
'Tab'
10/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #105620|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com
   |ommunity.org|

--- Comment #10 from Jonathan Druart  
---
I obsoleted my patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #9 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #8)
> There is a difference between no accountlines and sum(accountlines)=0.
> 
> If I am dealing with the situation you described in comment 0: A patron had
> fines, but paied all of them: their balance is 0.

So your patch makes it be that a patron with 0 fines will not be returned if
only a fine max is supplied? That is, it adds an assumption that you only want
patrons with any fines if you supply a fine under amount?  I do not think this
is desired behaviour. I think the final step in comment 0 was a correct return
and step 3 was the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|Signed Off  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457

--- Comment #7 from Jonathan Druart  
---
yes of course.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #5)
> I don't see how it could be useful, you are calling GetMarcStructure that is
> doing exactly that.

Is it storing the structure in L1?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #8 from Jonathan Druart  
---
There is a difference between no accountlines and sum(accountlines)=0.

If I am dealing with the situation you described in comment 0: A patron had
fines, but paied all of them: their balance is 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #7 from Andrew Fuerste-Henry  ---
I don't seem to have explained the issue well up front. Nick's patch addresses
what I was looking at. Jonathan, I don't entirely follow what your patch is
doing or why.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #6 from Jonathan Druart  
---
Nick, both changes are valid I think.
My patch is fixing what is describe in comment 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

Nick Clemens  changed:

   What|Removed |Added

 Attachment #105660|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 105662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105662=edit
Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding
(not NULL)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25698] Curbside Pickup

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
Created attachment 105661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105661=edit
Bug 25582 - Screenshot of border displaying on staff interface

This works, but it leaves a border across the screen - see screen shot (this is
after the patch is applied and there are no problem reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #4 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #2)
> Isn't it actually a hidden feature to search for negative balance (credit)?
> 
> If not you can test this patch!

I think the issue is that sum(amountoutstanding) is 'NULL' for patrons with no
account history, it should be treated as 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

--- Comment #3 from Nick Clemens  ---
Created attachment 105660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105660=edit
Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding
(not NULL)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

--- Comment #70 from Martin Renvoize  ---
Awesome.. glad to hear it worked well for your Jonathan.. I think my OOM's were
local.. seems my dev server was due of a little maintenance and I can confirm
that test now pass for me too :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25700] New: Recent Kohacons are missing from the timeline

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700

Bug ID: 25700
   Summary: Recent Kohacons are missing from the timeline
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@bugs.koha-community.org,
katrin.fisc...@bsz-bw.de,
martin.renvo...@ptfs-europe.com,
testo...@bugs.koha-community.org
Depends on: 25442

The last KohaCon entry in the history.txt on master is:

1381881600  October 16-22 2013  KohaCon 2013 and hackfest in Reno, Nevada, USA

I think it probably needs a bit of updating!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442
[Bug 25442] Release dates are missing from the timeline
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25442] Release dates are missing from the timeline

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||25700


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700
[Bug 25700] Recent Kohacons are missing from the timeline
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5198] HOLDPLACED being logged in patron messages

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5198

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

--- Comment #19 from Jonathan Druart  
---
I have no idea which bug in stable we are trying to fix. Where is that
describe?

We should think "regression proof", if the userenv exists then it should be
reliable. Having only the borrowerumber defined seems very wrong to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

--- Comment #68 from Jonathan Druart  
---
Created attachment 105659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105659=edit
Bug 22522: [19.11.x] Fix several REST API tests

Fixes among others the invalid use of json_has() which caused broken tests to
pass with older Mojolicious versions.

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

--- Comment #69 from Jonathan Druart  
---
I have tested Martin's remote branch on master-bionic and 19.11-bionic: all
tests pass!

Aleisha, could you push those 3 patches (the 19.11 ones) and see how behave
Jenkins?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version

2020-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522

--- Comment #67 from Jonathan Druart  
---
Created attachment 105658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105658=edit
Bug 22522: [19.11.x] Fix route typo

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >