[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105802|0 |1 is obsolete|| Attachment #105812|0 |1 is obsolete|| Attachment #105816|0 |1 is obsolete|| --- Comment #73 from Marcel de Rooy --- Created attachment 106033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106033&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105801|0 |1 is obsolete|| --- Comment #72 from Marcel de Rooy --- Created attachment 106032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106032&action=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105805|0 |1 is obsolete|| --- Comment #76 from Marcel de Rooy --- Created attachment 106036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106036&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105803|0 |1 is obsolete|| --- Comment #74 from Marcel de Rooy --- Created attachment 106034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106034&action=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105806|0 |1 is obsolete|| --- Comment #77 from Marcel de Rooy --- Created attachment 106037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106037&action=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105804|0 |1 is obsolete|| --- Comment #75 from Marcel de Rooy --- Created attachment 106035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106035&action=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105807|0 |1 is obsolete|| --- Comment #78 from Marcel de Rooy --- Created attachment 106038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106038&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105811|0 |1 is obsolete|| --- Comment #82 from Marcel de Rooy --- Created attachment 106042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106042&action=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105809|0 |1 is obsolete|| --- Comment #80 from Marcel de Rooy --- Created attachment 106040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106040&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #83 from Marcel de Rooy --- Created attachment 106043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106043&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105810|0 |1 is obsolete|| --- Comment #81 from Marcel de Rooy --- Created attachment 106041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106041&action=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105808|0 |1 is obsolete|| --- Comment #79 from Marcel de Rooy --- Created attachment 106039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106039&action=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #88 from Marcel de Rooy --- Created attachment 106048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106048&action=edit Bug 24151: (QA follow-up) Correct license in two modules Still listing the address.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105815|0 |1 is obsolete|| --- Comment #86 from Marcel de Rooy --- Created attachment 106046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106046&action=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #89 from Marcel de Rooy --- Created attachment 106049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106049&action=edit Bug 24151: (QA follow-up) Fix POD warnings from QA tools POD is missing for get_hash POD is missing for new_from_statistic POD is missing for 'object_class' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #87 from Marcel de Rooy --- Created attachment 106047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106047&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105814|0 |1 is obsolete|| --- Comment #85 from Marcel de Rooy --- Created attachment 106045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106045&action=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105813|0 |1 is obsolete|| --- Comment #84 from Marcel de Rooy --- Created attachment 106044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106044&action=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151
--- Comment #90 from Marcel de Rooy ---
Looks good to me, some additional comments:
t/db_dependent/Koha/Pseudonymization.t
Please add test descriptions. This is a good habit. If we dont do it now, we
will not.
# Subtest: Config does not exist
ok 2
# Subtest: Koha::Anonymized::Transactions tests
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11
ok 12
$values->{branchcode} = $patron->branchcode; # FIXME Must be removed from the
pref options, or FK removed (?)
Adding a FIXME !
my $attributes =
Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')->search({transaction_id
=> $p->id });
So no Koha objects here but DBIx ?
$(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/');
Why do you change $2y to $2a ?
If I understand correctly, $2y signals use of a safer updated algorithm.
$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2
BAD choice for a new config variable! What is key? Where is it used for? Please
add pseudonymize or something ?
In general: We are filling these tables with transactions? Are we going to
keep them indefinitely? What are the plans for cleanup etc.? This could be a
large table in no time.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #91 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #90) > In general: We are filling these tables with transactions? Are we going to > keep them indefinitely? What are the plans for cleanup etc.? This could be a > large table in no time. OK I see a follow-up for purging now ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #16 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Julian Maurice changed: What|Removed |Added Attachment #105870|0 |1 is obsolete|| --- Comment #20 from Julian Maurice --- Created attachment 106050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106050&action=edit Bug 22672: Change to and to in templates, includes, xslt This patch attempts to replace with AND with in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use . I found templates, includes and XSLT by using 'git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of or that I could have missed. Signed-off-by: Timothy Alexis Vass Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Marcel de Rooy changed: What|Removed |Added Attachment #105817|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 106051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106051&action=edit Bug 24152: Add method Koha::Objects->filter_by_last_update Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Marcel de Rooy changed: What|Removed |Added Attachment #105818|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 106052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106052&action=edit Bug 24152: Add a warning about the delete of statistics's table entries Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Marcel de Rooy changed: What|Removed |Added Attachment #105819|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 106053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106053&action=edit Bug 24152: Add the ability to purge pseudonymized tables anonymized_* tables have been added by bug 24151, this patch adds the usual way to purge data from them. The cleanup_database.pl script has been adjusted to take new parameters that will help to delete pseudonymized data. Test plan: Call the scrip with the new parameter to remove pseudonymized data * --pseudo-transactions DAYS will remove entries from pseudonymized_transactions older than DAYS day * --pseudo-transactions can be used without the parameter DAYS but with -- pseudo-transactions-from and/or --pseudo-transactions-to instead, to provide a range of date You can use the patch from bug 24153 to make the tests easier, data will not be deleted if the new --confirm flag is not passed. Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152
--- Comment #21 from Marcel de Rooy ---
Looks good to me, minor points:
+|| defined $pPseudoTransactions
) {
print "You did not specify any cleanup work for the script to do.\n\n";
=> Looks like you forgot the alternative parameters here with from and to ?
Follow-up added.
Use of uninitialized value $pPseudoTransactions in concatenation (.) or string
at misc/cronjobs/cleanup_database.pl line 462.
Purging pseudonymized transactions older than days.
=> Since we have three pars, removed the one parameter from the message.
Looks like it is not possible to purge with days 0 ? Is the time stripped in
the dtf parsing?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #20 from Marcel de Rooy --- Created attachment 106054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106054&action=edit Bug 24152: (QA follow-up) Add tests for alternative from and to pars Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #10 from Marcel de Rooy ---
+# FIXME The output for dry-run mode needs to be improved
Yes. Agreed.
+$tokens->delete if $confirm;
+say sprintf "Removed %s expired OAuth2 tokens", $count if $verbose;
This might be confusing. Among other examples.
* perl misc/cronjobs/cleanup_database.pl -m 10 -v
Mail queue purge triggered for 10 days.
Use of uninitialized value $count in concatenation (.) or string at
misc/cronjobs/cleanup_database.pl line 293.
messages were deleted from the mail queue.
So uninitialized warning that we do not want.
But this example could serve to illustrate that even the wrong count could have
been printed. Look at:
if ( $confirm ) {
$sth->execute($mail) or die $dbh->errstr;
$count = $sth->rows;
}
print "$count messages were deleted from the mail queue.\nDone with
message_queue purge.\n" if $verbose;
=> Since the count is not set, it could well be the count of a former statement
!
I do not think that this is ready for production. Since we do not really
support testing for many options, I do not see why this patch is useful.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #91230|0 |1 is obsolete|| --- Comment #4 from Matthias Meusburger --- Created attachment 106055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106055&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25812] New: Display overdue fines for the document on SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812
Bug ID: 25812
Summary: Display overdue fines for the document on SIP checkin
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs@lists.koha-community.org
Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
Display overdue fines for the document on SIP checkin
Test plan:
- Using SIP, checkin an item that has one or several overdue fines.
- Check that the following message is displayed (AF field):
"You owe {correctly formatted price} for this document."
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25812] Display overdue fines for the document on SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812
--- Comment #1 from Matthias Meusburger ---
Created attachment 106056
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106056&action=edit
Bug 25812: Display overdue fines for the document on SIP checkin.
Test plan:
- Using SIP, checkin an item that has one or several overdue fines.
- Check that the following message is displayed (AF field):
"You owe {correctly formatted price} for this document."
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156
--- Comment #42 from Alex Arnaud ---
Comment on attachment 105828
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105828
Bug 24156: Make sort order and number of items to display configurable (basket
page)
Review of attachment 105828:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24156&attachment=105828)
-
::: C4/Utils/DataTables/TablesSettings.pm
@@ +59,4 @@
> return $columns;
> }
>
> +sub get_table_settings {
No pod covering
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
@@ +4,3 @@
> [% SET footerjs = 1 %]
> [% SET panel_id = 0 %]
> +[% USE Dumper %]
Debug thing ?
@@ +100,5 @@
> +
> +[% IF
> table_settings.default_display_length == 10 %]
> + selected="selected">10
> +[% ELSE %]
> +[% END %]
This makes the "10" option never visible
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #43 from Alex Arnaud --- t/db_dependent/Koha/Template/Plugin/ColumnsSettings.t fail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] New: Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Bug ID: 25813 Summary: Enhance patron expiration in SIP display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently, the patron information returned by SIP only shows "PATRON EXPIRED" when the patron card has expired. This patch makes the display more consistant with the Opac display and also complies with the NotifyBorrowerDeparture system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813
--- Comment #1 from Matthias Meusburger ---
Created attachment 106057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106057&action=edit
Bug 25813: Enhance patron expiration in SIP display
Currently, the patron information returned by SIP only shows
"PATRON EXPIRED" when the patron card has expired.
This patch makes the display more consistant with the Opac display
and also complies with the NotifyBorrowerDeparture system preference.
Test plan:
- apply the patch
- set NotifyBorrowerDeparture to 0
- check that nothing is ever displayed about the card expiration
- set NotifyBorrowerDeparture to a value greater than 0
- check that the following message will be displayed for a card that will
expire within NotifyBorrowerDeparture days:
"Your card will expire on {correctly formatted date}"
- check that the following message will be displayed for a card that has
expired:
"Your account has expired as of {correctly formatted date}"
You can use src/C4/SIP/interactive_patron_dump.pl for easier testing.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25812] Display overdue fines for the document on SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25813] Enhance patron expiration in SIP display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25813 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
Status|Signed Off |Failed QA
--- Comment #3 from Marcel de Rooy ---
Thanks for your patch !
You remove the warning, but are you interpreting the value correctly?
-my $holds_per_record = $rule ? $rule->{holds_per_record} : 0;
+my $holds_per_record = $rule ? $rule->{holds_per_record} || 0 : 0;
$max = $holds_per_record if $holds_per_record > $max;
If space or empty string means Unlimited and we replace it by 0, would our
compares be correct ?
Note that perl now does the same thing but removing the warn will only hide the
problem you found in this code !
I see that code is calculating the number of remaining holds:
my $remaining_holds_for_record = $max_holds_for_record - $holds->count();
If max is 0 but should mean Unlimited, this definitely goes wrong ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #44 from Alex Arnaud --- (In reply to Jonathan Druart from comment #6) > QA note: We can decide to replace the different occurrences of "Columns > settings" > by "Tables settings" if needed. Since default display length is not column related, i agree. At least the visible string (Admin columns settings title). Not a blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25814] New: SIP: Add a message on successful checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Bug ID: 25814 Summary: SIP: Add a message on successful checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently, Koha does not return a message on successful SIP checkin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814
--- Comment #1 from Matthias Meusburger ---
Created attachment 106058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106058&action=edit
Bug 25814: SIP: Add a message on successful checkin.
Currently, Koha does not return a message on successful SIP checkin.
This patchs adds the following message:
- "Item checked-in: {homebranch} - {location}"
Test plan:
- Perform a successful checkin using SIP
- Check that the message is in the checkin response (AF field)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25814] SIP: Add a message on successful checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25814 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] New: SIP Checkout: add more information on why the patron is blocked.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Bug ID: 25815 Summary: SIP Checkout: add more information on why the patron is blocked. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 --- Comment #1 from Matthias Meusburger --- Created attachment 106059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106059&action=edit Bug 25815: SIP Checkout: add more information on why the patron is blocked. Currently, on SIP checkout, Koha only returns "Patron Blocked" when there is a problem with the patron. This patch adds more specific informations, with the following messages: - "Patron expired" - "Patron debarred" - "Patron has fines" (see system preference "noissuescharge") - "Patron blocked" (see system preference "OverduesBlockCirc") Test plan: - Try to do a SIP checkout with a patron that is in one of the above situations. - Check that the displayed message matches the patron's situation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25816] New: Add opac messages in SIP display.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Bug ID: 25816 Summary: Add opac messages in SIP display. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25816] Add opac messages in SIP display.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25816] Add opac messages in SIP display.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 --- Comment #1 from Matthias Meusburger --- Created attachment 106060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106060&action=edit Bug 25816: Add opac messages in SIP display. Test plan: - Add one or more opac messages to a patron (patron detail -> add message -> Add a message for: OPAC) - Check that the messages will be displayed, with correctly formatted dates. You can use src/C4/SIP/interactive_patron_dump.pl for easier testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 --- Comment #8 from Fiona Borthwick --- Our customers often require patron attributes to be mandatory so +1 for enhancing the borrowermandatoryfield system preference. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25817] New: Br0k3n h0m3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25817 Bug ID: 25817 Summary: Br0k3n h0m3 Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: HP OS: All Status: NEW Severity: critical Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: yudiske...@gmail.com Created attachment 106061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106061&action=edit Br0k3n h0m3 ganss slur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25817] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25817 Owen Leonard changed: What|Removed |Added Attachment #106061|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25817] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25817 Owen Leonard changed: What|Removed |Added Summary|Br0k3n h0m3 |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25818] New: Br0k3n h0m3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25818 Bug ID: 25818 Summary: Br0k3n h0m3 Change sponsored?: --- Product: Koha Version: unspecified Hardware: HP OS: All Status: NEW Severity: critical Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: devilgansh...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 106062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106062&action=edit Br0k3n h0m3 ganss slur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25821] New: DARK REGION TEAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25821 Bug ID: 25821 Summary: DARK REGION TEAM Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: kumangkimin...@gmail.com Created attachment 106065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106065&action=edit DARK REGION TEAM DARK REGION TEAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25822] New: Nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25822 Bug ID: 25822 Summary: Nothing Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.dru...@bugs.koha-community.org Reporter: adimuladi65...@gmail.com Created attachment 106066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106066&action=edit Nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25822] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25822 Katrin Fischer changed: What|Removed |Added Summary|Nothing |SPAM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25822] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25822 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25821] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25821 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|DARK REGION TEAM|SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25818] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25818 Katrin Fischer changed: What|Removed |Added Summary|Br0k3n h0m3 |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105400|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize --- Created attachment 106067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106067&action=edit Bug 25245: Add plugins_nightly.pl cronjob script This script simply iterates through installed plugins that impliment a cronjob_nightly method and runs said method. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105401|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 106068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106068&action=edit Bug 25245: (follow-up) Use Koha::Logger Update script to use Koha::Logger to capture method failures. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #47 from Martin Renvoize --- Restored SO lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105402|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 106069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106069&action=edit Bug 25245: Add plugins_nightly.pl to the default cron Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273
Julian Maurice changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Julian Maurice ---
Hi Nick,
Thanks for the explanation, it is much more clear to me now. The change makes
sense and the patch works as expected.
However I would like to see some changes in the patch before validating it:
1)
-ModZebra( $authid, 'specialUpdate', 'authorityserver', $record );
+ModZebra( $authid, 'specialUpdate', 'authorityserver', { record =>
$record, authtypecode => $authtypecode } );
This change is confusing. In ModZebra we now have a $record variable which is a
hash that contain a 'record' key. Even with this simple patch I had to ask
myself several times « what's this $record variable I'm looking at ? The hash
or the MARC::Record ? ».
Look at this line for instance:
+$record = $record->{record};
At some point in the subroutine, $record was a hasref, now it's a MARC::Record.
This is the kind of things that make code hard to read, and make it easier for
bugs to appear.
And I think it is not needed to pass the authtypecode to ModZebra, since it can
be obtained from the MARC::Record.
2)
-unless ($record) {
+if ($record) {
+$indexer->update_index_background( [$biblionumber], [$record]
);
+} else {
$record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1 });
+$indexer->update_index_background( [$biblionumber], [{ record
=> $record }] );
}
-my $records = [$record];
-$indexer->update_index_background( [$biblionumber], [$record] );
I think it was easier to read before : unless there is a record, fetch it; in
all cases call update_index_background
Now it's : if there is a record, call update_index_background, otherwise fetch
the record and call update_index_background.
This change was not needed, so why ? :)
3)
-my $id = $record->id // $record->authid;
+my $id = $record->id;
Again this change is not needed, but this time it causes a bug.
Try this : misc/search_tools/rebuild_elasticsearch.pl -a -ai X (replace X by an
existing authid)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769
--- Comment #3 from Martin Renvoize ---
Comment on attachment 105938
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105938
Bug 25769: Patron self modification triggers change request for date of birth
to null
Review of attachment 105938:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25769&attachment=105938)
-
::: opac/opac-memberentry.pl
@@ +484,5 @@
>
> +if ( defined $borrower{'dateofbirth'} ) {
> +my $dob_dt;
> +$dob_dt = eval { dt_from_string( $borrower{'dateofbirth'} ); }
> +if ( $borrower{'dateofbirth'} );
You're now testing if $borrower{'dateofbirth'} is defined above.. do you still
need to test it here too?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #4 from Martin Renvoize --- Failing QA whilst I wait for a reply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #6 from Martin Renvoize --- Comment on attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605 Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category Review of attachment 105605: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605) - ::: misc/cronjobs/update_patrons_category.pl @@ +57,5 @@ > -ra=date --regafter update if registration date is after a given date > -d --dbfield name=value where is a column in the borrowers table, > patrons will be updated if the field is equal to given > + -dn --notfield name=value where is a column in the borrowers > table, patrons will be updated if the field is equal to given > + -dl --likefield name=value where is a column in the borrowers > table, patrons will be updated if the field is equal to given > + -dnl --notlikefield name=value where is a column in the borrowers > table, patrons will be updated if the field is equal to given All three descriptions here match.. can you clarify the descriptions, please.. replacing 'equal' with the relevant comparison? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Martin Renvoize changed: What|Removed |Added Attachment #105248|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 106070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106070&action=edit Bug 25570: Regression tests This tests verify that the default behaviour is to paginate the results. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: $c->objects->search doesn't paginate results by default Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Martin Renvoize changed: What|Removed |Added Attachment #105249|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 106071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106071&action=edit Bug 25570: Paginate results by default in objects->search This patch makes the helper paginate the resultsif no pagination parameters are passed. Page number defaults to 1, and the page size to the RESTdefaultPageSize syspref value. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Pagination is not enforced by default 3. Apply this patch 4. Repeat 2 => SUCCESS: Results are paginated 5. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Martin Renvoize changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Works as expected, tests pass, qa script passes.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Martin Renvoize changed: What|Removed |Added Attachment #105250|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 106072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106072&action=edit Bug 25570: (follow-up) Fix tests This patch fixes the libraries tests, that expected the old behaviour To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Martin Renvoize changed: What|Removed |Added Attachment #103894|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 106073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106073&action=edit Bug 25189: Unit tests Adds new test for not adding authority if some already exist Also replaces use of 'SearchAuthorities' as it is Zebra specific Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Martin Renvoize changed: What|Removed |Added Attachment #103895|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 106074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106074&action=edit Bug 25189: Don't create authority if results found Automatic authority creation assumes that if we don't match we need a new authority. Using the Default linker, however, we don't match if there exists more than one match. This leads to repeatedly generating authorities once there is a duplicate in the system We shoudl instead only create a new authority if there are no results To test: 1 - Set Linker Module to 'Default' 2 - Enable AutoCreateAuthorities and BiblioAddsAuthorities and CatalogModuleRelink and LinkerRelink 3 - Add two copies of a single authority via Z39 4 - Add a heading for that authority to a bib record 5 - Save the record and note a new authority is generated 6 - Repeat and see another is generated 7 - Apply patch 8 - Restart all the things 9 - Save the record again, no new authority created Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Change in behaviour makes sense and works as expected, tests pass, qa script passes. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509 --- Comment #6 from Martin Renvoize --- Nice spot.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509 Martin Renvoize changed: What|Removed |Added Attachment #105951|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 106075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106075&action=edit Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25756] Empty HTML table row after OPAC "Appearance" preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25756 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Good catch, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25756] Empty HTML table row after OPAC "Appearance" preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25756 Martin Renvoize changed: What|Removed |Added Attachment #105971|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 106076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106076&action=edit Bug 25756: remove erroneous hyphen In the Staff Client, the OPAC "Appearance" preferences table has an extra, empty HTML table row at the end. Test plan: 0) Observe the empty HTML table row at the end of the table that lists OPAC "Appearance" system preferences. 1) Apply this patch. 2) Observe that the empty table row is now gone. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Matthias Meusburger changed: What|Removed |Added Attachment #106055|0 |1 is obsolete|| --- Comment #5 from Matthias Meusburger --- Created attachment 106077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106077&action=edit Bug 23258: Batch holding This patch allows to batch place or cancel holds. Test plan: 1) Apply the patch 2) Go to Tools -> Batch holding 3) Check that you can either upload a barcode file or use the textarea 4) Check that you can place holds on items 5) Check that you can cancel holds on items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25805] SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize changed: What|Removed |Added Attachment #106029|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 106078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106078&action=edit Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25805] SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize changed: What|Removed |Added Attachment #106030|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 106079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106079&action=edit Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25805] SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Works as expected, regressions tests present and passes qa scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] Add a way to restrict anonymous access to public routes (OpacPublic behaviour)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103749|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] Add a way to restrict anonymous access to public routes (OpacPublic behaviour)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 106080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106080&action=edit [19.11.x] Bug 25045: (follow-up) Fix typo adding the RESTPublicAnonymousRequests syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] Add a way to restrict anonymous access to public routes (OpacPublic behaviour)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103773|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] Add a way to restrict anonymous access to public routes (OpacPublic behaviour)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106080|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 106081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106081&action=edit [19.11.x] Bug 25045: (follow-up) Fix typo adding the RESTPublicAnonymousRequests syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25327] Cannot access API spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25327 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 106082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106082&action=edit [19.11.x] Bug 25327: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
