[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 --- Comment #1 from Jonathan Druart --- Created attachment 106218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106218&action=edit Bug 25851: (bug 18928 follow-up) Remove holdallowed rule is value is an empty string On the interface, if "Hold policy" is "Not set", the rule does not exist in the table. We should reflect that during the update DB process. Test plan: 1. Set "Hold policy" to "Not set" 2. Confirm that you can place holds 3. Confirm that the rule does not exist in the DB table 4. Set the value to an empty string (manually) 5. Confirm that you cannot longer place holds 6. Go to the circulation rules page and confirm that the value of "Hold policy" is "Not set" 7. Execute the update DB entry 8. Confirm that you can place holds 9. Confirm that the rule does not exist in the DB table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] Unknown column 'important' in 'field list'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] Unknown column 'important' in 'field list'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17232] When creating a new framework from an old one, several fields are not copied (important, link, default value, max length, is URL)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232 Katrin Fischer changed: What|Removed |Added Blocks||25861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 [Bug 25861] Unknown column 'important' in 'field list' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] Unknown column 'important' in 'field list'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Katrin Fischer changed: What|Removed |Added Depends on||17232 Resolution|--- |FIXED CC||alei...@catalyst.net.nz Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Charlie, something got backported which should not have been - the important field only exists in 20.05. I am linking this to the bug causing the issue and adding our new Release Maintainer for the version, so she can have a look. If it's really urgent, you could try to undo the changes from the other bugs, let me know if I can help there. Caused by bug 17232. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232 [Bug 17232] When creating a new framework from an old one, several fields are not copied (important, link, default value, max length, is URL) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added Status|NEW |In Discussion --- Comment #11 from Mason James --- (In reply to Mason James from comment #10) > hmm, this does look like a legitimate bug, caused by 22522 ^ oops, ignore that - i was testing on jessie :) the problem seems to be that the debian libjson-validator-perl package has the 'cache' dir omitted, which contains local copies of the various schemas Rick, a quick solution to the problem is to restore the cached schemas $ git clone https://github.com/mojolicious/json-validator $ cd json-validator $ git reset --hard 3.06 HEAD is now at 8b19ba0 Released version 3.06 $ sudo cp -a ./lib/JSON/Validator/cache /usr/share/perl5/JSON/Validator/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25861] New: Unknown column 'important' in 'field list'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861 Bug ID: 25861 Summary: Unknown column 'important' in 'field list' Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: ctw2...@protonmail.com QA Contact: testo...@bugs.koha-community.org Koha Version: 19.11.06.000 I found out it's doesn't work when I add new MARC frameworks, error log said there is an Unknown column 'important', So I checked the database structure, there isn't a column called 'important', I also try to delete 'important' from file marctagstructure.pl, and it works, try to fix this ASAP plz System Error Log: [Wed Jun 24 11:01:15.882256 2020] [cgi:error] [pid 22124] [client 172.105.200.142:37851] AH01215: [Wed Jun 24 11:01:15 2020] marctagstructure.pl: DBD::mysql::db do failed: Unknown column 'important' in 'field list' [for Statement "INSERT INTO marc_subfield_structure (frameworkcode,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,important,kohafield,tab,authorised_value,authtypecode,value_builder,isurl,seealso,hidden,link,defaultvalue,maxlength): /usr/share/koha/intranet/cgi-bin/admin/marctagstructure.pl, referer: http://47.113.102.87:8080/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=STT [Wed Jun 24 11:01:15.882612 2020] [cgi:error] [pid 22124] [client 172.105.200.142:37851] AH01215: [Wed Jun 24 11:01:15 2020] marctagstructure.pl: SELECT ?,tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,important,kohafield,tab,authorised_value,authtypecode,value_builder,isurl,seealso,hidden,link,defaultvalue,maxlength from marc_subfield_structure where frameworkcode=?: /usr/share/koha/intranet/cgi-bin/admin/marctagstructure.pl, referer: http://47.113.102.87:8080/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=STT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23653 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #10 from Mason James ---
hmm, this does look like a legitimate bug, caused by 22522
the 'try' block always fails with...
Can't locate object method "bundle" via package
"JSON::Validator::OpenAPI::Mojolicious" at /kohadevbox/koha/Koha/REST/V1.pm
line 76.
...and the 'catch' block calls validator->load_and_validate_schema() which does
a lookup to swagger.io
./Koha/REST/V1.pm
72
73 # Try to load and merge all schemas first and validate the result just
once.
74 my $spec;
75 try {
76 $spec = $validator->bundle(
77 {
78 replace => 1,
79 schema =>
$self->home->rel_file("api/v1/swagger/swagger.json")
80 }
81 );
82
100 }
101 catch {
102 # Validation of the complete spec failed. Resort to validation
one-by-one
103 # to catch bad ones.
104 $validator->load_and_validate_schema(
105 $self->home->rel_file("api/v1/swagger/swagger.json"),
106 {
107 allow_invalid_ref => 1,
108 }
109 );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #9 from c...@pennmanor.net --- Here is the output from my fresh buster server with koha-common 20.05.00-1 $ pmvers JSON::Validator 3.06 $ pmvers Mojolicious 8.12 $ pmvers Mojolicious::Plugin::OpenAPI 2.12 From plack-error.og Compilation failed in require at (eval 410) line 1. Child process 25034 exited with status 255 Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET http://swagger.io/v2/schema.json == Not Found at /usr/share/perl5/JSON/Validator.pm line 343. Compilation failed in require at (eval 410) line 1. Child process 25042 exited with status 255 Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET http://swagger.io/v2/schema.json == Not Found at /usr/share/perl5/JSON/Validator.pm line 343. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Alex Buckley --- (In reply to Jonathan Druart in comment #3): Thanks very much Jonathan. I have made those changes :) Andrew if you have time could you please re-test the patch now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 --- Comment #4 from Alex Buckley --- Created attachment 106217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106217&action=edit Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25828] Update cpanfile for 20.05 release cycle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25828 --- Comment #7 from Aleisha Amohia --- spoke to Chris, not sure that we should be backporting changes to required module versions without extensive testing. not backported to 19.11.x, unless this can be explained a bit more! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 Alex Buckley changed: What|Removed |Added Attachment #105872|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25842] Typo "streetype" in member-main-address-style.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25842 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25839] Typo patron.streetype in member-main-address-style.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25839 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #7 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25774] REST API searches don't handle correctly utf8 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25774 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #16 from Aleisha Amohia --- Does not apply cleanly to 19.11.x. Please rebase if required on 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25776] Last updated / modified date on notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25776 rco...@arlingtonva.us changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #2 from rco...@arlingtonva.us --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #8 from Tomás Cohen Arazi --- This looks really bad if Koha is trying to contact an external site on start-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #7 from Mason James --- (In reply to Rick Conrad from comment #6) > I don't have it on-hand, but I believe it was Ubuntu 18.04. for 18.04, try running these commands $ sudo echo 'deb http://debian.koha-community.org/koha 20.05 main bionic' > /etc/apt/sources.list.d/koha.list $ sudo apt-get update; apt-get -y upgrade $ sudo apt install pmtools you should have... $ pmvers JSON::Validator 3.06 $ pmvers Mojolicious 8.12 $ pmvers Mojolicious::Plugin::OpenAPI 2.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #6 from Rick Conrad --- I don't have it on-hand, but I believe it was Ubuntu 18.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #5 from Mason James --- (In reply to Rick Conrad from comment #3) > > rick@koha:~$ pmvers JSON::Validator > 1.08 > rick@koha:~$ pmvers Mojolicious > 7.59 > rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI > 1.15 > hi Rick which debian version is this output from? buster? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25702] Actions button on Search results from Z39.50 is displayed incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #16 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #16 from Michal Denar --- OK, I'll wait on "Needs signoff" status :-) But I think that similar bug has Holds queue page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #15 from Aleisha Amohia --- Hi Michal, not ready to test yet - needs some work on master and some tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25489] Add ability to delete without sending to clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25489 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #14 from Michal Denar --- Hello Aleisha, is this patch ready to test? I applied patch, but name of first patron was same after change of holds order as before. Tested on Kohadevbox after restart_all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20989] Hold Notes to be added later
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20989 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25488] Add method to clear clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25488 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #1 from Heather --- I would *really* like a method to clear selected items out of that Rancor clipboard--you can only see a teensy-weensy little bit of the beginning of whatever was copied with no horizontal scroll bar to be able to scroll to the right to see the rest of the field/subfield that was copied (thank goodness it doesn't word-wrap, because that would be a real mess to read), so it would be great to be able to select one of the lines of copied field/subfield and then execute a keystroke to delete it (or right-click and get a pop-up menu from which one could select "delete" for those who prefer mousing). Additionally, a method to clear out the entire clipboard would be great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Kelly McElligott changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25860 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25859] 19.11 upgrade creates holdfullfilment rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25859 Kelly McElligott changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25860 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25860] New: 19.11 upgrade creates Return Policy rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25860 Bug ID: 25860 Summary: 19.11 upgrade creates Return Policy rule with empty value Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As part of bug 18928, we moved rules from default_circ_rules to circulation_rules. We created an entry in circulation rules where rule name Return policy (in Default Checkout, hold and return policy) originally was null pre-upgrade, at the upgrade we created an entry where this null value became an empty string instead which Koha treats differently than the NULL value it was. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Kelly McElligott changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25859 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25859] New: 19.11 upgrade creates holdfullfilment rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25859 Bug ID: 25859 Summary: 19.11 upgrade creates holdfullfilment rule with empty value Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As part of bug 18928, we moved rules from default_circ_rules to circulation_rules. We created an entry in circulation rules where rule name hold fulfillment policy where it was null, we created an entry where this null value became an empty string instead which Koha treats differently than the NULL value it was. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 106215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106215&action=edit Bug 25855: Unit tests This patch adds tests fr a new circulation hook for plugins. In this case the post_renewal_action hook, The tests add the hook to the Test plugin, and verify that all the required parameters are passed for the plugin hook to use them. It relies on throwing an exception that is to be caught. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 106216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106216&action=edit Bug 25855: Add a post_renewal_action plugin hook This patch adds a new hook to notify plugins about renewal actions. To test it: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: The tests expect some warnings to show, and they don't (i.e. the sample plugin hook is not being called). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The hook is being called on renewal! 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] New: Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 Bug ID: 25858 Summary: Borrower permissions are broken by update from bug 22868 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The update in bug 22868 flips bit 12 in flags on, however, it was backported and there is no check that the flag is off. A borrower who had bit 11 will now have 4096 added twice which will break their permissions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25857] Hold Pickup Location is broken if UseBranchTransferLimits is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25857 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25857] Hold Pickup Location is broken if UseBranchTransferLimits is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25857 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25857] New: Hold Pickup Location is broken if UseBranchTransferLimits is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25857 Bug ID: 25857 Summary: Hold Pickup Location is broken if UseBranchTransferLimits is not enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If UseBranchTransferLimits is disabled, changing the hold pickup location pulldown on addreserve.pl does not trigger a reload, and thus that branch is not checked to see if it is a valid pickup location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 c...@pennmanor.net changed: What|Removed |Added CC||c...@pennmanor.net --- Comment #4 from c...@pennmanor.net --- I was able to reproduce this on a fresh installation of koha 20.05 from packages on debian buster. I have the webserver behind a firewall blocking all outbound traffic and could not get the koha installer to launch. After digging into the logs I saw the same connection timeouts to swagger.io As soon as I opened up our firewall the installer loaded. You can also reproduce this by dropping something bogus in your /etc/hosts file for swagger.io and restarting plack For example - 127.0.0.1 swagger.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25856] Suspended holds should be styled differently on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25856 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25856] New: Suspended holds should be styled differently on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25856 Bug ID: 25856 Summary: Suspended holds should be styled differently on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When looking at the list of holds on request.pl, it's not terribly obvious when a hold is suspended. It'd be great to make that line appear in a different color or something else immediately obvious. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 --- Comment #2 from Andrew Fuerste-Henry --- If we make the syspref force all terms to be fuzzy when on, can we make it so that when the syspref is off the ~ still works to fuzzy an individual term? I agree that it's unreasonable to expect patrons to remember to use a fancy search trick like that, but I think the flexibility is good for staff users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 106214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106214&action=edit [19.11.x] Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour This patch adds trivial tests for the new error (400) raised when the passed patron_id doesn't exist. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 106212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106212&action=edit [19.11.x] Bug 25662: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 106213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106213&action=edit [19.11.x] Bug 25662: Make the route for holds restpect maxreserves This patch fixes the behaviour for the POST /holds route. It assumed maxreserves was checked in CanItemBeReserved which is not the case. Tests are added to check for this behaviour. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- I think it would be very helpful for staff and patrons as our patrons won't know to do it and might get frustrated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16821] Display complete facets for home libraries, locations, item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821 --- Comment #8 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #123 from Christopher Brannon --- Could columns be accordioned like rows? Maybe accordion each column, or groups according to topic? Then maybe a button/link that shows all or return to accordion? Sometimes we like to scan the page, and having all show as we scroll is good, but we don't want to scroll all the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Nick Clemens changed: What|Removed |Added Blocks||25854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25854 [Bug 25854] Ability to add multiple guarantors affected ability to make guarantor fields mandatory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] New: Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Bug ID: 25855 Summary: Add post_renewal_hook in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We need a hook to trigger plugin actions after renweals take place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25854] Ability to add multiple guarantors affected ability to make guarantor fields mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25854 Nick Clemens changed: What|Removed |Added Depends on||14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25854] New: Ability to add multiple guarantors affected ability to make guarantor fields mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25854 Bug ID: 25854 Summary: Ability to add multiple guarantors affected ability to make guarantor fields mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com bug 14570 made the non-member guarantor fields visible on all patrons prior to this adding fields like 'contactname' to the BorrowerMandatoryFields system preference had the effect of making guarantors mandatory for child accounts only. Now adding those fields makes them required for all patron types, but does not make adding an actual guarantor mandatory. We need to restore a method of making guarantors mandatory for some patron types. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into the `circulation_rules` table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Blocks||25851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Nick Clemens changed: What|Removed |Added Depends on||18928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into the `circulation_rules` table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] New: update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Bug ID: 25853 Summary: update_patrons_category.pl has incorrect permissions in repo Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The permissions for this are -rw-r--r-- and need to be -rwxr-xr-x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #122 from Jessie Zairo --- I spent some time exploring the new layout, here is a summary of my notes. It is nice that if you don’t need to use a column in a certain table, you can set the default to null, save, and the column will be removed. This then creates a dropdown at the end that will allow all the users to add the column back in. Really makes for a clean interface if you have unused columns. It is great that the header floats, staff can easily save, cleanup rules, or apply filters wherever they are on the policy page. For large libraries with multiple branches or consortiums, the initial page, cgi-bin/koha/admin/policy.pl, is slow to load or reflect changes. It would be nice to have the left column and the header float when you are editing the rules. Currently, there is no way to see what rule/column you are editing (without scrolling back and forth). For the rules by category, when creating a new rule, it inserts the new rule alphabetically. For longer lists, you have to go back to find it to make any edits. Overall, this is a fantastic improvement to the matrix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Sally changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Sally --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Patch doesn't apply --- Comment #38 from Sally --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] New: If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Bug ID: 25852 Summary: If a layout is edited, the Layout Type will revert to Barcode Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If a label is set to have the layout as Barcode/Biblio - and edits are made, the layout type will change to just Barcode. To Recreate: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font. 3. Save and Exit. 4. Test print this label and realize that font is too large. 5. Edit existing Layout and change font. 6. Save and then see that the layout type is now set to Barcode. This is extremely confusing and frustrating since one might not notice that the type has changed and prepared to print a sheet of labels and they are now wrong as they are only creating barcode labels instead of barcode/biblio labels. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25430] Improve the styling of the claims returned tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25430 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25430] Improve the styling of the claims returned tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25430 ByWater Sandboxes changed: What|Removed |Added Attachment #104608|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 106211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106211&action=edit Bug 25430: Improve the styling of the claims returned tab It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read. Test Plan: 1) Set up return claims for your system 2) Apply this patch 3) View the claims tab for someone with not claims, and someone with claims 4) Note the resolved claims are green and have a "tooltip" when hovered over 5) Note the unresolved claims are green if 0, and yellow if not 0, and also have a "tooltip" Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24834] Display report number after running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 --- Comment #3 from mada...@ckls.org --- It would also be helpful to display a report's number when you are editing it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Andreas Jonsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #2 from Andreas Jonsson --- Test plan 1. Go to tools -> calendar and make sure Sundays are holidays by adding a holiday on a Sunday and selecting "Holiday repeated every same day of the week" and "Copy to all libraries" and save. 2. Go to administration -> system preferences and select "Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise" for the system preference "useDaysMode" and save the system preferences. 3. Put the below code in a file name test.pl and execute it using the command "sudo koha-shell -c 'perl test.pl' kohadev" use Koha::Calendar; my $calendar = Koha::Calendar->new( branchcode => 'CPL' ); $dt = DateTime->new( year => 2020, month => 06, day=> 21 ); print "This is a sunday: " . $dt->day_of_week . "\n"; my $ndt = $calendar->next_open_days($dt, 0); print "This is a monday: " . $ndt->day_of_week . "\n"; 4. Without the patch applied, this script will freeze after printing "This is a sunday ...". Abort using ctrl-c. 5. Apply patch and run the script again. The test script will now complete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||ke...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25851] New: 19.11 upgrade creates holdallowed rule with empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 Bug ID: 25851 Summary: 19.11 upgrade creates holdallowed rule with empty value Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As part of bug 18928, we moved rules from default_circ_rules to circulation_rules. In that move, where default_circ_rules.holdallowed was NULL, we created an entry in circulation_rules where rule_name is holdallowed and rule_value is an empty string. This results in holds being blocked because Koha treats an empty string differently than it treats an undefined rule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 106210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106210&action=edit
Bug 25845: Add 'api' to the log viewer interface options
This patch simply adds the API option to the log viewer.
To test:
1. Have BorrowersLog set
2. Update some patron using the API. For example
curl --location --request PUT
'http://koha:k...@kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \
--header 'Content-Type: application/json' \
--data-raw '{
"firstname": "Tomasito",
"surname": "None",
"address": "Address",
"category_id": "ST",
"city": "Córdoba",
"library_id": "MPL"
}'
3. Open the log viewer
=> FAIL: There's no way to filter on interface, choosing API
4. Apply this patch
5. Reload the log viewer
=> SUCCESS: There are options to filter by 'API' interface
=> SUCCESS: Filtering by 'API' works
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #41 from Martin Renvoize --- Created attachment 106209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106209&action=edit Bug 8338: (QA follow-up) Clean up warning This patch moves the accountline->store call below the FinesLog code such that we return the same 'thing' from _FixOverduesOnReturn as the other clauses of the routine. We also take the oportunity to clean up the warning thrown by an errant call to the routine such that we output the actual itemnumber rather than a HASH reference marker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697 ByWater Sandboxes changed: What|Removed |Added Attachment #106174|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 106208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106208&action=edit Bug 25697: Declare base url and suffix in tinymce init This patch declares the base url and suffix in tinymce init, so that tinymce will initialize properly cross-browser. Without this change, tinymce will fail to initialize on IE 11. Test plan: 0. Apply patch 1. Open IE 11 2. Enable "UseWYSIWYGinSystemPreferences" system preference 3. Go to /cgi-bin/koha/admin/preferences.pl?tab=opac and note that tinymce initializes correctly 4. Go to /cgi-bin/koha/tools/koha-news.pl and create/edit a news item, and note that tinymce initializes correctly 5. Go to /cgi-bin/koha/admin/branches.pl and add/edit a library, and note that tinymce initializes correctly for "OPAC info" Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #1 from Andreas Jonsson --- Created attachment 106207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106207&action=edit Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0 being Sunday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Andreas Jonsson changed: What|Removed |Added Summary|CalcDateDue freezes with|CalcDateDue freezes with |'useDaysMode' set to|'useDaysMode' set to |'Daysweek' and the due date |'Dayweek' and the due date |lands on a sunday. |lands on a sunday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #40 from Martin Renvoize --- Hmm... not it's not.. we already check for defined in the relevant line.. bit confused -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] New: CalcDateDue freezes with 'useDaysMode' set to 'Daysweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850
Bug ID: 25850
Summary: CalcDateDue freezes with 'useDaysMode' set to
'Daysweek' and the due date lands on a sunday.
Change sponsored?: ---
Product: Koha
Version: 19.11
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
From the DateTime manual page:
$dt->day_of_week()
Returns the day of the week as a number, from 1..7, with 1 being Monday
and 7 being Sunday.
Also available as "$dt->wday()" and "$dt->dow()".
But the method "get_push_amt" assumes that day_of_week is numbered 0..6 with 0
being Sunday. (Also, there is a funny equality test of a boolean value and the
number 1.)
The result is that for Sundays, $self->{weekly_closed_days}->[$dow] is
undefined and its negation is thus true, which results in a push_amt of seven
days, which lands on the next Sunday and the process repeats.
sub get_push_amt {
my ( $self, $base_date) = @_;
my $dow = $base_date->day_of_week;
return (
# We're using Dayweek useDaysMode option
$self->{days_mode} eq 'Dayweek' &&
# It's not a permanently closed day
!$self->{weekly_closed_days}->[$dow] == 1
) ? 7 : 1;
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #39 from Martin Renvoize --- Aha.. it's because with this patch the return of _FixAccountOnReturn is '0' as opposed to a result object.. but as the note says in the routine that doesn't signify an error. I'll add a little followup to clean up the warning.. not really even sure we need it at all now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 mada...@ckls.org changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 106204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106204&action=edit Bug 25662: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 106206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106206&action=edit Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour This patch adds trivial tests for the new error (400) raised when the passed patron_id doesn't exist. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338
--- Comment #38 from Martin Renvoize ---
The nasty looking warn is actually introduced with Bug 21206: Replace
C4::Items::GetItem where `->{itemnumber}` is replaced with `->itemnumber`.
You say the warning doesn't appear at all prior to the patch.. that feels odd..
I'll investigate that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 106205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106205&action=edit Bug 25662: Make the route for holds restpect maxreserves This patch fixes the behaviour for the POST /holds route. It assumed maxreserves was checked in CanItemBeReserved which is not the case. Tests are added to check for this behaviour. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip trapping items with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- Works well, adds units tests, passes qa scripts, no regressions found. Passing QA (I'll leave it to the RM to remove the superfluous comment from the atomicupdate at merge time.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip trapping items with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Martin Renvoize changed: What|Removed |Added Attachment #106198|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 106202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106202&action=edit Bug 25232: Add ability to skip trapping items with a given notforloan value This is a companion/alternative to bug 25184, in that it allows an explicit workflow for placing returned books into temporary storage for a few days for decontamination purposes. The idea here is to create a specific notforloan value for "In Decontamination" or something along along those lines. This notforloan value would never be trappable. At the end of decon, UpdateNotForLoanStatusOnCheckin could be used to remove the notforloan status and allow checkins to be trapped to fill holds. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Give an item a negative notforloan value 4) Place a hold on the item 5) Check the item in 6) Note the item is trapped for hold 7) Set SkipHoldTrapOnNotForLoanValue to the same notforloan value you used in step 3 8) Check the item in again 9) Note Koha did not ask you to trap the item for hold! Signed-off-by: Sally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip trapping items with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Martin Renvoize changed: What|Removed |Added Attachment #106199|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 106203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106203&action=edit Bug 25232: Add ability to specify multiple notforloan values to skip Signed-off-by: Sally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What|Removed |Added Attachment #105551|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 106201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106201&action=edit Bug 18086: Add FK constraints for branchcode and categorycode The overduerules table has no foreign key constraints to any for the related tables. The columns for branchcode, categorycode, letter1, letter2, and letter3 should all be foreign keys. Test Plan: 0) Create some overdue rules with invalid branchcodes and categorycodes 1) Apply this patch 2) Restart all the things! 3) Run updatedatabase.pl 4) Note the invalid rules are deleted 5) Note Default codes are NULL now instead of empty strings 6) Editor should behave as it did before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
