[Koha-bugs] [Bug 25937] Notify patrons about failed login attempts

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25937

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #17 from Marcel de Rooy  ---
(In reply to David Cook from comment #16)
> I like the idea of having a web page to show for an item (whether it's for a
> persistent identifier or just for doing manual updates to an item without
> needing a bib number).
> 
> However, I can understand Katrin's concerns. It seems like we're
> hacking/shoehorning the opac-detail.pl page to serve a purpose it's not
> meant to serve.
> 
> What's the practical use case for this? Is this to be used for a RDF
> subject? Or some other purpose?

Hi David,
See also comment1. This is a first attempt to quickly have an item landing page
(hacking just a few lines). And yes, the item persistent identifier to be used
in RDF subjects should be resolved by the opac-detail item page when content
negotiation comes down to HTML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

--- Comment #3 from Katrin Fischer  ---
I think a stronger default for new installations should be agreeable, but we
can't change behaviour for existing ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956

--- Comment #4 from Katrin Fischer  ---
It looks like bug 20813 is not happening, we might want to come back to this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

--- Comment #2 from David Cook  ---
(In reply to Katrin Fischer from comment #1)
> There was discussion in the past about having some kind of plugin structure
> (bug 13664). 

I was thinking about that a little bit. I mean password managers let you set
length and character sets, so it does make sense for it to be a bit
configurable. 

The dictionaries/common passwords would need to be configurable too. 

I think storing old password hashes and not matching username/password should
just be baked in. 

> I think 1. might not be agreeable to some (unless you mean it
> would only enforce length in combination with another setting). There were
> libraries very much insisting on such short passwords.

That's unfortunate although that's a good point. Personally, I'd like strong
defaults, and then people who choose weaker policies would have to accept the
risk that brings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

--- Comment #1 from Katrin Fischer  ---
There was discussion in the past about having some kind of plugin structure
(bug 13664). I think 1. might not be agreeable to some (unless you mean it
would only enforce length in combination with another setting). There were
libraries very much insisting on such short passwords.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

--- Comment #8 from Katrin Fischer  ---
This has a different purpose than the frameworks visibility - we use it to hide
notes that also appear in the normal view so they are not doubled up. By
default  all 5xx display in the description tab, but some can be in the XSLT
too. So I'd like to keep the functionality with a new name :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #16 from David Cook  ---
I like the idea of having a web page to show for an item (whether it's for a
persistent identifier or just for doing manual updates to an item without
needing a bib number).

However, I can understand Katrin's concerns. It seems like we're
hacking/shoehorning the opac-detail.pl page to serve a purpose it's not meant
to serve.

What's the practical use case for this? Is this to be used for a RDF subject?
Or some other purpose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #12 from David Cook  ---
And if we do want to store the PID at the record level, I think it would be
best to put that into the relational database (we could export it into the MARC
at indexing/exporting time).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
While I see the advantage of using PIDs (I use them in DSpace and other GLAM
systems), after browsing these patches, I don't see the advantages of adding
these patches.

What are you trying to achieve here?

Personally, I think that it would be better to add a plugin to the
authority/biblio/item records and allow you to mint PIDs while cataloguing.
That's how most systems I've used have worked.

That said, sometimes you want to batch mint PIDs, but I think that would be up
to the entity doing the batch work. I don't see why we'd need anything special
for that in Koha.

Or are you trying to create a local Koha PID minting service? If that's the
case, I think storing the data in MARC fields is not a wise direction. It would
be better to have a Koha PID lookup table mapping the PID to the record, so
that PID resolution could be handled that way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #7 from David Cook  ---
Note that this patch doesn't actually rename the system preference. The
updatedatabase.pl change is for version 3.12. It needs an UPDATE statement for
the present.

I also agree with Katrin. I don't think that NotesDenylist is very intuitive.
Perhaps NotesExcludeList or HideNotesList. (I don't think we can use
OpacNotesToHide since NotesBlacklist currently works for both the Intranet and
OPAC I believe?)

I also agree that rewriting release notes doesn't make sense. It would be
better to just say that we're renaming it now.

Alternatively, we could also deprecate this system preference, since the
framework visibility is working better now, although perhaps it's not quite
comprehensive enough yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25937] New: Notify patrons about failed login attempts

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25937

Bug ID: 25937
   Summary: Notify patrons about failed login attempts
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

We should email/SMS patrons about failed login attempts

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25937

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25937] Notify patrons about failed login attempts

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25937

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21190

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25936] New: Notify users if their password has changed

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936

Bug ID: 25936
   Summary: Notify users if their password has changed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

We should email/SMS users if their password has changed. 

We shouldn't include any information about the old or new password, but just
alert them that it has been changed. 

This is useful in the event that someone has compromised an account and changed
the password.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18314] Account lockout

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

David Cook  changed:

   What|Removed |Added

 Blocks||25935


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25935
[Bug 25935] Use time-based mechanism for account lockout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25935] New: Use time-based mechanism for account lockout

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25935

Bug ID: 25935
   Summary: Use time-based mechanism for account lockout
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Bug 18314 added account lockout for failed logins, but it's a hard lockout
which doesn't expire. While this has benefits, it does add administrative
overhead.

A well-crafted brute force attack could lock out all users permanently at
present.

A time-based mechanism could unlock the account after 15 minutes or so, and
further lockouts could get increasingly large lockout durations.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25935] Use time-based mechanism for account lockout

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25935

David Cook  changed:

   What|Removed |Added

 Depends on||18314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
[Bug 18314] Account lockout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25934] New: RequireStrongPassword should be more complex (password policy complexity)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

Bug ID: 25934
   Summary: RequireStrongPassword should be more complex (password
policy complexity)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

At the moment, RequireStrongPassword uses a minimum password length (of only 3
characters or the sysperf minPasswordLength) and a static regular expression.

Here are a number of improvements:

1. A minimum length of 10 characters that can't be lowered via
minPasswordLength

2. Should contain 3 of the following 4 sets (lowercase, uppercase, numbers,
special characters)

3. Not be the same as a previously set password

4. Should not include dictionary words or common passwords
(This could be challenging to do comprehensively on low spec systems, although
one variation of this could be to add a customizable list of passwords to
exclude.)

5. Should not be equal to the username

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22890] Add a chronological changelog

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #20 from David Cook  ---
I think that sending the securePasswordPattern is not a good idea, as it's not
the API consumer's job to handle the password. Sending "code" and
"securePasswordLabel" is fine as that communicates the message from Koha to the
API consumer.

On my TODO list, I'm actually planning more complex password security than just
a regex. I want to add a customizable list of passwords that users cannot use
(e.g. "password", "123456", "Password1", "koha", etc).

We could also add rules like the password and username cannot match. 

These aren't "patterns" per se, but would rather be communicated by "code" and
"securePasswordLabel" I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25905] REST API: create endpoint for importing OAI-PMH records from external OAI-PMH clients

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905

--- Comment #5 from David Cook  ---
(In reply to Katrin Fischer from comment #4)
> You can email and put it on the next dev meetings agenda for discussion/vote.

Great. I don't have a timeline for this at the moment, but I'll keep it in
mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222

--- Comment #10 from David Cook  ---
(In reply to Julian Maurice from comment #9)
> Not sure how this worked before, but uninstalling a plugin with the patch
> applied leaves a lot of files in . Can it be fixed ?

I think uninstallation is already broken anyway? Bug 25604

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #56 from David Cook  ---
(In reply to Jonathan Druart from comment #52)
> Do we need a unit test to compare the local and remote files? (ofc it won't
> fail if the remove file is not reachable)

I wouldn't think so. If our other API unit tests are passing, I'd say that's
what would matter most.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #55 from David Cook  ---
(In reply to Julian Maurice from comment #49)
> What is the test for ? rel_file returns something even if the file does not
> exist

That's interesting. I didn't think it did for me when I tested. I'd have to
look gain.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #19 from Arthur Suzuki  ---
(In reply to Jonathan Druart from comment #15)
> Waiting for an answer.

Bonsoir Jonathan :)
I've implemented a password_policy method in charge of submitting the regex.
KR,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #100426|0   |1
is obsolete||

--- Comment #17 from Arthur Suzuki  ---
Created attachment 106566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106566&action=edit
Bug 23011: Have AuthenticatePatron method send more information

We want AuthenticatePatron to send some more information upon
successful login, especially in the case where password is not safe
and should be renewed.
The goal is to let a third-party app catch thoses codes and
display a warning to the users.

Test plan :
1 / apply tests patch
2 / run tests, verify failure
3 / apply C4/ILSDI/Service.pm patch
4 / run tests again, verify green

Signed-off-by: Emmi Takkinen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

--- Comment #18 from Arthur Suzuki  ---
Created attachment 106567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106567&action=edit
Bug 23011: QA follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23011] AuthenticatePatron could alert if password is not safe

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23011

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #100425|0   |1
is obsolete||

--- Comment #16 from Arthur Suzuki  ---
Created attachment 106565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106565&action=edit
Bug 23011: Add new tests (AuthenticatePatron error codes)

This bug add new tests to the AuthenticatePatron ILS-DI service.
It tests new error codes patron might get when successfully connecting
but with a password which doesn't match Koha security rules.

Signed-off-by: Emmi Takkinen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

Andrew Nugged  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #32 from Arthur Suzuki  ---
added some tests to C4/Reserves as well :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #100175|0   |1
is obsolete||

--- Comment #31 from Arthur Suzuki  ---
Created attachment 106564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106564&action=edit
Bug 22806: Unit Tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #238 from Victor Grousset/tuxayo  ---
When running the tests, is there a way to disable the output of «running
"CREATE VIEW "items_legacy"» ?
There are more than 100 of those outputs when running the tests.

I commented all instances of CREATE VIEW
- installer/data/mysql/kohastructure.sql
-
installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl
And reset the DB but the messages are still outputted in a high number.

Before that: is that relevant to run the tests with and without the patchset to
compare the output and check if there are additional warnings?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club hold pickup locations should be able to default to patron's home library

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Katrin Fischer  changed:

   What|Removed |Added

Summary|Club Hold pickup locations  |Club hold pickup locations
   |should be able to default   |should be able to default
   |to patron's home branch |to patron's home library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

--- Comment #8 from Katrin Fischer  ---
Created attachment 106563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106563&action=edit
Bug 23820: (QA follow-up) Make label clickable for checkbox

By adding an id the checkbox is selected when the label is clicked
enhancing usability.

Also adds a colon : to the label.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105437|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 106562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106562&action=edit
Bug 23820: Add test for new behaviour

To test:
1. prove t/db_dependent/api/v1/clubs_holds.t
2. Sign off

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #102153|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 106561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106561&action=edit
Bug 23820: Add checkout to default to patron's home branch on club hold

This patch adds a checkbox to make holds created by club hold to default to
patron's home branch if possible.

To test:
1. Apply this patch
2. Create a club, and add two patrons (from now on called patron A and patron
B) to it, each one form a different library..
3. Create a hold for the club, and in the details set pickup location different
from any of the patrons.
4. Check "Pickup at patron's home library when possible" checkbox
SUCCESS => when submitted, pickup location of holds defaults to patron's home
branch
5. Modify patron A's library and set pickup location to no.
6. Repeat steps 3 and 4.
SUCCESS => when submitted, patron A's hold now points to pickup location setted
on step 3, and patron B's hold still points to his home branch.
7. Sign off

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Jason Robb 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25931] Show helpful message when a club has no members

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25931

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25931] Show helpful message when a club has no members

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25931

Katrin Fischer  changed:

   What|Removed |Added

Summary|Club members don't show |Show helpful message when a
   |when placing a club hold|club has no members

--- Comment #1 from Katrin Fischer  ---
I missed that you have to Enroll and Finish... to make it more obvious we could
show a message when placing the hold, that the club has no members.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25931] New: Club members don't show when placing a club hold

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25931

Bug ID: 25931
   Summary: Club members don't show when placing a club hold
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When placing holds for a club, the members are no longer shown below the
members heading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on||25930


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930
[Bug 25930] Datatables_Members.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25930] Datatables_Members.t is failing randomly

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Blocks||25551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25930] New: Datatables_Members.t is failing randomly

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930

Bug ID: 25930
   Summary: Datatables_Members.t is failing randomly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org

Two recent failures in the CI

https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_D8/248/consoleText
https://jenkins.koha-community.org/job/Koha_19.05_D9/252/consoleText

And I could reproduce locally in Debian 10 on master.

After 22 tries and 2017 tries

t/db_dependent/Utils/Datatables_Members.t .. 6/53 
#   Failed test 'There are two Doe at nIfpuJszvy'
#   at t/db_dependent/Utils/Datatables_Members.t line 183.
#  got: '3'
# expected: '2'
t/db_dependent/Utils/Datatables_Members.t .. 45/53 # Looks like you failed 1
test of 53.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #20 from Katrin Fischer  ---
Patch doesn't apply and I am not sure about the fix, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23816: Update kohastructure and atomic update
Applying: Bug 23816: [DO NOT PUSH] Update category schema
Applying: Bug 23816: (follow-up) Define boolean column in shcema
Applying: Bug 23816: Add tests
Applying: Bug 23816: Add minimum password length and require strong password
overrides by category
Using index info to reconstruct a base tree...
M   Koha/Patron.pm
M   koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt
M   members/memberentry.pl
M   opac/opac-memberentry.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-memberentry.pl
Auto-merging members/memberentry.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc
Auto-merging Koha/Patron.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23816: Add minimum password length and require strong
password overrides by category
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-23816-Add-minimum-password-length-and-require--PKRJhY.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

--- Comment #31 from Katrin Fischer  ---
Created attachment 106560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106560&action=edit
Bug 23111: (QA follow-up) Add AFTER to update database statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #30 from Katrin Fischer  ---
Hi Aleisha,

1) At the moment you can't tell from the administration page, which is the
current default framework. Could you add a column or note there to show the
current default? (/cgi-bin/koha/admin/biblio_framework.pl). I think this would
be really helpful.

I wonder if a hint would be helpful "unset to make default default" (better
phrased) as this might not be intuitive (no edit option for the default
framework).

2) It looks like the advanced editor still defaults to default - should this be
changed as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

Arthur Suzuki  changed:

   What|Removed |Added

Summary|HoldTitle and HoldItem do   |CanBookBeReserve and
   |not check   |CanItemBeReserve do not
   |AllowHoldsOnPatronsPossessi |check
   |ons |AllowHoldsOnPatronsPossessi
   ||ons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check AllowHoldsOnPatronsPossessions

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #30 from Arthur Suzuki  ---
Goeie avond Marcel,
inderdaat, the change also impact C4/Reserves.
Although I noticed the bug while using ILSDI, operations from OPAC and Staff
interface are also impacted.
And I think its better to have as much coherences between all interfaces, hence
my modification in C4/Reserves.
I will modify the tests and the title in consequences :)
Mvg,
Arthur

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104264|0   |1
is obsolete||

--- Comment #36 from Katrin Fischer  ---
Created attachment 106559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106559&action=edit
Bug 23070: Pass no_triggers => 1 to Koha::Objects->update

To make sure we will update all the objects in one go (and no trigger
the ->set->store from Koha::Object->update)

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104261|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer  ---
Created attachment 106556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106556&action=edit
Bug 23070: Use Koha::Hold in C4::Reserves::RevertWaitingStatus

We are using raw SQL statements, we should use Koha::Hold instead.

This patch does not seem optimal, we would like to increment priority in
only 1 statement and without the need to fetch and loop all holds.

== Test plan ==
- apply patch
- place some holds on the same record
- check that the priorities look good
- mark one hold as waiting by doing a check-in
- revert the waiting status
- confirm that the priorities are recalculated correctly

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104262|0   |1
is obsolete||

--- Comment #34 from Katrin Fischer  ---
Created attachment 106557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106557&action=edit
Bug 23070: Add tests

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104263|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 106558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106558&action=edit
Bug 23070: Increment all priorities in 1 query

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #31 from Katrin Fischer  ---
Oh also: Please write up the addition to the REST API:
https://wiki.koha-community.org/wiki/REST_api_RFCs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

--- Comment #30 from Katrin Fischer  ---
Created attachment 106555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106555&action=edit
Bug 23019: (QA follow-up) Fix typo Pre fill

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer  ---
This works, but I feel the GUI is not very intuitive. Actually, it took me a
while to figure it out. 

The profile is "started" at the top of the page, but then after making your
settings, you have to make sure to hit "Update profile" for the settings to be
saved. So the workflow is like this to add a profile for it to work:

1) Enter a name for a profile, click on add
2) Make the settings you want
3) DONT CLICK IMPORT - or your profile will save with the wrong values
4) Go back up, click "Update profile"
5) Import

I got it wrong the first time and was very confused why the "wrong" values
showed up on managing the staged import. 

If a profile was selected, values can be changed. After importing it's not
clear what was used for the import - the values from the profile or those set
(and not saved in the profile) of the form? The profile values will show.

I really believe we need to improve this a bit before including it.

Ideas:

- Remove the buttons from the profile on top of the form and only show the list
of existing profiles there.
- If a profile is selected, change the values in the form below.
- When one of the settings is changed, show a hint behind the field.
- When importing:
  - when profile is used and no field was changed: import
  - when no profile was used: import
  - when profile was used and values changed: ask if the profile or the changed
values should be used (and possibly if the existing profile should be updated)
- At the end of the form offer to save the settings as a new profile or update
the existing one. This way, you can start at the top and work your way down.


Alternatively: 
- Allow creating, updating and deleting profiles from a different configuration
screen. 
- When a profile is selected, disable the other form fields so it's an "either
or" and it's always clear what will be applied for the import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25929] New: create_analytical_rel.pl don't sets host biblionumber

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25929

Bug ID: 25929
   Summary: create_analytical_rel.pl don't sets host biblionumber
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: verolenci...@yahoo.com.ar
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

The command-line utility create_analytical_rel.pl creates links to the host
item from the barcode in 773$o of the analytical record. It should copy some
data from the host record and the host item but it fails to copy the
Biblionumber from the host record to 773$0 and copies instead the Biblionumber
of the analytical record.
In consequence the analytical record shows up in the host item (because Host
Itemnumber was correctly copied) but in the analytical record itself there is
no direct link to the host item that could show itemtype, circulation status,
homebranch, etc.

How to reproduce the bug.
1. Create an analytical record with $773$o that references a real
barcode in the system.
2. Run create_analytical_rel.pl. 
3. Now some fields have been populated in the 773 field, but the $0 subfield
(Host Biblionumber) shows the Biblionumber of the analytical record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22890] Add a chronological changelog

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Katrin Fischer  ---
It appears to work mostly ok, but there are some glitches:

- Formatting (indentation!) appears a little off. 
- We also need to make sure that HTML tags in the bug descriptions don't get
parsed (see bug 23915 at the bottom of 20.05 change log)

But from the comments I am not sure if this is really ready for the QA step
yet?
How to make sure this is updated with the releases?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25928] xt/find-license-problems.t should ignore release-tools

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25928

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #119 from Katrin Fischer  ---
I really like the suggested solution with the mandatory flag on the patron
attribute configuration page - it fits really well there with the other things.
I'd like to see this new feature advertised a bit more for the release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103966|0   |1
is obsolete||

--- Comment #115 from Katrin Fischer  ---
Created attachment 106551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106551&action=edit
Bug 22844: DBIC Schema changes

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103967|0   |1
is obsolete||

--- Comment #116 from Katrin Fischer  ---
Created attachment 106552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106552&action=edit
Bug 22844: Add is_boolean flag for new 'mandatory' column

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103969|0   |1
is obsolete||

--- Comment #118 from Katrin Fischer  ---
Created attachment 106554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106554&action=edit
Bug 22844: Remove 'separate columns with |' from prefs description

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103968|0   |1
is obsolete||

--- Comment #117 from Katrin Fischer  ---
Created attachment 106553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106553&action=edit
Bug 22844: Make the patron's attribute mandatory at the OPAC

Test plan:
- Set 1+ patron's attribute(s) mandatory
- Use the self-registration feature and confirm that you cannot selfreg
if the attribute has no value (or empty string)
- Same with the modification form (logged in)

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103965|0   |1
is obsolete||

--- Comment #114 from Katrin Fischer  ---
Created attachment 106550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106550&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103962|0   |1
is obsolete||

--- Comment #111 from Katrin Fischer  ---
Created attachment 106547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106547&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103963|0   |1
is obsolete||

--- Comment #112 from Katrin Fischer  ---
Created attachment 106548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106548&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103964|0   |1
is obsolete||

--- Comment #113 from Katrin Fischer  ---
Created attachment 106549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106549&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind 

Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103960|0   |1
is obsolete||

--- Comment #109 from Katrin Fischer  ---
Created attachment 106545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106545&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

== Test plan ==
 - apply the patches
 - regenerate the staff client CSS (yarn build)
 - updatedatabase
 - dbic
 - flush_memcached
 - restart_all to make sure the updated .pref file is used

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
 preferences, confirming that the right data is preselected each
 time the modal is shown and the right data is saved to the right
 field each time.

Signed-off-by: Hayley Mapley 

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103961|0   |1
is obsolete||

--- Comment #110 from Katrin Fischer  ---
Created attachment 106546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106546&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98733|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 106542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106542&action=edit
Bug 22773: The deprecated plugin is removed

Signed-off-by: Kelly McElligott 

Signed-off-by: Christopher Kellermeyer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #32 from Katrin Fischer  ---
Created attachment 106543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106543&action=edit
Bug 22773: (QA follow-up) Improve existing merge button and fix checkbox label

Fixes the checkbox label by adding an id, so that when you click on
"Show only subscriptons" the checkbox will be checked.

Adds standard classes to the existing "Merge selected invoices" button
to make things more consistent. Also added the fa-compress icon that
we use in cataloguing on the merge records button.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98731|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 106540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106540&action=edit
Bug 22773: Message appearing if any invoice selected

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #33 from Katrin Fischer  ---
Created attachment 106544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106544&action=edit
Bug 22773: (QA follow-up) Fix missing filters

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98732|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 106541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106541&action=edit
Bug 22773: (follow-up) Recommended changes are made on datatable and butons

Signed-off-by: Kelly McElligott 

Signed-off-by: Christopher Kellermeyer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98730|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 106539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106539&action=edit
Bug 22773: (follow-up) Fix capitalization

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #98729|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 106538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106538&action=edit
Bug 22773: Bulk Close invoices and Filter invoice view (open/closed)

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Kelly McElligott 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773

--- Comment #26 from Katrin Fischer  ---
I've tested merging invoices from 2 different tabs and it worked nicely. I did
2 follow-ups for some cosmetics (the label on the subscription limit and the
buttons). Ready to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0

2020-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

Katrin Fischer  changed:

   What|Removed |Added

Summary|Borrowers Login Attempts|Borrowers login attempts
   |happen to be NULL instead   |happen to be NULL instead
   |of 0|of 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/