[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106641|0   |1
is obsolete||

--- Comment #14 from Alex Arnaud  ---
Created attachment 106762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106762&action=edit
Bug 23797: (follow-up) Enable OpacLoginInstructions in header

The OpacLoginInstructions information should be available in the login
modal which is displayed when the login link in the header menu is
clicked.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106640|0   |1
is obsolete||

--- Comment #13 from Alex Arnaud  ---
Created attachment 106761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106761&action=edit
Bug 23797: (follow-up) Increase the size of opac_news.lang

This patch adds a database update to increase the size of the
opac_news.lang column in order to accommodate longer values.

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 Attachment #106639|0   |1
is obsolete||

--- Comment #12 from Alex Arnaud  ---
Created attachment 106760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106760&action=edit
Bug 23797: Convert OpacLoginInstructions system preference to news block

This patch builds on Bug 22318 to move the OpacLoginInstructions system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the OpacLoginInstructions system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and click the login link.
 - In the login modal, confirm that the content which was previously in
   the OpacLoginInstructions system preference displays correctly
   below the login form.
 - While not logged in to the OPAC, navigate directly to
   /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should
   display correctly here as well.
 - In the staff client, go to Tools -> News and verify that the content
   from OpacLoginInstructions is now stored in news items. There
   should be one entry for each of the enabled translations in your
   system, for instance 'OpacLoginInstructions_en',
   'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   OpacLoginInstructions preference has been removed.
 - To test the correct selection of language-specific content you must
   run the translation update/install process for the languages you're
   updating.

Signed-off-by: Sally 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #106722|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 106763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106763&action=edit
Bug 25950: Remove  in X-Forwarded-For from proxy tests

This patch removes the  ip address in the X-Forwarded-For
header from being tested against koha_trusted_proxies.

Without this patch, REMOTE_ADDR will be set to null, if the 
ip address matches against koha_trusted_proxies.

To Test:
1. Run the unit test t/Koha/Middleware/RealIP.t

Signed-off-by: Didier Gautheron 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Martin Renvoize  ---
This works as expected and I can't see any regressions.. admittedly this isn't
my area of expertise but the code appears to be sound and the description makes
sense.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25877] [19.11] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877

--- Comment #10 from Alex Arnaud  ---
(In reply to Kyle M Hall from comment #9)

> I think that would make a good bug report on its own. If no libraries are
> set as pickup locations, it makes sense to me to hide the holds tab
> altogether, or at the very least, disallow holds to be placed so long as
> there are no pickup locations.

Why not just keep the "libraryNotPickupLocation" red message in this case ?
IMO that could be done more quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5489] Send hold email to branch email address if it exists instead of koha email address

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489

Faiz Ahmed  changed:

   What|Removed |Added

 CC||faiz.ah...@habib.edu.pk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25973] New: Koha Admin Email

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25973

Bug ID: 25973
   Summary: Koha Admin Email
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: faiz.ah...@habib.edu.pk
QA Contact: testo...@bugs.koha-community.org

Hi,
I've installed Postfix successfully, 
Enable Koha email notifications through following command in terminal

sudo koha-email-enable library

Its all working fine till this step.

Now, In Koha I've setup notices for check ins, checkouts, advance due date etc.
& wrote my library's email address i.e. libr...@habib.edu.pk in Koha
Administration -> Global System Preferences -> Administration ->
KohaAdminEmailAddress.

But the issue is, Patrons are receiving the email notifications from the gmail
account which I used at the Postfix installation procedure.

Why Koha is not using the KohaAdminEmailAddress to send the notofications to
patrons?

Need suggestions.

Faiz Ahmed,
Assistant Manager
Digital Learning Services
Habib University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407

--- Comment #16 from Julian Maurice  ---
(In reply to David Cook from comment #15)
> If it doesn't die, what happens if you want to add a check to that object?
> Maybe you only want to return the guarantor under certain conditions. It
> probably makes sense to add that check here rather than in every caller of
> this method. To do that, you'd have to refactor to use the syntax I
> described anyway. Or maybe you're doing some debugging because the guarantor
> being returned isn't correct. You can't add any logging in this code unless
> you refactor to the syntax I described.

In my opinion "maybe we will want to add something here" is not a good reason
to refactor code. If that "maybe" ever comes true, then you can refactor the
code while making the change. No need to do it now.

Note that I also tend to prefer your version, but I'm happy with both.
If it ain't broke don't fix it ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24157] Additional acquisitions permissions

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com
 QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #117 from Michal Denar  ---
Hi Bouzid,
any progress with this bug? We're ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25964] Data loss possible when items are modified

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964

Martin Renvoize  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25964] Data loss possible when items are modified

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #106752|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 106765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106765&action=edit
Bug 25964: Prevent data loss when editing items from a MARC record

Coming from:
  Bug 23463: Use new method Koha::Object->set_or_blank

We have DB fields that are not mapped with MARC fields, for instance paidfor.
They are not handled correctly.

In ModItemFromMarc, we get a MARC record in parameter and update the item in
DB. But we are loosing the fields that are not in the MARC record

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25964] Data loss possible when items are modified

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25964] Data loss possible when items are modified

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25964

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Martin Renvoize  ---
I'm comfortable that this patch fixes the issue and I'm not seeing any obvious
regressions... Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24157] Additional acquisitions permissions

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

--- Comment #19 from Alex Arnaud  ---
I think the third commit "Add new method Acq::Invoice::Adjustement->fund" is
not the right place here. Right ?
I don't see any use of it and no old code removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #106611|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 106766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106766&action=edit
Bug 25940: Check for reserve_id before Dopop

TEST PLAN:
1. Have an item belonging to a different branch and check it in.
2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if 
AutomaticItemReturn is set to 'don't'
3. The first print dialog should appear with a URL like
'/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&&branchcode=CPL&op=slip'
4. Close that print dialog and you will immediately see another one that says
'No slip template found'.
5. Notice the URL of the second pop-up is: 
/cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id=
6. There is no reserve id so the template is not found.
7. Apply patch
8. Repeat 1-6
9. You should no longer have two print dialogs

Signed-off-by: Lisette Scheer 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24157] Additional acquisitions permissions

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Alex Arnaud  ---
Blocker:

I still see the "Merge selected invoices" button in invoices list if i don't
have the "edit_invoices" permission.
So i can select invoices, click on it, but i get an empty invoice form and
merge is not done.

So IMO there is two options:

1) i can see the merge option and the merge should be done,
2) i can't see the merge option and the checkboxes if i don't have the
"edit_invoices" permission.

Questioning: should we assume that merging is editing and deleting ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #118 from Bouzid Fergani  ---
Hi Michal,
Thanks, next week I will working for fixing all issues.
Bouzid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

--- Comment #31 from Martin Renvoize  ---
Created attachment 106767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106767&action=edit
Bug 19036: (QA follow-up) Fix test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Martin Renvoize  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

--- Comment #32 from Martin Renvoize  ---
(In reply to Katrin Fischer from comment #30)
> The test file this also changes is currently failing for me on master:
> 
> kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
> t/db_dependent/Koha/Account.t
> t/db_dependent/Koha/Account.t .. 1/12 Use of uninitialized value in numeric
> lt (<) at /home/vagrant/kohaclone/Koha/Account/Line.pm line 745.
> t/db_dependent/Koha/Account.t .. 3/12
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Cannot add or update a child row: a foreign key constraint
> fails (`koha_kohadev`.`accountlines`, CONSTRAINT
> `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES
> `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT
> INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`,
> `branchcode`, `date`, `debit_type_code`, `description`, `interface`,
> `issue_id`, `itemnumber`, `manager_id`, `note`, `payment_type`, `timestamp`)
> VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp )"
> with ParamValues: 0=5, 1=5, 2=199, 3='dgj1I5', 4='failure', 5='type
> validation failure', 6='commandline', 7=undef, 8=undef, 9=199, 10='this
> should fail anyway', 11=undef] at /home/vagrant/kohaclone/Koha/Object.pm
> line 166
> t/db_dependent/Koha/Account.t .. 13/12 # Looks like you planned 12 tests but
> ran 13.
> t/db_dependent/Koha/Account.t .. Dubious, test returned 255 (wstat 65280,
> 0xff00)
> All 12 subtests passed 
> 
> Test Summary Report
> ---
> t/db_dependent/Koha/Account.t (Wstat: 65280 Tests: 13 Failed: 1)
>   Failed test:  13
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 12 tests but ran 13.
> Files=1, Tests=13,  8 wallclock secs ( 0.05 usr  0.02 sys +  6.85 cusr  0.92
> csys =  7.84 CPU)
> Result: FAIL
> 
> Moving this to BLOCKED until this is resolved to then continue here.

I think you missed the DB update... The test passes both on master and with
this bug for me (though the test plan was out by one, which I've corrected with
a follow-up).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

--- Comment #5 from Martin Renvoize  ---
The logic here doesn't feel right to me I'm afraid.

I've worked hard in recent releases to improve the consistency of our accounts
records.. taking the 'double-entry accounting' approach.

In such an approach accountlines, once set, should not be altered and instead,
all alterations/updates should be recorded as additional lines and offset
against the original.  The exception to that rule is where the final amount is
not yet set when the line is initially created (the only case so far is fines
where we have accruing fines which are updated via the 'adjust' method).

I was intending to eventually update the void method to prevent it from
updating the original payment line as losing that detail in the line itself can
be a red flag when accountants come to audit the system.

Could we perhaps either update VOID to allow voiding of charges and apply a
similar treatment here.. or utilise the 'reduce' method I added recently?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9589] Authorities to authorities linker

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9589] Authorities to authorities linker

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589

--- Comment #2 from Michal Denar  ---
Still wanted :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25973] Koha Admin Email

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25973

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030

Nick Clemens  changed:

   What|Removed |Added

Summary|IncludeSeeFromInSearches|IncludeSeeFromInSearches
   |not honoured|not honoured in
   ||Elasticsearch
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968

Owen Leonard  changed:

   What|Removed |Added

Version|19.11   |master
  Component|Tools   |Templates
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

--- Comment #32 from Nick Clemens  ---
Created attachment 106768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106768&action=edit
Bug 24807: (follow-up) Add support for spaces as unknown characters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968

--- Comment #1 from Owen Leonard  ---
Created attachment 106769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106769&action=edit
Bug 25968: Make logs sort by date descending as a default

This patch adds DataTables with columns configuration to the log viewer.
The table of log entries is now sorted by default by date descending.

To test, apply the patch and go to Administration -> Table settings.

 - Expand the "Tools" section and confirm that there is a section for
   "logviewer."
 - Go to Tools -> Log viewer.
 - Perform a search which will return multiple results.
 - Confirm that the results are sorted by date descending.
 - Test that the table controls work correctly: Paging, columns, export.
 - Return to the Table settings administration page and test that
   changes to those settings are correctly reflected in the log viewer
   table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25972] SIP2 server doesn't have a TLS/SSL-enabled listener

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25972

--- Comment #1 from Colin Campbell  ---
SIP2 predates SSL - In the log in process there is a field to indicate what
encryption is used but no specified values. To my knowledge no supplier of SIP
devices is currently offering SSL at the client end. 
The Net::Server module used to handle the comms end does have SSL support so it
 should be possible to do this without too much effort.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #32 from Alex Arnaud  ---
I agree with the fact that the translate script should behave the same way than
before. But i think it's not possible.

I think of people that will upgrade with the gulp feature and surprisingly note
that the script no longer works for create or update if they didn't install the
gulp-cli / yarn command.

My feeling is that we should have the command ./translate create|update telling
the user: "Creating or updating po process has changed, please use it the way
" 

Bernardo, Katrin any thoughts ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

--- Comment #33 from Alex Arnaud  ---
Also, i have concerns about the .pot generated. They are no longer cleaned now.
Do we need these .pot files actually ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25974] New: Remove inline style from columns settings administration page

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974

Bug ID: 25974
   Summary: Remove inline style from columns settings
administration page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: alex.arn...@biblibre.com,
jonathan.dru...@bugs.koha-community.org,
mark.gavil...@ptfs-europe.com
Depends on: 24156

Bug 24156 added some inline styles to columns_settings.tt which seem out of
place. I'd prefer to remove the inline style and add some subtler CSS to the
page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156
[Bug 24156] Basket - Make sort order and number of items to display
configurable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25974


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974
[Bug 25974] Remove inline style from columns settings administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25974] Remove inline style from table settings administration page

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974

Owen Leonard  changed:

   What|Removed |Added

Summary|Remove inline style from|Remove inline style from
   |columns settings|table settings
   |administration page |administration page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25974] Remove inline style from table settings administration page

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25974] Remove inline style from table settings administration page

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974

--- Comment #1 from Owen Leonard  ---
Created attachment 106770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106770&action=edit
Bug 25974: Remove inline style from table settings administration page

This patch removes an inline style attribute from the table settings
administration template. A different style is added to the page's

[Koha-bugs] [Bug 25447] Terminology: Fix button text "Edit biblio"

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25447

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25447] Terminology: Fix button text "Edit biblio"

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25447

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25553] Edit item date sort does not sort correctly

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25553

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #11 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25769] Patron self modification triggers change request for date of birth to null

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25769

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #11 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25975] New: Receiving a manual transfer triggers another transfer (non-floating collection)

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25975

Bug ID: 25975
   Summary: Receiving a manual transfer triggers another transfer
(non-floating collection)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I'm putting this out there, I'm not sure if the use case is something that
would work in all libraries or if I'm completely beside the point...

If the circulation rules are set to 'item returns home' and you do a manual
transfer (for whatever reason, like that library needed that book for a display
or something), when the other library receives the transfer, it is
automatically put back in transit to go back to its home library. Which is kind
of logical, but not? Why would you do a manual transfer if it's just to be sent
back?

I can see several use cases for this, outside of a floating collection
situation:
1) special display
A library wants to make a special display and asks the other libraries to send
some material over. This system does not have a floating collection policy, but
they still exchange materials depending on needs (e.g. holds). If the other
libraries send 'manual' transfers, the library making the special display
receives them by checking them in (this currently triggers a transfer back to
the home library), puts them on display. If a user checks them out and then
returns them, the transfer to home branch will be triggered. If no users check
them out after the end of the display, the library can send them back by
checking them in.

2) temporary high demand
A school board loans out textbooks at the beginning of each year. Some schools
have more students than others so they ask other libraries to send their
surplus of textbooks over to satisfy the demand. Again, no floating policy for
general circulation. The smaller libraries send their surplus textbooks via
'manual' transfers, the larger library receives the transfers by checking them
in (this currently triggers a transfer back to home branch). They check them
out to students who haven't had their textbooks yet. When the students bring
back the textbooks, the check in triggers a transfer back to the home library.
If the library received more than needed, they can send back the texts to their
home library by checking them in.

3) course reserves
Similar to the two previous cases. A university has a course and needs some
material from other libraries for course reserves.

4) biblio-mobile
Again no floating policy, but during the summer, the library system has a
biblio-bus going to local parks. All libraries temporarily contribute to the
biblio-bus collection, but they want their materials back after.

In all these cases, the collections don't normally float, the materials are
only needed temporarily, and there is not one specific user who requested the
materials through a hold. Are manual transfers not the way to go in these
cases?

I think there are two potential solutions to this :
1) receiving a transfer is either not done through checkin or the checkin to
receive a transfer does not trigger another transfer (if there is an unreceived
'manual' branch transfer, and the item is checked in at the destination
library, do not send back home)
2) add a 'cancel transfer' button to the transfer dialog (when the destination
library receives the transfer through a checkin, a transfer back home is
triggered, but the receiving library could cancel the transfer in order to keep
the item). Right now, you can only click 'OK' or 'Print slip'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12093] Add CSS classes to item statuses in detail view

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #20 from Lucas Gass  ---
backported to 20.05.x for 20.05.02 along with bz25804

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25804] Remove HTML from title tag of bibliographic detail page

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25804

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25570] Listing requests should be paginated by default

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #16 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106758|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 106771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106771&action=edit
Bug 25969: Checking in a found hold at a different branch then confirming the
hold causes internal server error

If a record level hold is filled and waiting at Library A, and the item
is checked in at Library B, and an attempt is made to re-fill the hold
with the item, Koha will return an ISE.

Test Plan:
1) Place a hold for Library A, at Library A, for pickup at Library A
2) Check in the item at Library A and fill the hold so it is waiting at Library
A
3) Log in as Library B, check in the same barcode
4) Note the request to fill the hold with the item
5) Choose to fill the hold
6) Note you get an internal server error
7) Apply this patch
8) Restart all the things!
9) Repeat steps 1-5
10) No ISE!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #12 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #17 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #28 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

--- Comment #6 from Martin Renvoize  ---
Created attachment 106772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106772&action=edit
Bug 24603: (follow-up) Update to double entry accounting

This patch updates the logic to create a cancellation accountline and
apply it to the charge line so we correction record the transaction in
terms of double entry accounting standards.

Test plan:
1. Go to a patron's accounting section
2. Create a manual invoice
3. In Transactions tab, you should see a 'Cancel charge' button. Click
   on it. It should now be marked as cancelled
4. A cancellation line should be associated with the original charge.
5. Create another manual invoice
6. Pay it (partially or fully)
7. Notice that the 'Cancel charge' button is not available
8. Void the payment
9. 'Cancel charge' button is available again. Click on it and verify
   that it still works
10. prove t/db_dependent/Koha/Account/Lines.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25611] Changing the vendor when creating the basket does not keep that new vendor

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25756] Empty HTML table row after OPAC "Appearance" preferences

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25756

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|14825   |17596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client [OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24603   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603
[Bug 24603] Allow to cancel charges in patron accounting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17596] Simplify accounting UI in staff client [OMNIBUS]

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24603


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603
[Bug 24603] Allow to cancel charges in patron accounting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976
[Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] New: Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Bug ID: 25976
   Summary: Add 'Writeoff' button under Transactions tab in patron
accounting
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: josef.mora...@gmail.com, j...@bywatersolutions.com,
julian.maur...@biblibre.com,
k...@bywatersolutions.com, lu...@bywatersolutions.com,
martin.renvo...@ptfs-europe.com
Blocks: 24079

Nearly all over actions are now available via the transactions page directly..
we should add write-off to complete the set.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|24079   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24079


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24604, 25976|17734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604
[Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976
[Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|24079   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24604, 25976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604
[Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976
[Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|17735   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735
[Bug 17735] Merge boraccount and pay pages into one
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|17734   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #58174|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #58175|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|24079   |

--- Comment #16 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 24079 ***


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|17734   |
 CC||josef.mora...@gmail.com

--- Comment #1 from Martin Renvoize  ---
*** Bug 17734 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24604, 25976|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604
[Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976
[Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24079


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24604, 25976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604
[Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976
[Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|17734   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25976] Add 'Writeoff' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|17734   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734
[Bug 17734] Make possible to pay and writeoff from boraccount page and make
action buttons split button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24079


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24822] Add discount processing to paycollect

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||24079


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079
[Bug 24079] Convert paycollect 'page' to a modal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25789] New expiration date on placing a hold in staff interface can be set to a date in the past

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25789

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822
[Bug 24822] Add discount processing to paycollect
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25747] Don't display a comma when patron has no firstname

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25699] Add edition information to Holds to pull report

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
useful enhancement, choosing to backport

backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25471] Add DataTables to MARC subfield structure admin page for bibliographic frameworks

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25471

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Choosing to backport enhancement

backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

--- Comment #30 from Martin Renvoize  ---
Created attachment 106773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106773&action=edit
Bug 22393: (QA follow-up) Typos and Filters

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25977] New: Koha Offline Circulation tool to handle trigger for sending necessary notices after successful .koc upload

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25977

Bug ID: 25977
   Summary: Koha Offline Circulation tool to handle trigger for
sending necessary notices after successful .koc upload
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tgoat...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The Koha Offline Circulation tool(s) does not trigger Notices after a
successful .koc file upload.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

--- Comment #7 from Martin Renvoize  ---
Setting back to NSO to get Julians take on my follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25402] Put OPAC cart download options into dropdown menu

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #10 from Lucas Gass  ---
choosing to backport enhancement 


backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.02
released in||

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #14 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
This patch fails the QA script for me:

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   FAIL   forbidden patterns
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 105)


Which I do not understand because that line does include the aria-hidden
attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Lucas Gass  ---
I don't see how the QA script failure could be a problem, I am backporting this
anyway since it improves accessibility.

backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25151] Accessibility: The 'Your cart' page does not contain a level-one header

2020-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
backported to 20.05.x for 20.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >