[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #62 from David Cook --- (In reply to Jonathan Druart from comment #61) > In my understanding they are an alternative approach. QA will pick one or > the other. Yep, that was my intention when I wrote those [Alternative] patches. I think they're a better alternative, but I'm biased as the author of them ;). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24031] Add plugin hook after_hold_create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #20 from Julian Maurice --- (In reply to Jonathan Druart from comment #19) > Julian, can you have a look at bug 26063 and tell us if it's what you had in > mind with Koha::Plugins->call please? This is exactly what I had in mind :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #27 from Jonathan Druart --- Reported on the ML for "branches" https://lists.katipo.co.nz/pipermail/koha/2020-July/054967.html The solution was to replace the row_format's value with "Dynamic" (this is the default value). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25999] Renewal due date not being honoured for items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Depends on||7088 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|19.11 |master --- Comment #1 from Jonathan Druart --- Confirmed on master. Andrew, can you have a look please? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 [Bug 7088] Cannot renew items on hold even with override -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Jonathan Druart changed: What|Removed |Added Blocks||25999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 [Bug 25999] Renewal due date not being honoured for items with holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25999] Renewal due date not being honoured for items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999
--- Comment #2 from Jonathan Druart
---
Only one value is passed to the renew script:
+// Determine which due date we need to use
+var dueDate = isOnReserve ?
+$("#newonholdduedate input").val() :
+$("#newduedate").val();
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26007] Warning/ reminder for changes to Koha to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Cab, which exact text would you like to be displayed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Joonas Kylmälä --- Thanks for the commit message fix, Kyle! I was about to pass QA for this... But then I ended up with this error on my last test: DBIx::Class::Storage::DBI::_dbh_execute(): Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause at /kohadevbox/koha/members/paycollect.pl line 157 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Without the patch provided here the error doesn't happen. How to reproduce: 0) Apply patch provided in this bug report & restart plack 1) Have RoundFinesAtPayment = No (not sure this is relevant though) 2) Create 3 manual invoices with the amount of 3.33 3) Make a payment > write off selected 4) The error should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26096] New: Brother
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26096 Bug ID: 26096 Summary: Brother Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bintangcassanova6...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107560&action=edit Hay gays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart changed: What|Removed |Added Attachment #107498|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 107561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107561&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Jonathan Druart changed: What|Removed |Added Attachment #107561|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 107562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107562&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913
--- Comment #2 from Jonathan Druart
---
Created attachment 107563
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107563&action=edit
Bug 25913: Prevent get_coins to crash if record does not have title
If a bibliographic record does not have a title, get_coins will crash
with
Can't call method "as_string" on an undefined value at
/kohadevbox/koha/Koha/Biblio.pm line 645
Koha::Biblio::get_coins('Koha::Biblio=HASH(0x5558f91bb740)') called at
/kohadevbox/koha/catalogue/ISBDdetail.pl line 144
We can handle that situation easily by checking the existence of the
title field.
Test plan:
1. Create a record without 245
2. Enable COinSinOpac
4. Go to the ISBD detail view
=> It must not fail with this patch applied
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Nick Clemens from comment #0) > In opac search results we call get_coins in an eval so it can load, on other > scripts we don't We surround it by an eval in detail.pl to deal with encoding problems, what we don't on other views. I think this patch deals correctly with the problem you reported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25999] Renewal due date not being honoured for items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25999 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25913] Internal server error when calling get_coins on record with no title (245) but with 880 linked to 245
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25913 --- Comment #4 from Jonathan Druart --- Nick, don't forget to copy the error message when a 500 is reported :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 Joenvano changed: What|Removed |Added CC||funsar...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26097] New: Thanks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26097 Bug ID: 26097 Summary: Thanks Change sponsored?: --- Product: Koha Version: master Hardware: HP OS: Windows Status: NEW Severity: blocker Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: funsar...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107565&action=edit Touched -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887 --- Comment #1 from Jonathan Druart --- Created attachment 107564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107564&action=edit Bug 25887: Keep library filter on the fund list view The problem: When filtering funds by library, the pull down for libraries resets to "empty" when the page is reloaded, although the filter criteria is visible in the URL. Test plan: Create a fund for library A Create a fund for library B Go to the fund list view => All funds are listed Select library A in the library filter, click "Go" => Funds for library A are listed => Library filter has "library A" selected Edit fund for library B => The edit form has "library B" selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] New: JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Bug ID: 26098 Summary: JS error on the fund list view if no fund displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org To recreate, go to the fund list view, select a filter that will return no result. A JS error is displayed in the console: TypeError: this.data(...) is undefined coming from jquery.treetable.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 --- Comment #1 from Jonathan Druart --- Created attachment 107566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107566&action=edit Bug 26098: Fix JS error on the fund list view when no fund displayed TypeError: this.data(...) is undefined in jquery.treetable.js Test plan: Go to the fund list view Select a filter that will return no result => With this patch applied there is no JS error in the console -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26098 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25887 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26099] New: Bjir:v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26099 Bug ID: 26099 Summary: Bjir:v Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: dr.frm...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107567&action=edit Bjir :v -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26100] New: Im SORY admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26100 Bug ID: 26100 Summary: Im SORY admin Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: reyhangaul...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107568&action=edit IM SORY ADMIN -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25878] Schema incorrectly describes course_items fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25878 Jonathan Druart changed: What|Removed |Added Severity|normal |minor CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26101] New: return option show in one way type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26101 Bug ID: 26101 Summary: return option show in one way type Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: shitalkachav...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107569&action=edit this file is refer for a bug do not show the return option in one way type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26101] return option show in one way type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26101 Shital changed: What|Removed |Added CC||shitalkachav...@gmail.com Deadline||2020-07-31 URL||http://demo.guru99.com/test ||/newtours/index.php Orig. Est.|0.00|24.00 Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26103] New: P
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26103 Bug ID: 26103 Summary: P Change sponsored?: --- Product: Koha Version: master Hardware: HP OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: t4mpangamin...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107570&action=edit Touched -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|cnighswon...@foundations.ed |jonathan.dru...@bugs.koha-c |u |ommunity.org Version|19.11 |master Severity|minor |major CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 --- Comment #1 from Jonathan Druart --- Created attachment 107571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107571&action=edit Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 --- Comment #2 from Jonathan Druart --- Created attachment 107572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107572&action=edit Bug 25852: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26096] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26096 Katrin Fischer changed: What|Removed |Added Summary|Brother |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26097] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26097 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Summary|Thanks |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26099] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26099 Katrin Fischer changed: What|Removed |Added Summary|Bjir:v |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26100] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26100 Katrin Fischer changed: What|Removed |Added Summary|Im SORY admin |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26103] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26103 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|P |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26101] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26101 Katrin Fischer changed: What|Removed |Added Summary|return option show in one |SPAM |way type| Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26061] Improve style of sidebar datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #5 from Owen Leonard --- (In reply to Katrin Fischer from comment #4) > I think this is a good improvement, but I wonder if those date fields > wouldn't look a little nicer if they were even a little shorter The date fields in the sidebar are different than elsewhere because all form fields in the sidebar are styled to be the same width. I think this consistency looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 ByWater Sandboxes changed: What|Removed |Added Attachment #107571|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 107573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107573&action=edit Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25852] If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 ByWater Sandboxes changed: What|Removed |Added Attachment #107572|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 107574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107574&action=edit Bug 25852: Add tests Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Kelly McElligott --- I am using Update Existing Field as the action, this is not working as expected. If a Marc Record has a 521$b already in the record, and I use the action to add a 521$a, this process is not placing the $a before the $b in the final record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12709] Send a custom email to some or all patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24580 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 --- Comment #2 from Owen Leonard --- Created attachment 107575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107575&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid - Move heading inside container so that floats clear correctly - Change tag back to to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24580] Allow patron_emailer or parallel structure to generate custom print notices from report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12709 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #38 from Nick Clemens --- Created attachment 107577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107577&action=edit Bug 18958: Unit tests Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Nick Clemens changed: What|Removed |Added Attachment #93216|0 |1 is obsolete|| Attachment #93217|0 |1 is obsolete|| Attachment #93218|0 |1 is obsolete|| --- Comment #37 from Nick Clemens --- Created attachment 107576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107576&action=edit Bug 18958: Make check reserves find in transit holds To test: Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places two record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. The problem seems to be that we use GetOtherReserves to initiate transfers for holds This routine calls CheckReserves to see what holds are on the record. We have an implicit assumption here that anything matching the holds queue is the correct hold. This worked when we couldn't have multiple holds on a record, but now it can end up with false positive. The solution seems to be returning the in-transit hold before returning a second hold on the record to make sure we affect the correct reserve. Test Plan: 1 - Create and use a patron that can place multiple record level holds per record 2 - Create a record with X items, each at a different library 3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4 - perl misc/cronjobs/holds/build_holdsqueue.pl 5 - Check in LibraryA's copy as LibraryA and confirm the hold 6 - Revisit request.pl for the record, notice the next hold in line is now item-specific 7 - Checkout the item to the patron, notice the remaining hold is marked waiting 8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold 8 - Apply this patch 9 - Repeat steps 1-5 10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific 11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level 12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #39 from Nick Clemens --- (In reply to Marcel de Rooy from comment #36) > (In reply to Marcel de Rooy from comment #15) > > Failing QA because this patch has side-effects when you cancel a hold from > > the confirm hold popup. Before we called GetOtherReserves and now we dont. > I obsoleted Kyle's patch in favor of mine - I think I was confused before and added mine when I meant to replace Kyle's patch attempted to prevent the call to GetOtherReserves to fix the problem My patch alters _Findgroupreserves to find the correct hold which should fix the call to GetOtherReserves (GetOtherReserves calls CheckReserves call _Findgroupreserves) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #107575|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 107578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107578&action=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid - Move heading inside container so that floats clear correctly - Change tag back to to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26104] New: Indramayu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26104 Bug ID: 26104 Summary: Indramayu Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: popopraset...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107580&action=edit Jangan ganggu saya dan keluarga saya Subscribe woee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26090] Catalog by itemtype report fails if SQL strict mode is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26090 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #40 from Nick Clemens --- Created attachment 107582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107582&action=edit Bug 18958: (follow-up) Also find waiting holds for the current item/patron In the first patch we deal with the situation where the pickup location doesn't match the checked in location This patch takes care fo the situation for holds not being transferred Same test plan, but holds and items can all be for single library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||26090 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26090 [Bug 26090] Catalog by itemtype report fails if SQL strict mode is on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26090] Catalog by itemtype report fails if SQL strict mode is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26090 --- Comment #1 from Jonathan Druart --- Created attachment 107581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107581&action=edit Bug 26090: Fix "item types" report This report was broken with SQL strict mode, but also without. DBD::mysql::st execute failed: 'koha_kohadev.itemtypes.itemtype' isn't in GROUP BY [for Statement " and, if no library was selected: DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in 'field list' [for Statement " This patch does the minimum to make it usable, but it would need more love. Test plan: To test you will need to try the 4 combinaisons: item-level_itypes = item or biblio With or without a library selected in the dropdown list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26090] Catalog by itemtype report fails if SQL strict mode is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26090 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Blocks||17258 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14963 Version|20.05 |master Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 --- Comment #4 from Andrew Fuerste-Henry --- Looks like this bug may also be causing some foreign key constraint errors around branch code when duplicating an existing item and trying to change the home and holding branch. The error goes away when I apply the patch. So nothing more to do here, just noting it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26094 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094 --- Comment #1 from Jonathan Druart --- Created attachment 107583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107583&action=edit Bug 26094: Add class to the "Suggest for purchase" button Bug 14963 added a new "Suggest for purchase" button on the detail page of bibliographic records at the OPAC. This patch adds a specific CSS class to make it reachable easily Like others button in this action list Test plan: Go to the detail page of a bibliographic record at the OPAc Notice the new CSS class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #42 from Kyle M Hall --- Created attachment 107585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107585&action=edit Bug 18958: Unit tests Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Kyle M Hall changed: What|Removed |Added Attachment #107576|0 |1 is obsolete|| Attachment #107577|0 |1 is obsolete|| Attachment #107582|0 |1 is obsolete|| --- Comment #41 from Kyle M Hall --- Created attachment 107584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107584&action=edit Bug 18958: Make check reserves find in transit holds To test: Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places two record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. The problem seems to be that we use GetOtherReserves to initiate transfers for holds This routine calls CheckReserves to see what holds are on the record. We have an implicit assumption here that anything matching the holds queue is the correct hold. This worked when we couldn't have multiple holds on a record, but now it can end up with false positive. The solution seems to be returning the in-transit hold before returning a second hold on the record to make sure we affect the correct reserve. Test Plan: 1 - Create and use a patron that can place multiple record level holds per record 2 - Create a record with X items, each at a different library 3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4 - perl misc/cronjobs/holds/build_holdsqueue.pl 5 - Check in LibraryA's copy as LibraryA and confirm the hold 6 - Revisit request.pl for the record, notice the next hold in line is now item-specific 7 - Checkout the item to the patron, notice the remaining hold is marked waiting 8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold 8 - Apply this patch 9 - Repeat steps 1-5 10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific 11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level 12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #43 from Kyle M Hall --- Created attachment 107586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107586&action=edit Bug 18958: (follow-up) Also find waiting holds for the current item/patron In the first patch we deal with the situation where the pickup location doesn't match the checked in location This patch takes care fo the situation for holds not being transferred Same test plan, but holds and items can all be for single library Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26105] New: Incorrect hold status shown if hold is ignored after transfer to pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26105 Bug ID: 26105 Summary: Incorrect hold status shown if hold is ignored after transfer to pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: - Have an item at Branch A - Place a hold for pickup at Branch B - Check the item in at Branch A, confirm hold and transfer - Confirm request.pl and detail.pl for your bib show item is in transit to Branch B - Confirm circulation.pl and moremember.pl for your patron show item is in transit to Branch B - Check item in at Branch B, click Ignore on the hold popup - Detail.pl shows "There is an item level hold on this item (priority = 0)." -- the expected message for an item with an item-level hold with no Found value - Request.pl shows priority of "In transit" and message of "Item waiting at Branch B since" with no waiting date - Circulation.pl and moremember.pl show no priority or status for this hold - the database shows found=T for this hold To be honest, it's hard to think of a good reason why a library would ignore a hold at the end of its transfer, but this is still confusing and worth addressing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804
--- Comment #2 from Jonathan Druart
---
Created attachment 107588
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107588&action=edit
Bug 20804: Add support for "days" to the timeout syspref
If the timeout syspref did not contain an integer, or was not matching
integer.'d|D', then it "fallback" to 0
We can easily add support for hours and fallback to 600 if the value is
not correct.
It will prevent the session to timeout immediately
Test plan:
0. Do not apply the patches
1. Fill the timeout syspref with "5m"
2. Login
3. Click somewhere
=> Notice that the session timed out
4. Apply the patches, restart_all
5. Login
6. Click somewhere
=> You have 5 minutes to enjoy Koha
7. Fill the pref with an incorrect value ("5x" for instance)
8. Logout, login
9. There is a warning in the log, and you have 10 minutes to enjoy Koha
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20804] Sanitize input of timeout syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20804 --- Comment #1 from Jonathan Druart --- Created attachment 107587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107587&action=edit Bug 20804: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #57 from Jonathan Druart --- *** Bug 20857 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20857] "Orders search" filters overlap the toolbar on the basket view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20857 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- Cannot recreate, certainly fixed by bug 21751. *** This bug has been marked as a duplicate of bug 21751 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24479] POS doesn't follow CurrencyFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- + I think this is not correct, $Price should not be used for hidden inputs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What|Removed |Added Severity|normal |major --- Comment #25 from Fridolin SOMERS --- I rise to Major importance because a lot of libraries look forward to use this new SRU of BNF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 --- Comment #12 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #11) > Thanks for the commit message fix, Kyle! I was about to pass QA for this... > But then I ended up with this error on my last test: > > DBIx::Class::Storage::DBI::_dbh_execute(): Mixing of GROUP columns > (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no > GROUP BY clause at /kohadevbox/koha/members/paycollect.pl line 157 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > > Without the patch provided here the error doesn't happen. How to reproduce: > > 0) Apply patch provided in this bug report & restart plack > 1) Have RoundFinesAtPayment = No (not sure this is relevant though) > 2) Create 3 manual invoices with the amount of 3.33 > 3) Make a payment > write off selected > 4) The error should appear. Interesting, I have no idea why I didn't get this error in my testing! Followup incoming! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Kyle M Hall changed: What|Removed |Added Attachment #107516|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 107589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107589&action=edit Bug 26076: (QA Follow up) Prevent error by using a fresh resultset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Kyle M Hall changed: What|Removed |Added Attachment #107589|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 107590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107590&action=edit Bug 26076: Sum the amount due in the database query instead of a loop in Perl This appears to be a bug due to inaccuracies in floating point math. I've been unable to reproduce it on demand. Sometimes when using the "Write off selected" button, Koha will give the error that the payment is more than the amount owed, even though they are the same. The solution I've implemented is to move the summation from Perl code to the database query. This video demonstrates the issue and afterward, shows the error goes away after the patch is applied: https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE Test Plan: 1) Apply this patch 2) Restart all the things! 3) Verify that "Write off selected" functions as usual Signed-off-by: Amit Gupta -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 --- Comment #15 from Kyle M Hall --- Created attachment 107591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107591&action=edit Bug 26076: (QA Follow up) Prevent error by using a fresh resultset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #15 from Kyle M Hall --- (In reply to Lari Taskula from comment #14) > This would be really really really useful. The permission bits are one big > headache because features introducing new ones will conflict with one > another. > > And what about Koha plugins? Can they currently even add custom permission > modules without eventually conflicting the bit value? > > +1 to this Bug I ran out of time to work on this, so if you want to pick it up please do! I wouldn't worry about plugins. I'm not aware of any plugins creating top level permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24685] history.txt - entry for epoch 978712245 is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24685 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- There is also 1538589017 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Attachment #107470|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Jonathan Druart changed: What|Removed |Added Attachment #107557|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 107592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107592&action=edit Bug 22660: (QA follow-up) Fix capitalization in system preference Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #27 from Jonathan Druart --- (fixing patch's author) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #16 from Jonathan Druart --- I've tried to rebase the remote branch this morning but the original commits embed too many unrelated changes, which makes the work non trivial. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #17 from Lari Taskula --- (In reply to Kyle M Hall from comment #15) > I wouldn't worry about plugins. I'm not aware of any plugins creating top > level permissions. I see it likely that someone at some point will need it. Also, as discussed on #koha IRC [1], we noticed we will soon hit the top limit of borrowers.flags, making this Bug relevant and something that we should definitely look into. Hopefully we can find funding to continue this Bug. [1] http://irc.koha-community.org/koha/2020-07-29#i_2272965 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Jonathan Druart changed: What|Removed |Added Attachment #107552|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 107593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107593&action=edit Bug 25968: Make logs sort by date descending as a default This patch adds DataTables with columns configuration to the log viewer. The table of log entries is now sorted by default by date descending. To test, apply the patch and go to Administration -> Table settings. - Expand the "Tools" section and confirm that there is a section for "logviewer." - Go to Tools -> Log viewer. - Perform a search which will return multiple results. - Confirm that the results are sorted by date descending. - Test that the table controls work correctly: Paging, columns, export. - Return to the Table settings administration page and test that changes to those settings are correctly reflected in the log viewer table. Signed-off-by: barbara Signed-off-by: Katrin Fischer JD amended patch: Fix indentation in .yml to match other entries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #1 from Martha Fuerst --- Chiming in with a YES PLEASE from Huntsville-Madison County Public Library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887 ByWater Sandboxes changed: What|Removed |Added Attachment #107564|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107594&action=edit Bug 25887: Keep library filter on the fund list view The problem: When filtering funds by library, the pull down for libraries resets to "empty" when the page is reloaded, although the filter criteria is visible in the URL. Test plan: Create a fund for library A Create a fund for library B Go to the fund list view => All funds are listed Select library A in the library filter, click "Go" => Funds for library A are listed => Library filter has "library A" selected Edit fund for library B => The edit form has "library B" selected Signed-off-by: Holly Cooper -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887 Holly changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||h...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107562|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 107596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107596&action=edit Bug 26063: Use Koha::Plugins->call for some other hooks Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 107595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107595&action=edit Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
