[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #91 from Josef Moravec --- (In reply to Martin Renvoize from comment #86) > Three more tiny QA followups.. would appreciate your eyes on them Josef for > the final switch to PQA :) And one more from me again (capitalization fix) I consider it PQA now, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #90 from Josef Moravec --- Created attachment 107818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107818=edit Bug 24201: (QA follow-up) Another capitalization fix Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107751|0 |1 is obsolete|| --- Comment #88 from Josef Moravec --- Created attachment 107816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107816=edit Bug 24201: (QA follow-up) Capitalisation fix 'Set desk' vs 'Set Desk'. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107750|0 |1 is obsolete|| --- Comment #87 from Josef Moravec --- Created attachment 107815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107815=edit Bug 24201: (QA follow-up) Only display desks picker if enabled I missed a case on the authentication page with the prior patch of the same name. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24201] Attach desk to intranet session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Josef Moravec changed: What|Removed |Added Attachment #107752|0 |1 is obsolete|| --- Comment #89 from Josef Moravec --- Created attachment 107817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107817=edit Bug 24201: (QA follow-up) Correct call to set_userenv One call to set_userenv had been implimented incorrectly with the parameters out of order. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #106 from David Cook --- (In reply to Jonathan Druart from comment #105) > You can still add your signed-off-by stamp on the patch set to tell QA you > agree with it. Ok I'll keep that in mind. I don't 100% agree with all the current code, but I really do want to see this get into 20.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Patron login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 Status|Pushed to stable|Pushed to oldstable --- Comment #24 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107205|0 |1 is obsolete|| --- Comment #527 from Aleisha Amohia --- Created attachment 107814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107814=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107203|0 |1 is obsolete|| --- Comment #525 from Aleisha Amohia --- Created attachment 107812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107812=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107204|0 |1 is obsolete|| --- Comment #526 from Aleisha Amohia --- Created attachment 107813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107813=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107201|0 |1 is obsolete|| --- Comment #523 from Aleisha Amohia --- Created attachment 107810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107810=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107200|0 |1 is obsolete|| --- Comment #522 from Aleisha Amohia --- Created attachment 107809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107809=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107202|0 |1 is obsolete|| --- Comment #524 from Aleisha Amohia --- Created attachment 107811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107811=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107199|0 |1 is obsolete|| --- Comment #521 from Aleisha Amohia --- Created attachment 107808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107808=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #107198|0 |1 is obsolete|| --- Comment #520 from Aleisha Amohia --- Created attachment 107807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107807=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #43 from Arthur Suzuki --- Made a text proposal on the appropriate field on bugzilla (in the mean time) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Text to go in the||Checks for the release notes||"AllowHoldOnPatronPossessio ||n" policy is now even ||across all interfaces ||(Staff, Opac, WebServices). ||Bypassing this policy from ||Staff interface needs to be ||enforced with ||"AllowHoldPolicyOverride" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Text to go in the||Checks for the release notes||"AllowHoldOnPatronPossessio ||n" policy is now even ||across all interfaces ||(Staff, Opac, WebServices). ||Bypassing this policy from ||Staff interface needs to be ||enforced with ||"AllowHoldPolicyOverride" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #42 from Arthur Suzuki --- (In reply to Nick Clemens from comment #40) > Thanks Arthur! you're welcome Sir! > 1 - > With this patchset the message to the patron changes from" > This title cannot be requested because it's already in your possession. > To: > There are no items that can be placed on hold. > We should pass the exact reason if possible this problem has been addressed with new version of the qa patch :) > 2 - > On the staff side before these patches I am warned that patron has this in > possession, but I can still place the hold > After the patches I cannot place a hold unless AllowHoldPolicyOverride is set > This is probably appropriate, but it is a behaviour change and should be > noted in release notes hummm... I can see there is a folder called "misc/release_notes" but not sure which file is to be edited in there, if any. Some clue to get out of the glue? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Attachment #107760|0 |1 is obsolete|| --- Comment #41 from Arthur Suzuki --- Created attachment 107806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107806=edit Bug 22806: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22806] CanBookBeReserve and CanItemBeReserve do not check AllowHoldsOnPatronsPossessions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 --- Comment #13 from Aleisha Amohia --- I have opened Bug 26138 as this patch causes a bug when enable_plugins is 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26138] New: Errors if enable_plugins is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138
Bug ID: 26138
Summary: Errors if enable_plugins is zero
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P5 - low
Component: Plugin architecture
Assignee: koha-bugs@lists.koha-community.org
Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
Bug 26063 introduced a new way of checking plugins with Koha::Plugins->call(),
except there are now errors all over the OPAC if enable_plugins is zero in the
config.
Trying to submit a simple search throws this error: Can't use string ("0") as a
HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/opac/opac-search.pl line 661
This is a bad blocker assuming every instance uses plugins.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 Aleisha Amohia changed: What|Removed |Added Blocks||26138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 [Bug 26138] Errors if enable_plugins is zero -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26138] Errors if enable_plugins is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 Aleisha Amohia changed: What|Removed |Added Depends on||26063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 [Bug 26063] Use Koha::Plugins->call for other hooks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26063] Use Koha::Plugins->call for other hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
--- Comment #12 from Aleisha Amohia ---
Has anyone tested this without a plugin installed? I tried to do an OPAC search
on a fresh install of master and I'm getting errors.
Can't use string ("0") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/opac/opac-search.pl line 661
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 --- Comment #7 from Phantom --- Same error when tried the instructions as was pointed out. In addition, I also brought down Ubuntu 18.04 and tried to install Koha and got the same error. Atleast this time around I captured my complete commands list to a script file, that is attached. Please advise. Appreciate your help. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 --- Comment #6 from Phantom --- Created attachment 107805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107805=edit script File showing steps that I followed script File showing steps that I followed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Patron login attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Aleisha Amohia changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.03 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #43 from Martin Renvoize --- Found it.. the action was hidden by the checkout table column settings.. grr. Looking at how the code in the works, this is going to be rather challenging to add -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #41 from Andrew Fuerste-Henry --- I'm getting errors when trying to place club holds. - create rule that says 0 holds allowed for a specific category and item - create a club - add 2 patrons to club -- one of the category from your rule, one of a category that can hold that item type - attempt to place club hold for an item of the item type covered by your rule - get error "Something went wrong, check Koha logs for details." When placing individual holds, I'm not seeing a message of "No holds allowed: [Firstname Surname] cannot place holds on any of these items." Instead, I get "Cannot place hold: No items are available to be placed on hold." I'm happy enough with that message, but it's not what the test plan indicated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26137] Warn on malformed param on log viewer (viewlog.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25893 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26137] Warn on malformed param on log viewer (viewlog.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137 --- Comment #1 from Nick Clemens --- Created attachment 107804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107804=edit Bug 26137: Prevent warns form malformed params To test: 1 - Tail plack logs 2 - Browse to Tools->Log viewer 3 - Note an error 4 - Apply patch 5 - Confirm error is gone 6 - Confirm everytihg stil works right -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26137] Warn on malformed param on log viewer (viewlog.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26137 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26137] New: Warn on malformed param on log viewer (viewlog.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137
Bug ID: 26137
Summary: Warn on malformed param on log viewer (viewlog.pl)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In bug 25893 I noticed a warn when loading log viewer.
After some investigation I believe it comes from:
94 subscriptionsnumber => CountSubscriptionFromBiblionumber(scalar
$input->param('object')),
This may not return a value, if we don't have an object - when it doesn't we
get a warn
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens changed: What|Removed |Added Attachment #107084|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 107802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107802=edit Bug 25893: Use wildcards when searching logs The restores the wildcards that were used in the past To test: 0 - Ensure cataloguing logs and issues logs are enabled 1 - Edit an item 2 - Circulate that same item 3 - Browse to tools-> log viewer 4 - Put the itemnumber in the 'info' box 5 - You see only the circulation 6 - Put the itemnumber in the object box 7 - You see only the cataloging modification 8 - Apply patch 9 - Put itemnumber in info box 10 - you see both actions 11 - Put the itemnumber in the object box 12 - You see only the catalogiong modification Signed-off-by: Jason Robb Bug 25893: Don't wildcard object Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #12 from Nick Clemens --- Created attachment 107803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107803=edit Bug 25893: (follow-up) Undo unrelated changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132
--- Comment #10 from Nick Clemens ---
Created attachment 107800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107800=edit
Bug 26132: Tidy _check_max_qty
This is only a perltidy of _check_max_qty to remove some space
inconsistencies, like:
if( $max_checkouts_allowed eq '' ){ return;}
if ( $checkout_count - $onsite_checkout_count >= $max_checkouts_allowed ) {
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #11 from Nick Clemens --- Created attachment 107801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107801=edit Bug 26132: (follow-up) Count all checkouts if no limits needed Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #9 from Nick Clemens --- Created attachment 107799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107799=edit Bug 26132: Don't prefetch if not needed We only need to prefetch items if CircControl is set to ItemHomeLibrary Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #7 from Nick Clemens --- Created attachment 107797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107797=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much more readable here. It fixes 2 flaws: * $type was not quote escaped * the effective itemtype was not used which could lead to wrong calculation (for instance item-level_itypes is set but the item does not have the itype defined) However there is something to note, we are going to make things a bit less effective as we are now fetching the items to get their effective itemtype (vs a SUM done at DB level) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Nick Clemens changed: What|Removed |Added Attachment #107734|0 |1 is obsolete|| Attachment #107735|0 |1 is obsolete|| Attachment #107736|0 |1 is obsolete|| Attachment #107737|0 |1 is obsolete|| Attachment #107738|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 107796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107796=edit Bug 26132: TooMany refactoring The different calls to _check_max_qty can be improved to highlight what is really changing between each of them. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26132] Improve readability of TooMany
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #8 from Nick Clemens --- Created attachment 107798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107798=edit Bug 26132: Remove raw SQL query for patron_maxissueqty Same as before but for patron_maxissueqty Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #40 from Nick Clemens --- Created attachment 107795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107795=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #39 from Nick Clemens --- Created attachment 107794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107794=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Attachment #101473|0 |1 is obsolete|| Attachment #101474|0 |1 is obsolete|| Attachment #101895|0 |1 is obsolete|| --- Comment #38 from Nick Clemens --- Created attachment 107793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107793=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #16 from Nick Clemens --- Created attachment 107792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107792=edit Bug 25683: (follow-up) Use COALESCE instead of IFNULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26112] Errors in marc21_authorities files for uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105098|0 |1 is obsolete|| --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 107791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107791=edit Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. Signed-off-by: Peter Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100 --- Comment #7 from Barbara Johnson --- Lucas - I'm getting an error page when i go to Tools > News. https://snipboard.io/SvQroR.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26091] Add column configuration and export options to catalog statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26091 ByWater Sandboxes changed: What|Removed |Added Attachment #107519|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107790=edit Bug 26091: Add column configuration and export options to catalog statistics report This patch makes the catalog statistics report output a DataTable with on-the-fly column configuration and export options. Because the report can generate results with an arbitrary set of table headers, the columns set to be passed to DataTables is built on the fly along with the table. There is no global table setting. Since the "grand total" cell might reflect a total which includes hidden columns, the table footer label now indicates "all results." To test, apply the patch and go to Reports. - Submit a query to the "catalog" statistics wizard which will return multiple results. - On the results page, confirm that the DataTable displays correctly and that all controls work as expected, including column configuration and export options. - Submit other queries which will return a different set of columns in the result. Confirm that everything continues to work as expected. Signed-off-by: Sally -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26091] Add column configuration and export options to catalog statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26091 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21345] Patron records with attached files not obvious from patron details view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21345 ByWater Sandboxes changed: What|Removed |Added Attachment #107623|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 107789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107789=edit Bug 21345: Patron records with attached files not obvious from patron details view This patch adds a section to the patron details page for listing files which have been attached to the patron record. To test, apply the patch and enable the EnableBorrowerFiles system preference. - If necessary, attach some files to a patron record by viewing a patron record and choosing "Files" from the sidebar menu. - View the detail page (moremember.pl) for a patron who has files attached. - You should see a new section under "Alternative contact" with the heading "Files." - Test the "Manage" button to make sure it takes you to that patron's files. - Confirm that all the attached files are listed. - Confirm that the links to each file work correctly. Signed-off-by: Sally Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26087] Add table configuration and export options to orders by fund report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26087 ByWater Sandboxes changed: What|Removed |Added Attachment #107514|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107788=edit Bug 26087: Add table configuration and export options to orders by fund report This patch adds column configuration to the orders by funds report results table. The "Basket" column is excluded from being togglable. To test, apply the patch and clear your browser cache if necessary. - Go to Reports -> Orders by fund - Submit parameters which will return multiple results. - Test that the "Column visibility" button works to show and hide columns. The "Basket" column should be excluded. - Test the export options (Excel, CSV, etc) - Go to Administration -> Columns settings and edit the default configuration of the orders by fund report. Confirm that these changes are reflected in the report results. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26087] Add table configuration and export options to orders by fund report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26087 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #42 from Jonathan Druart --- https://snipboard.io/RsyS8W.jpg last column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Lisette Scheer --- Worked great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #41 from Martin Renvoize --- (In reply to Jonathan Druart from comment #40) > (In reply to Martin Renvoize from comment #39) > > (In reply to Jonathan Druart from comment #36) > > > 2. If you checkin from the checkouts page there is no alert > > > > Can you clarify how to achieve this.. I can't replicate it at present. > > from the checkouts view: circ/circulation.pl?borrowernumber=42 Nope, still not sure what you mean. I checkout an item to person X.. and then try to checkout the same item to Person Y... the alert is triggered.. is that not what you mean? How else can you perform a check-in on the checkout page? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 ByWater Sandboxes changed: What|Removed |Added Attachment #107662|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 107787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107787=edit Bug 23420: Add OPACSuggestionUnwantedFields option To test: -Apply patch -Check OPACSuggestionUnwantedFields -Check some fields as unwanted -Go to the OPAC suggestion page and make sure these correct fields are hidden -Go through each option and make sure it hides properly Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #47 from Jonathan Druart --- Just noting: I think some code is going to conflict with bug 21946 (PQA) and bug 26132 (which I'd like to push along with 21946) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #2 from Jonathan Druart --- Created attachment 107786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107786=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Jonathan Druart changed: What|Removed |Added Attachment #107783|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 107785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107785=edit Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26136] Prevent double submit of checkin form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26136
ByWater Sandboxes changed:
What|Removed |Added
Attachment #107764|0 |1
is obsolete||
--- Comment #2 from ByWater Sandboxes ---
Created attachment 107784
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107784=edit
Bug 26136: Prevent double submit on checkin-form
To test:
1 - Browse to Circulation->Check-in
2 - Type a barcode into the Check in box
3 - Hit Enter as many as times as you can
4 - Check the statistics table:
SELECT * FROM statistics WHERE itemnumber={itemnumber} AND
DATE(datetime)=CURDATE();
5 - Note you have multiple lines for the same item at the same time
6 - Apply patch
7 - Reload the page
8 - Type the barcode
9 - Press Enter even more fast and more furiously
10 - Check the statistics table
11 - Only one entry, huzzah!
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Jonathan Druart changed: What|Removed |Added Attachment #107782|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 107783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107783=edit Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Jonathan Druart changed: What|Removed |Added Attachment #107781|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 107782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107782=edit Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 --- Comment #9 from Jonathan Druart --- Created attachment 107781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107781=edit Bug 16748: Add the ability to define due date in batch checkout This patch allows the librarian to pick the due date when batch checkout Test plan: Batch checkout using a hard due date => Notice that the due date is taken into account Batch checkout the same barcodes with a different due date, to trigger the confirmation step => Notice that the due date is taken into account for the renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #25 from Arthur Suzuki --- (In reply to Nick Clemens from comment #20) > Needs a minor rebase done \o/ > > I am not sure this is the best way to go. With these patches we fetch every > item from the db and check the hold rule - but this doubles work we do in > CanItemBeReserved and feels unnecessary > > Currently the loop in CanBookBeReserved returns as soon as it finds one 'OK' > - you loop over all items to check the holds policy first - I think if we > return the holds policy too from CanItemBeReserved we can return if one item > is OK and item level holds not forced. I believe this would allow removal of > the caller check too Good advice, applied :) > The code on the patches returns 'RecordHoldNotAllowed' if any items have > item level holds forced, but shouldn't it only return that if all items on > the biblio are forced? > Erfff... you mean different items belonging to a single biblio could have different rules? daamn... > You add an extra fetch for the item which has already been fetched in the > code: > 429 $item = Koha::Items->find( $itemnumber ); This has been corrected in the qa patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Attachment #107779|0 |1 is obsolete|| --- Comment #24 from Arthur Suzuki --- Created attachment 107780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107780=edit Bug 25408: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #23 from Arthur Suzuki --- Created attachment 107779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107779=edit Bug 25408: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #22 from Arthur Suzuki --- Created attachment 107778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107778=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved test plan: 1) apply tests patch 2) run tests 3) verify not green 4) apply patch 5) run tests (again) 6) success: green :) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What|Removed |Added Attachment #106535|0 |1 is obsolete|| Attachment #106536|0 |1 is obsolete|| Attachment #106537|0 |1 is obsolete|| --- Comment #21 from Arthur Suzuki --- Created attachment 10 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What|Removed |Added Attachment #107775|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 107776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107776=edit Bug 21066: Update translated news and notices Replace timestamp by publicationdate in translations. Applies to sample notices and sample news. Test plan: Run a new install or pick a sql file and run it on cmdline. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What|Removed |Added Summary|Replace opac_news.timestamp |Replace opac_news.timestamp |by publisheddate and add|by publicationdate and add |updated_on as timestamp |updated_on as timestamp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #12 from Marcel de Rooy --- Created attachment 107774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107774=edit Bug 21066: Update English sample notices Applies to sample notices and sample news. Replace timestamp by publicationdate. Also adjust notice in TemplateToolkit.t. Test plan: Run dbrev and verify if ISSUESLIP refers to opac_news.publicationdate. Run t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #14 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #6) > Argh... should have looked more closely at the table. I completely > understand your problem now. > > I think making the timestamp a publishingdate (better fit with > expirationdate and might be in the future) and having another real timestamp > field makes totally sense. Okay, second try. With publicationdate. Perhaps even a bit better than publishingdate ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066
--- Comment #11 from Marcel de Rooy ---
Created attachment 107773
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107773=edit
Bug 21066: Update NewsChannels.t
Removing the weird '' => 1 from the hash too.
NOTE: The following line in the module seems to be useless:
$data->{$data->{'lang'}} = 1 if defined $data->{lang};
Test plan:
Run t/db_dependent/NewsChannels.t
Run t/db_dependent/Koha/News.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #13 from Marcel de Rooy --- Created attachment 107775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107775=edit Bug 21066: Update translated news and notices Replace timestamp by publicationdate in translations. Applies to sample notices and sample news. Test plan: Run a new install or pick a sql file and run it on cmdline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #10 from Marcel de Rooy --- Created attachment 107772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107772=edit Bug 21066: Resolve SQL errors in strict mode DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( content,number,lang,title,branchcode,borrowernumber,expirationdate,publicationdate ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0="test", 1="", 2="", 3="test", 4=undef, 5="51", 6='2020-08-11', 7='2020-08-04'] at /usr/share/koha/C4/NewsChannels.pm line 68. DBD::mysql::st execute failed: Incorrect integer value: 'a' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "UPDATE opac_news SET lang = ?,publicationdate = ?,expirationdate = ?,number = ?,content = ?,branchcode = ?,title = ? WHERE idnew = ?;" with ParamValues: 0="", 1='2020-08-03', 2=undef, 3="a", 4="test", 5=undef, 6="test", 7="9"] at /usr/share/koha/C4/NewsChannels.pm line 107. Test plan: Do not apply this patch. Enable strict mode in koha-conf. Add new record in tools/news leaving 'Appear in position' blank. The record is not added; you have a warn in your plack-error log. Apply patch and try again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #9 from Marcel de Rooy --- Created attachment 107771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107771=edit Bug 21066: Code changes needed for replacing opac_news.timestamp Test plan: Perform some CRUD operations on the news page in staff. Verify that news on opac and staff respect publicationdate. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #8 from Marcel de Rooy --- Created attachment 107770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107770=edit DO_NOT_PUSH: DBIx schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What|Removed |Added Attachment #77037|0 |1 is obsolete|| Attachment #77038|0 |1 is obsolete|| Attachment #77039|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 107769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107769=edit Bug 21066: Database revision Change timestamp to publicationdate, add updated_on as 'real' timestamp. Test plan: Run install or upgrade. Check table opac_news. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publisheddate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #28 from Jonathan Druart --- Some comments from bug 24190 comment 14 (&15) apply here. Additionally I don't think it's a good idea to pass the flag to CloseBasket. 577 # Close the basket, passing a flag indicating that this action 578 # originated from an approval 579 CloseBasket($b, 1); Cannot we imagine that Koha::EDI deals with this specific situation? (UPDATE the action_log with the desire action) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||and...@bywatersolutions.com --- Comment #46 from Andrew Fuerste-Henry --- (In reply to Lucie Gay from comment #26) > the priority rule is applied except for the loan period, it's the one define > in the more permissive rule which is taken into account. This is still valid. To recreate: - create an All Libraries rule for a specific patron category / item type that allows 1 checkout for 5 days. Mark this rule as Has Priority - create a library specific rule for same patron category / item type that allows 2 checkouts for 1 day - perform a checkout that matches the patron category / item type your wrote rules for. Confirm it checks out for 1 day (the loan period for the library-specific rule) - attempt a second checkout that matches the patron category / item type your wrote rules for. Confirm the checkout is blocked because it exceeds the checkout limit of the All Libraries rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #15 from Jonathan Druart --- 4. You should also consider adding tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
