[Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 --- Comment #13 from Aleisha Amohia --- last two patches backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24147] Objects.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147 --- Comment #4 from Jonathan Druart --- Koha_Master_U16 #45 (Docker_1) - 10.1.46-MariaDB-1~bionic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26000] Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Aleisha Amohia changed: What|Removed |Added Version(s)||19.11.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #16 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #5 from David Cook --- Adding dependency on Bug 26249 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #37 from Jonathan Druart --- (In reply to David Cook from comment #36) > I think CoverFlow has become a de facto standard for Koha. > > At this point, maybe Bywater would consider converting the plugin into a > patch, but I don't see a problem leaving it as a plugin and just closing > this report. Yes, ByWater or anybody else. The ambition for a plugin that is widely used must be to integrate Koha core. I don't think we should close this bug report, but obsolete the patches and link to the plugin instead, in hope someone will be willing to port it to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26249] keep_text class not set inconsistently in cat-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26249] keep_text class not set inconsistently in cat-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 --- Comment #1 from David Cook --- Created attachment 108570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108570=edit Bug 26249: Set keep_text class correctly in cat-search.inc This patch sets the keep_text class correctly in cat-search.inc for the "Search the catalog" tab To test: 1) Apply the patch 2) Go to /cgi-bin/koha/catalogue/search.pl 3) Type "A" into the search box for "Search the catalog" 4) Click on the "Check out" tab 5) Note that "A" appears in search box 6) Change "A" to "B" in search box 7) Click on the "Search the catalog" box 8) Note that "B" appears in the search box 9) Note no Javascript errors in the console -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26249] keep_text class not set inconsistently in cat-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 David Cook changed: What|Removed |Added Blocks||26248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 [Bug 26248] Simplify keep_text Javascript function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Depends on||26249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 [Bug 26249] keep_text class not set inconsistently in cat-search.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26249] New: keep_text class not set inconsistently in cat-search.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26249 Bug ID: 26249 Summary: keep_text class not set inconsistently in cat-search.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In cat-search.inc, the keep_text class should be set on the A elements but the "Search the catalog" is set on the LI element. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #4 from David Cook --- Ahh the keep_text isn't set correctly in "koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #3 from David Cook --- For some reason that tab is passing an index value of 4 rather than 3... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 --- Comment #12 from Jonathan Druart --- We had administration_tasks.t in infinite loop on all 19.11 jobs. The first patch is for all branches and will prevent this problem to appear in the future. The second patch is for <=19.11 only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 --- Comment #10 from Jonathan Druart --- Created attachment 108568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108568=edit Bug 26162: Don't fall into an infinite loop If something went wrong we do want to stop the script! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162
--- Comment #11 from Jonathan Druart
---
Created attachment 108569
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108569=edit
Bug 26162: [19.11] Fix DT info label
There is an inconsistency in 19.11:
% grep Showing koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
koha-tmpl/intranet-tmpl/prog/js/datatables.js
koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc:var MSG_DT_INFO =
_("Showing _START_ to _END_ of _TOTAL_");
koha-tmpl/intranet-tmpl/prog/js/datatables.js:"sInfo" :
window.MSG_DT_INFO || "Showing _START_ to _END_ of _TOTAL_ entries",
The "entries" is not always displayed.
datatables.inc has been removed from 20.05 by
Bug 24662: Remove global variables MSG_* from datatables.inc
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #2 from David Cook --- Hmm working fine on mainpage.pl but having an issue clicking on "Search the catalog" on search.pl... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 David Cook changed: What|Removed |Added Blocks||26248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 [Bug 26248] Simplify keep_text Javascript function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Depends on||14189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 --- Comment #1 from David Cook --- Created attachment 108567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108567=edit Bug 26248: Simplify keep_text function used in header search The current code is functional but not very readable. This patch simplifies the code to be more readable and to be more efficient. To test: 1) Apply patch 2) Refresh browser cache 3) Type "A" in "Check out" tab 4) Click "Check in" (and other tabs) 5) Observe that text is persisted from original tab 6) Type "B" in "Search the catalog" tab 7) Click "Renew" tab 8) Observe that text is persisted from latest changed tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] New: Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 Bug ID: 26248 Summary: Simplify keep_text Javascript function Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The keep_text function in koha-tmpl/intranet-tmpl/prog/js/staff-global.js is functional but not very readable. We can simplify it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #143 from Jonathan Druart --- (In reply to David Cook from comment #142) > At this point, are we just waiting for the QA team to look at this report? See comment 103 and comment 104 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 David Cook changed: What|Removed |Added Depends on||14189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 David Cook changed: What|Removed |Added Blocks||26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 David Cook changed: What|Removed |Added Blocks||26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 David Cook changed: What|Removed |Added Depends on||19046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 David Cook changed: What|Removed |Added Summary|Search terms retained in|Search terms retained in |header search creates |header search creates UX |system inconsistency|inconsistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] New: Search terms retained in header search creates system inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Bug ID: 26247 Summary: Search terms retained in header search creates system inconsistency Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If you type "test" in "Search the catalog" and click "Submit", the search term will be retained in the box. This means if you do a search and then want to scan a barcode into "Check out", "Check in", or "Renew", you first have to manually clear the search terms. This is inconsistent with how the header search boxes work overall. For instance, if you do a "Check out", it doesn't retain the value used to search. Either the search terms shouldn't be retained after a catalog search (change introduced in Bug 19046), or the text shouldn't be copied from that tab to other tabs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 --- Comment #12 from David Cook --- (In reply to David Cook from comment #11) > (In reply to Katrin Fischer from comment #3) > > Also the search term doesn't remain in the search box like it does in the > > OPAC. Still valid :( > > This actually creates a problem in the Staff Interface. If you retain the > search term in the search box, that text stays in the box if you change to > "Check out" or "Check in", which means you have to manually clear the search > terms before typing/scanning in a barcode. > > No other module retains the text in the top search box, so I think the > search module should be consistent with the behaviour across the system. Alternatively, maybe the text in the search box shouldn't be retained if it's coming from the "Search the catalog" tab... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #3) > Also the search term doesn't remain in the search box like it does in the > OPAC. Still valid :( This actually creates a problem in the Staff Interface. If you retain the search term in the search box, that text stays in the box if you change to "Check out" or "Check in", which means you have to manually clear the search terms before typing/scanning in a barcode. No other module retains the text in the top search box, so I think the search module should be consistent with the behaviour across the system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26246] New: Create an display area to show pending requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26246 Bug ID: 26246 Summary: Create an display area to show pending requests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: cornejo.alv...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 108566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108566=edit display location example The idea is to have a display area that can be seen from any part of the staff client that will show pending requests (Articles, suggestions, reserves, etc) and will provide links to the page that will allow staff to acction them. Currently some requests are not shown unless staff goes to specific area and some, like article requests or suggestions are only shown on the mainpage below the buttons. This location does not work well for low resolution screens since staff need to scroll down to check if there are any. I´ve twinkled with header.inc and was able to have something shown, however, the pending counts are shown only in the main page. Cheking code I saw that either header.inc or the page calling header.inc will need to call corresponding functions. An option like the "lastPatron" feature would be great. I´m attaching other display location options. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 --- Comment #1 from Owen Leonard --- Created attachment 108565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108565=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #12 from Tomás Cohen Arazi --- I was going to write the same but got a mid air collision. Never hesitate to add your signature, even if I wasn't a QA team member. It means something for the QA members and the RM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > If you signed it off still, we could count Tomas for towards QA if he agrees. Ok I could do that I was actually wondering about that same methodology for Bug 22417... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #10 from Katrin Fischer --- If you signed it off still, we could count Tomas for towards QA if he agrees. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #127 from Katrin Fischer --- Hm, I've checked the test plan on the dependent bug now too and am still a little confused about the use case for this. Reading "volume" made me think of something that would be used for serial issues bound together into one volume (serials, binding) But this doesn't seem to be the case with how the volume hold feature works. Does this more work like a "Hold group" maybe? One item out of the group appears to satisfy the hold - so maybe "Group" would be a better word to describe the idea? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #126 from Katrin Fischer ---
This one is a little scary already, but going in for a first review :)
1) QA script
Several issues found, please fix:
FAIL Koha/Biblio/Volume.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL Koha/Biblio/Volume/Item.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL pod
*** WARNING:
empty section in previous paragraph
in file Koha/Biblio/Volume/Item.pm
FAIL Koha/Biblio/Volume/Items.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL pod
*** WARNING:
empty section in previous paragraph
in file Koha/Biblio/Volume/Items.pm
FAIL Koha/Biblio/Volumes.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL pod
*** WARNING:
empty section in previous paragraph
in file Koha/Biblio/Volumes.pm
FAIL Koha/REST/V1/Biblios/Volumes.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL Koha/REST/V1/Biblios/Volumes/Items.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL Koha/Schema/Result/Volume.pm
FAIL pod coverage
POD is missing for koha_object_class
POD is missing for koha_objects_class
FAIL Koha/Schema/Result/VolumeItem.pm
FAIL pod coverage
POD is missing for koha_object_class
POD is missing for koha_objects_class
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
FAIL forbidden patterns
forbidden pattern: simple-quote string (line 1446)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
FAIL filters
missing_filter at line 20 ( var has_volumes = [% volumes.count
%];)
FAIL js_in_body
2) Doubled up use statement in Biblio.pm
+use Koha::Biblio::Volumes;
+use Koha::Biblio::Volumes;
3) REST API
I'd love to have Tomas take a look on the REST API bits here.
4) sysprefs.sql
After all the use statements were so nicely alphabetically resorted, THIS?
+('EnableVolumes','0','','Enable volumes feature','YesNo'),
('viewISBD','1','','Allow display of ISBD view of bibiographic
records','YesNo'),
;)
5) Pref (question)
Enable|Don't enable
volumes feature to allow collecting groups of items on a record into volumes.
Does it mean the items have to be from the same record or could they be from
different ones?
6) Table configuration
The new volumn column on the holdings table needs to be added to the table
configuration options.
7) GUI
"Create new" on the items table would work nicer as "Create new volume" or "New
volume" to give context to translators and for better accessibility.
Future improvements:
It might be nice to offer a kind of grouped view for the items in volumes...
but I am not sure yet how this would work best.
It might be nice to show the volumes in the OPAC as well.
8) Use case and future plans?
Can you tell a bit about in what context or use case this partner is using
this? Serials?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #36 from David Cook --- I think CoverFlow has become a de facto standard for Koha. At this point, maybe Bywater would consider converting the plugin into a patch, but I don't see a problem leaving it as a plugin and just closing this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #9 from David Cook --- I came to apologize for not signing this one off last night, but looks like Tomas has already signed off. Hurray! I'm actually quite looking forward to this change going in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #141 from David Cook --- (In reply to Jonathan Druart from comment #140) > See bug 25674. Considering I wrote the majority of the content on bug 25674, I'm not 100% sure what you're implying. I'm guessing that you're saying we can fix that later. I won't disagree on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #142 from David Cook --- At this point, are we just waiting for the QA team to look at this report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #39 from Katrin Fischer ---
Doing a first review here:
1) QA script:
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
FAIL filters
missing_filter at line 36 ()
missing_filter at line 38 ()
missing_filter at line 39 ()
2) Unit tests
There are changes on the ModReserveCancelAll and Hold:cancel methods. Can we
please get some tests for the new behavior?
3) Docs
Maybe it would be worth mentioning that this allows to store a cancellation
reason in the documentation? (Bug title + description for release notes).
Currently only the email functionality is mentioned, but we also have an
interesting db change.
4) Constants for translation?
+var REASON_LABEL = _("Reason: ");
I believe this is not really needed here as the Javascript code is in a tt file
and not js. Not a blocker, but was wondering.
5) Sample notice
Could we please create a nice sample notice for this? I think it would make
using the feature easier on new installations especially since the TT syntax is
still a little hard to figure out. As an existing notice also triggers
activation, we can't add for existing installations.
6) Authorised value
We should add the authorised value to ease use of the feature. I believe this
would be save for existing and new installations? Please also add a nice
description to the template on what the category is used for (See:
/cgi-bin/koha/admin/authorised_values.pl)
7) GUI
reserve.pl
I think it would be nice if the cancellation reason only activated once a "del"
was selected. Otherwise people might expect it to do something without that or
expect it to also work when they cancel using "X".
moremember.pl/circulation.pl
I think for context we should add "Cancellation reason:" here before the pull
down too.
Why pendingreserves, but not holds queue?
pendingreserves: I'd remove the bold and add : (only one string to translate
for translators :) )
8) Possible enhancements
I wonder if it would be nice to move the pull downs to a modal dialog later. So
it will always show when you decide to cancel something. It would add an
additional click, but libraries can opt-in to use the feature and might like
the 'confirmation' step that reminds of setting the reason?
It also might be nice to haven option to 'not send an email' in some cases. At
the moment I think it's always or never? A checkbox for 'send email' might do
the job and could be selected/preselected depending on library choice.
Overall no big issues - works well!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26153] Remove the use of jquery.checkboxes plugin from items lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26153] Remove the use of jquery.checkboxes plugin from items lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 Katrin Fischer changed: What|Removed |Added Attachment #108442|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 108564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108564=edit Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report This patch removes the use of the jquery.checkboxes plugin from the lost items report page and replaces it with custom JS. To test, apply the patch and go to Reports -> Lost items. - Run the report with parameters which will return multiple results. - On the results page Create a CSV export profile if there's none. - On the results page test the "Select all" and "Clear all" links at the top of the results. The controls should work correctly. Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26234] Default DataTables must know our own classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234 Katrin Fischer changed: What|Removed |Added Attachment #108520|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 108563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108563=edit Bug 26234: Teach our KohaTable constructor the specific th classes We have different classes we can use to set specific behaviours on table columns: title-string, string-sort, anti-the and NoSort. We should not need to pass them to the DataTable constructor, we could teach it that we always want to apply them. It will avoid bug like bug 26233 The goal is to define them in a centralised place (columns_settings.inc) then only use the class on the th Test plan: Different behaviour and tables must be tested to confirm it works correctly. Focus must be put on table when aoColumnsDefs is passed from the template and confirm that this will add more info to aoColumnsDefs and not remove the existing ones. Note that this only work when KohaTable is used. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26234] Default DataTables must know our own classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22263] Command line script to populate or update items.cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 hannah...@northwestu.edu changed: What|Removed |Added CC||hannah...@northwestu.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26039] Accessibility: Shelf browser is not announced upon loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26039 Katrin Fischer changed: What|Removed |Added Attachment #108457|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 108562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108562=edit Bug 26039: Focus and Scroll to ShelfBrowser on load When the shelf browser link is clicked we perform a full page reload which results in a reset in the context. We should immediately focus the shelf browser and scroll to that region to highlight the change of content. Test plan 1/ Enable shelf browser 2/ Search for an item in the open and navigate to the detail page 3/ Click the 'Browse shelf' link 4/ Note that upon page reload the screen scrolls to the 'Browsing...' location of the screen. 5/ Note that the 'Browsing...' title is 'focused' 6/ Signoff. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26039] Accessibility: Shelf browser is not announced upon loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26039 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25605] Exporting report as a tab delimited file can produce a lot of warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25605] Exporting report as a tab delimited file can produce a lot of warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer changed: What|Removed |Added Attachment #108509|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 108561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108561=edit Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text Test plan : 1- Create a new report : select * from items; 2- Run it 3- Download the report as a tab separated text 4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.' in plack-error.log 5- Apply patch 6- Restart all 7- Redo 2 and 3 8- No more warning. 9- diff both downloaded files, they must be the same. Signed-off-by: Marco Abi-Ramia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25605] Exporting report as a tab delimited file can produce a lot of warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25605 Katrin Fischer changed: What|Removed |Added Summary|exporting report as a tab |Exporting report as a tab |delimited file can produce |delimited file can produce |a lot of warning|a lot of warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26239] Number::Format issues with large negative numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Katrin Fischer changed: What|Removed |Added Attachment #108530|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 108560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108560=edit Bug 26239: Do not format large negative numbers At several places we got the following error if we use numbers too big for Number::Format Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44 It make the app explodes. The goal here is to handle these errors gracefully and easily. We fixed it for positive numbers in bug 15770, but we neglected the case of negative numbers Test plan: - Add a manual credit to a patron of 100 - ISE! - Apply patch - Restart all the things Works perfectly. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26239] Number::Format issues with large negative numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107162|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 108558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108558=edit Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107163|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 108559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108559=edit Bug 23816: Fix other tests This patch fixes other tests broken by new password length and strength override To test: 1. prove t/db_dependent/Auth.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patrons.t \ t/db_dependent/Koha/Patrons/Import.t \ t/db_dependent/Koha/Plugins/Patron.t \ t/db_dependent/Search/History.t \ t/db_dependent/api/v1/auth_basic.t \ t/db_dependent/api/v1/checkouts.t \ t/db_dependent/api/v1/patrons_password.t \ t/db_dependent/selenium/authentication.t \ t/db_dependent/selenium/regressions.t 2. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107160|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 108556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108556=edit Bug 23816: (follow-up) Define boolean column in shcema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107159|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108555=edit Bug 23816: [DO NOT PUSH] Update category schema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107161|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 108557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108557=edit Bug 23816: Add tests Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #107158|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 108554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108554=edit Bug 23816: Update kohastructure and atomic update Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 Owen Leonard changed: What|Removed |Added Depends on||26245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 [Bug 26245] Remove unused functions from members.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] New: Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Bug ID: 26245 Summary: Remove unused functions from members.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 26244 There are several functions in members.js which are obsolete and unused. Rather than change them in the process of fixing Bug 26244 they should be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap at_least_one_library_not_available_for_pickup text in HTML element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 Lucas Gass changed: What|Removed |Added Attachment #108526|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap at_least_one_library_not_available_for_pickup text in HTML element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #4 from Lucas Gass --- Hi Brandon, Thanks for looking at this and testing. Did you sign-off on this patch? Looks like you added a sign-off but didn't change the status to signed-off. Looks like you also supplied a patch which includes some changes to updatedatabase.pl, I am going to mark that patch as obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26244] New: Move translatable strings out of memberentrygen.tt and into JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 Bug ID: 26244 Summary: Move translatable strings out of memberentrygen.tt and into JavaScript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr, testo...@bugs.koha-community.org Depends on: 21156 Strings defined for translation in memberentrygen.tt can now be wrapped in the new translation function and put in members.js and messaging-preference-form.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #80361|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 108553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108553=edit Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #130 from Bouzid Fergani --- Hi all, I have fixed all the problems now. 1- adding verbose tests to t/db_dependent/Biblio.t 2- Remove line use C4::Heading in authorities/authorities.pl 3- Move cataloguing/automatic_linker.pl to svc and call BiblioAutoLink with verbose 4- Using Css class in all .tt 5- Changing the message No matching authority found when the authority is created or imported Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani changed: What|Removed |Added Attachment #108396|0 |1 is obsolete|| --- Comment #129 from Bouzid Fergani --- Created attachment 108552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108552=edit Bug 11299: Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26243] Move translatable strings out of templates and into circulation.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26243 --- Comment #1 from Owen Leonard --- Created attachment 108551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108551=edit Bug 26243: Move translatable strings out of templates and into circulation.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and check out to a patron. - If there are none on the account, add a new message using the "Add a new message" link. - Click "Delete" for that message. - You should get a confirmation message, "Are you sure you want to delete this message? This cannot be undone." - If necessary, enable the ExportCircHistory system preference. - Check out to a patron who has one or more items checked out. - Wihtout checking any checkboxes, click the "Export" button at the bottom of the page. - You should get an error message, "You must select checkout(s) to export." - Add a restriction the patron's account. - Delete the restriction. You should get a confirmation message, "Remove restriction?" - Perform the same tests from the patron detail page. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js for translation, e.g.: msgid "You must select checkout(s) to export" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26243] Move translatable strings out of templates and into circulation.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26243 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- Does the information just not show? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Lisette Scheer --- I've been informed that the <<< HEAD === >>> Bug 14866: Make high holds work with different item types is a sign that the patch doesn't cleanly apply, so I'm changing the status to patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Ivan Dziuba changed: What|Removed |Added CC||ivan.dzi...@inlibro.com --- Comment #4 from Ivan Dziuba --- This patch doesn't work ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26195] Add a way to specify authorised values should be expanded [OAI]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108209|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 108550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108550=edit Bug 26195: Add a way to specify authorised values should be expanded [OAI] This patch introduces a new configuration entry for OAI so the resulting records include authorised value descriptions instead of codes. This is off by default. To test: 1. Create a yaml file with the extended OAI configuration 2. Visit http://kohadev.myDNSname.org:8080/cgi-bin/koha/oai.pl 3. Browse some records => SUCCESS: The fields tied to AV show codes. 4. Update your configuration with 'expanded_avs: 1' for one of the defined format like in: --- format: marc21: metadataPrefix: marc21 metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 0 marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 expanded_avs: 1 5. restart_all 6. Repead 3 => SUCCESS: AV descriptions are returned! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26233] Edit item date sort still does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26233 --- Comment #8 from Owen Leonard --- data-order wasn't available in DataTables when we first started using the plugin. I think it is preferable to use data-order going forward because it's not dependent on our own addon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #82 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #67) > Seems like a simple failure to fix, but I'm not sure what the fix should be. > Is this a difference in response that will crop up from server differences? > Or does it fail on your system as well now? The test relied too much on a specific way the header was built. It actually highlighted bad design because the tests were showing the charset was being set as 'utf8' regardless. So I tweaked it a little bit so it actually sets the charset, following the design on Email::MIME and Email::Stuffer. No place in the codebase is setting it with this rewrite, though. As we return UTF-8 email body. But worth leaving room for passing it, just in case, in the right way. The tests now check iso-8859-1 is being set if requested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 108549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108549=edit Bug 22343: Prevent passing password to the UI Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 108548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108548=edit Bug 22343: Adapt runreport.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 108545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108545=edit Bug 22343: Make C4::Letters use the new SMTP server config This patch makes the different methods in C4::Letters use: - Koha::SMTP::Servers: to get the effective SMTP server for the library or the fallback default if no library in context. - New Koha::Email->create method for crafting the email envelope for sending. The tests are adapted so they behave the same way, but the trapped (in the mock) $email object has the right type and its attributes are accessed correctly. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Letters.t => SUCCESS: Tests pass. YAY! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 108543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108543=edit Bug 22343: Add ->transport method This patch adds a Koha::SMTP::Server->transport method that returns an Email::Sender::Transport::SMTP object generated with the current object's settings. Special case is handled for disabled SSL. This is all covered by the introduced tests. 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 108544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108544=edit Bug 22343: Revamped Koha::Email class This patch completely rewrites the Koha::Email class, inheriting from Email::Stuffer. The latter suits well the use by Email::Sender, which is to replace Mail::Sendmail on this patchset. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Email.t => SUCCESS: Tests pass! 3. Verify all conditional codepaths are covered 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 108547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108547=edit Bug 22343: Adapt controller scripts This patch adapts controller scripts that used sendmail. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 108546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108546=edit Bug 22343: Adapt Koha::Illrequest Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #72 from Tomás Cohen Arazi --- Created attachment 108540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108540=edit Bug 22343: Add classes for handling SMTP servers This patch introduces classes to handle SMTP servers. It is done in a way that a default server can be set, and then per-library ones can be set. All should be done with Koha::SMTP::Servers methods, that take care of overwriting library-specific configs, and handle the defaults retrieval and setting correctly. To test: 1. Apply this patches 2. Run: $ kshell $ perl installer/data/mysql/updatedatabase.pl => SUCCESS: Atomic update is ok, smtp_servers table created 3. Run: k$ prove t/db_dependent/Koha/SMTP/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #71 from Tomás Cohen Arazi --- Created attachment 108539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108539=edit Bug 22343: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 108542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108542=edit Bug 22343: Add CRUD page for SMTP servers This patch introduces a way to define SMTP servers either globally or per-library. To test: 1. Apply this patch 2. Find the SMTP servers entry in the admin page 3. Play with adding/removing SMTP servers => SUCCESS: All works as expected 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 108541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108541=edit Bug 22343: API routes for SMTP servers CRUD Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #69 from Tomás Cohen Arazi --- Created attachment 108537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108537=edit Bug 22343: Add a new table to store SMTP servers configs Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108529|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 108538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108538=edit Bug 22343: Add new table schema file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Attachment #108143|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
