[Koha-bugs] [Bug 26443] New: while installation internal server error occured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26443 Bug ID: 26443 Summary: while installation internal server error occured Change sponsored?: --- Product: Koha Version: 20.05 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: deepanrav...@gmail.com QA Contact: testo...@bugs.koha-community.org Hello everyone, This morning I install Koha version 20.05 in Ubuntu 20.04 After the installation, I failed to access staff login page with “Internal Server Error” message. Web installer › Selecting default settings after this step i got internal server error report I tried to do different options like restarting apache, reboot the PC but all failed to solve the problem. I kindly requesting for your assistance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26442] Account home page is missing the image icon for Dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26442 Christina changed: What|Removed |Added Alias||mybug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26442] New: Account home page is missing the image icon for Dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26442 Bug ID: 26442 Summary: Account home page is missing the image icon for Dashboard Change sponsored?: --- Product: Koha Version: unspecified Hardware: Macintosh OS: Mac OS Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: cus...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 109978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109978=edit The screen shot of the homepage of my account There are five options under "Welcome to Bugzilla" title. Each option has an image icon and a name. However the last "Dashboard" is missing the image icon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #50 from Arthur Suzuki --- I've just got everything to work fine on current master. Did a bit of rework and a bit of reword to comply with QA rules. QA scripts green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #47 from Arthur Suzuki --- Created attachment 109975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109975=edit Bug 17314: Added _to_model and _to_api methods and changed attirbutes naming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #49 from Arthur Suzuki --- Created attachment 109977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109977=edit Bug 17314: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #48 from Arthur Suzuki --- Created attachment 109976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109976=edit Bug 17314: (QA follow-up) Adjust spec This patch makes the exposed attribute names match what is defined in the internal mapping in the code, and also the query parameters. It also: - Makes 'status' an enum, as we know the list of possible values/codes... - Removes allow-owner and allow-guarantor, as said before, endpoints in /public namespace are allowed to use those. I didn't go and write those endpoints becuase I wasn't sure about the restrictions that apply in the OPAC and might differ from the ones in the staff interface. - Some numeric values are marked as such - Dates are strings in OpenAPI, but there's a way to specify the format inside the string: "format": "date". Use it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #46 from Arthur Suzuki --- Created attachment 109974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109974=edit Bug 17314: (QA follow-up) Test plan unchanged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Attachment #93762|0 |1 is obsolete|| Attachment #93763|0 |1 is obsolete|| Attachment #93764|0 |1 is obsolete|| Attachment #93765|0 |1 is obsolete|| Attachment #108380|0 |1 is obsolete|| --- Comment #44 from Arthur Suzuki --- Created attachment 109972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109972=edit Bug 17314: Routes to handle purchase suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #45 from Arthur Suzuki --- Created attachment 109973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109973=edit Bug 17314: Migration from Swagger2 to OpenApi This patch migrates the original implementation so it uses the new OpenAPI plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Lucas Gass changed: What|Removed |Added Attachment #109858|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 109971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109971=edit Bug 25321: Move translatable strings out of strings.inc into the corresponding JavaScript This patch moves string definitions out of strings.inc and into the corresponding JavaScript files. To test, apply the patch and test various pages in the staff interface: A few suggestions: - Perform a catalog search and view the detail page for a bibliographic record. - Confirm that the search results browser in the left-hand sidebar work correctly and that the title attributes of the controls are correct. - Locate a patron with multiple checkouts. View the checkout page and test the various controls in the table of checkouts: Renew, check in, return claims, etc. - View the list of holds on a patron's account. Test suspending and resuming holds. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/checkouts.js for translation, e.g.: msgid "Checked in" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 Alexis Ripetti changed: What|Removed |Added Status|NEW |Needs Signoff CC||alexis.ripe...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 --- Comment #1 from Alexis Ripetti --- Created attachment 109970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109970=edit Bug 26414: Unable to export Withdrawn status using CSV profile When using CSV profiles to export MARC records, it is impossible to export the withdrawn status. I suspect it is because withdrawn is in 952$0 and 0 is considered null rather than an actual 0. Test Plan : 1) Go to Tools > CSV profiles 2) Click on New CSV profile 3) Enter a profile name (ex. Simple record) 4) In the Profile MARC fields field enter the following (for MARC21) 245a|100a|952o|9520 5) Save your profile 6) Go to Search and search for something 7) Add a couple of things in your cart 8) Go to your cart 9) Click on Download and choose your CSV profile 10) Open the file and notice the 9520 column contains the whole of the 952 field and not just the withdrawn status 11) Apply patch 12) Redo steps 9) and 10) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26129 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19889 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #7 from Tomás Cohen Arazi --- The idea is that we have many places in which we define global configurations (sysprefs) and then override it somewhere, locally (e.g. min password length on category config). In that case, if we wanted to have a screen for managing this with a tree like structure, maybe handling all password-related configs globally or per-library or per-category, a-la circulation rules, we would benefit from this simple design and it would set a clear path forward. On bug 19889 we clearly added many configurations, in different places, and while it has the flexibility that is required, and we can give pointers to the end-user, it is clear that having a single page to manage all related things, was pointed out by the requestor as something valuable. And this generic approach on the DB might be the best way to store this. Even if we don't migrate all sysprefs into this. That said, I moved forward with an smtp_servers table and won't be back to this unless there's some interest. It felt like the right thing to do, though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26283] dateexpiry and dateenrolled are missing in the new modal for BorrowerMandatoryField and others
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||dateenrolled and dateexpiry ||fields to the list of ||fields that can be selected ||in system preferences such ||as the ||BorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 [Bug 26441] Move translatable strings out of catalog-strings.inc into catalog.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26441] New: Move translatable strings out of catalog-strings.inc into catalog.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26441 Bug ID: 26441 Summary: Move translatable strings out of catalog-strings.inc into catalog.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 21156 Strings defined for translation purposes in catalog-strings.inc can now be wrapped in the new translation function and put in catalog.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 --- Comment #1 from John Yorio --- In 18.11, and possibly prior, if a checked out item, with no remaining renewals, had a hold placed on it, the Renew column would show "On hold" as a link. In 19.11 and 20.05, the same situation, it shows "Not renewable" with a count of 0 of [the max renewals value] remaining. The "On hold" message was of more helpful to staff in determining whether or not they would try to force a renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 --- Comment #1 from Owen Leonard --- Created attachment 109969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109969=edit Bug 26439: Move cart-related strings out of js_includes.inc and into basket.js This patch moves strings defined for translation in js_includes.inc into basket.js for translation using the new double-underscore i81n function. To test, apply the patch and perform a catalog search in the staff client. - Click the Cart link in the header menu. A pop-up should appear saying "Your cart is currently empty." - On the search results page, click the "Add to cart" link next to any search result. The text should change to "In your cart." - Click the "Remove" link. The text should change to "Add to cart." - Check the box next to a title in the search results and click the "Add to cart" button in the search results toolbar. A message should appear, "1 item(s) added to your cart." - Click the "Add to cart" button again. You should see the message "No item was added to your cart (already in your cart)!" - Uncheck all check boxes on the search results page and click "Add to cart." You should see "No item was selected." - Add more items to your cart so that it contains more than one item. - Click the "Cart" link to open it. - Click the "Empty and close" button. You should be asked to confirm, "Are you sure you want to empty your cart?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/basket.js for translation, e.g.: msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26440] New: Not renewable Supersedes On Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Bug ID: 26440 Summary: Not renewable Supersedes On Hold Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jyo...@equinoxinitiative.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26007] Warning/reminder for changes to Koha to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Nind changed: What|Removed |Added Text to go in the||There are two pages where release notes||you can change the Koha to ||MARC mappings : || ||- When ||editing the configuration ||for a MARC subfield ||- On ||Koha administration > ||catalog > Koha to MARC ||mapping || ||This patch adds a ||warning that the ||batchRebuildBiblioTables ||script must be run if the ||mapping is changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5927] Show series information in Search results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #21 from Nick Clemens --- The patches here work, but they don't take into account the logic of 490/800/830 Rather than add new code, I suggest moving the code on the details page into the utilities and calling it as a template on results and details. I supplied a new patch for testing. If you agree I think we should obsolete the old patches. -Nick -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5927] Show series information in Search results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 --- Comment #20 from Nick Clemens --- Created attachment 109968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109968=edit Bug 5927: [Alternate] Show series information in staff and opac results pages This moves the series info to a template in the XSLT utils files and adds a few variables to make it work right. To test: 1 - Create a catalog records with: 440 series fields 490 traced series fields 490 untraced series fields 2 - View the details pages for these records and note the display and the links formed 3 - Apply patch 4 - Confirm the details pages look the same 5 - Search on staff and opac to return the records 6 - Confirm the results pages form the same series as on details 7 - Confirm the links work the same -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||26439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 [Bug 26439] Move cart-related strings out of js_includes.inc and into basket.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26439] New: Move cart-related strings out of js_includes.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26439 Bug ID: 26439 Summary: Move cart-related strings out of js_includes.inc and into basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 21156 Cart-related strings which were put in js_includes.inc for translation purposes can now be wrapped in the new translation function and put in basket.js Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Owen Leonard changed: What|Removed |Added Attachment #105890|0 |1 is obsolete|| --- Comment #22 from Owen Leonard --- Created attachment 109967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109967=edit Bug 24958: Remember last selected tab in SQL reports This patch modifies the saved reports page so that it remembers, for the duration of the browser session, the last active tab. To test you should have multiple reports in multiple report groups. Apply the patch and go to Reports -> Saved reports. - Select a tab to filter the table of saved reports to a particular report group. - Navigate away from the page - Return to the save reports page. The tab you previously selected should be selected again. - Restart your browser and return to the saved reports page. The tab should no longer be preselected. Update: The tabs filtering JavaScript has been moved to a separate function so that the function can be triggered by both the "create" event (when the tabs are initialized) and the "activate" event (when a tab is selected). Update II: Persistence is now enable through localStorage instead of Cookies. The localStorage item is now cleared during the logOut function. Update III: The logOut() function in staff-global.js is now called by auth.tt to ensure that tabs are not remembered across sessions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26366] system preperence no option usekohaplugin enable/disable option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26366 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26397] opac.scss calls non-existent image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard changed: What|Removed |Added Summary|opac.scss & opac.css does |opac.scss calls |call non existant image |non-existent image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26411] Adding Supplemental Issues, column headings are not labeled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26411 Owen Leonard changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 26410 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26410] Adding Supplemental Issues, column headings are not labeled.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26410 --- Comment #1 from Owen Leonard --- *** Bug 26411 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Owen Leonard changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Owen Leonard --- *** Bug 26437 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26437] New Tools Editor should have a save and continue option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26437 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 22659 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26438] Follow up to bug 23463 - return from Koha::Item overwrites existing variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438 --- Comment #1 from Colin Campbell --- Created attachment 109966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109966=edit patch to give the Koha::Item returns a unique name This renames all the Koha::Item->new returns to $kitem so as not to hide the $item variable (one case had a more restricted scope but this will guard against it causing the problem if the logic changes) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26438] New: Follow up to bug 23463 - return from Koha::Item overwrites existing variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438 Bug ID: 26438 Summary: Follow up to bug 23463 - return from Koha::Item overwrites existing variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The added calls to Koha::Item use a temporary variable called $item to store their return this hides the existing variable $item which is the lineitem being processed. Calling lineitem methods on it causes an error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26437] New: New Tools Editor should have a save and continue option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26437 Bug ID: 26437 Summary: New Tools Editor should have a save and continue option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It would be nice if there was an option in the news tool editor to save changes but also be able to continue editing that particular news item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26416] when try to restart apache2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26416 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25267] OPAC Browse Shelf feature is not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26436] New: Quick add patron will not copy over details from cities and towns pull down into patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Bug ID: 26436 Summary: Quick add patron will not copy over details from cities and towns pull down into patron details Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: drig...@equinoxinitiative.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When using the quick add patron option in koha 19.11 : If a library has cities and towns pre-populated in a drop down list and has added this field into the quick add patron form this information will not copy into the full patron form after saving. This was fixed in bug 18569 for 17.11 but is not working in 19.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #23 from Victor Grousset/tuxayo --- Can't backport to 19.05.x, the test uses next_open_days which isn't in 19.05 If someone needs this for 19.05.x, please send a patch or code extract that would allow the test to be backported. And thus ensuring that the fix works. kohadev-koha@891563ed356b:/kohadevbox/koha$ prove t/db_dependent/Calendar.t t/db_dependent/Calendar.t .. 1/8 # No tests run! # Failed test 'No tests run for subtest "weekday holidays"' # at t/db_dependent/Calendar.t line 183. # Looks like you failed 1 test of 1. # Failed test 'get_push_amt' # at t/db_dependent/Calendar.t line 184. Can't locate object method "next_open_days" via package "Koha::Calendar" at t/db_dependent/Calendar.t line 165. ...propagated at t/db_dependent/Calendar.t line 169. # Looks like your test exited with 11 just after 8. t/db_dependent/Calendar.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/8 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #22 from Victor Grousset/tuxayo --- Thanks for the notice Aleisha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 Lucas Gass changed: What|Removed |Added Attachment #109964|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 109965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109965=edit Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 109964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109964=edit Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #219 from David Gustafsson --- A small conflict in installer/data/mysql/sysprefs.sql, should now be rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100061|0 |1 is obsolete|| --- Comment #218 from David Gustafsson --- Created attachment 109963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109963=edit Bug 14957: Remove usage of deleted Koha::MarcMergeRulesModules Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100059|0 |1 is obsolete|| --- Comment #216 from David Gustafsson --- Created attachment 109961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109961=edit Bug 14957: Add icons for confirmation dialog and set preset based on actions configuration Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100058|0 |1 is obsolete|| --- Comment #215 from David Gustafsson --- Created attachment 109960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109960=edit Bug 14957: Remove prefetch of removed relationship Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100057|0 |1 is obsolete|| --- Comment #214 from David Gustafsson --- Created attachment 109959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109959=edit Bug 14957: Change YUI layout to to Boostrap Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100060|0 |1 is obsolete|| --- Comment #217 from David Gustafsson --- Created attachment 109962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109962=edit Bug 14957: Replace filter value with label if one exists Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100055|0 |1 is obsolete|| --- Comment #212 from David Gustafsson --- Created attachment 109957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109957=edit Bug 14957: Adjust paging option for new version of datatables Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100053|0 |1 is obsolete|| --- Comment #210 from David Gustafsson --- Created attachment 109955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109955=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100056|0 |1 is obsolete|| --- Comment #213 from David Gustafsson --- Created attachment 109958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109958=edit Bug 14957: Fix rule javascript validation issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Attachment #100054|0 |1 is obsolete|| --- Comment #211 from David Gustafsson --- Created attachment 109956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109956=edit Bug 14957: Make preset labels translatable Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #11 from Nick Clemens --- This works well, we should highlight the change in the release notes - in my testing nothing breaks, but we will need a full reindex for any ES site to make it work correctly. We will also need to highlight the new field for any sites using custom mapping files I added a followup - the performance doesn't seem to change greatly, but there is slight improvement on records with many items, and I think it is a bit simpler -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #10 from Nick Clemens --- Created attachment 109954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109954=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26435] New: AutoSelfCheckID syspref description should warn it blocks OPAC access
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26435 Bug ID: 26435 Summary: AutoSelfCheckID syspref description should warn it blocks OPAC access Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The OPAC blocks login of the account specified in the AutoSelfCheckID syspref (even if the AutoSelfCheckAllowed syspref is off and the account in question doesn't have self_check permissions). The descriptive text on the syspref should warn of this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #9 from Nick Clemens --- Created attachment 109953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109953=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens changed: What|Removed |Added Attachment #109659|0 |1 is obsolete|| Attachment #109660|0 |1 is obsolete|| Attachment #109951|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 109952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109952=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #7 from Nick Clemens --- Created attachment 109951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109951=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #171 from Kyle M Hall --- > 1) QA tools: > > FAIL cataloguing/additem.pl >FAIL valid > "my" variable $item masks earlier declaration in same scope Fixed! > 2) Unit tests > > Ran the database update, but tests are failing: I wasn't able to recreate your unit test failure. Can you try again? > 3) Methods > > libraries_where_can_see_patrons is added to Patron.pm > I am not sure how it fits into this functionality, maybe a leftover from an > earlier development? This subroutine is from Jonathan's patch that added group limits for viewing patrons. This patch set takes that logic and makes it more generic for use with other objects that also have branchcodes. libraries_where_can_see_patrons is the specific implementation for jonathans previous feature, which is now a wrapper around the more generic method that can also be used for items and other objects in the future. > 4) Item edit checks > > I think we might also need a check on the permission from the item search > edit item link. I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25267] OPAC Browse Shelf feature is not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267 Owen Leonard changed: What|Removed |Added Assignee|lu...@bywatersolutions.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26431] Use split button to offer choice of WYSIWYG or code editor for news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Lucas Gass changed: What|Removed |Added Attachment #109865|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 109950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109950=edit Bug 26431: Use split button to offer choice of WYSIWYG or code editor for news This patch modifies the news interface so that the user is offered a choice of editing news items using the default editor as defined by the NewsToolEditor system preference or the non-default one. To test, apply the patch and go to Tools -> News. - In the list of news items you should see an "Edit" split button in each row. - Clicking the "Edit" part of the button should open the edit view with the correct editor as defined by the NewsToolEditor preference. - Clicking the menu arrow on the button should offer the other editing method: - If NewsToolEditor is set to "WYSIWYG," the menu should offer "text editor." - If NewsToolEditor is set to "text editor," the menu should offer "WYSIWYG editor." - Test the button with the NewsToolEditor preference set to both options and confirm that the button and menu work correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26431] Use split button to offer choice of WYSIWYG or code editor for news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 109949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109949=edit Bug 26290: Make Makefile.PL aware of SMTP configs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #8 from Owen Leonard --- Created attachment 109948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109948=edit Bug 26392: Fix opac news display issue when there is no author Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Owen Leonard changed: What|Removed |Added Attachment #109943|0 |1 is obsolete|| Attachment #109944|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 109947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109947=edit Bug 26392: Wrap all translatable strings in opac-main.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #2 from Fridolin SOMERS --- Strangely we also see in @INC the template dirs : koha-tmpl/opac-tmpl and koha-tmpl/intranet-tmpl The duplicates like plugin dirs thats causes the error. With patch thoses dirs aren't duplicate anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 --- Comment #1 from Fridolin SOMERS --- Created attachment 109946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109946=edit Bug 26434: Fix plugin dirs addition to @INC Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". This bug was identified with Carrousel plugin : https://inlibro.com/instructions-carrousel/ Test plan : 1) Enable plack and plugins 2) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' 3) Install plugin KitchenSink : https://github.com/bywatersolutions/koha-plugin-kitchen-sink 4) Dont apply patch 5) Use configure on KitchenSink 6) Look at page about.pl : @INC contains server plugin dir 'var/lib/plugins' 7) Apply patch and restart plack 8) Use configure on KitchenSink 9) Look at page about.pl : @INC contains one plugin dir 'var/lib/plugins' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26280] Add unique IDs or class names for each condition in returns.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26280 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I think to make it less likely that these classes collide with classes defined elsewhere in Koha they should have a common prefix. "ret_badbarcode" or something like that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26434] New: Plugin dirs duplicates in @INC with plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434 Bug ID: 26434 Summary: Plugin dirs duplicates in @INC with plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Plugin dirs defined in koha-conf.xml are added to @INC in order to compile perl code. Looks like with plack those dirs are added several times. This may lead to an error "INCLUDE_PATH exceeds 64 directories". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10921] You can edit an order even when it is in a closed basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10921] You can edit an order even when it is in a closed basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10921 Nick Clemens changed: What|Removed |Added Attachment #109639|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 109945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109945=edit Bug 10921: Prevent an order from a closed basket to be edited We don't allow editing of orders that are part of a closed basket, but we don't enforce the rule in the controller file. This patch use output_and_exit to stop the script and display an error to the end user. Test plan: Create a basket, add an order On the basket view you see the "Modify" link, open it in a separate tab => You can edit the basket Keep this tab open, get back to the other one and close the basket Reload the tab with the order edition form => You cannot longer edit the basket QA: Do we need a check in addorder.pl as well? Signed-off-by: Henry Bolshaw Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Julian Maurice --- (In reply to Owen Leonard from comment #3) > This looks good overall but I see one issue: > > If I have the NewsAuthorDisplay set to "none" it looks like the template is > still trying to show an author. I see something like this on each news item: > > Published on 10.03.2019 by > > I think the "author" variable is getting evaluated as true even if the [% IF > %] block inside it evaluates as false. I think the "author" BLOCK belongs > inside the "[% IF ( (newsdisp == 'opac'..." You're 100% right :) Thanks Fixed in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #5 from Julian Maurice --- Created attachment 109944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109944=edit Bug 26392: Fix opac news display issue when there is no author -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Julian Maurice changed: What|Removed |Added Attachment #109666|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 109943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109943=edit Bug 26392: Wrap all translatable strings in opac-main.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26431] Use split button to offer choice of WYSIWYG or code editor for news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26431 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26407] fix query in 'title exists' in `search_for_data_inconsistencies.pl`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26407 Nick Clemens changed: What|Removed |Added Attachment #109763|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 109942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109942=edit Bug 26407: fix query in 'title exists' in `search_for_data_inconsistencies.pl` Bug 23871 added check for 'title exists' to `search_for_data_inconsistencies.pl`. There is a typo in DBIx query to create or : hashref instead of arrayref. Test plan : 1) Change title of biblio record XXX in SQL : UPDATE biblio SET title = '' WHERE biblionumber=XXX 2) Change title of biblio record YYY in SQL : UPDATE biblio SET title = NULL WHERE biblionumber=YYY 3) Run misc/maintenance/search_for_data_inconsistencies.pl 4) Check you see both records Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26407] fix query in 'title exists' in `search_for_data_inconsistencies.pl`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26407 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26301] Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Nick Clemens changed: What|Removed |Added Attachment #109791|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 109941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109941=edit Bug 26301: Use CanBookBeRenewed when renewing via self-checkout Currently, if you have OverduesBlockCirc set to "Ask for confirmation" and OverduesBlockRenewing set to "allow renewing", you get caught in a loop where you can never renew an overdue material. This patch uses CanBookBeRenewed for renewals, rather than CanBookBeIssued, which means the correct rules are applied to the correct scenario. To test: a. Set OverduesBlockCirc to "Ask for confirmation" b. Ensure "OverduesBlockRenewing" set to "allow renewing" 0. Apply the patch 1. Checkin item barcode 30001 2. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 3. Checkout item barcode 30001 to 1 year ago 4. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5. Login as the "koha" user 6. Click on "Renew item" 7. Note that the item is renewed 8. Checkin item barcode 30001 9. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 10. Checkout item barcode 30001 to 1 year ago 11. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 12. Login as the "koha" user 13. Type "30001" into the box under "Scan a new item or enter its barcode" 14. Click "Submit" 15. Note the system says the item is already checked out and it prompts you to click "Renew item" in this screen 16. Click "Renew item" 17. Note the system says "Item renewed" near the top of the screen, and the "Due" date near the bottom of the screen is more recent than the original due date 18. Checkin item barcode 30001 19. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 20. Login as the "koha" user 21. Type "30001" into the box under "Scan a new item or enter its barcode" 22. Click "Submit" 23. Note the system says "Item checked out" and the item appears in the checkouts at the bottom of the screen Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26301] Self-checkout blocks renew for overdues even when OverduesBlockRenewing allows it in opac-user.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26301 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- This looks good overall but I see one issue: If I have the NewsAuthorDisplay set to "none" it looks like the template is still trying to show an author. I see something like this on each news item: Published on 10.03.2019 by I think the "author" variable is getting evaluated as true even if the [% IF %] block inside it evaluates as false. I think the "author" BLOCK belongs inside the "[% IF ( (newsdisp == 'opac'..." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26230] Move translatable strings out of item_search_fields.tt and into item_search_fields.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26230 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26230] Move translatable strings out of item_search_fields.tt and into item_search_fields.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26230 Julian Maurice changed: What|Removed |Added Attachment #109773|0 |1 is obsolete|| --- Comment #3 from Julian Maurice --- Created attachment 109940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109940=edit Bug 26230: Move translatable strings out of item_search_fields.tt and into item_search_fields.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Item search fields. - If necessary, add a new search field. - From the table of search fields, click the "Delete" button for one of the fields. - You should get a confirmation: "Are you sure you want to delete this field?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate the string pulled from koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js for translation: #: koha-tmpl/intranet-tmpl/prog/js/item_search_fields.js:18 msgid "Are you sure you want to delete this field?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: Alexis Ripetti Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #170 from Kyle M Hall --- Created attachment 109939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109939=edit Bug 20256: (QA follow-up) Fix variable masking warning in additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #9 from Nick Clemens --- Small things: Please put change for ModBiblio in its own patch, appreciated, but not entirely related :-) You have some stray whitespace changes Blocker: Before this patch the items are stripped before saving the marc. After this patch they are not. To test: 1 - Export a record with items from Koha into a file: test.mrc 2 - perl misc/migration_tools/bulkmarcimport.pl -b -file test.mrc 3 - You will get error on adding items, but not important for this test 4 - Check the biblio_metadata table: SELECT metadata FROM biblio_metadata ORDER BY biblionumber DESC LIMIT 1\G 5 - Note no item fields 6 - Apply patch 7 - perl misc/migration_tools/bulkmarcimport.pl -b -file test.mrc 8 - Check the biblio_metadata table as above 9 - Item fields are stored in the db -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Allow setting default SMTP parameters in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #7) > (In reply to Tomás Cohen Arazi from comment #6) > > I wasn't sure it was useful. Do you think so? > > I guess that if it's useful to debian package users, it should be useful to > non-debian package users too. > That can be added in a follow-up bug, but I'm a bit worried about this > pattern of adding features to debian packages and not in Koha "core". In the > long term it could mean that it would be more and more difficult to install > Koha on non-debian systems. Hold on. Its been a while since I touched the Makefile.PL, and I'm testing my follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
