[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00 20.05.01, 19.11.07 |20.11.00 20.05.01, released in||19.11.07, 19.05.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #71 from Victor Grousset/tuxayo --- Rats, I somehow missed it, I don't know what the consequences of that miss have been. Might have been confused by my attempt to sign it off before being RMaint. Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #103996|0 |1 is obsolete|| --- Comment #20 from Aleisha Amohia --- Created attachment 110094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110094&action=edit Bug 20453: Manage sending of HOLD_MANUAL_CANCEL notice with patron messaging preferences To test: 1) Apply this patch and run database updates 2) Confirm the 'Hold manually cancelled' option shows on the patron messaging preferences table on both the staff client and the OPAC. It should be unchecked (NOT enabled). 3) Follow the test plan from the second patch "Send notice when cancelling a hold from intranet" 4) Confirm that after completing the test plan, Borrower A has not been sent any notices (Check Notices tab) 5) Check the 'Hold manually cancelled' option in the patron messaging preferences (enable). 6) Go through the previous test plan again. 7) Refresh the Notices tab each time you cancel a hold. Confirm a new notice is pending with each refresh. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #103995|0 |1 is obsolete|| --- Comment #19 from Aleisha Amohia --- Created attachment 110093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110093&action=edit Bug 20453: Send notice when cancelling a hold from intranet To test: 1) Apply patch 2) Place a reserve for Borrower A 3) Cancel the reserve from reserve/request.pl 4) Go to Borrower A's account page and look at Notices tab 5) Confirm the HOLD_MANUAL_CANCEL notice is pending 6) Place a reserve for Borrower A again 7) Go to Circulation -> Holds to pull 8) Cancel the hold 9) Repeat steps 4 and 5 10) Place a reserve for Borrower A again 11) Go to Borrower A's account page and look at the Holds table (under Check out tab or Details tab) 12) Cancel hold using 'Cancel marked holds' button 13) Repeat steps 4 and 5 Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #103994|0 |1 is obsolete|| --- Comment #18 from Aleisha Amohia --- Created attachment 110092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110092&action=edit Bug 20453: Adding notice to be sent when cancelling holds Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07|19.11.07, 19.05.15 --- Comment #40 from Victor Grousset/tuxayo --- > Rats! Conflict which I can't resolve: It was a mistake on my side. Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591
--- Comment #39 from Victor Grousset/tuxayo ---
(In reply to Mason James from comment #37)
> it will fix 19.05 installation errors on...
> deb 8, 10, 11
> ubuntu 16.04, 18.04, 20.04, 20.10
😱😱😱 okay that's a big deal.
> ps: i have applied this patch to the last 3 19.05.x package releases
Thanks a lot!
Ok backporting.
Rats! Conflict which I can't resolve:
Next is the conflict part in the diff3 conflict style. Here is the structure:
<<< HEAD
here is the code in 19.05.x before the cherry-pick
||| parent of 248978bc62... Bug 25591: Update list-deps for Debian 10 and
Ubuntu 20.04
here is the code in 19.11.x before the patch
===
here is the code in 19.11.x after the patch
>>> 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04
<<< HEAD
my $modules = C4::Installer::PerlModules->new();
my $prereqs = $modules->prereqs;
foreach my $phase ($prereqs->phases) {
foreach my $type ($prereqs->types_in($phase)) {
my $reqs = $prereqs->requirements_for($phase, $type);
||| parent of 248978bc62... Bug 25591: Update list-deps for Debian 10 and
Ubuntu 20.04
# Remove packages that are required/essential and always installed on
# a Debian system. Debian packages should not have unversioned
# dependencies on such packages.
foreach my $line (@temp) {
if ( $line ne "perl-base" ) {
@lines = ( @lines, $line );
}
}
if ( exists $overrides{$module} ) {
print "$overrides{$module}\n";
}
elsif ( scalar(@lines) == 1 && $lines[0] ne "" ) {
my $pkg = $lines[0];
print "$pkg\n";
}
elsif ( scalar(@lines) > 1 ) {
foreach my $pkg (@lines) {
print " | " if ( $pkg ne $lines[0] );
print "$pkg";
print " | $pkg" . "-5.22" if ( $pkg eq "perl-modules" );
print " | $pkg" . "-5.24" if ( $pkg eq "perl-modules" );
}
print "\n";
}
elsif ( scalar(@temp) != 0 ) {
===
# Remove packages that are required/essential and always installed on
# a Debian system. Debian packages should not have unversioned
# dependencies on such packages.
# skip perl-base and problematic version specific libperl* and
# perl-module* packages (they get installed as deps. anyway)
foreach my $line (@temp) {
if ( $line ne "perl-base" and $line !~ /^libperl5\./ and $line !~
/^perl-modules-5\./ ) {
@lines = ( @lines, $line );
}
}
if ( exists $overrides{$module} ) {
print "$overrides{$module}\n";
}
elsif ( scalar(@lines) == 1 && $lines[0] ne "" ) {
my $pkg = $lines[0];
print "$pkg\n";
}
elsif ( scalar(@lines) > 1 ) {
foreach my $pkg (@lines) {
print " | " if ( $pkg ne $lines[0] );
print "$pkg";
}
print "\n";
}
elsif ( scalar(@temp) != 0 ) {
>>> 248978bc62... Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106275|0 |1 is obsolete|| --- Comment #39 from Aleisha Amohia --- Created attachment 110090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110090&action=edit Bug 24718: (follow-up) Updated schema file For sandboxes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 --- Comment #41 from Aleisha Amohia --- (In reply to Nick Clemens from comment #32) > Hi Aleisha, > > The comment on the syspref says jobs will be run hourly - probably should > say something like: > NOTE: This system preference requires the misc/cronjobs/holds/ cronjobs. Ask > your system administrator to schedule them. Fixed > > When confirming a hold the max pickup delay is added for days correctly, > however, the time part is set to 00:00:00 - I thin it should be preserved > from original setting or set to 23:59:59 Fixed (note, this is for when setting a hold as waiting). It now preserves minutes and seconds > > t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use > 23:59:59 if time not specified? I am not sure how it is handled for checkouts The same tests in this test file fail for me, before and after the patches, so I can't test this one. Can you please paste the output for what fails and be more specific when you say 'should we accept a simple date'? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 --- Comment #40 from Aleisha Amohia --- Created attachment 110091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110091&action=edit Bug 24718: (follow-up) Update syspref description, fix expdate time when setting waiting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106274|0 |1 is obsolete|| --- Comment #38 from Aleisha Amohia --- Created attachment 110089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110089&action=edit Bug 24718: (follow-up) Removing old code This solves the JS error Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106272|0 |1 is obsolete|| --- Comment #36 from Aleisha Amohia --- Created attachment 110087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110087&action=edit Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106271|0 |1 is obsolete|| --- Comment #35 from Aleisha Amohia --- Created attachment 110086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110086&action=edit Bug 24718: Get templates working with HourBasedHolds Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106270|0 |1 is obsolete|| --- Comment #34 from Aleisha Amohia --- Created attachment 110085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110085&action=edit Bug 24718: Get reservedate and expirationdate to use datetime Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #106273|0 |1 is obsolete|| --- Comment #37 from Aleisha Amohia --- Created attachment 110088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110088&action=edit Bug 24718: Ensuring tests pass Confirm these tests pass before and after applying patches t/db_dependent/Holds.t t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/HoldsQueue.t t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Attachment #103549|0 |1 is obsolete|| --- Comment #33 from Aleisha Amohia --- Created attachment 110084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110084&action=edit Bug 24718: Introducing HourBasedHolds system preference Sponsored-by: Waikato Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26033] framapic is closing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26033 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.03, |20.11.00, 20.05.03, released in|19.11.09|19.11.09, 19.05.15 --- Comment #9 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #2 from David Cook --- I suppose one option would be to do 1 AJAX request with all the information, rather than 1 AJAX request for *each* issue. That would probably cause a performance degradation overall though. I suppose one obvious fix would be changing from UPDATE issues SET date_due = ?, renewals = ?, lastreneweddate = ? WHERE borrowernumber=? AND itemnumber=?" to: UPDATE issues SET date_due = ?, renewals = ?, lastreneweddate = ? WHERE issue_id=?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #11 from David Cook --- According to Bug 26457, the same deadlocks are still occurring. Based on Didier's report, this whole sub transaction probably made it worse? Interesting that the problem happened before adding the (too) large transaction though. In Didier's report, the lock contention seems to be due to the "WHERE borrowernumber =" causing the issuesborridx index to be locked. That shouldn't be an issue for this bug report, since there wasn't a large transaction that would cause waiting for locks... I'm guessing that some of the fine logic is slow though, and since the renewals are processed asynchronously, doing a large volume of renewals at once could cause lock contention I suppose... Anyway, best to continue this at Bug 26457... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 David Cook changed: What|Removed |Added Depends on||20086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 David Cook changed: What|Removed |Added Blocks||26457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 [Bug 26457] DB DeadLock when renewing checkout items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I'm more familiar with PostgreSQL deadlocks than MySQL deadlocks, but it looks to me like 2 separate Koha processes are trying to add renewals for different items for the same borrower, and perhaps the lock contention is over the issuesborridx index. Looking at Bug 20086, I see that those are unnecessarily large transactions. It's better to keep transactions as small as possible, especially to avoid scenarios like this. Looking at koha-tmpl/intranet-tmpl/prog/js/checkouts.js, I see that the renewals are POSTed to "/cgi-bin/koha/svc/renew" asynchronously, so that's how there would be multiple AddRenewal transactions running for the same borrower at the same time... Looking at https://dev.mysql.com/doc/refman/8.0/en/innodb-locking.html#innodb-record-locks, I think my theory is correct about the issue being contention over the issuesborridx. Now, I haven't noticed this / haven't gotten any reports of this, but I don't think we really use fines, so this report is interesting. I'm guessing that your renewals must be processed *very* slowly, and that your 2nd transaction is rolled back, because your 1st transaction is taking too long to release a lock on issuesborridx. I'd say the solution is to redo the transaction handling for C4::Circulation::AddRenewal. Didier, do you been able to reproduce this issue in koha-testing-docker? That would help in fixing the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- I agree that this was very helpful for staff. I confirmed that it doesn't work with item or record level holds. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 Aleisha Amohia changed: What|Removed |Added Text to go in the|This patch adds a new |This patch adds a new release notes|system preference |system preference |AllowRenewalIfOtherItemsAva |AllowRenewalIfOtherItemsAva |ilableLocation which works |ilableLocation which works |in conjunction with the |in conjunction with the |AllowRenewalIfOtherItemsAva |AllowRenewalIfOtherItemsAva |ilable |ilable |system preference. |system preference. |It has two options - allow |It has two options - allow |renewal if other items are |renewal if other items are |available to fill holds at |available to fill holds at |any branch, or only at the |any library, or only at the |hold's pickup branch. This |hold's pickup library. This |way, if items cannot be |way, if items cannot be |shared between branches,|shared between libraries, |the |the |AllowRenewalIfOtherItemsAva |AllowRenewalIfOtherItemsAva |ilable system preference|ilable system preference |will consider this when |will consider this when |deciding if renewal is |deciding if renewal is |allowed.|allowed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193
Aleisha Amohia changed:
What|Removed |Added
Attachment #107293|0 |1
is obsolete||
--- Comment #10 from Aleisha Amohia ---
Created attachment 110083
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110083&action=edit
Bug 25193: Add AllowRenewalIfOtherItemsAvailableLocation syspref
This syspref works in conjunction with AllowRenewalIfOtherItemsAvailable
syspref. It has two options - allow renewal if other items are available
to fill holds at any branch, or only at the hold's pickup branch.
To test:
1) Apply patch, update database, restart services
2) Go to Administration -> system preferences. Search for
AllowRenewalIfOtherItemsAvailable. Notice the two sysprefs exist in the
same row. By default they should be set to "Don't allow" and "at any
library".
3) Set up a biblio with two items. Have both items held at Branch A.
4) Check out Item A to Borrower A.
5) Place a biblio-level reserve for Borrower B with pickup branch at
Branch A.
6) View Borrower A's checkouts. Confirm you cannot renew Item A ('On
hold' message).
7) Edit Item B, set the current location to Branch B. The items should
now have different locations.
8) Enable the AllowRenewalIfOtherItemsAvailable syspref. Leave the
AllowRenewalIfOtherItemsAvailableLocation syspref set to "at any library".
9) View Borrower A's checkouts. Confirm you CAN renew Item A (because
Item B can fill Borrower B's reserve).
10) Set the AllowRenewalIfOtherItemsAvailableLocation syspref to "at the
hold's pickup library". Keep AllowRenewalIfOtherItemsAvailable syspref
enabled.
11) View Borrower A's checkouts. Confirm you CANNOT renew Item A
(because Item B cannot fill Borrower B's reserve due to being at a
different branch).
12) Edit Item B, set the current location to Branch A. The items should
have the same location now.
13) View Borrower A's checkouts. Confirm you CAN renew Item A.
Sponsored-by: Chartered Accountants Australia & New Zealand
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia changed: What|Removed |Added Version(s)||This enhancement adds released in||several new system ||preferences so that library ||can define custom SIP ||messages when a patron is ||using self-checkout: ||RenewItemSIPMessage, ||ReservedSIPMessage, ||ReservedWaitingSIPMessage, ||CheckedToAnotherSIPMessage, ||DebtSIPMessage, and ||HighHoldsSIPMessage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia changed: What|Removed |Added Version(s)|This enhancement adds |This enhancement adds released in|several new system |several new system |preferences so that library |preferences so that the |can define custom SIP |library can define custom |messages when a patron is |SIP messages to be |using self-checkout:|displayed when a patron is |RenewItemSIPMessage,|using self-checkout: |ReservedSIPMessage, |RenewItemSIPMessage, |ReservedWaitingSIPMessage, |ReservedSIPMessage, |CheckedToAnotherSIPMessage, |ReservedWaitingSIPMessage, |DebtSIPMessage, and |CheckedToAnotherSIPMessage, |HighHoldsSIPMessage.|DebtSIPMessage, and ||HighHoldsSIPMessage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What|Removed |Added Version(s)||This enhancement adds a new released in||system preference ||'DisableReserveExpiration' ||which, when enabled, will ||remove the display and ||effect of expiration dates ||in the reserves module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What|Removed |Added Attachment #100927|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 110082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110082&action=edit Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. 11) Confirm tests pass t/db_dependent/Hold.t t/db_dependent/Reserves.t Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #81 from David Cook --- (In reply to Martin Renvoize from comment #80) > I think if/when we can get the Mojo side authentication routines nailed we > can likely more easily add in native shibboleth handling at the same time > which would save us the "nasty" headers work around too :) I'm not familiar with the Shibboleth work, but I'm already sold on the idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 --- Comment #3 from Katrin Fischer --- Created attachment 110081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110081&action=edit Bug 15329: Add new column for budget to the late orders table The table currently displays the fund, but as late orders can be from a past budget with the same fund names, this can be confusing. So adding the budget in addition to the fund will be helpful. To test: - Add a basket and an order, close the basket - Go to the late oder page - Make sure your order shows up there - Apply the patch - Reload the late orders page - Verify a new column budget shows in the table - Verify the table configuration settings work for the new column - Run t/db_dependent/Koha/Acquisition/Fund.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #10 from David Cook --- (In reply to Tomás Cohen Arazi from comment #9) > This is really for multi branch sites that need more granularity. Minor > things like the default MARC organization code are defined globally and then > overridden with a new column in 'branches'. This pattern can be problematic > in my opinion, handling it on a per-case basis. > > And adding columns everywhere we want to make a syspref overridden > per-branch looks worse than NULL values. Those are good points. I've wondered a bit about branch_configurations, item_configurations, and patron_configurations, but then there are times when you need combinations of all 3, so having just one configurations table as you've done does make sense. Something about the configurations table *feels* wrong though. That said, maybe it's just my mind trying to prematurely optimize. I suppose even if you had 1000 library branches, so long as you indexed by branch, patron category, and item type... you could do a lookup pretty easily. So scale shouldn't be an issue. And having 1 big table versus smaller tables or configuration files makes it easier to add new configuration options (although possibly with a downtime cost at upgrade time for adding columns to all existing rows if you have a large configurations table but I doubt the configurations table would ever grow that large, and if it did then we could split it out more at that point). I suppose I can't think of any good reason not to do a "configurations" table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #5 from Katrin Fischer --- Created attachment 110080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110080&action=edit Bug 18050: Add relation alias to schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #4 from Katrin Fischer --- Created attachment 110079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110079&action=edit Bug 18050: [Do not push] Schema update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added Attachment #110076|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110078&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia changed: What|Removed |Added Attachment #90537|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia changed: What|Removed |Added Attachment #69809|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 110077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110077&action=edit Bug 19787: Add sysprefs to hide SIP screen messages in self checkout You'll need two patrons set up for testing the functionality of the patch. I have only created messages for the check out transaction as this was the main request. The remaining transactions can be dealt with in follow-ups. Test plan: Apply patch Update database Create your SIP librarian user Restart SIP server Go to Administration -> Preferences -> SIP Confirm that all system preferences for SIP messages are filled with default messages RenewItemSIPMessage Check out an item to Patron1 using SIP and confirm the 'Item already checked out to you: renewing item.' message shows Change the RenewItemSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately, but the item is still renewed as expected. CheckedToAnotherSIPMessage Check out an item to Patron2 in the intranet Check the same item out to Patron1 using SIP and confirm the 'Item already checked out to another person.' message shows Change the CheckedToAnotherSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out Patron1, it should stay checked out to Patron2, as expected. ReservedSIPMessage Reserve an item to Patron2 in the intranet Check out the same item to Patron1 using SIP and confirm the 'Item is reserved for another patron upon return.' message shows Change the ReservedSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1, it should stay reserved for Patron2, as expected. DebtSIPMessage Create a manual invoice for Patron1 to add some fines to their account Check out an item to Patron1 using SIP and confirm the 'Outstanding fines, block issue.' message shows Change the DebtSIPMessage syspref to another message, or leave it empty Check out the item again and confirm the message has changed appropriately. The item should not be checked out to Patron1 and their fines should not change. ReservedWaitingSIPMessage I've made this syspref but unfortunately couldn't work out where to put it as I couldn't trigger the message. I've put it where it makes sense to go (where all the other sysprefs are) but at this point, no message shows when I do the following: Reserve an item to Patron1 in the intranet Check out the item to Patron1 using SIP - I can't see a message here. Corresponding syspref is ReservedWaitingSIPMessage. HighHoldsSIPMessage Enable the decreaseLoanHighHolds syspref and any other info you need for testing. (I had 5 days for items with more than 1 hold on the record). Reserve an item to Patron1 on the intranet. Reserve the same item to Patron2 on the intranet. Check out the item to Patron1 using SIP and confirm the 'Loan period reduced for high-demand item' message shows Change the HighHoldsSIPMessage syspref to another message, or leave it empty Redo both reserves (ensure in the correct priority order) and check out the item again. Confirm the message has changed appropriately. The item should be checked out and the hold for that patron removed, as expected. Sponsored-by: Whanganui District Council -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25129] Update German (de-DE) web installer files for 20.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25129 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26007] Warning/reminder for changes to Koha to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.04 released in|| --- Comment #28 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #77 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26388] Renew all and Renew selected buttons should account for items that can't be renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26388 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.04 released in|| --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #2 from Katrin Fischer --- Created attachment 110076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110076&action=edit Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #32 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #23 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #24 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #18 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.04 released in|| CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- accessibility enhancement, choosing to backport: backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26445] Search results browser in staff has broken link back to results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26445 --- Comment #2 from Katrin Fischer --- I think it might be related to short result lists and a wrong calculation of the offset parameter. The offset defines where in the list we return to (the page... the result number), but for my result list of 3 it shows 9 - which makes a jump behind the existing results - blank page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.04 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26236] log viewer does not translate the interface properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.04 released in|| --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.04 released in|| --- Comment #12 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #78 from Lucas Gass --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.04 released in|| CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26445] Search results browser in staff has broken link back to results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26445 Elaine Bradtke changed: What|Removed |Added CC||e...@efdss.org --- Comment #1 from Elaine Bradtke --- We've seen this too, it happens only in the staff interface. It works for some records, and not others, consistently. With a list of search results, clicking on a title takes us to the bib record as expected, but when we click results to go back to the list, we get a blank results page. No error message, but no titles listed. If we sort the results list, the titles appear. As I said above, it only happens to certain records, which led me to suspect there's a problem in the MARC somewhere. Experimenting with one of them, I've tried the following: 1) Checked the record in MarcEdit - it didn't flag up any problems. 2) Replaced the offending record with a Z39.50 download from LC 3) Deleted the record and re-catalogued it using a template that we have. 4) Catalogued it completely from scratch - without a template (the template has the same problem!). No change. We still get the blank results page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 --- Comment #23 from Victor Grousset/tuxayo --- IIUC doing the necessary refactoring along with the bugfix would prevent it from being backportable. If the bug is indeed major and a fix is there it would be a shame to not have it in the current stable branches. The related instances having to wait till the upgrade to 20.11. That's option 1. option 2 would be push to master (and backport) the current bugfix and open a new ticket for the heavier refactoring. With the risk of that happening in a very distant future. option 3 would be to do the heavier refactoring and cleaner fix in the short term and when it's in master, then the bugfix from this ticket could go to the stable branches. This needs someone having the resources for doing the heavier refactoring in the short term. trade-offs everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.04 released in|| --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.04 released in|| CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Katrin Fischer changed: What|Removed |Added Depends on||18050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added Blocks||15329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 [Bug 15329] Show budget in addition to fund for late orders in acquisition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Katrin Fischer changed: What|Removed |Added Summary|Missing constraint foreign |Missing constraint on |key on table aqbudget |aqbudgets.budget_period_id ||in aqbudgets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25448] Update German (de-DE) framework files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Lucas Gass --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26253] duplicated mana_config in etc/koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26253 --- Comment #8 from Lucas Gass --- (In reply to Fridolin SOMERS from comment #7) > Can this be backported to stable branches ? I backported this for 20.05.03 but failed to update here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26253] duplicated mana_config in etc/koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26253 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| --- Comment #9 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18924] De-activating a course reserve does not update zebraqueue.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18924 --- Comment #2 from Katrin Fischer --- Hi Rogan, would you mind testing the deactivation too? Edit the course and change the checkbox setting. The items remain on the course, but they should still change back to the original value and get reindexed while the course is inactive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25566] Change in DecreaseLoanHighHolds behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25566 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.03, |20.11.00, 20.05.03, released in|19.11.09|19.11.09, 19.05.15 CC||vic...@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #1 from Owen Leonard --- Created attachment 110075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110075&action=edit Screenshot of proposed implementation I propose a solution that would automatically generate a dropdown menu for each result in itemnumber, biblionumber, cardnumber, and borrowernumber columns. Each menu would contain "View" and "Edit" options. The card number column would link to the checkout page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18924] De-activating a course reserve does not update zebraqueue.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18924 --- Comment #1 from Rogan Hamby --- Current testing shows this bug is, at least now, invalid. Using a test box with master as of 2020-09-11 took an item with location Fiction and item type BK and added it to a course as a reserve. The item type and location appropriately changed, zebraqueue updated with it and search verified the change. Upon removing the item it returned to the original attributes, a new entry to put into zebraqueue for the bib and search verified the change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14848] Fund level user restriction is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14848 --- Comment #3 from Kelly McElligott --- yes Katrin- that was it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26458] Get item details using only itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 --- Comment #1 from Owen Leonard --- Created attachment 110074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110074&action=edit Bug 26458: Get item details using only itemnumber This patch modifies moredetail.pl so that it can accept an itemnumber as a single parameter. To test, apply the patch and view a bibliographic record in the catalog which has one or more items. - In the table showing holdings, click the barcode to view the item detail page for that item. - In the location bar, modify the URL so that it uses only the itemnumber parameter, e.g. /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=1234 The page should load correctly, showing information about just that item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26458] Get item details using only itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26408] MoveReserve can fill the wrong hold when patron is not the first in line for an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26408 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #9 from Tomás Cohen Arazi --- (In reply to David Cook from comment #8) > (In reply to Tomás Cohen Arazi from comment #7) > > It felt like the right thing to do, though. > > I like the idea in theory but I'm not 100% sure how I feel about this > implementation. > > That being said, I can't point to anything technical I don't like about it > except for the large number of nulls. And the large number of nulls do make > sense for a simple design. > > I don't think I've done much work that requires anything more granular than > global-config, so I don't think that I'm best placed to comment on this > meaningfully. This is really for multi branch sites that need more granularity. Minor things like the default MARC organization code are defined globally and then overridden with a new column in 'branches'. This pattern can be problematic in my opinion, handling it on a per-case basis. And adding columns everywhere we want to make a syspref overridden per-branch looks worse than NULL values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 --- Comment #12 from Tomás Cohen Arazi --- (In reply to David Nind from comment #10) > Applying this patch seems to stop the 'Batch extend due dates' from working > as expected (for me anyway): > > - Before applying the patch: issued some items, batch extend due dates comes > up with items to extend the due date. > > - After applying the patch: Using exactly the same criteria the batch extend > due dates shows 'No checkouts for the selected filters.' Sorry for taking so long! That's correct, I used .count instead of .size, which would be the correct way of doing it as I changed into using an array. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26461] New: Incorrect handling of hold levels in SIP2 code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26461 Bug ID: 26461 Summary: Incorrect handling of hold levels in SIP2 code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com This may need to be split into 2 bugs, but problems are related. The SIP2 specification lists two fields for holds requests: AB - item identifier AJ - title identifier 1 - When placing a hold via SIP we always place a title level hold but only use the 'item identifier' to determine the biblio 2 - When cancelling a hold we use the 'item identifier' to identify the item and will only cancel an item level hold We should allow the use of the 'title identifier' for placing holds, and we should place an item level hold if 'item identifier' is passed or title level if 'title identifier' is passed with no item identifier We should do the same for cancelling. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102273|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 110073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110073&action=edit Bug 25039: Move new due date calculation to Koha::Checkout This is a follow-up patch of bug 25020. This patch adds a new method Koha::Checkout->shift_due_date that accepts the same parameters we provide in the form. It catches bad scenarios (type errors, passing both parameters when only one is accepted, and so on). Date manipulation is tested so time is kept and resulting dates are correct. The controller script is cleaned a bit to use the introduced method. I do this because: - We really need tests for this and doing it with selenium is no-end - I see a use for this new method for encapsulating behaviours, for example we might want to add Calendar support for the 'days' use case, and having the method here assures we will have tests, etc. To test: 1. Apply this patches 2. Repeat the original test plan => SUCCESS: Everything works as expected 3. Run: $ kshell k$ prove t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26460] wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26460] wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460
--- Comment #1 from Nick Clemens ---
Created attachment 110072
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110072&action=edit
Bug 26460: Fix line ending in JSON
Wrong line ending in JSON causes error:
Uncaught SyntaxError: missing } after property list
note: { opened at line 29579, column 15
To test:
1 - Have a title with some items not for hold in staff interface
2 - Set AllowHoldPolicyOverride to 'Allow'
3 - Attempt to place hold on the title
4 - Note JS error in the console and datatable does not load for items
5 - Apply patch
6 - Reload
7 - Error is cleared, table loads correctly
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Nick Clemens changed: What|Removed |Added Blocks||26460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 [Bug 26460] wrong line ending (semicolon vs comma) in request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26460] wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens changed: What|Removed |Added Depends on||23777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 [Bug 23777] Text converted to html entity codes in cataloguing edit form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26460] New: wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Bug ID: 26460 Summary: wrong line ending (semicolon vs comma) in request.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 23777 switched request.tt to use Branches plugin, but inadvertently replace the comma in the JSON with a semicolon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459
--- Comment #1 from Nick Clemens ---
Created attachment 110071
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110071&action=edit
Bug 26459: Add hold-mode option to sip_cli_emulator
To test:
1 - Apply patch
2 - Restart all
3 - Place an item level hold for a patron via the staff client
4 - Cancel the hold using the sip_cli_emulator with hold-mode: -
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --patron
{cardnumber} --item {BARCODE} -m hold -l CPL --hold-mode -
5 - Run the sip_cli_emulator with no params
6 - Verify help text is understandable
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26459] New: Allow sip_cli_emulator to handle cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 Bug ID: 26459 Summary: Allow sip_cli_emulator to handle cancelling holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
