[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #279 from Mason James --- Created attachment 110150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110150=edit Bug 22417: Update packaging files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26466] Zebra finds results in empty instance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26466 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from David Cook --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #4 from David Cook --- (In reply to didier from comment #3) > It's also our analysis, there's redundant indexes on issues which may on may > not compound the problem. > PRIMARY KEY (`issue_id`), > UNIQUE KEY `itemnumber` (`itemnumber`), > KEY `issuesborridx` (`borrowernumber`), > KEY `itemnumber_idx` (`itemnumber`), > KEY `branchcode_idx` (`branchcode`), > KEY `bordate` (`borrowernumber`,`timestamp`), > > itemnumber_idx and issuesborridx are redundant. I doubt that the indexes compound the problem, but I suppose more investigation would be needed. I see that itemnumber_idx is redundant, but how is issuesborridx redundant? It's not the same as bordate. > I'll try, maybe adding a fat sleep(5) in transaction block. Certainly worth experimenting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #111 from David Cook --- Cheers, Arthur. You're a legend :D. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia changed: What|Removed |Added Attachment #103427|0 |1 is obsolete|| --- Comment #15 from Aleisha Amohia --- Created attachment 110149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110149=edit Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108695|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108701|0 |1 is obsolete|| --- Comment #84 from Aleisha Amohia --- Created attachment 110147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110147=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #85 from Aleisha Amohia --- Created attachment 110148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110148=edit Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108699|0 |1 is obsolete|| --- Comment #82 from Aleisha Amohia --- Created attachment 110145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110145=edit Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108700|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 110146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110146=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108697|0 |1 is obsolete|| --- Comment #80 from Aleisha Amohia --- Created attachment 110143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110143=edit Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #78 from Aleisha Amohia --- Created attachment 110141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110141=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108696|0 |1 is obsolete|| --- Comment #79 from Aleisha Amohia --- Created attachment 110142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110142=edit Bug 14242: (follow up) renaming syspref OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108698|0 |1 is obsolete|| --- Comment #81 from Aleisha Amohia --- Created attachment 110144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110144=edit Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #102174|0 |1 is obsolete|| --- Comment #37 from Aleisha Amohia --- Created attachment 110139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110139=edit Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #102173|0 |1 is obsolete|| --- Comment #36 from Aleisha Amohia --- Created attachment 110138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110138=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Attachment #102175|0 |1 is obsolete|| --- Comment #38 from Aleisha Amohia --- Created attachment 110140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110140=edit Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 --- Comment #46 from Aleisha Amohia --- Nick, I didn't really know what to do other than remove dateonly flags from all the date options. I don't think it worked. Feel free to amend that last patch on my behalf. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 --- Comment #45 from Aleisha Amohia --- Created attachment 110137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110137=edit Bug 24718: (follow-up) Attempting to fix Koha REST holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/19.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nightly Build Bot changed: What|Removed |Added Attachment #107273|0 |1 is obsolete|| --- Comment #22 from Nightly Build Bot --- Created attachment 110136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110136=edit Bug 17108- Automatic debian/control updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #44 from Aleisha Amohia --- (In reply to Nick Clemens from comment #42) > It may be the problem is in api/v1/swagger/definitions/hold.json where > hold_date and expiration_date are defined as "format": "date" and may need > to be "date-time" with these patches? Thank you for the suggestion, I'll try this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #4 from Katrin Fischer --- Hi Eric, thx for adding more details to this bug report and welcome to the Koha community! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26231] bulkmarcimport.pl does not import authority if it already has a 001 field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26231 Katrin Fischer changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Katrin Fischer --- I think Bug 12722 - bulkmarcimport.pl: Should we move the old 001 to 035 would deal with the issue of the lost 001. I am adding Marcel here, if I IIRC this is related to work he did a while ago. (Bug 18014) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Alexis, I believe the tests may need a bit more work to run on different installations: Processing additional checks OK! kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Record/marcrecord2csv.t t/db_dependent/Record/marcrecord2csv.t .. 1/13 # Failed test 'normal way: headers retrieved from the DB' # at t/db_dependent/Record/marcrecord2csv.t line 53. # got: '"TITLE STATEMENT"|"SUBJECT ADDED ENTRY--TOPICAL TERM" # "The art of computer programming,Donald E. Knuth.,0;The art of another title,Donald E. Knuth. II,1"|"Computer programming.,462;Computer algorithms.,499" # ' # expected: '"Mention du titre"|Vedette-matière--Sujet # "The art of computer programming,Donald E. Knuth.,0;The art of another title,Donald E. Knuth. II,1"|"Computer programming.,462;Computer algorithms.,499" # ' # Looks like you failed 1 test of 13. t/db_dependent/Record/marcrecord2csv.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 David Nind changed: What|Removed |Added Attachment #110120|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110135=edit Bug 26470: Store the item before calling the after action hook This patch makes Koha::Item->store call $self->SUPER::store before calling the hook, so things like the itemnumber (AUTO_INCREMENT field) are available to the plugin hook. It does so by storing the output on a temporary variable, to keep the current behaviour of just returning the output from SUPER::store. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t \ t/db_dependent/Koha/Item.t \ t/db_dependent/Koha/Items.t => FAIL: the hooks tests fail. Item.t hasn't been altered so should pass 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! Item.t as well! (i.e. no behaviour change) 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 David Nind changed: What|Removed |Added Attachment #110119|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 110134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110134=edit Bug 26470: Regression tests This patch tweaks the test plugin so it composes an exception based on the fact that the hook was called with the item and item_id parameters defined. It then makes the tests expect a specific exception message with information about this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #131 from Katrin Fischer --- When checking out an item with $3 set and the syspref active, I see both the old blue 'information dialog' and the new yellow 'confirmation dialog'. The information shown is doubled up this way - I believe if we ask for confirmation the blue one should not appear? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #3 from Eric Swenson --- We are very new to community koha (just migrated this past weekend) and this is one of those features that excites us the most since we see the potential to make reporting "End of Day" totals a breeze. We currently have 2 primary locations that take payments that stay separate from each other and it would very helpful to group those locations using these register_id rather than our previous method of searching for all the possible manager_ids that might be taking payments at that location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #130 from Katrin Fischer --- Created attachment 110133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110133=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Eric Swenson changed: What|Removed |Added CC||t...@salinapublic.org --- Comment #2 from Eric Swenson --- I can also confirm that paying a total line from a different register, other than ID=1, did not log that in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 David Nind changed: What|Removed |Added Attachment #109970|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 110132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110132=edit Bug 26414: Unable to export Withdrawn status using CSV profile When using CSV profiles to export MARC records, it is impossible to export the withdrawn status. I suspect it is because withdrawn is in 952$0 and 0 is considered null rather than an actual 0. Test Plan : 1) Go to Tools > CSV profiles 2) Click on New CSV profile 3) Enter a profile name (ex. Simple record) 4) In the Profile MARC fields field enter the following (for MARC21) 245a|100a|952o|9520 5) Save your profile 6) Go to Search and search for something 7) Add a couple of things in your cart 8) Go to your cart 9) Click on Download and choose your CSV profile 10) Open the file and notice the 9520 column contains the whole of the 952 field and not just the withdrawn status 11) Apply patch 12) Redo steps 9) and 10) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 --- Comment #4 from Katrin Fischer --- Created attachment 110131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110131=edit Bug 26311: (QA follow-up) Rephrase output message This is a suggestion for rephrasing the message slightly: Before: * Patron borrowernumber=15 in category 'J' has invalid age '56' After: * Patron borrowernumber=37 has an invalid age of 37 for their category 'K' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Katrin Fischer changed: What|Removed |Added Attachment #110106|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110130=edit Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl Patron categories may have age limits. Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of patrons which age is invalid regarding there category. Test plan : 1) Create an adult patron category limited to 18-99 years 2) Create a patron in the category 3) Edit in database its date of birth so that he is 17 years old 4) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the patron Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer changed: What|Removed |Added Attachment #110055|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 110129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110129=edit Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer changed: What|Removed |Added Attachment #109702|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 110128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110128=edit Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #16 from David Nind --- Hi Aleisha. Everything worked for me a per the test plan, and the tests passed, so I have signed off. Just a couple of things I noted, which are probably more for the QA team than me 8-) : - Everywhere else in the UI it refers to holds rather than reserves: should the system preference name by HideHoldExpiration instead? - For a patron, under Details > Holds the Expiration column is still shown. Should this be the case? (I'm not sure whether this is used for other holds/reserves things). David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 David Nind changed: What|Removed |Added Attachment #110082|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 110127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110127=edit Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. 11) Confirm tests pass t/db_dependent/Hold.t t/db_dependent/Reserves.t Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Katrin Fischer changed: What|Removed |Added Attachment #106851|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 110126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110126=edit Bug 15933: Add cataloguing plugin to search for existing publishers in other records This patch adds a new cataloging plugin for MARC21 installations, marc21_field-260b.pl. When enabled it provides autocomplete for publisher name, pulling existing data from biblioitems.publishercode. To test, apply the patch and enable the plugin: - Go to Administration -> MARC bibliographic framework -> MARC structure -> 260 -> Edit subfields -> Subfield b -> Other options. - Set "Plugin" to marc21_field_260b.pl. - Go to Cataloging and edit or create a record. - Under tab 2 click the field for 260$b. Start typing a publisher name. A dropdown should appear with matching publishers. - Selecting one of the results should populate the form field with that information. Signed-off-by: Sally Signed-off-by: Katrin Fischer Also works with 264$b. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Katrin Fischer changed: What|Removed |Added Attachment #110110|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 --- Comment #9 from Katrin Fischer --- It looks like something went wrong here with the sandboxes, I'll fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Katrin Fischer --- Taking the chance to count myself as QA here after David's sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26467] Allow multiple display locations to be added in news tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26467 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- +1 this would be especially helpful for consortium with districts inside. Right now if our 7-branch district wants news somewhere just for our patrons I need to make 7 news entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Katrin Fischer changed: What|Removed |Added Attachment #110112|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110125=edit Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 Katrin Fischer changed: What|Removed |Added Attachment #110114|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110124=edit Bug 26325: Add primary_key_exists check to C4::Installer To test: 1 - prove -v t/db_dependent/Installer.t Signed-off-by: Brandon J Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26420] Overdue notices script does not care about borrower's language, always takes default template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26420] Overdue notices script does not care about borrower's language, always takes default template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26420 Katrin Fischer changed: What|Removed |Added Attachment #110036|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110123=edit Bug 26420: Use translated notices for overdue_notices.pl This script does not pass the patron's preferred lang for notices. Test plan: Enable TranslateNotices Create a patron with a preferred lang for notices != default Translate ODUE for this language Setup the overdue notices for this patron's category Check an item out for this patron (select the correct due date to trigger the notice) Run the script overdue_notices.pl Check the message_queue table and confirm that the notice enqueued is translated Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26458] Get item details using only itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 Katrin Fischer changed: What|Removed |Added Attachment #110099|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110122=edit Bug 26458: Get item details using only itemnumber This patch modifies moredetail.pl so that it can accept an itemnumber as a single parameter. To test, apply the patch and view a bibliographic record in the catalog which has one or more items. - In the table showing holdings, click the barcode to view the item detail page for that item. - In the location bar, modify the URL so that it uses only the itemnumber parameter, e.g. /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=1234 The page should load correctly, showing information about just that item. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26458] Get item details using only itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26458 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 110119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110119=edit Bug 26470: Regression tests This patch tweaks the test plugin so it composes an exception based on the fact that the hook was called with the item and item_id parameters defined. It then makes the tests expect a specific exception message with information about this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26462] t/db_dependent/Holds.t tests delete data unnecessarily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Katrin Fischer changed: What|Removed |Added Attachment #110104|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 110121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110121=edit Bug 26462: Don't delete existing data for tests These tests generate their own items, patrons, and circ rules. Existing system data will not affect the results of the tests. We do not need to delete information. You may be able to notice the difference in speed of tests depending on your system. It should be faster after applying To test: 1 - Before applying patch: prove -v t/db_dependent/Holds.t 2 - It passes 3 - Apply patch 4 - prove -v t/db_dependent/Holds.t 5 - It passes Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26462] t/db_dependent/Holds.t tests delete data unnecessarily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26462 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 110120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110120=edit Bug 26470: Store the item before calling the after action hook This patch makes Koha::Item->store call $self->SUPER::store before calling the hook, so things like the itemnumber (AUTO_INCREMENT field) are available to the plugin hook. It does so by storing the output on a temporary variable, to keep the current behaviour of just returning the output from SUPER::store. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t \ t/db_dependent/Koha/Item.t \ t/db_dependent/Koha/Items.t => FAIL: the hooks tests fail. Item.t hasn't been altered so should pass 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! Item.t as well! (i.e. no behaviour change) 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26464] Code correction in opac-main when news_id passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26464 Katrin Fischer changed: What|Removed |Added Attachment #110105|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 110118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110118=edit Bug 26464: Code correction in opac-main when news_id passed Theoretical change. If somehow the search would return more than one result, the code is wrong. The if test can be simplified: remove scalar and >0. We should not pass @array to one param. It would theoretically add wrong items or trigger an odd number warning. If it is only one, it is no problem. But it is buggy. Test plan: Pass an existing news_id to opac-main. Item visible? And pass a not-existing. Error message? Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26464] Code correction in opac-main when news_id passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26464 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26421] Use Bootstrap screen reader text class for shelf browser messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Katrin Fischer changed: What|Removed |Added Attachment #110058|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 110117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110117=edit Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." Signed-off-by: Stina Hallin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26421] Use Bootstrap screen reader text class for shelf browser messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #21 from Joe Sikowitz --- I set this back to the "Needs Signoff" status even though the first iteration already went to QA and failed. I'm not sure if this is the correct process, but it's been pending for a while. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 [Bug 26470] itemnumber not available for plugin hook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Depends on||22709 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 [Bug 22709] Add hooks to notify plugins of biblio and item changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26470] New: itemnumber not available for plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 Bug ID: 26470 Summary: itemnumber not available for plugin hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The way the hook got placed in Koha::Item->store, it doesn't get the itemnumber populated by the DB. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Katrin Fischer changed: What|Removed |Added Attachment #110111|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 110116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110116=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. Signed-off-by: Brandon J Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Andrew Fuerste-Henry changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 --- Comment #1 from Andrew Fuerste-Henry --- Verified that the register is recorded incorrectly regardless of which pay button one uses (Pay, Pay Selected, or Pay Amount) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26469] New: Register_id saves incorrect value in accountlnes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26469 Bug ID: 26469 Summary: Register_id saves incorrect value in accountlnes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: - turn on cash registers in sysprefs - define at least 2 cash registers in Admin - create a manual invoice on a patron - pay off half of your fee, selecting the first register - pay off the remaining fee, selecting the second register - query accountlines.register_id for your two payments - see that they both show the first register confirmed in master and 19.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1 from Donna --- The item search is so helpful for users, adding a damaged status limiter would be amazing!!! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26468] New: Item search should include a way to limit by damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26468 Bug ID: 26468 Summary: Item search should include a way to limit by damaged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org On itemsearch.pl you can limit by LOST or WITHDRAWN statuses but not by DAMAGED status. It would be neat if that was added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26467] New: Allow multiple display locations to be added in news tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26467 Bug ID: 26467 Summary: Allow multiple display locations to be added in news tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When configuring a news items for display you can leave the display location blank, which adds your news item in all possible display locations OR you can select a single display location. It would be neat if you could select multiple display locations for a news item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #269 from Joonas Kylmälä --- Created attachment 110115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110115=edit Bug 20447: (follow-up) Prevent internal server error with Attach item feature If one tried to use the "Edit -> Attach item" feature in biblio detail.pl page then the following error would come if the item was not attached to any holdings record: "DBIC result _type isn't of the _type Holding" This fix prevents the error by skipping the creation of Holding object if the result set is empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26460] wrong line ending (semicolon vs comma) in request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26445] Search results browser in staff has broken link back to results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26445 --- Comment #3 from Elaine Bradtke --- I don't think the list length makes a difference. From the last record in a list of 1987 records, we get offset=195101 Other interesting behaviours from this long list. It seems like records in the first few pages of results work, but when you go back to results, it advances to the next page of results. If the record is on the first page of results, going back to results lands you on the second page of results and so on. Records towards the end of the list give a blank page. It's almost as if something is increasing the number of records the system is trying to retrieve. In a long list, some will work, but eventually it starts looking for more records than are in the results. There be dragons! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Katrin Fischer --- Hi Sally, I can see your sign-off line - switching status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 Brandon J changed: What|Removed |Added Attachment #109372|0 |1 is obsolete|| --- Comment #2 from Brandon J --- Created attachment 110114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110114=edit Bug 26325: Add primary_key_exists check to C4::Installer To test: 1 - prove -v t/db_dependent/Installer.t Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26325] Add primary_key_exists function to Installer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26325 Brandon J changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 --- Comment #3 from Owen Leonard --- Did you apply Bug 26118 first? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26089] Add acquisitions-related reports to acquisitions sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26089 Brandon J changed: What|Removed |Added Attachment #107515|0 |1 is obsolete|| --- Comment #2 from Brandon J --- Created attachment 110113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110113=edit Bug 26089: Add acquisitions-related reports to acquisitions sidebar menu This patch adds links to two acquisitions-related reports in the sidebar menu shown on acquisitions pages: Acquisitions statistics wizard and orders by fund. To test, apply the patch and go to the Acquisitions page. - If you are logged in as a user with permission to access reports you should see a new "Reports" heading in the sidebar menu and links to two reports. - Confirm that the links work correctly. - Log in as a user without reports permission and confirm that the section doesn't appear. Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26466] New: Zebra finds results in empty instance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26466 Bug ID: 26466 Summary: Zebra finds results in empty instance Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: anke.br...@gwdg.de QA Contact: testo...@bugs.koha-community.org Koha still finds results for bib records even though all bib records have been deleted from the instance. Zebra index has been rebuilt with option -f after deleting, so I would expect no search results at all. The search results lead to empty records anyway, but they shouldn't be there at all. What else has to be deleted exept items, deleteditems, biblioitems, deletedbiblioitems, biblio, deletedbiblio, biblio_metadata, deletedbibliometadata so that Zebra won't find anything after rebuilding? Is there another way to empty a Koha instance of its bib records apart from TRUNCATE-ing the tables mentioned above in the database? Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26120] Remove the use of jquery.checkboxes plugin from tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26120 Brandon J changed: What|Removed |Added CC||brandon.jime...@inlibro.com --- Comment #2 from Brandon J --- Tried to sign-off got error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Brandon J changed: What|Removed |Added Attachment #107854|0 |1 is obsolete|| --- Comment #2 from Brandon J --- Created attachment 110112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110112=edit Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Brandon J changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Brandon J changed: What|Removed |Added Attachment #108565|0 |1 is obsolete|| --- Comment #3 from Brandon J --- Created attachment 110111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110111=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26178] When executing a title search in the OPAC for titles that contain "/" in the main title, the search results do not display the entire title. Is "/" a "stop term"?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26178 --- Comment #5 from Owen Leonard --- (In reply to Katrin Fischer from comment #4) > Owen, can you replicate the problem? No, I was simply reposting the attachment as something more easily viewed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26245] Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Brandon J changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 --- Comment #7 from PTFS Europe Sandboxes --- Created attachment 110110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110110=edit Bug 23682: DBRev 20.06.00.035 Signed-off-by: Jonathan Druart Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/