[Koha-bugs] [Bug 8338] Add ability to remove fines with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #61 from Martin Renvoize --- (In reply to Aleisha Amohia from comment #53) > Patches do not apply cleanly on 19.11.x. Please rebase if needed. I just wish it had been made clear it wouldn't be backported even if rebased rather than suggested it would.. I've wasted time working on it and cannot afford to waste any more time now. All good.. dropping it and putting it down as experience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry errors information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 --- Comment #4 from Martin Renvoize --- I'm in favour of such a standardised way of adding operational feedback for non-fatal errors/information passing. We introduced such a use case in the Koha::Item trigger for when lost items are marked as found. Having a standardised approach to passing such information around in the object would be great.. I've already found a few more cases for such feedback and it allows for continued moves toward fluent (chainable) interfaces. Perhaps 'messages' is the best name for this as we already have exceptions for fatal errors, and I can see where Jonathan is coming from with your comment Tomas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #26 from Julian Maurice --- (In reply to Martin Renvoize from comment #25) > Code speaks more than words.. I've been having a play with a couple of > followups to use a 'key' rather than rely on the string as the key for > lookup, adding 'fuzzy' support and re-introducing an accessor method on the > Koha::ItemType object: > > https://gitlab.com/mrenvoize/Koha/-/commits/bug_24975 > > Still a work in progress but would love some feedback as to whether this > might be a route to adopt. Does it solve the problem we mentioned with framework translations ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23579] error during web install: 'changed_fields' can't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 sriram lamsal changed: What|Removed |Added CC||sriramlam...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #6 from Fridolin SOMERS ---
I see the error when upgrading from 19.11 :
DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MariaDB server version for the right syntax to
use near '' at line 1 [for Statement "
INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`,
`explanation`, `type` ) VALUES
('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost
statuses by default in longoverdue.pl', 'Free'),
"] at ./src/installer/data/mysql/updatedatabase.pl line 22388.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26552] Batch extend due date previews new due date as 00:00, but actually it's 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26552 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jonathan Druart --- This is caused by bug 25039 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548
--- Comment #7 from Fridolin SOMERS ---
(In reply to Fridolin SOMERS from comment #6)
> I see the error when upgrading from 19.11 :
>
> DBD::mysql::db do failed: You have an error in your SQL syntax; check the
> manual that corresponds to your MariaDB server version for the right syntax
> to use near '' at line 1 [for Statement "
> INSERT IGNORE INTO systempreferences ( `variable`, `value`,
> `options`, `explanation`, `type` ) VALUES
> ('DefaultLongOverdueSkipLostStatuses', '', NULL, 'Skip these lost
> statuses by default in longoverdue.pl', 'Free'),
> "] at ./src/installer/data/mysql/updatedatabase.pl line 22388.
By changing in installer/data/mysql/updatedatabase.pl :
- local $dbh->{RaiseError} = 0;
+ local $dbh->{RaiseError} = 1;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #22 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > (In reply to David Nind from comment #18) > > (In reply to Tomás Cohen Arazi from comment #15) > > > Naw, it was just I forgot to commit the updated dates to the DB. > > > > It all works now and have signed off! > > > > One minor thing I noticed was that in the preview table listing changes to > > be made it shows the new due date as (for example) 09/21/2020 00:00 > > > > When applied the new due date is shown as 09/21/2020 23:59 on the item > > record and in the patron's circulation history. > > > > This may or may not be an issue... > > Hi David, I've added a new bug for this: > > Bug 26552 - Batch extend due date previews new due date as 00:00, but > actually it's 23:59 This is the behaviour with this patch set, not master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #27 from Martin Renvoize --- We key on new 'key' field. So it leaves it up to the person whome implements the next translatable feature to pick an appropriate key. For frameworks I would suggest a group of 'framework' and a key of 'marc field'.. thus allowing to translate at the default framework level but keep marc fields distinct for the cases as mentioned by Jonas on IRC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Fridolin SOMERS changed: What|Removed |Added Attachment #110876|0 |1 is obsolete|| --- Comment #8 from Fridolin SOMERS --- Created attachment 110887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110887&action=edit Bug 26548: Fix typo in updatedatabase Test plan: 1. On 20.05.x run updatedatbase and see an error 2. Apply patch 3. Re-run updatedatabase without an error https://bugs.koha-community.org/show_bug.cgi?id=25958 Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 --- Comment #9 from Fridolin SOMERS --- Commit in master in indeed OK : git show 385a4cba44c5ac56d334d5ac4f8acd69d17375e9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26552] Batch extend due date previews new due date as 00:00, but actually it's 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26552 --- Comment #5 from David Nind --- Created attachment 110888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110888&action=edit Bug 26552 - Screenshots of date-times displayed Screenshots showing how dates and date/times shown when using the batch extend due dates tool - after Bug 25039 applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26552] Batch extend due date previews new due date as 00:00, but actually it's 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26552 David Nind changed: What|Removed |Added Depends on||25039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 [Bug 25039] Move new due calculation to Koha::Checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 David Nind changed: What|Removed |Added Blocks||26552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26552 [Bug 26552] Batch extend due date previews new due date as 00:00, but actually it's 23:59 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #124 from Jonathan Druart --- For information, the package does not exist in Jessie and Xenial (U16) https://gitlab.com/koha-community/koha-testing-docker/-/pipelines/195722968 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 --- Comment #23 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > (In reply to Katrin Fischer from comment #19) > > (In reply to David Nind from comment #18) > > > (In reply to Tomás Cohen Arazi from comment #15) > > > > Naw, it was just I forgot to commit the updated dates to the DB. > > > > > > It all works now and have signed off! > > > > > > One minor thing I noticed was that in the preview table listing changes to > > > be made it shows the new due date as (for example) 09/21/2020 00:00 > > > > > > When applied the new due date is shown as 09/21/2020 23:59 on the item > > > record and in the patron's circulation history. > > > > > > This may or may not be an issue... > > > > Hi David, I've added a new bug for this: > > > > Bug 26552 - Batch extend due date previews new due date as 00:00, but > > actually it's 23:59 > > This is the behaviour with this patch set, not master. Thx Joubu, sorry for missing the connection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #28 from Martin Renvoize --- What I'm also tempted to do is add a standardly named accessor be to objects with translatable fields.. ->translation_key which would produce the right key from the internal fields behind the scenes. So for itemtype it simply passes through itemtype, but for a it might pass $code_$interface for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
--- Comment #29 from Julian Maurice ---
(In reply to Martin Renvoize from comment #27)
> We key on new 'key' field. So it leaves it up to the person whome implements
> the next translatable feature to pick an appropriate key.
>
> For frameworks I would suggest a group of 'framework' and a key of 'marc
> field'.. thus allowing to translate at the default framework level but keep
> marc fields distinct for the cases as mentioned by Jonas on IRC.
I'm confused. Do you mean something like
db_t('framework', 'marc field', { marc_field => '245a', type => 'opac' })
or
db_t('framework', '245a-opac')
or
db_t('framework-FW1', '245a-opac')
or something else ?
I could not find what Jonas mentioned on IRC, that probably doesn't help me to
understand :) Can you paste it or summarize it here ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Attachment #108002|0 |1 is obsolete|| --- Comment #5 from Fridolin SOMERS --- Created attachment 110889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110889&action=edit Bug 24598: Add tests Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Attachment #108003|0 |1 is obsolete|| --- Comment #6 from Fridolin SOMERS --- Created attachment 110890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110890&action=edit Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Jonathan Druart changed: What|Removed |Added Blocks||26523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26523 [Bug 26523] In reserve/request.pl biblioitemnumber is used where biblionumber is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS --- Nice work. Test plan and unit test are OK. I add to rebase a bit unit test patch. Also changed a bit the test plan : - 1) Place an item on hold at Library A for Patron 1 at Library B + 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B Because I forgot twice to change pickup library ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26523] In reserve/request.pl biblioitemnumber is used where biblionumber is required.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26523 Jonathan Druart changed: What|Removed |Added Depends on||24185 Version|20.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26523] In reserve/request.pl biblioitemnumber is used where biblionumber is required.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26523 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- biblioitemnumber and biblionumber must be contain the same value. If not you are going to face some oddities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26538] Display cities list before input text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #6 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #5) > Oh I found why, I'm on a patch Bug 26556 is now in master (whaoo fast). You can test again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26559] New: koha-create fails to upgrade database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26559
Bug ID: 26559
Summary: koha-create fails to upgrade database
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Packaging
Assignee: koha-bugs@lists.koha-community.org
Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: m...@kohaaloha.com
When I run koha-create, with DEFAULTSQL set to the path of an existing database
dump, I get an error when it tries to upgrade the database:
$ sudo koha-create --create-db --letsencrypt --configfile student.conf mykoha
staff user password is '***' but keep that secret
Upgrading database schema for mykoha
DBI connect('database=koha_mykoha;host=localhost;port=3306','koha_mykoha',...)
failed: Access denied for user 'koha_mykoha'@'localhost' (using password: YES)
at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1517.
DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied
for user 'koha_mykoha'@'localhost' (using password: YES) at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at
/usr/share/koha/lib/Koha/Database.pm line 116
After this, the Apache config file is created at
/etc/apache2/sites-available/mykoha.conf, but the symlink at
/etc/apache2/sites-enabled/mykoha.conf is not created.
I can run koha-mysql and get access to the database, where the data from
DEFAULTSQL has been loaded.
If I comment out line 734 of koha-create:
koha-upgrade-schema "$name"
things run as expected, and the Apache config symlink is created.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26232] undefined fine grace period kills koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26232 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26560] New: Perl Modules Missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26560 Bug ID: 26560 Summary: Perl Modules Missing Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: dhanabal...@gmail.com QA Contact: testo...@bugs.koha-community.org Hi All I am new to koha. When i installed koha 20.04 in ubuntu 18.04, i got some error, like, perl modules missing How to fix it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25548 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=7607 CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin SOMERS --- Ah and it causes Bug 7607 +1 to remove useless rewrites. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Bug 24167 depends on bug 25591, which changed state. Bug 25591 Summary: Update list-deps for Debian 10 and Ubuntu 20.04 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26109] Update list-deps for Koha 19.05.x to support Debian 8 and 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26109 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Has this been fixed by bug 25591? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25640] [OMNIBUS] Ubuntu 20.04 support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 Bug 25640 depends on bug 25591, which changed state. Bug 25591 Summary: Update list-deps for Debian 10 and Ubuntu 20.04 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26414] Unable to export Withdrawn status using CSV profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26414 David Nind changed: What|Removed |Added Text to go in the||This patch fixes the export release notes||of MARC records and the ||withdrawn status when using ||CSV profiles. Before this ||fix the full 952 field was ||exported, rather than just ||the withdrawn status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
--- Comment #30 from Martin Renvoize ---
(In reply to Julian Maurice from comment #29)
> (In reply to Martin Renvoize from comment #27)
> > We key on new 'key' field. So it leaves it up to the person whome implements
> > the next translatable feature to pick an appropriate key.
> >
> > For frameworks I would suggest a group of 'framework' and a key of 'marc
> > field'.. thus allowing to translate at the default framework level but keep
> > marc fields distinct for the cases as mentioned by Jonas on IRC.
>
> I'm confused. Do you mean something like
> db_t('framework', 'marc field', { marc_field => '245a', type => 'opac' })
> or
> db_t('framework', '245a-opac')
> or
> db_t('framework-FW1', '245a-opac')
> or something else ?
>
> I could not find what Jonas mentioned on IRC, that probably doesn't help me
> to understand :) Can you paste it or summarize it here ?
db_t('framework', '245a');
or if you need it at an interface level too
db_t('framework', '245a-opac');
i.e. We leave defining the granularity of the key to the developer adding the
translation option to the component and we discus that granularity there.
What I've not done is any form of fallback system.. i.e. if we wanted to allow
one to optionally define translations at a more granular level, for per
framework for example.
example
db_t('framework', 'FA-245a');.. fall back to just '245a' if the 'FA-'
translation doesn't exist. I felt that was out of scope for here.. and perhaps
not really required.
I'll go dig out the IRC log.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- % git grep MSG_LOADING returns only 2 occurrences in js/z3950_search.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #31 from Martin Renvoize --- >kohaputti maybe 013e and 583l could use different translations in finnish, 583l = "Kunto" and 013l = "Tila" I mean you could translate Kunto also as Tila I guess so not the best example but someone could do it like this... >kohaputti a safe bet here would be frameworks+field+subfield, the meaning cannot change between different frameworks, can it? Also, why even allow changing the descriptions for each framework separately -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25320] Move translatable strings out of merge-record-strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart --- Include file still used in authorities/merge.tt koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt:[% INCLUDE 'merge-record-strings.inc' %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #32 from Martin Renvoize --- To add detail to that.. it's two different translations for the single word 'Status' in English for the Finnish translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
--- Comment #33 from Julian Maurice ---
(In reply to Martin Renvoize from comment #30)
> db_t('framework', 'FA-245a');.. fall back to just '245a' if the 'FA-'
> translation doesn't exist. I felt that was out of scope for here.. and
> perhaps not really required.
The problem with that is that we don't know if we should fall back. 245a may
have a completely different description in FA than in default framework. (Well
maybe not for 245a, but you get the point)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26389] OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin SOMERS --- System preference OpacRenewalAllowed must be on "Allow" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #34 from Martin Renvoize --- My point is.. I've tried to make it flexible enough without introducing too much additional overhead/code complexity here. I suggest we should not second guess the level of translation requirements/granularity of different components here but rather defer that to each bug introducing additional translation options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26561] New: Number on claims tab not showing when translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26561 Bug ID: 26561 Summary: Number on claims tab not showing when translated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr, k...@bywatersolutions.com In German we only see: / Claim(s) (or Rückgebebehauptungen...) when there should be 0 / 0 be displaying in the patron account in staff. I believe we have had similar problems in the past with 0 values? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26523] In reserve/request.pl biblioitemnumber is used where biblionumber is required.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26523 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26242] Move translatable strings out of results.tt and into results.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26242 --- Comment #4 from Jonathan Druart --- Created attachment 110891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110891&action=edit Bug 26242: Remove one unused occurrences of MSG_NON_RESERVES_SELECTED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26389] OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26389] OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Fridolin SOMERS changed: What|Removed |Added Attachment #109685|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 110892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110892&action=edit Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26389] OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 --- Comment #3 from Fridolin SOMERS --- (In reply to Lucas Gass from comment #1) > Created attachment 109685 [details] [review] > Bug 26389: Add auto renewal error to opac-user.tt > > Test plan: > 1 Check out an auto-renewing item to a patron > 2 confirm in circ rules that the rule allows at least one renewal > 3 log into OPAC, confirm your summary shows item is scheduled for > auto-renewal > 4 click Renew All I was able to display "Renew All" when item is in auto-renewal. But one can run directly the URL to simulate it : /cgi-bin/koha/opac-renew.pl?from=opac_user&item=&borrowernumber= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 --- Comment #8 from Jonathan Druart --- Created attachment 110893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110893&action=edit Bug 25321: Remove PLACE_HOLD from results.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26322] REST API plugin authorization is not checked anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26322 --- Comment #29 from Joonas Kylmälä --- Reminding that this should be pushed to master as well given it is in the released versions now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26425] Fix history.txt once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize changed: What|Removed |Added Attachment #109887|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 110894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110894&action=edit Bug 26425: Manual changes Patches will be squashed when pushed. Here the changes are done manually, we add the missing 0 for the releases after 3.00.00 (with alpha, beta, etc) And we remove all the laters, that will added automatically by the release script Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 --- Comment #2 from Fridolin SOMERS --- Whaoo super, I had this issue when playing with plugins install. All perl is broken if a plugins is broken or its source removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Fridolin SOMERS changed: What|Removed |Added Attachment #105143|0 |1 is obsolete|| --- Comment #3 from Fridolin SOMERS --- Created attachment 110896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110896&action=edit Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26425] Fix history.txt once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize changed: What|Removed |Added Attachment #109888|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 110895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110895&action=edit Bug 26425: Update history.txt With the modifications brought by https://gitlab.com/koha-community/release-tools/-/issues/18 After the manual changes we can run the script with the 3 commits from the issue #18 of release-tools. * Add missing whitespace to align the dates * Add all the releases (from the tag list) after 3.00.00 There is no change in the developers numbering, neither in the wording. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26425] Fix history.txt once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- As basically a string patch, and having dug deeply into the history of the project myself a few times on route to this point.. I think we can safely call it a PQA too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Fridolin SOMERS changed: What|Removed |Added Depends on||23191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 [Bug 23191] Administrators should be able to install plugins from the command line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26425] Fix history.txt once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Discussed and agreed on IRC.. I'm happy with these patches moving us to a more consistent state :) Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Fridolin SOMERS changed: What|Removed |Added Blocks||25549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 [Bug 25549] Install plugin script/method should remove broken plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 Martin Renvoize changed: What|Removed |Added Blocks||21883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 [Bug 21883] Show authorized value description for withdrawn in check-in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 David Nind changed: What|Removed |Added Attachment #110843|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 110897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110897&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||26323 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26323 [Bug 26323] Not_for_loan, damaged, location and ccode values must be retrieved from the correct AV category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 David Nind changed: What|Removed |Added Attachment #110853|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 110898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110898&action=edit Bug 24223: (follow-up) Add date to OpacNav news entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #120 from Martin Renvoize --- This would be a good use case for bug 26555.. but I'd really like to see this move first and I can followup to convert to using that bug once it's moved forwards. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap 'items available for pick-up' note when placing a hold in the OPAC in a div element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #10 from Jonathan Druart --- class="note"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26137] Warn on malformed param on log viewer (viewlog.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26137 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Fridolin SOMERS --- Needs a rebase since Bug 25893 is integrated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26519] Clean up OPAC buttons with incorrect classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26519] Clean up OPAC buttons with incorrect classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 David Nind changed: What|Removed |Added Attachment #110658|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 110900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110900&action=edit Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26563] New: Merging patrons will cause the "time queued" column in the message queue to be updated to the current date and time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26563 Bug ID: 26563 Summary: Merging patrons will cause the "time queued" column in the message queue to be updated to the current date and time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The column time_queued is considered by librarians to be either the time a message was created ( if pending ), or the time a message was sent. Merging patrons will cause this column to be updated, making it look like the message was sent far more recently. It might be worth considering adding a new column for datetime_created, and datetime_sent, while leaving the existing column alone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap 'items available for pick-up' note when placing a hold in the OPAC in a div element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #11 from Katrin Fischer --- Hi Jonathan, as the stated intention here was to be able to change the text, a specific class (or id) makes more sense. With possibly changing translations hooking the jQuery on a test or word is not ideal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26184] Wrap 'items available for pick-up' note when placing a hold in the OPAC in a div element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26184 --- Comment #12 from Katrin Fischer --- test = text... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #22) > (In reply to Katrin Fischer from comment #19) > > (In reply to David Nind from comment #18) > > > (In reply to Tomás Cohen Arazi from comment #15) > > > > Naw, it was just I forgot to commit the updated dates to the DB. > > > > > > It all works now and have signed off! > > > > > > One minor thing I noticed was that in the preview table listing changes to > > > be made it shows the new due date as (for example) 09/21/2020 00:00 > > > > > > When applied the new due date is shown as 09/21/2020 23:59 on the item > > > record and in the patron's circulation history. > > > > > > This may or may not be an issue... > > > > Hi David, I've added a new bug for this: > > > > Bug 26552 - Batch extend due date previews new due date as 00:00, but > > actually it's 23:59 > > This is the behaviour with this patch set, not master. Are you sure? Date arithmetic is exactly the same. Isn't this highlighting some other bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26564] New: Default field_config.yaml should be under /etc/koha/searchengine instead of /usr/share/koha/...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26564 Bug ID: 26564 Summary: Default field_config.yaml should be under /etc/koha/searchengine instead of /usr/share/koha/... Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com The default field_config.yaml file for elasticsearch is found in the intranet share source directly.. as a config file I believe it should be found under etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26564] Default field_config.yaml should be under /etc/koha/searchengine instead of /usr/share/koha/...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26564 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 --- Comment #15 from Emmi Takkinen --- (In reply to Fridolin SOMERS from comment #14) > Hi, nice work. > > Just a question : > I see in first patch : $password =~ /[a-zA-ZöäåÖÄÅ]/ > I don't see the caracters öäå in patch on password_check.inc. > > Should we use POSIX =character class like [:alnum:] ? > https://www.regular-expressions.info/posixbrackets.html With Perl we could yes. However Javascript doesn't seem to support POSIX. [a-zäöå] and [A-ZÄÖÅ] seem to work. I guess we could also use POSIX in first patch and Unicode on password_check.inc e.g \u00DF-\u00FF and allow characters like éëêẽ etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25320] Move translatable strings out of merge-record-strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25320] Move translatable strings out of merge-record-strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 --- Comment #5 from Owen Leonard --- Created attachment 110901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110901&action=edit Bug 25320: (follow-up) Remove obsolete include file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #1 from Jonathan Druart --- Created attachment 110902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110902&action=edit Bug 26518: Use Koha::Biblio[item] in AddBiblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #2 from Jonathan Druart --- Created attachment 110903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110903&action=edit Bug 26518: Raise exception if the insert failed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com --- Comment #3 from Jonathan Druart --- This first patch fixes the problem when using the UI, but the tests fail. I guess there is something do tweak for the dev_install and strict_mode config flag. Attaching them here in case someone else wants to give it a try. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26291] Move translatable strings out of z3950_search.inc into z3950_search.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26291 --- Comment #5 from Owen Leonard --- Created attachment 110904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110904&action=edit Bug 26291: (follow-up) Correct stray MSG instances -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25384] Label maker font list is not configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #38 from Marcel de Rooy --- (In reply to David Cook from comment #37) > Comment on attachment 81125 [details] [review] > Bug 21311: (follow-up) Adjust wording of failed login message > > Review of attachment 81125 [details] [review]: > - > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt > @@ +168,4 @@ > > > > > > > class="btn" /> > > + > > I think this must've been a typo. Sorry, late response ;) Commit message says: Adding a tag between 'Log in'-button and 'Forgot your password' for presentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25673] Access logging of borrower's personal information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #3 from Lari Taskula --- (In reply to Joonas Kylmälä from comment #0) > I don't know if this is directly related to GDPR By the way it looks like this is not required by GDPR. The Finnish libraries that use it in their custom Koha fork were inspired by the laws for health care sector, and decided to implement such functionality when there was still a lot of confusion regarding GDPR. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975
--- Comment #35 from Julian Maurice ---
(In reply to Martin Renvoize from comment #28)
> What I'm also tempted to do is add a standardly named accessor be to objects
> with translatable fields.. ->translation_key which would produce the right
> key from the internal fields behind the scenes. So for itemtype it simply
> passes through itemtype, but for a it might pass $code_$interface for
> example.
That means Koha::Object(s) should be aware of the interface (opac/staff) ? :/
(In reply to Martin Renvoize from comment #34)
> My point is.. I've tried to make it flexible enough without introducing too
> much additional overhead/code complexity here. I suggest we should not
> second guess the level of translation requirements/granularity of different
> components here but rather defer that to each bug introducing additional
> translation options.
We have the same goal, just different opinions on how to achieve that. If we do
it right from the beginning, making more kind of objects translatable will be
easier. I think it's worth taking some time to think about it.
By using codes as translation key, it can work for MARC frameworks too, but it
will require to translate the same strings multiple times. To avoid that, we
would need to implement some kind of fallback mechanism.
By using descriptions as translation key, there is no need for fallback. Every
string have to be translated only once. However it doesn't allow to translate
the same string in different ways (like in comment 31). Doing that will also
require a fallback mechanism.
So, do we want to use a code as key (eg. "245a") and refine with other codes
("FW2"),
or do we want to use a description as key (eg. "Title") and refine with other
codes ("FW2", "245a") ?
I'd say the fallback for a description-based key is more likely to be accurate
("Kunto" is not very different in meaning from "Tila"), whereas a fallback for
a code-based key can be simply wrong if descriptions are different.
Now that I think about it, this refinement system could also include the group
("itemtype", "framework", ...) so we'd have to translate "Title" only once, and
it would be translated everywhere the same way, except if one add a different
translation for [framework, FW2, 245a] for instance.
That being said, I recognize that frameworks are a particular case, and it may
not be worth it to add all these translation features just for that. But having
a separate translation system for frameworks is not ideal either... It would be
simpler if all frameworks shared their descriptions :)
BTW, I really like the idea of "fuzzy" you've added
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26565] New: Issue number occurs in both missinglist and receivedlist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26565 Bug ID: 26565 Summary: Issue number occurs in both missinglist and receivedlist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com From bug 24903 (comment Katrin): Maybe an edge case: My number (18) was Arrived and listed as received. Change the status to missing. It's now both missing and received in the summary. Should to not be removed from the received list in this case? Please also check bug 24842 for how it relates to this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25673] Access logging of borrower's personal information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #4 from Joonas Kylmälä --- There was some confusion regarding this indeed. Koha and the webserver running in front of it provides already logs of similar content albeit in slightly harder to parse format. I feel like we can close this bug and re-open it later if somebody else is interested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #3 from Séverine Queune --- +1 ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25217] Allow user to define default label layout and template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25217 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 110905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110905&action=edit Bug 25039: (QA follow-up) Restore date display The original implementation didn't display the time portion of the datetime object (00:00) as it used output_pref( ..., 'iso' ). This patch makes it do the same. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25039] Move new due calculation to Koha::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25039 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24724] Add plugin hook for new SQL report export formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24724 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #4 from Fridolin SOMERS --- Ah really nice hook. I think it could be useful for many other exports (checkouts table, ...). Use of those plugins will only be implemented only for sql reports, but can be implemented somewhere else in a second time. So I propose you some changes : 1) Only one format per plugin. 2 formats = create 2 plugins ;) Will make code more clear I bet. 2) Change methods : sub sql_report_get_export_format sub sql_report_process_data to : export_format process_export 3) Better add a method to Koha/Template/Plugin/KohaPlugins.pm to fetch the plugins you need. PS : you need to remove call to UseKohaPlugins system preference Let me know if you need help. Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
