[Koha-bugs] [Bug 26616] New: Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26616 Bug ID: 26616 Summary: Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: muhammednaj...@kannuruniv.ac.in QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 111261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111261=edit Error report Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26615] New: Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26615 Bug ID: 26615 Summary: Koha 18.11.04.000 Upon clicking any tab after ligin or doing any function it displays error :session timed out please login again Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: muhammednaj...@kannuruniv.ac.in QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 111260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111260=edit Error report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26606] Correctly URI-encode query string in URL loaded after deleting an authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26606 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Looks like all the other filters shown in the context should be changed to "uri" from "html" as well, but seems out of scope for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26614] Diacritics taken into account in facet sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26614 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #14 from David Cook --- (In reply to Marcel de Rooy from comment #13) > Looks good to me too. But a rather intriguing question is: is there some > script somewhere that depended somehow on the logic of removed empty > parameters? > (Apart from seeing the other way around on the see also bug.) I've traced the Apache lines back to 2007 when MJ Ray added them via commit e449c139fff, but there's really no information provided. I imagine that it was just cosmetic. That empty URL query parameters look ugly so that they stripped them off. MJ or Chris Cormack (who signed off on the patch) might know more. > Have the impression that David already had this in production for longer, so > it is probably highly fictitious ;) Yep, I've been running this in production since May 20th 2020. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #3 from David Cook --- (In reply to Jonathan Druart from comment #2) > Move it up please ;) Noted! Exciting! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #319 from David Cook --- Yahoo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #26 from David Cook --- Does Koha-Suomi Oy already have these patches running in Koha? I'm going to mark as Failed QA, as I think the current password policies won't be workable for many Koha implementations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 --- Comment #25 from David Cook --- For what it's worth, I've tested Keycloak again and now my Chinese software keyboard is working for inputting passwords. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26614] New: Diacritics taken into account in facet sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26614 Bug ID: 26614 Summary: Diacritics taken into account in facet sorting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org Created attachment 111259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111259=edit Record with subject beginning with É for testing In both OPAC and Intranet, the subject facets are sorted in alphabetical order. However, letters with diacritics are sorted at the end rather than with their corresponding letters. Right now, the sorting is A, B, C, M, O, R, V, Z, É but it should be A, B, C, É, M, O, R, V, Z To replicate: I attached a record with a subject beginning with É 1- Import the record in your catalog 2- If necessary, rebuild zebra 3- In OPAC, search for the record (choose a keyword that is vague enough to get you some results but not too many, otherwise the facet won't show up -- see maxRecordsForFacets), I used the keyword "action" in my catalog 4- If necessary, expand the subject facet 5- Note that the "Égalité des sexes" subject is at the end rather than where E should be 6- Repeat steps 3-5 in Intranet, same problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26613] New: In the unimarc_framework.sql file in the it-IT translation there are wrong value fields for 995 r record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26613 Bug ID: 26613 Summary: In the unimarc_framework.sql file in the it-IT translation there are wrong value fields for 995 r record Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: j...@voipsupport.it QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 111258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111258=edit patch This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942 c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Proposed patch attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26612] New: Error during web install for it-IT translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26612 Bug ID: 26612 Summary: Error during web install for it-IT translation Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: j...@voipsupport.it QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 111257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111257=edit patch When running the web installer with it-IT translation, the Unimarc version of unimarc_framework.sql gives an error about the record with key 307 violating null constraint. Sorry I did not keep the exact error message. However, the install does not proceed beyond inserting record 306 and the installation must be restarted after correcting the unimarc_framework.sql file. The patch to the file is attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 --- Comment #14 from David Nind --- This might be an edge case, but if you: - Partially pay a charge (pay $5 off a $15 charge) - Pay the rest of the charge (pay $10 off a $15 charge) - Void one of the payments for the charge - Then you cannot cancel the charge - This option comes back when you void the other partial payment My notes from testing; - updatedatabase required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What|Removed |Added Attachment #111218|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 111256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111256=edit Bug 24603: (follow-up) Update to double entry accounting This patch updates the logic to create a cancellation accountline and apply it to the charge line so we correction record the transaction in terms of double entry accounting standards. Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. A cancellation line should be associated with the original charge. 5. Create another manual invoice 6. Pay it (partially or fully) 7. Notice that the 'Cancel charge' button is not available 8. Void the payment 9. 'Cancel charge' button is available again. Click on it and verify that it still works 10. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24603] Allow to cancel charges in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24603 David Nind changed: What|Removed |Added Attachment #111217|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 111255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111255=edit Bug 24603: Allow to cancel charges in patron accounting There is already a button to void a payment. It should be possible to cancel a charge too. This patch adds a button in patron's accounting section (Transactions tab) that allow to cancel charges. Charges that have been fully or partially paid cannot be cancelled. It also fixes Koha::Account::Line::is_credit by looking at credit_type_code instead of amount (amount can be 0 for voided payments) It also fixes the tests for Koha::Account::Line::void when database does not contain the borrowernumber 51 (the default in t::lib::Mocks::mock_userenv) Test plan: 1. Go to a patron's accounting section 2. Create a manual invoice 3. In Transactions tab, you should see a 'Cancel charge' button. Click on it. It should now be marked as cancelled 4. Create another manual invoice 5. Pay it (partially or fully) 6. Notice that the 'Cancel charge' button is not available 7. Void the payment 8. 'Cancel charge' button is available again. Click on it and verify that it still works 9. prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Azucena Aguayo changed: What|Removed |Added CC||azucena.agu...@uvu.edu --- Comment #61 from Azucena Aguayo --- It would be helpful to have this type of functionality. We have patrons that ignore due and overdue notices. Once they are billed then they call the library expecting to have their lost charges dropped and items renew. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26606] Correctly URI-encode query string in URL loaded after deleting an authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26606 didier changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||didier.gautheron@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #60 from Christopher Brannon --- Would like to see some traction on this. This bug seems to be stalled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21972 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21972] Record matching rule for authorities only works for first 20 authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21972 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26611 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26611 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12586 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21972] Record matching rule for authorities only works for first 20 authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21972 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- I think the configurability of that number should be addressed, however, I think the other issue here is the lack of match checks, see bug 26611 Looking the the two matchpoints specified, it seems the second should be a match check - verify the id, then verify it comes from the same source. The two match points are not searched together, they are separate searches. It may be more straightforward here to simply specify a single matchpoint that checks: Tag: 024 Subfields: a2 That would check against both values, rather than needing to search more records, and wouldn't require building the combined index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26611] New: Required match checks don't work for authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 Bug ID: 26611 Summary: Required match checks don't work for authority records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The code specifically ignores these for authorities, I am not sure why? While we could easily disable the feature for authority matching to follow current behaviour, I believe we need this functionality to be able to match correctly. Match points check only the first 20 records (see bug 21972) so can only target unique or unique-ish values Match checks allow you to compare specific fields and can verify that matches above are correct. For example: Importing records and checking the 010a - which matches the LC-card-number index can have false matches because the index also contains the 010z - the match check would allow us to compare the specific fields in the records as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 --- Comment #28 from Lucas Gass --- Created attachment 111254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111254=edit Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code Test plan: 1. git grep -i AllowPurchaseSuggestionBranchChoice **/*.pm **/*.pl **/*.t 2. There should no longer be any code related to the old sys pref AllowPurchaseSuggestionBranchChoice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 Lucas Gass changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26610] Add 'NULL' option to report value dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26610 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26610] New: Add 'NULL' option to report value dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26610 Bug ID: 26610 Summary: Add 'NULL' option to report value dropdowns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Sometimes you may want to have a report optionally limit to an itemtype or branch etc. Sometimes you may want to pick NULL from that dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- This all works well and I'm surprised we didn't already handle such cases. Unit tests pass and we're dealing with the obvious cases where rules should not be blank. I suspect there may be a few other cases crop up in the future where we've been allowing errant blank rules in, but we can handle them as we find them. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529 Martin Renvoize changed: What|Removed |Added Attachment #110859|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 111253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111253=edit Bug 26529: Remove existing blank rules Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529 Martin Renvoize changed: What|Removed |Added Attachment #110857|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 111252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111252=edit Bug 26529: Unit tests This tests tries to set some rules to blank, and then fetch the effective rule - nothing should be returned as these values are 'Not set' To test: 1 - Apply just this patch 2 - Tests fail 3 - Apply second patch 4 - Tests pass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529 Martin Renvoize changed: What|Removed |Added Attachment #110856|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 111251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111251=edit Bug 26529: Define some rules as not able to be blank Currently, the 'Default checkout, hold, and return policy' have a conditional to blank 'holdallowed' when not set, but other rules don't get the same treatment This patch uses the existing hash that controls the scope of rules and adds a new parameter 'can_be_blank' Default is assumed to be true, can_be_blank, but if set to '0' then blank rule values will not be save to the database To test: 0 - Set CircControl to 'the library the item is from' 1 - Goto to Admin -> Circulation and fines rules and select a library 2 - Under "Default checkout, hold, and return policy" set: Total current checkouts allowed: 1 Hold policy: Not set Hold pickup library match: Not set Return policy: Not set 3 - Save the rule 4 - Check the DB SELECT * FROM circulation_rules WHERE branchcode = 'BRANCHCODE' using the branchcode for the library you chode 5 - Note returnbranch, and hold_fulfillment_policy rules exist with blank value 6 - Set 'All libraries'->'Default checkout, hold and return policy'->'Item floats' 7 - Checkin an item from the library with blank rules at another library 8 - It returns home rather than floating 9 - Apply patch and restart all the things 10 - Reload the page and save the rules as before 11 - Check the DB and note the rules no longer exist 12 - Check in the item, it floats! 13 - prove -v t/db_dependent/Koha/CirculationRules.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Julian Maurice changed: What|Removed |Added Text to go in the||This allows to run Koha as release notes||a Mojolicious application. ||It's a first step towards ||rewriting CGI code as ||Mojolicious controllers, ||for cleaner code and more ||testability. ||It's designed ||for developers only at this ||point, and should not be ||used in production. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 --- Comment #13 from Martin Renvoize --- Created attachment 111250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111250=edit Bug 23376: (QA follow-up) Remove authnotrequired The rebased patchset subsequnetly re-introduced the now deprecated use of authnotrequired on staff client controllers. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #14 from Martin Renvoize --- Nice bit of cleaning up, thanks. All works as expected still, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize changed: What|Removed |Added Attachment #110694|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 111249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111249=edit Bug 23376: Remove unneeded 'count' parameter Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize changed: What|Removed |Added Attachment #110693|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 111248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111248=edit Bug 23376: Move AcqCreateItem logic to template Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Martin Renvoize changed: What|Removed |Added Attachment #110692|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 111247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111247=edit Bug 23376: Clean up order recipt page This patchset switches from using DB lookups to using an order object for most things on orderreceive.pl It simplifies the script and makes minimal changes to the template To test: 1 - Place some orders and receive them 2 - Have orders with or without subscriptions attached 3 - Try with different AcqCreateItems settings 4 - Apply patch 5 - No behaviour should change 6 - Read code to ensure things make sense Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26609] New: Batch Extend Due Dates tool should add filter for borrower expiry date and item holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26609 Bug ID: 26609 Summary: Batch Extend Due Dates tool should add filter for borrower expiry date and item holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jeremy.ev...@phe.gov.uk QA Contact: testo...@bugs.koha-community.org The Batch Extend Due Date tool should add filters for the borrower expiry date and the number of existing holds on the items. These fields should also display in the results summary that can be checked before proceeding with the due date change. We have amended all due dates while the libraries have been closed during 2020, but we would not want to extend the due dates for books ln loan to borrowers who have already left, or in some circumstances if they have an expiry date before the intended new due date. Similarly, we may not want to automatically extend the due dates for items that have existing holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16728] Add MARC21 777 - Issued with entry to staff and OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16728 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Passing QA, thanks Katrin :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16728] Add MARC21 777 - Issued with entry to staff and OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16728 Martin Renvoize changed: What|Removed |Added Attachment #110416|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 111246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111246=edit Bug 16728: Add MARC21 777 - Issued with entry to staff and OPAC detail pages This adds the 777 - Issued with entry to the staff and OPAC detail pages. It's built using the template for 773 with minor adjustments. To test: - Apply patch - Catalog several 777 fields in one or more of your records - When using 1st indicator = 1, the note won't display - When using 2nd indicator empty, label will be "Issued with:" - When using 2nd indicator 8, the label will be drawn from $i if present - When $w and UseControlNumber pref is used, the link will be built using $w - In all other cases the title form $t will be used for the link - Verify the display is correct Examples for 777 can be found in the LOC MARC21 documentation: http://www.loc.gov/marc/bibliographic/bd777.html Note: Because the label depends on the 2nd indicator, the label is repeated for every 777 on a record. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |andrew.isherwood@ptfs-europ |.com|e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #318 from Jonathan Druart --- Created attachment 111245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111245=edit Bug 22417: Remove batch_record_modification from the non-plack list Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26551] When importing a framework, the modal heading is too long and runs outside of the dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Wrapping now works as expected and no regressions were found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26551] When importing a framework, the modal heading is too long and runs outside of the dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Martin Renvoize changed: What|Removed |Added Attachment #110885|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 111244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111244=edit Bug 26551: Correct modal markup to prevent long heading from overflowing This patch modifies the markup of the MARC framework import and export modals so that CSS intended only for Bootstrap buttons isn't applied to content in the modal. The modal dialog markup was nested inside a ".btn-group" , which carries with it CSS that prevents text wrapping. Moving the modal markup out of the button group while keeping it inside the corrects the problem. Lines have only been shifted and reindented. To test, apply the patch and go to Administration -> MARC bibliographic framework. - In the table of frameworks, from the "Actions" menu, test both the "Import" and "Export" links. Both should work as expected. - Confirm that the text of the heading on the "Import" modal wraps correctly. - Test the same operations for a framework other than the default one. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26191] Relocate track_login call in Auth.pm (see 22543)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26191 Martin Renvoize changed: What|Removed |Added Attachment #108052|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 111243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111243=edit Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26191] Relocate track_login call in Auth.pm (see 22543)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26191 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Passing QA, patch is clear and simple and works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604
Martin Renvoize changed:
What|Removed |Added
Attachment #71|0 |1
is obsolete||
--- Comment #8 from Martin Renvoize ---
Created attachment 111242
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111242=edit
Bug 26604: "Generate next" button gives error on serials-collection.pl
In serials-collection.pl, the line
$frequency =
C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});
causes the error
Can't use string ("13") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Serials.pm line 2198.
This function call makes no sense, that subroutine always returns a list and
doesn't take any parameters. I think it was meant to be
GetSubscriptionFrequency which is in fact already called a few lines down.
Signed-off-by: kelly mcelligott
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Works as expected, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17047 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : Data sharing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26604 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 --- Comment #7 from Martin Renvoize --- Odd.. has this really not been working since 19.05! It looks like it was introduced with bug 17047 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 Martin Renvoize changed: What|Removed |Added Attachment #110880|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 111240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111240=edit Bug 25957: Unit test Signed-off-by: Bob Bennhoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25957] Elasticsearch 5.X - empty subfields cause error on suggestible fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25957 Martin Renvoize changed: What|Removed |Added Attachment #110881|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 111241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111241=edit Bug 25957: Don't push blank field values to ES document To test: 1 - Load the sample DB or edit a record (using advanced cataloging editor) to have a blank subfield in a field that is indexed as suggestible 2 - For example 'author' / 100a 100 _ _ ‡a 3 - Index that record into Elasticsearch 5.X: perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 4 - Note error 'value must have length > 0' 5 - Edit mappings to set author 100a not suggestible 6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 7 - Success 8 - Set field to suggestible again 9 - Apply patch 10 - perl misc/search_tools/rebuild_elasticsearch.pl -v -bn 115 -b -d 11 - Success! Signed-off-by: Bob Bennhoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 --- Comment #5 from Martin Renvoize --- I think we need to move the call to GetPlugins in install_plugins.pl back up to where it we and add the option to run GetPlugins with 'can_load' in this case. It would be nice to report the deletions too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #2 from Jonathan Druart --- (In reply to David Cook from comment #1) > I'll add it to my TODO list :D Move it up please ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Whilst this is great and resolves the bug mentioned (I've hit this too), it breaks the output of the script as the 'existing_plugins' array used to contain the 'plugins before' call to InstallPlugins but now runs after the call to InstallPlugins and so will not be a comparison. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #317 from Jonathan Druart --- (In reply to Jonathan Druart from comment #316) > Created attachment 111239 [details] [review] > Bug 22417: Add exec flag on .t file Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #316 from Jonathan Druart --- Created attachment 111239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111239=edit Bug 22417: Add exec flag on .t file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #315 from Jonathan Druart --- (In reply to Jonathan Druart from comment #314) > Created attachment 111238 [details] [review] > Bug 22417: Add koha-worker to koha-common.install > > Signed-off-by: Jonathan Druart Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #314 from Jonathan Druart --- Created attachment 111238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111238=edit Bug 22417: Add koha-worker to koha-common.install Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8338] Add ability to remove fines with dropbox mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193
--- Comment #15 from Jonathan Druart
---
(In reply to Aleisha Amohia from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > my $res = Koha::Holds->search({ biblionumber => $item->biblionumber,
> > borrowernumber => $patron->borrowernumber })->next;
> > next unless $item->holdingbranch eq $res->branchcode;
> >
> > What if a given patron has several holds on the same record? Should not we
> > loop on the different holds instead of testing only the first one?
>
> I guess we could put another condition in the search params like:
>
> my $res = Koha::Holds->search({ biblionumber => $item->biblionumber,
> borrowernumber => $patron->borrowernumber, branchcode =>
> $item->holdingbranch }, { order_by => { -asc => 'priority' } })->next;
>
> What do you think?
My concern was about the other holds a patron could have on the same
bibliographic record.
I don't know if it makes sense but, reading the code:
2826 if (
C4::Context->preference('AllowRenewalIfOtherItemsAvailableLocation') eq
'holdbranch' ){
2827 my $res = Koha::Holds->search({ biblionumber =>
$item->biblionumber, borrowernumber => $patron->borrowernumber })->next;
2828 next unless $item->holdingbranch eq
$res->branchcode;
2829 }
We skip the patron if they have their first hold on this biblio in the holding
library of the item.
Should not we do this test on all the holds this patron has on the
bibliographic record?
Katrin, what do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25293] Don't call escapeHtml on null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15219 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25293 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 David Nind changed: What|Removed |Added Attachment #111207|0 |1 is obsolete|| --- Comment #68 from David Nind --- Created attachment 111237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111237=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Items/MoveItemFromBiblio.t Rebased-by: Joonas Kylmälä Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #67 from Joonas Kylmälä --- Hi, (In reply to David Nind from comment #66) > However, the the tests for prove -v t/db_dependent/Koha/Item.t run a lot > faster as well, but still fail - see attachment Bug 22690 - Output from > tests for Item.t. please run the test after running "reset_all" and it should work. The Koha unit tests tend to fail if you change system preferences (which seems to be the case here with the searchengine syspref). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #313 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #66 from David Nind --- Created attachment 111236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111236=edit Bug 22690 - Output from tests for Item.t Thanks Ere! That made a huge difference, and the merge takes almost no time at all now (less than 1 minute) However, the the tests for prove -v t/db_dependent/Koha/Item.t run a lot faster as well, but still fail - see attachment Bug 22690 - Output from tests for Item.t. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 Fridolin SOMERS changed: What|Removed |Added Component|Searching |Searching - Zebra QA Contact|testo...@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26307] misc/cronjobs/update_patrons_category.pl --too_old acts a year too early
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #10 from Magnus Enger --- After thinking about it for a bit, I think the current behaviour makes sense. If CHILD has an upper limit of 18, it means the patron should change category on the day she turns 18. And ADULT has a lower limit of 18, because the day the patron turns 18 they should be moved to this category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111226|0 |1 is obsolete|| --- Comment #99 from Andrew Fuerste-Henry --- Created attachment 111234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111234=edit Bug 24786: Default to 'branch default' on auth. If no branch is selected (i.e. 'My library') then we should default to 'branch default' if one is defined for the users library at login. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111227|0 |1 is obsolete|| --- Comment #100 from Andrew Fuerste-Henry --- Created attachment 111235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111235=edit Bug 24786: Add validation to point of sale The Point of Sale page relied upon serverside validation prior to this patch; As such with the introduction of the ability to select '--None--' at the session register level (to require the librarian to pick their register for every transaction) we could result in a server error page. This patch introduced clientside validation to add checks for both the 'collected' and 'registerid' form fields. Test plan: 1/ Select a branch with cash registers available 2/ Select the '--None--' option for the session cash register 3/ Navigate to the point of sale page 4/ Attempt to make a sale without having picked your cash register 5/ Note that the submission was prevented and the fiedl is highlighted as required in red. 6/ Signoff Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111225|0 |1 is obsolete|| --- Comment #98 from Andrew Fuerste-Henry --- Created attachment 111233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111233=edit Bug 24786: (follow-up) Cache the register_name in the session This leads to one DB hit less per page load in the staff client when cash registers are enabled. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111224|0 |1 is obsolete|| --- Comment #97 from Andrew Fuerste-Henry --- Created attachment 111232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111232=edit Bug 24786: Update borroaccount to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the refund or payout action. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111222|0 |1 is obsolete|| --- Comment #95 from Andrew Fuerste-Henry --- Created attachment 111230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111230=edit Bug 24786: Update point of sale to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the sale. Test plan 1/ Enable cash registers via the 'UseCashRegisters' system preference 2/ Enable point of sale via the 'EnablePointOfSale' system preference 3/ Navigate to the point of sale page 4/ Note that if you are logged in at a branch with no cash registers yet defined, then an alert should appear 5/ Note that when you are logged in at a branch with cash regsiters defined, but without a cash register associated with your session then the cash 'Cash register' select box is populated with '-- None --' and you are required to select a register prior to submission 6/ Note that upon selection, the '-- None --' option is disabled 7/ Note that when you have a register associated with your session then the 'Cash register' select box is pre-populated with that register. 8/ Signoff Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111223|0 |1 is obsolete|| --- Comment #96 from Andrew Fuerste-Henry --- Created attachment 111231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111231=edit Bug 24786: Update paycollect to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the payment. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111221|0 |1 is obsolete|| --- Comment #94 from Andrew Fuerste-Henry --- Created attachment 111229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111229=edit Bug 24786: Allow selection of cash register at login Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111220|0 |1 is obsolete|| --- Comment #93 from Andrew Fuerste-Henry --- Created attachment 111228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111228=edit Bug 24786: Allow setting a register for the session This patch adds the ability to set a register for the current session from the 'set library' page. Upon entering the page, the current selection will be displayed. Changing the branch will trigger the register select list to update to display only those registers associated with the updated branch and will automatically select either 'no register' or the 'branch default' register. The user can then override that selection to choose a different register for the session. Test plan 1/ Enable cash registers with the 'UseCashRegisters' system preference 2/ Select the 'Set library' option from the top right menu 3/ Note that you can now select a cash register from the subsequent page 4/ Change the branch and note that the cash register selection is updated to reflect the change 5/ Note that the 'branch default' register is auto-selected upon branch selection if one has been defined, otherwise '-- None --' is selected 6/ You can then alter the selection before submitting the form 7/ Once submitted note that you are returned to the page you were on prior to attempting to change the library and register 8/ Note the present of the register name next to the library name at the top of the screen. 9/ Signoff Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26172] Add a cashup summary view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #21 from Sally --- (In reply to Martin Renvoize from comment #20) > Thanks for testing Sally, I'm really happy it's working for you. > > On the print front, can I ask what browser you tested with and whether you > ran the CSS build option on the sandbox? The code is intended to hide the > background and only print the modal content so if you weren't seeing that I > may still have a bug there. I'll investigate and can work through it with > whoever picks this up for QA if it's not working as expected. > > Thanks again Argh, my mistake - I didn't run build CSS. I shouldn't have been rushing to get it tested on Friday! I've re-tested, and can confirm that it works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added URL||https://gitlab.com/mrenvoiz ||e/Koha/-/commits/bug_24786 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #92 from Martin Renvoize --- It sounds like this wasn't applying.. rebased again and added a branch link: https://gitlab.com/mrenvoize/Koha/-/commits/bug_24786 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #30|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 111224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111224=edit Bug 24786: Update borroaccount to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the refund or payout action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #33|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 111227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111227=edit Bug 24786: Add validation to point of sale The Point of Sale page relied upon serverside validation prior to this patch; As such with the introduction of the ability to select '--None--' at the session register level (to require the librarian to pick their register for every transaction) we could result in a server error page. This patch introduced clientside validation to add checks for both the 'collected' and 'registerid' form fields. Test plan: 1/ Select a branch with cash registers available 2/ Select the '--None--' option for the session cash register 3/ Navigate to the point of sale page 4/ Attempt to make a sale without having picked your cash register 5/ Note that the submission was prevented and the fiedl is highlighted as required in red. 6/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #32|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 111226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111226=edit Bug 24786: Default to 'branch default' on auth. If no branch is selected (i.e. 'My library') then we should default to 'branch default' if one is defined for the users library at login. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #29|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 111223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111223=edit Bug 24786: Update paycollect to use session register This patch adds handling to allow for the use of the session cash register by default if it has been set, otherwise it defaults to '-- None --' and requires the end user to select the register to proceed with the payment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24786] Allow setting a cash register for a login session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 Martin Renvoize changed: What|Removed |Added Attachment #31|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 111225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111225=edit Bug 24786: (follow-up) Cache the register_name in the session This leads to one DB hit less per page load in the staff client when cash registers are enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
