[Koha-bugs] [Bug 26625] Add ability to configure mojolicious applications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26625 Julian Maurice changed: What|Removed |Added Summary|Add a mojolicious section |Add ability to configure |in $KOHA_CONF |mojolicious applications -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26625] Add a mojolicious section in $KOHA_CONF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26625 --- Comment #4 from Julian Maurice --- Created attachment 111365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111365&action=edit Bug 26625: (alternative) Use Config plugin in Mojolicious apps This allows to have separate config files for each mojolicious app. They can also both use the same config file. The config file is Perl code, so the configuration can be dynamic See https://docs.mojolicious.org/Mojolicious/Plugin/Config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26631] wrong description of test case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26631 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi, I think you didn't file this in the right place - this is the bugtracker for Koha - an open source library system. Please check for the bug tracker of the project this was meant for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #14 from Fridolin SOMERS ---
Nice job.
Just my opinion :
Would be great to send Koha::Patron object to template.
So call in template [% patron.opacnote %].
Also add in Koha::Patron a method messages() to get :
Koha::Patron::Messages->search({borrowernumber => $borrowernumber})
Like it exists for checkouts, holds ...
So in template you just add [% patron.messages.count %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #331 from Marcel de Rooy --- Thx David for your thorough investigations. And note that my 'badly programmed' statement is really in an if-block embedded :) We never reach that point IF the condition is not true.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26398] Credit and Debit types on creating a manual credits and manual invoices are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 --- Comment #7 from Martin Renvoize --- This one is a bit challenging for me to write a test plan as I only just understand the translation workflow myself. What the patch does is update the templates to include the English strings for translation in the right places. Regression tests * Create some debts and payments of various types. * Check that they appear as expected in the accounts tables on both the transactions and pay tabs of the members page. Bug fix test * We need to check that the strings appear in .po files. I believe this is a case of running the 'update' method of misc/translator/translator script. * The final aim of the bug is to make the drop-down options for manual invoice and manual credit type drop downs are translated. Katrin, perhaps you could lend a hand on how this can be properly tested? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #330 from David Cook --- Ok I'm using the vanilla koha-testing-docker on Debian 9 (stretch), so I have RabbitMQ 3.6.6 with Erlang 19.2.1 and Erts 8.2.1. Very old now... Even without "+sbwt none", my usage is sitting at 0% and spiking to 2% every 1-5 real seconds (typically more like every 5 seconds). It's actually using less CPU time than my Ubuntu 18.04 VM. Note that I'm using koha-testing-docker via Docker Desktop in Windows, so my Docker host is actually a Hyper-V virtual machine. Popping "SERVER_ADDITIONAL_ERL_ARGS="+sbwt none"" into /etc/rabbitmq/rabbitmq-env.conf and restarting the rabbitmq server... Yeah I'd say a 2% spike every 5 seconds for a fraction of a second. Going into "top" and pressing "H", I see "1_scheduler", "2_scheduler", and "aux" threads very occasionally having a little burst. But it's by no means constant. It's actually idling very nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #7 from David Cook --- (In reply to Sally from comment #6) > (In reply to David Cook from comment #5) > > > > As far as I know, that shouldn't be an issue. I tested this using a HTTP > > site. > > > > What browser did you use and what exact issue did you have? > > The problem is this: > > 5b) If you're using a modern browser, try Ctrl+V somewhere and note > that the URL has already been copied to your clipboard > > (If the browser supports the Clipboard API, the URL is also written to the > browser's clipboard, making manually copying from the modal redundant.) > > This doesn't happen for me on the sandbox - I had to manually copy the link > from the modal, because Ctrl+V still retains my previous clipboard contents. > > The web browser is Chrome 86. Hmm that's interesting. It should've worked for you. Maybe I'll have to test this one again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #329 from David Cook --- Ok some numbers... The Ubuntu 18.04 container running RabbitMQ 3.8.9 used 3x less CPU time while idling compared to a Ubuntu 18.04 virtual machine running RabbitMQ 3.6.10. The openSUSE Leap 15.1 virtual machine running RabbitMQ 3.7.14 used 2x less CPU time while idling compared to the Ubuntu 18.04 container. So, my recommendation would be the same as the people from RabbitMQ, and that is that it would be best to install the latest version of RabbitMQ available, as that's probably going to result in the best performance. I don't feel like meddling with my Ubuntu 18.04 virtual machine today, but I might have a look at that, although I'm not concerned with the small amount of CPU usage/CPU time it's using, so I might not bother. Watching the beam.smp process over time, even on the Ubuntu 18.04 virtual machine, it's using a max of 2% CPU for fractions of a second every few seconds. It's a small amount of CPU time over a fairly large amount of real time. It's not competing with other processes for CPU. It's not like a process that is sitting constantly at 100% or even 50%. That said, maybe I should have a look at koha-testing-docker one more time... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #328 from David Cook --- Actually trying that new Docker image with the following: RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS="+sbwt none +sbwtdcpu none +sbwtdio none" That definitely got rid of the sched_yield syscalls. Lots of futex calls from 1_scheduler thread. The aux thread is doing some other work. Based on https://www.rabbitmq.com/runtime.html#thread-stats, I'd say that's probably doing things like managing timers and doing other management work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #327 from David Cook --- I just remembered that I have a RabbitMQ on an openSUSE Leap 15.1 server. It's running RabbitMQ 3.7.14 with Erlang 20.3.8.15 and Erts 9.3.3.6 with 12 CPUs. I'm not using +sbwt on that system, but my constant CPU usage is 0%. The 1_scheduler thread is still doing a constant stream of syscalls (epoll_pwait, clock_gettime, futex), but I don't see it reflected in CPU usage via top. The "aux" thread is also doing something a little bit but rarely. Looking back again at Ubuntu 18.04 with RabbitMQ 3.6.10 with Erlang 20.2.2 and Erts 9.2 with 8 CPUs, I can see that all the scheduler threads are spinning a bit. I'm curious if it's due to Erlang/Erts/RabbitMQ differences, or configuration differences. I'm going to study the configuration options a bit. -- As for Docker... I'm running rabbitmq:3.6.10 and CPU usage is typically 0% and occasionally spikes to 2% on a 2 CPU system. It's not as frequent as the Ubuntu system but more frequent than the openSUSE system. I'd say on openSUSE it stays at 0% for 10 seconds before moving up to maybe 0.333% for .5 seconds. On Ubuntu 18.04, it sits at 0% but every 1-2 seconds it'll jump up to 2%. On Docker rabbitmq:3.6.10, it looks like it goes up to 2% every 2-10 seconds. -- Trying Docker rabbitmq:3.8.9... it goes to 2% CPU every every 2-5 seconds it seems. Like openSUSE 3.7.14, it seems to be 1_scheduler thread that is doing the majority of the spinning. When I use strace for it, I do see a huge number of sched_yield syscalls and a much smaller number of futex syscalls. I'm going to try using "+sbwt none" on another container and see how it goes. (I'm also capturing the CLI conf to see if there's anything obvious there.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #326 from David Cook --- (In reply to Marcel de Rooy from comment #325) > Keep in mind that some libraries might not have the luxury of sufficient > funds to allocate the resources that most of us do have. > That is true. I would argue that Elasticsearch requires resources, but we still have Zebra for less well resourced libraries. Technically speaking, Koha doesn't require RabbitMQ. Rather, it just requires a message queue that can use the STOMP protocol. So we could always recommend RabbitMQ for well resourced libraries, but provide/recommend a smaller alternative. A quick Google suggests ocamlmq as a lightweight option. Apache ActiveMQ is embedded in DSpace and Fedora Commons I believe, but we could use a standalone instance. Here's a list of STOMP compliant servers: https://stomp.github.io/implementations.html > If the load is just the result of the waiting/polling, the thing is really > badly programmed ;) I think that's a bit presumptuous. In the Koha community, I think that we should endeavour to be open-minded about technology. After chatting with some RabbitMQ folk and briefly studying Erlang, it appears that the Erlang BEAM virtual machine uses "busy waiting" to stay in a state of readiness, so that it's able to start new work as quickly as possible. This helps RabbitMQ to achieve high throughput on heavy workloads. So I wouldn't say that it is "really badly programmed". Rather, it's a deliberate programming choice designed for high performance computing (HPC). I think that we should be careful not to mistake our own local perspectives for absolute truth. That being said, I'm not the most trusting person, and don't like to accept what people tell me without some evidence. While using "+sbwt none" does reduce the CPU usage and reduce the number of syscalls, it appears to me that when using RabbitMQ 3.6.10-1ubuntu0.1 with the Erlang Run-Time System (ERTS) 9.2 on Ubuntu 18.04, the Erlang schedulers are still "busy waiting", despite what the RabbitMQ and Erlang documentation say. I'm able to demonstrate that using "top" and "strace". Someone on the RabbitMQ listserv pointed out that I was using outdated tech, and https://www.rabbitmq.com/install-debian.html does point out that the software in the Debian and Ubuntu repositories is often quite out-of-date (just like Zebra) and suggests installing from their own sources. I'd be interested to see if newer versions of RabbitMQ and Erlang do as much busy waiting. I might do some quick Docker-based experiments to see if anything obvious jumps out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26631] New: wrong description of test case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26631 Bug ID: 26631 Summary: wrong description of test case Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: mayapiwan...@gmail.com QA Contact: testo...@bugs.koha-community.org Seeing AI indoor scene analysis gave the user a wrong description of the test case. 1) Select the Scene Detection Analysis 2) Capture users surrounding by taking a picture 3) Wait for Seeing AI application to produce description of the user's input 4) Seeing AI application gives list of what it detected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26630] New: Allow custom text for each library on Purchase Suggestion Page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Bug ID: 26630 Summary: Allow custom text for each library on Purchase Suggestion Page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be great if using the news tool we could set custom text at the top of the purchase suggestion screen based on the home branch of the patron. Currently I'm using jq to do this, but it would be nice if it was built in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26456] Reindent MARC subfield structure template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind changed: What|Removed |Added Attachment #111306|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 111363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111363&action=edit Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26456] Reindent MARC subfield structure template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind changed: What|Removed |Added Attachment #111307|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 111364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111364&action=edit Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in to make it consistent with other pages. This patch should have no effect on functionality. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26456] Reindent MARC subfield structure template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #56 from Michal Denar --- Created attachment 111361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111361&action=edit Bug 24488: Simplify searches It also: Use dtf for date handling add missing td Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #57 from Michal Denar --- Created attachment 111362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111362&action=edit Bug 24488: [DISCUSSION] For comparaison I'd like someone to run a benchmark with and without this patch on a quite big database and see which approach is the best Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #55 from Michal Denar --- Created attachment 111360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111360&action=edit Bug 24488: Display patron with the highest priority hold Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Michal Denar changed: What|Removed |Added Attachment #111341|0 |1 is obsolete|| Attachment #111342|0 |1 is obsolete|| Attachment #111343|0 |1 is obsolete|| Attachment #111348|0 |1 is obsolete|| Attachment #111350|0 |1 is obsolete|| --- Comment #53 from Michal Denar --- Created attachment 111358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111358&action=edit Bug 24488: Show correct first patron details on Holds to pull This patch rewrites the complex search query to reduce the risk of reordering the results multiple times. This patch includes a change to schema files so may need to upgrade schema and/or restart memcached To test: 1) Reproduce problem following test plan in Description 2) Apply patch and refresh page 3) Notice the correct patron is now shown 4) Play with date selection, confirm correct results are still shown 5) Test cancelling holds 6) Test filtering table results 7) Test with biblios with multiple items 8) Test with making items unavailable (i.e. not for loan, checked out) Sponsored by: IHC New Zealand Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #54 from Michal Denar --- Created attachment 111359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111359&action=edit Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Tomás Cohen Arazi changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 111357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111357&action=edit Bug 15436: (follow-up) Fix separator for a single 440 in staff Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 111356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111356&action=edit Bug 15436: Use semicolon between series name and volume MARC21 dictates that we should be using a ; before $v in 440, 490, 810, 811 and 830. This patch also introduces some additional changes to unify formatting between the various options for cataloguing series: - The separator between multiple series is switched form ; to the now commonly used | with a class for easy change of formatting. - There was some missing logic that prevented the separator to show up correctly between traced and untraced series. - For some series $v was included in the link for others not. Now $v always appears as text and only $a is linked, as this is what we actually search for. To test this: - You should be cataloguing multiple series in different ways, using - deprecated 440 (still present in old data) - 490, Ind. 1 = empty or 0 = not traced - 490, Ind. 1 = 1 = traced in combination with an 8xx field Example (you should try a different combination!) 440 _ _ $aFirst series 490 _ _ $aSecond series ;$v1 490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display) 830 _ _ $aThird series ;$v1 Without patch: Series: First Series; Second series ; 1Third series: 1 With patch: Series: First series | Second series ; 1 | Third series ; 1 Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110481|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110480|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 --- Comment #15 from Tomás Cohen Arazi --- I PQA as it does what it was requested. And I guess it doesn't hurt to make it independent on ind2. I still have my question open about $u (separate enhancement, for sure), and the incidence of ind2=0. I felt like this 'enhanced' formatting/output should be dependent on ind2, but I'm not a MARC expert and I guess if people add the subfields, they expect them to be displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 111355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111355&action=edit Bug 19616: (follow-up) Breaking items according to punctuation Previously the code assumed that $t indicates a new line in the listing. But this is not true. The standard tells us that -- or .-- will indicate a new item. "In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--)." The previous logic did no longer work with $g added. From the LOC examples: This would work: 505 2 0 $tBaptisms, 1816-1872 --$tChurch members, 1816-1831 --$tHistory of the Second Presbyterian Church of West Durham /$rby L. H. Fellows. 505 0 0 $tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). This wouldn't: 505 1 0 $gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland With the patches applied, all examples should display nicely now. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 111354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111354&action=edit Bug 19616: (follow-up) Reindent XSLT code used for 505 display Also adds a note at the beginning of the code block. This causes no functional change, just code clean-up. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 111353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111353&action=edit Bug 19616: Add MARC21 505$g - Formatted Contents Note / Miscellaneous informatoin This adds the subfield $g to the display of the 505 field in staff and OPAC detail pages. To test: - Catalog some records using variations of 505 Examples can be found in the LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html - Verify that the display in staff and OPAC is still nice and now includes $g Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110215|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110216|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110217|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19616] Add MARC21 505$g - Formatted Contents Note / Miscellaneous information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19616 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25898] Prohibit indirect object notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 111352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111352&action=edit Bug 25898: (follow-up) POD Our docs shouldn't suggest indirect object notation is accepted or encouraged. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25898] Prohibit indirect object notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25898] Prohibit indirect object notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106423|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 111351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111351&action=edit Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart changed: What|Removed |Added Blocks||26449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26449 [Bug 26449] Small typo in web installer template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26449] Small typo in web installer template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26449 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||17942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 [Bug 17942] Update style of the web installer with Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What|Removed |Added Attachment #111349|0 |1 is obsolete|| --- Comment #52 from Jonathan Druart --- Created attachment 111350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111350&action=edit Bug 24488: [DISCUSSION] For comparaison I'd like someone to run a benchmark with and without this patch on a quite big database and see which approach is the best -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26604] "Generate next" button gives error on serials-collection.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26604 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #51 from Jonathan Druart --- Created attachment 111349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111349&action=edit Bug 24488: [DISCUSSION] For comparaison I'd like someone to run a benchmark with and without this patch on a quite big database and see which approach is the best -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
--- Comment #50 from Jonathan Druart
---
Aleisha, what were you trying to achieve with the following code?
196 foreach my $bibnum ( @biblionumbers ){
197
198 my @items = Koha::Items->search({ biblionumber => $bibnum });
199 foreach my $i ( @items ){
200 if ( $i->checkout ){
201 next;
202 }
203 }
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Nick Clemens changed: What|Removed |Added Attachment #111347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #49 from Jonathan Druart --- Created attachment 111348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111348&action=edit Bug 24488: Simplify searches It also: Use dtf for date handling add missing td -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize --- This works really well.. the switch to using can_load in the GetPlugins call has the added benefit that the initial 'broken koha' issue goes away entirely.. just the plugin functionality won't load. I've added a followup that restores the InstallPlugins call such that erroneoes plugins are no longer removed by calling it (as they no longer cause an issue) and now use such occurrences along with the errors flag on GetPlugins to highlight broken plugins from the plugin management page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #48 from Nick Clemens --- Created attachment 111347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111347&action=edit Bug 24488: (follow-up) Reduce repeated code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Martin Renvoize changed: What|Removed |Added Attachment #111335|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 111345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111345&action=edit Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 --- Comment #9 from Martin Renvoize --- Created attachment 111346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111346&action=edit Bug 25549: Add error reporting to plugins-home This patch adds handling for the newly introduced 'errors' option in GetPlugins and reports erroroneos plugins to the user. To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - The plugin should display as installed in the table at tools/plugins. 5 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 6 - Add a line to break compilation, like: this won't compile 7 - Restart all 8 - Your Koha is not broken, but is no longer orange (The plugin is not loading). 9 - The plugin should display as unable to load in the table at tools/plugins. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 --- Comment #22 from Nick Clemens --- Created attachment 111344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111344&action=edit Bug 26627: Print and confirming a hold can cause an infinite loop Test plan: 1) Place a hold for pickup at library A 2) Confirm the hold and print slip 3) Checkin the item again 4) Confirm the hold and print slip 5) The modal returns, do it again 6) Apply this patch 7) Reload the page 8) Repeat steps 1-3 9) No loop! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26192] Elasticsearch does not sort call numbers correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26192 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com ||, n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Tomás Cohen Arazi changed: What|Removed |Added Summary|"Analytics: Show analytics" |Only display "Analytics: |showing regardless of |Show analytics" when |whether they have analytics |records have linked ||analytics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26629] Link to clubs from patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26629 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25787] Club holds can't be placed without modify_holds_priority permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26628] Clubs permissions should grant access to Tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #47 from Jonathan Druart --- Patches have been rebased (and I've added some modifications to the first patch, especially related to bug 23485 and bug 25534). I have also added a patch to display the patron with the highest priority hold. Reading for testing again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26485] Simplify itemnumber handling in returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 Nick Clemens changed: What|Removed |Added Blocks||26627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 [Bug 26627] Print and confirming a hold can cause an infinite loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 Nick Clemens changed: What|Removed |Added Depends on||26485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26485 [Bug 26485] Simplify itemnumber handling in returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #46 from Jonathan Druart --- Created attachment 111343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111343&action=edit Bug 24488: Display patron with the highest priority hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #45 from Jonathan Druart --- Created attachment 111342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111342&action=edit Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What|Removed |Added Attachment #107206|0 |1 is obsolete|| Attachment #107213|0 |1 is obsolete|| --- Comment #44 from Jonathan Druart --- Created attachment 111341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111341&action=edit Bug 24488: Show correct first patron details on Holds to pull This patch rewrites the complex search query to reduce the risk of reordering the results multiple times. This patch includes a change to schema files so may need to upgrade schema and/or restart memcached To test: 1) Reproduce problem following test plan in Description 2) Apply patch and refresh page 3) Notice the correct patron is now shown 4) Play with date selection, confirm correct results are still shown 5) Test cancelling holds 6) Test filtering table results 7) Test with biblios with multiple items 8) Test with making items unavailable (i.e. not for loan, checked out) Sponsored by: IHC New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 Nick Clemens changed: What|Removed |Added Blocks||26627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 [Bug 26627] Print and confirming a hold can cause an infinite loop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 Nick Clemens changed: What|Removed |Added Depends on||25969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25969 [Bug 25969] Checking in a found hold at a different branch then confirming the hold causes internal server error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #18 from Sally --- Works well - here's some of the accented searches I used on the sandbox in case they're useful for others testing: Howe, Zoë Street Strk̆v̜elser Ślez -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes changed: What|Removed |Added Attachment #108124|0 |1 is obsolete|| --- Comment #15 from ByWater Sandboxes --- Created attachment 111338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111338&action=edit Bug 23475: Use cookies to preserve simple search values To test: 1 - Enable IntranetCatalogSearchPulldown 2 - Perform a search that brings you to a single title 3 - Note the search is not displayed on the details page 4 - Apply patch 5 - Repeat 6 - Note the search is retained on details page 7 - Try with different dropdown values and search terms 8 - Test search terms including accented characters etc Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes changed: What|Removed |Added Attachment #111325|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 111340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111340&action=edit Bug 23475: (follow-up) Include URI::Escape Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 ByWater Sandboxes changed: What|Removed |Added Attachment #109624|0 |1 is obsolete|| --- Comment #16 from ByWater Sandboxes --- Created attachment 111339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111339&action=edit Bug 23475: Make cookie name more explicit Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26290] Add the ability to set a default SMTP server in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26290 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Severity|enhancement |new feature Text to go in the||With this enhancement, release notes||systems administrators can ||set a default/global SMTP ||configuration when creating ||the Koha instance, or by ||manually editing the ||koha-conf.xml. Summary|Allow setting default SMTP |Add the ability to set a |parameters in koha-conf.xml |default SMTP server in ||koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Summary|Allow configuring SMTP |Add configuration options |servers |for SMTP servers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Allow configuring SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 Tomás Cohen Arazi changed: What|Removed |Added Summary|Add SMTP configuration |Allow configuring SMTP |options to Administration |servers Text to go in the||This patchset adds the release notes||ability to set SMTP servers ||and then pick them for ||using on each library when ||sending notices, cart, etc. || ||SSL/TLS authentication is ||supported. || ||A new ||administration page is ||added for managing the ||servers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 --- Comment #1 from Kyle M Hall --- Created attachment 111337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111337&action=edit Bug 26627: Print and confirming a hold can cause an infinite loop Test plan: 1) Place a hold for pickup at library A 2) Confirm the hold and print slip 3) Checkin the item again 4) Confirm the hold and print slip 5) The modal returns, do it again 6) Apply this patch 7) Reload the page 8) Repeat steps 1-3 9) No loop! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26627] Print and confirming a hold can cause an infinite loop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26627 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #9 from Tomás Cohen Arazi --- It should definitely stop when an error is found. Each DBRev should be run inside a transaction as well. And it should report meaningful things :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Lucas Gass changed: What|Removed |Added Attachment #108427|0 |1 is obsolete|| Attachment #109134|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 111336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111336&action=edit Bug 26123: Add message notification to patron dashboard Test plan: 1. Apply patch, restart_all 2. Add some OPAC messages by clicking 'Add a message' on Home › Circulation › Checkouts › patron 3. Log into the OPAC as that patron and you should see a notice about how many messages you have with a link to opac-user.pl 4. Add multiple OPAC messages and make sure it all continues to work. 5. Also add an OPAC note from memberentry.pl. Refresh the OPAC and you should see a 1 message added to the total 6. Try an OPAC without any messages. 7. Test it with some other notices that would appear on the dashboard, checkouts, holds, overdues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26628] Clubs permissions should grant access to Tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26629] Link to clubs from patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26629 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25787] Club holds can't be placed without modify_holds_priority permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25787 Christopher Brannon changed: What|Removed |Added Severity|enhancement |normal CC||cbran...@cdalibrary.org --- Comment #1 from Christopher Brannon --- That's no good. I've also found that staff can't see the button for the tools page if the clubs is the only tool they have permission too. But that is a different bug. This definitely needs to be fixed. I don't like loop holes in permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26629] New: Link to clubs from patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26629 Bug ID: 26629 Summary: Link to clubs from patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When one has any clubs permissions, one can see a patron's club enrollments on moremember.pl and circulation.pl. However, the club name on these pages doesn't link one over to the club in tools. It should, provided one has clubs permissions beyond simply enrolling/removing patrons from clubs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26628] New: Clubs permissions should grant access to Tools page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Bug ID: 26628 Summary: Clubs permissions should grant access to Tools page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: - create a patron with only the catalogue, borrowers, and clubs permissions - log in to the staff client as that patron - navigate to a patron record, confirm you can see the Clubs tab in the patron account, can add patrons to and remove patrons from clubs - confirm you don't have a link to the Tools module either on the Koha homepage or in the More menu - enter the clubs url manually (/cgi-bin/koha/clubs/clubs.pl), confirm you are allowed to open the page We should give a Tools link to anyone with clubs, edit_clubs, or edit_templates permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #14 from Martin Renvoize --- As discussed in the dev meeting I think this bug should be unblocked whilst we work on the issues with updatedatabse discussed on bug 25078. We should sort out all the existing warn cases that fall into this category at the same time on that bug and not hold up an important improvement for many. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #146 from Martin Renvoize --- (In reply to Martin Renvoize from comment #144) > I can confirm the branch does work as expected (when you remember to run the > yarn commands 'yarn install && yarn build') > > We've had this branch checked out for a few days with PTFS-E staff testing, > and even had a feedback session with ByWater staff. > > Written feedback here to follow. OK.. so after conversing about this.. the tl:dr feedback was "We like it" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 Tomás Cohen Arazi changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||This enhancement adds the release notes||following plugin hooks: ||- ||opac_results_xslt_variables ||- ||opac_detail_xslt_variables || ||This allows us to pass ||valuable information for ||XSLT customization. || ||Plugins implementing this ||hooks, should return a ||hashref containing the ||variable names and values ||to be passed to the XSLT ||processing code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25078 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18050 CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Nick Clemens changed: What|Removed |Added Attachment #111324|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 111335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111335&action=edit Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26600] Missing module in Indexer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26600 Nick Clemens changed: What|Removed |Added Attachment #111057|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 111334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111334&action=edit Bug 26600: Missing module in Elasticsearch/Indexer.pm Just formally needed. It is already loaded somewhere. That is: Koha::SearchEngine::Elasticsearch. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26600] Missing module in Indexer.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26600 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 --- Comment #8 from Martin Renvoize --- Checked and confirmed the changes make sense.. nice work! As for the early developers that were missing, when I discussed this with Chris a while back it was due to the way things were committed in the early days on SVN... I think they shared a commit bit and so things went in under one name/user and the history file reflects his personal knowledge of who joined the team when at that early stage before they split out commit bits. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26621] .mailmap adjustments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621 Martin Renvoize changed: What|Removed |Added Attachment #111327|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 111333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111333&action=edit Bug 26621: Adjust docs/contributors.yaml accordingly Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
