[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #9 from Lari Taskula --- Created attachment 112384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112384=edit Bug 26814: (SMART-RULES GUI) Add onsite_checkout into user interface SMART-RULES GUI tag means that this patch will apply before Bug 15522. To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814
--- Comment #8 from Lari Taskula ---
Created attachment 112383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112383=edit
Bug 26814: Add onsite_checkout to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
onsite_checkout where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'onsite_checkout' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=1611=sub GetLoanLength {
C4/Circulation.pm=1650=sub GetHardDueDate {
C4/Circulation.pm=2301=sub _calculate_new_debar_dt {
C4/Circulation.pm=2654=sub CanBookBeRenewed {
C4/Circulation.pm=3107=sub GetSoonestRenewDate {
C4/Circulation.pm=3171=sub GetLatestAutoRenewDate {
C4/Overdues.pm=224=sub CalcFine {
C4/Reserves.pm=2245=sub GetHoldRule {
Check these subroutines and make sure they are using
get_effective_rules() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows onsite_checkout) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with onsite_checkout of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #10 from Lari Taskula --- Created attachment 112385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112385=edit Bug 26814: (SMART-RULES GUI) Indent and add onsite_checkout to all_rules hash SMART-RULES GUI tag means that this patch will apply before Bug 15522. No other changes in this patch. To test: 1. git diff --word-diff=color --ignore-all-space HEAD~1 -- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt 2. Observe only $osc has been added Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814
--- Comment #7 from Lari Taskula ---
Created attachment 112382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112382=edit
Bug 26814: Add onsite_checkout to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
onsite_checkout where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'onsite_checkout' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a onsite_checkout (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=394=sub TooMany {
C4/Circulation.pm=1375=sub AddIssue {
C4/Circulation.pm=1697=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1753=sub GetBranchItemRule {
C4/Circulation.pm=3040=sub GetRenewCount {
C4/Reserves.pm=359=sub CanItemBeReserved {
C4/Reserves.pm=2245=sub GetHoldRule {
Koha/Biblio.pm=295=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=93=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=221=sub get_effective_rules {
Koha/CirculationRules.pm=395=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=421=sub get_onshelfholds_policy {
Koha/CirculationRules.pm=443=sub get_lostreturn_policy {
Koha/CirculationRules.pm=538=sub get_effective_daysmode {
Koha/Item.pm=617=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, onsite_checkout is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows onsite_checkout) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814
--- Comment #5 from Lari Taskula ---
Created attachment 112380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112380=edit
Bug 26814: Add onsite_checkout to set_rule
To test:
1. Find all occurrences of set_rule that are missing onsite_checkout
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'onsite_checkout' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a onsite_checkout (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=331=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
onsite_checkout. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814
--- Comment #6 from Lari Taskula ---
Created attachment 112381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112381=edit
Bug 26814: Add onsite_checkout to set_rules
To test:
1. Find all occurrences of set_rules that are missing onsite_checkout
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' \
--exclude="smart-rules.pl" --exclude="smart-rules.tt" | \
grep -avz 'onsite_checkout' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a onsite_checkout (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=401=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
onsite_checkout. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #1 from Lari Taskula --- Created attachment 112376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112376=edit Bug 26814: Add a new column onsite_checkout to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #4 from Lari Taskula --- Created attachment 112379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112379=edit Bug 26814: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files (excluding .git, atomicupdates nor updatedatabase.pl, no release notes) 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (excluding .git, atomicupdates and updatedatabase.pl and release notes) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #2 from Lari Taskula --- Created attachment 112377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112377=edit Bug 26814: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 --- Comment #3 from Lari Taskula --- Created attachment 112378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112378=edit Bug 26814: Add onsite_checkout to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #112003|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 112374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112374=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Attachment #112004|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 112375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112375=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki changed: What|Removed |Added CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #4 from Arthur Suzuki --- I propose the following test plan : 1) install a plugin which make use of PLUGIN_DIR in templates and check it works 2) adding a new plugin dir to koha-conf.xml and restart_all 3) plugin doesn't work anymore. 4) apply patch and restart_all 5) the plugin should now work As an example plugin which requires the variable I used this one : https://github.com/fredericd/Koha-Plugin-Tamil-Mirabel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #96 from Nick Clemens --- Works well, all tests pass, confirmed it works for SIP and SCO, excellent job! I cleaned up a few commit messages to make them clearer, they could be squashed on push to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #95 from Nick Clemens --- Created attachment 112373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112373=edit Bug 23916: (QA follow-up) Remove stray changes and fix typo There were a couple changes that had no effect, so cleaned those up Typo 'is' for 'if' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #92 from Nick Clemens --- Created attachment 112370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112370=edit Bug 23916: (follow-up) Fix terminology, use patron-title and make column consistent in issues and old_issues This commit makes the changes suggested by Katrin in comment #50: - Changed syspref from RecordIssuer to RecordStaffUserOnCheckout - Changed terminology from "issue" to "check out" and variations - Fixed name display to use patron-title.inc - Made issuer column DEFAULT NULL consistently between issues and old_issues and between the DB update and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #93 from Nick Clemens --- Created attachment 112371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112371=edit Bug 23916: (follow-up) Rebase unit tests This commit is a response to Katrin's comments in comment #62: - Fixed merge conflict It also fixes a test which now fails due to an upstream change in C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #94 from Nick Clemens --- Created attachment 112372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112372=edit Bug 23916: (follow-up) Fix unit test This commit responds to the comment made by Katrin in comment #73. I have removed the lines cited as causing the contraint violation. The were added in the original iteration of the bug patches and, despite spending time trying to get to the bottom of it, I cannot figure out why. There are no changes in the patchset relating to Koha/Patron.pm and removing the lines does not cause any of the tests in files that *are* affected by this patchset to fail. I do not know why these lines were ever added in the first place, unfortunately I did not add comments explaining (lesson learned)! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #90 from Nick Clemens --- Created attachment 112368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112368=edit Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #91 from Nick Clemens --- Created attachment 112369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112369=edit Bug 23916: (follow-up) Don't anonymise issuer and don't update action_logs on upgrade This commit implements the two suggestions made by Nick in comment #41: - Removes the attempted retrospective addition of issuers to old issues. It was not particularly reliable, it also is not appropriate if the user does not wish to make use of this functionality - Removes the conversion of a NULL issuer to the anonymous borrowernumber when anonymising checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #89 from Nick Clemens --- Created attachment 112367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112367=edit Bug 23916: Add unit tests This patch adds unit tests for the new functions Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #88 from Nick Clemens --- Created attachment 112366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112366=edit Bug 23916: Anonymise 'issuer' when required This patch adds the anonymisation of 'old_issues.issuer' alongside the existing anonymisation of 'old_issues.borrowernumber' Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Nick Clemens changed: What|Removed |Added Attachment #112248|0 |1 is obsolete|| Attachment #112249|0 |1 is obsolete|| Attachment #112250|0 |1 is obsolete|| Attachment #112251|0 |1 is obsolete|| Attachment #112252|0 |1 is obsolete|| Attachment #112253|0 |1 is obsolete|| Attachment #112254|0 |1 is obsolete|| Attachment #112255|0 |1 is obsolete|| Attachment #112256|0 |1 is obsolete|| Attachment #112257|0 |1 is obsolete|| --- Comment #85 from Nick Clemens --- Created attachment 112363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112363=edit Bug 23916: Add issues.issuer column and FK This patch adds the issues.issuer column which is a foreign key to borrowers.borrowernumber Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #86 from Nick Clemens --- Created attachment 112364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112364=edit Bug 23916: Add "RecordIssuer" syspref This patch adds the "RecordIssuer" syspref, which is disabled by default Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #87 from Nick Clemens --- Created attachment 112365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112365=edit Bug 23916: Record and display item issuer This patch adds the recording and display of the item issuer. This behaviour is governed by the RecordIssuer syspref, if disabled (the default), no recording or display of issuer will take place. Signed-off-by: Ben Veasey Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki changed: What|Removed |Added Attachment #112295|0 |1 is obsolete|| --- Comment #3 from Arthur Suzuki --- Created attachment 112362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112362=edit Bug 26803 - Fix PLUGIN_DIR when plugin_dirs is multivalued When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. See bug 23237 Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26803] Fix PLUGIN_DIR when plugin_dirs is multivalued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #78 from Lari Taskula --- Taking a different approach with less code dependencies - moving these patches to Bug 26814. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26028] Allow HoldsToPullStartDate to be blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26028 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #1 from Agnes Rivers-Moore --- This may meed deeper investigation. We think the problem more than just the Holds to Pull report. It's much bigger than that. The system should consider the hold to be active after it is either manually unsuspended or it reaches the end date of a suspension. We see that the circulation side of Koha simply does not indicate the hold status at all - it is not shown as on hold or hold pending on the staff side, but the OPAC does show hold pending, not available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26814 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25089 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26814] New: Add onsite_checkout to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Bug ID: 26814 Summary: Add onsite_checkout to circulation rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@hypernova.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We need the ability to define different circulation rules for normal and on-site checkouts. This Bug aims to add support for such functionality. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22394] Remove C4::Accounts::manualinvoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22394 Nick Clemens changed: What|Removed |Added Attachment #112259|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 112361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112361=edit Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26686] Sorting for "Updated on" broken on patron's "Notices" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26686 Nick Clemens changed: What|Removed |Added Attachment #112244|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 112360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112360=edit Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26686] Sorting for "Updated on" broken on patron's "Notices" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26686 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25353] Correct eslint errors in additems.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25353] Correct eslint errors in additems.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Nick Clemens changed: What|Removed |Added Attachment #112260|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 112359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112359=edit Bug 25353: Correct eslint errors in additems.js This patch makes minor changes to additem.js to correct errors highlighted by eslint: - Consistent indentation - Notation of global and exported variables and functions - Consistent use of the "var" declaration for all new variables - Remove variables from function calls which aren't used To test, apply the patch and use your preferred eslint-enabled tool to check for errors. There should be none. If you don't have eslint integrated in your development environment you could use the online ESLint demo at https://eslint.org/demo. The demo isn't configured to assume a browser environment with jQuery present, so you'll have to modify the top line after pasting the contents of additem.js: /* global $ alert window __ */ Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26450] Typo in UNIMARC field 105 plugin template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26450 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26450] Typo in UNIMARC field 105 plugin template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26450 Nick Clemens changed: What|Removed |Added Attachment #112263|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 112357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112357=edit Bug 26450: fix typo in plugin template The UNIMARC field 105 plugin template contains some dropdown menu options with unnecessary capitalisation: "w - Religious text". This patch fixes that. Test plan: apply the patch, and confirm that the dropdown menu options appear in all lowercase. Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26450] Typo in UNIMARC field 105 plugin template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26450 --- Comment #4 from Nick Clemens --- Created attachment 112358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112358=edit Bug 26450: (QA follow-up) Replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26450] Typo in UNIMARC field 105 plugin template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26450 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Passing QA, but noting that on hea the majority of installs do not enable this preference. Maybe this default fixes it, but worth mentioning Also, please remember to capitalize the "B" in 'bug' in your commit titles ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Nick Clemens changed: What|Removed |Added Attachment #112355|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 112356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112356=edit Bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Nick Clemens changed: What|Removed |Added Attachment #112352|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 112355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112355=edit Nug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #33 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #30) > 2) It looks like the advanced editor still defaults to default - should this > be changed as well? I have implemented everything except this point, I'm not sure the best way to go about it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #32 from Aleisha Amohia --- Created attachment 112354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112354=edit Bug 23111: (follow-up) Add a column to show default framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #9 from Nick Clemens --- This fixes the issue mentioned, others should be on a new bug, there could be a lot of refactoring here to make this a bit more readable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25167] Fix not for loan filter in inventory tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #8 from Nick Clemens --- Created attachment 112353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112353=edit Bug 25167: (QA follow-up) Don't add a new variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26813] New: Accessibility: Review labels of page elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26813 Bug ID: 26813 Summary: Accessibility: Review labels of page elements Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P3 Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kath...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Some page elements are not consistently labelled. Tested this on the staff interface home page only. Would be great to learn the best way to label page elements, make those changes, and test with a screen reader. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26812] New: Accessibility: Make indication of which visual element is highlighted more obvious to sighted users tabbing through elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26812 Bug ID: 26812 Summary: Accessibility: Make indication of which visual element is highlighted more obvious to sighted users tabbing through elements Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kath...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To reproduce: When on the staff interface home page, try tabbing through the page elements. Notice that is hard to see which page element is selected. Suggested changes: Changes could include a bolder hover text, shading the whole box/button when selected or bolder shading/colour change if strengthening the outline highlight of an element. I only tested the Koha staff home page, but this could be a bit of a project working through all of Koha looking to improve visibility/contrast. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Owen Leonard changed: What|Removed |Added Component|Circulation |Templates Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Version|20.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Owen Leonard changed: What|Removed |Added Summary|Reduce number of times a|Improve tab key access to |user has to press tab to|circulation confirmation |confirm a check out when|dialog |there is a condition that | |the user may want to| |overide, and is circulating | |without a mouse| |(Accessibility issue) | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 David Nind changed: What|Removed |Added Attachment #112332|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112352=edit bug 26783: set OpacRenewalAllowed to "Allow" for new Koha installations test plan: 1.Drop and recreate database 2.Go through web installer 3.Observe that "OpacRenewalAllowed" is set to "Don't Allow" 4.Apply patch 5.Repeat steps 1 and 2 6.Observe that "OpacRenewalAllowed" is now set to "Allow" sponsored-by: Catalyst Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26811] New: Accessibility: Improve staff client usability for non-mouse users by changing order of page elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26811 Bug ID: 26811 Summary: Accessibility: Improve staff client usability for non-mouse users by changing order of page elements Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kath...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The order of page elements could be improved to enhance the user experience for any user that does not use a mouse and instead tabs through, e.g. screen-reader users or those who prefer to only use the keyboard. To reproduce: When on the staff interface home page, try tabbing through the page elements. Notice the order you go through the elements. (I will open other bugs to address the highlighting of elements, and labels). Currently the first tab goes to the submit button, then back to the check out tab under the search box, then through everything in the left hand column. Suggested order: the next elements to tab across after submit and Check out are the Checkin, Renew, Search Patrons, Search the catalog (all the items across the tabs under the search box), then to the top News block (in case libraries use this for urgent announcements?), back to the modules, then on to the other things down the left hand navigation. Open to other input on the order or things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26725] Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |tal.rog...@cass.govt.nz --- Comment #10 from Alex Buckley --- Now Tal has a Bugzilla account, I'll set her as the assignee :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26726] Improve link text on Transport cost matrix page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26726 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |tal.rog...@cass.govt.nz --- Comment #5 from Alex Buckley --- Now Tal has a Bugzilla account I'll set her as the assignee :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26783] Set OpacRenewalAllowed to "Allowed" for new installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26783 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |tal.rog...@cass.govt.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens changed: What|Removed |Added Attachment #112313|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 112351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112351=edit Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26760] Redirect to paycollect.pl when clicking on "Save and pay"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26760 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- I was unsure at first about not being able to add a reason without sending the notice, however, it seems like you just won't add a reason if you don't want to send. You can also force the reason and prevent sending by wrapping the notice in a conditional: [% UNLESS hold.cancellation_reason == 'INSANITY' %] ... [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens changed: What|Removed |Added Attachment #112337|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 112350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112350=edit Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. To test: 1/ Ensure the unit tests continue to pass after the patch (t/db_dependent/Reserves/CancelExpiredReserves.t) Also: 1 - Add an expired hold for a patron: INSERT INTO RESERVES (borrowernumber, biblionumber, expirationdate, found,branchcode,itemnumber) VALUES (5,5,'2020-01-01','W','CPL',983); 2 - Set ExpireReservesMaxPickUpDelay to Allow 3 - Run the cronjob: perl misc/cronjobs/hold/cancel_expired_holds.pl --reason EXPIRED 4 - Visit the patron's notices tab 5 - Confirm they have been sent a cancellation notice Signed-off-by: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805
Owen Leonard changed:
What|Removed |Added
Attachment #112348|0 |1
is obsolete||
--- Comment #5 from Owen Leonard ---
Created attachment 112349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112349=edit
Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC
This patch removes the use of the jquery.checkboxes plugin from the 5
templates in the OPAC which still use it. The plugin itself is removed.
To test, apply the patch and test the "Select all" and "Clear all" links
work to select and deselect checkboxes on the following pages:
- The catalog search results page: The controls should also enable
and disable the "Select titles to..." menu.
- The list contents page: The controls should also enable
and disable the "Select titles to..." links.
- The suggestions page: The controls should also enable
and disable the "Select suggestions to..." link.
- The search history page: The controls should affect only the
corresponding table ("Current" or "Previous") and should enable and
disable the "Select searches to..." link.
This patch also modifies the template for grouped search results, as
enabled by the OpacGroupResults system preference, but I don't know how
to test it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805
Owen Leonard changed:
What|Removed |Added
Attachment #112308|0 |1
is obsolete||
--- Comment #4 from Owen Leonard ---
Created attachment 112348
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112348=edit
Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC
This patch removes the use of the jquery.checkboxes plugin from the 5
templates in the OPAC which still use it. The plugin itself is removed.
To test, apply the patch and test the "Select all" and "Clear all" links
work to select and deselect checkboxes on the following pages:
- The catalog search results page: The controls should also enable
and disable the "Select titles to..." menu.
- The list contents page: The controls should also enable
and disable the "Select titles to..." links.
- The suggestions page: The controls should also enable
and disable the "Select suggestions to..." link.
- The search history page: The controls should affect only the
corresponding table ("Current" or "Previous") and should enable and
disable the "Select searches to..." link.
This patch also modifies the template for grouped search results, as
enabled by the OpacGroupResults system preference, but I don't know how
to test it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 Nick Clemens changed: What|Removed |Added Attachment #112333|0 |1 is obsolete|| Attachment #112336|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 112347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112347=edit Bug 26706: Fix btn-default styling for better contrast This patch makes some updates to the OPAC's CSS in order to make Bootstrap button styles more consistent. Some CSS has been simplified and some has been made more specific. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a variety of pages in the OPAC to confirm that button styles look good. For example: - Advanced search. - Catalog search results. - Bibligraphic details (including sidebar menu links and menus). - Subscription details, brief and full - "Your summary" page, various tabs. - Lists The more pages tested the better! Be sure to test the hover and active states of buttons as well. https://bugs.koha-community.org/show_bug.cgi?id=26707 Signed off: Lisette Scheer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #604 from Aleisha Amohia --- Created attachment 112346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112346=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26725] Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #9 from Nick Clemens --- Created attachment 112345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112345=edit Bug 26725: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26725] Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 --- Comment #8 from Nick Clemens --- Created attachment 112344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112344=edit Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26725] Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26725] Improve link text on Patron attributes administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725 Nick Clemens changed: What|Removed |Added Attachment #112319|0 |1 is obsolete|| Attachment #112320|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 112343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112343=edit Bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lisettesla...@gmail.com --- Comment #3 from Lisette Scheer --- The checkboxes and select all/unselect boxes all seem to work properly. On the catalog and list pages it doesn't seem to have any effect on the dropdown menu or link. On Purchase Suggestions the Select Suggestions to : Delete link never becomes clickable. Search History worked properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Owen Leonard changed: What|Removed |Added Attachment #112341|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 112342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112342=edit Bug 26810: Restore OpacCustomSearch news display To test: 1 - Define a new opac news entry for OpacCustomSearch 2 - Browse opac, notice the standard search bar is displayed 3 - Apply patch 4 - Note new search bar displays on refresh Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23796] Convert OpacCustomSearch system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Nick Clemens changed: What|Removed |Added Blocks||26810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Caroline Cyr La Rose changed: What|Removed |Added Attachment #112340|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 112341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112341=edit Bug 26810: Restore OpacCustomSearch news display To test: 1 - Define a new opac news entry for OpacCustomSearch 2 - Browse opac, notice the standard search bar is displayed 3 - Apply patch 4 - Note new search bar displays on refresh Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Nick Clemens changed: What|Removed |Added Depends on||23796, 20168 Assignee|oleon...@myacpl.org |n...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 [Bug 23796] Convert OpacCustomSearch system preference to news block -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Nick Clemens changed: What|Removed |Added Blocks||26810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 --- Comment #1 from Nick Clemens --- Created attachment 112340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112340=edit Bug 26810: Restore OpacCustomSearch news display To test: 1 - Define a new opac news entry for OpacCustomSearch 2 - Browse opac, notice the standard search bar is displayed 3 - Apply patch 4 - Note new search bar displays on refresh -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] New: OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Bug ID: 26810 Summary: OpacCustomSearch is no longer a system preference, we must use the template variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 23796 moved OPacCustomSearch to News form SystemPreferences Bug 20168 set the template to use the syspref again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
