[Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26584] Remove unused C4::Acquisition::CloseBasket function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 David Nind changed: What|Removed |Added Attachment #111010|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 112796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112796=edit Bug 26584: Remove unused C4::Acquisition::CloseBasket function This patch makes code use the new Koha::Acquisition::Basket->close method and makes CloseBasket obsolete. It then removes it, and adapts the few places in which it was used. 1. Apply this patch 2. Run: $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => SUCCESS: Tests pass! 3. Try playing with baskets, closing them => SUCCESS: All works as expected! 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26807] Relator term punctuation should not be automatically added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26807 Katrin Fischer changed: What|Removed |Added Summary|Realtor Term Punctuation|Relator term punctuation |should not be automatically |should not be automatically |added |added -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26820] "Important" flag enforced only at subfield level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26820 --- Comment #1 from Katrin Fischer --- Hi Andrew, I tested with 243 and I do get the warning on saving once all mandatory fields are filled in. Could it be only the controlfields acting differently? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 --- Comment #1 from Katrin Fischer --- Confirmed on master with kohadevbox. My item was 300276 from sample data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Katrin Fischer changed: What|Removed |Added Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26842] SIP should allow bib level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26842 Katrin Fischer changed: What|Removed |Added Summary|SIP should allow bib level |SIP should allow bib level |hols|holds --- Comment #1 from Katrin Fischer --- This sounds similar to your discussion with Nick on bug 26461, can you check if it's a duplicate maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26866] Items table on additem should sort by cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26866 --- Comment #3 from Katrin Fischer --- Thx, Andrew! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 --- Comment #2 from Katrin Fischer --- I can understand the use case, but I feel like it would be giving wrong information somehow to update the timestamp on the record level without an actual change to the record. For example it would create extra updates over our API to the union catalog, where we don't transfer items, but only record changes. That probably would not be that many, but it might be worth seeing if we can figure out a different way to make the 'remove' of items known. How does Aspen Discovery get the record information from Koha, OAI-PMH? How does it deal with deleted items? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 --- Comment #4 from Katrin Fischer --- So glad to see this close to finished :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 Katrin Fischer changed: What|Removed |Added Attachment #112773|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112795=edit Bug 26806: Remove the jquery.checkboxes plugin from the staff client This patch removes the jquery.checkboxes plugin from the staff client. It also removes some leftover instances of the "checkboxed" class which was used in some cases to enable the checkbox plugin on selected elements. To test, apply the patch and check that the jquery.checkboxes plugin no longer exists in /intranet-tmpl/lib/jquery/plugins. To test changes to the templates, confirm that "Check all" and "Check none" links still work on these pages: - The tags review page. See the test plan for Bug 26120. - The inventory page. See the test plan for Bug 26150. - The list contents page. See the test plan for Bug 26204. The other modified templates contained the "checkboxed" class but it served no purpose: - Serials -> Serials collection - Labels -> Edit label batch - Patron cards -> Edit card batch If you search the Koha codebase for instances of "checkboxed" the only results should be from the OPAC (if Bug 26805 hasn't been applied) and in Z39.50 templates where the class is still used by JavaScript. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 Katrin Fischer changed: What|Removed |Added Attachment #112485|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112794=edit Bug 26487: Add all MARC flavours for not-onloan-count search field In admin/searchengine/elasticsearch/mappings.yaml the search field not-onloan-count is defined for MARC21 on 999x. This should be for all the MARC flavours, like in Zebra config. Test plan: 1) On a UNIMARC database 2) Reset Elasticsearch mappings 3) Check search engine config to see field 'not-onloan-count' on 999$x 4) Same on a NORMARC database Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26487] Add all MARC flavours for not-onloan-count search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26487 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26583] Unnecessary code in AddIssue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Katrin Fischer changed: What|Removed |Added Attachment #112484|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 112793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112793=edit Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26583] Unnecessary code in AddIssue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26583 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- Hi Lucas, thx a lot for reworking this. I feel with the current size of the modal we have the same issue as with the inline one, that it's too small to get a good impression. Could we have this a bit bigger? Or maybe at least as wide as the graphics in it? Sorry to bother you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26753] Set focus for cursor to password field on Overdrive login popup on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26753 Katrin Fischer changed: What|Removed |Added Attachment #112489|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112792=edit Bug 26753: Set focus for cursor to password field on Overdrive login popup on OPAC This patch modifies the OverDrive login process so that clicking the "Log in to your OverDrive account" link automatically puts the focus on the password field when the modal displays. Unrelated change: A redundant "document.ready" function has been removed. To test you must have OverDrive credentials set in system preferences. - Log in to the OPAC. - On the "Your summary" page, open the "OverDrive account" tab. - Click the "Log in to your OverDrive account" link. - A modal dialog should appear, and the cursor focus should automatically be on the password field. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 Katrin Fischer changed: What|Removed |Added Attachment #112593|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112791=edit Bug 26830: Set focus for cursor to name input box when creating a new list in the OPAC This patch adds the "focus" class to the list name input box in order to automatically set focus on the field. To test, apply the patch and log in to the OPAC. - Go to Lists -> New list. - The cursor focus should automatically be on the "list name" field. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 --- Comment #20 from Katrin Fischer --- Created attachment 112790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112790=edit Bug 25700: (follow-up) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What|Removed |Added Attachment #112784|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 112788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112788=edit Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What|Removed |Added Attachment #112785|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 112789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112789=edit Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 Katrin Fischer changed: What|Removed |Added Attachment #112591|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112787=edit Bug 26828: Set focus for cursor to current password field when updating in the OPAC This patch adds the "focus" class to the first field in the OPAC's password update form so that the field automatically receives focus upon page load. To test, apply the patch and make sure the OpacPasswordChange system preference is enabled. - Log in to the OPAC - Open the "Change your password" page - The cursor should automatically be in the "Current password" field when the page loads. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What|Removed |Added Attachment #112173|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 112784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112784=edit Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What|Removed |Added Attachment #112729|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 112786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112786=edit Bug 25700: (follow-up 2) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What|Removed |Added Attachment #112174|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 112785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112785=edit Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 Katrin Fischer changed: What|Removed |Added Attachment #112590|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112783=edit Bug 26826: Set focus for cursor to name input box when creating a new list This patch adds the "focus" class to the list name input field so that it automatically has focus when the page loads. To test, apply the patch and open the lists page in the staff client. - Click "New list." - When the list creation page loads the "Name" field should have focus. Signed-off-by: B Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112587|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 112782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112782=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #16 from Katrin Fischer --- Do we need any documentation for the API routes here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112438|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 112781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112781=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112437|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 112780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112780=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112330|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 112779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112779=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112328|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 112778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112778=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 Katrin Fischer changed: What|Removed |Added Attachment #112670|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112777=edit Bug 26816: Chomp whitespace around i18n strings This patch adds the chomp shorthand [%- -%] to the output of i18n.inc to prevent extra spaces from being inserted. To test, apply the patch and perform a catalog search in the staff interface which will return results with multiple items. In the items column, the availability information should not have unwanted spaces: 3 items, 3 available: ...instead of 3 items , 3 available: Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26816] Remove extra space before comma in staff results item list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26816 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer changed: What|Removed |Added Attachment #112728|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112776=edit Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26817] "Total" line in checkouts table is too short when ExportCircHistory is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What|Removed |Added Attachment #112750|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112775=edit Bug 26880: Add explanatory text to add course reserve pages To test: - go to course reserve add item and batch add items pages - batch add has a little bit of explanation, add has none - apply patch, restart, reload pages - both pages have more text explaining how they work! "Checking the box next to the field label will enable changes to that field. Leave boxes unchecked to make no change. Any items with existing course reserves will have their on reserve values updated." Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26880] Add explanatory text to Add course reserve screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26880 Katrin Fischer changed: What|Removed |Added Summary|Add explanatory text to Add |Add explanatory text to Add |Course Reserve screens |course reserve screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Katrin Fischer changed: What|Removed |Added Attachment #112764|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 112774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112774=edit Bug 26881: Remove period on limit to available items on opac To test: 1- do a search on the opac 2- on the results page, it says "Limit to currently available items." 3- apply patch, restart, reload 4- period is gone Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26806] Remove the jquery.checkboxes plugin from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26806 David Nind changed: What|Removed |Added Attachment #112309|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112773=edit Bug 26806: Remove the jquery.checkboxes plugin from the staff client This patch removes the jquery.checkboxes plugin from the staff client. It also removes some leftover instances of the "checkboxed" class which was used in some cases to enable the checkbox plugin on selected elements. To test, apply the patch and check that the jquery.checkboxes plugin no longer exists in /intranet-tmpl/lib/jquery/plugins. To test changes to the templates, confirm that "Check all" and "Check none" links still work on these pages: - The tags review page. See the test plan for Bug 26120. - The inventory page. See the test plan for Bug 26150. - The list contents page. See the test plan for Bug 26204. The other modified templates contained the "checkboxed" class but it served no purpose: - Serials -> Serials collection - Labels -> Edit label batch - Patron cards -> Edit card batch If you search the Koha codebase for instances of "checkboxed" the only results should be from the OPAC (if Bug 26805 hasn't been applied) and in Z39.50 templates where the class is still used by JavaScript. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer changed: What|Removed |Added Attachment #112765|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 112772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112772=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Katrin Fischer changed: What|Removed |Added Attachment #112766|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112771=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer changed: What|Removed |Added Attachment #112769|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 112770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112770=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes: See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758#c3 for how to setup ILL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind changed: What|Removed |Added Attachment #112261|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112769=edit Bug 26795: Remove the use of jquery.checkboxes plugin from ILL pages This patch removes the inclusion of the jquery.checkboxes plugin from two staff interface ILL pages where the plugin is unused. To test you need at least one patron with some ILL requests. - Apply the patch and locate a patron with ILL requests. - Click the "ILL requests history" tab. - Confirm that the table of requests has no checkboxes. - Choose "Ill requests" from the "More" menu in the header. - Confirm that the table of requests has no checkboxes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26795] Remove the use of jquery.checkboxes plugin from ILL pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26795 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26883] Bad undefined position 18 in tag 000 (leader) in marc21_leader_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26883 Pablo López Liotti changed: What|Removed |Added Summary|Lost position 18 in tag 000 |Bad undefined position 18 |(leader) in |in tag 000 (leader) in |marc21_leader_authorities.p |marc21_leader_authorities.p |l |l -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26883] New: Lost position 18 in tag 000 (leader) in marc21_leader_authorities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26883 Bug ID: 26883 Summary: Lost position 18 in tag 000 (leader) in marc21_leader_authorities.pl Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: palio...@mdp.edu.ar QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 112768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112768=edit marc21_leader_authorities.pl bug Using marc21_leader_authorities.pl with tag 000 (leader) to add authority records, it´s marked how "undefined" position 18. Position 19 is really undefined in Marc format but 18 not. This one-character code is actually valid and useful according http://www.loc.gov/marc/authority/adleader.html Character function is like position 18 of marc21_leader.pl in tag 000 Regards from Mar del Plata Pablo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Created attachment 112767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112767=edit Screenshots - After patch applied I've attached screenshots of the pages after the patch was applied. Just to note that I found the black text on a grey background hard to read for the 'Add new field' and 'Create' buttons. My notes from testing = I tested using koha-testing-docker and setup two ILL backends: FreeForm and Koha. Instructions are available at https://wiki.koha-community.org/wiki/ILL_backends 1. Create an Illbackends directory outside the koha root: mkdir /usr/share/koha/lib/Koha/Illbackends 2. Change to the newly cerated directory: cd /usr/share/koha/lib/Koha/Illbackends 3. Clone the FreeForm and Koha backends: i. git clone https://github.com/PTFS-Europe/koha-ill-freeform.git ii. git clone https://github.com/PTFS-Europe/koha-ill-koha.git 4. Rename the directories: i. mv koha-ill-freeform FreeForm ii. mv koha-ill-koha Koha 5. Setup symbolic links to these directories: i. mkdir /kohdevebox/koha/Koha/Illbackends ii. ln -s /usr/share/koha/lib/Koha/Illbackends/FreeForm /kohadevbox/koha/Koha/Illbackends/ iii. ln -s /usr/share/koha/lib/Koha/Illbackends/Koha /kohadevbox/koha/Koha/Illbackends/ 6. Change ownership (not sure if this is required): i. chown -R kohdev-koha:kohadev-koha /kohdevebox/koha/Koha/Illbackends ii. chown -R kohdev-koha:kohadev-koha /usr/share/koha/lib/Koha/Illbackends 7. Enable interlibrary loans system preference: ILLModule 8. Add some text to the ILLModuleCopyrightClearance system preference. 9. Restart everything: i. flush_memcached ii. restart_all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 David Nind changed: What|Removed |Added Attachment #112085|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112766=edit Bug 26758: Correct OPAC ILL requests page markup This patch makes some corrections to the OPAC ILL page which should have been included in the upgrade to Bootstrap 4. To test you must have Interlibrary loan configured and enabled in the OPAC. Enter some text in the ILLModuleCopyrightClearance system preference. - Log in to the OPAC and go to the "your interlibrary loan requests" page. - If you have only one ILL backend set up you should see a "Create a new request" button which is styled correctly. - This patch makes corrections to the menu which displays if you have more than one ILL backend set up, so it would be ideal to be able to test it. - Upon clickng the "new request" button (or selecting a backend from the new request menu) you should be prompted to choose Yes or No in response to the ILLModuleCopyrightClearance text. The buttons should be styled green and red, respectively. - On the new request entry page the "Add new field" and "Create" buttons should be styled in the "secondary" grey style. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 David Nind changed: What|Removed |Added Attachment #112581|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 112765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112765=edit Bug 26808: Improve tab key access to circulation confirmation dialog This patch modifies the checkout template so that the checkout confirmation message can receive focus, improving tab access to the form buttons in the dialog. A "-1" value "tabindex" attribute makes the dialog focusable, and a "focus" class automatically triggers focus. The focus and tabindex are only set when the template logic says that the alert will require confirmation. To test, apply the patch and open a patron's account for checkout. - Submit a barcode for checkout which will trigger a confirmation dialog. For instance: - A barcode they already have checked out - A barcode which is checked out to another patron - When the page reloads you should see an alert-style dialog, "Please confirm checkout." The browser should show a focus outline around the dialog. - Hitting the tab key should move the focus to the first focusable element inside the dialog. If there is a link in the text, this may be the first element. If not the confirmation button should be the next tabbable element. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 ByWater Sandboxes changed: What|Removed |Added Attachment #112763|0 |1 is obsolete|| --- Comment #7 from ByWater Sandboxes --- Created attachment 112764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112764=edit Bug 26881: Remove period on limit to available items on opac To test: 1- do a search on the opac 2- on the results page, it says "Limit to currently available items." 3- apply patch, restart, reload 4- period is gone Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 --- Comment #6 from Barbara Johnson --- Ooh, that is spooky. Must be Halloween. And after 4 years on Koha that’s the first time I saw that period. (In reply to Katrin Fischer from comment #4) > Spooky, I just wanted to file this... are you reading my mind? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Owen Leonard changed: What|Removed |Added Attachment #112760|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 112763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112763=edit Bug 26881: Remove period on limit to available items on opac To test: 1- do a search on the opac 2- on the results page, it says "Limit to currently available items." 3- apply patch, restart, reload 4- period is gone Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26881] Remove the period at the end of 'Limit to currently available items' in facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26881 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26112] Errors in marc21_authorities files for uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26112 Bohdan changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26829] New installer: Make it possible to use a language specific sample quotes file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26829 Katrin Fischer changed: What|Removed |Added Blocks||26882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26882 [Bug 26882] New installer: Make it possible to use a language specific holidays file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26882] New: New installer: Make it possible to use a language specific holidays file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26882 Bug ID: 26882 Summary: New installer: Make it possible to use a language specific holidays file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, koha-bugs@lists.koha-community.org, testo...@bugs.koha-community.org Depends on: 26829 +++ This bug was initially created as a clone of Bug #26829 +++ The sample holidays in the en installer are Sunday, christmas and new year, but these might not generally apply or it would be nice to add other common public holiays specific to the language area. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26829 [Bug 26829] New installer: Make it possible to use a language specific sample quotes file -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
