[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

--- Comment #11 from Jonathan Druart  
---
(In reply to David Cook from comment #10)
> Alternatively, could we pin JSON::Validator to an older version? 

See comment 6, that does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by.

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004

--- Comment #2 from Katrin Fischer  ---
Could setting to NULL also be an option? I think it might work better with FK
constraints than allowing a "dead" one :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

--- Comment #3 from Katrin Fischer  ---
Thx David, I will check that - it's indeed an older version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #107 from Jonathan Druart  
---
(In reply to David Cook from comment #106)
> Finally, I don't actually see myself using KOHA_MOJO_APP in
> koha-testing-docker unless I was testing to see how a transition to using it
> in production would work?

The idea is to provide an easy way for developer to test it in on a daily
basis.
We should first catch eventual issues before knowing it is ready for
production.

I am not sure I understand your question actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22086] Birthday Wishes email to patron

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22086

Alvaro Cornejo  changed:

   What|Removed |Added

 CC||cornejo.alv...@gmail.com

--- Comment #12 from Alvaro Cornejo  ---
I´ve created a script in perl that sends birthday emails using a report that
provides patron info to script. It shall run daily in a cronjob.
See 
https://wiki.koha-community.org/wiki/Scripts_Library#Send_birthday_greetings_to_patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by.

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
(In reply to Enica Davis from comment #0)
> Should Koha allow the deletion of an account when there are still
> return_claims unresolved?

I think yes, either by transferring to another account or by storing a "dead"
borrowernumber like in the reports table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25293

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
Hmm what version of Koha are you using? This should have been fixed by Bug
25293 I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27006

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

David Cook  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds   |This enhancements adds
  release notes|timestamped logs for each   |timestamped logs for
   |PSGI application for|Plack-enabled Koha, which
   |Plack-enabled Koha. These   |makes it easier for system
   |new log files are   |administrators to review
   |plack-opac-error.log,   |warnings and errors in
   |plack-intranet-error.log,   |Koha.
   |and plack-api-error.log and |
   |can be found in the typical |
   |Koha log directory. |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

--- Comment #106 from David Cook  ---
(In reply to Jonathan Druart from comment #105)
> (In reply to Jonathan Druart from comment #98)
> > I have created a merge request on koha-testing-docker to use this easily for
> > devs:
> > https://gitlab.com/koha-community/koha-testing-docker/-/issues/228
> 
> I've worked a bit more on that this morning. Can I get feedback on it please?

Looks good I think. I've just added 1 comment about using the --pid flag with
starman to make the restart_all code a bit more robust.

Actually, here's another question: why are we using starman when we could be
using hypnotoad? 

Finally, I don't actually see myself using KOHA_MOJO_APP in koha-testing-docker
unless I was testing to see how a transition to using it in production would
work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

--- Comment #10 from David Cook  ---
(In reply to Martin Renvoize from comment #9)
> In my understanding we aren't using any of those methods directly with
> Koha... it's rather than many of those methods are used in
> Mojolicious::Plugin::OpenAPI which we're using.  Said plugin has been
> updated to reflect the changes in JSON::Validator but it also requires a new
> Mojolicious than we're currently supporting I think..
> 
> Hense, I don't think it's just a case of updating Koha code, but rather
> tracking down the versions we wish to support and pinning ourselves to them
> properly again.

I had a feeling that might be the case. 

Alternatively, could we pin JSON::Validator to an older version? 

I suppose every approach has its trade offs...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Lucas Gass  changed:

   What|Removed |Added

  Text to go in the||This patch adds the ability
  release notes||to switch between the
   ||TinyMCE (WYSIWYG) text
   ||editor and the more robust
   ||CodeMirror text editor via
   ||the new system preference,
   ||NewsToolEditor, when
   ||editing News items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

--- Comment #21 from Victor Grousset/tuxayo  ---
I have still error in logs

> [2020/11/12 22:42:00] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data 
> too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 
> 169
> [2020/11/12 22:42:00] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): Data 
> too long for column 'lccn' at row 1 at /kohadevbox/koha/Koha/Object.pm line 
> 169

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||vic...@tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo  ---
> When saving the record, I don't get the add new item screen - see the 
> screenshot attached. 

Same error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #143 from Maryse Simard  ---
Created attachment 113583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113583&action=edit
Bug 12446: Add canbeguarantee value to patron categories sample data

This patch changes sample data so patron categories of type 'C' or
'P' can be guarantees by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Maryse Simard  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #144 from Maryse Simard  ---
I decided to keep the default value in the database as 0 because I feel this
would be the most common case. Instead, what I did was add "canbeguarantee"
values in the sample data used for fresh installs. This, plus the database
update, should make sure patron categories of type 'C' and 'P' can be
guarantees by default for both new and updated installs.

As for the "Add guarantee" button displaying the "There are no patron
categories defined." error, this is due to the last patch wich limit categories
to the ones which can be guarantees. It seems normal to me that adding a
guarantee would fail if no patron categories can be used. If this is not ok,
what we could do would be to either hide the button if there is no categories
available or use a more specific error message in that particular case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26522] Elasticsearch - don't attempt to index record if it cannot be retrieved

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26522

--- Comment #4 from Victor Grousset/tuxayo  ---
As well as /var/log/koha/kohadev/plack-intranet-error.log

(got confused with the log files)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26965] streetnumber field not shown in table when searching by partial patron data

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26965

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #6)
> There is a syspref to change the way the addresses are displayed. However
> I've checked when I wrote the patch, the 3 versions has the street number
> before the "address" value

In German the streetnumber goes after the street. So I believe your first idea
was right here and that it needs more thought.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc;h=f31f379d842a39401e579cc177db5406be76dd57;hb=64ee6f0b2bbcc9b23520c689146f1c5cf905e997#l29

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com
   Priority|P5 - low|P3
 Status|Needs Signoff   |Signed Off
   Severity|normal  |critical
   Patch complexity|--- |Small patch

--- Comment #3 from Blou  ---
This functionality crashes without this patch.  Not sure how it got this far
(probably not used much), but this should be fixed for 20.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Blou  changed:

   What|Removed |Added

 Attachment #113417|0   |1
is obsolete||

--- Comment #2 from Blou  ---
Created attachment 113582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113582&action=edit
Bug 26992 - On serial collection page, impossible to delete issues and related
items

serial-collection.pl uses C4::Items::DelItemCheck() function which is obsolte.

Test plan:

1. Create a subscription with items created when receiving.
2. Receive several issues, and create corresponding items.
3. On Serial collection page (serial-collection.pl), select several issues.
4. Click on button Delete selected issues
5. A confirmation page is displayed. Enable "Delete associated items?".
   Then click on "Yes, delete" button.

   You get this error: Undefined subroutine &C4::Items::DelItemCheck
6. Apply the patch an repeat steps 3-5.
   Check that issues and related items are deleted.

Signed-off-by: Blou 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo  ---
Hi, not enough experience with SIP so I have two questions

> 5) Note the "too many overdue" flag is set

> READ: 24  00120201112201630AEEdna 
> Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL|

Which one is it? I couldn't in the spec where is the patron status field.

> 6) Set the new SIP config option "disable_too_many_overdue" for the
> account you used for testing

Where does one do that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com
 Attachment #113581|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #168 from Blou  ---
Created attachment 113581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113581&action=edit
Bug 26948: Regression tests

We already mock the send_or_die method from Email::Stuffer; This patch
updates that mock to extract the internal representation of the email
encoded message and looks for a known double encoded representation of a
character in the sample body.

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 
Signed-off-by: Blou 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781

--- Comment #6 from Aleisha Amohia  ---
(In reply to David Nind from comment #5)
> Patch no longer applies 8-(

I'm waiting for Bug 19532 to get through so I can rebase this on top of that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

Katrin Fischer  changed:

   What|Removed |Added

Summary|If a record has not title,  |If a record has no title,
   |the list of checkouts   |the list of checkouts
   |breaks  |breaks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #12)
> Hm, I believed I had set the leader - because I had pointed out that exact
> thing in comment#4 - time to maybe give it another try.

Feel free to reopen it, if you find other ways to break it. This were just my
findings. And I think it deserves its own bug (the fact that because of the
added 'a' the leader is not auto-populated as the rest of the control fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

Alexis Ripetti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] If a record has not title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
I've run into this, too, and just assumed it was intentional. It would be great
to handle these more gracefully.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #4)
> (In reply to Andrew Fuerste-Henry from comment #3)
> > I saw bug 15851 about how this relates to the serials.
> > Right now, the link shows on the parent record regardless of whether or not
> > it's a serial if UseControlNumber is off. Is that the intended behavior?
> > There absolutely may be some cataloging standard or intended behavior that
> > I'm missing, but it seems like UseControlNumber should impact how the link
> > is formed but not whether or not it appears in the first place.
> 
> Actually, on master it should depend on the LDR - only showing for serials.

Right now, only for bib-level <> a AND bib-level <> b. Not just serials.

https://gitlab.com/koha-community/Koha/-/blob/master/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl#L201-231

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

--- Comment #12 from Katrin Fischer  ---
Hm, I believed I had set the leader - because I had pointed out that exact
thing in comment#4 - time to maybe give it another try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

--- Comment #5 from Kyle M Hall  ---
Created attachment 113580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113580&action=edit
Bug 26352: Add unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #109547|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 113579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113579&action=edit
Bug 26352: Add plugin hooks to transform patron barcodes

Some of our partners have unusual barcode requirements that have
required us to transform scanned barcodes using javascript. This is not
the most reliable method. It would make more sense to have Koha
transform the barcodes on the backend using a plugin. We should add
hooks to transform and generate new item and patron barcodes.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
  
https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/download/v1.0.1/koha-plugin-barcode-transformer-v1.0.1.kpz
3) Go to the plugin configuration page, set the configuration to the example
configuration from the same page
4) In the patron search and anywhere else you can scan a patron
   cardnumber, type in some cardnumbers but prefix them with A and postfix
   them with A or B, e.g. A12345A, A12345B
5) Note the letters are removed by Koha!
6) Try a cardnumber like X123456Y
7) Note Koha converts it to Z13456Z

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m, katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #7)
> 
> The link to the analytical record doesn't show up with UseControlnumber,
> only without.

If UseControlNumber it produces a search on the title (773$t) so it is expected
to find things.

> Searchengine: Zebra

We should file a bug for the default leader created. I'm not sure it affects ES
the same way, but as it will be offsets on the string, I guess the problem will
be the same in ES.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26480] With UseControlNumber on, "Show analytics" link doesn't show on parent record

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26480

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |INVALID

--- Comment #10 from Tomás Cohen Arazi  ---
I've managed to reproduce this issue, but it took me a while to figure.

As a start, I have to say that bug 15851 only highlighted another issue. That
bug introduced a search to be done before rendering the detail page:

'rcn:'. $record->field('001')->data . ' AND (bib-level:a OR bib-level:b)'

This search is the exact same search already existed on the always-diplayed
link. In other words, if the link is not showing, it is because there are no
results. And this means if we showed the link, it wouldn't produce results
either.

I managed to reproduce it simply by picking a record from the sample data, that
contains a 001 field, and using the 'New child record'. Add a title, fix the
missing fields and save.

The host record didn't show the analytics link.

But also Zebra didn't return any results:

root@kohadevbox:koha(bug_26480)$ yaz-client
unix://var/run/koha/kohadev/bibliosocket
Connecting...OK.
Sent initrequest.
Connection accepted by v3 target.
ID : 81
Name   : Zebra Information Server/GFS/YAZ
Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031
Options: search present delSet triggerResourceCtrl scan sort extendedServices
namedResultSets
Elapsed: 0.006809
Z> base biblios
Z> f @and @attr 1=1045 14207979 @or @attr 1=1021 a @attr 1=1021 b
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 0, setno 1
SearchResult-1: term=14207979 cnt=1, term=a cnt=2, term=b cnt=1
records returned: 0
Elapsed: 0.006004
Z>

The CCL version (more readable, similar to the code) gives the same results:

Z> querytype ccl2rpn
Z> set_cclfile /etc/koha/zebradb/ccl.properties
Z> f rcn=14207979 AND (bib-level=a OR bib-level=b)
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 0, setno 2
SearchResult-1: term=14207979 cnt=1, term=a cnt=2, term=b cnt=1
records returned: 0
Elapsed: 0.008100
Z>

So the next step was to look for what is our pipeline sending Zebra for
indexing:

root@kohadevbox:koha(bug_26480)$ xsltproc
/etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl <(sudo
koha-mysql kohadev <<< \
"select  metadata from biblio_metadata where biblionumber=443 limit 1\\G" | \
sed -n 's/metadata: //;2,$p' )

http://indexdata.com/zebra-2.0";
xmlns:marc="http://www.loc.gov/MARC21/slim";
xmlns:kohaidx="http://www.koha-community.org/schemas/index-defs"; type="update"
z:id="443">
  00337
   
   
  2020111218.0
  20111
  20111
  
  
  
  
 
  |
   
  0
  0
   
  eng
  
  
  Algo algo
  Conway, Damian
  Perl best practices /
  14207979
  ddc
  CF
  443
  443
  Ost
  Algo algo
  CF
  
...

You can see there is Record-control-number, with the right value on it. But if
you look closer, you will notice the Bib-level index is empty.

So that's it. I opened the record for editing, opened the LEADER builder,
everything looks correct. Close it. And now the LEADER has more data on it. And
on saving the searches in Zebra work, and the link is displayed as expected.

In my opinion, this might be a bug. On how the default leader value it built,
specifically on child records. Because when it is opened for creation, you see
the 'a' or 'b' value, but the rest of the leader is empty and saving it
produces a wrong behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541

Koha Team University Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #19 from Koha Team University Lyon 3  ---
Hi,
I have a few questions about this BZ:
- which level is checked during the return: the biblio-level or the item-level?
If an hold is on an item-level, the return of another item from the same biblio
shouldn't be blocked.
- If an hold is "served" because an item is waiting or in transfer to another
branch for a reserve, will the other items of the same biblio be blocked? They
shouldn't be if an item is already here for the hold.

Thanks for your explanations :-) !

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #37 from Kyle M Hall  ---
Created attachment 113576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113576&action=edit
Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though
barcodedecode

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #39 from Kyle M Hall  ---
Created attachment 113578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113578&action=edit
Bug 26351: (QA follow-up) Fix Checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #38 from Kyle M Hall  ---
Created attachment 113577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113577&action=edit
Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #35 from Kyle M Hall  ---
Created attachment 113574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113574&action=edit
Bug 26351: (QA follow-up) Remove unused method barcode_transform

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #34 from Kyle M Hall  ---
Created attachment 113573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113573&action=edit
Bug 26351: Add unit tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #36 from Kyle M Hall  ---
Created attachment 113575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113575&action=edit
Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #111916|0   |1
is obsolete||
 Attachment #111917|0   |1
is obsolete||
 Attachment #111918|0   |1
is obsolete||
 Attachment #111919|0   |1
is obsolete||
 Attachment #111920|0   |1
is obsolete||
 Attachment #111921|0   |1
is obsolete||
 Attachment #111922|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall  ---
Created attachment 113571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113571&action=edit
Bug 26351: Add plugin hooks to transform item barcodes

Some of our partners have unusual barcode requirements that have
required us to transform scanned barcodes using javascript. This is not
the most reliable method. It would make more sense to have Koha
transform the barcodes on the backend using a plugin. We should add
hooks to transform and generate new item and patron barcodes.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
  
https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/
3) Go to the plugin configuration page, set the configuration to the example
configuration from the same page
4) In the item barcode field on the checkin and checkout pages,
   and anywhere else you can scan an item barcode, type in some
   valid barcodes, but prefix them with X and postfix them with
   Y, e.g. X123456Y
5) Note the letters are removed by Koha!

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

--- Comment #33 from Kyle M Hall  ---
Created attachment 113572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113572&action=edit
Bug 26351: (QA follow-up) Fix QA script issue

* Fixes issue with barcode generate stub so perlcritic is happy
* Removes extra semicolon from return call in configure method

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement allows a   |This enhancement allows a
  release notes|library to configure the|library to configure the
   |visibility of the input |visibility of the input
   |fields on the OPAC  |fields on the OPAC
   |suggestion form.
   |suggestion form.
   |
   |
   |**New   |**New
   |system preference**:|system preference**:
   |`SuggestionsUnwantedFields` |`OPACSuggestionUnwantedFiel
   |**Removed system|ds`
   |preference**:   |**Removed system
   |`AllowPurchaseSuggestionBra |preference**:
   |nchChoice`  |`AllowPurchaseSuggestionBra
   ||nchChoice`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement allows a   |This enhancement allows a
  release notes|library to configure the|library to configure the
   |visibility of the input |visibility of the input
   |fields on the OPAC  |fields on the OPAC
   |suggestion form.
   |suggestion form.
   |
   |
   |New |**New
   |system preference:  |system preference**:
   |`SuggestionsUnwantedFields` |`SuggestionsUnwantedFields`
   |Removed system preference:  |**Removed system
   |`AllowPurchaseSuggestionBra |preference**:
   |nchChoice`  |`AllowPurchaseSuggestionBra
   ||nchChoice`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement allows the |This enhancement allows a
  release notes|library to configure the|library to configure the
   |visibility of the input |visibility of the input
   |fields on the OPAC  |fields on the OPAC
   |suggestion form.
   |suggestion form.
   |
   |
   |New |New
   |system preference:  |system preference:
   |`SuggestionsUnwantedFields` |`SuggestionsUnwantedFields`
   |Removed system preference:  |Removed system preference:
   |`AllowPurchaseSuggestionBra |`AllowPurchaseSuggestionBra
   |nchChoice`  |nchChoice`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Text to go in the|The new system preference   |This enhancement allows the
  release notes|SuggestionsUnwantedFields   |library to configure the
   |allows you to configure the |visibility of the input
   |visibility of the input |fields on the OPAC
   |fields on the OPAC  |suggestion form.
   |suggestion form. It |
   |replaces the|New
   |AllowPurchaseSuggestionBran |system preference:
   |chChoice system preference. |`SuggestionsUnwantedFields`
   ||Removed system preference:
   ||`AllowPurchaseSuggestionBra
   ||nchChoice`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21898] Add basket info available for ACQORDER

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21898

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds the   |This enhancement adds the
  release notes|aqbasket variable to the|aqbasket variable to the
   |AQORDER notice processor.   |AQORDER notice processor.
   |This allows users to|
   |utilise basket details in   |This allows users to
   |the subject and content of  |utilise basket details in
   |their `AQORDER` notices.|the subject and content of
   ||their `AQORDER` notices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24380] Add option to recalculate fines upon a backdated return distinctly from `CalculateFinesOnReturn`

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement allows |This enhancement allows
  release notes|libraries to set the option |libraries to set the option
   |to calculate fines upon a   |to calculate fines upon a
   |backdated return distinctly |backdated return distinctly
   |from the broader option to  |from the broader option to
   |always recalculate fines on |always recalculate fines on
   |return option.
 |return option.
   |
   |
   |**New   |**New
   |system preference**:|system preference**:
   |`CalculateFinesOnBackdate`  |`CalculateFinesOnBackdate`
   |defaults to enabled on new  |defaults to enabled on new
   |installations or the value  |installations or the value
   |of `CalucalteFinesOnReturn` |of `CalculateFinesOnReturn`
   |during upgrades.|during upgrades.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds the   |This enhancement adds the
  release notes|option to require staff |option to require staff
   |members to confirm that an  |members to confirm that an
   |item contains all it's  |item contains all its
   |listed parts at |listed parts at
   |check-in/check-out time.
   |check-in/check-out time.
   ||
   |New system preference:  |New system preference:
   |`CircConfirmItemParts`  |`CircConfirmItemParts`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27006] New: If a record has not title, the list of checkouts breaks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006

Bug ID: 27006
   Summary: If a record has not title, the list of checkouts
breaks
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We have some cases recently where libraries have only cataloged 245$p (name of
the part) and no $a. This is hard to detect, as $p shows like the title would.
But if you check out the item, the list of checkouts will load forever.

Records in our catalog are added by import from the union catalog - so having
the 245$a mandatory doesn't help in this case. 

Could we have a fix showing "no title" or similar when $a is missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27003] action_logs table error when adding an item

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003

Andres Ovalle López  changed:

   What|Removed |Added

 CC||aova...@biteca.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

--- Comment #1 from Alexis Ripetti  ---
Created attachment 113570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113570&action=edit
Bug 27005: Adding a filter in the datatable of opac-readingrecord page

Test plan:
1) apply patch
2) go to the opac-readingrecord page / your checkout history
3) See that the filter is here and works fine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] New: Adding a filter in the datatable of opac-readingrecord page

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

Bug ID: 27005
   Summary: Adding a filter in the datatable of opac-readingrecord
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alexis.ripe...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Adding a filter to the datatable in order to facilitate research in the
opac-readingrecord page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17279] Edifact::Line quantity should ensure its returning invoiced quantity

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17279

Colin Campbell  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #5 from Colin Campbell  ---
Distinction is maintained by code in patch 18267 which incorporates tests from
this

*** This bug has been marked as a duplicate of bug 18267 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #38 from Colin Campbell  ---
*** Bug 17279 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22818] ILL should be able to send notices

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #194 from Jonathan Druart  
---
Same, I can't recreate anymore, weird! Will see later if it popups.

Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

--- Comment #145 from Jonathan Druart  
---
Last patches squashed and pushed, thanks Andrew!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Small patch

--- Comment #37 from Colin Campbell  ---
Handles tax and discount information from the vendor and deals with different
encodings of quantity. Ensures all populatable fields are handled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26990] No feedback if holds override is disabled and hold fails

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26990] No feedback if holds override is disabled and hold fails

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26990

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26948] Some Koha Emails are double encoded (HOLD, ODUE, ...)

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26948

--- Comment #15 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26948] Some Koha Emails are double encoded (HOLD, ODUE, ...)

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26948

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65246|0   |1
is obsolete||
  Attachment #68707|0   |1
is obsolete||
  Attachment #68708|0   |1
is obsolete||
  Attachment #68709|0   |1
is obsolete||
  Attachment #68710|0   |1
is obsolete||
  Attachment #68711|0   |1
is obsolete||
  Attachment #68712|0   |1
is obsolete||
  Attachment #68713|0   |1
is obsolete||
  Attachment #68714|0   |1
is obsolete||

--- Comment #36 from Colin Campbell  ---
Created attachment 113569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113569&action=edit
Patch to handle Price and related information from Quotes and Invoices

These modified routines have been running in production and have been tested
against all known Edifact vendors messages, both in parsing and populating the
database and ensuring the total amounts match the summary totals in the
incoming files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #59 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #58)
> I think we should keep the number of tests, don't you?
> 
> 
> I wrote a similar patch than "Don't delete existing data before tests" today:
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113551
> 
> I will drop mine, but I think this part makes sense:
> +next
> +  unless grep { $pickup_location eq $_ } @branchcodes;
> 
> 
> Do we agree that this change can be considered an enhancement?

I do keep the number of tests, I just calculate it based on the number of
branches - I think the line you mention makes that unecessary though, so yes,
that line should be copied here

This should be considered a bug - not an enhancement. The current code can
crash a system with the number of DB requests generated and should be
backported to avoid issues on any large systems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23328] Some check-in messages should be dismissable

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23328

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits will warn, but not block the deletion

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23219] Show a warning about cancelling their holds before a patron is deleted

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22627] Rephrase 'your fines and charges' tab in OPAC

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963

--- Comment #58 from Jonathan Druart  
---
I think we should keep the number of tests, don't you?


I wrote a similar patch than "Don't delete existing data before tests" today:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113551

I will drop mine, but I think this part makes sense:
+next
+  unless grep { $pickup_location eq $_ } @branchcodes;


Do we agree that this change can be considered an enhancement?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23522] Show "Actual price" in basket when available

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21891] Remove non-XSLT detail view in the staff client

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24347] Add a 'search to order' function

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7882] Add ability to move and reorder fields and subfields in MARC editor

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23290] XSLT system preferences allow administrators to exploit XML and XSLT vulnerabilities

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23290

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25287] Add columns_settings support to API datatables wrapper

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26032] Add 'is new' filter in items search

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26032

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14567] Add an elasticsearch driven browse interface to the OPAC

2020-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >