[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #195 from Jonathan Druart --- Created attachment 113584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113584&action=edit Bug 22818: Fix the last_insert_id call DBI last_insert_id: invalid number of arguments: got handle + 3, expected handle + between 4 and 5 Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, \%attr ]) at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23326. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #196 from Jonathan Druart --- (In reply to Jonathan Druart from comment #194) > Same, I can't recreate anymore, weird! Will see later if it popups. > > Last patch pushed to master. Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Didier Gautheron changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #197 from Didier Gautheron --- Update datanase isn't working for me DBI last_insert_id: invalid number of arguments: got handle + 3, expected handle + between 4 and 5 Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, \%attr ]) at ./installer/data/mysql/updatedatabase.pl line 23326. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807
--- Comment #11 from Jonathan Druart
---
Any good reasons to have called GetMarcSubfieldStructure with the unsafe flag
set?
% grep unsafe t/db_dependent/Koha/Item.t
my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
$mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 0 } );
Unsafe from tests don't feel safe :)
I am seeing some tests failing (when run twice) because of it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807 Jonathan Druart changed: What|Removed |Added Blocks||27007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] New: GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007
Bug ID: 27007
Summary: GetMarcSubfieldStructure called with "unsafe" in tests
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 23807
It does not feel correct to call GetMarcSubfieldStructure with the unsafe flag
set in tests:
my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
Some tests are failing is run twice
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
[x~10]
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
# Failed test 'Value is mapped correctly for column biblionumber'
# at t/db_dependent/Koha/Item.t line 115.
# got: undef
# expected: '483'
[etc.]
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807
[Bug 23807] Add Koha::Item->as_marc_field
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007
--- Comment #1 from Jonathan Druart
---
Created attachment 113585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113585&action=edit
Bug 27007: Don't call GetMarcSubfieldStructure with unsafe in tests
It does not feel correct to call GetMarcSubfieldStructure with the unsafe flag
set in tests:
my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
Some tests are failing is run twice
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
[x~10]
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
# Failed test 'Value is mapped correctly for column biblionumber'
# at t/db_dependent/Koha/Item.t line 115.
# got: undef
# expected: '483'
[etc.]
Test plan:
Run the tests twice, without the patch it fails, with the patch it
passes
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #198 from Jonathan Druart --- (In reply to Didier Gautheron from comment #197) > Update datanase isn't working for me > > DBI last_insert_id: invalid number of arguments: got handle + 3, expected > handle + between 4 and 5 > Usage: $h->last_insert_id($catalog, $schema, $table_name, $field_name [, > \%attr ]) at ./installer/data/mysql/updatedatabase.pl line 23326. I pushed a fix more than 1h ago: commit dcc1b96ea9cba850b1d5cfb84a171685b1b2a5ad Bug 22818: Fix the last_insert_id call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23807] Add Koha::Item->as_marc_field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23807 --- Comment #12 from Jonathan Druart --- I've opened bug 27007. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 --- Comment #60 from Jonathan Druart --- Created attachment 113586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113586&action=edit Bug 26963: Ignore existing libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27008] New: Broken SQL statement formed in Breeding.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 Bug ID: 27008 Summary: Broken SQL statement formed in Breeding.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org The C4/Breeding.pm code doesn't properly form SQL statements and gives error instead: > DBD::mysql::st execute failed: You have an error in your SQL syntax; check > the > manual that corresponds to your MariaDB server version for the right > syntax to > use near '' at line 5 [for Statement "SELECT import_record_id, > file_name, isbn, > title, author > FROM import_biblios > JOIN import_records USING (import_record_id) > JOIN import_batches USING (import_batch_id) > WHERE "] at /usr/share/koha/lib/C4/Breeding.pm line 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27009] New: Use 301 to redirect from tracklinks.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27009 Bug ID: 27009 Summary: Use 301 to redirect from tracklinks.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org In opac/tracklinks.pl we use a simple redirect to send the user on to the actual URL, after tracking: print $cgi->redirect($uri); This sends a "302 Moved Temporarily" to the browser as a default. One of our clients had some SEO work done on their websites, and one of the recommendations was to use "301 Moved Permanently" instead. This makes some sense, the URLs we redirect to do not change very often, I guess. According to https://metacpan.org/pod/CGI#Generating-a-redirection-header, the solution is to change the call to redirect() thusly: print $q->redirect( -uri=> $uri, -status => '301 Moved Permanently' ); Patch coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #199 from Andrew Isherwood --- Thanks for that fix Jonathan! I actually had 4 parameters when I tested the upgrade, then just prior to committing I removed the last one thinking its absence would infer undef, I didn't realise last_insert_id expected 4. Sorry, silly mistake! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27010] New: Warnings produced by Elasticsearch QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010
Bug ID: 27010
Summary: Warnings produced by Elasticsearch QueryBuilder.pm
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: joonas.kylm...@helsinki.fi
In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm we get following warnings:
> [WARN] Use of uninitialized value $f in hash element at
> /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605.
> [WARN] Use of uninitialized value $d in hash element at
> /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605.
This seems to be due to _convert_sort_fields() not checking whether my ( $f, $d
) get initialized by the regex before using them in the map function:
> 601 grep { $_->{field} } map {
> 602 my ( $f, $d ) = /(.+)_(.+)/;
> 603 {
> 604 field => $sort_field_convert{$f},
> 605 direction => $sort_order_convert{$d}
> 606 }
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27011] New: Warnings in returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Bug ID: 27011 Summary: Warnings in returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When you check-in some books you get the following warnings to error logs: > [WARN] Use of uninitialized value in concatenation (.) or string at > /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 164. > [WARN] Use of uninitialized value in concatenation (.) or string at > /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 402. This seems to be due to treating the patron fields as non-null values: > 164 my $name = $patron ? $patron->surname . ", " . $patron->title . " " > . $patron->firstname : ''; The DB schema allows NULL values (and I think that is okay) so we should check for every one of these whether the value is defined or not before using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007
Martin Renvoize changed:
What|Removed |Added
Attachment #113585|0 |1
is obsolete||
--- Comment #2 from Martin Renvoize ---
Created attachment 113587
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113587&action=edit
Bug 27007: Don't call GetMarcSubfieldStructure with unsafe in tests
It does not feel correct to call GetMarcSubfieldStructure with the unsafe flag
set in tests:
my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
Some tests are failing is run twice
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
[x~10]
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
# Failed test 'Value is mapped correctly for column biblionumber'
# at t/db_dependent/Koha/Item.t line 115.
# got: undef
# expected: '483'
[etc.]
Test plan:
Run the tests twice, without the patch it fails, with the patch it
passes
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- I dug into the code and agree with this change.. tests well.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
--- Comment #314 from Joonas Kylmälä ---
This patch set causes following error in error logs:
> Use of uninitialized value in concatenation (.) or string at
> /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 242.
> 242 $authorised_lib{$holding->{holding_id}} = $holding->{holding_id} . ' '
> . $holding->{holdingbranch} . ' ' . $holding->{location} . ' ' .
> $holding->{ccode} . ' ' . $holding->{callnumber};
Before using the values in string one should check whether the string is
defined.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27009] Use 301 to redirect from tracklinks.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27009 --- Comment #1 from Magnus Enger --- Created attachment 113588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113588&action=edit Bug 27009 - Use 301 to redirect from tracklinks.pl The default for the tracklinks.pl redirect is "302 Moved Temporarily". It makes more sense to use "301 Moved Permanently". To test: 1. Set TrackClicks = Track 2. Make sure you have a MARC record with an external link in 856$u 3. In the OPAC, click on the link and use e.g. Developer tools to check on the HTTP status code sent by tracklinks.pl. It will be 302. 4. Apply this patch and restart all the things 5. Click on the external link in the OPAC again. The status code should now be 301. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27009] Use 301 to redirect from tracklinks.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27009 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #2 from Timothy Alexis Vass --- Created attachment 113589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113589&action=edit Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions Currently Koha will delete a biblio record if there are existent serial subscriptions. This patch will prevent deleting the biblio until attached subscriptions are removed. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Sign off. Sponsored by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #19 from Jonathan Druart --- Created attachment 113590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113590&action=edit Bug 26988: No need to check if hold is linked to a patron Holds are deleted along with patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Séverine Queune changed: What|Removed |Added Attachment #113589|0 |1 is obsolete|| --- Comment #3 from Séverine Queune --- Created attachment 113591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113591&action=edit Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions Currently Koha will delete a biblio record if there are existent serial subscriptions. This patch will prevent deleting the biblio until attached subscriptions are removed. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 --- Comment #61 from Jonathan Druart --- (In reply to Nick Clemens from comment #59) > This should be considered a bug - not an enhancement. The current code can > crash a system with the number of DB requests generated and should be > backported to avoid issues on any large systems Ok, but we are working on 2 things at the same time, modifying the same code. So which one goes first? This one or bug 26988? We need a dependency between both, otherwise it does not work... https://snipboard.io/u4TGrK.jpg [2020/11/13 10:28:48] [ERROR] GET /api/v1/holds/8/pickup_locations: unhandled exception (Mojo::Exception)<> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] New: Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Bug ID: 27012 Summary: Merging records with holds causes SQL error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 12556 If one merges records A and B and A has holds in it then we get following error in /var/log/koha/kohadev/plack-intranet-error.log: > [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are > needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND > (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with > ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm > line 2002. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Blocks||27012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 [Bug 27012] Merging records with holds causes SQL error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 --- Comment #1 from Joonas Kylmälä --- Created attachment 113592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113592&action=edit Bug 27012: Fix incorrect SQL syntax in hold merging If you merge two records with holds in them following error happens without this patch: [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm line 2002. To test: 1) Create a hold in record A 2) Use cataloging search to search for something that brings up record A and another record B. 3) Select A and B records in the search results and click Edit -> Merge records 4) Merge the records and notice that the above error is printed to plack-intranet-error.log 5) Apply patch and repeat steps 1-4 but notice the error is gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate Assignee|koha-b...@lists.koha-commun |joonas.kylm...@helsinki.fi |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 --- Comment #2 from Jonathan Druart --- Can you provide a test please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 Joonas Kylmälä changed: What|Removed |Added Attachment #113592|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 113593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113593&action=edit Bug 27012: Add test for C4::Reserves::MergeHolds This does a basic check whether a hold gets moved to another biblio when MergeHolds() is called. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 --- Comment #4 from Joonas Kylmälä --- Created attachment 113594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113594&action=edit Bug 27012: Fix incorrect SQL syntax in hold merging If you merge two records with holds in them following error happens without this patch: [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm line 2002. To test: 1) Notice prove t/db_dependent/Reserves.t fails with above error 2) Apply patch 3) Notice prove t/db_dependent/Reserves.t passes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27013] New: Display an image of barcode on slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Bug ID: 27013 Summary: Display an image of barcode on slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: severine.que...@bulac.fr QA Contact: testo...@bugs.koha-community.org It could be great if, on printed slips, we could display an image of the barcode. Especially useful when a barcode is filled in Koha but not physically present on the book (lost, etc.) or just unreadable because of its condition. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #9 from Kyle M Hall --- (In reply to Victor Grousset/tuxayo from comment #8) > Hi, not enough experience with SIP so I have two questions > > > 5) Note the "too many overdue" flag is set > > > READ: 24 00120201112201630AEEdna > > Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL| > > Which one is it? I couldn't in the spec where is the patron status field. It is the 6th character of the patron status flags, the 8th character of the entire message. 24 00120201112201630AEEdna ^ This one. Y means patron has too many overdues, blank means they don't. > > > 6) Set the new SIP config option "disable_too_many_overdue" for the > > account you used for testing > > Where does one do that? Find your SIPconfig.xml, usually in /etc/koha/sites//SIPconfig.xml, then add as you can see here at the bottom of the page for the SIP account you want to use for testing: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109786&action=diff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27012] Merging records with holds causes SQL error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 --- Comment #5 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #2) > Can you provide a test please? I provided but I'm still against having those for old untested subroutines because those are mostly very long and hard to provide tests for due to having multiple functions combined in them and will have to go another round of changes when moving to Koha namespace. Also I think it as a separate matter that can be handled at another time and does not relate to the bug itself. This would allow the testers and QA team to work on smaller tasks therefore allowing higher chance of finding the time to review the code and pay more attention to every detail in the patch compared to long patch set with multiple goals (in this case: adding tests, fixing bug). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27014] New: SIP2 cannot find patrons at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014
Bug ID: 27014
Summary: SIP2 cannot find patrons at checkin
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
Caused by bug 23403 - when performing a checkin we lookup the SIP patron using
the borrowernumber, however, SIP only knows how to find a patron via cardnumber
or userid
The change on 23403 was to avoid using an 'id' that didn't always exist (as
some users don't have a userid or cardnumber
When checking in, however, we are not passed a user cardnumber or
borrowernumber, so we don't have those on hand to get the patron.
from C4/SIP/ILS.pm
245 } elsif ( $circ->ok ) {
246 $circ->patron( $patron = C4::SIP::ILS::Patron->new(
$item->{borrowernumber} ) );
247 delete $item->{borrowernumber};
248 delete $item->{due_date};
249 $patron->{items} = [ grep { $_ ne $item_id } @{ $patron->{items} }
];
250 } else {
I actually don't know if the $patron->{items} call is useful, it seems to be
updating the patron item cache, but I don't see where we cache it, or read it,
we just seem to create new patrons/transactions when needed
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27014] SIP2 cannot find patrons at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #11 from Martin Renvoize --- Created attachment 113596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113596&action=edit Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize changed: What|Removed |Added Attachment #109786|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 113595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113595&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25054] Display search field aliases in Search Engine Configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25054 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #6 from Séverine Queune --- I'm surprised by alias 'callnum' associate to 'local-classification' instead of 'Call-Number'. Is it really the link we're supposed to use ? Except that point, everything works fine ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- I never went back to this, sorry. The idea was that eventually the caller would fetch the mss data, accumulate it as needed, and pass the right one to the method as a parameter. The context is you will iterate on the biblio's items and it doesn't make sense to retrieve the whole thing. I promise I'll be back to this on this new cycle. I agree with the change BTW. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #52 from Magnus Enger --- Any chance this can be backported to 20.05 (and 19.11)? I thnk I am seing this problem on 19.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #39 from Kyle M Hall --- Created attachment 113597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113597&action=edit Bug 18267 Refactored Edifact Price Calculations Refactored the price calculations for Quotes and Invoices This takes in to account various combinations used by different vendors. Makes the extraction of basic price, quantity and tax information more reliable. Tests are in Edifact.t and EdiInvoice.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #12 from Kyle M Hall --- (In reply to Martin Renvoize from comment #11) > Created attachment 113596 [details] [review] > Bug 25761: (QA follow-up) Consistent flag names > > This follow-up updates the config flag to be consistent with bug 24449 > and updates the debian template file to match too. > > Signed-off-by: Martin Renvoize Thanks for the followup Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall changed: What|Removed |Added Attachment #113596|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 113598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113598&action=edit Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 Julian Maurice changed: What|Removed |Added Attachment #113582|0 |1 is obsolete|| --- Comment #4 from Julian Maurice --- Created attachment 113599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113599&action=edit Bug 26992: Fix serial issue and related items deletion on serial collection page serial-collection.pl uses C4::Items::DelItemCheck() function which is obsolete. Test plan: 1. Create a subscription with items created when receiving. 2. Receive several issues, and create corresponding items. 3. On Serial collection page (serial-collection.pl), select several issues. 4. Click on button Delete selected issues 5. A confirmation page is displayed. Enable "Delete associated items?". Then click on "Yes, delete" button. You get this error: Undefined subroutine &C4::Items::DelItemCheck 6. Apply the patch an repeat steps 3-5. Check that issues and related items are deleted. Signed-off-by: Blou Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 --- Comment #4 from Jonathan Druart --- Created attachment 113600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113600&action=edit Bug 26997: Remove -00-00 from aqorders.datecancellationprinted This patch remove the -00-00 from the WHERE condition from ordered.pl and spent.pl to prevent an error under MySQL 8 It also fixes the wrong values in DB (if possible, ie. under other DBMS that MySQL 8) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What|Removed |Added Blocks||23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support [Omnibus] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 --- Comment #5 from Jonathan Druart --- Halim, this patch should fix your problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart changed: What|Removed |Added Depends on||26997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What|Removed |Added Text to go in the||These patches alter the release notes||behaviour of ||'CanBookBerenewed' to ||return a status of ||'too_soon' before any other ||statuses if the book is not ||eligible for renewal yet. ||This is done to prevent ||sending messages to patrons ||about other changes in ||status when it is still too ||soon to renew the item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Attachment #113569|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 Nick Clemens changed: What|Removed |Added Text to go in the||Bug 19014 prioritized the release notes||'too soon' message for ||renewals to prevent sending ||too many notifications. ||When displaying information ||about the hold elsewhere it ||is desired to see the 'on ||hold' status even when the ||renewal is too soon. || ||This ||patch add a switch to the ||CanBookBeRenewed routine to ||decide which status has ||priority (i.e. whether we ||are checking from the ||renewal cron or elsewhere) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Nick Clemens changed: What|Removed |Added Depends on||26963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 [Bug 26963] Improve Koha::Item::pickup_locations performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 Nick Clemens changed: What|Removed |Added Blocks||26988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #20 from Nick Clemens --- Created attachment 113601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113601&action=edit Bug 26988: Adjust for bug 26963 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- Can we have this for 20.11 please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 --- Comment #62 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 --- Comment #21 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26963] Improve Koha::Item::pickup_locations performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26963 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize changed: What|Removed |Added Text to go in the||This bugfix allows the release notes||circulation rules that ||prevent checkouts if a user ||has reached a maximum ||number of overdue to be ||overridden at the SIP login ||level. || ||This is especially ||useful for ebook lending ||services where you may want ||this block to be disabled. || ||***New SIP config ||option***: ||`overdues_block_checkout` ||defaults to `1` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27014] SIP2 cannot find patrons at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 --- Comment #1 from Kyle M Hall --- Created attachment 113602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113602&action=edit Bug 27014: Enable C4::SIP::ILS::Patron::new to accept a hash Caused by bug 23403 - when performing a checkin we lookup the SIP patron using the borrowernumber, however, SIP only knows how to find a patron via cardnumber or userid The change on 23403 was to avoid using an 'id' that didn't always exist (as some users don't have a userid or cardnumber When checking in, however, we are not passed a user cardnumber or borrowernumber, so we don't have those on hand to get the patron. Test Plan: 1) Check in an item via SIP, note patron is not found 2) Apply this patch 3) Restart all the things! 4) Check in an item via SIP, patron should be found! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27014] SIP2 cannot find patrons at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27014] SIP2 cannot find patrons at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25761] Implementation of too_many_overdue has unintended consequences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26972] Test suite does not pass with Elasticsearch for Item.t test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26972 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Jonathan Druart changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #5 from Jonathan Druart --- *** Bug 26972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26972] Test suite does not pass with Elasticsearch for Item.t test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26972 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27015] New: Add filtering options to the pickup_locations routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015 Bug ID: 27015 Summary: Add filtering options to the pickup_locations routes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com Based on bug 27002 and bug 26988, the route could be added filters as the routes will rely on resultsets, leveraging on our existing framework. This paves the way to using things like Select2 in a fancier way for the dropdown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27016] New: Make the pickup locations dropdowns use Select2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Bug ID: 27016 Summary: Make the pickup locations dropdowns use Select2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com On top of bug 26988, we can nicely use Select2 on those dropdowns. This would be beneficial on sites with many branches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 [Bug 27016] Make the pickup locations dropdowns use Select2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Tomás Cohen Arazi changed: What|Removed |Added Depends on||26988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27017] New: Add log trace to EDI Invoice handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27017 Bug ID: 27017 Summary: Add log trace to EDI Invoice handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org It is useful to log to the trace log the bib numbers affected by Invoice processing. It makes it much easier to establish what processing has occured if any question has been raised -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26561] Number on claims tab not showing when translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26561 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|RESOLVED Keywords|rel_20_11_target| Resolution|--- |INVALID --- Comment #2 from Jonathan Druart --- Looks ok for me using es-ES: https://snipboard.io/3P9Ko4.jpg /cgi-bin/koha/members/moremember.pl?borrowernumber=5 Can you provide more detail please, or confirm it's fixed now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #1 from Nick Clemens --- Created attachment 113603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113603&action=edit Bug 26947: Add scheam-only option to koha-dump This patch adds a new --schema-only optoin to the koha-dump script. This can be used to generate a new kohastructure.sql file during the release, and later to compare the DB structure of a koha instance to the kohastructure.sql file shipped with a version to identify any missing constraints or other db structure issues To test: 1 - debian/scripts/koha-dump kohadev 2 - Confirm db and configs are dumped correctly 3 - Apply patch 4 - debian/scripts/koha-dump --help 5 - Confirm new option is listed and makes sense 6 - debian/scripts/koha-dump --schema-only kohadev 7 - Confirm only schema is dumped and is not zipped 8 - debian/scripts/koha-dump kohadev 9 - Confirm entire db is dumped as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27017] Add log trace to EDI Invoice handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27017 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 113604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113604&action=edit Patch adding log entries Patch adds two log entries one if no order match one to record bib if processing ok. If no match code jumps to next line to avoid possible runtime errors further down. Recording this info in the the edi log has proved very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Jonathan Druart changed: What|Removed |Added Severity|normal |major --- Comment #4 from Jonathan Druart --- Kyle, this is blocker for the release. Can you have another try please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26429] If a waiting hold has expired the expiration date on the holds page shows for tomorrow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00, 20.05.06 released in|| --- Comment #9 from Lucas Gass --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26389] OPAC renewal failure due to automatic renewal does not have a failure message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26389 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.06 released in|| --- Comment #7 from Lucas Gass --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #43 from Jonathan Druart --- root@kohadevbox:koha(BZ17809|BISECTING)$ koha-mysql kohadev < installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql ERROR 1062 (23000) at line 613: Duplicate entry 'qualif-370' for key 'authorised_values.av_uniq' Still not working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23141] The Debian scripts do not use the MySQL port number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105896|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 113606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113606&action=edit Bug 23141: Add support for configuring database port in koha-dump, koha-mysql and koha-mysqlcheck -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23141] The Debian scripts do not use the MySQL port number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105895|0 |1 is obsolete|| --- Comment #25 from Victor Grousset/tuxayo --- Created attachment 113605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113605&action=edit Bug 23141: Add port number to koha-dump script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
