[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #91 from Josef Moravec  ---
(In reply to Josef Moravec from comment #90)
> This does not work correctly - in fact the behaviour is same as before patch
> (only slower)
> 
> When we get all holds at once, it will be the same as before... we need to
> do one of this things:
> 
> - get hold by biblionumber in each loop - revert last patch - bad performance
> - add 'priority' => 1, to where clause - best performance, but can we 
> - add subquery and get only the holds with priority = min(priority) for
> given biblionumber - probably the optimal solution?

Sorry, commited comment too early ;)

ad second point:
- add 'priority' => 1, to where clause - best performance, but can we assume
the lowest priority is always 1?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #90 from Josef Moravec  ---
This does not work correctly - in fact the behaviour is same as before patch
(only slower)

When we get all holds at once, it will be the same as before... we need to do
one of this things:

- get hold by biblionumber in each loop - revert last patch - bad performance
- add 'priority' => 1, to where clause - best performance, but can we 
- add subquery and get only the holds with priority = min(priority) for given
biblionumber - probably the optimal solution?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

--- Comment #6 from David Cook  ---
I'm bumping into this with "/usr/share/koha/bin/cronjobs/membership_expiry.pl"
where 1 library wants to send notices to only some categories.

In the past, we added a --category option, but that only worked when we set up
cronjobs per-library instead of using koha-foreach. 

I think that I'm just going to use a local system preference here and a local
code customization, but it would be useful for libraries to be able to define
their own parameters via the web UI for this cronjob...

Really this is a "scheduled task" issue. Not just "cronjobs". In the future, we
may have other schedulers in addition to the cron daemon. So whatever solution
we come up with... it should be fairly extensible. 

Scheduled Task:
Name: MembershipExpiry
Args:
  Categories: ['Staff','Students','Administrators']
  Branches: ['CPL','MPL','QPL']
  Letter: 

A cronjob could fetch using my $task =
ScheduledTask->GetByName('MembershipExpiry');

You could even arguably add "Min time interval" (maybe the cronjob runs every
15 minutes but you only want the job to run no faster than 1 time per hour) and
"Last run" to try to control timing a bit... 

Anyway, just some thoughts

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #23 from Mason James  ---
(In reply to Jonathan Druart from comment #19)
> Created attachment 113793 [details] [review]
> Bug 26031: Remove www/search_utf8.t
> 
> Those tests are not reliable and fail randomly and we did not find the
> root of the problem.
> I am in favour of removing them, at least for now.

hi Jonathan, can you push my last patch to test on jenkins please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Mason James  changed:

   What|Removed |Added

 Attachment #113793|0   |1
is obsolete||

--- Comment #22 from Mason James  ---
Created attachment 113796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113796&action=edit
Bug 26031: add sleep(1) to fix  www/search_utf8.t failing randomly

to test...
 1/ apply patch
 2/ run test
 3/ observe PASS

root@kohadevbox:/kohadevbox/koha# export
KOHA_INTRANET_URL="http://kohadev-intra.myDNSname.org:8081";
root@kohadevbox:/kohadevbox/koha# export
KOHA_OPAC_URL="http://kohadev.myDNSname.org:8080";
root@kohadevbox:/kohadevbox/koha# prove -v  ./t/db_dependent/www/search_utf8.t
1..99
ok 1 - connect to intranet
ok 2 - login to staff interface
ok 3 - load main page
ok 4 - open tools module
ok 5 - go to stage MARC
ok 6 - uploaded file
ok 7 - upload succeeded
ok 8 - reopen stage MARC page
ok 9 - stage MARC
ok 10 - have job ID
ok 11 - job was completed
ok 12 - reopen stage MARC page at end of upload
ok 13 - stage MARC
ok 14 - view batch
ok 15 - imported records into catalog
ok 16 - got search on intranet
ok 17 - test staff  'kw' search
ok 18 - got search on intranet2
ok 19 - test staff 'kw' search 2
ok 20 - Base is like
"(?^u:search.pl\?advsearch=1&idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"
ok 21 - UTF-8 are multi-byte. Good
ok 22 - UTF-8 chars are correctly present. Good
ok 23 - got opac
ok 24 - test opac default search
ok 25 - got opac2
ok 26 - test opac default search 2
ok 27 - Base is like
"(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"
ok 28 - Base does not contain an idx
ok 29 - UTF-8 are multi-byte. Good
ok 30 - UTF-8 chars are correctly present. Good
ok 31 - view and clean batch
ok 32 - biblio on intranet
ok 33 - biblio deleted
ok 34 - connect to intranet
ok 35 - login to staff interface
ok 36 - load main page
ok 37 - open tools module
ok 38 - go to stage MARC
ok 39 - uploaded file
ok 40 - upload succeeded
ok 41 - reopen stage MARC page
ok 42 - stage MARC
ok 43 - have job ID
ok 44 - job was completed
ok 45 - reopen stage MARC page at end of upload
ok 46 - stage MARC
ok 47 - view batch
ok 48 - imported records into catalog
ok 49 - got search on intranet
ok 50 - test staff  'kw' search
ok 51 - got search on intranet2
ok 52 - test staff 'kw' search 2
ok 53 - Base is like "(?^u:search.pl\?advsearch=1&idx=kw&q=Ram%C3%B2n)"
ok 54 - UTF-8 are multi-byte. Good
ok 55 - UTF-8 chars are correctly present. Good
ok 56 - got opac
ok 57 - test opac default search
ok 58 - got opac2
ok 59 - test opac default search 2
ok 60 - Base is like "(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)"
ok 61 - Base does not contain an idx
ok 62 - UTF-8 are multi-byte. Good
ok 63 - UTF-8 chars are correctly present. Good
ok 64 - view and clean batch
ok 65 - biblio on intranet
ok 66 - biblio deleted
ok 67 - connect to intranet
ok 68 - login to staff interface
ok 69 - load main page
ok 70 - open tools module
ok 71 - go to stage MARC
ok 72 - uploaded file
ok 73 - upload succeeded
ok 74 - reopen stage MARC page
ok 75 - stage MARC
ok 76 - have job ID
ok 77 - job was completed
ok 78 - reopen stage MARC page at end of upload
ok 79 - stage MARC
ok 80 - view batch
ok 81 - imported records into catalog
ok 82 - got search on intranet
ok 83 - test staff  'kw' search
ok 84 - got search on intranet2
ok 85 - test staff 'kw' search 2
ok 86 - Base is like
"(?^u:search.pl\?advsearch=1&idx=kw&q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"
ok 87 - UTF-8 are multi-byte. Good
ok 88 - UTF-8 chars are correctly present. Good
ok 89 - got opac
ok 90 - test opac default search
ok 91 - got opac2
ok 92 - test opac default search 2
ok 93 - Base is like
"(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"
ok 94 - Base does not contain an idx
ok 95 - UTF-8 are multi-byte. Good
ok 96 - UTF-8 chars are correctly present. Good
ok 97 - view and clean batch
ok 98 - biblio on intranet
ok 99 - biblio deleted
ok
All tests successful.
Files=1, Tests=99, 153 wallclock secs ( 0.05 usr  0.01 sys +  2.92 cusr  1.06
csys =  4.04 CPU)
Result: PASS

real2m32.825s
user0m3.048s
sys 0m1.096s

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033

--- Comment #9 from David Cook  ---
(In reply to Fridolin Somers from comment #7)
> Indeed the terminology could be better.
> 
> I prefer "home_nav_link".
> The goal is to navigate to somewhere, module or more specific page.
> We already have OPACNav preferences.
> 
> So hook named : "intranet_home_nav_link".
> And maybe rename the class "biglinks-list".
> 
> Other votes ?

Sounds good to me. Curious to hear what others think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

--- Comment #20 from David Cook  ---
(In reply to Jonathan Druart from comment #19)
> Either we have it pushed for 20.11 without the new log file, or we wait for
> 21.05. I let you decide what's best for you.

I reckon let's push for 20.11 without the new log file.

Do you want a new patch or are you going to modify it yourself?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #14 from David Cook  ---
(In reply to Mark Hofstetter from comment #12)
>  maybe close this bug

Actually, I think that I'll keep this bug open, as I think that it's a valid
request.

I just made my earlier comments as they provided a way of getting something
working sooner rather than later.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #13 from David Cook  ---
(In reply to Mark Hofstetter from comment #12)
> thanks for the help, maybe close this bug

Can do.

>, but a little more "plugability"
> would be great. I really do like the wordpress hook system - just pondering

I'm not very familiar with the Wordpress hook system, but I think that's what
originally inspired Kyle Hall to add Koha's plugin system. 

Feel free to suggest improvements to how Koha works. Even if you don't work on
something, it might inspire someone else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #46 from David Cook  ---
(In reply to Jonathan Druart from comment #44)

Thanks for clarifying, Jonathan! Makes sense.

(In reply to Nick Clemens from comment #45)
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Hmm bizarre...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630

--- Comment #2 from Lucas Gass  ---
Created attachment 113795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113795&action=edit
Bug 26630: Add OpacSuggestionInstructions options to News

Test plan:
1. Apply patch
2. Go to /cgi-bin/koha/tools/koha-news.pl and create 'New entry' with a dsiplay
location of OpacSuggestionInstructions
3. Login to the OPAC and go to the purchase suggestion page
(/cgi-bin/koha/opac-suggestions.pl)
4. Your new content should be there.
5. Delete the OpacSuggestionInstructions news entry.
6. Re-load the OPAC purchase suggestion page and the original text will be
restored.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26891] Manual: Incorrect image on 'Make payment' documentation

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26891

Lucy Vaux-Harvey  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||lucy.vaux-harvey@ptfs-europ
   ||e.com
 Status|NEW |RESOLVED

--- Comment #1 from Lucy Vaux-Harvey  ---
Fixed now in the 20.11 manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22157] HideLostItems items still show in OPAC when patron places a hold on a specific item

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22157

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27042] Issue in postfix send mail

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27042

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Katrin Fischer  ---
Please use the mailing lists or IRC chat for support questions (this is why I
had closed the report). You can change your cronjob setting, but I would not
recomment in this case for the reason given - you will end up sending a lot of
emails to the patrons unintentionally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

--- Comment #3 from Katrin Fischer  ---
We deliberately left the email off because email configuration can differ. I'd
have to remove this from every of our 130 installations because for us the
reply to contains the email to the library due to spam restrictions with the
mail servers.

Also: no spam protection if you put the email on the page directly.

Could we imagine making this one a multi-select pref maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438

--- Comment #6 from Doug Dearden  ---
(In reply to Doug Dearden from comment #5)
> I got the same error messages during an update from 19.05.10 to 19.05.16

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438

Doug Dearden  changed:

   What|Removed |Added

 CC||dear...@sarsf.org

--- Comment #5 from Doug Dearden  ---
I got the same error messages during an update from 19.05.10 to 19.15.16

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry  ---
This is sort of at odds with bug 24767, in which we hid the claims tab if the
value is not set.

Katrin, your test plan sort of sneaks up on Claims, by using the Columns button
to show the Return Claims column that would otherwise be hidden. Is the answer
here to just not allow one to reveal the claims column at all when
ClaimReturnedLostValue is not set?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #12 from Mark Hofstetter  ---
ok everything works now without touching koha-core, plz see

https://github.com/HKS3/koha-plugin-subordinate-items/

thanks for the help, maybe close this bug, but a little more "plugability"
would be great. I really do like the wordpress hook system - just pondering

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #89 from Michal Denar  ---
Hi,
I get this errors on Hold to pull page
https://lh3.googleusercontent.com/-Ka99Dm0l93w/X7VZsqPoAoI/HvM/btn2wdfWqWYKe7zgA6xu62B5DAd0c_PIgCK8BGAsYHg/s0/2020-11-18.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27029] Detail page missing Javascript accessible biblionumber value

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27029

--- Comment #11 from Mark Hofstetter  ---
until the patch is in core you may use

// "if" statment may/has to be removed when 
// https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27029
// is in koha
var biblionumber = $("div#catalogue_detail_biblio").data("biblionumber");
if (!biblionumber) {
var x = document.getElementsByClassName("unapi-id")[0]
.getAttribute("title");
biblionumber = x.split(':')[2];
}

see https://github.com/HKS3/koha-plugin-subordinate-items/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27054] Round fines at charging

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27054

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27054] Round fines at charging

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27054

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27054] New: Round fines at charging

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27054

Bug ID: 27054
   Summary: Round fines at charging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We currently have the option to round fines at payment. However, there are
still places where Koha can charge partial cent fines. We should give the
option to round fines at charging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27046] Add ability to customize purchase suggestion form text

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27046

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Lisette Scheer  ---


*** This bug has been marked as a duplicate of bug 26630 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630

Lisette Scheer  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #1 from Lisette Scheer  ---
*** Bug 27046 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958

Daniel Gaghan  changed:

   What|Removed |Added

 CC||daniel.gaghan@pueblolibrary
   ||.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #11 from Martin Renvoize  ---
Not entirely sure I like this approach.. it's very MySQL centric.. even MariaDB
complains about some of the statements :(.. we can probably safely drop those,
but I wasn't 100% sure what they did or why they appear in the dumpfile in the
first place.

The alternative is to fallback to using the system MySQL cli from the perl
script.. but I don't really like that idea much either... so perhaps just
falling back to disabling foreign key checks is the right thing to do here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #10 from Martin Renvoize  ---
Created attachment 113794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113794&action=edit
Bug 26947: (follow-up) Set key checks to disabled for kohastructure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #21 from Jonathan Druart  
---
search_utf8.t is not using Selenium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #9 from Jonathan Druart  
---
I didn't find a way to export the schema in an order different than alpha. I
may have missed something somewhere... but I read the mysqldump man page (as
well as mydumper) and didn't find anything. I guess it's not possible as you
could have two tables having each one relation to the other.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27053] New: Serial search results from Mana should give the option to use found patterns in new/existing subscriptions

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27053

Bug ID: 27053
   Summary: Serial search results from Mana should give the option
to use found patterns in new/existing subscriptions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When one finds subscription patterns in Mana via serials-search.pl, there's no
path from the results page to actually using that pattern in a new or existing
subscription. We should add an Action button here that gives the option to
start a new subscription or apply the found pattern to an existing
subscription.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #20 from Tomás Cohen Arazi  ---
Selenium needs to be replaced altogether as the Perl libraries really don't
support newer browsers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #108798|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

Summary|www/search_utf8.t is|www/search_utf8.t is
   |failing randomly|failing randomly and must
   ||be removed/replaced

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #19 from Jonathan Druart  
---
Created attachment 113793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113793&action=edit
Bug 26031: Remove www/search_utf8.t

Those tests are not reliable and fail randomly and we did not find the
root of the problem.
I am in favour of removing them, at least for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize  ---
Something along the line 'sed -r --in-place 's/,\s*-- (.*)$/ COMMENT "\1",/g;'
installer/data/mysql/kohastructure.sql' should be used before the first run of
this to capture our existing `, -- this is a comment` type comments and convert
them to `COMMENT 'this is a comment',` so we keep the data and it also gets
added to DBIC schemas as per the research undertaken by Victor:
https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo/Coding_Guidelines-SQL11-changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #7 from Jonathan Druart  
---
My guess is that the following instruction line, from kohastructure.sql, is not
read by DBIx::RunSQL

  14 /*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS,
FOREIGN_KEY_CHECKS=0 */;

we load the schema from C4::Installer
282 my $error = $self->load_sql("$datadir/kohastructure.sql")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5198] HOLDPLACED being logged in patron messages

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5198

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

--- Comment #5 from Holly  ---
Hi,
Just want to express interest in getting this issue resolved. I can confirm
that this is still happening on the 19.11.07 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #6 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #5)
> C4::Installer::load_sql returned the following errors while attempting to
> load /kohadevbox/koha/installer/data/mysql/kohastructure.sql:
> DBD::mysql::st execute failed: Failed to open the referenced table
> 'branches' at /usr/share/perl5/DBIx/RunSQL.pm line 273.
> Something went wrong loading file
> /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
> TABLE `account_credit_types_branches` (
> 
> Did it work for you?

Actually, the following works:

> DROP DATABASE koha_kohadev
> CREATE DATABASE koha_kohadev
koha-mysql kohadev < installer/data/mysql/kohastructure.sql

But reset_all does not, neither the installer (it says "Database tables
created", but it's wrong...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016

--- Comment #9 from Nick Clemens  ---
Created attachment 113792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113792&action=edit
Bug 27016: (QA follow-up) Move allowClear out of ajax

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113760|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 113791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113791&action=edit
Bug 27016: Make the pickup locations dropdowns use Select2

On the shoulders of bug 27015, this patch makes the pickup locations
dropdowns use Select2 to handle both fetching the pickup location
on-deman through the API, and also searching for them.

This provides a better user experience for really big lists.

To test:
1. Have some holds on a biblio
=> SUCCESS: Bug 26988 works, made it load the data when you click on the
dropdowns.
2. Apply this patch
3. Reload the page
=> SUCCESS: Similar-ish behaviour
=> SUCCESS: Notice you can search for branch names and make the list
shrink
4. Sign off :-D

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27015] Add filtering options to the pickup_locations routes

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015

--- Comment #8 from Nick Clemens  ---
Created attachment 113790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113790&action=edit
Bug 27015: Make pickup locations searchable

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27015] Add filtering options to the pickup_locations routes

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015

Nick Clemens  changed:

   What|Removed |Added

 Attachment #113761|0   |1
is obsolete||
 Attachment #113762|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 113789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113789&action=edit
Bug 27015: Unit tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27015] Add filtering options to the pickup_locations routes

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27052] New: OPACReportProblems

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27052

Bug ID: 27052
   Summary: OPACReportProblems
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Should give admin the ability to define who gets the e-mail/what e-mails to
use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26926] Update all occurrences of to apply ACC2 coding guideline

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410

--- Comment #4 from Jonathan Druart  
---
Asked for deprecation on the list - 
https://lists.katipo.co.nz/pipermail/koha/2020-November/055362.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

--- Comment #2 from Lucas Gass  ---
Created attachment 113788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113788&action=edit
Bug 27051: Add email to OPAC library page

Test plan:
1. Add some branch emails via /cgi-bin/koha/admin/branches.pl
2. Go to the OPAC and opac-library.pl, notice there emails are not listed
3. Apply patch
4. Reloda opac-library.pl and you should see the branch email addresses.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

Lucas Gass  changed:

   What|Removed |Added

 Attachment #113787|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

--- Comment #1 from Lucas Gass  ---
Created attachment 113787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113787&action=edit
Bug 26986: Prevent Selenium's StaleElementReferenceException

Test plan:
1. Add some branch emails via /cgi-bin/koha/admin/branches.pl
2. Go to the OPAC and opac-library.pl, notice there emails are not listed
3. Apply patch
4. Reloda opac-library.pl and you should see the branch email addresses.

This is a follow-up bug for bug 26162

By finding the element before the click I hope to get the good element,
even if the page changed in the meanwhile.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

--- Comment #14 from Jonathan Druart  
---
(In reply to David Cook from comment #12)
> In your example, it's interesting that JSON::Validator::OpenAPI::Mojolicious
> is at /usr/local/share/perl/5.30.3/JSON/Validator/OpenAPI/Mojolicious.pm
> instead of /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm. Did you
> install it using CPAN instead of DEB package?

Yes, I was certainly trying something and installed it from CPAN.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) break our REST API routes

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m...@kohaaloha.com
   |ity.org |
 Status|NEW |ASSIGNED
   Keywords||rel_20_11_target

--- Comment #13 from Jonathan Druart  
---
Good catch David!

So, on a fresh D11:

% cpanm
https://cpan.metacpan.org/authors/id/J/JH/JHTHORSEN/JSON-Validator-3.25.tar.gz

And that's it, it works!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27051] New: opac-library.tt should include email

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27051

Bug ID: 27051
   Summary: opac-library.tt should include email
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

opac-library.tt omits the branch email address. This information would be nice
to show on the page as a 'mailto:' link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code.

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939

--- Comment #5 from Jonathan Druart  
---
Created attachment 113786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113786&action=edit
Bug 26939: Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to David Nind from comment #6)
> I think it is a great improvement.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

--- Comment #2 from Martin Renvoize  ---
This script has been kept deliberately simple for now to allow easy backport..
I would like to further enhance it to allow the use of different credit types
(CANCEL vs WRITEOFF) and perhaps allow partial writeoffs and discounts in the
future... but I intend to do that work as followups on new bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Martin Renvoize  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om,
   ||ian.b...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

--- Comment #1 from Martin Renvoize  ---
Created attachment 113785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113785&action=edit
Bug 27049: Add bulkwaiveaccounts.pl

This patch adds a new misc/bulkwaiveaccounts.pl script to allow the bulk
waiver of debts from the system. The script is passed a file of line
delimited accountline_ids and will apply a WRITEOFF account against them
for the amount of the debt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

--- Comment #29 from Nick Clemens  ---
Created attachment 113784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113784&action=edit
Bug 23475: (follow-up) Fix selectors and stray use statements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #113782|0   |1
is obsolete||

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 113783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113783&action=edit
Bug 25942: Fix batch report operations for cardnumbers and biblionumbers

This patch moves the processing for these to a block and adds a comment
in place of whitespace and uses template directives to chomp newlines to
improve readability

To test:
 1 - Create a report like:
SELECT biblionumber FROM biblios
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
(You will need to define a marc modification template)
 4 - The operations don't find the biblios
 5 - Create a report like:
SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

--- Comment #4 from Nick Clemens  ---
Created attachment 113782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113782&action=edit
Bug 25942: Fix batch report operations for cardnumbers and biblionumbers

This patch moves the processing for these to a block and adds a comment
in place of whitespace and uses template directives to chomp newlines to
improve readability

To test:
 1 - Create a report like:
SELECT biblionumber FROM biblios
 2 - Run it
 3 - Try the various options from the 'Batch operations' button
(You will need to define a marc modification template)
 4 - The operations don't find the biblios
 5 - Create a report like:
SELECT cardnumber FROM borrowers
 6 - Run it
 7 - Test the batch operations
 8 - They fail
 9 - Apply patch
10 - Run each report again and test batch operations
11 - They work!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #45 from Nick Clemens  ---
Created attachment 113781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113781&action=edit
Bug 7607: (follow-up) Address OPAC and limits

This patch adds the same function to the OPAC and adds support for limits

I adjust the class on staff side to match the one already existing on OPAC

On the OPAC when you click the back button the fields are not enabled - on the
staff side they are,
I leave this problem for someone else to solve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #60 from Arthur Suzuki  ---
almost there, still a few tests failing in t/db_dependant/Circulation.t
Expect a followup patch tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050

Timothy Alexis Vass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |timothy_alexis.v...@ub.lu.s
   |ity.org |e
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27050] New: Allow multiple category_codes in delete_patrons.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050

Bug ID: 27050
   Summary: Allow multiple category_codes in delete_patrons.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: timothy_alexis.v...@ub.lu.se
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

overdue_notices.pl allows a list with branch codes.
Allow similiar functionality for category codes in delete_patrons.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033

--- Comment #8 from Fridolin Somers  ---
(In reply to David Nind from comment #5)
> LOL! 8-) Love the plugin: Have a break, sign you out of Koha!!
> 
> Owen might want to have a look at how to make the columns more responsive.
> For example, when narrowing the size of you screen so that the options flow
> nicely into one column if the screen width gets too narrow.

Those links more responsive would be great.
But no idea how to do it 😊

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033

Fridolin Somers  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #7 from Fridolin Somers  ---
Indeed the terminology could be better.

I prefer "home_nav_link".
The goal is to navigate to somewhere, module or more specific page.
We already have OPACNav preferences.

So hook named : "intranet_home_nav_link".
And maybe rename the class "biglinks-list".

Other votes ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27049] New: It would be helpful to have a bulk waive of debts tool

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049

Bug ID: 27049
   Summary: It would be helpful to have a bulk waive of debts tool
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

With extended periods of libraries being closed and the recent complexities
introduced into the accounts system for properly tracking accountline
writeoffs, it would be helpful to have a command line too allowing
administrators to writeoff accounts in bulk using the proper routines within
Koha to properly record the action.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #3 from Kelly McElligott  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26993] Allow StoreLastBorrower to retain up to 2 previous patrons

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993

--- Comment #2 from Marcel de Rooy  ---
If we are extending from 1 to 2, why not extend to a defined limit or for a
defined period of time? Makes it a bit more flexible?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048

Martin Renvoize  changed:

   What|Removed |Added

 CC||ian.b...@ptfs-europe.com,
   ||jon.tur...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113773|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize  ---
Created attachment 113780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113780&action=edit
Bug 27048: Add basic timekeeping to rebuild_zebra

This patch adds a start time, end time and elapsed times on the 'records
exported' lines to the verbose output of the rebuild_zebra.pl script.

Test plan
1/ Run rebuild_zebra.pl -a -b -v
2/ Note the new timestamps included on the verbose output
3/ Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26973] extendedPatronAttributes not showing during selfregistration

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26973

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #14 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.05.x so bug shouldn't affect it. No backporting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26940] debarred comment in borrowers table is lost on patron modifications in memberentry.pl page

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26940

--- Comment #17 from Jonathan Druart  
---
Created attachment 113779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113779&action=edit
Bug 26940: Take empty strings into account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26910] When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun
   |ommunity.org|ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26778] Software Error

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26778

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
  Group|Koha security   |
Product|Koha security   |Koha
 Status|NEW |RESOLVED
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
  Component|Koha|Architecture, internals,
   ||and plumbing
 QA Contact||testo...@bugs.koha-communit
   ||y.org

--- Comment #2 from Jonathan Druart  
---
Please ask the list if you need support with an upgrade or installation issue.

You will need to provide us more information, version of Koha, version of the
OS, how did you install, etc.

https://lists.katipo.co.nz/mailman/listinfo/koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

--- Comment #52 from Jonathan Druart  
---
(In reply to Arthur Suzuki from comment #48)
> Implementation here is the same as in BZ 17247 which is refered to by
> 24841...
> I've rebased the patch on current master, hopping it may pass.
> If not, can you be more precise on the changes needed for this bz to pass?

I've tried to explain on bug 24841 comment 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >