[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #61 from Arthur Suzuki  ---
Created attachment 113797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113797&action=edit
Bug 8137: (follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #24 from Jonathan Druart  
---
Can you explain your patch, Mason? Adding sleep everywhere in this script won't
make the tests pass IMO.
The calls are synchronous, sleep(1) won't change anything. And even if it
would, it's (almost) always a bad idea as 1s won't be enough in all cases (slow
servers?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #15 from Mark Hofstetter  ---
just slept over it, and maybe I'm getting an idea about what feels wrong.

The system is very explicit now, meaning you need a lot of code in specific
places to use a plugin excactly "there"

I think a plugin system needs to be more implicit eg all cgi scripts should use
the same plugin hook(s) (with the name of the script as a config parameter
whether the plugin should actually run)

eg: plugin parameter rewrite 
add a parameter to all queries, or whenever a ISBN appears do a transformation

+ maybe could be doable by simply subclassing CGI 

+ or better an more generalised, derive all cgi scripts from a common base
class, wrap the code in a sub run {} and everthing becomes possible, this may
sound huge but should be in fact only a few lines per script

as I've said just thinking loud(ly)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
   Assignee|alei...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #113778|0   |1
is obsolete||

--- Comment #92 from Jonathan Druart  
---
Created attachment 113798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113798&action=edit
Bug 24488: perf - Move holds search out of the loop

This will need attention from QA.
We are assuming that the hold with the highest priority has priority=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #93 from Jonathan Druart  
---
Sorry, the last patch was silly indeed. I hadn't turned on the strict mode.

Your suggestion, Josef, of assuming that the highest priority hold has
priority=1 is great actually. I think we never wanted to assume that (in case
the data is corrupted?) in this script, but we should go for it IMO, that
simplifies the code, the queries, and it makes sense to me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #62 from Jonathan Druart  
---
(In reply to Arthur Suzuki from comment #61)
> Created attachment 113797 [details] [review]
> Bug 8137: (follow-up)

"(follow-up)" is not a valid commit message. Please have a look at the wiki
page - https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #47 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Looks of for me on Firefox (68.12.0esr) and Chromium (Version 83.0.4103.116)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #94 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #93)
> Sorry, the last patch was silly indeed. I hadn't turned on the strict mode.
> 
> Your suggestion, Josef, of assuming that the highest priority hold has
> priority=1 is great actually. I think we never wanted to assume that (in
> case the data is corrupted?) in this script, but we should go for it IMO,
> that simplifies the code, the queries, and it makes sense to me!

I believe in the past we had issues with the priorities not being correct, but
believe it was fixed (hopefully). Nick or Kyle might be able to tell.

Wondering what happens with the local holds priority settings - do they change
the priority in the db or do they check highest priority for local?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

--- Comment #48 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #45)
> Created attachment 113781 [details] [review] [review]
> On the OPAC when you click the back button the fields are not enabled - on
> the staff side they are,
> I leave this problem for someone else to solve

Looks ok for me on Firefox (68.12.0esr) and Chromium (Version 83.0.4103.116)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438

--- Comment #7 from Jonathan Druart  
---
(In reply to Doug Dearden from comment #6)
> (In reply to Doug Dearden from comment #5)
> > I got the same error messages during an update from 19.05.10 to 19.05.16

Which errors?
Can you post the upgrade logs?

I don't see anything related to ISBN between 19.05.10 and 19.05.16

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #12 from Jonathan Druart  
---
Should not we only need to turn off FOREIGN_KEY_CHECKS?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #13 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #12)
> Should not we only need to turn off FOREIGN_KEY_CHECKS?

I think you're probably right, I wasn't really sure why mysqldump turns so much
else off.. I aim to try and understand that today and will quickly followup
with details if I find any and likely re-submit that final patch with just the
disablement of keys rather than all the other oddities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #14 from Jonathan Druart  
---
Created attachment 113799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113799&action=edit
Bug 26947: Move -- comment to the COMMENT clause

Sed command from bug 26947 comment 8
sed -r --in-place 's/,\s*-- (.*)$/ COMMENT "\1",/g;'
installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #15 from Jonathan Druart  
---
Created attachment 113800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113800&action=edit
Bug 26947: Replace double quotes from comments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #16 from Jonathan Druart  
---
Martin, I wanted to try your sed command, it works pretty well!
I only had to adjust manually 3 occurrences. Attaching the patches here but
feel free to drop them if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954

--- Comment #2 from Jonathan Druart  
---
Created attachment 113801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113801&action=edit
Bug 26954: Remove log of STDERR

See discussion on comments 12-20

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|RM_priority |rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |major

--- Comment #15 from Jonathan Druart  
---
We really need this part of 20.11 IMO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the|RM NOTE: REMOVE FROM|RMNOTE: REMOVE FROM RELEASE
  release notes|RELEASE NOTE|NOTE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25828] Update cpanfile for 20.05 release cycle

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25828

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the||RMNOTE: This has been
  release notes||reverted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113603|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 113802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113802&action=edit
Bug 26947: Add scheam-only option to koha-dump

This patch adds a new --schema-only optoin to the koha-dump script.

This can be used to generate a new kohastructure.sql file during the release,
and later to
compare the DB structure of a koha instance to the kohastructure.sql file
shipped with a version
to identify any missing constraints or other db structure issues

To test:
1 - debian/scripts/koha-dump kohadev
2 - Confirm db and configs are dumped correctly
3 - Apply patch
4 - debian/scripts/koha-dump --help
5 - Confirm new option is listed and makes sense
6 - debian/scripts/koha-dump --schema-only kohadev
7 - Confirm only schema is dumped and is not zipped
8 - debian/scripts/koha-dump kohadev
9 - Confirm entire db is dumped as before

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113794|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 113803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113803&action=edit
Bug 26947: (follow-up) Set key checks to disabled for kohastructure

This patch adds sql calls to disable foreign key checks for the initial
kohastructure schema load and then re-enables them again for subsequent
actions.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113799|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 113804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113804&action=edit
Bug 26947: Move -- comment to the COMMENT clause

Sed command from bug 26947 comment 8
sed -r --in-place 's/,\s*-- (.*)$/ COMMENT "\1",/g;'
installer/data/mysql/kohastructure.sql

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #113800|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 113805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113805&action=edit
Bug 26947: Replace double quotes from comments

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

--- Comment #21 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> (In reply to Jonathan Druart from comment #2)
> > Should not we have a bash function in ktd instead? Or a dev script in
> > misc/devel?
> 
> function update_kohastructure {
> mysqldump --databases -d --host=db --user=koha_kohadev
> --password=password koha_kohadev > installer/data/mysql/kohastructure.sql
> }

This one is better, but still not perfect:
mysqldump --no-create-db --no-data --host=db --user=koha_kohadev
--password=password koha_kohadev > installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19815] Replace Record via Z39.50 Server give option to change framework

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19815

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27044] Deprecate core support for PayPal payments

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27044

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113750|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 113806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113806&action=edit
Bug 27044: Mark the PayPal integration as deprecated on the user interface

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27044] Deprecate core support for PayPal payments

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27044

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] New: Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Bug ID: 27055
   Summary: Update Firefox version used in Selenium GUI tests
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org

It's currently 47, if it stays like that, we will have to drop these tests at
some point.

Followup of https://gitlab.com/koha-community/koha-testing-docker/-/issues/203

Past update attempt failed due to like incompatibility/bug between recent
Selenium version and our Perl Selenium library (Selenium::Remote::Driver)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113770|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113739|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 113807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113807&action=edit
Bug 27026: (bug 24159 follow-up) Add a tooltip to explain the values of "Days
mode"

There was a tooltip for values of the existing rules, but not the only
you were editing.

Now there is the same tooltip (title) on the option elements of the
dropdown list.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 113808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113808&action=edit
Bug 27026: Use meaningful descriptions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] New: BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

Bug ID: 27056
   Summary: BARCODE NOT PRINTING ON PATRON CARDS AT ALL
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Windows
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hasa...@mugirls.org.uk
QA Contact: testo...@bugs.koha-community.org

Created attachment 113809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113809&action=edit
this is how the pdf shows up all the time without the barcode.

This is my KOHA VERSION: 17.11.04.000

Hi,

Whenever i create a patron card, the barcode never ever appears on the
template. i have copied and tried many templates now and on all of them the
barcodes just don't appear. so i figured it isn't that im scaling them wrong,
it must be something wrong within the settings of koha and i just can't figure
it out.
i have looked at MANY tutorials online too! and none of them seem to have the
solution. i have even followed them step by step and the barcode still does not
appear for me and it appears for them

i have attached the image below (but obviously i scribbled out the patron names
for GDPR reasons). 

If someone could please help me with this!!!

Kind reagrds,
HH

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|vic...@tuxayo.net   |testo...@bugs.koha-communit
   ||y.org
   Assignee|ch...@bigballofwax.co.nz|vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

--- Comment #1 from Victor Grousset/tuxayo  ---
Created attachment 113810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113810&action=edit
WIP Bug 27055: Fix compatibility with newer Selenium+Firefox version

Fix "submit is not a function error"
A submit button should be named "submit", in this case, it's id.
https://stackoverflow.com/questions/833032/submit-is-not-a-function-error-in-javascript

WIP:
1. Fix SCSS which used the id=submit
2. Fix other tests, there are major issues like crash at the beginning
   or endless duration

== Test plan ==
1. Update selenium/standalone-firefox to the latest version [1]
2. prove t/db_dependent/selenium/authentication.t
3. It fails with: arguments[0].form.submit is not a function
4. Apply patch
5. Retest
6. Success

[1] In koha-testing-docker you can do it with
docker-compose.yml
 selenium:
-image: selenium/standalone-firefox:2.53.1-americium
+image: selenium/standalone-firefox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27056] BARCODE NOT PRINTING ON PATRON CARDS AT ALL

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27056

hasa...@mugirls.org.uk changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|RESOLVED|UNCONFIRMED
 Resolution|INVALID |---

--- Comment #2 from hasa...@mugirls.org.uk ---
where can i report this for support, as i have no clue.

thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #95 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #94)
> (In reply to Jonathan Druart from comment #93)
> > Sorry, the last patch was silly indeed. I hadn't turned on the strict mode.
> > 
> > Your suggestion, Josef, of assuming that the highest priority hold has
> > priority=1 is great actually. I think we never wanted to assume that (in
> > case the data is corrupted?) in this script, but we should go for it IMO,
> > that simplifies the code, the queries, and it makes sense to me!
> 
> I believe in the past we had issues with the priorities not being correct,
> but believe it was fixed (hopefully). Nick or Kyle might be able to tell.
> 
> Wondering what happens with the local holds priority settings - do they
> change the priority in the db or do they check highest priority for local?

I checked in our production sites, there are few cases where the highest
priority is not 1, and they mostly seem to be related to other issues
(suspended holds, holds in the future, missing items) so nothing that should
show on holds to pull.

Local holds don't alter the priority, they get checked first when filling holds
or building the queue, so this report won't catch them, but I think that is
fine as this report isn't branch specific

Other options (for another bug) would be:
1 - List all the holds - just show the first and maybe add a modal to see all
the others
2 - Create a cron like the holds queue, build this page on the backend and
simply display - it adds a delay to new holds showing, but allows us to
calculate the exact holds to be pulled
3 - Add a branch limiter to the report and default to local branches items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27057] New: Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057

Bug ID: 27057
   Summary: Add the ability to have a Override this entire
Checkout transaction when Allowtoomanyoverride is
turned on
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be nice to allow staff to Override an entire Patron transaction when
the library is allowing staff to AllowTooManyoverride. Right now, when a staff
member is checking out to a patron that has gone over the limit of the number
of checkouts, they have to override each checkout. 

A good example would be, a patron that has just returned all their books in the
book drop and now want to checkout more- because the others have not been
checked in, they have gone over their checkout total but the library would like
to allow this.  This enhancement would save a lot of clicking!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Mason James  changed:

   What|Removed |Added

 Attachment #113796|0   |1
is obsolete||

--- Comment #25 from Mason James  ---
Created attachment 113811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113811&action=edit
Bug 26031: Remove 4 failing tests from t/db_dependent/www/search_utf8.t

to test...
1/ apply patch
2/ run test
3/ observe PASS

root@kohadevbox:/kohadevbox/koha# export
KOHA_INTRANET_URL="http://kohadev-intra.myDNSname.org:8081";
root@kohadevbox:/kohadevbox/koha# export
KOHA_OPAC_URL="http://kohadev.myDNSname.org:8080";
root@kohadevbox:/kohadevbox/koha# prove -v  ./t/db_dependent/www/search_utf8.t
1..87
ok 1 - connect to intranet
ok 2 - login to staff interface
ok 3 - load main page
ok 4 - open tools module
ok 5 - go to stage MARC
ok 6 - uploaded file
ok 7 - upload succeeded
ok 8 - reopen stage MARC page
ok 9 - stage MARC
ok 10 - have job ID
ok 11 - job was completed
ok 12 - reopen stage MARC page at end of upload
ok 13 - stage MARC
ok 14 - view batch
ok 15 - imported records into catalog
ok 16 - got search on intranet
ok 17 - got search on intranet
ok 18 - Base is like
"(?^u:search.pl\?advsearch=1&idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"
ok 19 - UTF-8 are multi-byte. Good
ok 20 - UTF-8 chars are correctly present. Good
ok 21 - got opac
ok 22 - got opac
ok 23 - Base is like
"(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"
ok 24 - Base does not contain an idx
ok 25 - UTF-8 are multi-byte. Good
ok 26 - UTF-8 chars are correctly present. Good
ok 27 - view and clean batch
ok 28 - biblio on intranet
ok 29 - biblio deleted
ok 30 - connect to intranet
ok 31 - login to staff interface
ok 32 - load main page
ok 33 - open tools module
ok 34 - go to stage MARC
ok 35 - uploaded file
ok 36 - upload succeeded
ok 37 - reopen stage MARC page
ok 38 - stage MARC
ok 39 - have job ID
ok 40 - job was completed
ok 41 - reopen stage MARC page at end of upload
ok 42 - stage MARC
ok 43 - view batch
ok 44 - imported records into catalog
ok 45 - got search on intranet
ok 46 - got search on intranet
ok 47 - Base is like "(?^u:search.pl\?advsearch=1&idx=kw&q=Ram%C3%B2n)"
ok 48 - UTF-8 are multi-byte. Good
ok 49 - UTF-8 chars are correctly present. Good
ok 50 - got opac
ok 51 - got opac
ok 52 - Base is like "(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)"
ok 53 - Base does not contain an idx
ok 54 - UTF-8 are multi-byte. Good
ok 55 - UTF-8 chars are correctly present. Good
ok 56 - view and clean batch
ok 57 - biblio on intranet
ok 58 - biblio deleted
ok 59 - connect to intranet
ok 60 - login to staff interface
ok 61 - load main page
ok 62 - open tools module
ok 63 - go to stage MARC
ok 64 - uploaded file
ok 65 - upload succeeded
ok 66 - reopen stage MARC page
ok 67 - stage MARC
ok 68 - have job ID
ok 69 - job was completed
ok 70 - reopen stage MARC page at end of upload
ok 71 - stage MARC
ok 72 - view batch
ok 73 - imported records into catalog
ok 74 - got search on intranet
ok 75 - got search on intranet
ok 76 - Base is like
"(?^u:search.pl\?advsearch=1&idx=kw&q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"
ok 77 - UTF-8 are multi-byte. Good
ok 78 - UTF-8 chars are correctly present. Good
ok 79 - got opac
ok 80 - got opac
ok 81 - Base is like
"(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"
ok 82 - Base does not contain an idx
ok 83 - UTF-8 are multi-byte. Good
ok 84 - UTF-8 chars are correctly present. Good
ok 85 - view and clean batch
ok 86 - biblio on intranet
ok 87 - biblio deleted
ok
All tests successful.
Files=1, Tests=87, 127 wallclock secs ( 0.06 usr  0.02 sys +  3.00 cusr  0.99
csys =  4.07 CPU)
Result: PASS

real2m6.709s
user0m3.124s
sys 0m1.032s

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #26 from Mason James  ---
(In reply to Jonathan Druart from comment #24)
> Can you explain your patch, Mason? Adding sleep everywhere in this script
> won't make the tests pass IMO.
> The calls are synchronous, sleep(1) won't change anything. And even if it
> would, it's (almost) always a bad idea as 1s won't be enough in all cases
> (slow servers?)

hi Jonathan, yes, i do see your point about slow servers,

i uploaded another patch that just removes the 4 unreliable tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||19384


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384
[Bug 19384] [OMNIBUS] Add Selenium tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on||27055


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055
[Bug 27055] Update Firefox version used in Selenium GUI tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

--- Comment #27 from Jonathan Druart  
---
Created attachment 113812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113812&action=edit
Bug 26031: Remove the failing tests and the diag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

--- Comment #30 from Jonathan Druart  
---
Found a bug:
1. Search for "Chapman" on the adv search
2. The detail page has "undefined" in the search box

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #113801|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 113813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113813&action=edit
Bug 26954: Remove log of STDERR

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

--- Comment #147 from Nick Clemens  ---
Created attachment 113814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113814&action=edit
Bug 24083: (follow-up) Assign renewals remaining string to content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Nick Clemens  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113753|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 113815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113815&action=edit
Bug 26992: Fix serial issue and related items deletion on serial collection
page

serial-collection.pl uses C4::Items::DelItemCheck() function which is obsolete.

Test plan:

1. Create a subscription with items created when receiving.
2. Receive several issues, and create corresponding items.
3. On Serial collection page (serial-collection.pl), select several issues.
4. Click on button Delete selected issues
5. A confirmation page is displayed. Enable "Delete associated items?".
   Then click on "Yes, delete" button.

   You get this error: Undefined subroutine &C4::Items::DelItemCheck

6. Apply the patch an repeat steps 3-5.
   Check that issues and related items are deleted.

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
   Severity|normal  |major
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Pretty sure this is caused by bug 23463.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||23463


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
[Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26557


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557
[Bug 26557] Batch import fails when incoming records contain itemnumber
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

--- Comment #16 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #11)
> We won't generate an anonymous user, unless weird case (you have the pref
> set but the AI for borrowers is not there yet...)

We'll see :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

--- Comment #29 from Magnus Enger  ---
Hm, I think I agree that a plugin might make sense here. But can we agree on
how to signal that the patron should be denied access? The vendors of "more
open" that I have worked with expect a SIP2 response that has us using this to
set the proper status:

$patron->{'charge_ok'}

Could we pass $patron to the plugin and let the plugin do what it needs to it,
before returning it? So instead of this (as suggested by Mark):

$patron = undef unless ( check_patron ( $patron, $server ) );

we could do this? 

$patron = check_patron ( $patron, $server );

And the plugin could return undef or just a changed $patron. 

I would also suggest a more detailed name for the config-parameter: 

  
  
  

Maybe something like patron_validation_plugin_class? There could be other
plugins that do other things in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

--- Comment #2 from Jonathan Druart  
---
Created attachment 113816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113816&action=edit
Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain
itemnumber

Prior to ug 23463 AddItemFromMarc where calling AddItem, that did not
take into account the itemnumber field.
Now that we are using Koha::Item, we need to remove the items.itemnumber
field from the MARC record

Test plan:
1 - find an existing bib in your system with just one item
2 - export that bib with the item attached
3 - delete the barcode from your item in Koha
4 - stage your exported marc file for reimport, match on biblionumber, set it
to Always Add Items
5 - confirm that the bib matches and the incoming 952 is parsed
6 - click "Import this batch into the catalog"

=> Without this patch you get (in the logs, or hidden)
manage-marc-import.pl: DBD::mysql::st execute failed: Duplicate entry '23' for
key 'PRIMARY' [for Statement "INSERT INTO `items` ( `barcode`,
`biblioitemnumber`, `biblionumber`, `ccode`, `cn_sort`, `cn_source`,
`damaged_on`, `dateaccessioned`, `datelastborrowed`, `datelastseen`,
`holdingbranch`, `homebranch`, `itemcallnumber`, `itemlost_on`, `itemnumber`,
`itype`, `location`, `more_subfields_xml`, `onloan`, `permanent_location`,
`replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with
ParamValues: 0="BC_23", 1=8, 2=8, 3="REF", 4='CN__23', 5=undef, 6=undef,
7="2014-09-04", 8=undef, 9="2014-09-04", 10="FPL", 11="FPL", 12="CN_23",
13=undef, 14="23", 15="BK", 16="GEN", 17=undef, 18=undef, 19="GEN",
20="2014-09-04", 21=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
manage-marc-import.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate
entry '23' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 169
manage-marc-import.pl: {UNKNOWN}: Transaction aborted: Duplicate ID. Rollback
failed: DBIx::Class::Storage::txn_rollback(): Refusing to roll back without a
started transaction at /kohadevbox/koha/tools/manage-marc-import.pl line 253 at
/kohadevbox/koha/tools/manage-marc-import.pl line 253

=> With this patch applied, the new item must be added to the existing
bibliographic record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26557] Batch import fails when incoming records contain itemnumber

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26557

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113704|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #113662|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 113817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113817&action=edit
Bug 26984: Make tests pass if AnonymousPatron is set

There is only 1 place where it can be tricky to not remove them as we
want exactly 10 patrons to be present in the DB

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 113818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113818&action=edit
Bug 26984: (follow-up) Don't delete patrons and checkouts in Objects.t

Rather than counting all and assuriing we get 10, we can count all, add 10, and
ensure the numbers still match

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27057] Add the ability to have a Override this entire Checkout transaction when Allowtoomanyoverride is turned on

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27057

Erica  changed:

   What|Removed |Added

 CC||er...@benbrooklibrary.org

--- Comment #1 from Erica  ---
Quarantining items is messy for libraries anyway because of the lag time for
patrons returning their items in and then receiving an overdue notice.  Once
they return the items, and then come in to check more items out, we have to
manually override each and every item.  Most of the times this has to do with
families with little fidgety ones, and the longer it takes, the most stressful
the interaction is for all parties.  It would be nice if there was a way to
have some sort of bulk override when those instances occur.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #113813|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

--- Comment #21 from Jonathan Druart  
---
Created attachment 113819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113819&action=edit
Bug 26854: Remove log of STDERR

See discussion on comments 12-20

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854

--- Comment #22 from Jonathan Druart  
---
David, to be discussed on a separated bug report but, did you make the log
work?

It kind of worked for me, but I got the log in /var/log/koha/kohadev/sip.log
(?!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] New: Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

Bug ID: 27058
   Summary: Cannot place hold to ordered item when on shelf holds
are not allowed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If you have on shelf holds with "If all unavailable" option in circulation
rules  one cannot place holds on biblio where there is only ordered items
(notforloan = -1). This should be possible since "If all unavailable" means
that all items should be unavailable for checkout for the customer before a
hold can be placed and ordered items are unavailable for checkout.

I'm attaching a trivial patch to fix this but we still need unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |m...@kohaaloha.com
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #1 from Joonas Kylmälä  ---
Created attachment 113820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113820&action=edit
Bug 27058: Make checkout availability use all notforloan reasons

The ItemsAnyAvailableAndNotRestricted function is checking whether an
item can be checked out and it incorrectly only checks the positive
notforloan values when there can be also negative notforloan
values. If notforloan value is not 0 then it means the item cannot be
checked out. In the case of ordered items the value is negative (-1)
and thus before this change the checkout availability was reported
incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26048] Apache does not use /cgi-bin/koha/errors/500.pl if Perl script dies

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #113820|0   |1
is obsolete||

--- Comment #2 from Joonas Kylmälä  ---
Created attachment 113821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113821&action=edit
Bug 27058: Add test to show ordered items cannot be reserved

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #3 from Joonas Kylmälä  ---
Created attachment 113822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113822&action=edit
Bug 27058: Make checkout availability use all notforloan reasons

The ItemsAnyAvailableAndNotRestricted function is checking whether an
item can be checked out and it incorrectly only checks the positive
notforloan values when there can be also negative notforloan
values. If notforloan value is not 0 then it means the item cannot be
checked out. In the case of ordered items the value is negative (-1)
and thus before this change the checkout availability was reported
incorrectly.

To test:
 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
Notice it fails
 2) Apply this patch
 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
Notice it passes now.

To test via Koha sandbox (Alternatively):
 1) Create circ rule with If all unavailable
 2) Create new biblio
 3) Order a new item to the biblio via acquisitions and set the not
for loan value to Ordered / -1
 4) Notice you cannot place a hold to the biblio
 5) Apply patch
 6) Notice you can now place a hold to the biblio

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27059] New: Adding elapsed times/durations to updatedatabase would be nice.

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059

Bug ID: 27059
   Summary: Adding elapsed times/durations to updatedatabase would
be nice.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

In bug 24696 we added completion times to each step in updatedatabase, it would
also be useful to display the elapsed times or time taken per step.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593

--- Comment #2 from Nick Clemens  ---
Created attachment 113823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113823&action=edit
Bug 26593: Remove _get_discount_from_rule

This patch remove the private sub used in GetIssuingCharges in favor
of get_effective_rule

It corrects the wrong precedence for rules and adds tests to cover this
subroutine

NOTE: the 'branch' for the discount will be determined by the signed in branch,
this is a bug to be fixed in the future

To test:
1 - Define a rentalcharge for an itemtype
2 - Define a 10% discount for library A, category A, all itemtypes
3 - Define a 50% discount for all libraries, category A, same itemtype
4 - Attempt to checkout an item from library A of the matching itemtype
5 - The 50% discount is applied
6 - Apply patches
7 - Attempt to checkout an item from library A of the matching itemtype
8 - The 10% discount is applied

prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #113821|0   |1
is obsolete||
 Attachment #113822|0   |1
is obsolete||

--- Comment #4 from Joonas Kylmälä  ---
Created attachment 113824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113824&action=edit
Bug 27058: Add test to show ordered items cannot be checked out

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #5 from Joonas Kylmälä  ---
Created attachment 113825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113825&action=edit
Bug 27058: Make checkout availability use all notforloan reasons

The ItemsAnyAvailableAndNotRestricted function is checking whether an
item can be checked out and it incorrectly only checks the positive
notforloan values when there can be also negative notforloan
values. If notforloan value is not 0 then it means the item cannot be
checked out. In the case of ordered items the value is negative (-1)
and thus before this change the checkout availability was reported
incorrectly.

To test:
 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
Notice it fails
 2) Apply this patch
 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
Notice it passes now.

To test via Koha sandbox (Alternatively):
 1) Create circ rule with If all unavailable
 2) Create new biblio
 3) Order a new item to the biblio via acquisitions and set the not
for loan value to Ordered / -1
 4) Notice you cannot place a hold to the biblio
 5) Apply patch
 6) Notice you can now place a hold to the biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice.

2020-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059

--- Comment #1 from Martin Renvoize  ---
Created attachment 113826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113826&action=edit
Bug 27059: Add elapsed times to updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >