[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #16 from Timothy Alexis Vass --- (In reply to David Cook from comment #15) > (In reply to Timothy Alexis Vass from comment #14) > > I will make it --statue-barred-fees. > > The fees are literally statute-barred. > > > > Thanks for humouring me, Timothy. I know I am being pedantic, but I really > do think it will be helpful. I agree David. It definitely is more obvious and that is definitely important. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27150] New: Batch delete items broke. Returns "0 item(s) deleted"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27150 Bug ID: 27150 Summary: Batch delete items broke. Returns "0 item(s) deleted" Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: somesecretem...@mailinator.com QA Contact: testo...@bugs.koha-community.org Steps to reproduce: 1. Navigate to a biblio with available items (ie https://kodevsod-intra.dev.imcode.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=3296381) 2. Check boxes for två available items 3. Click " Delete selected items" 4. Batch item deletion view is loaded. Click button "Delete selected items" 5. System presents text "0 item(s) deleted" Expected result: 2 item(s) deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #6 from Pablo AB --- (In reply to David Cook from comment #4) > I actually ran into this problem again today, and at the moment the query I > like best is actually the following: > > SELECT max(cast(barcode as unsigned)) from items; Why you like the most this one (except for the ABS identical to my first suggestion), instead of your alternative con comment 1? I remember that at the time your suggestion seems better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What|Removed |Added Summary|barcode.pl: |incremental barcode |ValueBuilder::incremental |generation fails when |should filter non-natural |incorrectly converting |numbers |strings to numbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #5 from David Cook --- Created attachment 114179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114179=edit Bug 26328: Cast barcode from varchar to integer for incremental barcode Without this patch, the incremental barcode generation will treat 978e0143019375 as having an exponent and interpret it as a very large number. With this patch, the incremental barcode generation will first cast barcode varchar strings to integers before finding a max() value. In this case 978e0143019375 becomes 978 instead of 1.7976931348623157e308 Test plan: 0. Using koha-testing-docker Before applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=autobarcode 2. Set to "generated in the form 1, 2, 3" 3. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema=scs_1607059974968 4. Add item with barcode 978e0143019375 5. Click "p - Barcode" 6. Note the barcode is "Inf" After applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema=scs_1607059974968 2. Click "p - Barcode" 3. Note the barcode is "319194" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #4 from David Cook --- I actually ran into this problem again today, and at the moment the query I like best is actually the following: SELECT max(cast(barcode as unsigned)) from items; I'll write up a patch now... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27134] Zebra reindexing Searching issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27134 David Cook changed: What|Removed |Added Status|NEW |RESOLVED CC||dc...@prosentient.com.au Resolution|--- |INVALID --- Comment #1 from David Cook --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #5 from David Cook --- Ultimately, I'd say that we can't reliably use the "daemon" utility to stop "zebrasrv", since "daemon" just sends a SIGTERM signal to "zebrasrv" and "zebrasrv" does not propagate SIGTERM to its child processes. This prevents "zebrasrv" from being stopped by "daemon --stop". Since "zebrasrv" comes with its own -l logfile, -D daemon, and -p pidfile options, I think it would be trivial to just manage zebrasrv via a koha-zebra script that does not use the "daemon" utility. Of course, we'd have to SIGKILL zebrasrv to get it to really stop. Interestingly, looking at https://github.com/indexdata/idzebra/blob/master/etc/init.d/idzebra-init-script shows that they try to "stop" their zebrasrv by just using SIGTERM. (It's also a poorly written service overall...) My guess is that they think it works correctly but I bet that it doesn't... We're running Zebra 2.2.2 on Ubuntu and it looks like someone has provided a different script for /etc/init.d/zebrasrv which uses "start-stop-daemon". This is how that service stops zebrasrv: start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile $PIDFILE --name $NAME However, SIGKILL probably won't work any better as it won't propagate to the child process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #2 from Aleisha Amohia --- Created attachment 114178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114178=edit Bug 16522: Adding 773 to basket and cart WIP Not yet ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #4 from David Cook --- If I manually run zebrasrv by hand I'll get the same result which shows that zebrasrv isn't set up to propagate SIGTERM to its child processes. /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml Visit http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test root@kohadevbox:kohadevbox$ ps -efww | grep "zebrasrv" root 25693 3959 0 02:52 pts/100:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25697 25693 0 02:53 pts/100:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25712 25617 0 02:53 pts/200:00:00 grep zebrasrv root@kohadevbox:kohadevbox$ kill 25693 root@kohadevbox:kohadevbox$ ps -efww | grep "zebrasrv" root 25697 1 0 02:53 pts/100:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25727 25617 0 02:53 pts/200:00:00 grep zebrasrv -- -- On koha-testing-docker, we are using 2.0.59 (and I have mine set up for ICU atm): root@kohadevbox:kohadevbox$ zebraidx -V Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU Looking at the Zebra news https://github.com/indexdata/idzebra/blob/master/NEWS, I don't see anything about SIGTERM specifically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #3 from David Cook --- If you manually try to kill the parent zebrasrv, you get the same problem. -- -- root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25532 1 0 02:48 ?00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25553 25532 0 02:48 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25560 25553 1 02:48 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25563 3959 0 02:48 pts/100:00:00 grep zebrasrv -- -- root@kohadevbox:koha(bug_12430)$ kill 25553 -- -- root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25532 1 0 02:48 ?00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25553 25532 0 02:48 ?00:00:00 [zebrasrv] kohadev+ 25560 1 0 02:48 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25575 3959 0 02:49 pts/100:00:00 grep zebrasrv -- -- If we manually kill the parent zebrasrv process, it becomes a zombie and pid 25560 is adopted by pid 1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #2 from David Cook --- (In reply to Marcel de Rooy from comment #1) > Remember some similar experience. But is the info clear enough for someone > to solve this ticket ? :) Good point heh. Interestingly... I just tried "koha-zebra --stop -v kohadev" and "koha-zebra --start -v kohadev" and it worked correctly. "koha-zebra --restart -v kohadev" just worked too... -- Aha... I just went to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test and then I tried "koha-zebra --stop -v kohadev" but it didn't work. Evidence: -- - root@kohadevbox:koha(bug_12430)$ koha-zebra --start -v kohadev [ ok ] Starting Koha Zebra daemon for kohadev:. root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 1 02:38 ?00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25310 3959 0 02:38 pts/100:00:00 grep zebrasrv -- - root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 0 02:38 ?00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25315 25308 0 02:38 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25320 3959 0 02:38 pts/100:00:00 grep zebrasrv -- - root@kohadevbox:koha(bug_12430)$ koha-zebra --stop -v kohadev [ ok ] Stopping Koha Zebra daemon for kohadev:. root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 0 02:38 ?00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ?00:00:00 [zebrasrv] kohadev+ 25315 1 0 02:38 ?00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25357 3959 0 02:38 pts/100:00:00 grep zebrasrv -- - It looks like the daemon stop killed the original zebrasrv process but it didn't kill the child process of the original zebrasrv process... If I kill the child process (pid 25315), then everything will terminate: root@kohadevbox:koha(bug_12430)$ kill -9 25315 root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" root 25417 3959 0 02:42 pts/100:00:00 grep zebrasrv -- - -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #19 from David Cook --- (In reply to Mark Hofstetter from comment #18) > I still think plugabiltiy would be a good idea (even if it would be just for > the sake of concistency) > > but thanks to all your advice I was able to to todo it in a plugin > (https://github.com/HKS3/koha-plugin-subordinate-items) just create the tab > with js I'm glad that I was able to help! While I used to be worried about UIs built with Javascript, I think a lot of accessibility tools have advanced to the point where it is OK now. And as a result I think that we should actually be moving more work client-side. (One of the advantages of moving things client-side is also that we can make more robust reusable APIs and make calls to the same API from different places in the system or even from other systems. Koha is a big system so I'd love to see less replication and more reuse.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #15 from David Cook --- (In reply to Timothy Alexis Vass from comment #14) > I will make it --statue-barred-fees. > The fees are literally statute-barred. > Thanks for humouring me, Timothy. I know I am being pedantic, but I really do think it will be helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026
--- Comment #15 from David Cook ---
I'm not sure about this change...
Why don't we just set RaiseError and PrintError in Database.pm and then deal
with localizations in install.pl and misc4dev?
For example:
"If you want to temporarily turn RaiseError off (inside a library function that
is likely to fail, for example), the recommended way is like this:"
https://metacpan.org/pod/DBI#RaiseError
{
local $h->{RaiseError}; # localize and turn off for this block
...
}
I'd prefer that ideally.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #76 from David Cook --- (In reply to Martin Renvoize from comment #75) > All works well and this is a really good bug to fix.. Passing QA Cheers, Martin :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #17 from David Cook --- (In reply to Fridolin Somers from comment #16) > This change is harmless I'd say. It's harmless but the description is inaccurate. If you renamed this issue to "QueryWeightFields creates unnecessary whitespace", then I would happily test again and probably sign off. But it wouldn't be fixing any functional bug I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26701] Deal with scripts in C4/SIP directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26701 --- Comment #3 from David Cook --- (In reply to Kyle M Hall from comment #2) > I can state confidently that I didn't even know about this script :) I'm glad that I'm not the only one who didn't know that these existed! (Koha is so big O_O.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #15 from David Cook --- It would be good to have more data from real life examples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- This sounds like an anti-feature to me. Nick's note on Bug 26457 says that renewals are silently failing. I'd say it would be better to make them fail loudly rather than making this work serially? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #119 from Aleisha Amohia --- Created attachment 114177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114177=edit Bug 13952: (follow-up) fixing indentation and rebasing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103616|0 |1 is obsolete|| --- Comment #118 from Aleisha Amohia --- Created attachment 114176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114176=edit Bug 13952: (follow-up) Removing XML options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103615|0 |1 is obsolete|| --- Comment #117 from Aleisha Amohia --- Created attachment 114175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114175=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103614|0 |1 is obsolete|| --- Comment #116 from Aleisha Amohia --- Created attachment 114174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114174=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103613|0 |1 is obsolete|| --- Comment #115 from Aleisha Amohia --- Created attachment 114173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114173=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103612|0 |1 is obsolete|| --- Comment #114 from Aleisha Amohia --- Created attachment 114172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114172=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103611|0 |1 is obsolete|| --- Comment #113 from Aleisha Amohia --- Created attachment 114171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114171=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Attachment #103610|0 |1 is obsolete|| --- Comment #112 from Aleisha Amohia --- Created attachment 114170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114170=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added CC||ivan.dzi...@inlibro.com --- Comment #2 from Ivan Dziuba --- Created attachment 114169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114169=edit Result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes an error when release notes||batch modifying patrons ||using the reports module. ||After running a report ||(such as SELECT * FROM ||borrowers LIMIT 50) and ||selecting batch ||modification an error was ||displayed: "Warning, the ||following cardnumbers were ||not found:", and you were ||not able to modify any ||patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ivan.dzi...@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added CC||eric.be...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #1 from Ivan Dziuba --- Created attachment 114168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114168=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What|Removed |Added Attachment #114146|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 114167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114167=edit Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #3 from Kyle M Hall --- Created attachment 114166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114166=edit Bug 25716: Don't exit if config doesn't exist in Koha conf file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26991] Add action logs to search engine administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds release notes||logging of changes made to ||Elasticsearch. These can be ||viewed in the log viewer ||tool, where you can view ||all search engine changes, ||or limit to edit mapping ||and reset mapping actions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What|Removed |Added Text to go in the||With OIA-PMH enabled, if release notes||you clicked on Sets or ||Metadata in the search ||results no additional ||information was displayed ||(example query: ||/cgi-bin/koha/ ||oai.pl?verb=ListRecords ||adataPrefix=marc21). This ||patch fixes this so that ||the additional information ||for Sets and Metadata is ||now correctly displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26457 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26208 --- Comment #14 from Nick Clemens --- Investigating this, as near as I can tell it only occurs during 'Renew all' when too many processes hit the server at once. I cannot recreate locally, but can verify on larger active koha instances The renewals silently fail and the user is never notified leading to problems later. We have other issues from the multiple concurrent renewals, see bug 26208 I attached a patch there to perform the actions serially which I believe will mitigate this issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 --- Comment #2 from Nick Clemens --- Created attachment 114165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114165=edit Bug 26208: Perform batch checkin/renewals serially rather than asynchronously The issue here seems to be that when multiple requests hit at once they may not register that the renewal performed by the request should lift restrictions on the account. To mitigate this we can simply perform the renewals one after the other. To test: 1 - have multiple overdue items on one patron 2 - run overdues.pl with triggers set to generate a restriction 3 - renew all overdues with the Renew All button 4 - restriction is not removed even though patron no longer has overdue items 5 - Apply patch 6 - Make all items overdue again 7 - Click Renew All 8 - Items are renewed and restriction removed 9 - Checkout items to patron again (overdue or not) 10 - Click 'Select all' in checkin column 11 - Click 'Renew/Checkin selected items' 12 - Confirm checkin succeeds as before patches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #7 from Agustín Moyano --- (In reply to David Nind from comment #6) > Notes from testing (koha-testing-docker (KTD)): > > - Step 2: should be PatronSelfRegistration rather than SeflRegistration, is > set to allow by default in KTD; PatronSelfRegistrationDefaultCategory is set > to SELFREG as the patron category in KTD > > - Step 6: > . to change the password settings for the patron category go to > Administration > Patrons and circulation > Patron category and edit the > SELFREG category; combinations of settings to experiment with are Minimum > password length and Require strong password > . system preferences for password security are minPasswordLength and > RequireStrongPassword > > Everything works as expected with the test plan. Thanks David for this comments, and testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Notes from testing (koha-testing-docker): 1. Enable OIA-PMH - set the OAI-PMH system preference to Enable. 2. Visit /cgi-bin/koha/oai.pl?verb=ListRecords=marc21 3. If you click Metadata for any of the search results it does not open to display additional information. 4. Apply the patch (and flush_memcached and restart_all). 5. Repeat step 2 (or refresh the page). 6. Now if you click on Metadata for one of the search results it will now open to display the additional information. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What|Removed |Added Attachment #114095|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 114164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114164=edit Bug 26665: (bug 20168 follow-up) Fix path to bootstrap js file 20168 moved it to /opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.min.js It fixed the OAI-PMH view Test plan: Hit /cgi-bin/koha/oai.pl?verb=ListRecords=marc21 and confirm that you can click "Metadata" and it opens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Seems to fix the console error in all the places! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- The display for modifying 1 record looks much better now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What|Removed |Added Attachment #114152|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 114163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114163=edit Bug 27124: JS error "select2Width is not defined" This patch changes the way select2.js checks for an existing value of the "select2Width" variable in order to avoid errors when it is undefined. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- Notes from testing (koha-testing-docker (KTD)): - Step 2: should be PatronSelfRegistration rather than SeflRegistration, is set to allow by default in KTD; PatronSelfRegistrationDefaultCategory is set to SELFREG as the patron category in KTD - Step 6: . to change the password settings for the patron category go to Administration > Patrons and circulation > Patron category and edit the SELFREG category; combinations of settings to experiment with are Minimum password length and Require strong password . system preferences for password security are minPasswordLength and RequireStrongPassword Everything works as expected with the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127
Lucas Gass changed:
What|Removed |Added
Attachment #114073|0 |1
is obsolete||
--- Comment #3 from Lucas Gass ---
Created attachment 114162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114162=edit
Bug 27127: Make Koha::BackgroundJob->messages return a scalar
Otherwise the code in the template is not handled correctly:
112 [% FOR m IN job.messages %]
m will become each key/val of the message hash:
{"type":"success","biblionumber":"1","code":"biblio_modified"}
And not the whole hash
Test plan:
Modify one biblio using the batch record modification tool
Modify two biblios using the batch record modification tool
Go to the detail view of each job and confirm that with this patch the
display is correct
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 David Nind changed: What|Removed |Added Attachment #114154|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 114161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114161=edit Bug 27148: Fix bug on self registration when user category is hidden This patch fixes the bug when there is no patron category available for selection in self registration form. It uses PatronSelfRegistrationDefaultCategory to get patron's password length and strength. To test: 1. Do not apply this patch 2. Allow PatronSelfRegistration, set PatronSelfRegistrationDefaultCategory to a valid patron category and finally add categorycode to PatronSelfRegistrationBorrowerUnwantedField 3. Go to opac and enter self registration form CHECK => There is no patron category available for selection => Password's info alert shows "Password must contain at least undefined characters" 4. Fill the form setting a password and send. CHECH => You get an exception saying "You must provide a patron's category to validate password's strength and length" 5. Apply this patch and restart_all 6. repeat steps 3 and 4 SUCCESS => Password's info alert message shows a number instead of "undefined" => Password's strength and length checks are working => If you change default category's lenght or strength parameter it get's reflected when you refresh the page => When you click submit, patron is saved Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #19) > I want to propose an alternate solution based on bug 24254. Writing the > alternate patch. I would love your feedback on that bug and if it makes > sense to use here. ^^ this last comment is because the other bug introduces a new method and it could make things harder for bakporting to the stable branches (don't really think so, but just in case) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #19 from Tomás Cohen Arazi --- I want to propose an alternate solution based on bug 24254. Writing the alternate patch. I would love your feedback on that bug and if it makes sense to use here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 114160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114160=edit
Bug 24254: Add Koha::Items->filter_by_visible_in_opac
This patch adds a method based on the original idea from Nick, but on
Koha::Items.
The idea is to build a proper filter, based on the current rules for
hiding things, directly on the DBIC query. The caller takes care of
knowing if the filtering should apply (i.e. checking the patron category
exceptions) and then it would do something like:
my @items;
if ( ) {
@items = $biblio->items->filter_by_visible_in_opac(
{
rules => $rules
}
);
}
else {
# still want to enforce 'hidelostitems'
@items = $biblio->items->filter_by_visible_in_opac;
}
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Items.t
=> SUCCESS: Tests pass!
3. Look at the use cases on the tests, read the code
=> SUCCESS: It all makes sense
4. Compare with Koha::Item->hidden_in_opac
=> SUCCESS: It all makes sense
5. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 114159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114159=edit Bug 24254: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What|Removed |Added Attachment #96373|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27049] It would be helpful to have a bulk waive of debts tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Lucas Gass changed: What|Removed |Added Attachment #114097|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 114158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114158=edit Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26991] Add action logs to search engine administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 David Nind changed: What|Removed |Added Attachment #114150|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 114157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114157=edit Bug 26991: Add action logs to search engine administration Search engine administration is very important, we should log who/when it is changed. I don't add a preference system to disable it, like there is no for preference system logs. Test plan : 1) Use searchengine Elasticsearch 2) Go to Administation > Search engine configuration (Elasticsearch) 3) Click on 'Reset Mappings' and accept 4) Edit some lines and save 5) Go to 'Tools' > 'Log viewer' 6) Select only 'Search engine' in Modules and submit 7) Select only 'Edit mappings' in Actions 8) Check you see a log 9) Select only 'Reset mappings' in Actions 10) Check you see a log Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26991] Add action logs to search engine administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27149 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25716 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 --- Comment #2 from Nick Clemens --- Created attachment 114156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114156=edit Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 --- Comment #1 from Nick Clemens --- Created attachment 114155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114155=edit Bug 27149: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27149] New: Z3950Responder removes itemnumber when adding item statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Bug ID: 27149 Summary: Z3950Responder removes itemnumber when adding item statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Koha/Z3950Responder/Session.pm: 297 $field->delete_subfield( code => $itemnumber_subfield ); This breaks MARCEdit integration as svc/bib uses the itemnumber field to update items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27144] Cannot delete any patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #6 from Andrew Nugged --- (add) i.e. that might happen on those servers where this fail happened so manual post-check and cleanup in "deletedborrowers" might be required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27144] Cannot delete any patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #5 from Andrew Nugged --- (In reply to Jonathan Druart from comment #4) > (In reply to Joonas Kylmälä from comment #3) > > This might have caused some corruption/duplicated data in the DB, to check > > if you have any use: > > > > > select count(*) FROM deletedborrowers WHERE borrowernumber IN (SELECT > > > borrowernumber FROM borrowers); > > Why, can you detail please? deletedborrowers pollution happens because first "$patron->move_to_deleted;" succeeds, but then try/catch with "$patron->delete" fails, keeping those deleted records as duplicates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #4 from Agustín Moyano --- Created attachment 114154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114154=edit Bug 27148: Fix bug on self registration when user category is hidden This patch fixes the bug when there is no patron category available for selection in self registration form. It uses PatronSelfRegistrationDefaultCategory to get patron's password length and strength. To test: 1. Do not apply this patch 2. Allow SeflRegistration, set PatronSelfRegistrationDefaultCategory to a valid patron category and finally add categorycode to PatronSelfRegistrationBorrowerUnwantedField 3. Go to opac and enter self registration form CHECK => There is no patron category available for selection => Password's info alert shows "Password must contain at least undefined characters" 4. Fill the form setting a password and send. CHECH => You get an exception saying "You must provide a patron's category to validate password's strength and length" 5. Apply this patch and restart_all 6. repeat steps 3 and 4 SUCCESS => Password's info alert message shows a number instead of "undefined" => Password's strength and length checks are working => If you change default category's lenght or strength parameter it get's reflected when you refresh the page => When you click send, patron is saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26701] Deal with scripts in C4/SIP directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26701 --- Comment #2 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > There don't bring much, I am in favour of removing them. > > At least C4/SIP/interactive_renew_all_dump.pl is broken since > commit d85f757ce7bf446705a8d76bc0d2280705a2d88d > Date: Thu Oct 30 15:36:09 2014 + > Bug 7904 Change SIP modules to use standard LIB path > > Kyle, Colin, are you using them? I can state confidently that I didn't even know about this script :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- This new look is very nice and each of the new controls works well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Lucas Gass changed: What|Removed |Added Attachment #113331|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 114153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114153=edit Bug 25775: Add DataTables controls to user's checkouts table in OPAC This patch updates the "your summary" page in the OPAC so that tables on the logged-in user's page have DataTables controls. The patch also tweaks the DataTable configuration of some other pages to make them all more consistent. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user who has checkouts, overdues, and holds. - On the "your summary" page, confirm that the checkouts table has controls at the top: A search form and link-style buttons: Clear filter, Copy, CSV, Print, iCal, Renew selected, and Renew all. - Confirm that each work correctly. - At the bottom of the page, the style of the "Renew selected" and "Renew all" buttons should now be side by side. - Confirm that both buttons work correctly. - If necessary, enable the UseCourseReserves system preference. - Go to the OPAC course reserves page. - Confirm that there is a working "Search courses" field at the top of the table. - View the contents of a course reserve. - There should be a "Search course reserves" field at the top of the table. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 --- Comment #1 from Owen Leonard --- Created attachment 114152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114152=edit Bug 27124: JS error "select2Width is not defined" This patch changes the way select2.js checks for an existing value of the "select2Width" variable in order to avoid errors when it is undefined. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- Fridolin, I have encounter a problem while testing this patch. To recreate: 1. apply your patch 2. try opac-password-recovery.pl without an email, I see the new error message 3. in the staff client add an email for the same patron 4. try opac-password-recovery.pl again, it blows up with the error: Invalid 'from' parameter: root@localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Summary|Add Koha::Biblio|Add |get_visible_items method|Koha::Items->filter_by_visi ||ble_in_opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Fridolin Somers changed: What|Removed |Added Attachment #114134|0 |1 is obsolete|| --- Comment #2 from Fridolin Somers --- Created attachment 114151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114151=edit Bug 27135: Adjust "upload image" button when viewing item's cover images When viewing the cover image of an item, the "upload image" button is about to upload an image at biblio level. Test plan: - Attach a cover image to an item - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the item - Attach a cover image to the biblio - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the biblio Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #3 from Jonathan Druart --- (In reply to Agustín Moyano from comment #2) > If PatronSelfRegistrationDefaultCategory is not set, then we should fetch > system's default password strength and length The self registration feature is disabled is this pref is not set. So we don't need to take this case into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
