[Koha-bugs] [Bug 26528] Koha return no result if there's invalid records in Z39.50/SRU server reply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26528 --- Comment #3 from Didier Gautheron --- Hi, cf: https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru and sql code adding it: https://git.biblibre.com/biblibre/tools/src/branch/master/koha/bnf_sru_aut.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26742] Add configuration for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #9) > There is "Failed to connect: Error connecting to localhost:61613: Cannot > assign requested address at /usr/share/perl5/Net/Stomp.pm line 27.; giving > up at /usr/share/perl5/Net/Stomp.pm line 27" that is raised by the > constructor. > So you are right, not by $stomp->connect but already by our > Koha::BackgroundJob->connect. > Hmm, did you get that when RabbitMQ was down? What if RabbitMQ is up but the auth details are wrong? I feel like I didn't get an exception in that latter case. > It hasn't been advertised by the commit message, I think it need discussion > and tests are missing. Can we move this part to its own bug report? I suppose so. I don't really have the stamina at the moment to work on anything, so happy to just have it moved to Failed QA as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #18 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #16) > 13. Review "The following NEW packages will be installed" and note > rabbitmq-server is included > > Not included right? Hopefully... October feels a long time ago. I'd probably mark this as Failed QA. I doubt I'm going to work on it again though. Plus, I think that this is handled by a different bug now anyway... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #17 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #15) > Why was the shebang changed in /debian/koha-common.postinst ? > > -#!/bin/sh > +a!/bin/sh That's definitely a vim typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #36 from David Cook --- It's unlikely that I'm going to work on this any time soon, since this doesn't impact any of my clients and I have other priorities. At this point, I'd suggest a temporary workaround of requesting a high ProxyTimeout, or asking one's vendor to create a more robust patron import. If someone sponsored the development, I could work on it, although I'd need to take some time to analyze the code to estimate the effort/cost involved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #34 from David Cook --- I reiterate though that I'm not an expert on this and I'm happy to defer to others. I'm just saying that the current proposal looks complex and difficult to use. Since the OPAC is much smaller than the Staff Interface, it's probably reasonable to experiment there. As Owen said on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988#c50, it makes sense to try a proof-of-concept before trying to update everything, and it seems Julian opened this bug as that proof-of-concept (it probably would've been good to announce it as such but oh well). Maybe we'll even find that due to the complexity of the 8 functions that people try to make simpler text constructs so that they can just use t(). To quote Jonathan (from ages ago), let's focus on code rather than on talk. I'm sure we could endlessly debate this one back and forth and never get anywhere. So why don't we just move forward and see how we go? (The only downside to that approach is that a new release isn't for half a year.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #33 from David Cook ---
(In reply to Martin Renvoize from comment #28)
> Just for documentation, we had a good discussion around this on IRC this
> morning with a few options to think about.. discussion is around 8.13:
> http://irc.koha-community.org/koha/2020-12-11#i_2316124
Looking at http://irc.koha-community.org/koha/2020-12-11#i_2316124, I'm
thinking about separation of concerns...
On one hand, using t() could make it easier for a frontend web designer to do
their design in English and offload translations to others without worrying
about the backend.
On the other hand, using t() is looking quite complex and not
designer-friendly. It really looks like we're trying to shoehorn a solution
into the templates.
Take the following example:
[% tx('Published on {published_on} by {author}', { published_on =
filter(date_var, 'KohaDates', options), author = filter(author, 'html') }) |
html %]
Compare it with this much simpler Vue.js i18n example:
https://kazupon.github.io/vue-i18n/guide/formatting.html#named-formatting
A lot of the i18n systems out there work based on this token idea.
Now of course in the Koha version we're doing a lot of extra things. I'd
actually argue that we shouldn't be using KohaDates in the templates and really
should format the date in the Perl and then push the correctly formatted date
to the template (ie view). After all, if we were getting the date by an AJAX
call (say using Vue.js), we'd want the correct data, since we're just rendering
it in the presentation layer of our application. Regarding html escaping, we'd
just have that on by default. To avoid double-encoding, we could turn off the
html filter at the function level.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #32 from David Cook --- (In reply to Katrin Fischer from comment #29) > Have to still read discussion, but I also am in favor of keeping stuff > readable in templates to some extent. Using only variables in templates and > having to look them up in a Perl script adds an extra step and will make it > harder again for people to contribute simple changes. Easier doesn't always mean better. > Also I foresee use of > a lot of silly variable names with the amount of strings we have. With DSpace, you see keys like this: "jsp.dspace-admin.eperson-edit.emailexists". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #31 from David Cook --- (In reply to Julian Maurice from comment #27) > If we can't expect developers to use 8 functions, what can we expect from > them ? We can expect developers to follow consistent simple rules. > We can probably reduce the number of functions to 2: t and tn, and transform > the other ones into optional arguments of these 2 functions (the same as > drupal). But developers would now have to remember the name of the options. > (And the parser which extracts translatable strings would have to be > modified too) This sounds better to me. It is easier to lookup options for 2 functions than to lookup, compare, and contrast 8 different functions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #30 from David Cook ---
(In reply to Julian Maurice from comment #27)
> I really don't see how what you're describing is a better solution than what
> we already have. This is looking worse actually. Correct me if I'm wrong but
> are you're suggesting that
>
> [% t('Hello, World!') %]
>
> should be replaced by
>
> $template->param('hello_world_str' => fetch('hello_world_str'))
>
> in Perl script and
>
> [% hello_world_str %]
>
> in template ? I don't find that very clean.
I would say that the latter example is actually much *cleaner*. I think that
you mean that it is less *convenient*.
A different example could be:
[% opac_access_denied %]
vs
[% t('Sorry, the system doesn\'t think you have permission to access this
page.') %]
That being said... I suppose using t() does make it easier to automate string
extraction from templates rather than forcing developers to put their strings
into translation files and to reference them correctly in the Perl.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #4 from David Cook --- (In reply to Julian Maurice from comment #3) > I believe Starman is not strictly required, as other PSGI servers should > work as well. And we also have an option to run Koha as a Mojolicious > application. > Would it make sense to move it to the 'recommends' section of cpanfile > instead ? I think that your argument has merit, but if we want Koha to work out-of-the-box, we do need to provide a default requirement, which is going to be starman for the time being. Maybe we could put it as "recommends" in the cpanfile, and then keep "starman" in debian/control for koha-common and koha-full... and allow people to install whatever PSGI/Mojolicious server they want for koha-core... It seems that "C4/Installer/PerlModules.pm" and "debian/list-deps" won't process "recommends", so that could work... Perhaps something to discuss further.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 --- Comment #1 from Donna --- In the purchase suggestion form on the OPAC, the reason for purchase, linked to opac_sug authorized value does not show the OPAC description label, it shows the description instead. To recreate: 1. Create an auth value in opac_sug, with different text for the description and OPAC description. 2. Go to the OPAC and open the purchase suggestion form. 3. Note in the Reason for purchase drop down, the descriptions appear, not the text entered in the OPAC description field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27230] New: purchase suggestion authorized value opac_sug doesn't show opac description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Bug ID: 27230 Summary: purchase suggestion authorized value opac_sug doesn't show opac description Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo --- It works :) QA question, is that expected for a space char in the content to cause the message to be sent? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #112650|0 |1 is obsolete|| --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 114371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114371&action=edit Bug 26851: Don't generate a notice to library if no content To test: 1 - Check out an over due to a patron 2 - Set overdue triggers to a trigger less than number of days overdue 3 - Make sure the patron has no email 4 - Set content of ODUE notice to: [%# Comment will not print %] 5 - perl misc/cronjobs/overdue_notices.pl 6 - Check the message queue 7 - There is a notice sent to the library: "These messages were not sent directly to the patrons." With no messages 8 - Apply patch 9 - Repeat 10 - No new message generated Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Ed Veal changed: What|Removed |Added CC||ev...@mckinneytexas.org --- Comment #7 from Ed Veal --- I support separating news and html customizations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26897] Blank SIP message closes SIP server connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26897 Ed Veal changed: What|Removed |Added CC||ev...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #221 from Katrin Fischer --- I've added a suggestion for this on the Koha 21.05 Road Map - please sign up if you are interested to finally get this one in :) https://annuel.framapad.org/p/koha_21.05_roadmap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27229] Italian translation of State
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27229 John Fawcett changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #2 from John Fawcett --- Closing this as this is more appropriate to translate mailing list and if modification agreed, it can be done directly in .po files on translate site -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27227] Itailan PO: "your charges" typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27227 John Fawcett changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from John Fawcett --- Closing this as .po files can be modified directly on translate site. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27228] Italian Translation typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 John Fawcett changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from John Fawcett --- Closing this as .inc file strings are generated from .po as per previous comment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27228] Italian Translation typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #3 from Katrin Fischer --- The template files you see locally are generated from the po files. The strings all come from the po files originally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27228] Italian Translation typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #2 from John Fawcett --- Hi Katrin thanks for the feedback. I'll modify the .po types there. What about typos in .pl or .tt files. I don't see that type of file on the translate site, only .po files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27229] Italian translation of State
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27229 Katrin Fischer changed: What|Removed |Added Status|NEW |In Discussion --- Comment #1 from Katrin Fischer --- Hi John, I suggest to bring this up on the koha-translate mailing list instead. This is were translation matters are discussed - you will probably not reach the Italian translators via bugzilla. Only very few people (like the QA manager) check on the newly reported bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27228] Italian Translation typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #1 from Katrin Fischer --- Hi John, translations are maintained on translate.koha-community.org and any typos can be fixed there directly and usually don't need to be reported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
