[Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 Timothy Alexis Vass changed: What|Removed |Added CC||timothy_alexis.v...@ub.lu.s ||e -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #21 from Johanna Räisä --- (In reply to David Cook from comment #20) > (In reply to David Cook from comment #18) > > I was thinking about this idea just the other day... > > > > If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll > > see that $0 can also be a URI. That could be pretty cool. > > > > It seems too that the $0 is repeatable so that you could have different > > identifiers... I guess so you could reference VIAF and something else? > > We could index a URI, so that Koha's bib to auth link search would still > work... > > We could actually build in a RDF dereferencing system eventually. Do you mean putting Koha's internal link to authority linking subfield? We are using national metadata repository and mainly the URI in $0 subfield has a link to that. It might be a good idea that Koha would use URI in authority linking subfield also. We are facing problem with this $9 subfield because it is used in our national metadata repository for other things and it should not change if we are pulling data to Koha. This is why it would be nice to choose which subfield is used for the authority linking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #20 from David Cook --- (In reply to David Cook from comment #18) > I was thinking about this idea just the other day... > > If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll > see that $0 can also be a URI. That could be pretty cool. > > It seems too that the $0 is repeatable so that you could have different > identifiers... I guess so you could reference VIAF and something else? We could index a URI, so that Koha's bib to auth link search would still work... We could actually build in a RDF dereferencing system eventually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #4) > I think another reason might be that Koha was using $9 when there was no $0 > subfield in MARC21 yet. Bingo. According to https://www.loc.gov/marc/bibliographic/ecbdcntf.html, the $0 was added (for this purpose) in 2007. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #18 from David Cook --- I was thinking about this idea just the other day... If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll see that $0 can also be a URI. That could be pretty cool. It seems too that the $0 is repeatable so that you could have different identifiers... I guess so you could reference VIAF and something else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27257] New: Hai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27257 Bug ID: 27257 Summary: Hai Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: hisyamnur...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 114469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114469&action=edit Hai -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #2 from David Cook --- Created attachment 114468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114468&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #4 from David Cook --- (In reply to Fridolin Somers from comment #3) > I like the idea I've done more thinking this morning, and now I'm starting to think about just monitoring Zebra better. Possibly putting together a Koha plugin to act as a Prometheus exporter, so it would scan Zebra logs for errors and then let Prometheus pull that data into itself. It could then be interrogated in Prometheus, and we as developers could then track back issues and improve Koha's Zebra integration as a result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #10 from Aleisha Amohia --- I'm currently working on this, and a big goal is to make it work as a notice with the template toolkit syntax. I believe this depends on moving some of the old C4/Biblio.pm subroutines (GetMarcAuthors etc) into Koha/Biblio.pm. That work would be substantial and needs to be done first, in separate bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Bug 27145 depends on bug 27144, which changed state. Bug 27144 Summary: Cannot delete any patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27144] Cannot delete any patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #37 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in||19.11.13 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #21 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247
Lucas Gass changed:
What|Removed |Added
Attachment #114432|0 |1
is obsolete||
--- Comment #3 from Lucas Gass ---
Created attachment 114467
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114467&action=edit
Bug 27247: Re-add highlighting to the quote editor
Caused by
commmit 247dca306407ac9568344a0a37aca3bbcffc2468
Bug 23013: Upgrade DataTables in the staff client
which removed
-tr.even.selected td {
-background-color: #D3D3D3;
-}
There was no more highlighting when trying to delete an imported quote, as
there was before
(see screenshot from the manual
https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png)
It was, however, possible to delete imported quotes, you just don't see which
ones you are deleting.
Test plan:
1) Create a CSV with two columns first the name, then the quote (I've attached
a CSV that I've done for testing purposes)
2) Go to Tools > Edit quotes for the QOTD feature
3) Click 'Import quotes'
4) Click 'Browse' and choose the CSV created earlier
5) Click on the id of a couple of quotes. Notice those lintes are highlighted
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #8 from Lucas Gass --- (In reply to Lucas Gass from comment #7) > Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all > the hard work Nick did it would not be easy to add easily add the > 'exclusions: branchcode' line to opac.pref now it would be easy* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #7 from Lucas Gass --- Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all the hard work Nick did it would not be easy to add easily add the 'exclusions: branchcode' line to opac.pref now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- (In reply to Fridolin Somers from comment #5) > (In reply to Fridolin Somers from comment #3) > > > > Most important : > > Clicking on "Select all" selects the branchcode :O > > Do you reproduce this ? > Its a major issue no ? I cannot reproduce this. When I click 'Select All' the branchcode option does appear to be select (it gets a check) but if I load the registration form I am able to complete it. Also if I click 'Select All' and save then immediately reopen the modal you will see that branchcode is not selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27092] Remove note about "synced mirror" from the README.md
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in||19.11.13 Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in||19.11.13 --- Comment #38 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 heinrichjbheidenre...@gmx.de changed: What|Removed |Added CC||HeinrichJBHeidenreich@gmx.d ||e Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27239] FRBRizeEditions is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23294] Restore actual cost input field on order page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Aleisha Amohia changed: What|Removed |Added Blocks||27203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 [Bug 27203] Order unitprice is not set anymore and totals are 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Depends on||23294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 [Bug 23294] Restore actual cost input field on order page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Kyle M Hall changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27109] Better labels for background job details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. As this one > improves the display, I've signed it off. I will add a new bug for changing > the term and see what others think. > > Testing notes: > - Applied patch: applied successfully > - Reviewed diff, makes sense to me I agree. Can you submit a follow-up on this bug for 'Queued'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27109] Better labels for background job details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha. As this one improves the display, I've signed it off. I will add a new bug for changing the term and see what others think. Testing notes: - Applied patch: applied successfully - Reviewed diff, makes sense to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #1 from Nick Clemens --- Created attachment 114466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114466&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27109] Better labels for background job details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What|Removed |Added Attachment #114075|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 114465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114465&action=edit Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27109] Better labels for background job details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What|Removed |Added Attachment #114074|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 114464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114464&action=edit Bug 27109: Remove Replay action - not implemented Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27109] Better labels for background job details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 --- Comment #1 from Martin Renvoize --- Created attachment 114463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114463&action=edit Bug 27256: Update click handler for point of sale This patch updates the click handler to bind to the table element in the DOM as aposed to the individual buttons by their classes. We then use the event propogation and filter on the button class to catch the clicks we want. Test plan 1/ Add 22 debit_types that can be sold to the system (or reduce the datatable paging size) 2/ Confirm that items on the second page of results cannot be added for sale on the point of sale page. 3/ Apply the patch 4/ Confirm items from the second table page can now be added correctly 5/ Clicking add when navigating to such an item should leave the items table unmodified. 6/ Clicking aa when the table was filtered should reset the filters bringing the table back to the first page 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What|Removed |Added Depends on||27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] Add button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27256] New: Add button on point of sale page fails on table paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Bug ID: 27256 Summary: Add button on point of sale page fails on table paging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The default paging for our DataTables is 20 items, so if we have more than 20 different items that can be sold via the point of sale page then the table of items will be paged. The 'add' button works perfectly for the first page or results, but if you navigate to the second page, or filter/search the the table and find an item from a subsequent page, the add button does nothing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27255] New: Authorized values does not allow you to provide a description for the category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27255 Bug ID: 27255 Summary: Authorized values does not allow you to provide a description for the category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I am noticing that AV has descriptions for the categories that come with Koha, but when you create a category, you are not allowed to provide a description. This is probably an oversight, but I think it would be great if we could add descriptions to new or existing categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #37 from Victor Grousset/tuxayo --- Wait, I got confused. «Yes, that's the expected behaviour» Ok, will backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 --- Comment #4 from Owen Leonard --- Created attachment 114462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114462&action=edit Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Bug 27245 depends on bug 26518, which changed state. Bug 26518 Summary: Adding a record can succeed even if adding the biblioitem fails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #36 from Victor Grousset/tuxayo --- *It doesn't Not backporting unless this is need and a fix is provided. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #35 from Victor Grousset/tuxayo --- I doesn't seem to work on 19.11.x 1. apply 2. restart services 3. optional: prove t/db_dependent/Biblio.t (passes) 4. fill a record with 010 = ThisisgoingtobetoomanycharactersfortheLCCNfield 5. save 6. error: "Bibliographic record not found." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27254] New: Damaged items need more control over holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27254 Bug ID: 27254 Summary: Damaged items need more control over holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently, NOT_LOAN is setup so that negative values will allow holds and positive values will not. DAMAGED does not have this functionality, to my knowledge. AllowHoldsOnDamagedItems gives you an ON/OFF setting for DAMAGED items. It would be great if we did away with AllowHoldsOnDamagedItems and instead DAMAGED would function the same as NOT_LOAN in terms of positive and negative values distinguishing whether or not the item can be put on hold. This way, a library can determine if a damaged item is a lost cause and change it to a damaged status that can't be held. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 --- Comment #20 from Victor Grousset/tuxayo --- Does this mean that for now, 19.11 and 20.05 will have to advertise (and test in the CI) ES 5 only? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #244 from Chris Cormack --- Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Attachment #114457|0 |1 is obsolete|| --- Comment #89 from Alexis Ripetti --- Created attachment 114461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114461&action=edit Bug 12532 - Correction of tests involving guarantorid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Attachment #114456|0 |1 is obsolete|| --- Comment #88 from Alexis Ripetti --- Created attachment 114460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114460&action=edit Bug 12532 - Rebase and correction of the patch by adding the possibility of sending emails to several guarantors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Attachment #88296|0 |1 is obsolete|| --- Comment #87 from Alexis Ripetti --- Created attachment 114459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114459&action=edit Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Attachment #114455|0 |1 is obsolete|| --- Comment #86 from Alexis Ripetti --- Created attachment 114458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114458&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27082] Problem when a basket has more of 20 orders with uncertain price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in||19.11.13 --- Comment #15 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #85 from Alexis Ripetti --- Created attachment 114457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114457&action=edit Bug 12532 - Correction of tests involving guarantorid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #84 from Alexis Ripetti --- Created attachment 114456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114456&action=edit Bug 12532 - Rebase and correction of the patch by adding the possibility of sending emails to several guarantors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Attachment #88295|0 |1 is obsolete|| --- Comment #83 from Alexis Ripetti --- Created attachment 114455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114455&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #17 from Josef Moravec --- This is definitely a bug. Now at least both backup files have same permissions which is good. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Josef Moravec changed: What|Removed |Added Attachment #113685|0 |1 is obsolete|| --- Comment #16 from Josef Moravec --- Created attachment 114454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114454&action=edit Bug 14564: Set permissions on configuration backups This patch sets the group and group read permissions on configuration backups, so that they can be downloaded via the web staff interface. Test plan: 0. Apply the patch 1. cp debian/scripts/koha-dump /usr/sbin/koha-dump 2. koha-run-backups --days 2 --output /var/spool/koha 3. Note *.tar.gz backups in /var/spool/koha/kohadev now have root:kohadev-koha ownership and 640 permissions 4. vi /etc/koha/sites/kohadev/koha-conf.xml 5. Set backup_db_via_tools and backup_conf_via_tools to 1 6. echo 'flush_all' | nc -q 1 memcached 1121 7. koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 9. Click on "Export configuration" 10. Choose a file 11. Click Download configuration 12. Note that *.tar.gz file downloaded correctly Signed-off-by: David Cook Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Josef Moravec changed: What|Removed |Added Attachment #113701|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 114453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114453&action=edit Bug 24519: Match paycollect form validation for change collection This patch adds form validation to the Point Of Sale payment page such that one cannot submit the form with a 'collected' value that is less than the 'owed' amount. Signed-off-by: Sally Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921
Josef Moravec changed:
What|Removed |Added
Attachment #113128|0 |1
is obsolete||
--- Comment #4 from Josef Moravec ---
Created attachment 114452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114452&action=edit
Bug 26921: Don't generate an invalid custom cover image if the url cannot be
generated
In case a custom cover image url is used to generate the cover image of
bibliographic records, we should not build one if the record does not
have the necessary data.
For instance if you have
CustomCoverImagesURL set to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb
and a biblio does not have the isbn defined, we should not generate and
empty image (empty or invalid src)
Test plan:
0.
Set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb
Enable CustomCoverImages and OPACCustomCoverImages
To highlight the issue you should disable LocalCoverImages and
OPACLocalCoverImages.
1. Make sure you have some of your bibliographic records with a valid
isbn
2. Make sure you have at least 1 bibliographic record without an isbn
set
3. Visit the search result and detail views (OPAC and staff interfaces)
=> Without this patch you should see a "Cover image" link, and an empty
block/div on the detail page
=> With this patch applied you should only see images when the url can
be generated
Note that the problem will persist if the isbn is not valid (ie. no
image is generated)
Sponsored-by: Orex Digital
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27035] Shows the number of results in a facets after facet selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Indeed, number of results are useful before selecting a facet. After, it may be confusing and not really useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- There is also Surname: in moremember.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/ec1979a385cb35228d39d139d7c0bd8c685dd4a2/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt#L638 Creating : msgid "Surname: " So maybe better add a span in other places : Surname: It removes the %s which is not a real PO var, it must not be moved. What do you think ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Kyle M Hall changed: What|Removed |Added Attachment #114310|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 114451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114451&action=edit Bug 27117: Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- if ( $metadata & $metadata !~ "") second test is useless I think, if ($metadata) with skip undefined, empty string and 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27244] items with a negative not for loan values are considered available in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27244 --- Comment #2 from Lucas Gass --- (In reply to Jonathan Druart from comment #1) > Does it work on the staff interface? Jonathan, I just test it and no, it does not work in the staff client either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What|Removed |Added Attachment #114445|0 |1 is obsolete|| --- Comment #12 from Josef Moravec --- Created attachment 114450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114450&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What|Removed |Added Attachment #11|0 |1 is obsolete|| --- Comment #11 from Josef Moravec --- Created attachment 114449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114449&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What|Removed |Added Attachment #114443|0 |1 is obsolete|| --- Comment #10 from Josef Moravec --- Created attachment 114448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114448&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #10 from Kyle M Hall --- Created attachment 114447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114447&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check for valid pickup location to the POST /holds route. A 400 code is returned if the supplied pickup library is not valid. To test: 1. Apply this patch 2. Run; $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What|Removed |Added Attachment #114377|0 |1 is obsolete|| Attachment #114384|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 114446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114446&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a test for valid pickup locations when updating a hold through the API. Tests are adjusted to reflect this change. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #9 from Kyle M Hall --- Created attachment 114445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114445&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #8 from Kyle M Hall --- Created attachment 11 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Kyle M Hall changed: What|Removed |Added Attachment #114378|0 |1 is obsolete|| Attachment #114379|0 |1 is obsolete|| Attachment #114380|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 114443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114443&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22332] Limit to currently available items in home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Jaki changed: What|Removed |Added CC||jaki.fris...@leblibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #4 from Fridolin Somers --- Fix makes sens. I corrected the commit message, see https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What|Removed |Added Attachment #113970|0 |1 is obsolete|| --- Comment #3 from Fridolin Somers --- Created attachment 114442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114442&action=edit Bug 27085: Corrections in overdue_notices.pl help text -library only deal with overdues from this library (repeatable : several libraries can be given) Should be Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Passed QA Keywords|rel_20_11_candidate |rel_21_05_candidate --- Comment #16 from Josef Moravec --- QA script passed Bug fixed, no regression found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Josef Moravec changed: What|Removed |Added Attachment #114400|0 |1 is obsolete|| --- Comment #15 from Josef Moravec --- Created attachment 114441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114441&action=edit Bug 27124: JS error "select2Width is not defined" This patch changes the default width paramter passed to the select2 plugin. This allows the basic MARC editor's Select2 widgets to be styled differently than on other pages. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. Update: Thanks to Julian for the suggested optimization Signed-off-by: Lucas Gass Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #14 from Josef Moravec --- (In reply to Victor Grousset/tuxayo from comment #12) > I tried even though I don't know well these places ^^" > > > - Basic MARC editor > > Is it cataloguing/addbiblio.pl ? Because I don't have the JS error before > applying the patch. And I don't field a field that look like a Select2. Yes it is addbiblio, on this page the error is not shown, it's the only one page using select2 which does not has this error > > - Authority editor > > Which field? I bet you should define some authorized value category to a field manually... I've done it that way, because it was easier to me than trying to find some defined by default (which maybe even don't exist) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Kelly McElligott changed: What|Removed |Added Attachment #114241|0 |1 is obsolete|| --- Comment #8 from Kelly McElligott --- Created attachment 114440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114440&action=edit Bug 26208: Perform batch checkin/renewals serially rather than asynchronously The issue here seems to be that when multiple requests hit at once they may not register that the renewal performed by the request should lift restrictions on the account. To mitigate this we can simply perform the renewals one after the other. To test: 1 - have multiple overdue items on one patron 2 - run overdues.pl with triggers set to generate a restriction 3 - renew all overdues with the Renew All button 4 - restriction is not removed even though patron no longer has overdue items 5 - Apply patch 6 - Make all items overdue again 7 - Click Renew All 8 - Items are renewed and restriction removed 9 - Checkout items to patron again (overdue or not) 10 - Click 'Select all' in checkin column 11 - Click 'Renew/Checkin selected items' 12 - Confirm checkin succeeds as before patches Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com --- Comment #17 from Josef Moravec --- QA script passed tests passed code is readable and does have test Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8287] remove filter on checked out from overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Josef Moravec changed: What|Removed |Added Attachment #114260|0 |1 is obsolete|| --- Comment #16 from Josef Moravec --- Created attachment 114439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114439&action=edit Bug 26634: Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
