[Koha-bugs] [Bug 27284] New: We are anonymous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27284 Bug ID: 27284 Summary: We are anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: soulfisio...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 114538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114538&action=edit SoulFision -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27283] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27283 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Hshehehehhehe |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27283] New: Hshehehehhehe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27283 Bug ID: 27283 Summary: Hshehehehhehe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ayarsj...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 114537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114537&action=edit Hsheueheheh -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 --- Comment #7 from Alvaro Cornejo --- (In reply to Fridolin Somers from comment #6) > if ( $metadata & $metadata !~ "") > > second test is useless I think, > if ($metadata) with skip undefined, empty string and 0 Yes, I thought that but with only one of the tests there are still "undefined" variable errors. Not sure why, but with both tests error does not show anymore -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in||19.05.17 --- Comment #13 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25811] authentication.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 --- Comment #29 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #1) > Reproduced after: > - first try > - 14 tries > - first try Should be fixed with bug 27055, the whole test suite was stable during more than a whole night of looping. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #5 from Victor Grousset/tuxayo --- I thought searching with ES6 would be broken by default. And thus that some tests would fail. Because the syspref would allow to choose to have ES 6 working or ES 5 working and would default to ES 5. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
--- Comment #22 from Victor Grousset/tuxayo ---
Got a conflict when backporting from 20.05.x to 19.11.x
Tried to fix by selecting the 3rd section (Bug 26536: Assignment fix)
<<< HEAD
$payment_id = $account->pay(
||| parent of 6d302b741c (Bug 26536: Assignment fix)
$pay_result = $payment_id = $account->pay(
===
$pay_result = $account->pay(
>>> 6d302b741c (Bug 26536: Assignment fix)
{
amount => $total_paid,
library_id => $library_id,
note => $note,
payment_type => $payment_type,
interface=> C4::Context->interface,
payment_type => $payment_type,
cash_register => $registerid
}
);
$payment_id = $pay_result->{payment_id};
}
print
$input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber&payment_id=$payment_id&change_given=$change_given");
}
}
But when writing off, I got this error:
Could not compile /kohadevbox/koha/members/paycollect.pl: Global symbol
"$pay_result" requires explicit package name
It's not clear either if 19.11.x is affected. I'm not sure I did the test plan
right to confirm the issue.
Does anyone have hints?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in|| Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com --- Comment #20 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in|| --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #10 from Nick Clemens --- Created attachment 114536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114536&action=edit Bug 27166: [20.05.x] Set destination_loc to item->homebranch In bug 21020 we used the issue to fetch the item and then the homebranch. This fails when the item is not issued. We fetch the item already, so we can use it directly In 20.05.x we don't have the item object, so we can just use the SIP transaction item To test: 1 - Have an item belonging to branch A 2 - Check it in via sip at branch B: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item CHESS1 -l FPL -m checkin 3 - The read command is blank and there is a warn about uninitialized data 4 - Apply patch 5 - Restart sip server 6 - Check the item in at branch A using the sip cli emulator 7 - Check it in at branch B 8 - This time the checkin should succeed and the output msg should be included Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Bug 15851 depends on bug 26131, which changed state. Bug 26131 Summary: console errors when attempting to open SCO related system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26785] JS errors in pos/pay.tt in 20.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #1 from Lucas Gass --- Created attachment 114535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114535&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] New: Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Bug ID: 27282 Summary: Print List (shelves.pl) broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In more recent version of Chrome if you go to /cgi-bin/koha/virtualshelves/shelves.pl and attempt to 'Print list' the dialog pops up and immediately closes. We fixed this problem in the OPAC with Bug 24061, the same fix is needed in the staff client on shelves.pl Read Bug 24061 for much of the details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
Martin Renvoize changed:
What|Removed |Added
Depends on||27281
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added Blocks||22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26057] Add Koha::Item::Transfer->cancel method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057
Martin Renvoize changed:
What|Removed |Added
Blocks||27281
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added Depends on||26057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 [Bug 26057] Add Koha::Item::Transfer->cancel method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] New: Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
Bug ID: 27281
Summary: Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment
})` in `C4::Circulation::LostItem`
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
We should remove C4::Circulation::DeleteTransfer.
We can use Koha::Item::Transfer->cancel in preference to it.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize changed: What|Removed |Added Blocks|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Blocks||25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What|Removed |Added Depends on|26618 |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize changed: What|Removed |Added Blocks||22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What|Removed |Added Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|25753 |26618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #113882|0 |1 is obsolete|| --- Comment #67 from Andrew Fuerste-Henry --- Created attachment 114534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114534&action=edit Bug 8137: (follow-up) Fix error on the rules cloning functionality Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #112640|0 |1 is obsolete|| --- Comment #66 from Andrew Fuerste-Henry --- Created attachment 114533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114533&action=edit Bug 8137: (follow-up) Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111369|0 |1 is obsolete|| --- Comment #65 from Andrew Fuerste-Henry --- Created attachment 114532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114532&action=edit Bug 8137: Add default issuing rule for all branches. This patch does the same that for 'Default checkout limit by patron category'. test plan: - Create an issuing rule a patron category and itemtype. make it has priority, - create more permissive issuing rules for all other branches, - check that the priority rule is taken into account for this category and itemtype. Rebased: 2018-03-14, by: Alex Arnaud Rebased: 2020-07-34, by: Arthur Suzuki Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #111368|0 |1 is obsolete|| --- Comment #64 from Andrew Fuerste-Henry --- Created attachment 114531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114531&action=edit Bug 8137: Add Default checkout limit by patron category with priority. This patch add the ability to make a 'Default checkout limit by patron category' rule has priority. When a rule has priority, it overrides all others for the same categorycode. For "normal" rule, the behavior is the same than before (like a default rule if no one is specified at branch level). Rule with priority can only be created on the circulation and fine rules page for *all libraries*. The goal is to allow librarian to limit the total number of checkouts by patron category for all libraries. test plan: - Create a rule with 4 checkouts allowed in default checkout limit table for a patron category and make it has priority, - create more permissive rules for all other branches (at least 5 checkouts allowed), - Checkout items of different branches for a patron with the same category, - Patron should be limited to 4 checkouts https://bugs.koha-community.org/show_bug.cgi?id=8137 Rebased: 2018-03-14, by: Alex Arnaud Rebased: 2020-07-23, by: Arthur Suzuki Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #9 from Caroline Cyr La Rose --- Everything works well with the patch! :) The only things left to correct are the capitalizations and one space: - New Quote should be New quote on the New quote button - text should be Text in the form to add a quote - There should be a space between the trash can and the word Delete on the Delete button - In the staff interface, Quote of the Day should be Quote of the day in the title of the block (this was not introduced by this patch, the capitalization was wrong before) Should these go in another bug? I'm also mentioning this, but it doesn't bother me too much: we lost the ability to import quote from a csv and we lost the ability to select multiple quotes to delete. I'll leave it to QA to decide if those two functions are essential and should be re-added. Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #8 from Caroline Cyr La Rose --- Test plan : 1) In Administration > Global system preferences, enable QuoteOfTheDay in both OPAC and staff interface 2) Go to Tools > Edit quotes for QOTD feature Add new quote 3) Click New quote 4) Enter a Source and a Text 5) Click Submit --> There should be a message saying "Quote added successfully." and the added quote should appear in the table. Edit quote 6) Click Edit next to a quote 7) Change the source or the text 8) Click Submit --> There should be a message saying "Quote updated successfully." and the change should be visible in the table Delete a quote 9) Click Delete next to a quote 10) Click Delete again in the confirmation box --> There should be a message saying "Quote #X was deleted successfully." and the quote should not be in the table anymore View quote in the staff interface 11) Go to Koha' staff interface's home page --> Under the news blocks, there should be a block called "Quote of the day" with a quote and source from the table View quote in the OPAC 12) Go to the OPAC's home page --> Under the news blocks, there should be a block called "Quote of the day" with the same quote. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Caroline Cyr La Rose changed: What|Removed |Added Attachment #114529|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 114530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114530&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 --- Comment #1 from Jonathan Druart --- Created attachment 114529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114529&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] New: Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Bug ID: 27280 Summary: Explanation for "Days mode" is not consistent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 27026 We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 [Bug 27026] New circulation rule "Days mode" values are not explained anywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart changed: What|Removed |Added Blocks||27280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 [Bug 27280] Explanation for "Days mode" is not consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17320, which changed state. Bug 17320 Summary: MySQL 5.7 doesn't work well with SQL using '-00-00' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart --- After bug 7806 we will assume that we reached a stable state. Please reopen bug reports if still happened when pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #9 from Jonathan Druart --- Created attachment 114528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114528&action=edit Bug 7806: Fix remaining occurrences of -00-00 We should remove all SQL queries that contain -00-00 and finally assume we do not longer have such value in our DB (for date type) We already dealt with such values in previous update DB entries. The 2 added by this one haven't been replaced already. The code will now assume that either a valid date exist, or NULL/undef. Test plan: QA review is needed and test of the different places where code is modified. Not sure about the change from reports/issues_avg_stats.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- I've tested this myself now and am happy with the result.. signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What|Removed |Added Attachment #113600|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 114527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114527&action=edit Bug 26997: Remove -00-00 from aqorders.datecancellationprinted This patch remove the -00-00 from the WHERE condition from ordered.pl and spent.pl to prevent an error under MySQL 8 It also fixes the wrong values in DB (if possible, ie. under other DBMS that MySQL 8) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What|Removed |Added Attachment #113495|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 114526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114526&action=edit Bug 26997: Fix upgrade process under MySQL 8 If you are coming from an old version of Koha, you may face an upgrade error for the SQL query using -00-00. The idea was to fix it, but actually the DBMS will raise an error (not blocking the upgrade process however). We can hide them to not cause confusion Errors are like: DBD::mysql::db do failed: Incorrect date value: '-00-00' for column 'suggesteddate' at row 1 [for Statement "UPDATE suggestions SET suggesteddate = '1970-01-01' WHERE suggesteddate = '-00-00';"] at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23312. Test plan: Checkout an old version of Koha (3.20, not older) Insert a dump, install Koha Checkout a recent version of Koha, apply the patch (or use master) Execute the upgrade process You should not see the errors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What|Removed |Added Blocks||7806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 [Bug 7806] Don't use -00-00 to signal a non-existing date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Depends on||26997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27279] New: "Checked out by" not populated on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Bug ID: 27279 Summary: "Checked out by" not populated on issuehistory.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: severine.que...@bulac.fr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Activating the sypref RecordStaffUserOnCheckout, the librarian who checked out the item is not displayed on "Checkout history" tab on biblio view as it's described in release notes for bug 23916. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||and...@bywatersolutions.com Version(s)|20.11.00|20.11.00, 20.05.07 released in|| --- Comment #21 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27274] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27274 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Summary|Hiii|SPAM CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25026] RaiseError must be set for the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #8 from Emmi Takkinen --- Either "DefaultHoldExpirationdatePeriod" or "DefaultHoldExpirationdateUnitOfTime" was left undefined causing Datetime error. Added missing default values for all sysprefs and clarified test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #65 from Séverine Queune --- (In reply to Jonathan Druart from comment #64) > (In reply to Jonathan Druart from comment #38) > > Séverine, this is how FindDuplicate works so far. If we want to improve its > > behavior we should done it on a separate bug report. It is out of the scope > > of this one. > > See bug 27278. Thanks ! 👍 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What|Removed |Added Attachment #114523|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 114525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114525&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Attachment #114057|0 |1 is obsolete|| --- Comment #7 from Emmi Takkinen --- Created attachment 114524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114524&action=edit Bug 26498: Set default expiration date for holds Koha doesn't automatically set expiration date for holds so they can live in the system forever. This patch adds new sysprefs to control setting of default expiration date for holds. Note that expiration date is only set if input field for it is left blank. To test: 1. Apply patch and update database. 2. Enable syspref "DefaultHoldExpirationdate" and set some values to "DefaultHoldExpirationdatePeriod" and "DefaultHoldExpirationdateUnitOfTime". 3. Add some holds for patron from staff client or OPAC and leave expiration date input field blank. => Holds expiration date should be set according your settings 4. Disable "DefaultHoldExpirationdate" and repeat step 3. => Expiration date shouldn't be set. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What|Removed |Added Attachment #114522|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 114523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114523&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 --- Comment #1 from Kyle M Hall --- Created attachment 114522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114522&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #20 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #19)
> (In reply to Tomás Cohen Arazi from comment #18)
> > (In reply to Jonathan Druart from comment #17)
> > > (In reply to Tomás Cohen Arazi from comment #15)
> > > > (In reply to Jonathan Druart from comment #13)
> > > > > Why does the method take rules in parameter? Why don't we simply
> > > > > build the
> > > > > rules from the pref in the method?
> > > >
> > > > If it was called in a loop, we could reuse the rules. That was the idea.
> > > > Maybe we should read the rules locally if the parameter was not passed
> > > > at
> > > > all (i.e. !exists $params->{rules}).
> > >
> > > What for? Performance?
> > > If we are looping on biblios then it's not that reading the pref and
> > > building the rules that will have an impact on perf. If you are concerned
> > > about that I would cache it at package level (->{_item_hide_rules}).
> > >
> > > I think it's better to prevent calls that will forget to pass the rules,
> > > or
> > > having to update all the callers if we decide to add one rules.
> > >
> > > What do you think?
> >
> > I usually prefer explicit vs. implicit. But not a strong position on this
> > particular case. The 'if passed use it, if not, read it' approach seems to
> > me like the best compromise option. This could be a follow-up bug (it
> > requires new tests, probably adapt the callers)
>
> I don't think it's explicit vs implicit.
> ->filter_by_visible_in_opac is explicit already.
> If you are passing a set of rules then it would be ->filter_by_rules
> As I said I am also concerned about the need to update the callers if rules
> are added.
> If we agree on that it should be done on this bug report, not a follow-up
> bug.
I understand your point, and agree.
I've also reviewed how syspref caching works, and I belive there's no need for
the optimization by design I was thinking about.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Jonathan Druart changed: What|Removed |Added Depends on||14973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What|Removed |Added Blocks||27278 --- Comment #64 from Jonathan Druart --- (In reply to Jonathan Druart from comment #38) > Séverine, this is how FindDuplicate works so far. If we want to improve its > behavior we should done it on a separate bug report. It is out of the scope > of this one. See bug 27278. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 --- Comment #2 from Jonathan Druart --- Created attachment 114521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114521&action=edit Bug 27245: Replace AutoCommit=0 with txn_begin in bulkmarcimport.pl To prevent DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588, line 1. Test plan: Export more than 100 records Use bulkmarcimport (with -commit=10) to import them Modify a record to make the import fail (for instance having a too long lccn) Use bulkmarcimport (with -commit=10) to import them Notice that the import stops but that the imported record are imported (a part from the last batch of 10) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 --- Comment #3 from Jonathan Druart --- Stefan, can you try this patch? (I haven't tested it yet!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 --- Comment #2 from Jonathan Druart --- Created attachment 114520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114520&action=edit Bug 27276: Prevent borrowers-force-messaging-defaults.pl to crash MySQL 5.7 does not allow queries using -00-00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What|Removed |Added Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||27276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '-00-00' even though sql strict mode is dissabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What|Removed |Added Depends on||27276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '-00-00' even though sql strict mode is dissabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What|Removed |Added Severity|critical|major CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED Blocks||7806, 17258 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- It's a bug. Lowering severity a bit however. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 [Bug 7806] Don't use -00-00 to signal a non-existing date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25515] Remove warnings and errors from tests output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What|Removed |Added Depends on||18772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772 [Bug 18772] t/ImportBatch.t noise -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18772] t/ImportBatch.t noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772 Jonathan Druart changed: What|Removed |Added Blocks||25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27087] Allow encoding level comparison on record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 --- Comment #2 from Andrew Fuerste-Henry --- So maybe a broader move to allow match checks to use a comparison other than equals? So we'd set a target subfield in the incoming record, a target subfield in the existing record, and a comparison operator? But the values on the encoding level aren't strictly numeric. "#" is the "best" value, followed by 1-8, then "u" for unknown and "z" for not applicable (https://www.loc.gov/marc/bibliographic/bdleader.html). We could hardcode that hierarchy for encoding level, but it seems likely other bits of MARC have comparably idiosyncratic sets of values. Should the match check setup include a mechanism for telling Koha an order of preference for possible values? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27108] Update team for 21.05 cycle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #12 from Andrew Fuerste-Henry --- Phew! I did ponder this one a while, glad I jumped the right way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
Keywords|release-notes-needed|
--- Comment #19 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #18)
> (In reply to Jonathan Druart from comment #17)
> > (In reply to Tomás Cohen Arazi from comment #15)
> > > (In reply to Jonathan Druart from comment #13)
> > > > Why does the method take rules in parameter? Why don't we simply build
> > > > the
> > > > rules from the pref in the method?
> > >
> > > If it was called in a loop, we could reuse the rules. That was the idea.
> > > Maybe we should read the rules locally if the parameter was not passed at
> > > all (i.e. !exists $params->{rules}).
> >
> > What for? Performance?
> > If we are looping on biblios then it's not that reading the pref and
> > building the rules that will have an impact on perf. If you are concerned
> > about that I would cache it at package level (->{_item_hide_rules}).
> >
> > I think it's better to prevent calls that will forget to pass the rules, or
> > having to update all the callers if we decide to add one rules.
> >
> > What do you think?
>
> I usually prefer explicit vs. implicit. But not a strong position on this
> particular case. The 'if passed use it, if not, read it' approach seems to
> me like the best compromise option. This could be a follow-up bug (it
> requires new tests, probably adapt the callers)
I don't think it's explicit vs implicit.
->filter_by_visible_in_opac is explicit already.
If you are passing a set of rules then it would be ->filter_by_rules
As I said I am also concerned about the need to update the callers if rules are
added.
If we agree on that it should be done on this bug report, not a follow-up bug.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #18 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Tomás Cohen Arazi from comment #15)
> > (In reply to Jonathan Druart from comment #13)
> > > Why does the method take rules in parameter? Why don't we simply build the
> > > rules from the pref in the method?
> >
> > If it was called in a loop, we could reuse the rules. That was the idea.
> > Maybe we should read the rules locally if the parameter was not passed at
> > all (i.e. !exists $params->{rules}).
>
> What for? Performance?
> If we are looping on biblios then it's not that reading the pref and
> building the rules that will have an impact on perf. If you are concerned
> about that I would cache it at package level (->{_item_hide_rules}).
>
> I think it's better to prevent calls that will forget to pass the rules, or
> having to update all the callers if we decide to add one rules.
>
> What do you think?
I usually prefer explicit vs. implicit. But not a strong position on this
particular case. The 'if passed use it, if not, read it' approach seems to me
like the best compromise option. This could be a follow-up bug (it requires new
tests, probably adapt the callers)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #17 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #15)
> (In reply to Jonathan Druart from comment #13)
> > Why does the method take rules in parameter? Why don't we simply build the
> > rules from the pref in the method?
>
> If it was called in a loop, we could reuse the rules. That was the idea.
> Maybe we should read the rules locally if the parameter was not passed at
> all (i.e. !exists $params->{rules}).
What for? Performance?
If we are looping on biblios then it's not that reading the pref and building
the rules that will have an impact on perf. If you are concerned about that I
would cache it at package level (->{_item_hide_rules}).
I think it's better to prevent calls that will forget to pass the rules, or
having to update all the callers if we decide to add one rules.
What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] New: FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Bug ID: 27278 Summary: FindDuplicate uses 'exact' for searching and is too strict Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using FindDuplicate to check for existing records the check for suggestions is too strict. Entering an author's name in direct order: John Jacob Jingleheiner-Schmidt Will not match Jingleheimer-Schmidt, John Jacob Entering partial title: The vixens Will not match: The vixens. A novel. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Shouldn't it be $name-koha:$name-koha? Backups are a sysadmin thing, and there shouldn't be permissions allowing the user to delete them. St first glance. I agree with the proposed root:$name-koha and g+r combination. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #20 from Jonathan Druart --- Shouldn't it be $name-koha:$name-koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #16 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #12)
> Comment on attachment 114279 [details] [review]
> Bug 24254: Add Koha::Items->filter_by_visible_in_opac
>
> Review of attachment 114279 [details] [review]:
> -
>
> ::: Koha/Items.pm
> @@ +70,5 @@
> > +$search_params->{$field}->{'-not_in'} = $rules->{$field};
> > +}
> > +
> > +$search_params->{itemlost}->{'<='} = 0
> > +if C4::Context->preference('hidelostitems');
>
> Where is that <= 0 coming from?
>
> From C4::Search:
> 1919 # hidden because lost
> 1920 if ($hidelostitems && $item->{itemlost}) {
> 1921 $hideatopac_count++;
> 1922 next;
> 1923 }
>
> Remember that -1 is evaluated true.
Good catch! I overlooked the negative values here. All this was very
undocumented, so I'd say we need a regression test for that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254
--- Comment #15 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #13)
> Why does the method take rules in parameter? Why don't we simply build the
> rules from the pref in the method?
If it was called in a loop, we could reuse the rules. That was the idea. Maybe
we should read the rules locally if the parameter was not passed at all (i.e.
!exists $params->{rules}).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27273] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27273 Owen Leonard changed: What|Removed |Added Summary|Hiii|SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #19 from Jonathan Druart --- Adjusted commit date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What|Removed |Added Attachment #114454|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 114519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114519&action=edit Bug 14564: Set permissions on configuration backups This patch sets the group and group read permissions on configuration backups, so that they can be downloaded via the web staff interface. Test plan: 0. Apply the patch 1. cp debian/scripts/koha-dump /usr/sbin/koha-dump 2. koha-run-backups --days 2 --output /var/spool/koha 3. Note *.tar.gz backups in /var/spool/koha/kohadev now have root:kohadev-koha ownership and 640 permissions 4. vi /etc/koha/sites/kohadev/koha-conf.xml 5. Set backup_db_via_tools and backup_conf_via_tools to 1 6. echo 'flush_all' | nc -q 1 memcached 1121 7. koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 9. Click on "Export configuration" 10. Choose a file 11. Click Download configuration 12. Note that *.tar.gz file downloaded correctly Signed-off-by: David Cook Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Why does the method take rules in parameter? Why don't we simply build the > rules from the pref in the method? ie. do we have other places where we have other rules? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
