[Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 --- Comment #1 from David Cook --- We could also remove the following warnings since they're not actually useful: [2020/12/22 07:00:36] [WARN] no query in gettemplate at /kohadevbox/koha/C4/Templates.pm line 206. [2020/12/22 07:00:36] [WARN] no query in themelanguage at /kohadevbox/koha/C4/Templates.pm line 266. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #231 from Josef Moravec --- Created attachment 114586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114586&action=edit Bug 15516: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What|Removed |Added Attachment #114518|0 |1 is obsolete|| --- Comment #230 from Josef Moravec --- Created attachment 114585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114585&action=edit Bug 15516: (follow-up) Fix db structure and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26791 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27293 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27293] New: Refactor C4::Templates and C4::Languages to not use CGI objects directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 Bug ID: 27293 Summary: Refactor C4::Templates and C4::Languages to not use CGI objects directly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If you look through C4::Templates and C4::Languages, you'll see CGI objects being passed around a lot. In the end, all that C4::Templates::gettemplate() and C4::Languages::getlanguage need are the "language" param and the "KohaOpacLanguage" cookie. We should be fetching these appropriately from the CGI or PSGI or whatever context at a higher level and passing back the data rather than the objects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #234 from David Cook --- (Apologies if my above comments came across as rude or disrespectful. I'm not trying to criticize anyone. I'm just really keen to move forward, as I have a library that really wants multiple holds at once functionality ASAP, and I think breaking up the patches might be a good way to move forward.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #229 from Josef Moravec --- (In reply to David Cook from comment #228) > (In reply to Josef Moravec from comment #227) > > I rebased and squashed a bit, but this still must be considered as WIP > > I'll hopefully take a look at this tomorrow. > > Why is it considered a WIP at this point? I do consider i as WIP mainly because, thinks needs to be moved from C4 to Koha namespace (using Koha::Object[s] of course). Second step would to modify hold to by always a hold group (even on only one title). But this could be eventually done on another report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26845] Refactor get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26845 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from David Cook --- I don't think we're going to ever fix it, so I think the only real hope is to eventually replace it via Bug 26791 or equivalent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #21 from David Cook --- *** Bug 26792 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from David Cook --- *** This bug has been marked as a duplicate of bug 26791 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #228 from David Cook --- (In reply to Josef Moravec from comment #227) > I rebased and squashed a bit, but this still must be considered as WIP I'll hopefully take a look at this tomorrow. Why is it considered a WIP at this point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27292] New: TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292
Bug ID: 27292
Summary: TablesSettings.GetColumns() returning nothing creates
unexpected Javascript on request.tt
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
I was rebasing Bug 15565 when I noticed strange Javascript errors.
The following code in master was the actual problem:
columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ',
'circulation', 'table_borrowers', 'json' ) | $raw %]
At the moment in koha-testing-docker, this creates the following Javascript:
"columns_settings_borrowers_table = "
For some reason, this doesn't currently cause a problem because the next line
is blank and that line is followed by "$(document).ready(function() {".
Anyway, there should be data coming back there, so that's something to
investigate...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #233 from David Cook --- On the plus side, rebasing actually exposed a bug in master! So yay! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- Depending on client feedback, I may split out the staff interface code from Bug 15565 and submit it as a separate patch here. I think Bug 15565 suffered scope creep which has made it difficult to rebase and test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #232 from David Cook --- I've put in some effort into rebasing these patches (and skipping many of them), but there's so many different changes that it's difficult to keep it all straight and the existing test plans are chaos. Rather than proceeding with this patch, I reckon that it's smarter to split this patch into separate patches that deal with 1 change at a time (e.g. adding checkboxes to the staff client, adding checkboxes to the OPAC, changing maximum hold logic, etc.) I think that Bug 23457 is a good candidate for adding checkboxes to the staff client, and I think that's probably where I'm going to focus my energy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Mason James changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 from Mason James --- this patch is working well for me with the following patch applied... https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/184 so signing off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Mason James changed: What|Removed |Added Attachment #114005|0 |1 is obsolete|| --- Comment #12 from Mason James --- Created attachment 114584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114584&action=edit Bug 27055: Fix compatibility with newer Firefox+Selenium version Fix "submit is not a function error" A submit button should not be named "submit", in this case, it's id. https://stackoverflow.com/questions/833032/submit-is-not-a-function-error-in-javascript Fix some uses of get_attribute() Fix a fail by setting a global implicit_wait_timeout, default value is 0 in our lib. Other libs set it higher which helps to not have to manually deal with part of the timing issues. Fix: remove usage of click_when_visible() because it doesn't work with elements not in the top of the page. Because they are off screen. Fix: use $driver->quit() in error_handler to not forget an open Firefox. With the current version, it fills /dev/shm and fails with around 5 Firefox opened. Also use quit() it at the end of every script. Fix: filling item fields, to fill only the displayed one (not those with display:none) == Test plan == 1. Update selenium/standalone-firefox to the latest version [1] 2. prove t/db_dependent/selenium/authentication.t 3. It fails with: arguments[0].form.submit is not a function 4. Apply patch 5. Retest 6. Success [1] In koha-testing-docker you can do it with docker-compose.yml: selenium: -image: selenium/standalone-firefox:2.53.1-americium +image: selenium/standalone-firefox Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #114430|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 114583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114583&action=edit Bug 15348: WIP Working on pre-filling values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #231 from David Cook --- (In reply to Aleisha Amohia from comment #230) > I don't have time to get to this right now and probably won't for a while, > but it is on my list. I'm happy to collaborate on it as it's increased in priority here. I was just being grumpy before, but I can try rebasing it now against master. I'm off from Dec 25 through Jan 3, so I suppose there is no rush, but I'm hoping to tick this one off sooner rather than later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #230 from Aleisha Amohia --- I don't have time to get to this right now and probably won't for a while, but it is on my list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #229 from David Cook --- We can trust that commit 1b5635bebd75c418fdda68036e1e91f857cb1e4d was probably made and applied on May 30 2019 as it includes the release notes for 19.05.00. Aleisha posted a comment about patches being rebased on April 15 2019, but the patches conflict with commits from April 11 2019... But then if I go before those I'm still getting lots of conflicts. Without that parent commit or a tonne of work, I don't think anyone can rebase these except Aleisha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #228 from David Cook --- It's actually quite interesting... I just tried `git log --before="2019-04-16"`, which looks good at a glance, but it doesn't include f668fecec3771b633068f89dcead2312471f9425. Yet, f668fecec3771b633068f89dcead2312471f9425 should be before "2019-04-16". Something weird going on there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #227 from David Cook --- (In reply to Jonathan Druart from comment #226) > (In reply to David Cook from comment #225) > > Aleisha, even if you don't squash them, could you let me know the parent > > commit for these patches from your last rebase? > > See https://gist.github.com/jajm/f0b77da1a41b6b1c5ab1 I've reviewed it based on your suggestion, but it doesn't actually work. At least not with git 2.16.4. The git rev-list appears to be random, so returning the first result is like picking a name out of a hat. This can be verified by comparing the results of the following command: `git rev-list -n 15 --before="'Tue, 16 Apr 2019 23:00:05 +'" origin/master | less` Even if the list weren't random, the dates are from patch creation time rather than merge time, so it would still be a shot in the dark. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #26 from David Cook --- (In reply to Johanna Räisä from comment #16) > TEST PLAN: > 1) Add new authority linking to a record. > 2) Verify that the authority records ID is on $9 subfield. > 3) Check index that authority has one record chosen. > 4) Apply the patch. > 5) Check AuthoritySubfieldLink to be 9. > 6) Repeat steps 1, 2 and 3. > 7) Change the preference value > 8) Replace zebradb/marc_defs with new files or/and reset ES configurations. > 9) Add new authority linking to a record. > 10) Verify that the authority records ID is now on the chosen subfield. > 11) Check index again that authority has record chosen. > Could you elaborate on Step 8? I think it would be wise to add an additional example patch (marked with something like DONOTPUSH) with your desired configuration for etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl That'll make it easier for us to test. Otherwise, the tester and QA have to guess at the correct configuration. I think that this sounds like a good change though. Wise to keep the $9 for default, and maybe we can announce a deprecation in favour of moving to $0 at some point... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #25 from David Cook --- (In reply to Johanna Räisä from comment #24) > (In reply to David Cook from comment #23) > > (In reply to Johanna Räisä from comment #21) > > > Do you mean putting Koha's internal link to authority linking subfield? > > > > > > > I'm not 100% sure what you mean, but I think so, yes. > > I meant that the authid would be changed to URI and saved that instead of > integer value. > Sounds good to me. The only thing to keep in mind is that the $9 is currently indexed into the Koha-Auth-Number:w index which does mean that it's normalized and tokenized. This could cause problems if there is an unencoded space in the URI for instance. It might be wise for us to start using a "p" register instead of a "w" register, and to start doing "exact" searches when querying this index... At least if you're using Zebra. I don't know about Elasticsearch... > > Yeah that sounds good to me. So you wouldn't be storing authority records in > > Koha? > > No we won't. > Interesting! Very interesting! > We are making a plugin which fetches the authority via SRU or REST API while > writing it to the field. We have already a similar approach to get > vocabularies > https://github.com/KohaSuomi/Koha/commit/ > 9dec82f3c28b41946f8b301dd9200cc36e92cd35 Sounds interesting. I'd like to hear more as you progress. When you say that the plugin fetches the authority, do you mean that it fetches it, extracts the relevant data, inserts it into the Koha bibliographic record, and then discards the authority record? I think that's such a great idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #114579|0 |1 is obsolete|| --- Comment #33 from Aleisha Amohia --- Created attachment 114582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114582&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org Component|Searching - Zebra |Packaging --- Comment #3 from David Cook --- Actually going to switch the component from "Searching - Zebra" to "Packaging" as that might be more accurate... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #6 from David Cook --- Frido: Bug 27291 may be interesting to you. I think that change would make it a lot easier to monitor the Zebra logs... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 --- Comment #2 from David Cook --- Created attachment 114581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114581&action=edit Bug 27291: Reformat Zebra output logs This patch changes the Zebra output log time format from the default "hh:mm:ss-DD/MM" to the more standard ISO 8601 "%FT%T". This change makes the logs easier to read for both humans and machines. One benefit includes easy searching and sorting. Test plan: 1. cp debian/scripts/koha-zebra /usr/sbin/koha-zebra 2. koha-zebra --stop kohadev 3. koha-zebra --start kohadev 4. ps -efww | grep "zebrasrv" 5. Note "-m %FT%T" in the grep output 6. tail -f /var/log/koha/kohadev/zebra-output.log 7. Run a few searches like http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=ccl%3Dargawarga%3D1 or http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=e 8. Note that the timestamp in the Zebra log is formatted "2020-12-22T00:13:42" instead of like "00:13:42-22/12" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Sarah Daviau changed: What|Removed |Added CC||sdav...@arlingtonva.us --- Comment #7 from Sarah Daviau --- This would be a good way to smooth the process out for both front line staff and on the back end. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 --- Comment #1 from David Cook --- One of the reasons for changing the dateformat is to improve log file monitoring of Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27139 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27291] New: Change datetime format in Zebra logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Bug ID: 27291 Summary: Change datetime format in Zebra logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au At the moment, Zebra logs using a dateformat of "hh:mm:ss-DD/MM". For example, "23:16:22-21/12". I propose that we change it to use the dateformat of "%F %T" or "%FT%T". For example, "2020-12-21 23:16:41" or "2020-12-21T23:21:19" It can be done by adding the following option to zebrasrv: -m "%F %T" or -m "%FT%T" While this option doesn't obviously appear in "man zebrasrv", it does appear in "man yaz-ztest" and the manpage for zebrasrv says that zebrasrv has the same options as "yaz-ztest". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #5 from David Cook --- *** Bug 21287 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21287] Report Zebra search errors to web server logs and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21287 David Cook changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 27139 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21287] Report Zebra search errors to web server logs and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21287 David Cook changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #17 from David Cook --- Question for Phil Ringnalda: Phil, do you know if you're using CHR or ICU indexing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #114503|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 114580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114580&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #9 from Victor Grousset/tuxayo --- As it's an UNIMARC bug and it's getting old, I think it's okay to have a signoff from the same entity, so Didier or someone else at BibLibre, you can sign this off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #114545|0 |1 is obsolete|| --- Comment #32 from Aleisha Amohia --- Created attachment 114579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114579&action=edit Bug 3150: WIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #7 from Andrew Fuerste-Henry --- Kyle, can you please rebase this? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Jeff Gaines changed: What|Removed |Added CC||jga...@arlingtonva.us --- Comment #6 from Jeff Gaines --- It would make sense to set the system to handle this for payments that are not staff mediated. Even for staff-mediated payments, it's one less thing for staff to do (or forget to do). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Depends on|27269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia changed: What|Removed |Added Blocks|3150| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the|This patch introduces an|This patch introduces an release notes|efficient way of filtering |efficient way of filtering |Koha::Items result sets, to |Koha::Items result sets, to |hide items that |hide items that that |OpacHiddenItems determines |shouldn't be exposed on |shouldn't be exposed on |public interfaces. |public interfaces. | ||Filtering is governed by ||the following system ||preferences. Two helper ||methods are added to handle ||each of them: ||- ||OpacHiddenItems: ||Koha::Items->filter_out_opa ||chiddenitems is added to ||handle this. ||- ||hidelostitems: ||Koha::Items->filter_out_los ||t is added to handle this. || ||Some patrons have ||exceptions so ||OpacHiddenItems is not ||enforced on them. That's ||why the new method [1] has ||an optional parameter that ||expects the logged in ||patron to be passed in the ||call. || ||[1] ||Koha::Items->filter_by_visi ||ble_in_opac CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
--- Comment #24 from Victor Grousset/tuxayo ---
After applying the patch , while restarting the services, I have a compilation
issue.
root@kohadevbox:koha((6982680ae9...))$ restart_all
Restarting Apache httpd web server: apache2.
Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:.
Stopping Z39.50/SRU daemon for kohadev:.
Stopping Koha worker daemon for kohadev:.
Stopping Koha indexing daemon for kohadev:.
Starting Plack daemon for kohadev:.
Starting Z39.50/SRU daemon for kohadev:syntax error at
/kohadevbox/koha/C4/Circulation.pm line 3091, near "->errstr;"
Type of arg 1 to List::MoreUtils::any must be block or sub {} (not reference
constructor) at /kohadevbox/koha/C4/Circulation.pm line 4397, near "} )"
Type of arg 1 to List::MoreUtils::any must be block or sub {} (not reference
constructor) at /kohadevbox/koha/C4/Circulation.pm line 4400, near "}) "
> 2 - Confirm that 'Renew all' feature continues to work as expected
Is testing the "Renew all" button in a patron's checkout list enough?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #5 from Tomás Cohen Arazi --- Thinking about this in the context of bug bug 10589: this is a clear use case for bug 26129. - This bug tries to implement a flag on Koha::Patron::Categories. - Bug 10589 pretends to make that flag per-category. This could just be a per-branch configuration for each category, or a global value. This is all covered by bug 26129. This bug and 10589 would just be choosing the right 'keyword' for the configuration entry, and adding the UI (on the categories?) and then using the methods to retrieve the configuration based on the parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #5 from Rebecca Coert --- It would be helpful to have the ability to have a Long Overdue (Lost) items convert to Lost and Paid upon payment. A sys-preference seems the easiest way to make this available for those of us that want it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 114578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114578&action=edit Bug 15448: (follow-up) Adapt to changes on bug 24254 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Added a follow-up to clarify which object threw the exception and explain where the id comes from - feel free to drop if you disagree RM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 --- Comment #10 from Nick Clemens --- Created attachment 114577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114577&action=edit Bug 26171: (QA follow-up) Add table name and object type to message Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What|Removed |Added Attachment #114051|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 114576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114576&action=edit Bug 26171: adapt Koha/Exceptions.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What|Removed |Added Attachment #114050|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 114575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114575&action=edit Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid Bug 23846 added a check for invalid MARCXML in search_for_data_inconsistencies.pl. But the error message does not show the biblionumber of invalid biblio record. Test plan: 1) Import a bibliographic record with invalid XML, you can add non printable characters, like 0x1F (CTRL-V 1F with vim) 2) Run misc/maintenance/search_for_data_inconsistencies.pl 3) Check you see correct biblionumber in error message : Invalid data, cannot decode object (id=xxx, biblionumber=yyy, format=marcxml, schema=zzz, decoding_error=... Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Nick Clemens changed: What|Removed |Added Status|Signed Off |In Discussion CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- I don't think this makes things much better - why do we have an itemnumber that we cannot edit? It would be better to have that in the breadcrumbs or page title, no? Also, it seems the code for supporting multiple image uploads (zip file) has references to itemnumber, but never actually receive/calculate it. In my opinion the bug is that one cannot choose a zip file to upload item covers. When attaching a cover to the biblio we actually can edit the biblionumber, which seems like a bad idea, but we should at least be consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 114574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114574&action=edit Bug 24254: Implement separate filters and add patron param This patch introduces two new methods for stacking filters on Koha::Items: - filter_out_lost _ filter_out_opachiddenitems This two filters are what actually happened inside the filter_by_visible_in_opac. Everything is covered by tests. In the process I added a Koha::Patron param to the method that is internally used to decide if the OPACHiddenItems syspref needs to be honoured or not. This *could* be better done with a fallback to C4::Context->userenv if no param is passed. I decided to leave that part for later, if we really find it would help (e.g. if bug 10589 gets some action and we really need something here to handle that). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #12 from Victor Grousset/tuxayo --- The tests pass in 19.11.x but I have an error message not in 20.05.x kohadev-koha@9ddfdbbbd877:/kohadevbox/koha$ prove t/db_dependent/SIP/Transaction.t t/db_dependent/SIP/Transaction.t .. 7/10 AddReturn error: branch 'SIP2' not found. Reverting to bH8GNQ at /kohadevbox/koha/C4/Circulation.pm line 1844. AddReturn error: branch 'SIP2' not found. Reverting to bH8GNQ at /kohadevbox/koha/C4/Circulation.pm line 1844. t/db_dependent/SIP/Transaction.t .. 9/10 AddReturn error: branch 'SIP2' not found. Reverting to lw0u4bBY02 at /kohadevbox/koha/C4/Circulation.pm line 1844. AddReturn error: branch 'SIP2' not found. Reverting to lw0u4bBY02 at /kohadevbox/koha/C4/Circulation.pm line 1844. t/db_dependent/SIP/Transaction.t .. ok All tests successful. Files=1, Tests=10, 6 wallclock secs ( 0.04 usr 0.00 sys + 4.78 cusr 0.78 csys = 5.60 CPU) Result: PASS That doesn't look good right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Owen Leonard --- Jonathan told me in IRC that one should not be able to "select" a line anymore during the import process because the option to delete has been removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vic...@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- It works :) Completed test plan + fixed "Check an item in" => "Check an item out" (maybe it's actually doable with a checkin) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114547|0 |1 is obsolete|| --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114573&action=edit Bug 27004: Prevent claim resolution to fail If the account of the patron who created a claim is removed, then the claim won't be resolvable. Trying to resolve the claim will result in a 500: [2020/12/21 10:05:55] [ERROR] PUT /api/v1/return_claims/1/resolve: unhandled exception (Koha::Exceptions::Checkouts::ReturnClaims::NoCreatedBy)<<[created_by is mandatory]>> Koha::REST::Plugin::Exceptions::__ANON We should not check if created_by exist when we update an existing hold, only when we create it. Test plan: - Login with patron A - set a value to syspref ClaimReturnedLostValue - Check an item out - Claim returned it - Login with patron B - Delete patron A - Resolve the claim - ERROR in api-error.log an UI never confirming the resolution - apply patch & restart services - Resolve the claim - it works Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #1 from Benjamin Daeuber --- I'm not sure what's in the scope of this bug, but another thing to consider is item type. For example, a suggestion for a movie might reveal the novel adaptation, or vice versa. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26397] opac.scss calls non-existent image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens changed: What|Removed |Added Attachment #114397|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 114572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114572&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26397] opac.scss calls non-existent image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper changed: What|Removed |Added CC|rkui...@roundrocktexas.gov | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13326] Add possibilty to edit purchase suggestion on opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Rhonda Kuiper changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #4 from Rhonda Kuiper --- We have found the ability for patron to delete items even after the item has been ordered a problem especially with the functionality in 20.05 that limits the number of patron suggestion within a specified time period. (MAXTOTALSUGGESTION and NUMBEROFSUGGESTIONDAYS). With this function, if the patron deletes a suggestion after it is no longer in pending status, the NUMBEROFSUGGESTIONDAYS calculation isn't accurate. We ended up removing the Delete function on the OPAC with some jquery. The solution I would suggest is two fold: -If the suggestion is in pending status, they can delete it (or edit as suggested earlier). Rationale: The library staff has not spent any time dealing with the suggestion so there is no time lost or confusion about what the person wants. -If the suggestion in any status other that pending, they can delete it from the OPAC display but what is really happening is the suggestion is archived (using the function from bug 22784). What would display on the OPAC is all non-archived suggestions. This way the suggestion stays in the database and the NUMBEROFSUGGESTIONDAYS calculation will still be accurate along with any other stats a library would like to gather. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27099] Stage for import button not showing up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099
Nick Clemens changed:
What|Removed |Added
Attachment #114428|0 |1
is obsolete||
--- Comment #7 from Nick Clemens ---
Created attachment 114571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114571&action=edit
Bug 27099: Stage for import button not showing up
In the latest version of Chrome, pages where the Humansmg library is
included have a problem where the language footer obscures the bottom of
the page.
The problem traces back to some CSS in the Humanmsg library's CSS file:
html, body {
height: 100%; /* Damn you IE! */
}
Removing the line doesn't have any ill effects that I can see in Chrome
or Firefox, and it fixes the problem in Chrome. IE can be damned.
To test you must have one or more translations enabled in the staff
interface.
- Apply the patch and clear your browser cache if necessary.
- View pages in the staff interface which use the Humansmg library,
e.g.:
- Administration -> System preferences. Choose a category of
preferences which will be numerous enough to require scrolling to
reach the bottom of the page.
- Tools -> Stage MARC records for import. Upload a file to display the
form for staging the import.
- Cataloging -> Advanced MARC editor
On each page the language footer should not obscure the bottom of the
page.
Signed-off-by: Lucas Gass
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27099] Stage for import button not showing up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247
Nick Clemens changed:
What|Removed |Added
Attachment #114467|0 |1
is obsolete||
--- Comment #4 from Nick Clemens ---
Created attachment 114570
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114570&action=edit
Bug 27247: Re-add highlighting to the quote editor
Caused by
commmit 247dca306407ac9568344a0a37aca3bbcffc2468
Bug 23013: Upgrade DataTables in the staff client
which removed
-tr.even.selected td {
-background-color: #D3D3D3;
-}
There was no more highlighting when trying to delete an imported quote, as
there was before
(see screenshot from the manual
https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png)
It was, however, possible to delete imported quotes, you just don't see which
ones you are deleting.
Test plan:
1) Create a CSV with two columns first the name, then the quote (I've attached
a CSV that I've done for testing purposes)
2) Go to Tools > Edit quotes for the QOTD feature
3) Click 'Import quotes'
4) Click 'Browse' and choose the CSV created earlier
5) Click on the id of a couple of quotes. Notice those lintes are highlighted
Signed-off-by: Lucas Gass
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #2 from Martin Renvoize --- I think there's some browser ambiguity here.. I tested on latest Chrome, Firefox and Brave browsers and all worked as expected with this patch... but I'm not entirely confident in my fix... it's a step in the right direction accessibility wise though :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250
Nick Clemens changed:
What|Removed |Added
Attachment #114484|0 |1
is obsolete||
--- Comment #4 from Nick Clemens ---
Created attachment 114569
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114569&action=edit
Bug 27250: Fix stacked event listeners in SMTP delete modal
There is a design issue on the click event listener that makes the modal
get added new event listeners on each row being deleted. This makes the
page call all the event listeners and generates an error.
This patch replaces the flawed logic (adding the event listener inside
the event listener). It makes the event listener be defined at startup
time, and make the .on('click') action just pass information around as
required.
To test:
1. Create at least 2 SMTP servers
2. Open the browser inspector, on the network tab
3. Click "Delete" for server 1
=> SUCCESS: You get a successful message (OK)
4. Click "Delete" for server 2
=> SUCCESS: You get a successful message (OK)
=> FAIL: You get also an alert message about server 1 (KO)
=> FAIL: The inspector shows more than one AJAX call has been made
5. Apply this patch and reload the page
6. Repeat 3-4
=> SUCCESS: Everything goes smooth this time
7. Sign off :-D
Signed-off-by: Jonathan Druart
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #1 from Martin Renvoize --- Created attachment 114568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114568&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updates the inputs for the pay form on the point of sale page to use numeric inputmode. This appears to also fix the validation issue described in the bug report. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What|Removed |Added Attachment #114501|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 114567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114567&action=edit Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What|Removed |Added Attachment #114500|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 114566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114566&action=edit Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #14 from Nick Clemens --- Created attachment 114565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114565&action=edit Bug 27148: (QA follow-up) Calculate default_strong_password correctly Fix a typo lenght for length If category strong password is not set, then we fall back to the preference, but that can be "" - which should be treated as 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What|Removed |Added Attachment #114290|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 114564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114564&action=edit Bug 27148: (follow-up) Fix require_strong variable set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What|Removed |Added Attachment #114235|0 |1 is obsolete|| --- Comment #12 from Nick Clemens --- Created attachment 114563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114563&action=edit Bug 27148: Fix bug on self registration when user category is hidden This patch fixes the bug when there is no patron category available for selection in self registration form. It uses PatronSelfRegistrationDefaultCategory to get patron's password length and strength. To test: 1. Do not apply this patch 2. Allow SeflRegistration, set PatronSelfRegistrationDefaultCategory to a valid patron category and finally add categorycode to PatronSelfRegistrationBorrowerUnwantedField 3. Go to opac and enter self registration form CHECK => There is no patron category available for selection => Password's info alert shows "Password must contain at least undefined characters" 4. Fill the form setting a password and send. CHECH => You get an exception saying "You must provide a patron's category to validate password's strength and length" 5. Apply this patch and restart_all 6. repeat steps 3 and 4 SUCCESS => Password's info alert message shows a number instead of "undefined" => Password's strength and length checks are working => If you change default category's lenght or strength parameter it get's reflected when you refresh the page => When you click send, patron is saved Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Without the patch I'm getting «Already in a transaction» even with a (supposedly) valid MARCXML file with 120 records. I just exported the first 120 records of the sample data in XML. With the patch, with valid or invalid data, it's just importing one record: kohadev-koha@kohadevbox:/kohadevbox/koha$ misc/migration_tools/bulkmarcimport.pl -commit 10 -file 120-records.xml . 1 MARC records done in 0.0640840530395508 seconds kohadev-koha@kohadevbox:/kohadevbox/koha$ misc/migration_tools/bulkmarcimport.pl -commit 10 -file 120-records-one-invalid.xml . 1 MARC records done in 0.0556449890136719 seconds Maybe I'm missing a param from bulkmarcimport.pl? (-b doesn't help) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard changed: What|Removed |Added Attachment #114535|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 114562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114562&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Nick Clemens changed: What|Removed |Added Attachment #114502|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 114561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114561&action=edit Bug 22243: Fix unescaped apostrophe in Z target This patch escapes apostrophes in the z39.50 target name prior to them being embedded in the template. To test: - Create a z39.50 target containing an apostrophe in the title - Note that the Advanced Cataloguer editor does not load - Apply the patch - TEST: Note that the Advanced Cataloguer editor does load Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Nick Clemens changed: What|Removed |Added Attachment #114530|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 114560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114560&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells Signed-off-by: Caroline Cyr La Rose Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
