[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #111 from Lari Taskula --- (In reply to Joonas Kylmälä from comment #110) > I see these message preferences as their own object tied to a patron (not to > a patron's individual message). This would mean the name would be > Koha::Patron::MessagePreference and Koha::Patron::MessagePreferences. Good point. That makes sense. Let's go with that. > As far as I can > tell the table message_attributes is incorrectly named / created, the > columns should be in my opinion in the borrower_message_preferences table. > ... > Koha::Patron::MessagePreference (contains both > borrower_message_preferences and message_attributes with JOIN) This is basically what the current patches do, but without a join. The Message::Preference object has an accessor called "message_name" even though it's not physically part of borrower_message_preferences table. JOIN sounds interesting. But doesn't DBIx require you to use "table.column" key format when referencing to a column of a joined table? That's not very user friendly. Would it work with DBIx's "+as" option? Then we could get rid of the "find_with_message_name" method pointed out in comment #80 by Jonathan. I wonder if it's possible to define the JOIN in DBIx schema file so that we don't have to override search/find/whatever methods manually? While there could be improvement at database level, imo that's outside of this Bug's scope. At database level, I don't think they should be merged either. We need message_attribute for database normalization. borrower_message_preferences could also be improved by splitting it in two; borrower_message_preferences and category_message_preferences (the default category preferences). Anyways I think it's outside of the scope here. > The message_transports seems to contains also unrelated columns to transport > types, namely the is_digest information which seems to be preference of the > patron instead of something that is decided based on the transportation > medium. But maybe you can fit this somehow nicely anyway? If it seems > impossible we could restructure first the messaging preference related > tables. "message_options" would better describe its current data. It should also have a primary key integer. Then borrower_message_preferences columns "message_attribute_id" and "wants_digest" could be replaced with a foreign key to "message_option_id". So, borrower_message_preference would simply be a reference to a borrowernumber and message_option_id (and additionally having the days_in_advance setting). But your suggestion works as well. It's just a matter of selecting where the digest information should be at. > Also see comment #80 from Jonathan, I think it the > $patron->messaging_preferences suggestion is a bit like what I have here but > instead with an object. We can implement the Koha::Patron accessors from comment #80, I've nothing against that. But $patron->messaging_preferences would be an object (of MessagingPreferences class), I'm not sure what you mean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What|Removed |Added Blocks||27318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 [Bug 27318] make shibboleth instructions customizable in the loginModal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What|Removed |Added Depends on||25405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 --- Comment #1 from Lucas Gass --- Created attachment 114755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114755&action=edit Bug 27318: Add ShibbolethLoginInstructions to News This patch adds ShibbolethLoginInstructions as an option in the News Tool so librarians customize the wording within the loginModal To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the OPAC loginModal and make sure something like "If you have a Shibboleth account, please click here to login." is visiible. 4. Apply patch 5. Go to /cgi-bin/koha/tools/koha-news.pl and make a New entry 6. Choose ShibbolethLoginInstructions and enter something like: 'Sign in using: Google' 7. Reload the OPAC and look at the loginModal again, it should show your new login instructions instead of the default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] New: make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Bug ID: 27318 Summary: make shibboleth instructions customizable in the loginModal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If you enable shibboleth for sign on in the OPAC and go to the loginModal the instructions say "If you have a Shibboleth account, please click here to login." That language is confusing to most users who don't know what shibboleth is. This area should be editable via the News Tool so librarians can add their own language here. I have moved some things in the loginModal in Bug 25405 and this would build upon that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What|Removed |Added Attachment #104520|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 114754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114754&action=edit Bug 25405: clearly define local login and shib login sections This patch attempts to clearly seperate local login from shibboleth login in the OPAC loginModal. It includes seperate id's for local and shibboleth to make it easier to customize this login To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the loginModal in the OPAC by clicking 'Log in to your account' in the top right corner. 4. Apply patch, restart all, and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 5. Look at the loginModal again the shibboleth section should be underneath the local login stuff. 6. Inscept the loginModal and make sure there is a for both local_login and shibboleth_login 7. Make sure it all works. 8. Turn Shibboleth back off and restart all. 9. Make sure everything still works and looks good without Shibboleth off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12044] Checkout should not be possible if a patron's fines will block the transaction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- +1, this is confusing. Currently in master: If AllowFineOverride is off, then all staff see a message of "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" when looking at the checkout tab of a patron over the fines limit. The behavior is great! If AllowFineOverride is on, then all staff see the checkout box when looking at the checkout tab of a patron over the fines limit. When a staff member who has force_checkout permission attempts a checkout, Koha gives a confirmation message "Please confirm checkout The patron has a debt of XXX" and the user picks Yes or no. When a staff member who does not have force_checkout permission attempts a checkout, the checkout fails and the staff member gets a message of "Cannot check out The patron has a debt of XXX." If AllowFineOverride is on and the staff member does not have force_checkout permission, I think we should show them the same "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" as when the syspref is off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass changed: What|Removed |Added Attachment #114694|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 114753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114753&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference: New Home 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What|Removed |Added Attachment #114743|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 114752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114752&action=edit Bug 27316: In Elasticsearch mappings use yes/no for sortable In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. Test plan : 1) Without patch, look at Administration > Search engine configuration (Elasticsearch) 2) Look at tab 'Bibliographic records' 3) Look at a row containing 0 and a row containing 1 4) Apply patch 5) Refresh page 6) Check 0 is now 'No' and 1 is now 'Yes' 7) Check creating a new row with 'Yes' or 'No' Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- much more user friendly, thank you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Nice work. I just wonder about get_failed_notices() method in Koha/Notice/Message.pm. It does not use current object. And why using SQL and not the ORM ? Also : Koha::Notice::Message::restrict_patron_when_notice_fails($failed_notice); This is strange. Method restrict_patron_when_notice_fails() should be called on a Koha::Notice::Message object instance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25306] Unnecessary update of framework in ModBiblioMarc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Fridolin Somers --- Sorry does not apply on current master. I get : Applying: Bug 25306: Remove framework paramter from ModBiblioMarc error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 --- Comment #6 from Fridolin Somers --- Bug 20415 removed preference 'UseKohaPlugins', please remove it from your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Needs Signoff |Failed QA --- Comment #5 from Fridolin Somers --- Bug 20145 removed preference 'UseKohaPlugins', please remove it from your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 Holly changed: What|Removed |Added CC||h...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What|Removed |Added Attachment #114483|0 |1 is obsolete|| --- Comment #3 from Fridolin Somers --- Created attachment 114751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114751&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- Great :D Maybe we need some CSS on excluded fields name, grey color for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What|Removed |Added Assignee|alex.arn...@biblibre.com|fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Fridolin Somers changed: What|Removed |Added Attachment #114521|0 |1 is obsolete|| --- Comment #5 from Fridolin Somers --- Created attachment 114750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114750&action=edit Bug 27245: Replace AutoCommit=0 with txn_begin in bulkmarcimport.pl To prevent DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588, line 1. Test plan: Export more than 100 records Use bulkmarcimport (with -commit=10) to import them Modify a record to make the import fail (for instance having a too long lccn) Use bulkmarcimport (with -commit=10) to import them Notice that the import stops but that the imported record are imported (a part from the last batch of 10) Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 --- Comment #4 from Fridolin Somers --- For me its ok, works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #9 from Martin Renvoize --- OK, reading the followup highlighted some further issues.. I think during a rebase somewhere we ended up with duplication of code blocks causing random issues. I've cleaned up the duplication in the final patch. I'm not entirely sure we need the 'on_editing' option added to the $Price filter of the readonly field, but I may be wrong there.. I not Nick you added it back in so I'm happy to defer.. not sure it makes much difference in this case. So.. all in all.. back to NQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #8 from Martin Renvoize --- Created attachment 114749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114749&action=edit Bug 27290: Clean up validation It seems we had the validator instantiated twice and we used a mix of validation of required at form element level and in JS instantiator. This patch moves the rules to consistently apply at the instantiation and removes the duplicate lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114671|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 114748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114748&action=edit Bug 27290: (follow-up) fix filters - make register required Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114670|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 114747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114747&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updates the inputs for the pay form on the point of sale page to use numeric inputmode. This appears to also fix the validation issue described in the bug report. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master --- Comment #4 from Tomás Cohen Arazi --- Pushed, to end the year with happy Jenkins. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master --- Comment #16 from Tomás Cohen Arazi --- Pushed, to end the year with happy Jenkins. Thanks everyone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114745|0 |1 is obsolete|| --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114746&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t Signed-off-by: Tomas Cohen Arazi Edit: I fixed the indentation of the test label. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.01 released in|| --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27099] Stage for import button not showing up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.01 released in|| --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114745&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t Signed-off-by: Tomas Cohen Arazi Edit: I fixed the indentation of the test label. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.01 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.01 released in|| --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.01 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Not sure this was the best way to fix. There are only a few places with 'html_entity' filter. Other places use double-quotes for JS strings and html TT filter replaces double-quotes with " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114744|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.01,20.05.07 |21.05.00,20.11.01,20.05.07, released in||19.11.13 --- Comment #25 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 --- Comment #1 from Fridolin Somers --- Created attachment 114744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114744&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 24519, which changed state. Bug 24519 Summary: Change calculation and validation in Point of Sale should match Paycollect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|ch...@bigballofwax.co.nz|fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Fridolin Somers changed: What|Removed |Added Blocks||27317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What|Removed |Added Depends on||27127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 [Bug 27127] Wrong display of messages if there was only 1 record modified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] New: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Bug ID: 27317 Summary: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #15 from Fridolin Somers --- (In reply to Nick Clemens from comment #14) > (In reply to Fridolin Somers from comment #13) > > Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm : > > > > https://bugs.koha-community.org/bugzilla3/attachment. > > cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1 > > > > Is this on purpose ? > > It was not, but shouldn't hurt anything OK no pb. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27316 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20588 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 --- Comment #1 from Fridolin Somers --- Created attachment 114743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114743&action=edit Bug 27316: In Elasticsearch mappings use yes/no for sortable In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. Test plan : 1) Without patch, look at Administration > Search engine configuration (Elasticsearch) 2) Look at tab 'Bibliographic records' 3) Look at a row containing 0 and a row containing 1 4) Apply patch 5) Refresh page 6) Check 0 is now 'No' and 1 is now 'Yes' 7) Check creating a new row with 'Yes' or 'No' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |String patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27316] New: In mappings use yes/no for sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Bug ID: 27316 Summary: In mappings use yes/no for sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #106 from Fridolin Somers --- OK for QA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Tested on Ubuntu 18.04 with Google Chrome, Firefox and Firefox Developer Edition. With the patch applied the Visibility are aligns nicely like all the other options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What|Removed |Added Attachment #114718|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 114742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114742&action=edit Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27314] Update default Elastic mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 --- Comment #1 from Katrin Fischer --- +1 I'd love to see good defaults for the libraries just starting out with Elasticseach! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27314] Update default Elastic mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
