[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

--- Comment #5 from Lucas Gass  ---
Created attachment 115715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115715=edit
Bug 26942: Allow style and link tags in NewsEditor TinyMCE

To Test:
-Make sure the sys pref 'NewsToolEditor' is set to TinyMCE
-Go to any news item and add this line:  https://fonts.googleapis.com/css?family=Open+Sans” rel=“stylesheet">
-Save the news item
-Re-open the same news item again in TinyMCE.
-The editor has removed that line. Annoying!
-Apply patch
-Try again, the  should stay now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27339] Display opac notes and opac messages on check-in

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27339

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
Hi Didier,

I'm just curious why we display the OPAC message but not the staff internal -
message here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27533] New: Subject Cloud (/opac-tags_subject.pl) - No results with Elasticsearch if subfield present

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27533

Bug ID: 27533
   Summary: Subject Cloud (/opac-tags_subject.pl) - No results
with Elasticsearch if subfield present
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: cbut...@gmail.com
QA Contact: testo...@bugs.koha-community.org

With Koha 20.11.01 on Ubuntu 18.04 running Elasticsearch 6x, links generated on
the subject cloud page (/opac-tags_subject.pl) using the
./build_browser_and_cloud.pl script are broken due to the presence of a
subfield in the query url. 

For example: 

Running /build_browser_and_cloud.pl -b -f 650a -t 650 -c succeeds in creating a
subject list: see from
https://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl

However,

Subjects that include any subfield, generate links like the following:

https://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?idx=su="Capitalism
Political aspects." (Political aspects = 650 subfield x).

Under Zebra, running the same script returned results even if subfields were
present in the field and defined in the script

I tried to adjust the script options -t and -f to include/exclude subfield
definitions in various combinations, but no effect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

--- Comment #20 from Victor Grousset/tuxayo  ---
Can't backport to 19.11.x, a test is failing, help needed if this patch is
wanted in 19.11.x


#   Failed test 'No tests run for subtest "Checkin an in transit item"'
#   at t/db_dependent/SIP/Transaction.t line 338.
# Looks like you failed 1 test of 12.
t/db_dependent/SIP/Transaction.t .. 8/10 
#   Failed test 'do_checkin'
#   at t/db_dependent/SIP/Transaction.t line 339.
DBIx::Class::Row::store_column(): No such column 'biblionumber' on
Koha::Schema::Result::Branch at /kohadevbox/koha/Koha/Object.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27413] Cannot add debarment with batch patron modification tool

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27413

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.11.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.11.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||vic...@tuxayo.net
 Status|Pushed to oldstable |RESOLVED

--- Comment #16 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.11.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27003] action_logs table error when adding an item

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27420] A mistake in bug 5161 leads to some patron attributes appearing without a fieldset

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27420

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.11.x, shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||

--- Comment #10 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531

Lucas Gass  changed:

   What|Removed |Added

 Attachment #115703|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 115714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115714=edit
Bug 27531: Remove type attribute from script tags: Cataloging plugins

This patch removes the no-longer-valid "type" attribute from script tags
found in cataloging plugin templates.

I don't think testing each plugin individually is a reasonable thing to
ask for a test. I think a visual verification of the changes in the
patch should be enough.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27003] action_logs table error when adding an item

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003

--- Comment #21 from Andrew Fuerste-Henry  ---
Follow-up pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27487] Rename system preference reviewson to OPACComments

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487

Lucas Gass  changed:

   What|Removed |Added

 Attachment #115623|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 115713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115713=edit
Bug 27487: Rename system preference reviewson to OPACComments

This patch renames the reviewson system pref to OPACComments

Test Plan:
1. In Koha Administration, search for the reviewson system preferance
2. Note the presence of the reviewson system preferance
3. Apply the patch and run updatedatabase.pl
4. Repeat steps 1 and 2. The reviewson preferenace should be gone
5. Seach for and note the OPACComments system preferance
6. Ensure that the OPACComments system preferance operates correctly, as
if it were reviewson

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27487] Rename system preference reviewson to OPACComments

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27003] action_logs table error when adding an item

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003

--- Comment #20 from Victor Grousset/tuxayo  ---
Missing dependencies for 19.11.x, shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27003] action_logs table error when adding an item

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003

--- Comment #19 from Nick Clemens  ---
Created attachment 115712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115712=edit
Bug 27003: [20.05.x] Fix test failure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27532] New: Add items.itemnotes to holds lists

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27532

Bug ID: 27532
   Summary: Add items.itemnotes to holds lists
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mfue...@hmcpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be very helpful to us if items.itemnotes was a toggle-able column on
the holds queue (view_holdsqueue.pl), and perhaps other holds-related lists in
Circulation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26848] Fix Readonly dependency in cpanfile

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #12 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
Bug 18081 depends on bug 21301, which changed state.

Bug 21301 Summary: Restriction of the informations given by GetRecords ILS-DI 
service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

   What|Removed |Added

 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #45 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.01   |21.05.00,20.11.01,20.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #19 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24470] Set import_status when file used to populate basket in acquisitions

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24470

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196

--- Comment #18 from Nick Clemens  ---
Created attachment 115711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115711=edit
Bug 27196:[20.05.x]  Don't explode if item that is waiting if checked in by SIP

Signed-off-by: Nick Clemens 
Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27404] Update intranet-tmpl/prog/en/modules/labels/label-edit-range.tt for ACC2

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27404

Owen Leonard  changed:

   What|Removed |Added

 Attachment #115375|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 115710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115710=edit
Bug 27404: update file for ACC2

Form has been edited in
intranet-tmpl/prog/en/modules/labels/label-edit-range.tt

Test Plan:
Check that pages work as normal

Sponsored by Catalyst IT

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27404] Update intranet-tmpl/prog/en/modules/labels/label-edit-range.tt for ACC2

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27404

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26926] Omnibus: Update all occurrences of to apply ACC2 coding guideline

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27384] Manual typo: OpacSuppression is about records, not items

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27384

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27520] Adding new itemtype images to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520

--- Comment #4 from Owen Leonard  ---
Created attachment 115709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115709=edit
Bug 27520: (follow-up) Add copy of images to carredart icons in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27520] Adding new itemtype images to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27521] Add new item type headset image for carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521

--- Comment #3 from Owen Leonard  ---
Created attachment 115708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115708=edit
Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27521] Add new item type headset image for carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27413] Cannot add debarment with batch patron modification tool

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27413

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27515] Elasticsearch: search for singular/plural form / stemming

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515

Katrin Fischer  changed:

   What|Removed |Added

Summary|Search for singular/plural  |Elasticsearch: search for
   |form|singular/plural form /
   ||stemming
  Component|Searching   |Searching - Elasticsearch
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

--- Comment #7 from Katrin Fischer  ---
I think it doesn't apply for Elasticsearch, but not completely sure. Changing
component and adding a hint to the description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27515] Search for singular/plural form

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515

--- Comment #6 from Katrin Fischer  ---
Hi Christopher, as I said, I think the stemming feature already does this.
Please try it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522

Owen Leonard  changed:

   What|Removed |Added

 Attachment #115706|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 115707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115707=edit
Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522

--- Comment #4 from Owen Leonard  ---
Created attachment 115706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115706=edit
Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC

https://bugs.koha-community.org/show_bug.cgi?id=27505

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27505] Add new item type controller image for carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505

--- Comment #5 from Owen Leonard  ---
Created attachment 115705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115705=edit
Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27505] Add new item type controller image for carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523

--- Comment #3 from Owen Leonard  ---
Created attachment 115704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115704=edit
Bug 27523: (follow-up) Add copy of image to carredart in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531

--- Comment #1 from Owen Leonard  ---
Created attachment 115703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115703=edit
Bug 27531: Remove type attribute from script tags: Cataloging plugins

This patch removes the no-longer-valid "type" attribute from script tags
found in cataloging plugin templates.

I don't think testing each plugin individually is a reasonable thing to
ask for a test. I think a visual verification of the changes in the
patch should be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22956] Omnibus: Remove type attribute from script tags

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956

Owen Leonard  changed:

   What|Removed |Added

 Depends on||27531


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531
[Bug 27531] Remove type attribute from script tags: Cataloging plugins
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27531] New: Remove type attribute from script tags: Cataloging plugins

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531

Bug ID: 27531
   Summary: Remove type attribute from script tags: Cataloging
plugins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 22956

This patch will remove the obsolete "type" attribute from 

[Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329

Daphne Hoolahan  changed:

   What|Removed |Added

 CC||d...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||

--- Comment #8 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27356] Don't hide the SMTP servers table when last displayed is deleted

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27356

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #8 from Andrew Fuerste-Henry  ---
Missing dependencies, not backported to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||

--- Comment #15 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27518] Allow definition of default value in Cities and Towns

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27518

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27529] Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

--- Comment #2 from Lisette Scheer  ---
(In reply to Andrew Fuerste-Henry from comment #1)
> The behavior with hold groups should mirror the behavior without them. If we
> set hold_fulfillment_policy to Any Library and OPACAllowUserToChooseBranch
> to not allowed, Koha defaults OPAC holds to the patron's home library for
> the pickup location. So when hold_fulfillment_policy is set to patron's hold
> group, we should do the same and set to the pickup location to the patron's
> home library, which will by definition be in the patron's hold group and
> therefore a valid pickup location.

Agreed, this is what we expected when we set up hold groups.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27529] Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||
 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

--- Comment #8 from Christopher Brannon  ---
(In reply to Andrew Fuerste-Henry from comment #5)
> (In reply to Christopher Brannon from comment #4)
> > What about the three auto renew columns in the Circulation rules?
> 
> I'd argue that's a separate question/issue - removing an option in the
> patron record vs entirely hiding an option from your circ rules. Maybe file
> a separate bug for the option to completely hide auto-renew from the circ
> rules?

I would counter argue that this is not a separate question/issue.  The request
of this bug was a master off switch, not a request to independently hide
individual parts of a feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

--- Comment #7 from Christopher Brannon  ---
(In reply to PTFS Europe Sandboxes from comment #2)
> Created attachment 115446 [details] [review]
> Bug 25029: Add autorenew_checkouts column to preferences json
> 
> Bug 24476 added autorenew_checkouts as a borrower column, intending it to be
> able to be
> hidden if a library was not using the feature.
> 
> When the column chooser was added, this column was not included.
> 
> To test:
> 1 - Search system preferences for "BorrowerUnwantedFields"
> 2 - Click the box to change the value
> 3 - "autorenew_checkouts" is not an option
> 4 - Confirm that you see the option to opt patron out of autorenewal when
> editing patron on staff side
> 5 - Apply patch and restart everythign
> 6 - Search for the syspref again
> 7 - Note that now you can select "autorenew_checkouts"
> 8 - Check the box and save
> 9 - Confirm the opt out option is no longer visible during patron editing
> 
> Signed-off-by: Sally 

I don't know that I agree with this approach.  This patch provides a way to
clean up the mess left behind when a feature is not used.  A straight forward
approach would be to have an option to turn off this feature and have all
related pieces go away.  Instead, we have various options to hide it in
different places.

It doesn't make sense that if a library doesn't want a feature that we have to
go to other controls and hide it.  It should either be on and in use, or off,
and not shown anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27530] Sample patron data should be updated and/or use relative dates

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27530

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27530] New: Sample patron data should be updated and/or use relative dates

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27530

Bug ID: 27530
   Summary: Sample patron data should be updated and/or use
relative dates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Many patrons in the sample file are expired now that we all live in the future.

Ideally we would set the dates relative so that patrons don't start to get too
old or be expired etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27515] Search for singular/plural form

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515

--- Comment #5 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #3)
> A note here: not all languages are as lucky as English where it's about
> added s most of the time :)

Even so, this would be a step in the right direction.  A rule applied for
specific languages that would improve searching.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27515] Search for singular/plural form

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515

--- Comment #4 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #2)
> I believe the Stemming feature with Zebra should already take care of this.
> Is it active in your instance and have you tried some searches?

We are using ElasticSearch, not Zebra.  I have no understanding of the
inner-workings of all of this, but as far as my knowledge goes, this doesn't
apply.  Or am I wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26755] Make the guarantor search popup taller

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27510] Download the report in HTML format

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510

Ivan Dziuba  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Ivan Dziuba  ---
(In reply to Owen Leonard from comment #3)
> I don't see any changes to the template in this patch. Shouldn't there be a
> new menu item under the "Download" button?

Added! Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #22 from Andrew Fuerste-Henry  ---
Missing dependency, not backported to 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27510] Download the report in HTML format

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510

Ivan Dziuba  changed:

   What|Removed |Added

 Attachment #115696|0   |1
is obsolete||

--- Comment #4 from Ivan Dziuba  ---
Created attachment 115702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115702=edit
Bug 27510: Download the report in HTML format

Bug 27510: Download the report in HTML format.

Added to Download list this option.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26755] Make the guarantor search popup taller

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #115700|0   |1
is obsolete||

--- Comment #4 from PTFS Europe Sandboxes  ---
Created attachment 115701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115701=edit
Bug 26755: Make the guarantor search popup taller

This patch changes the dimensions of the popup window in which
guarantors are chosen during the patron edit process.

The patch also removes an obsolete function delcaration for "Dopop"
which is unused.

To test, apply the patch and open a "child" type patron account for
editing.

Click the "Add guarantor" button. This should trigger a popup window.
Eyeball the size of the window, you'll be able to tell that it is
exactly 800 pixels wide.

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17364

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25029

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26755] Make the guarantor search popup taller

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755

--- Comment #3 from Owen Leonard  ---
Created attachment 115700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115700=edit
Bug 26755: Make the guarantor search popup taller

This patch changes the dimensions of the popup window in which
guarantors are chosen during the patron edit process.

The patch also removes an obsolete function delcaration for "Dopop"
which is unused.

To test, apply the patch and open a "child" type patron account for
editing.

Click the "Add guarantor" button. This should trigger a popup window.
Eyeball the size of the window, you'll be able to tell that it is
exactly 800 pixels wide.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26755] Make the guarantor search popup taller

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27529] Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
The behavior with hold groups should mirror the behavior without them. If we
set hold_fulfillment_policy to Any Library and OPACAllowUserToChooseBranch to
not allowed, Koha defaults OPAC holds to the patron's home library for the
pickup location. So when hold_fulfillment_policy is set to patron's hold group,
we should do the same and set to the pickup location to the patron's home
library, which will by definition be in the patron's hold group and therefore a
valid pickup location.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion
 CC||ha...@orex.es

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

--- Comment #4 from Jonathan Druart  
---
This has been developed for a very specific need and I don't know if it has to
be part of Koha core. If people are interested, both the plugin and the code
here will have to be improved (it's not ready yet).

Also we will think how it could be extended for other uses.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

--- Comment #3 from Jonathan Druart  
---
Test plan:
1. Apply the patches
2. Download the "additional contents" plugin at
https://gitlab.com/joubu/koha-plugin-additional-contents/-/releases
3. Install it
4. Configure it
Example:
Create an internal link: https://snipboard.io/vsQadW.jpg
Create an external link: https://snipboard.io/IPsjlz.jpg
Create a content: https://snipboard.io/HT1kxi.jpg
Note that if the URL is filled the content will be ignored.
Note that you can choose "mainpage" or "tools-home" for the "page" input.

The table lists the different contents you created:
https://snipboard.io/YAdKzC.jpg

The appears on the main page: https://snipboard.io/N2IRsK.jpg

Click the links.
You should be redirected correctly.

For the link that point to a specific content you will see:
https://snipboard.io/91ezAG.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22284] Add ability to define groups of locations for hold pickup

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Nick Clemens  changed:

   What|Removed |Added

 Blocks||27529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529
[Bug 27529] Cannot place hold on OPAC if hold_fullfillment_policy is set to
group and  OPACAllowUserToChooseBranch  not allowed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27529] Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

Nick Clemens  changed:

   What|Removed |Added

 Depends on||22284


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
[Bug 22284] Add ability to define groups of locations for hold pickup
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

--- Comment #2 from Jonathan Druart  
---
Created attachment 115699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115699=edit
Bug 27527: Add new page to integrate the content to Koha correctly

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

--- Comment #1 from Jonathan Druart  
---
Created attachment 115698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115698=edit
Bug 27527: Additional content plugin

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27529] New: Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

Bug ID: 27529
   Summary: Cannot place hold on OPAC if hold_fullfillment_policy
is set to group and  OPACAllowUserToChooseBranch  not
allowed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In opac/opac-reserve.pl:
243 # When choosing a specific item, the default pickup library should
be dictated by the default hold policy
244 if ( ! C4::Context->preference("OPACAllowUserToChooseBranch") &&
$itemNum ) {
245 my $item = Koha::Items->find( $itemNum );
246 my $type = $item->effective_itemtype;
247 my $rule = GetBranchItemRule( $patron->branchcode, $type );
248 if ( $rule->{hold_fulfillment_policy} eq 'any' ) {
249 $branch = $patron->branchcode;
250 } else {
251 my $policy = $rule->{hold_fulfillment_policy};
252 $branch = $item->$policy;
253 }   
254 }
255 

$branch = $item->$policy; is problematic for group values


To test:
1 - Set 'Default checkout, hold and return policy' -> 'Hold pickup library
match' to item's hold group or patron's hold group 
2 - Set  OPACAllowUserToChooseBranch to 'Don't allow'
3 - Try to place an item level hold on the opac
4 - Ka-boom
The method Koha::Item->patrongroup is not covered by tests!
The method Koha::Item->itemgroup is not covered by tests!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26755] Make the guarantor search popup taller

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26755

Owen Leonard  changed:

   What|Removed |Added

   Keywords|Academy |
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED
  Component|Patrons |Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27510] Download the report in HTML format

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
I don't see any changes to the template in this patch. Shouldn't there be a new
menu item under the "Download" button?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27528] system design

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27528

--- Comment #1 from Owen Leonard  ---
This definitely requires more details.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16544] Changes to circ rules should be logged

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #4 from Barbara Johnson  ---
This would be really helpful to our library.  In addition to adding logs for
circ/fine rules it would be helpful to be able to access those logs right from
the specific rule on the smart-rules.pl page.  Maybe add a 'logs' or 'history'
button to the actions column.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27528] New: system design

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27528

Bug ID: 27528
   Summary: system design
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: christianfidel...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.02
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] New: Plugin hooks to create additional contents

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

Bug ID: 27527
   Summary: Plugin hooks to create additional contents
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

It would be useful to let plugin create contents that we will integrate into
Koha.

The idea is to have a hook (on the main page for instance) that will retrieve a
list of URL that will be displayed at the end of the page.

The URL could be:
- A link to an external website
- A link to an existing view of Koha
- A link to a specific content

The specific content would be returned by the plugin and displayed nicely
integrated into Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27420] A mistake in bug 5161 leads to some patron attributes appearing without a fieldset

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27420

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||and...@bywatersolutions.com
 Version(s)|21.05.00,20.11.02   |21.05.00,20.11.02,20.05.08
released in||

--- Comment #7 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Tomás Cohen Arazi from comment #6)
> > I expected to see Koha::Item->new_from_marc({  })
> 
> No, the idea is to remove MARC::Record completely when dealing with items.

Yes. When I read the patches, I noticed you were tackling the cataloging form.
But there is also import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #7 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #6)
> I expected to see Koha::Item->new_from_marc({  })

No, the idea is to remove MARC::Record completely when dealing with items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27509] cn_sort value is lost when editing an item without changing cn_source or itemcallnumber

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27509

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27491] Rename system preference opaclanguages to OPACLanguages

2021-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27491

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >