[Koha-bugs] [Bug 25614] "Clear filter" button permanently disabled on ILL request list

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614

David Nind  changed:

   What|Removed |Added

 Attachment #112565|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 115738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115738=edit
Bug 25614: Move ILL request keyword filter to sidebar

On the ILL request list page there are two filters for the table: One in
the sidebar and one configured automatically by the DataTables plugin. I
think these two systems are conflicting somehow to prevent the "clear
filter" button in the table toolbar from working correctly.

This patch doesn't fix the bug but avoids it: Since the filter field in
the table toolbar is duplicating the functionality of the form in the
sidebar, we could hide it and rely on the sidebar filter instead.

To test, apply the patch and go to the ILL requests page in the staff
interface.

 - The table of requests should display without a search form or "clear
   filter" button at the top.
 - The left-hand sidebar form should now have a "keyword" filter option
   which searches any column in the table.
 - Other filter fields should work as before.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25614] "Clear filter" button permanently disabled on ILL request list

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
I have one minor suggestion, if it is possible.

For the export and print lists, in the type column the value is shown as
standard_checkout and onsite_checkout. Ideally these should be shown as
"normal" human readable information, such as Standard checkout or On-site
checkout, instead of the name used by Koha.

Testing notes: 
- To enable the on-site checkout feature, enable the OnSiteCheckouts system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

David Nind  changed:

   What|Removed |Added

 Attachment #115683|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 115737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115737=edit
Bug 27005: Adding a filter in the datatable of opac-readingrecord page

This patch adds a search field and export options to the
patron's checkout history table in the OPAC.

This patch also adds some showing/hiding classes to controls which
should only be seen by users with or without JavaScript: The 
for resorting the table is hidden when JS is enabled. The tabs for
filtering checkouts from on-site checkouts are hidden when JS is
disabled.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Log in to the OPAC as a user who has both regular and on-site
   checkouts.
 - Go to "Your checkout history."
 - The table of checkouts should have controls at the top: A search
   field, "Clear filter," "Copy," "CSV," and "Print."
 - Confirm that the search filter works: Enter some text which will
   return results among regular or on-site checkouts.
   - It should work correctly to filter the results.
   - If you switch tabs, the filter should persist, and correctly filter
 the results under "Checkouts" and "On-site checkouts."
   - The "Clear filter" button should work correctly to clear your
 search.
  - Test the export and print button to confirm that they work for each
table.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21851] Improve style of sidebar forms

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
A nice subtle improvement - looks much nicer!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21851] Improve style of sidebar forms

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851

David Nind  changed:

   What|Removed |Added

 Attachment #115334|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 115736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115736=edit
Bug 21851: Improve style of sidebar forms

This patch makes minor changes to staff client CSS in order to improve
the style of forms in sidebars. It adjusts the style of nested fieldsets
and gives more room to list items (and the form fields they contain).

To test, apply the patch and regenerate the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

 - View pages with forms in the left-hand sidebar, especially:
   - Circulation -> Overdues
   - Tools -> Tags
   - Patrons -> Patrons search results
   - Acquisitions -> Invoices
   - Acquisitions -> Order search results
   - Tools -> Tags

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21851] Improve style of sidebar forms

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525

David Nind  changed:

   What|Removed |Added

 Attachment #115677|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 115735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115735=edit
Bug 27525: Replace "wich" with "with" in batch delete template

This patch corrects two typos: "wich" -> "with."

To test, apply the patch and check the batch delete template
(batchMod-del.tt) and confirm that the two instances of this sentence
are correct:

"Last item for bibliographic record with biblio-level hold on it"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

David Nind  changed:

   What|Removed |Added

 Attachment #115364|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Comment on attachment 115364
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115364
Bug 27395: Add warning to PatronSelfRegistrationDefaultCategory.

I amended the commit message and updated the warning to:

WARNING: Do not use a regular patron category for self registration. If the
misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and
unfinished OPAC self registrations, it will permanently and unrecoverably
delete all patrons that have registered more than
PatronSelfRegistrationExpireTemporaryAccountsDelay days ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #5 from David Nind  ---
Created attachment 115734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115734=edit
Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory

This patch adds a warning to the PatronSelfRegistrationDefaultCategory system
preference to not use a regular patron category for self registration.

If a regular patron category code is used and the cleanup_database cronjob is
setup
to delete unverified and unfinished OPAC self registrations, it permanently and
and unrecoverably deletes all patrons that have registered more than
PatronSelfRegistrationExpireTemporaryAccountsDelay days ago.

It also removes unnecessary apostrophes at the end of two self registration
and modification system preference descriptions.

Test plan:
1. Apply the patch.
2. Check that the warning message for the PatronSelfRegistrationDefaultCategory
   system preference is clear and makes sense.
3. Sign off!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Nind  changed:

   What|Removed |Added

  Text to go in the||This bug fixes the "On
  release notes||shelf holds allowed" rules
   ||so that they work correctly
   ||when using ILS-DI to place
   ||holds.
   ||
   ||The expected
   ||behaviour for "On shelf
   ||holds allowed" settings for
   ||the circulation rules (Koha
   ||administration > Patrons
   ||and circulation >
   ||Circulation and fines
   ||rules) are:
   ||- If set to
   ||"Yes", patrons can place
   ||holds on items currently
   ||checked in.
   ||- If set to "If
   ||any unavailable", patrons
   ||can only place holds on
   ||items that are not
   ||unavailable.
   ||- If set to
   ||"If all unavailable",
   ||patrons can only place
   ||holds on items where *all*
   ||items on the record are
   ||unavailable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Nind  changed:

   What|Removed |Added

 Attachment #114805|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 115733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115733=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved

The expected behaviour for "On shelf holds allowed" setting for the circulation
rules (Koha administration > Patrons and circulation > Circulation and fines
rules):
- Allow holds only on items that are currently checked out or otherwise
unavailable.
- If set to "Yes", patrons can place holds on items currently checked in.
- If set to "If any unavailable", patrons can only place holds on items that
are not unavailable.
- If set to "If all unavailable", patrons can only place holds on items where
*all* items on the record are unavailable.
(Adapted from
https://bywatersolutions.com/education/preparing-for-library-closures)

These rules should also work when using ILS-DI, but currently they don't. This
bug makes sure that the "On shelf holds allowed" rules work correctly when
using ILS-DI to place holds.

Test plan:

1. Enable ILS-DI (set the ILS-DI system preference to Enable).
2. Go to Koha administration > Patrons and circulation > Circulation and fines
rules.
3. Work through steps 4-5 for each of the settings for "On shelf holds allowed"
for all libraries/patron categories/item types:
   . "Yes", "If any unavailable", and "If all unavailable"
4. Staff interface - place a hold on a record with items available for loan,
the rules should work as expected before and after the patch is applied:
   . "Yes"
  ==> information column in the item table displays "Not on hold", the hold
is placed, cancel the hold
   . "If any unavailable" and "If all unavailable"
  ==> the hold is not placed, message is "Cannot place hold. No items are
available to be placed on hold.", red "X" in the hold column and the
information column displays "Not on hold".
5. ILS-DI - place a hold on a record with items available for loan (note:
without the patch, holds can be placed):
   . Query to place a hold using ILS-DI on a title that have all its items
available,
 example query:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=1_id=1_location=127.0.0.1
 ==> Without the patch the hold is placed but it shouldn't be allowed,
cancel the hold
   . Query to place a hold using ILS-DI on an available item,
 example query:
http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem_id=1_id=1_id=1)
 ==> Without the patch the hold is placed but it shouldn't be allowed,
cancel the hold
6. Run the tests prove t/db_dependent/Reserves.t - these should pass.
7. Apply the patch (and flush_memcached and restart_all if using
koha-testing-docker).
8. Run through steps 3-6 again, and note the changes when "If any unavailable"
and "If all unavailable" options are used:
   . For the staff interface: there should be no change in behavour and should
work as expected, for the red "X" in the items table additional text is added
"onShelfHoldsNotAllowed".
   . For ILS-DI: these should now work as expected, with holds not placed, and
this message in the results returned onShelfHoldsNotAllowed (check
to confirm no holds place for either the patron or the item)
   . Tests: should still pass.
9. Sign off.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Nind  changed:

   What|Removed |Added

 Attachment #114804|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 115732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115732=edit
Bug 20985: Unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27527] Plugin hooks to create additional contents

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27515] Elasticsearch: search for singular/plural form / stemming

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook  ---
(In reply to Katrin Fischer from comment #7)
> I think it doesn't apply for Elasticsearch, but not completely sure.
> Changing component and adding a hint to the description.

Yeah at a glance client-side stemming in Koha wasn't implemented for
Elasticsearch. 

It looks like Elasticsearch can be configured to use its own stemmer token
filters though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
I think Andrew is right about keeping separate gender and pronouns, and having
the data being localized. 

Either we should update authorized values or create a new "Local Data" system
which supports locales.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27540] Allow local definition of gender options

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
(In reply to Katrin Fischer from comment #1)
> I think one reason was that the authorised values are still not translatable

Do we have a bug open for that?

I imagine that the way to fix that would be to add a locale column? Initially
we could default to English but build up support for passing in locales.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139

--- Comment #11 from David Cook  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to David Cook from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > The "You did not specify any search criteria." part is incorrect, but the
> > > user is informed something wrong happened.
> > 
> > Hmm, is that something that we want to concede to users? 
> 
> Yes, I think so, and it's what you wanted on comment 0 if I understand
> correctly :)

True although I changed my mind later heh

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #9 from David Cook  ---
(In reply to Jonathan Druart from comment #3)
> Those two patches are a first (POC) step. Lot of code from the controller
> and template must be adjusted and removed.
> 

Do you mean that you're planning to move the new replacement code from
additem.pl and put it in a module?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26048] PSGI Koha does not use custom ErrorDocument pages

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048

--- Comment #30 from David Cook  ---
But in most production situations I don't think that we'd want to show system
generated error messages. It's not a good look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26048] PSGI Koha does not use custom ErrorDocument pages

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048

--- Comment #29 from David Cook  ---
(In reply to Fridolin Somers from comment #27)
> If only we could find a way to display the error in 500.pl.
> Would be so useful for support.

The errors should still be in your web server logs. See
https://metacpan.org/release/Plack/source/lib/Plack/Middleware/HTTPExceptions.pm#L63

In terms of displaying on the screen, we could probably do it a number of ways. 

For instance, we could do our own middleware to catch errors and then throw a
HTTP::Exception and let Plack::Middleware::HTTPException handle it. 

Or we could replace HTTPException with our own middleware which sets an
environmental variable that we then print in the subrequest done by
ErrorDocument. 

Or we could replace both HTTPException and ErrorDocument with a middleware that
renders the template we want and shows the message we want. It wouldn't be very
hard.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.5.1

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

--- Comment #4 from David Nind  ---
Hi Owen.

I've retested and everything seems okay.

The only thing I noticed was that on the Administration > Libraries input form
the Visual Aids and Help buttons are back, everywhere else I could fine those
buttons are not there.

I assume to sign off, I just change the status to signed off?

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26048] PSGI Koha does not use custom ErrorDocument pages

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048

--- Comment #28 from David Cook  ---
(In reply to Nick Clemens from comment #26)
> QA tools complain about authnotrequired in 404, but I think it is okay

I think so. I modelled it off the other 4xx errors in the intranet, so I think
it's a spurious complaint.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #19 from David Nind  ---
The patch no longer applies 8-(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #4 from Katrin Fischer  ---
It had quite severe results here, so I am in favor of warning that is hard to
ignore. It will delete if the cron is set up according to the delay configured.
So unless the delay is very high, deleting patrons is a very sure thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #3 from David Nind  ---
I have read this again, and have come up with some alternative wording:

WARNING: Do not use a regular patron category code for self registration. If
the misc/cronjobs/cleanup_database.pl cronjob is setup to delete unverified and
unfinished OPAC self registrations, it may result in the permanent and
unrecoverable deletion of all patrons that have registered more than
PatronSelfRegistrationExpireTemporaryAccountsDelay days ago.

As this was an academy bug, I'm happy to do a follow up patch, or amend.

It's a bit long, but the consequence of changing this system preference to a
regular patron category code seems quite major.

Also, is "it may result" correct? That is, rather than "it may result" in
deletion, it will result in deletion? Or are there other factors involved?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27091] Document how Elasticsearch is supposed to work and implement respective configurations

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27091

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27540] Allow local definition of gender options

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540

--- Comment #1 from Katrin Fischer  ---
I think one reason was that the authorised values are still not translatable :(
Which means it makes it really hard to work this out for multi-language
installation to always display nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27540

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27540] New: Allow local definition of gender options

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540

Bug ID: 27540
   Summary: Allow local definition of gender options
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 25364 added an "other" option for gender, which is great!
But why are the gender options hardcoded to begin with? We allow each install
to define their own options for borrower titles. We should do the same for
gender (either in a dedicated syspref as we have for title or in an authorized
value).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry  ---
I like the idea of a field for pronouns! However we set it up, it should have
the ability to support a locally-defined list of options.

> Since laws vary wildly about how one's gender is defined I can certainly see
> the use in having both a "legal gender" field and a "preferred gender" field.

I'm hesitant to go with this construction. "Legal/preferred" has a strong
possibility to carry connotations of "real/imagined" for some folks. Further,
we should not overly-conflate gender and pronouns. They're very much
intertwined, but not quite synonymous.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #7 from David Nind  ---
Hi James/Aleisha/Katrin.

I like OpacLists much better than virtualshelves (or AllowLists), so a nice
improvement!

A couple of things I noticed in testing:

1. Should it be OpacLists or OPACLists - the naming of system preferences with
either OPAC or Opac in the name is a bit of a mixed bag! I think I would prefer
OPAC, so it would then be OPACLists.

2. Database update - is there supposed to be a database update for this change?
There is nothing in the patch, so running updatedatabase doesn't do anything.

3. Text for system preference description - Opac should be spelt as OPAC to be
consistent with other descriptions for system preferences. Also "saved lists of
books" - as the lists could include catalog records for many types of things,
maybe a more generic wording could be used, such as records or items. My
suggestion would by: 

"Allow staff and patrons to create and view saved lists of items in the OPAC: "

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27539] Console warnings "Use of uninitialized value in split" on "Holds to pull" page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539

--- Comment #1 from Peter Vashchuk  ---
Created attachment 115731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115731=edit
Bug 27539: fix console warnings "Use of uninitialized value in split"

When items in the database have NULLs for some fields, those are SELECTed as
undefs and those values arrive as strings to be splitted by "split" command,
and that produces undef warnings. That is expected behaviour to not have data
for those fields sometimes, so we just need to add perl's "defaulting" to empty
strings for split.

To reproduce:
1) Place a hold on an item that has an available call number, copy numbers
or enumeration empty.
2) Head to the Holds to Pull page and check the console to see "Use of
uninitialized value in split" errors.
3) Apply the patch.
4) Refresh the Holds to Pull page and check the console again to ensure
that new errors about "Use of uninitialized value in split" weren't added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27539] Console warnings "Use of uninitialized value in split" on "Holds to pull" page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539

Peter Vashchuk  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27539] New: Console warnings "Use of uninitialized value in split" on "Holds to pull" page

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539

Bug ID: 27539
   Summary: Console warnings "Use of uninitialized value in split"
on "Holds to pull" page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: stalkern...@gmail.com
  Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com,
nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27538] Bottom filtering row of "Holds to pull" table do not correlate to other ones

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538

--- Comment #1 from Peter Vashchuk  ---
Created attachment 115730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115730=edit
Bug 27538: fix correlation of fields in Holds to Pull table

Bottom filtering row of "Holds to pull" table do not correlate to other ones,
columns diverged from "Call numbers" cell: it should be under "Available call
numbers" while it's under "Available barcodes", and so on to the last cell
(while number of cells still adjusted).

To reproduce:
1) Head to the Holds to Pull page, check that bottom filtering row shifted
to the left by one, starting from the "Call number" column and don't correlate
to the upper table (for example, "Call numbers" cell should be under "Available
call numbers" while it's under "Available barcodes"), and so on for all cells
till the end of the filtering row.
2) Apply patch.
3) Refresh Holds to Pull page and ensure that all filtering row columns
correlate to other rows columns correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27538] Bottom filtering row of "Holds to pull" table do not correlate to other ones

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538

Peter Vashchuk  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27538] New: Bottom filtering row of "Holds to pull" table do not correlate to other ones

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538

Bug ID: 27538
   Summary: Bottom filtering row of "Holds to pull" table do not
correlate to other ones
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: stalkern...@gmail.com
  Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com,
nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27536] SPAM

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27536

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
Summary|2   |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #355 from Andrew Nugged  ---
Created attachment 115729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115729=edit
Bug 20447: (Follow-up) Regenerate DBIX schema to match with latest DB state

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115658|0   |1
is obsolete||

--- Comment #354 from Andrew Nugged  ---
Created attachment 115728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115728=edit
Bug 20447: DBIX schema changes

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115660|0   |1
is obsolete||

--- Comment #353 from Andrew Nugged  ---
Created attachment 115727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115727=edit
Bug 20447: (follow-up) Correctly list all holdings frameworks in editor

The Template Toolkit expects a ref to array and we passed the array
instead. It caused the listing of holdings frameworks not to show when
there was more than one holdings framework defined.

To test:
 1) Apply patch
 2) Make 3 copies of the default HLD framework
 3) Go to a biblio page and create new holding
 4) Click Settings in the editor page and notice all 3 frameworks are
now listed in the drop-down menu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115659|0   |1
is obsolete||

--- Comment #352 from Andrew Nugged  ---
Created attachment 115726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115726=edit
Bug 20447: (follow-up) Add required metadata field when creating holdings

Since metadata column is mandatory in the holdings_metadata table we
need to define it already when it is first created instead of creating it
first and updating the column immediately after.

This fixes the following error during holdings record creation:
DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a
default value at /kohadevbox/koha/Koha/Objects.pm line 114

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115657|0   |1
is obsolete||

--- Comment #351 from Andrew Nugged  ---
Created attachment 115725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115725=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115656|0   |1
is obsolete||

--- Comment #350 from Andrew Nugged  ---
Created attachment 115724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115724=edit
Bug 20447: Add a batch rebuild script for holdings table

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115655|0   |1
is obsolete||

--- Comment #349 from Andrew Nugged  ---
Created attachment 115723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115723=edit
Bug 20447: Add holding_id to REST API item definition

Allows items to be properly returned, including the holding_id field.

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #115654|0   |1
is obsolete||

--- Comment #348 from Andrew Nugged  ---
Created attachment 115722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115722=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland

https://bugs.koha-community.org/show_bug.cgi?id=22690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #347 from Andrew Nugged  ---
Adding regenerated DBIX::Class Schema with proper checksums:

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763

David Nind  changed:

   What|Removed |Added

 Attachment #114674|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 115721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115721=edit
Bug 23763: Make search on staff and opac use new routine

To test:
1 - Apply patch
2 - Search on staff and opac side
3 - Confirm you can paginate results
4 - Confirm you see 10 pages on pagination if under page 10
5 - Confirm you see 20 pages in pagination if over page 10
6 - Confirm you can go to first or last page

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763

David Nind  changed:

   What|Removed |Added

  Attachment #93824|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 115720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115720=edit
Bug 23763: Create a pagination_bar routine

To test:
prove -v t/Koha/SearchEngine/Search.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine

2021-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/