[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

David Nind  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #11 from David Nind  ---
Patch no longer applies, I will have a go at rescuing it (not sure how to do
exactly, but will try and work it out).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

David Nind  changed:

   What|Removed |Added

 Attachment #115647|Bug-27503-Rename-system-pre |Bug-27503-follow-up-rename-
   filename|ference-virtualshelves-.pat |allowlists-to-opaclists.pat
   |ch  |ch

--- Comment #10 from David Nind  ---
Comment on attachment 115647
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115647
Bug 27503: (follow up) Rename AllowLists to OpacLists

Rename file name for follow up patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

David Nind  changed:

   What|Removed |Added

 Attachment #115647|Bug 27503: Rename system|Bug 27503: (follow up)
description|preference virtualshelves   |Rename AllowLists to
   |to AllowLists   |OpacLists

--- Comment #9 from David Nind  ---
Comment on attachment 115647
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115647
Bug 27503: (follow up) Rename AllowLists to OpacLists

Not sure whether this is the best way - renaming title for the follow up patch
so it is different from the initial patch name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608

--- Comment #5 from Katrin Fischer  ---
Excellent catch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116341|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 116450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116450=edit
Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt

When looking at an accepted suggestion in suggestion.pl, under 'Suggestion
management', the displayed cardnumber in parenthesis is the wrong one.  It
displays the "suggestedby"'s cardnumber instead of the acceptedby.

Test:
- create a suggestion in OPAC or staff client with user A.
- In staff client, go to accept it with User B.
- Click Edit
- Under section "Suggestion management", you have a "Accepted on".
- In the By column, the cardnumber in parenthsis is not the B one.
- Apply patch, refresh.

Looking at the code patch is self-explanatory.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618

--- Comment #4 from Katrin Fischer  ---
We've been asked to remove this input field too by libraries, so really in
favor of this change :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116335|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116449=edit
Bug 27618: Don't show dropdown if PatronSelfRegistrationLibraryList only has
one library

This patch modifies the patron entry form in the OPAC so that if there
is only one library to choose from, the input is hidden and the single
library displays as text.

To test, apply the patch and enable PatronSelfRegistration.

- Modify the PatronSelfRegistrationLibraryList system preference to
  include only one library.
- Go to the self-registratoin page in the OPAC.
- Under "Home library," you should see the library name. If you inspect
  the source you should see the library branchcode in a hidden form.
- Confirm that the form submission includes the correct library
  information.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27618] Don't show dropdown if PatronSelfRegistrationLibraryList only has one library

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27618

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116347|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 116448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116448=edit
Bug 27632: add data-biblionumber attr to OPAC results

To test:
-Apply patch and do an OPAC search that returns several results
-Inscept and look for the class bibiocol
-Make sure it contains a data-biblionumber attr with a value that matches the
biblionumber

Signed-off-by: David Cook 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27632] Add a more easily javascript accessible biblionumber to each record in OPAC results

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
Summary|Add a link for the Hold |Add a link for the hold
   |Ratios to Acquisitions home |ratios to acquisitions home
   |page|page

--- Comment #5 from Katrin Fischer  ---
Hi Owen,
I believe the permission check is not quite right. The hold ratios page is
asking for circulation_remaining_permissions. Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27598] Add UPLOAD as a built-in system authorized value category

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---
This works well for the existing installations, but won't add the value to new
installations. 

Can you please also add it to:

https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/mandatory/auth_val_cat.sql

And write up a short description for the authorised value categories table?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27598] Add UPLOAD as a built-in system authorized value category

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116428|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116447=edit
Bug 27598: Add UPLOAD as a built-in system authorized value category

This patch updates the database so that it includes an "UPLOAD"
authorized value category with the "is_system" flag set to 1.

The upload tool template is updated to add a link to the authorized
value category from the hint which appears if no authorized values exist
in the UPLOAD category.

To test, apply the patch and run the database update.

- If you have manually added an UPLOAD category it should now be
  classified as a system category.
- If you did not have an UPLOAD category it should have been created for
  you.
- With no authorized values in the UPLOAD category, go to Tools ->
  Upload.
  - Logged in as a user with permission to manage authorized values you
should see a note, "No upload categories are defined..." It should
contain a link directly to the UPLOAD category of authorized values.
  - Logged in as a user without authorized value permission you should
see a similar note without the link.
- Add an authorized value in the UPLOAD category and confirm that the
  note disappears.

Signed-off-by: Barbara Johnson 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27605] Add floating toolbar to patron search page

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605

--- Comment #4 from Katrin Fischer  ---
I was a little surprised that the "second" toolbar was the floating one, not
the one with "Patron lists" and "New patron". But the ones floating make more
sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27605] Add floating toolbar to patron search page

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116289|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116446=edit
Bug 27605: Add floating toolbar to patron search page

This patch modifies the patron search results page so that the toolbar
with results-related controls "floats" when the user scrolls down. This
gives access to the controls for adding patrons to a list and for
merging patrons.

Other templates are modified to incorporate a change to the CSS which
changes "#searchheader" to ".searchheader," enabling multiple instances
of a  styled with the .searchheader class.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Go to Patrons in the staff interface.
 - Perform a patron search which will return many results.
 - Scroll down the page far enough to trigger the floating toolbar.
 - Confirm that the toolbar is positioned correctly when paging through
   results.
 - Confirm that the patron list and merge controls still work correctly.
 - Confirm that other pages which used the "#searchheader" id are still
   styled correctly:
   - Catalog search results
   - List contents
   - Patron list contents
   - Add orders from MARC file

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27605] Add floating toolbar to patron search page

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27605] Add floating toolbar to patron search page

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27605

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613

--- Comment #4 from Katrin Fischer  ---
I am not completely sure about this one.

The existing pattern at the moment would be to use  |
.

What is the advantage of the pseudo element? That it can be overwritten using
CSS instead of jQuery? 

I tried to remove the 3rd link out of 4 by using:
$("a:contains('Table')").remove(); 

Sample data: Philippics. I-II / Cicero ; edited by John T. Ramsey.

In this case I end up with || and have no idea how to fix that. Previously I
would just hide the preceeding one with jQuery as well and that would solve he
issue. I am not sure if and how I could do that now.

We often get requests for hiding some or highlighting other URLs, so that's a
common use case for me. Remember: Our records are created in a union catalog,
there are often tons of links, but changing the records locally is not an
option as the union catalog is the primary database.

I am failing this, because I think if we change it on the detail page, we
should really change it in the results list too.

And personally I'd really like to know if you can still hide elements in a nice
way somehow!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #3 from Katrin Fischer  ---
I am not completely sure about this one.

The existing pattern at the moment would be to use  |
.

What is the advantage of the pseudo element? That it can be overwritten using
CSS instead of jQuery? 

I tried to remove the 3rd link out of 4 by using:
$("a:contains('Table')").remove(); 

Sample data: Philippics. I-II / Cicero ; edited by John T. Ramsey.

In this case I end up with || and have no idea how to fix that. Previously I
would just hide the preceeding one with jQuery as well and that would solve he
issue. I am not sure if and how I could do that now.

We often get requests for hiding some or highlighting other URLs, so that's a
common use case for me. Remember: Our records are created in a union catalog,
there are often tons of links, but changing the records locally is not an
option as the union catalog is the primary database.

I am failing this, because I think if we change it on the detail page, we
should really change it in the results list too.

And personally I'd really like to know if you can still hide elements in a nice
way somehow!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27628] Fix minor HTML markup errors in OPAC search results templates

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116333|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116445=edit
Bug 27628: Fix minor HTML markup errors in OPAC search results templates

This patch makes a couple of minor corrections to templates related to
OPAC search results: An errant quote, and invalidly repeating ids.

The #login4tags id is changed to a class, and CSS related to this id
(which was not used) is removed. For consistency, the id is changed to a
class on the detail page as well.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Perform a search in the OPAC. Confirm that the "Log in to add tags"
   link still looks correct at various browser widths.
 - Confirm that it works to trigger the login modal.
 - Validate the source of the page. There should be no errors.

 - View the detail page for a bibliographic record.
 - The "Log in to add tags" link should look correct and work correctly.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27628] Fix minor HTML markup errors in OPAC search results templates

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27633] Double indication of a reference when indicating a series

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633

--- Comment #7 from Katrin Fischer  ---
Thx for the patch - and sorry for missing that one in the first place!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27633] Double indication of a reference when indicating a series

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116430|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 116444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116444=edit
Bug 27633: (bug 15436 follow-up) Fix duplicate of 440$v at the OPAC

Only display a in link, not v that is displayed later.

It has been fixed in different other places by
  commit 81f71d45fe4fee92596ea8d8edb57c602490e9b1
  Bug 15436: Use semicolon between series name and volume

but missed one occurrence.

Test plan:
Add a 440$a and $v and confirm that the display at the OPAC is now the
same as the staff interface.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27633] Double indication of a reference when indicating a series

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27633] Double indication of a reference when indicating a series

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This fixes the display of   |This fixes the display of
  release notes|440$v (Series   |440$v (Series
   |Statement/Added |Statement/Added Entry-Title
   |Entry-TitleTitle -  |- Volume/sequential
   |Volume/sequential   |designation ($v)) in the
   |designation ($v)) in the|OPAC. Before this fix $v is
   |OPAC. Before this fix $v is |included in the title link
   |included in the title link  |and then displayed after
   |and then displayed after|the ;. With the fix $v is
   |the ;. With the fix $v is   |only displayed after the ;
   |only displayed after the ;  |and is not duplicated in
   |and is not duplicated in|the title link.
   |the title link. |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27633] Double indication of a reference when indicating a series

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633

Katrin Fischer  changed:

   What|Removed |Added

Summary|Double indication of a  |Double indication of a
   |reference when indicating a |reference when indicating a
   |series. |series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27643] Add CodeMirror custom syntax highlighting for SQL runtime parameters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643

--- Comment #4 from Katrin Fischer  ---
I like :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27643] Add CodeMirror custom syntax highlighting for SQL runtime parameters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116437|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116443=edit
Bug 27643: Add CodeMirror custom syntax highlighting for SQL runtime parameters

This patch adds some additional configuration to CodeMirror so that
runtime parameters have a distinct color in the CodeMirror SQL editor.

To test, apply the patch and create or edit an SQL report which contains
one or more runtime parameters, e.g. <>, <>,
etc.

Confirm that when editing the SQL, these parameters should appear as
green text. Save your report and view it. The syntax highlighting should
be updated in this view too.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27643] Add CodeMirror custom syntax highlighting for SQL runtime parameters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27643] Add CodeMirror custom syntax highlighting for SQL runtime parameters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27643

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27646] Allow export of acquisitions home and funds table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
I was able to fix the Actions column, but I was not able to remove the
navigation links from the export.

 Expand all
  | Collapse all
  | Hide inactive budgets
  | Show inactive budgets...

These are especially messy when using the "Copy" link.

Can you please have a look? Hopefully an easy fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27646] Allow export of acquisitions home and funds table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646

--- Comment #4 from Katrin Fischer  ---
Created attachment 116442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116442=edit
Bug 27646: (QA follow-up) Add class to not export action column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27646] Allow export of acquisitions home and funds table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646

Katrin Fischer  changed:

   What|Removed |Added

Summary|Allow export of |Allow export of
   |Acquisitions Home table and |acquisitions home and funds
   |Funds table |table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19309] Add ReservesMaxPickUpDelay to the Circulation Matrix

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27637

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27637] Allow ReservesMaxPickUpDelay to be adjusted based on item values

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27637

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19309

--- Comment #1 from Katrin Fischer  ---
Hi Andrew,
there is an older bug about moving this to the circulation conditions:
Bug 19309 - Add ReservesMaxPickUpDelay to the Circulation Matrix 

What do you think of that proposal vs the system preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27635] Add option for patron to view archived suggestions on the OPAC

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27635

--- Comment #3 from Katrin Fischer  ---
Maybe we could offer to "anonymize" too. As suggestions are linked to the acq
process it can be a bit confusing if they disappear suddenly. 

But it might require that we fix the linking (database side) between the
suggestion and the order first :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10142] Unclear which issues show on subscription details issues tab

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10142

Katrin Fischer  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from Katrin Fischer  ---
*** Bug 27617 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27617] Issues tab in subscription-detail.pl page is misleading

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27617

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---
Filed in 2013 - I win ;)

*** This bug has been marked as a duplicate of bug 10142 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6734] Show location in serials history table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734

Katrin Fischer  changed:

   What|Removed |Added

Summary|location in serials history |Show location in serials
   |table   |history table
   Keywords||Academy

--- Comment #1 from Katrin Fischer  ---
We show the library, but not the location, so this is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27616] Manually track claims in Serials module

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27616

--- Comment #1 from Katrin Fischer  ---
Hi David, just to clarify: you mean to set the item claimed, but without
sending an email or exporting a file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #138 from Katrin Fischer  ---
*** Bug 27611 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27611] Allow batch deletion of serials

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27611

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
This feature is already available in 20.05 :)

*** This bug has been marked as a duplicate of bug 17674 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #137 from Katrin Fischer  ---
*** Bug 12157 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12157] Batch delete for serial holdings

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12157

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 17674 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595

Katrin Fischer  changed:

   What|Removed |Added

Summary|Placing Patrons on Hold for |Place holds for patrons on
   |Accepted Purchase   |accepted purchase
   |Suggestions |suggestions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27590] Self-created MARC-Framework deletes content containing german special characters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27590

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Katrin Fischer  ---
You are welcome :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27581] UseICU is a misnamed systempreference

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27581

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Katrin Fischer  ---
Hi David,

> 1. Should it be OpacLists or OPACLists - the naming of system preferences
> with either OPAC or Opac in the name is a bit of a mixed bag! I think I
> would prefer OPAC, so it would then be OPACLists.

I don't have a preference there, but OPACLists makes sense.

> 2. Database update - is there supposed to be a database update for this
> change? There is nothing in the patch, so running updatedatabase doesn't do
> anything.

We definitely need a database update. It looks like something went wrong here,
as the initial patch made many more changes to files and included a database
update. But doesn't have the new name now :(

I believe git bz is to blame. The follow-up had the exact same subject, so one
got overwritten with the other. It also needs to be fixed to reflect the new
name we picked.

> 3. Text for system preference description - Opac should be spelt as OPAC to
> be consistent with other descriptions for system preferences. Also "saved
> lists of books" - as the lists could include catalog records for many types
> of things, maybe a more generic wording could be used, such as records or
> items. My suggestion would by: 
> 
> "Allow staff and patrons to create and view saved lists of items in the
> OPAC: "

Actually, I would much prefer records, as lists can only be used on record
level and this would lead to a lot of wrong translations (I know in English
lists have items, but not the same word in other languages :) )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115499|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27499] serialsUpdate doesn't create all late issues

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27499

--- Comment #2 from Katrin Fischer  ---
I believe it might be the intended behaviour right now - we run this daily. But
I see merit in the other behavior - maybe it could be an option?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27497] Display Koha version in staff interface

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497

--- Comment #26 from Katrin Fischer  ---
I like Barbara's suggestion at the bottom of the page, like "credits".
It also doesn't work for in the top navigation, as this is misleading and we
already have a lot of stuff going on there.

I'd also be happy with the initial patch here showing it in the pull down.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27468] OPACReportProblem not sending the specific URL that problem was reported on

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27468

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Hi Kelly, what was the exact version? There was bug 26127 fixed in 20.05.05. I
am marking duplicate, but please reopen if both Owen's and my comment don't
prove helpful :)

*** This bug has been marked as a duplicate of bug 26127 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127

--- Comment #16 from Katrin Fischer  ---
*** Bug 27468 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27467] Provide a static URL for tables

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467

--- Comment #10 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #9)
> We are starting to modify our tables to use the REST API routes.
> 
> That will replace our GET parameters and users won't be able to share what
> they really see (copy/pasting the URL).
> 
> The first example is parcel.pl, yes. But more will certainly come.

I totally agree here. Haven an option to link to exact spots in Koha is really
great for a lot of things. We use this a lot in reports, but also of course in
support. I'd love if this worked in a transparent way for the datatables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27451] Split opac_news.lang into two distinct fields for location and language

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451

--- Comment #3 from Katrin Fischer  ---
I think Josef is right about the cleaner design and it will also make it a
little nicer to add an 'all languages' like I think we really should have for
the logo and such. It also makes reporting and querying on the data nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395

--- Comment #13 from Katrin Fischer  ---
(In reply to Fridolin Somers from comment #12)
> Enhancement not pushed to 20.11.x

Hi Frido, could you please reconsider this one? We had a library hurt badly by
this one and I'd like to see others not run into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358

--- Comment #17 from Katrin Fischer  ---
I am a little worried about the short list here:

+sub api_privileged_attrs {
+return [
+'checked_out_date',
+'checkouts_count',
+'holds_count',
+'internal_notes',
+'extended_subfields',
+];
+}
+

Can you help me? Just wondering if it also uses the framework visibility, then
I'd be happy already :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27286] Patron picture-upload.pl allows arbitrary file extension during upload

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27286] Patron picture-upload.pl allows arbitrary file extension during upload

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #2 from Katrin Fischer  ---
Resetting to NEW to make this a bit more visible!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27022] Add publisher number (MARC21 028) to OPAC and staff detail pages

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27022

Katrin Fischer  changed:

   What|Removed |Added

Summary|Publisher number 028 does   |Add publisher number
   |not display according to|(MARC21 028) to OPAC and
   |framework settings  |staff detail pages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26878] Add ability to prevent spending against parent funds

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26878

--- Comment #3 from Katrin Fischer  ---
(In reply to Andrew Fuerste-Henry from comment #2)
> Giving this a bump based on conversation in bug 23767 and bug 16126.
> 
> Currently, Koha supports two different conceptions of parent/child funds and
> that ambiguity necessitates complexity in the UI.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693

--- Comment #7 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #6)
> So a global setting, and the option to change that global default on
> receiving?

I think so. Andrew, do you agree or did we miss something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

--- Comment #6 from Tomás Cohen Arazi  ---
So a global setting, and the option to change that global default on receiving?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26693] Add option to update dateaccessioned when receiving an order

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26693

--- Comment #5 from Katrin Fischer  ---
I think it's probably only needed when items are created on order, then we
would want to update on receive. So maybe the checkbox should be on the receive
page when linked items exist?

Also totally agree with Andrew about the global default setting!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26540] Server error when attempting to issue cash credit with UseCashRegisters

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540

Katrin Fischer  changed:

   What|Removed |Added

Summary|Server error when   |Server error when
   |aattempting to issue cash   |attempting to issue cash
   |credit with |credit with
   |UseCashRegisters|UseCashRegisters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

--- Comment #8 from Katrin Fischer  ---
I realize this all might change a bit with 

- RenewalPeriodBase is set to 'current date'.

The issue we had there was that the patrons would renew early and get surprised
by a short (or no) extension of the loan period. I guess displaying a hint
would have been an option "this will only extend your due date by ... days". So
we are basically always using the 'due date' option here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018

--- Comment #7 from Katrin Fischer  ---
I am trying Andrew, but I am not sure either :) I'll try with some examples
too:

1) Library without auto-renewals and without norenewalbefore limit
- RenewalPeriodBase is set to 'date_due'
- renewals allowed > 0
- norenewalbefore  is not set

Patrons would be allowed to renew immediately after checkout to a much longer
loan period than intended. This will take away the chance for other users to
get the items earlier by placing a hold.

2) Library without auto-renewals
- RenewalPeriodBase is set to 'date_due'
- renewals allowed > 0
- norenewalbefore is set to x days before

Patrons and staff can only renew once the items get close to the due date.
Note: if the 'override' renewal doesn't work here yet, it could be nice to have
a way to do that for staff.

3) Library with auto-renewals and without norenewalbefore limit
- RenewalPeriodBase is set to 'date_due'
- renewals allowed > 0
- norenewalbefore  is not set

This used to mean: That the system would "game" itself. The items would be
renewed immediately the first day after checkout. 
So norenewalbefore determined the first day it should try to renew. 

The idea here was to try the auto-renew a few days before the actual date due,
so in case of it failing, the patron would receive the item due notice and have
a change to return the item on time before accumulating fines.

--

After the initial introduction of these features a lot more options were added
to the auto-renew process. The separate notice was added and Bug 19014 was
pushed - I am not sure how that might have changed things. :( It's something
you might have a better idea about.

So my initial comments were referring to the fact, that maybe we would want to
have different settings for manual vs. automatic renewals. I am not stuck to
this idea.

I believe the use case described by Martin is a bit difficult... if the
intention of using auto renewals and holds (instead of just having looong loan
periods) is that holds should have the effect of people having to return items,
renewing "early" seems like going against that? I feel a bit like you can't
have both, but I might lack imagination right now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18441] Add primary, foreign keys to statistics table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441

Katrin Fischer  changed:

   What|Removed |Added

Summary|add primary, foreign keys   |Add primary, foreign keys
   |to statistics table |to statistics table

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18441] add primary, foreign keys to statistics table

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441

--- Comment #2 from Katrin Fischer  ---
I think sometimes it's really useful that the entries are not all 'NULLed' on
deletion of an item, borrower or staff user. Especially with our current 2
table setup. I often have to dig in statistics and action_logs when "strange
things" happen at the circulation desk.

Maybe insted of a FK we could just add an index?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148

--- Comment #13 from Katrin Fischer  ---
Rereading this I wondered:

Maybe we should keep the first issue as is, but rename it "Start issue" or
similar and have a new and different field, perhaps linked to subscription
history, for the first issue published/available in the library if there is a
need for having this information? 

My use case was this:

The subscription start date could have been at the beginning of the year or
even years ago (most here are renewed automatically) and I don't really care
about this date for the predictions.

The "Start issue" would be the one I start predicting with.

The "historical" first issue  would be the first one in my library's
collection.

... and now I wonder if this isn't what the subscription history fields are
already supposed to be used for:

- Check manual history
- Go to the subscription
- Edit the manual history
- Change the subscription start date.

It won't change the start date when editing the subscription, as these fields
are all stored separately in the database. So maybe the solution is ultimately
to make the history more accessible and maybe add any additionally needed
information there?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27629] Filter invoices by library in invoices.pl

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27629

--- Comment #2 from Daphne Hoolahan  ---
The missing invoices are all linked to a basket.  Baskets have authorisedby
column = 0.  What is the significance of authorisedby for this filter?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27630] TestBuilder real number formatting is different to DBI(x)

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #12 from David Nind  ---
Testing notes:
- Applied first patch and ran tests, then applied second patch and ran tests
- Tests pass as per the test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27630] TestBuilder real number formatting is different to DBI(x)

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630

David Nind  changed:

   What|Removed |Added

 Attachment #116427|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 116441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116441=edit
Bug 27630: Update database generated values and format in TestBuilder

To test:
1. prove t/db_dependent/TestBuilder.t
2. Observe success

TODO: Enable the commented-out test when statistics table gets a primary key

Sponsored-by: The National Library of Finland

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27630] TestBuilder real number formatting is different to DBI(x)

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630

David Nind  changed:

   What|Removed |Added

 Attachment #116426|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 116440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116440=edit
Bug 27630: Add tests

This proves different behavior between floats and decimals for values
built by TestBuilder vs values returned by DBI/DBIx.

To test:
1. prove t/db_dependent/TestBuilder.t
2. Observe failure

 Subtest: _gen_real formatting
1..4
not ok 1 - There can be more decimals when the column size allows it.
   Failed test 'There can be more decimals when the column size allows
it.'
   at t/db_dependent/TestBuilder.t line 112.
  got: '10.10'
 expected: '10.10'
not ok 2 - decimal - Builder builds same format as DBIx returns.
   Failed test 'decimal - Builder builds same format as DBIx returns.'
   at t/db_dependent/TestBuilder.t line 118.
  got: '10.10'
 expected: '10.10'
not ok 3 - float - Builder builds same precision as DBIx returns.
   Failed test 'float - Builder builds same precision as DBIx returns.'
   at t/db_dependent/TestBuilder.t line 124.
  got: '10.10'
 expected: '10.1'
not ok 4 - double - Builder builds same precision as DBIx returns.
   Failed test 'double - Builder builds same precision as DBIx
returns.'
   at t/db_dependent/TestBuilder.t line 131.
  got: '10.10'
 expected: '10.1'
 Looks like you failed 4 tests of 4.
not ok 4 - _gen_real formatting
   Failed test '_gen_real formatting'

Sponsored-by: The National Library of Finland

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27630] TestBuilder real number formatting is different to DBI(x)

2021-02-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/