[Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #21 from Jonathan Druart  
---
We answer this problem with the new debian packages: koha-core vs koha-full.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633

--- Comment #57 from Jonathan Druart  
---
The changes from this merge request must be applied to the qa-test-tools repo:
https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27691] Allow HTML in notes for saved SQL reports

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27691

--- Comment #7 from Jonathan Druart  
---
Yes, it's what I meant with "sanitized", HTML tags must be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626

--- Comment #6 from Jonathan Druart  
---
try: r...@example.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27384] Manual typo: OpacSuppression is about records, not items

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27384

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #4 from Caroline Cyr La Rose  ---
I corrected the system preference descriptions for 21.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27382] [Omnibus] Typos in the manual

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382
Bug 27382 depends on bug 27384, which changed state.

Bug 27384 Summary: Manual typo: OpacSuppression is about records, not items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27384

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||This adds a new system
  release notes||preference
   ||CheckPrevCheckoutDelay that
   ||allows to specify a number
   ||of days that is used with
   ||the CheckPrevCheckout
   ||feature to determine, if a
   ||warning should be shown or
   ||not. If the checkin date of
   ||the item that is about to
   ||be checked out is longer
   ||ago than
   ||CheckPrefCheckoutDelay
   ||days, no warning will be
   ||displayed.
   Keywords||Manual

--- Comment #7 from Katrin Fischer  ---
Tried to write release notes, a native speaker might be able to improve them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Text to go in the|This adds the edition   |This adds the edition
  release notes|statement (MARC21 260) to   |statement (MARC21 250) to
   |the card/ISBD views in the  |the card/ISBD views in the
   |Z39.50 search results in|Z39.50 search results in
   |the acquisition and |the acquisition and
   |cataloging modules. |cataloging modules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8287] Improve filter on checked out from overdues

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords||Manual
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user if CheckPrevCheckout is used via SIP2

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add a choice to prevent the |Add a choice to prevent the
   |checkout or warn the user   |checkout or warn the user
   |at the selfcheckout system  |if CheckPrevCheckout is
   |if we use CheckPrevCheckout |used via SIP2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937

--- Comment #6 from Katrin Fischer  ---
Created attachment 116905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116905&action=edit
Bug 26937: (QA follow-up) Rephrase and link CheckPrevCheckoutDelay description

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #113343|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 116904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116904&action=edit
Bug 26937: Add an optional delay to the CheckPrevCheckout syspref.

The CheckPrevCheckout allows to check a borrower's checkout history to see if
the current item has been checked out before.

This patch adds an optional syspref: CheckPrevCheckoutDelay

It allows to specify the maximum number of days since the last checkin
that will trigger CheckPrevCheckout's warning.

Test plan:

 - Apply the patch.

 - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n.

 - Checkout and check-in an item for a patron.

 - Try to checkout the same item.

 - Check that you have a warning:
   "Patron has previously checked out this title: Check out anyway?"

 - Update the returndate column from the old_issues table to have a returndate
   older than n days ago.

 - Try to checkout the same item.

 - Check that you don't have the warning.

 - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709

Katrin Fischer  changed:

   What|Removed |Added

Summary|Batch item modification |Batch item modification
   |tool is missing Save/Cancel |tool is missing Save/Cancel
   |buttons |buttons in Chrome
   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27701] Can't open __LOG_DIR__/opac-error.log (No such file or directory)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27701

--- Comment #8 from David Cook  ---
(In reply to Magnus Enger from comment #7)
> I have seen this too. On a server with lots of instances, one of them had
> this problem. I must confess I fixed it without investigating further. 

Good to know!

Based on the error, my guess is that there must've been a bug in the past that
made the log4perl.conf not get generated correctly, but it went unnoticed. So
in theory it shouldn't affect anyone that wasn't affected by that bug, but it's
tough to know who is affected without checking everyone.

That said... maybe it is worth writing some kind of patch to look for and fix
this problem...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

Summary|Advanced editor: configure  |Configure if biblionumber
   |if biblionumber or control  |or control number is used
   |number is used for saved|for saved files from detail
   |files   |page or advanced
   ||cataloguing editor
  Text to go in the|This enhancement lets you   |This enhancement lets you
  release notes|choose how a record is  |choose how a record is
   |named when saving it as a   |named when saving it as a
   |MARC or MARCXML file using  |MARC or MARCXML file using
   |the advanced cataloguing|the advanced cataloguing
   |editor. 
   |editor or the download
   |
   |option from the staff
   |Using the new   |interface detail page.
   |system system preference|
   |"DefaultSaveRecordFileID"   |Using the new system system
   |choose:
|preference
   |- the bibliographic |"DefaultSaveRecordFileID"
   |record number (the  |choose:
   |default): the file is saved |- the bibliographic
   |as  |record number (the
   |bib-{biblionumber}.{format} |default): the file is saved
   |, or
   |as
   |- the control number|bib-{biblionumber}.{format}
   |(001 field): the file is|, or
   |saved as as |- the control number
   |record-{controlnumber}.{for |(001 field): the file is
   |mat}.   |saved as as
   ||record-{controlnumber}.{for
   ||mat}.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #36 from Katrin Fischer  ---
Created attachment 116903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116903&action=edit
Bug 24108: (QA follow-up) Add staff detail page to syspref description

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #35 from Katrin Fischer  ---
Created attachment 116902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116902&action=edit
Bug 24108: (QA follow-up) Add missing comma in sysprefs.sql

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115359|0   |1
is obsolete||

--- Comment #34 from Katrin Fischer  ---
Created attachment 116901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116901&action=edit
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be
'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115358|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer  ---
Created attachment 116900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116900&action=edit
Bug 24108: (QA follow-up) Adjust wording and use perl for update file

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115357|0   |1
is obsolete||

--- Comment #32 from Katrin Fischer  ---
Created attachment 116899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116899&action=edit
Bug 24108: (follow-up) Fix typo with .xml extension

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115356|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 116898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116898&action=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Trivial patch   |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27691] Allow HTML in notes for saved SQL reports

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27691

--- Comment #6 from Katrin Fischer  ---
Is there a way we could remove HTML elements before uploading to Mana as a
compromise? I believe the tagging feature does "scrubbing" of the input in a
way, maybe that could be useful?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27711] New: Add categories to Public Lists in the OPAC

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27711

Bug ID: 27711
   Summary: Add categories to Public Lists in the OPAC
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: e0464...@cmaisonneuve.qc.ca
QA Contact: testo...@bugs.koha-community.org

Created attachment 116897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116897&action=edit
Exemple of the categories

Hi,

In the Saved Reports section (guided_reports.pl) of KOHA there is an
interesting way to categorize every single report. It would be interesting if
there could be something similar implemented in the Lists (opac-shelves.pl)
section of the OPAC. I've added a screenshot of the desire addition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27691] Allow HTML in notes for saved SQL reports

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27691

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607

--- Comment #5 from Katrin Fischer  ---
I really like this new use case for the diff view :)

I am not sure if people would like to see more patron fields included, like the
the other addresses, but think we could wait and see in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607

--- Comment #4 from Katrin Fischer  ---
Created attachment 116896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116896&action=edit
Bug 27607: (QA follow-up) Make label match patron form: ZIP/Postal code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116534|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 116895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116895&action=edit
Bug 27607: Add the ability to compare patron records during merge process

This patch adds an option to compare two patron records during the
patron merge process. It can't work with more than two patrons, so the
option only appears if one has selected only two patrons to merge.

This patch also adds links to the patron names for opening the patron
record in a new tab.

To test, apply the patch and perform a search for patrons in the staff
client Patrons module.

 - Select two patrons in the list of search results and click "Merge
   selected patrons."
 - On the merge patron records page, confirm that the two patron names
   are links which, when clicked, open the patron details in another
   tab.
 - Click the "Compare patrons" button. A modal window should display
   highlighting the differences in some selected values in the patron
   record.
 - Close the modal and click "Compare patrons" again. It should still
   display correctly.
 - Repeat the same process above but select more than two patrons for
   merging. The "Compare patrons" button should not appear.

Signed-off-by: Barbara Johnson 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633

--- Comment #56 from Katrin Fischer  ---
Reran the QA tools with the dependency applied, but still get:

 FAIL   api/v1/swagger/paths/transfer_limits.yaml
   OK git manipulation
   FAIL   yaml_valid
YAML Error: Invalid element in map


Do I need to install something new or do we need an update to the QA test
tools?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116877|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 116894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116894&action=edit
Bug 27569: Fix ODS export - take empty string into account

If a cell contains an empty string it was not taken into account.

Test plan:
Same as CSV but with ODS

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116876|0   |1
is obsolete||

--- Comment #29 from Katrin Fischer  ---
Created attachment 116893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116893&action=edit
Bug 27569: Change av for 100$2

Switch from "#" to ""

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116875|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 116892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116892&action=edit
Bug 27569: Add tests for ODS export

Looks ok so far

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116874|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 116891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116891&action=edit
Bug 27569: Fix CSV export for biblio frameworks

The CSV import of the biblio frameworks is broken.
A change in LibreOffice resulted in CSV not formatted how the
C4::ImportExportFramework code is expected.
This code is quite broken, it expects all the CSV cells to be quoted.

The "add tests" patch shows the different between what we expected
before this patch, and what is the new version generated by LibreOffice.

Test plan:
Export a biblio framework in CSV
Open it with LibreOffice and save it undef a different name
Create a new biblio framework and use the new file to construct it
Compare the 2 frameworks and make sure they are identical

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116873|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 116890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116890&action=edit
Bug 27569: Add tests

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116872|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 116889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116889&action=edit
Bug 27569: Don't hide errors!

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #116871|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 116888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116888&action=edit
Bug 27569: Remove non mysql code

Remove a bit of the confusion by removing unless code (not related to
mysql)

Signed-off-by: Ron Houk 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626

--- Comment #5 from Katrin Fischer  ---
I tried to test this, but ran into bug 27710 and then into:

Invalid 'from' parameter: root@localhost at
/usr/share/perl5/Exception/Class/Base.pm line 88

KohAdminEmailAdress is filled, but my system not set up to sent email. 

Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27710] New: PatronSelfRegistrationLibraryList can no longer be empty

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27710

Bug ID: 27710
   Summary: PatronSelfRegistrationLibraryList can no longer be
empty
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When leaving PatronSelfRegistrationLibraryList all libraries should be listed.
But now it lists lone and the form cannot be saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27709] New: Batch item modification tool is missing Save/Cancel buttons

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709

Bug ID: 27709
   Summary: Batch item modification tool is missing Save/Cancel
buttons
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: Windows
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Browser compatibility
  Assignee: oleon...@myacpl.org
  Reporter: frak...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 116887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116887&action=edit
Missing button in G. Chrome

When multiple barcodes are loaded to "Batch item modification" at
"/cgi-bin/koha/tools/batchMod.pl" in Google Chrome, on the second page you are
unable to proceed because "Save/Cancel" pair is missing on the bottom left
side.
Tested on 3 different PC, with 2 users (bfu and superadmin) - in FF everything
fine, in GCh not. 
Koha v. 19.05.10.000 (Czech Mutation)
Chrome Version 88.0.4324.146 (Official Build) (64-bit)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27703] Can't navigate in Authorized values

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703

--- Comment #4 from Jonathan Druart  
---
This occurrence might be problematic as well:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt:   


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25954] Header search forms should be labeled

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27703


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703
[Bug 27703] Can't navigate in Authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27703] Can't navigate in Authorized values

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||25954
   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

--- Comment #3 from Jonathan Druart  
---
Caused by 

  commit 38bc9eb2a8c01c8625b1c33c7e098cd0022b2710
  Bug 25954: Replace paragraph tags with labels in header search forms

Owen, can you have a look please? There are 2 elements with id=searchfield on
this page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954
[Bug 25954] Header search forms should be labeled
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27703] Can't navigate in Authorized values

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703

--- Comment #2 from Séverine Queune  ---
Hi Jonathan !
Here is a capture made a few minutes ago on Biblibre's sandbox #1 :
https://prnt.sc/zmai4z
When I select a new category in the menu, it doesn't change.
When the page is slow to charge, I can see a "Submit" button that finally
disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694

--- Comment #7 from Jonathan Druart  
---
I cannot remember exactly but I know it was painful.

The "logic" is in C4::Serials::abouttoexpire, IIRC I tried to hit the first
condition and hardcoded planneddate to be before then after today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886

Timothy Alexis Vass  changed:

   What|Removed |Added

  Text to go in the||Option added to
  release notes||advance_notice.pl and
   ||overdue_notice.pl for
   ||sending notices from owning
   ||or issuing branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697

Jonathan Druart  changed:

   What|Removed |Added

Version|20.05   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697
[Bug 27697] Opening bibliographic record page prepopulates search bar text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||23475
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||n...@bywatersolutions.com

--- Comment #1 from Jonathan Druart  
---
It has been added by bug 23475.

Nick, maybe we should use sessionStorage instead of localStorage?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475
[Bug 23475] Search context is lost when simple search leads to a single record
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27703] Can't navigate in Authorized values

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Hi Séverine, can you be more specific?

I am seeing the "Show category" on this view https://snipboard.io/Cda091.jpg

Do you mean when we edit an authorised value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

--- Comment #46 from Jonathan Druart  
---
Hum

$ perl misc/admin/koha-preferences dump | perl misc/admin/koha-preferences load
It works

$ perl misc/admin/koha-preferences dump > prefs && file prefs
prefs: ASCII text

indeed, but edit URLLinkText, set "✔ ❤️ ★"

$ perl misc/admin/koha-preferences dump > prefs && file prefs
prefs: UTF-8 Unicode text

$ perl misc/admin/koha-preferences dump | perl misc/admin/koha-preferences load
Still works

Edit URLLinkText, it contains the characters in the correct encoding.

Can you try adding
  binmode STDOUT, ':encoding(UTF-8)';
before Dump?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five pieces of information

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||27708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
[Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an
order"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27708] New: Cannot create EDI order if AcqCreateItem value is not "placing an order"

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

Bug ID: 27708
   Summary: Cannot create EDI order if AcqCreateItem value is not
"placing an order"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org
CC: nug...@gmail.com
Depends on: 23926

There was a regression in bug 23926 which causes EDI orders to give internal
server error if AcqCreateItem syspref is set to something other than "placing
an order." The code from patch "Bug 23926: Limit GIR segment to 5 pieces of
info" (f9efa7a9) assumes in the line

> branchcode => $item->homebranch->branchcode,

that we have an Koha object but that is not true when AcqCreateItem is set to
not create an item while placing the order. In that case we manually create
hash representing item which has the key "branch" that contains the branchcode
so the code "$item->homebranch->branchcode" doesn't work because it should be
$item{branch}.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926
[Bug 23926] In EDI Order limit GIR segment to five pieces of information
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #25 from Jonathan Druart  
---
There is a failing test on My8

#   Failed test 'income_grouped arrayref is correct'
#   at t/db_dependent/Koha/Cash/Register/Cashup.t line 223.
# Structures begin differing at:
#  $got->[0]{debit_type}{description} = 'Overdue fine'
# $expected->[0]{debit_type}{description} = 'Account creation fee'
# Looks like you failed 1 test of 29.

The order is different that the one we expect, I think we should order by
created_on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

--- Comment #45 from Julian Maurice  ---
Sorry, but I think there is still a problem with dump/load

If I do
  koha-preferences dump | koha-preferences load

I get an error
  YAML::XS::Load Error: The problem:
invalid trailing UTF-8 octet
  was found at document: 1

If I do
  koha-preferences dump > prefs && file prefs
I get
  prefs: ISO-8859 text, with very long lines

but If I do
  koha-preferences dump -o prefs && file prefs
I get
  prefs: UTF-8 Unicode text, with very long lines

If I remove the call to decode_utf8 in dump subcommand, it works (ie. I get
UTF-8 Unicode in both cases, and dump|load seems to work)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #116885|0   |1
is obsolete||

--- Comment #3 from Joonas Kylmälä  ---
Created attachment 116886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116886&action=edit
Bug 27706: (bug 24488 follow-up) Fix libraries column filter

From commit 2285c2d65752dcc899d3fdcff634e6927a1cbbf0
 Bug 24488: Show correct first patron details on Holds to pull

   $('select', this).change( function () {
-  var filter_value = $(this).val();
-  holdst.fnFilter( filter_value, 5, true );
+  holdst.fnFilter( $(this).child().val(), 5 );
   });

This does not make sense, we need to filter on $(this).val(), it's a
select element.

Test plan:
Place some holds
Hit the pending holds page
Use the "libraries" column filter and confirm that it works correctly

Signed-off-by: Andrew Nugged 
Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706

Andrew Nugged  changed:

   What|Removed |Added

 Attachment #116880|0   |1
is obsolete||

--- Comment #2 from Andrew Nugged  ---
Created attachment 116885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116885&action=edit
Bug 27706: (bug 24488 follow-up) Fix libraries column filter

From commit 2285c2d65752dcc899d3fdcff634e6927a1cbbf0
 Bug 24488: Show correct first patron details on Holds to pull

   $('select', this).change( function () {
-  var filter_value = $(this).val();
-  holdst.fnFilter( filter_value, 5, true );
+  holdst.fnFilter( $(this).child().val(), 5 );
   });

This does not make sense, we need to filter on $(this).val(), it's a
select element.

Test plan:
Place some holds
Hit the pending holds page
Use the "libraries" column filter and confirm that it works correctly

Signed-off-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706

Andrew Nugged  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707

--- Comment #1 from Jonathan Druart  
---
I did some testing and I confirm that the txn is not needed here.

use Koha::Database;
my $schema = Koha::Database->new->schema;
$schema->txn_do(sub {
$schema->txn_do( sub {
my $dbh = $schema->storage->dbh;
say "getting locks";
$dbh->do(q|LOCK TABLE message_queue READ|);
$dbh->do(q|LOCK TABLE message_queue WRITE|);
say "locked!";
sleep 10;
say "unlocking";
$dbh->do(q|UNLOCK TABLES|);
say "unlocked!";
});
});

Start several parallel processes.

Remove the nested txn_do, try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27282] Printing broken in some versions of Chrome

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|release-notes-needed|
  Text to go in the||This adds the edition
  release notes||statement (MARC21 260) to
   ||the card/ISBD views in the
   ||Z39.50 search results in
   ||the acquisition and
   ||cataloging modules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27707

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26208
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27702] contents of 440 subfield v duplicated in OPAC display

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27702

--- Comment #2 from Jesse Savage  ---
Thank you, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27661] Clarify error for message broker

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661

--- Comment #6 from Jonathan Druart  
---
This change is actually not advertised by the patch and not directly linked
with what we are doing here. Can we remove it from the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27707

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26639] Turn auto_savepoint ON

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||27707


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707
[Bug 27707] Renewing doesn't work when renewal notices are enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27707] New: Renewing doesn't work when renewal notices are enabled

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707

Bug ID: 27707
   Summary: Renewing doesn't work when renewal notices are enabled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: joonas.kylm...@helsinki.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Depends on: 26639

Renewing loans doesn't work for patrons who have enabled renewal notices to be
sent to them. To reproduce:

1) Enable RenewalSendNotice 
2) Add some email address to patron and select the email box from the message
preference "Item checkout and renewal" in order to receive renewal emails.
3) Checkout 4 items to the patron (maybe 1 is enough not quite sure)
4) Try to renew the loans in intranet and notice the progress icon circles
forever and in the plack-error.log you have following error:

> DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: 
> DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement 
> "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm 
> line 3590

This bug seems to have started happening after bug 26639 was merged, i.e. AUTO
SAVEPOINT was enabled. I have found a workaround and possibly it is also a
reasonable solution:

In C4/Circulation.pm function SendCirculationAlert there is this comment:

> # LOCK TABLES is not transaction-safe and implicitly commits any active 
> transaction before attempting to lock the tables.

So basically if that comment is true (I have not verified) then it means that
the transaction that has been put around the "LOCK TABLE message_queue READ"
stuff is doing nothing. And here based on the error message we got in
plack-error.log the problem is that we are trying to commit a non-existent
transaction because as per the comment in the code calling LOCK TABLE already
commited the transaction so there is no transaction left for us to commit
manually in the end. To summarise we need to remove the two lines I think:

$schema->storage->txn_begin;
$schema->storage->txn_commit;

Also why I think the above solution is reasonable is because otherwise we need
to rethought the design here totally on how the digest messages are sent and
maybe add a new is_digest db column and do the logic in the message sending
script instead of "merging db rows". For more background on why the table
locking was introduced see bug 15854.

PS. I think this bug might affect check-in and checkouts, not totally sure.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639
[Bug 26639] Turn auto_savepoint ON
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

--- Comment #44 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #42)
> (In reply to Jonathan Druart from comment #41)
> > Created attachment 116883 [details] [review] [review]
> > Bug 22824: Prevent YesNo to be filled with invalid values
> > 
> > This patch prevents koha-preferences to set other values than 1/0 to be
> > used for YesNo prefs
> 
> This patch does not work.
> If I execute
>   misc/admin/koha-preferences set viewMARC 2
> it warns "System preference viewMARC is YesNo and expects 1 or 0. '2' was
> given, using '0' (OK)
> but the value is set to '2'. (NOT OK)

Right, I tested it very poorly, sorry about that.
Should work now.

> And the dump subcommand output is different from master. On master it prints
> a serie of
>   : 
> but with the patches it prints
>   :
> type: 
> value: 
> variable: 
> 
> which prevents to do things like:
> 
>   koha-preferences dump | koha-preferences load

The dump|load actually worked, but not using a dump generated from master.
I restored the current behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #116883|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart  
---
Created attachment 116884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116884&action=edit
Bug 22824: Prevent YesNo to be filled with invalid values

This patch prevents koha-preferences to set other values than 1/0 to be
used for YesNo prefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27653] Do not include 'caption' row in print/copy export of datatables

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27653] Do not include 'caption' row in print/copy export of datatables

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27646] Allow export of acquisitions home and funds table

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27646] Allow export of acquisitions home and funds table

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27598] Add UPLOAD as a built-in system authorized value category

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27598] Add UPLOAD as a built-in system authorized value category

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26406] Suggestions filter does not work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26406] Suggestions filter does not work

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18146] C4::Circulation CanBookBeRenewed lacks full test coverage

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18146] C4::Circulation CanBookBeRenewed lacks full test coverage

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326

--- Comment #15 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8287] Improve filter on checked out from overdues

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8287] Improve filter on checked out from overdues

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12966] Edition statement missing from card view in Z39.50 result list (acq+cataloguing)

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12966

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27691] Allow HTML in notes for saved SQL reports

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27691

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
The problem is that this saved_sql.notes field can be filled in by Mana, so I
don't think we can trust the data coming from there.

We should first make sure the data is sanitized before it is inserted into the
Mana DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #41)
> Created attachment 116883 [details] [review]
> Bug 22824: Prevent YesNo to be filled with invalid values
> 
> This patch prevents koha-preferences to set other values than 1/0 to be
> used for YesNo prefs

This patch does not work.
If I execute
  misc/admin/koha-preferences set viewMARC 2
it warns "System preference viewMARC is YesNo and expects 1 or 0. '2' was
given, using '0' (OK)
but the value is set to '2'. (NOT OK)

And the dump subcommand output is different from master. On master it prints a
serie of
  : 
but with the patches it prints
  :
type: 
value: 
variable: 

which prevents to do things like:

  koha-preferences dump | koha-preferences load

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27577] Autolink bibs after generating the biblionumber

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27577

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #5 from Jonathan Druart  
---
Nick, can you try to provide a test for this change please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25760] Holds Ratio report is not reporting on records with 1 hold

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |n...@bywatersolutions.com
   |ommunity.org|
 QA Contact|n...@bywatersolutions.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25760] Holds Ratio report is not reporting on records with 1 hold

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #110063|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >