[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #8 from David Cook --- I'm loving this change. I have an AWS server with 4GB RAM and only 3 instances. I switched over to using this alternative indexer and I saved 500MB immediately while idling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #93 from Arthur Suzuki --- Created attachment 116928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116928&action=edit Bug 7376: (follow-up) Fix C4/Circulation.pm This follow-up patch actually fixes the issue. This patch forbids a patron to return a book to a library from where the book may not return to its home or holding library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #92 from Arthur Suzuki --- Created attachment 116927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116927&action=edit Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19339] Enhance streaming cataloging to include Vimeo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19339 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- (In reply to Charlotte Stock from comment #3) > This enhancement implies that it is not possible to stream videos unless > they are from YouTube or Vimeo? This would explain why I have been unable to > stream videos from other sources under the Play Media tab; is there a > workaround solution to enable videos to be uploaded or streamed within a > catalogue record? No, you can still stream videos from a file server or S3 for instance. This is about embedding an external video player I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #59 from Arthur Suzuki --- Hi Sonia, Just managed to get my Koha testing environment up again. Unfortunately, after applying both tests patch and fix patchs, some tests are still failing. Still a bit of work needed on that patch. I see that assignee changed, is there someone working on that one? King regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #57 from Andrew Fuerste-Henry --- A couple of typos. To recreate: 1 - select two or more orders to receive 2 - in the multi-receiving modal, update all but one of your orders to have received items 3 - save your changes in the modal 4 - back on the multi-receiving page, get these messages ("X" is the order number): Order X: No quantity to receive setted. No items will be created. Order X: An error cocurred while saving Those should be: Order 7: No quantity to receive set. No items will be created. Order 7: An error occurred while saving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #56 from Andrew Fuerste-Henry --- Additional issue: 1 - on parcel.pl, check the checkboxes for one or more titles 2 - click the individual Receive link for one of the expected titles 3 - that takes you to orderreceive.pl for that individual title 4 - click Cancel 5 - when you get back to parcel.pl, the checkboxes you checked previously are still marked, but the Receive Selected button indicates you have zero titles selected. You must un-check and re-check the titles to get them to register. We should un-check those boxes if we leave and then return to the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #55 from Andrew Fuerste-Henry --- To recreate the issue where receiving hangs on processing when missing a replacement price: 1: have a fresh Koha Testing Docker 2: apply patch, updatedatabase, restart_all 3: have a basket set to create item records on ordering 4: populate basket from a marc file, only setting price and fund for the items 5: close basket 6: click to Receive, create invoice 7: on parcel.pl, "Processing" alert never resolves The console shows: parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property 'format_price' of null at render (parcel.pl?invoiceid=1:810) at datatables.min_20.1200012.js:57 at Object.b.fnGetData (datatables.min_20.1200012.js:51) at B (datatables.min_20.1200012.js:56) at Ha (datatables.min_20.1200012.js:64) at P (datatables.min_20.1200012.js:68) at vb (datatables.min_20.1200012.js:79) at datatables.min_20.1200012.js:76 at i (datatables.min_20.1200012.js:74) at Object.success (datatables.min_20.1200012.js:75) And that error points toward: "data": "replacement_price", "render": function(data, type, row, meta) { return (row.replacement_price).format_price(); }, }, In the database, I see that aqorders.replacementprice is null for all of the orders I made. If I do an update to set aqorders.replacementprice=0, then the receiving page populates as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 Ron Houk changed: What|Removed |Added CC||rhouk@ottumwapubliclibrary. ||org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 ByWater Sandboxes changed: What|Removed |Added Attachment #116839|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 116926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116926&action=edit Bug 27694: use HTML filtering on News Tool textarea To test: 1. Add some HTML enties to your codemirror in the News Tool. Example: Movies 2. Save and re-eneter the tool, the HTML entites have been converted 3. Apply patch 4. Try again, HTML entities should not be converted Signed-off-by: Ron Houk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19339] Enhance streaming cataloging to include Vimeo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19339 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25954] Header search forms should be labeled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart changed: What|Removed |Added Blocks||27713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 [Bug 27713] Duplicate search field IDs in MARC framework administration template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27713] Duplicate search field IDs in MARC framework administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||25954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 [Bug 25954] Header search forms should be labeled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27713] Duplicate search field IDs in MARC framework administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 --- Comment #1 from Owen Leonard --- Created attachment 116925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116925&action=edit Bug 27713: Duplicate search field IDs in MARC framework administration template This patch makes a minor change to the MARC framework administration template so that the ID of a form field on the page isn't a duplicate of one in the header search form. To test, apply the patch and go to Administration -> MARC bibliographic framework -> MARC structure. - Test the "Search for tag" form field to confirm that it works correctly. - Validate the HTML of the page to confirm that there are no "Duplicate ID" errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27713] Duplicate search field IDs in MARC framework administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||fridolin.som...@biblibre.co ||m, vic...@tuxayo.net --- Comment #6 from Jonathan Druart --- @RMaints: you all need this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #231 from Jonathan Druart --- *** Bug 22838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 Jonathan Druart changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Jonathan Druart --- On master: kohadev-koha@kohadevbox:/kohadevbox/koha$ perl misc/cronjobs/runreport.pl 2 --format html --to f...@example.org It does not return any warnings. Certainly fixed by bug 22343. *** This bug has been marked as a duplicate of bug 22343 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27713] Duplicate search field IDs in MARC framework administration template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Summary|Can't navigate in |Duplicate search field IDs |Authorized values |in MARC framework ||administration template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27703] Can't navigate in Authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 Owen Leonard changed: What|Removed |Added Attachment #116923|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 116924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116924&action=edit Bug 27703: Make ID of category select field unique Duplicate element IDs on the authorized values page are invalid and cause a problem with the JavaScript intended to submit the form when the category select field changes. This patch changes the ID of the label and the field and makes the corresponding change to the JavaScript. To test, apply the patch and go to Administration -> Authorized values. - Click an authorized value category to view its contents. - Using mouse or keyboard, make a selection from the "Show category" dropdown menu. - The form should submit automatically and direct you to the corresponding category. - Validate the HTML of the page and confirm that there are no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27703] Can't navigate in Authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27713 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27713] New: Can't navigate in Authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27713 Bug ID: 27713 Summary: Can't navigate in Authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, testo...@bugs.koha-community.org The "search for tag" field in MARC framework administration has the same ID as "search system preferences" field in the header search box. This is invalid and can cause problems when references elements by ID in JavaScript or CSS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27703] Can't navigate in Authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 --- Comment #5 from Owen Leonard --- Created attachment 116923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116923&action=edit Bug 27703: Make ID of category select field unique Duplicate element IDs on the authorized values page are invalid and cause a problem with the JavaScript intended to submit the form when the category select field changes. This patch changes the ID of the label and the field and makes the corresponding change to the JavaScript. To test, apply the patch and go to Administration -> Authorized values. - Click an authorized value category to view its contents. - Using mouse or keyboard, make a selection from the "Show category" dropdown menu. - The form should submit automatically and direct you to the corresponding category. - Validate the HTML of the page and confirm that there are no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27703] Can't navigate in Authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27703 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 --- Comment #15 from Jonathan Druart --- So you don't need that, you can define several "item news" and set a different library for each of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 737] Map of library in search system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24692] OpacBrowseSearch: enable navigating result list with arrow keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24692 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome for Czech fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 --- Comment #4 from Josef Moravec --- As a quick fix, you can add something like this into intranet css pref: fieldset.action { margin: .9em 0 2em; } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome for Czech fork
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 Tomáš Wünsch changed: What|Removed |Added Summary|Batch item modification |Batch item modification |tool is missing Save/Cancel |tool is missing Save/Cancel |buttons in Chrome |buttons in Chrome for Czech ||fork -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 --- Comment #3 from Tomáš Wünsch --- You are correct - I tried in same browser to open two demo installations: https://intranet-demo.biblibre.com/cgi-bin/koha/tools/batchMod.pl (Fr. V. 19.11.12.000) == Save/Cancel is there https://demo.koha.cz/cgi-bin/koha/tools/batchMod.pl (Czech v. 19.05.10.000) == Missing. The problem is Czech fork related. Sorry for misleading you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 Tomáš Wünsch changed: What|Removed |Added Version|unspecified |19.05 Severity|normal |minor CC||josef.mora...@gmail.com Hardware|All |PC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27711] Add categories to Public Lists in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27711 Marjorie Barry-Vila changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27711] Add categories to Public Lists in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27711 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109880|0 |1 is obsolete|| --- Comment #26 from Emmi Takkinen --- Created attachment 116922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116922&action=edit Bug 23415: Display confirm dialog only once On detail page when patron has multiple checkouts and they are renewed from checkouts list, confirmation dialog box is displayed as many times as patron has checkouts. This patch reworks some code so this dialog box is displayed only once. To test: 1. Find patron with multiple checkouts (at least two) 2. Renew all checkouts from checkout list 3. Confirmation pop-up is displayed for every checkout 4. Apply this patch 5. Renew again => Confirmation dialog box is displayed only once Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #14 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > (In reply to Kyle M Hall from comment #12) > > (In reply to Jonathan Druart from comment #11) > > > Kyle, can you detail a bit more the need please? > > > > > > "It allows supports the use of Koha's TT plugins for data and price > > > formatting and more!" > > > > > > Which "data"? And what "more"? :) > > > > > > Seems overkilled for price formatting only. > > > > Those are just basic examples. A good example would be a news item that > > shows different information to libraries based on what category they are. > > Logged-in patron's category you mean? How would you do that? We don't pass > any variables to ->process. My bad, I was thinking the logged in branch code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109876|0 |1 is obsolete|| --- Comment #25 from Emmi Takkinen --- Created attachment 116921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116921&action=edit Bug 23415: Use OPACFineNoRenewals instead of noissuecharge Since noissuecharge is mainly fine limit for checkouts it's more logical to use value in OPACFineNoRenewals. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109872|0 |1 is obsolete|| --- Comment #24 from Emmi Takkinen --- Created attachment 116920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116920&action=edit Bug 23415: Add missing filters Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Emmi Takkinen changed: What|Removed |Added Attachment #109871|0 |1 is obsolete|| --- Comment #23 from Emmi Takkinen --- Created attachment 116919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116919&action=edit Bug 23415: Notify patron fines when renewing It is possible to renew items for patron who has fines over accepted limit on renew page or from checkout list. This patch adds confirmation alerts to these renew actions when patron has fines over "noissuescharge" syspref. Test plan: 1. Have patron with checkouts and fines over allowed limit 2. Renew checkouts either from renew page or checkout list => renew is successful 3. Apply patch 4. Repeat steps 1 and 2 => On renew page an alert is displayed and user has to confirm renew => When renew is done from checkout list confirmation pop-up is displayed Signed-off-by: Anneli Österman Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #43 from Jonathan Druart --- Created attachment 116918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116918&action=edit Bug 24108: Remove extra spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #42 from Jonathan Druart --- Created attachment 116917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116917&action=edit Bug 24108: (QA follow-up) Add staff detail page to syspref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #41 from Jonathan Druart --- Created attachment 116916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116916&action=edit Bug 24108: (QA follow-up) Add missing comma in sysprefs.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #40 from Jonathan Druart --- Created attachment 116915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116915&action=edit Bug 24108: Make export file names consistent This patch renames the systempreference to be a bit clearer and uses explicit options rather than a yes/no Additionally it standardizes the export from the advanced cataloging editor with that from the details page To test: 1 - Apply patches 2 - Update database and restart all the things 3 - Open a record in the advanced editor and save it as marc and xml 4 - Note the file name is 'bib-{biblionumber.{format}' 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number 6 - Repeate 3-4 on a record with and without a control number 7 - If control number present fiule name should be 'record-{controlnumber}.{format}' 8 - Otherwise it should be as above 9 - Repeat tests from the details page of a record 10 - Repeat tests from the opac details page of a record Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #39 from Jonathan Druart --- Created attachment 116914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116914&action=edit Bug 24108: (QA follow-up) Adjust wording and use perl for update file Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #38 from Jonathan Druart --- Created attachment 116913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116913&action=edit Bug 24108: (follow-up) Fix typo with .xml extension Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer JD amended patch: * Fix author's patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Jonathan Druart changed: What|Removed |Added Attachment #116898|0 |1 is obsolete|| Attachment #116899|0 |1 is obsolete|| Attachment #116900|0 |1 is obsolete|| Attachment #116901|0 |1 is obsolete|| Attachment #116902|0 |1 is obsolete|| Attachment #116903|0 |1 is obsolete|| --- Comment #37 from Jonathan Druart --- Created attachment 116912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116912&action=edit Bug 24108: Advanced editor: configure if biblionumber or control number is used for saved files Creates a new system preference "SaveRecordbyControlNumber" (renamed in follow-up patch with "DefaultSaveRecordFileID") which is initially set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the biblionumber. If the record does not yet have a biblionumber, the record will be saved as record.mrc or record.xml Test plan: 1) Apply the patch, flush_memcached and restart_all 2) Enable the "EnableAdvancedCatalogingEditor" system preference 4) Save the record using the drop down box selecting "Save as MARC (.mrc) file. 5) Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 6) Repeat steps 3-5 for the .xml save option 7) Update the new system preference "SaveRecordbyControlNumber" and change to "Save by ControlNumber" 8) Verify that there is not a 001 field in the record (delete it if there is) 9) Repeat steps 3-5 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 10) Add a 001 field to the record such as "001 abc00012345" 11) Repeat step 4 for both .mrc and .xml and verify that the files saved are named abc00012345.mrc and abc00012345.xml 12) Sign off! Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer JD amended patch: * Remove change to obsolete sysprefs.sql * Fix author's patch * Update commit message to tell the syspref has been renamed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24691] OpacBrowseSearch: Show number of results behind each list entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24691 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- I don't think this is correct. You must take into account the "Select patron to keep" information. Here we assume that the first one will always be replaced by the second one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27661] Clarify error for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #46 from Jonathan Druart --- Adding here some notes about the dependent tree (I've squashed the whole tree for pre-review): 1. -$messages->{'WasTransfered'} = 1; +$messages->{'WasTransfered'} = $tbr; but t/db_dependent/SIP/Transaction.t:is_deeply($result,{ messages => { 'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not issued and transferred"); So I ran the tests and there is a failure: # Failed test 'Messages show not issued and transferred' # at t/db_dependent/SIP/Transaction.t line 327. # Structures begin differing at: # $got->{messages}{TransferTrigger} = 'ReturnToHome' # $expected->{messages}{TransferTrigger} = Does not exist # Looks like you planned 5 tests but ran 2. 2. -my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber ); +my $transfer = $item->get_transfer; This GetTransfers is pretty bad, it could return several transfers, but callers are not ready for that: opac/opac-detail.pl: my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($itm->{itemnumber}); So that's definitely a good move to have a get_transfer method that will return only 1, the current one. However, cannot we enforce this constraint at DB level (DB unique key) and have a ->find call in ->get_transfer to replace the ->first? 3. Shouldn't Koha::Exceptions::Item::Transfer::Found be actually Koha::Exceptions::Item::Transfer::AlreadyInTransfer, to be more explicit? 4. Same, should we make Koha::Exceptions::Item::Transfer::Limit more explicit? Its description is "Transfer not allowed" but it seems that we can make it more exact. 5. in circ/transferstosend.pl +show_date=> output_pref( +{ dt => dt_from_string, dateformat => 'iso', dateonly => 1 } +) I'd pass {today => dt_from_string}, it should be enough. 6. in circ/transferstosend.tt [% FOREACH branchesloo IN branchesloop %] should be [% FOREACH library IN libraries %] 7. There are some indentation inconsistencies in circ/transferstosend.tt 8. (not blocker) transferCollection.tt +[%- SWITCH message.type -%] +[%- CASE 'failure' %] ... +[%- CASE 'enqueu' -%] The usual pattern is push @message, { type => 'error', # or message code => 'enqueu(ed?)', %more_variables } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #1 from Andreas Jonsson --- Created attachment 116911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116911&action=edit Bug 21225: Add Syndetics cover images to staff client. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly setting a MIME header field (content-type) is dangerous'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838 --- Comment #8 from Koha Team University Lyon 3 --- Hello, could someone have a look at this one? Thanks, Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #45 from Jonathan Druart --- Shouldn't we start with a good script/template name? transferstosend.pl => transfers_to_send.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #44 from Jonathan Druart --- Is this store call needed? +$self->stage_id($new_stage->stage_id)->store;# Revert stage change There are also several places in the tests where ->store calls are unnecessary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- Does it make sense to have a global setting when the check prev checkout feature can be tweak at 3 different levels (pref, patron's category, individual patron)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Joonas Kylmälä changed: What|Removed |Added Attachment #116909|0 |1 is obsolete|| --- Comment #5 from Joonas Kylmälä --- Created attachment 116910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116910&action=edit Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query in C4::Circulation::SendCirculationAlert is not correctly handled. From the MySQL doc that is copied few lines before, "LOCK TABLE will commit any transactions", but here we don't have a savepoint and the release for a non-existent savepoint will throw a DBI exception. This patch removes the unecessary transaction and prevent the following error when a renewal is done: > DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: > DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement > "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm > line 3590 Test plan: 1. Enable RenewalSendNotice 2. Add some email address to patron and select the email box from the message preference "Item checkout and renewal" in order to receive renewal emails. 3. Check 1 item out to a patron 4. Renew it Signed-off-by: Andrew Nugged Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 --- Comment #4 from Joonas Kylmälä --- I found the MySQL documentation where the LOCK Tables behaviour with transactions is explained: https://dev.mysql.com/doc/refman/8.0/en/lock-tables.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Andrew Nugged changed: What|Removed |Added Attachment #116906|0 |1 is obsolete|| --- Comment #3 from Andrew Nugged --- Created attachment 116909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116909&action=edit Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query in C4::Circulation::SendCirculationAlert is not correctly handled. From the MySQL doc that is copied few lines before, "LOCK TABLE will commit any transactions", but here we don't have a savepoint and the release for a non-existent savepoint will throw a DBI exception. This patch removes the unecessary transaction and prevent the following error when a renewal is done: > DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: > DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement > "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm > line 3590 Test plan: 1. Enable RenewalSendNotice 2. Add some email address to patron and select the email box from the message preference "Item checkout and renewal" in order to receive renewal emails. 3. Check 1 item out to a patron 4. Renew it Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Andrew Nugged changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Hm, I already tried root@localhost and kat...@something.de so both syntax. > Is there some special magic about the one you suggested? And is > KohaAdminEmailAddress the one it shoud go into? kat...@something.de should work, please try again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Created attachment 116908 [details] [review] > Bug 27380: Add missing use statement Patched pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27712] Cannot use date parameters in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27712 --- Comment #2 from Joonas Kylmälä --- Applying the patch from there fixes the issue indeed, thanks Jonathan for the super fast patch! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27706] Holds to Pull libraries column filter doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27706 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #31 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27712] Cannot use date parameters in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27712 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jonathan Druart --- I've added a fix on bug 27380 (Add missing use statement) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 --- Comment #21 from Jonathan Druart --- Created attachment 116908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116908&action=edit Bug 27380: Add missing use statement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #22 from Jonathan Druart --- (In reply to Rickard Lindfors from comment #21) > Hi! We use the API for our discovery to get item information, but that's one > api call per item. It would be nice to just use one call from the biblio. > > How about to add the get functions of this bug as starter, and add the > post/put function later? They should be easier to implement. See bug 27358. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Jonathan Druart --- Also works on v19.05.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27709] Batch item modification tool is missing Save/Cancel buttons in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27709 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- It works for me on master and with chromium 83.0.4103.116 If this issue is related to the Czech fork you should contact them instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Joonas Kylmälä changed: What|Removed |Added Blocks||27712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27712 [Bug 27712] Cannot use date parameters in SQL reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27712] New: Cannot use date parameters in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27712 Bug ID: 27712 Summary: Cannot use date parameters in SQL reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: n...@bywatersolutions.com Depends on: 27380 Using the date parameter in SQL report doesn't work anymore after bug 27380 was merged, reverting the patches fixes problem. I'm not exactly sure what is it that causes the problem, Nick do you have any idea? To reproduce the problem create a new SQL report: > select * from biblio where datecreated = <> and then run it with whatever date and you should get the error: > Can't locate object method "_columns" via package "02/16/2021" (perhaps you > forgot to load "02/16/2021"?) at /kohadevbox/koha/Koha/Object.pm line 810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 [Bug 27380] Add option for taking a list parameter in reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #7 from Katrin Fischer --- Hm, I already tried root@localhost and kat...@something.de so both syntax. Is there some special magic about the one you suggested? And is KohaAdminEmailAddress the one it shoud go into? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Rickard Lindfors changed: What|Removed |Added CC||rickard.lindf...@sh.se --- Comment #21 from Rickard Lindfors --- Hi! We use the API for our discovery to get item information, but that's one api call per item. It would be nice to just use one call from the biblio. How about to add the get functions of this bug as starter, and add the post/put function later? They should be easier to implement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27710] PatronSelfRegistrationLibraryList can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27710 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27604 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- I've added a follow-up patch on Bug 27604: Deal with empty pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 --- Comment #2 from Jonathan Druart --- Created attachment 116906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116906&action=edit Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query in C4::Circulation::SendCirculationAlert is not correctly handled. From the MySQL doc that is copied few lines before, "LOCK TABLE will commit any transactions", but here we don't have a savepoint and the release for a non-existent savepoint will throw a DBI exception. This patch removes the unecessary transaction and prevent the following error when a renewal is done: > DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: > DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement > "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm > line 3590 Test plan: 1. Enable RenewalSendNotice 2. Add some email address to patron and select the email box from the message preference "Item checkout and renewal" in order to receive renewal emails. 3. Check 1 item out to a patron 4. Renew it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15854] Race condition for sending renewal/check-in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Jonathan Druart changed: What|Removed |Added Blocks||27707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 [Bug 27707] Renewing doesn't work when renewal notices are enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707 Jonathan Druart changed: What|Removed |Added Depends on||15854 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 [Bug 15854] Race condition for sending renewal/check-in notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #58 from Koha Team University Lyon 3 --- Hello, does this one need new tests or is there just QA issues ? Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/