[Koha-bugs] [Bug 27722] Eliminate 'All' as an option from display location in OPAC and Koha news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27722 --- Comment #1 from Katrin Fischer --- Could we rename it "OPAC and staff interface" instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #18 from Marcel de Rooy --- This change looks good to me, but I certainly expected to see more code moving from the pending holds script to a module when I qa'ed the previous one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #17 from Marcel de Rooy --- Created attachment 116973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116973&action=edit Bug 27131: (QA follow-up) POD and comments Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Marcel de Rooy changed: What|Removed |Added Attachment #116970|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 116972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116972&action=edit Bug 27131: Add tests for get_items_that_can_fill Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Marcel de Rooy changed: What|Removed |Added Attachment #116969|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 116971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116971&action=edit Bug 27131: Add get_items_that_can_fill Signed-off-by: Andrew Nugged Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #14 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27723] Add search box to OPAC reading record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27723 Aleisha Amohia changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia --- Oops sorry I didn't realise this was fixed in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27723] Add search box to OPAC reading record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27723 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27723] New: Add search box to OPAC reading record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27723 Bug ID: 27723 Summary: Add search box to OPAC reading record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org A member's reading record (circulation history) can be searched with a search box on the staff client but not on the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #13 from Andrew Nugged --- Created attachment 116970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116970&action=edit Bug 27131: Add tests for get_items_that_can_fill Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Andrew Nugged changed: What|Removed |Added Attachment #114085|0 |1 is obsolete|| Attachment #114852|0 |1 is obsolete|| --- Comment #12 from Andrew Nugged --- Created attachment 116969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116969&action=edit Bug 27131: Add get_items_that_can_fill Signed-off-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Andrew Nugged changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #125 from Aleisha Amohia --- Created attachment 116968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116968&action=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Manual CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27722] New: Eliminate 'All' as an option from display location in OPAC and Koha news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27722 Bug ID: 27722 Summary: Eliminate 'All' as an option from display location in OPAC and Koha news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When the Koha News tool was just for OPAC News and 'librarian interface' all was a good option. Now that we have 10+ content areas options 'All' is just confusing. It should be eliminated as an option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| CC||and...@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27721] New: Circulation Workflow (Statuses)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27721 Bug ID: 27721 Summary: Circulation Workflow (Statuses) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be great if there were some kind of centralized workflow for processing items that would allow libraries to handle items the way they need to at each branch. Right now we have rules, and then we have statuses. There are some workflows for statuses peppered throughout the preferences, but nothing centralized, and far too limiting. I think some of these settings could be centralized through a common workflow interface, similar to (or maybe combined with) UpdateItemLocationOnCheckin, and be given some better flexibility. Please understand that I am just throwing this out there for a discussion. Some of these ideas might be redundant and might even be too complex a change for Koha. But, for the sake of discussion and brainstorming, what if we could define common triggers and actions, and allow libraries to combine these with common elements? Basically, it would be great to have a framework in which we could define what elements would trigger what kind of actions, and in what order. Here is where I am coming from. We have a library that would like to create a status for lost items that are in collections. Easy enough. We would like to make sure that when the item status is changed from long overdue to lost and in collections that the fee is not removed. We would also like it if an item with this status were checked in at some or all libraries, it would pause the check in with a message stating that it is in collections, are you sure you want to check this item in? Maybe we just simply need more status preferences? But, it seems we have a few peppered through the settings as it is, and it would be great if we had these in a central framework where we could see them all and prioritize them and have more options as to how they work. Does this status charge? Does it refund? Should it be confirmed? Should it block? Should it reroute? Should it notify a staff member? Should it go to a staff member for processing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 --- Comment #19 from David Cook --- (In reply to Kyle M Hall from comment #16) > That was just an example. The real power here is combining new with running > perl in TT so we have access to any data in Koha. What would make this much > better and more convenient is the ability to get a schema object via a TT > plugin. That way we can get to the data without resorting to raw perl. What > do you think? This sounds like it might be convenient for a developer but what staff interface user would actually have the knowledge or skill to make use of this? What's your current/expected use cases? It seems a bit too hypothetical to me at the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 --- Comment #18 from David Cook --- (In reply to Katrin Fischer from comment #17) > Hm, wondering... if we could get any object, wouldn't that allow to get > around permissions like the ones to access patron data? (might be totally > misunderstanding things) Yes, it would allow you to get around permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #22 from Katrin Fischer --- The dependency patch is not yet signed off - moving to BLOCKED for the moment until that is sorted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Katrin Fischer changed: What|Removed |Added Attachment #116065|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 116967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116967&action=edit Bug 25846: Improve handling of multiple covers on catalog search results in the staff client This patch modifies the template, JS, and CSS for the staff interface catalog search results in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference Perform a variet of searches and confirm that cover images are displaying correctly, whether there be 0, 1, 2, or more covers available for each. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27628] Fix minor HTML markup errors in OPAC search results templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #24 from Katrin Fischer --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25405: clearly define local login and shib login sections Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc error: Failed to merge in the changes. Can you please add the other bug (comment#21) in See also or as blocks? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- This works well, still wondering about comment#3 - Failing QA to get attention :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27334] Add Template Toolkit support to news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 --- Comment #17 from Katrin Fischer --- Hm, wondering... if we could get any object, wouldn't that allow to get around permissions like the ones to access patron data? (might be totally misunderstanding things) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Missing dependency from 27289, which needs a rebase for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27289] Template tweaks for point of sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from Katrin Fischer --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22605: Add ability to edit a search on staff interface .git/rebase-apply/patch:441: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Search.pm M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt .git/rebase-apply/patch:441: trailing whitespace. warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Auto-merging C4/Search.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27633] Display of 440$v doubled up in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27633 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #11 from Andrew Fuerste-Henry --- missing dependency, not backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #124 from Katrin Fischer --- (In reply to Katrin Fischer from comment #123) > Hi Aleisha, > I tested with "lerening perl" and the year got filled with "2011-06-16", but > this won't store. Can we edit it to be 2011 so the form can be saved without > further editing? Learning Perl actually... without all the typos! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27154] Koha/Util/SystemPreferences.pm must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| Status|Pushed to stable|Pushed to oldstable CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #123 from Katrin Fischer --- Hi Aleisha, I tested with "lerening perl" and the year got filled with "2011-06-16", but this won't store. Can we edit it to be 2011 so the form can be saved without further editing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26602] Datatables - Actions columns should not be exported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 Katrin Fischer changed: What|Removed |Added Attachment #116926|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 116966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116966&action=edit Bug 27694: use HTML filtering on News Tool textarea To test: 1. Add some HTML enties to your codemirror in the News Tool. Example: Movies 2. Save and re-eneter the tool, the HTML entites have been converted 3. Apply patch 4. Try again, HTML entities should not be converted Signed-off-by: Ron Houk Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > This appears to work, but is it expected that you can't use the source view > of the visual editor to enter Movies ? It only > leaves "Movies" and that's scary. > > Does it mean opening in the wrong editor and saving, you'll completely > destroy things? Ok. it only destroy entries if it doesn't like your HTML. Adding the surrounding select make it stay ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 --- Comment #3 from Katrin Fischer --- This appears to work, but is it expected that you can't use the source view of the visual editor to enter Movies ? It only leaves "Movies" and that's scary. Does it mean opening in the wrong editor and saving, you'll completely destroy things? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719
Katrin Fischer changed:
What|Removed |Added
Attachment #116947|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 116965
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116965&action=edit
Bug 27719: Apply _escape_str and _escape_price where needed
This bug replaces calls for .escapeHtml and format_price for there null
checking counterparts
To test:
1: have a fresh Koha Testing Docker
2: have a basket set to create item records on ordering
3: populate basket from a marc file, only setting price and fund for the items
4: close basket
5: click to Receive, create invoice
6: on parcel.pl, "Processing" alert never resolves
CHECK => The console shows:
parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property
'format_price' of null
at render (parcel.pl?invoiceid=1:810)
at datatables.min_20.1200012.js:57
at Object.b.fnGetData (datatables.min_20.1200012.js:51)
at B (datatables.min_20.1200012.js:56)
at Ha (datatables.min_20.1200012.js:64)
at P (datatables.min_20.1200012.js:68)
at vb (datatables.min_20.1200012.js:79)
at datatables.min_20.1200012.js:76
at i (datatables.min_20.1200012.js:74)
at Object.success (datatables.min_20.1200012.js:75)
And that error points toward:
"data": "replacement_price",
"render": function(data, type, row, meta) {
return (row.replacement_price).format_price();
},
},
7: apply patch
8: redo steps 5 and 6
SUCCESS => "Processing" alert doesn't hangs, and prices with null values
are empty.
Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27589] Error when specifying CR field in SIP Config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |FIXED CC||and...@bywatersolutions.com Status|Pushed to stable|RESOLVED --- Comment #11 from Andrew Fuerste-Henry --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27466] Update process failing for 20.06.00.023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27466 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #16 from Andrew Fuerste-Henry --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Katrin Fischer changed: What|Removed |Added Summary|receiving orders hangs on |Receiving orders hangs on |processing when missing a |processing when missing a |replacement price |replacement price -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #9 from Katrin Fischer --- I've set all the email prefs to kat...@something.de and it doesn't change the error message: Invalid 'from' parameter: root@localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 I believe it might be related to the SMTP configuration, but I am not sure how to set that up on a devbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #116613|0 |1 is obsolete|| --- Comment #70 from Katrin Fischer --- Created attachment 116964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116964&action=edit Bug 26633: Add advanced editor link on admin home page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #116612|0 |1 is obsolete|| --- Comment #69 from Katrin Fischer --- Created attachment 116963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116963&action=edit Bug 26633: (QA follow-up) Add error handling for loading transfer limits table Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113275|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 116962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116962&action=edit Bug 26633: Add ability to bookmark the page you are viewing Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113274|0 |1 is obsolete|| --- Comment #67 from Katrin Fischer --- Created attachment 116961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116961&action=edit Bug 26633: Add API documentation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113273|0 |1 is obsolete|| --- Comment #66 from Katrin Fischer --- Created attachment 116960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116960&action=edit Bug 26633: Convert transfer_limit.json to YAML Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113272|0 |1 is obsolete|| --- Comment #65 from Katrin Fischer --- Created attachment 116959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116959&action=edit Bug 26633: Remove jquery.checkboxes.min.js include No longer exists and not used in this template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113271|0 |1 is obsolete|| --- Comment #64 from Katrin Fischer --- Created attachment 116958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116958&action=edit Bug 26633: POD for the exceptions file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113270|0 |1 is obsolete|| --- Comment #63 from Katrin Fischer --- Created attachment 116957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116957&action=edit Bug 26633: (QA follow-up) Tests on error condition This patch highlights a problem with the try/catch conditions in the ad() controlled method. Tests are added, and the controller is fixed to reflect the right behaviour. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/transfer_limits.t => SUCCESS: Tests pass! 409 is returned as appropriate! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113269|0 |1 is obsolete|| --- Comment #62 from Katrin Fischer --- Created attachment 116956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116956&action=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113268|0 |1 is obsolete|| --- Comment #61 from Katrin Fischer --- Created attachment 116955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116955&action=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113267|0 |1 is obsolete|| --- Comment #60 from Katrin Fischer --- Created attachment 116954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116954&action=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113266|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 116953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116953&action=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113265|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 116952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116952&action=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27717] Date of birth fails to display for babies under 1 year
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This breaks patron search in the patrons module--the JSON is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #7 from Joonas Kylmälä --- I have done some rudimentary testing to those attached patches that fix this issue and a bit more. I will move the status to Needs Sign-Off when I'm as certain as I possibly can that there is no bugs from my changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #6 from Joonas Kylmälä --- Created attachment 116951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116951&action=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This prevents checking out to a patron an item with hold to someone else in the In Processing state via staff interface. The checkout error message via SIP is now a more clearer one: "Item is on hold for another patron." Before it was "Item cannot be issued: $confirmation". The branch transfer and batch checkout pages are adapted to this new confirmation message as well. To test: 1) Create bib level hold to an item for patron A 2) Check-in that item via SIP2, now the hold state should be "In Processing" 3) Apply patch 4) Try to checkout the item to patron B via staff interface and notice we get now confirmation prompt do we really want to do it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #5 from Joonas Kylmälä --- Created attachment 116950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116950&action=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the common code from CanBookBeIssued and ignore only the RESERVED confirmation message case in SIP2 checkout code. This slightly changes the checkout error message given for "In processing" holds that someone other than the holdee tries to checkout. Otherwise there is no logic changes. The message that this changes is "Item is on hold for another patron." vs. now "Item cannot be issued: $confirmation". It is easier to create follow-up patch to properly add INPROCESSING confirmation to CanBookBeIssued and then show correct message based on the CanBookBeIssued return value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #4 from Joonas Kylmälä --- Created attachment 116949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116949&action=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items that are attached to a hold and being transferred (found = T) is final decision and you cannot checkout those to other patrons. To test: 1) Create hold and set pickup library to something else where the item is at 2) Return the item and it should confirm the hold and start transfer 3) Apply this patch 4) Try to checkout this item now to some other patron via SIP2 and notice it doesn't allow it 5) Revert this patch 6) Notice you can now checkout somebody else's hold that is being transferred! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #3 from Joonas Kylmälä --- Created attachment 116948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116948&action=edit Bug 25690: Remove double usage of 'Reserved' return value The patch "Bug 19116: Hold not set to waiting after transfer" added a new meaning to 'Reserved' return value of C4::Reserves::CheckReserves function. Let's remove double usage and have separate Transferred return value so we can differentiate between attached and non-attached holds. This will come useful in future refactorings. This patch does no changes to the logic except in the /cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give similarly to waiting state notice about hold being transferred. To test: 1) Apply this patch 2) Create a new item level hold so that pickup library is different than where the item is currently. Then return the item so that hold is being attached and transferred. 3) Go to branchtransfers.pl and try to create a new transfer: it should prompt you with message "Item is attached to a hold and being transferred for XXX" and provide you with option to cancel the hold or to ignore the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27720] New: Print Holds List slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27720 Bug ID: 27720 Summary: Print Holds List slip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: daniel.gag...@pueblolibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Enhancement would add a new option to the print drop down menu on a user's account page. The option would be labeled Print Holds List slip. On the slip would be displayed the user's first initial last name and last four of their library card number (all of this should be modifiable through the notices Notices & slips tool/template toolkit). The slip would then list the item title, material type, pickup library and position that the user is in the hold queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #64 from Agustín Moyano --- (In reply to Andrew Fuerste-Henry from comment #56) > Additional issue: > 1 - on parcel.pl, check the checkboxes for one or more titles > 2 - click the individual Receive link for one of the expected titles > 3 - that takes you to orderreceive.pl for that individual title > 4 - click Cancel > 5 - when you get back to parcel.pl, the checkboxes you checked previously > are still marked, but the Receive Selected button indicates you have zero > titles selected. You must un-check and re-check the titles to get them to > register. > > We should un-check those boxes if we leave and then return to the page. Again, could not reproduce this error.. could you please copy/paste any errors that appear in browsers console? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
--- Comment #63 from Agustín Moyano ---
(In reply to Andrew Fuerste-Henry from comment #57)
> A couple of typos. To recreate:
> 1 - select two or more orders to receive
> 2 - in the multi-receiving modal, update all but one of your orders to have
> received items
> 3 - save your changes in the modal
> 4 - back on the multi-receiving page, get these messages ("X" is the order
> number):
> Order X: No quantity to receive setted. No items will be created.
> Order X: An error cocurred while saving
>
> Those should be:
> Order 7: No quantity to receive set. No items will be created.
> Order 7: An error occurred while saving.
Typos fixed!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
--- Comment #62 from Agustín Moyano ---
(In reply to Andrew Fuerste-Henry from comment #55)
> To recreate the issue where receiving hangs on processing when missing a
> replacement price:
> 1: have a fresh Koha Testing Docker
> 2: apply patch, updatedatabase, restart_all
> 3: have a basket set to create item records on ordering
> 4: populate basket from a marc file, only setting price and fund for the
> items
> 5: close basket
> 6: click to Receive, create invoice
> 7: on parcel.pl, "Processing" alert never resolves
> The console shows:
> parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property
> 'format_price' of null
> at render (parcel.pl?invoiceid=1:810)
> at datatables.min_20.1200012.js:57
> at Object.b.fnGetData (datatables.min_20.1200012.js:51)
> at B (datatables.min_20.1200012.js:56)
> at Ha (datatables.min_20.1200012.js:64)
> at P (datatables.min_20.1200012.js:68)
> at vb (datatables.min_20.1200012.js:79)
> at datatables.min_20.1200012.js:76
> at i (datatables.min_20.1200012.js:74)
> at Object.success (datatables.min_20.1200012.js:75)
>
> And that error points toward:
> "data": "replacement_price",
> "render": function(data, type, row, meta) {
> return (row.replacement_price).format_price();
> },
> },
>
> In the database, I see that aqorders.replacementprice is null for all of the
> orders I made. If I do an update to set aqorders.replacementprice=0, then
> the receiving page populates as expected.
Well, that was thorough! Thanks so much.
This issue is not related to this bug, but to 20212 where the code was
introduced.
I created bug 27719 to fix this issue.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #116946|0 |1
is obsolete||
--- Comment #2 from Andrew Fuerste-Henry ---
Created attachment 116947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116947&action=edit
Bug 27719: Apply _escape_str and _escape_price where needed
This bug replaces calls for .escapeHtml and format_price for there null
checking counterparts
To test:
1: have a fresh Koha Testing Docker
2: have a basket set to create item records on ordering
3: populate basket from a marc file, only setting price and fund for the items
4: close basket
5: click to Receive, create invoice
6: on parcel.pl, "Processing" alert never resolves
CHECK => The console shows:
parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property
'format_price' of null
at render (parcel.pl?invoiceid=1:810)
at datatables.min_20.1200012.js:57
at Object.b.fnGetData (datatables.min_20.1200012.js:51)
at B (datatables.min_20.1200012.js:56)
at Ha (datatables.min_20.1200012.js:64)
at P (datatables.min_20.1200012.js:68)
at vb (datatables.min_20.1200012.js:79)
at datatables.min_20.1200012.js:76
at i (datatables.min_20.1200012.js:74)
at Object.success (datatables.min_20.1200012.js:75)
And that error points toward:
"data": "replacement_price",
"render": function(data, type, row, meta) {
return (row.replacement_price).format_price();
},
},
7: apply patch
8: redo steps 5 and 6
SUCCESS => "Processing" alert doesn't hangs, and prices with null values
are empty.
Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22713 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Agustín Moyano changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8179| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27719 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8179 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22713 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22713] Replacement price removed when receiving if using MarcItemFieldstoOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713 Agustín Moyano changed: What|Removed |Added CC||agustinmoy...@theke.io See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8179 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added Attachment #116681|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27379] Autocomplete addresses for a patron using Google Places API (Maps).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #6 from Benjamin Daeuber --- Is this better approached as a plugin? This development locks libraries into Google Maps, where if this were a plugin, it's easier to use alternate providers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719
--- Comment #1 from Agustín Moyano ---
Created attachment 116946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116946&action=edit
Bug 27719: Apply _escape_str and _escape_price where needed
This bug replaces calls for .escapeHtml and format_price for there null
checking counterparts
To test:
1: have a fresh Koha Testing Docker
2: have a basket set to create item records on ordering
3: populate basket from a marc file, only setting price and fund for the items
4: close basket
5: click to Receive, create invoice
6: on parcel.pl, "Processing" alert never resolves
CHECK => The console shows:
parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property
'format_price' of null
at render (parcel.pl?invoiceid=1:810)
at datatables.min_20.1200012.js:57
at Object.b.fnGetData (datatables.min_20.1200012.js:51)
at B (datatables.min_20.1200012.js:56)
at Ha (datatables.min_20.1200012.js:64)
at P (datatables.min_20.1200012.js:68)
at vb (datatables.min_20.1200012.js:79)
at datatables.min_20.1200012.js:76
at i (datatables.min_20.1200012.js:74)
at Object.success (datatables.min_20.1200012.js:75)
And that error points toward:
"data": "replacement_price",
"render": function(data, type, row, meta) {
return (row.replacement_price).format_price();
},
},
7: apply patch
8: redo steps 5 and 6
SUCCESS => "Processing" alert doesn't hangs, and prices with null values
are empty.
Sponsored-by: Virginia Polytechnic Institute and State University
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What|Removed |Added Assignee|nug...@gmail.com|joonas.kylm...@helsinki.fi CC||joonas.kylm...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What|Removed |Added Keywords||dependency CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #26 from Jonathan Druart --- Right, thanks Joonas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #25 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #24) > Very strange because https://packages.ubuntu.com/xenial/libyaml-libyaml-perl > lists it as being available on Ubuntu 16.04 / Xenial. Could the > Jenkins/Docker setup have some problem relating to which packages get > installed? I think it is because in our debian control file we don't specify libyaml-libyaml-perl to be installed explicitly, we only install libyaml-perl which has two alternative recommendations (see https://packages.ubuntu.com/xenial/libyaml-perl): - libyaml-syck-perl - libyaml-libyaml-perl and in our control file we explicitly say we want libyaml-syck-perl so the other one doesn't get installed most likely because of that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #24 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #23) > U16 is failing because of this, YAML::XS is missing. > > Don't backport! Very strange because https://packages.ubuntu.com/xenial/libyaml-libyaml-perl lists it as being available on Ubuntu 16.04 / Xenial. Could the Jenkins/Docker setup have some problem relating to which packages get installed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #28 from Jonathan Druart --- Patch pushed to master, thanks Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #44 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24108] Configure if biblionumber or control number is used for saved files from detail page or advanced cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano changed: What|Removed |Added Blocks||27719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 [Bug 27719] receiving orders hangs on processing when missing a replacement price -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27719] New: receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Bug ID: 27719 Summary: receiving orders hangs on processing when missing a replacement price Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: agustinmoy...@theke.io Reporter: agustinmoy...@theke.io QA Contact: testo...@bugs.koha-community.org Depends on: 20212 The list of items to be received hangs at Processing if any of your items/orders do not include a replacement price. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in receiving in acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
