[Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Magnus Enger changed: What|Removed |Added CC||eugen...@yahoo.com --- Comment #19 from Magnus Enger --- *** Bug 27902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27902] In batch record modification within reports, biblionumbers are truncated instead of one by one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27902 Magnus Enger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||mag...@libriotech.no --- Comment #1 from Magnus Enger --- I think this is fixed in version 20.05.07, by Bug 25942. *** This bug has been marked as a duplicate of bug 25942 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498
--- Comment #20 from Emmi Takkinen ---
(In reply to Jonathan Druart from comment #19)
> (In reply to Emmi Takkinen from comment #18)
> > (In reply to Jonathan Druart from comment #17)
> > > The store method should be improved to set expirationdate only if
> > > reservedate has been modified, to avoid unnecessary processing.
> >
> > Could you explain a little? Currently expirationdate is set only if
> > "DefaultHoldExpirationdate" and it's not defined or empty. Which is true
> > only when hold is first time made so I'm failing to see logic behind
> > checking reservedate in case of modifications.
> >
> > However I now noticed that if "AllowHoldDateInFuture" is set and reservedate
> > is modified expirationdate remains the same. That should be imo be fixed.
>
> You need to set expiration only if reservedate has been passed/modified.
> Koha::Item->store will give you some example (search for %updated_columns).
>
> If you have:
> my $hold = Koha::Holds->find(42);
> $hold->notes("some notes")->store;
> you don't want to rebuild expirationdate.
>
> Let me know if you need more details.
OK I see what you mean. I'll look into this and provide patch later.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18787] Create permission profiles for staff users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18787 --- Comment #2 from Séverine Queune --- Just discovered this plugin, but not tested yet. https://github.com/bywatersolutions/koha-plugin-batch-permissions-modifier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 --- Comment #19 from Phil Ringnalda --- Created attachment 117952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117952&action=edit Bug 27737: (follow-up) Minimal CSS changes to avoid regressions To keep the specificity of the rules we want to have apply to both the biblio editor and also the authorities editor, we need to add the ID for the authorities editor, rather than remove the ID for the biblio editor. Also, the removal of the selectors for #authoritiestabs descendents was regressing the display of authority record details, which is where that plural authoritiestabs element lives. Test plan: 1. With neither patch from this bug applied, Cataloging - New record - Default framework. 2. Shrink and widen your browser window, noticing how the input fields flex to remain the full width, keeping the controls to duplicate and delete a subfield out directly to the right of the input. 3. Authorities - search for Perl (or any term that will match a record), click the linked authority term to open the Authority detail display 4. Note how the field number, field description, and subfield descriptions are all different colors, and subfield codes are on the same line as the subfield contents. 5. Apply both patches from this bug. 6. Cataloging - New record - Default framework 7. Verify that the input fields still behave the same as you widen and shrink your browser window 8. Authorities - New authority - Chronological Term 9. Verify that the input fields now behave like the ones in the biblio editor, shrinking and widening to fill the width of the page, keeping the controls to duplicate and delete subfields immediately to the right of the field 10. Authorities - search for Perl, click the linked authority term to open the Authority detail display 11. Verify that the tag number, field description and subfield descriptions are still properly colored and subfield codes are still on the same line as the subfield contents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 Phil Ringnalda changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27902] New: In batch record modification within reports, biblionumbers are truncated instead of one by one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27902 Bug ID: 27902 Summary: In batch record modification within reports, biblionumbers are truncated instead of one by one Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: eugen...@yahoo.com QA Contact: testo...@bugs.koha-community.org Created attachment 117951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117951&action=edit Reports - Batch Records Modification error In batch record modification within reports, When the option "Batch record modification" is clicked, list of biblionumbers to be batch record modified are instead truncated and given as one record like: Bibliographic record 2088137458205232602921200212002120021180211882118721008208812052320878210442104620889208882097621061210602106221065210582088621064208912106321066208902850220892284982097320975211572115621154211552097420950208442119920831209642079220791207892079620788209342077420775210972109620755210992112620898209772084325965260142601526017259662602725967259672602526026260262597225972259692603025968260292595725959259562596025958259622596125963259552597425990259972599525976260002599325986259882599425989259872598425982259922598325985259992598126002260522605226051260512617526196261952617426174261712617226200262002619826201262182621926221262032620826207262072620926204262062662172621726214262152621627006262412624126234262342657226220265742656526548265672656226568265752657526546260002655326547265442654526211262412667226657266742665526669266512665222666826668266752665927011270112701227014270172734327340273352734127344273322732927325273312734527346273262732727337273622736127375273572737820523273672737727368273562737628569285912855128550284552845628545285712854728547285952859428544372903603736040359552856935990359973599736001360003599835998370953708137085371363713837141371593716637188371913719337206374562656525972209503745737459209762097620976260522617226208375163752225946 does not exist in the database. Notice that the biblionumbers are five digits, so the biblionumbers of my records in the error above are: 20881, 37458, 20523, and so on It seems these records are concatenated instead of them being an array or one by one? This is on Koha 20.05.06.000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27510] Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 Ivan Dziuba changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Ivan Dziuba --- You need install the module HTML::Table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Ivan Dziuba changed: What|Removed |Added Attachment #115206|0 |1 is obsolete|| --- Comment #8 from Ivan Dziuba --- Created attachment 117950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117950&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Remove Switch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #37 from Michael Adamyk --- I'm afraid I don't know enough about Koha to know how to do the SCSS or yard rebuild. Can someone else test and see if it's working for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 --- Comment #17 from wainuiwitikap...@catalyst.net.nz --- (In reply to Henry Bolshaw from comment #16) > This is great work, it's awesome to see people working on accessibility > improvements! > > I think we would want the on the OPAC main page to be visible to > screenreaders and I think they ignore content with "display:none" (please > correct me if I'm wrong!) > > I recently learnt that Bootstrap has a built-in screenreader only class: > ".sr-only". Can we use that instead? > > https://getbootstrap.com/docs/4.0/utilities/screenreaders/ Hi Henry, thanks so much for your feedback! Owen also pointed this out in the comments on Bug 27740 so we will definitely work on amending that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27901] cancelling acq order does not delete item record, causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27901 Donna changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27901] New: cancelling acq order does not delete item record, causes error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27901 Bug ID: 27901 Summary: cancelling acq order does not delete item record, causes error Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org Prior to 20.05 when an order was cancelled from the basket, the item created when the order was placed was deleted also. In 20.05, users now get the message: An error has occurred. The order has been cancelled, although one or more items could not have been deleted. To recreate: 1. Add biblio and item to basket 2. Cancel the order and delete the biblio 3. Get the error message 4. Verify that the Holdings table still shows the item, but the acq correctly shows the cancellation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27894] Add visual feedback on overridden pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27894 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 [Bug 27864] Pickup locations while placing a hold on the staff client should respect hold fulfillment policies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27864] Pickup locations while placing a hold on the staff client should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27894 [Bug 27894] Add visual feedback on overridden pickup locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27900] regression: add from existing record with null results deadends
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Donna changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27900] New: regression: add from existing record with null results deadends
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 Bug ID: 27900 Summary: regression: add from existing record with null results deadends Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org Prior to 20.05, when adding to a basket in acquisitions from an existing record, a search with no results left the user at /acqui/neworderbiblio.pl where they could then add to the basket via external source, etc. In 20.05 the user now ends at catalogue/search.pl and has to use the back button to return to the vendors list, and access the basket again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Waiting for the update of the wiki RFC page. Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366
Tomás Cohen Arazi changed:
What|Removed |Added
Text to go in the|This enhancements adds the |This enhancements adds the
release notes|`GET|`GET
|/patrons/{patron_id}/holds |/patrons/{patron_id}/holds`
|endpoint to the REST API. |endpoint to the REST API.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27366] Add GET /patrons/:patron_id/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27366
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|release-notes-needed|
Status|Failed QA |Needs Signoff
URL||https://wiki.koha-community
||.org/wiki/Patrons_holds_end
||point_RFC
Text to go in the|This enhancements adds the |This enhancements adds the
release notes|`GET|`GET
|/patrons/{patrin_id}/holds |/patrons/{patron_id}/holds
|endpoint to the REST API. |endpoint to the REST API.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 David Nind changed: What|Removed |Added Attachment #117760|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 117949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117949&action=edit Bug 27869: let user know something went wrong with csv upload To test: -attempt to upload a malformed CSV file -nothing happens, check the console and see the error: Uncaught TypeError: arrData[(arrData.length - 1)] is undefined -apply patch -try again -now you should at least see a warning that something went wrong -attempt to upload a good CSV file, it should work Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27869] QotD CSV upload JavaScript errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27869 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117938|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 117948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117948&action=edit Bug 27857: Add handling for globally mandatory attributes This patch adds handling for globally mandatory extended attributes and the corresponding unit tests. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117711|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 117947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117947&action=edit Bug 27857: Make Koha::Patron->extended_attributes validate data This patch makes the extended_attributes method use Koha::Patron->add_extended_attribute inside the loop, instead of direct DB access. This way, it takes advantage of the validation that is done there. All happens inside a transaction, so if 'add_extended_attribute' throws an exception, everything is rolled back. To test: 1. Apply the previous patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => FAIL: The behavior is not the correct one, tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117710|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 117946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117946&action=edit Bug 27857: Regression tests This patch adds regression tests for the changed behavior. Koha::Patron->extended_attributes will now throw exceptions and rollback on invalid attributes. The existing tests are amended so they don't try to deal with skipping bad attributes. Specific subtests are added for error situations. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => FAIL: Tests fail because the new behavior is not implemented. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Attachment #117709|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 117945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117945&action=edit Bug 27857: Move extended_attributes tests to Koha/Patron.t They really belong here. both Patron.t and Patrons.t got lengthy and it is not intuitive to look for tests for a Koha::Patron method in the Patrons.t file. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass, no new stuff 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26964] Advanced editor no longer selects newly created macros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 David Nind changed: What|Removed |Added Text to go in the||This patch fixes the release notes||behaviour for saving of new ||macros using the advanced ||editor. Before this fix the ||newly created macro wasn't ||selected and the automatic ||save (there isn't a save ||option) had nothing to ||save. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27899] Missing description for libraryNotPickupLocation on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117944&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27899] New: Missing description for libraryNotPickupLocation on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Bug ID: 27899 Summary: Missing description for libraryNotPickupLocation on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org As the attached screenshot highlights, there's no description for that error status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27884] Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson changed: What|Removed |Added Attachment #117942|0 |1 is obsolete|| --- Comment #4 from David Gustafsson --- Created attachment 117943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117943&action=edit Bug 123123: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "testing". 2) Create a new sql report, the query could be someting like: SELECT "" as `borrowernumber`, "t...@example.com", as `email`, "f...@example.com" as `from`; where "" is a valid borrowernumber. 3) Run patron_emailer.pl --report= --notice=TEST --module=members -commit where is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27884] Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Gustafsson changed: What|Removed |Added Attachment #117869|0 |1 is obsolete|| --- Comment #3 from David Gustafsson --- Created attachment 117942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117942&action=edit Bug 123123: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons" and name/code TEST 2) Create a new sql report, the query could be someting like: SELECT "" as `borrowernumber`, "t...@example.com", as `email`, "f...@example.com" as `from`; where "" is a valid borrowernumber. 3) Run patron_emailer.pl --report= --notice=TEST --module=members -commit where is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117941&action=edit Bug 27865: Pass the x-koha-override header to PUT /holds/:hold_id from the patron's page This patch makes the AJAX call to update an existing hold, pass the 'x-koha-override' header with the value of 'any', so any pickup location policy override that is needed, is applied. As the override is taken into account only if AllowHoldPolicyOverride is enabled, this in fact restores the previous behavior. To test: 1. Have a patron with a hold 2. Have AllowHoldPolicyOverride set to 'yes' 3. Try changing the pickup location to an invalid one => FAIL: The options are the same as before 27205, yet the AJAX call fails because of invalid pickup location. 4. Apply this patch 5. Repeat 3 => SUCCESS: The API call succeeds, and the hold is updated (it is actually refetch, so just verify it has the value you selected 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117936|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 117940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117940&action=edit Bug 27898: Make PUT /holds/:hold_id accept overrides This patch makes the route handle overriding pickup locations by passing the 'x-koha-override' header (set to 'any'). To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, because things cannot be overridden ATM. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117935|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 117939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117939&action=edit Bug 27898: Unit tests This patch adds unit tests for the PUT /holds/:hold_id route so it accepts the x-koha-override header and is able to override pickup location constraints. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on||27205 --- Comment #1 from Tomás Cohen Arazi --- This was caused by bug 27205. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27610] Accessibility: OPAC - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27610 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk --- Comment #16 from Henry Bolshaw --- This is great work, it's awesome to see people working on accessibility improvements! I think we would want the on the OPAC main page to be visible to screenreaders and I think they ignore content with "display:none" (please correct me if I'm wrong!) I recently learnt that Bootstrap has a built-in screenreader only class: ".sr-only". Can we use that instead? https://getbootstrap.com/docs/4.0/utilities/screenreaders/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #7 from Martin Renvoize --- Created attachment 117938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117938&action=edit Bug 27857: Add handling for globally mandatory attributes This patch adds handling for globally mandatory extended attributes and the corresponding unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 --- Comment #11 from Andrew Fuerste-Henry --- Tomas pointed out the dropdown on a new hold is to be handled in bug 27894. Therefore signing off here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #117874|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 117937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117937&action=edit Bug 27863: Use the /libraries route when AllowHoldsPolicyOverride is set This patch makes the dropdown for changing the pickup location for existing holds use the GET /libraries route instead of GET /holds/:hold_id/pikcup_locations if the configuration allows the override. Terminology: - Pickup location, means a library that is marked as valid pickup location on its configuration. To test: 1. Have the circ rules set so 'Hold pickup library match' is set to 'Item's home library' or 'Any'. The goal is to be able to differentiate when all libraries are returned, from the case only 'valid pickup locations' are returned. The easiest one is 'Item's home library'. 2. Set AllowHoldsPolicyOverride 3. Pick a patron from a library that is not a valid pickup location and an item that belongs to a library that doesn't match any of the valid ones. => SUCCESS: Notice Koha allows you to choose any library (because of the syspref) 4. Place the hold. 5. Now check on the holds list for the bib, if you can use the dropdown to change the pickup location for the hold => SUCCESS: You can, sort of => FAIL: It doesn't show/search all pickup locations. It only shows the valid ones, even though we should be able to override it. 6. Apply this patch 7. Restart all just in case, and reload the holds page for the bib 8. Repeat 5 => SUCCESS: You are presented all pickup locations! 9. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #8) > When placing a new hold with pickup library match set to Item's Holding > Library and AllowHoldPolicyOverride set to Allow, I am not given the option > of setting a pickup branch other that the item's holdingbranch, with or > without the patch. I should be able to pick whatever branch I want when > placing the hold, rather than having to place it and then edit the pickup > branch to something else. > > The changes to pickup branch selection on existing holds works great! I > agree that it'd be good to have some indicator within that dropdown of which > branches follow the rules and which require an override, though it makes > sense to follow up on that in a separate bug. Are you sure that's not *another* holds bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27863] Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry --- When placing a new hold with pickup library match set to Item's Holding Library and AllowHoldPolicyOverride set to Allow, I am not given the option of setting a pickup branch other that the item's holdingbranch, with or without the patch. I should be able to pick whatever branch I want when placing the hold, rather than having to place it and then edit the pickup branch to something else. The changes to pickup branch selection on existing holds works great! I agree that it'd be good to have some indicator within that dropdown of which branches follow the rules and which require an override, though it makes sense to follow up on that in a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21472] Allow linking of $w subfields to 035 or 001+003 using the MarcOrgCode prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 --- Comment #9 from Heather --- Hi, Katrin! We have many examples, including: https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=16157 https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=15291 https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=31840 Let me know if any other specific 7XX example is needed, and I can mock up something. Cheerio! h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 --- Comment #6 from Martin Renvoize --- The more I think about this, the more I think perhaps that 'mandatory' is a purely UI concept in this case. I can see all sorts of reasons you may have added mandatory attributes.. but actually enforcing them would likely need to happen at whatever point the attribute should be getting looked at rather than at the point at which it's entered. Examples * An attribute that denotes permission to access certain resources at a certain branch. - This attribute is 'mandatory' as such at the point at which the patron wants to gain access to the resource.. they're either given permission or not. This is at a branch level and is mandatory in so much as it's required prior to being able to access the resource. We don't tie any logic to that mandatory for that action so in reality, it's only at the data entry via the existing UI that will take any notice of the mandatory flag.. I think the API can and probably should safely ignore the mandatory cases when they're not set as globally mandatory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #37 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #24) > And I don't understand how this didn't get into 20.11. My answer is 'yes'. But let's hear others! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Works as intended now, I think newest or oldest is the 'best' order in this case as opposed to the opposite. No regressions and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117936&action=edit Bug 27898: Make PUT /holds/:hold_id accept overrides This patch makes the route handle overriding pickup locations by passing the 'x-koha-override' header (set to 'any'). To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, because things cannot be overridden ATM. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117935&action=edit Bug 27898: Unit tests This patch adds unit tests for the PUT /holds/:hold_id route so it accepts the x-koha-override header and is able to override pickup location constraints. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 Martin Renvoize changed: What|Removed |Added Attachment #117555|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 117934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117934&action=edit Bug 27813: Restore default order on suggestion list view Prior to 20.05, suggestions on /cgi-bin/koha/suggestion/suggestion.pl sorted by suggesteddate by default. On 20.05 and later, they're sorting by title instead. We should go back to the previous behavior. Test plan: Create some suggestions Edit the suggestions.suggesteddate in the DB List the suggestions and confirm that there are sorted by new suggested date first Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27865 Depends on||27797 Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 [Bug 27797] Make POST /holds use the stashed koha.overrides https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] New: Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Bug ID: 27898 Summary: Make PUT /holds/:hold_id handle x-koha-override for pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com We need this so the UI can use the PUT route effectively. This is a follow-up for bug 27797 and needed on its descendents tree. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27860] Bad KohaAdminEmailAddress breaks patron self registration and password reset feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27860 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize --- Works as expected.. adding a warning on the about page is a 'nice to have'. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27860] Bad KohaAdminEmailAddress breaks patron self registration and password reset feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27860 Martin Renvoize changed: What|Removed |Added Attachment #117798|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 117933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117933&action=edit Bug 27860: Fix password recovery Same as the previous patch but for the password recovery feature. Test plan: 1. Do not apply the patches 2. Set KohaAdminEmailAddress to an invalid email (root@localhost for instance) 3. Use the password recovery feature 5. Boom (that must be fixed on a separate bug report) 6. Set KohaAdminEmailAddress to a valid email (r...@example.org) 7. Use again the password recovery for a different user 8. Still Boom! (because it's processing the first invalid email) 9. Apply the patches, restart_all 10. Try again the password recovery => The email is sent! Notice the change in DB, the first email is still there with status "pending" and second email is sent! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27860] Bad KohaAdminEmailAddress breaks patron self registration and password reset feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27860 Martin Renvoize changed: What|Removed |Added Attachment #117797|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 117932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117932&action=edit Bug 27860: Fix self-registration if messages with incorrect email are inqueued If the pref KohaAdminEmailAddress was not set correctly (invalid email) and has been used to generate message, the message_queue table can contain some messages that are not sent (pending) and will be processed each time a new self-reg is done. The PatronSelfRegistrationVerifyByEmail feature must send only the notice we just generated, not the whole pending queue. Test plan: 1. Do not apply the patches 2. Set KohaAdminEmailAddress to an invalid email (root@localhost for instance) 3. Turn on PatronSelfRegistrationVerifyByEmail 4. Self-reg a patron 5. Boom (that must be fixed on a separate bug report) 6. Set KohaAdminEmailAddress to a valid email (r...@example.org) 7. Self-reg a patron 8. Still Boom! (because it's processing the first invalid email) 9. Apply the patches, restart_all 10. Self-reg a patron => The email is sent! Notice the change in DB, the first email is still there with status "pending" and second email is sent! QA: at step 10. TODO first email must be 'failed' (highlight in tests) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27860] Bad KohaAdminEmailAddress breaks patron self registration and password reset feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27860 Martin Renvoize changed: What|Removed |Added Attachment #117796|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 117931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117931&action=edit Bug 27860: Add message_id param to SendQueuedMessages We could use C4::Letter::GetMessage, but the query in _get_unsent_messages join on borrowers and return the branchcode. To prevent any regressions it's preferable to not modify SendQueuedMessages. Ideally we obviously need a Koha methods to have better and clean code.. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27668] Improve validation of patron entry form in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27668 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Nice. But lot of changes. This is more en enhancement no ? Since it is for OPAC : Is it safe for backport on 20.11.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27777] Improve tables on Point of Sale page for low screen resolutions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.04 released in|| --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27776] Point of Sale 'This sale' table should not be sorted by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27776 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27717] Date of birth fails to display for babies under 1 year
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #36 from Fridolin Somers --- Do you think this may be backported to 20.11.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26742] Add configuration for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #23 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #99 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.04 released in|| --- Comment #20 from Fridolin Somers --- Nice little enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24623] Phase out jquery.cookie.js: Advanced MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24623 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24624] Phase out jquery.cookie.js: Receipt summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26960] Move batch item modification template JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26959] Reindent batch item modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #16 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #14 from Tomás Cohen Arazi --- Nick, can you give this a new QA round? I noticed pickup locations couldn't be overridden, and added a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.04 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #54 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 117930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117930&action=edit Bug 27797: (QA follow-up) Pickup locations can be overridden too This patch adds regression tests for overridding pickup locations, which was inadvertedly not covered by the original dev. What this does, is moving the $can_override variable definition above, and avoid returning 400 if conditions are not met for the passed pickup_library_id, when $can_override is true. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 117929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117929&action=edit Bug 27797: (QA follow-up) Make tests more robust This patch makes the tests mock things so the complex holds scenarios where existing data could interfere, don't get in the middle with what we need to test. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Nothing broke Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||joonas.kylm...@helsinki.fi, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 --- Comment #2 from Martin Renvoize --- Created attachment 117928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117928&action=edit BUg 27896: Remove DeleteTransfer This patch removes the last mentions of DeleteTransfer Test plan 1/ Grep the codebase for DeleteTransfer 2/ It should no longer exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 --- Comment #1 from Martin Renvoize --- Created attachment 117927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117927&action=edit Bug 27896: Remove DeleteTransfer from circ/return.pl This patch replaces the DeleteTransfer call in circ/returns.pl with a call to Koha::Item::Transfer->cancel. Test plan 1/ Check an item out 2/ Add a transfer request for the item to a second library 3/ Attempt to check the item in at the first library 4/ Note that you should be given a 'WrongTransfer' modal and have to option to cancel. 5/ Cancel the transfer 6/ Check in the database that the transfer now has 'datecancelled' set. 7/ Add a transfer for the item again 8/ From the transferstoreceive page cancel the transfer 9/ Click cancel and again check that datecancelled is set in the database for your transfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27897] PluginRoutes.t - deprecation warnings on D11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27897 Jonathan Druart changed: What|Removed |Added Summary|PluginRoutes.t - deprecated |PluginRoutes.t - |warnings on D11 |deprecation warnings on D11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27897] PluginRoutes.t - deprecated warnings on D11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27897 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27897] New: PluginRoutes.t - deprecated warnings on D11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27897 Bug ID: 27897 Summary: PluginRoutes.t - deprecated warnings on D11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org t/db_dependent/Koha/REST/Plugin/PluginRoutes.t 16:24:23 koha_1 | Mojolicious::Routes::Route::via is DEPRECATED in favor of Mojolicious::Routes::Route::methods at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 265. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
Martin Renvoize changed:
What|Removed |Added
Depends on|27281 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What|Removed |Added Depends on||27896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 [Bug 27896] Remove C4::Circulation::DeleteTransfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Martin Renvoize changed: What|Removed |Added Blocks||22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added Blocks||27896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 [Bug 27896] Remove C4::Circulation::DeleteTransfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896
Martin Renvoize changed:
What|Removed |Added
Depends on||27281
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27896] New: Remove C4::Circulation::DeleteTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 Bug ID: 27896 Summary: Remove C4::Circulation::DeleteTransfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We have just one call to DeleteTransfer left.. we should replace it with Koha::Item::Transfer->cancel and then drop DeleteTransfer entirely :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
