[Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #21 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 23352: Default setting of item price, replacement price, ccode, dateaccesioned in serials-edit.pl Using index info to reconstruct a base tree... M C4/Items.pm M C4/Serials.pm M Koha/Schema/Result/Subscription.pm M installer/data/mysql/kohastructure.sql A installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/serials.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Subscription.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Subscription.pm Auto-merging C4/Serials.pm Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23352: Default setting of item price, replacement price, ccode, dateaccesioned in serials-edit.pl ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28110] YAML::XS minimum version should be 0.67, not 0.41
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28110 --- Comment #5 from Mason James --- (In reply to Jonathan Druart from comment #2) > This was done for U16 support. > > Mason, can you have a look at this patch please? hi Jonathan, this looks ok to me i have built a new yaml 0.82 package for U16, from cpan root@u16:~# apt-cache policy libyaml-libyaml-perl libyaml-libyaml-perl: Installed: (none) Candidate: 0.82-1+koha2 Version table: 0.82-1+koha2 500 500 http://debian.koha-community.org/koha stable/xenial amd64 Packages 0.76+repack-1~bpo9+1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages 0.41-6build1 500 500 http://apt.kohaaloha.com:3142/ftp.nz.debian.org/ubuntu xenial/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- I agree that having more meaningful descriptions here is much more useful than just the code. Only a really very trivial comment - should the options have a full stop at the end of the sentence? The option descriptions are full sentences and it would normally makes sense to have a full stop. However, it looks a little out of place with all the other drop down lists that don't. Either way, it is a nice improvement over the way it is now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind changed: What|Removed |Added Attachment #119372|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 119439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119439&action=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28119] Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27830] OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 David Nind changed: What|Removed |Added Attachment #117731|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 119438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119438&action=edit Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27830] OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |In Discussion --- Comment #13 from David Nind --- Hi Ítalo. As this patch is not formatted the "normal" way, then the development environments we use don't work - so I'm not able to test and sign off the usual way. See the Developer Handbook, https://wiki.koha-community.org/wiki/Developer_handbook and look for : - the Development workflow (https://wiki.koha-community.org/wiki/Development_workflow) - submitting a patch https://wiki.koha-community.org/wiki/Submitting_A_Patch - commit messages https://wiki.koha-community.org/wiki/Commit_messages There is a bit of a hurdle to get these things in! Feel free to ask for help on how to do this on the bug, Development email list, or IRC (there are times where there are more people around to help - day time European and US time zones are probably better, it is normally very quiet over the weekend). I'm not a developer, so I don't think I will be much help in getting your patch formatted and attached to Bugzilla the right way... I'm also not sure whether the variable names need to be English (as per comment #11 and #12) - something some of the developers will be able to answer. I've changed status to In Discussion in the meantime until it is ready for sign off. David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Nind --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26684: Remove marc from auth_header for new installs Using index info to reconstruct a base tree... M C4/AuthoritiesMarc.pm M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/AuthoritiesMarc.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26684: Remove marc from auth_header for new installs Also, is there a test plan? I have no idea how to test this one... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #60 from David Nind --- Patch still applies! Failed test still though: - not ok 30 - AddReturn + CumulativeRestrictionPeriods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #15 from David Nind --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18618: Mana - Add scripts to send readings Applying: Bug 18618: Mana - Add reading suggestion Using index info to reconstruct a base tree... M Koha/Biblio.pm M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging Koha/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18618: Mana - Add reading suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |In Discussion --- Comment #9 from David Nind --- Changed status to in discussion... feel free to change back when/if ready for sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Hi Kyle. I get this message when applying the patch (after applying 27883): Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27920: Add ability to update patron expiration dates when importing patrons error: sha1 information is lacking or useless (Koha/Patrons/Import.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27920: Add ability to update patron expiration dates when importing patrons ... David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 David Nind changed: What|Removed |Added Attachment #119371|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 119437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119437&action=edit Bug 27883: (follow-up) Make label match input id This change alters the list of columns under "Preserve existing values," changing the label for each checkbox can be clicked to trigger the checkbox change. To test, apply the patch and refresh the patron import page. Expand the "Preserve existing values" section and click any label in the list. The corresponding checkbox should be checked. Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 David Nind changed: What|Removed |Added Attachment #119370|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 119436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119436&action=edit Bug 27883: Add ability to preserve patron field from being overwritten by import Some libraries would like to be able to preserve particular fields for existing patrons when overwriting them via the patron import tool. Effectively, this means the specified columns of the CSV are used for new patrons, but ignored for existing patrons. Test Plan: 1) Create a patron CSV with one new patron, make the surname and firstname "Test1". Add a cardnumber so we can upload it again later. 2) Import the file 3) Change the firstname and surname in the CSV to "Test2" 4) Return to the patron import tool, choose to match on cardnumber, overwrite existing patrons, and preserve exiting firstnames 5) Import the file with these settings 6) Referesh the patron details for this patron, the patron's surname should still be "Test" while the firstname should now be "Test2" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27864] Visual feedback on overridden pickup locations when placing biblio-level hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Patch no longer applies 8-(.. 118232 - Bug 27864: Visual feedback on overridden pickup locations when placing hold 118236 - Bug 27864: Correct dropdown size Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27864: Visual feedback on overridden pickup locations when placing hold error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27864: Visual feedback on overridden pickup locations when placing hold Testing notes: - To setup for testing follow the test plan as for bug 27863: . In Circulation and fines rules > Default checkout, hold and return policy, change 'Hold pickup library match' to 'item's home library' . Set AllowHoldPolicyOverride system preference to Allow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #1 from Lucas Gass --- Created attachment 119435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119435&action=edit Bug 28127: add transaction timestampt to register details tables To Test: -Enable POS and setup some registers -Make some transactions -Go to Point of Sale > Register details and look at the two tables, sales and past sales -No timestamp or transaction date -Apply patch and look again -See Tranactions dates in the Transaction column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] New: POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Bug ID: 28127 Summary: POS register details tables should have a transaction date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Some librarians would fine it useful to include the transaction timestamp when viewing the two register detail tables (sales and past_sales). The tables are a bit in different than others in Koha, transaction occupy two table rows and the description spans 2 columns. This leaves some table cells unused. Rather than adding a new column to these tables I purpose adding the transaction timestamp into the unused in the Transaction column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
