[Koha-bugs] [Bug 28172] New: Optimize Koha::Plugins::GetPlugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 Bug ID: 28172 Summary: Optimize Koha::Plugins::GetPlugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 --- Comment #1 from Julian Maurice --- Created attachment 119870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119870&action=edit Bug 28172: [DO NOT PUSH] Test script for GetPlugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172
--- Comment #2 from Julian Maurice ---
Created attachment 119871
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119871&action=edit
Bug 28172: Optimize Koha::Plugins::GetPlugins
Instead of doing one SQL query for retrieving a list of plugin classes
(filtered or not by a method name) + one SQL query for each loaded
plugin (to look up the 'enabled' status), we can do a single SQL query,
fetching only enabled plugins, and do the method check using `can`.
It allows to use the Module::Load::Conditional cache when requesting
only enabled modules, which gives a great performance boost
Also, call get_metadata only if needed
Test plan:
1. Make sure you have some plugins enabled
2. Apply the 1st patch ("Test script for GetPlugins")
3. Run the test script several times, copy each result into a file A
4. Apply the other patch(es)
5. Run the test script several times, copy each result into another
file B
6. Compare the results. Times in file B should be smaller than in file A
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 --- Comment #3 from Julian Maurice --- Without the patch: % ./test_getplugins.pl 2 plugins detected, 2 enabled First 2 calls to GetPlugins: 0.533s 1000 calls to GetPlugins: 3.505s 1000 calls to GetPlugins with method = "unknown_method": 0.824s 1000 calls to GetPlugins with all = 1: 3.580s With the patch: % ./test_getplugins.pl 2 plugins detected, 2 enabled First 2 calls to GetPlugins: 0.535s 1000 calls to GetPlugins: 1.502s 1000 calls to GetPlugins with method = "unknown_method": 0.730s 1000 calls to GetPlugins with all = 1: 3.795s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] New: Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Bug ID: 28173 Summary: Add plugin hooks object_store_pre and object_store_post Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 --- Comment #1 from Julian Maurice --- Created attachment 119872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119872&action=edit Bug 28173: Add plugin hooks object_store_pre and object_store_post These two hooks are called in Koha::Object::store, which means any object stored in the database will trigger these hooks. object_store_pre is called just before `update_or_insert`, allowing to modify the object before sending the INSERT/UPDATE query object_store_post is called just after `update_or_insert`, so it can be used for any actions that require to have the final object, like indexing, logging, ... Test plan: 1. prove t/db_dependent/Koha/Plugins/Object_hooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119652|0 |1 is obsolete|| --- Comment #102 from Henry Bolshaw --- Created attachment 119873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119873&action=edit Bug 26703: modules and modules/acqui folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119653|0 |1 is obsolete|| --- Comment #103 from Henry Bolshaw --- Created attachment 119874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119874&action=edit Bug 26703: admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119654|0 |1 is obsolete|| --- Comment #104 from Henry Bolshaw --- Created attachment 119875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119875&action=edit Bug 26703: authorities, basket and batch folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119655|0 |1 is obsolete|| --- Comment #105 from Henry Bolshaw --- Created attachment 119876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119876&action=edit Bug 26703: catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119656|0 |1 is obsolete|| --- Comment #106 from Henry Bolshaw --- Created attachment 119877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119877&action=edit Bug 26703: cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119657|0 |1 is obsolete|| --- Comment #107 from Henry Bolshaw --- Created attachment 119878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119878&action=edit Bug 26703: circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119658|0 |1 is obsolete|| --- Comment #108 from Henry Bolshaw --- Created attachment 119879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119879&action=edit Bug 26703: clubs, common & course_reserves folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119659|0 |1 is obsolete|| --- Comment #109 from Henry Bolshaw --- Created attachment 119880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119880&action=edit Bug 26703: errors, ill and installer folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119660|0 |1 is obsolete|| --- Comment #110 from Henry Bolshaw --- Created attachment 119881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119881&action=edit Bug 26703: labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119661|0 |1 is obsolete|| --- Comment #111 from Henry Bolshaw --- Created attachment 119882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119882&action=edit Bug 26703: members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119662|0 |1 is obsolete|| --- Comment #112 from Henry Bolshaw --- Created attachment 119883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119883&action=edit Bug 26703: offline_circ and onboarding folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119663|0 |1 is obsolete|| --- Comment #113 from Henry Bolshaw --- Created attachment 119884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119884&action=edit Bug 26703: patroncards and patron_lists folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119664|0 |1 is obsolete|| --- Comment #114 from Henry Bolshaw --- Created attachment 119885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119885&action=edit Bug 26703: plugins and pos folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119665|0 |1 is obsolete|| --- Comment #115 from Henry Bolshaw --- Created attachment 119886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119886&action=edit Bug 26703: reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119666|0 |1 is obsolete|| --- Comment #116 from Henry Bolshaw --- Created attachment 119887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119887&action=edit Bug 26703: reserve, reviews & rotating_collections folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119667|0 |1 is obsolete|| --- Comment #117 from Henry Bolshaw --- Created attachment 119888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119888&action=edit Bug 26703: serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119668|0 |1 is obsolete|| --- Comment #118 from Henry Bolshaw --- Created attachment 119889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119889&action=edit Bug 26703: suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestion and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119669|0 |1 is obsolete|| --- Comment #119 from Henry Bolshaw --- Created attachment 119890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119890&action=edit Bug 26703: tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119670|0 |1 is obsolete|| --- Comment #120 from Henry Bolshaw --- Created attachment 119891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119891&action=edit Bug 26703: virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119671|0 |1 is obsolete|| --- Comment #121 from Henry Bolshaw --- Created attachment 119892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119892&action=edit Bug 26703: (follow-up) Reverse title for mana report search results Signed-off-by: Martin Renvoize Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119820|0 |1 is obsolete|| --- Comment #122 from Henry Bolshaw --- Created attachment 119893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119893&action=edit Bug 26703: (follow-up) corrected aqbudgets title Corrected the admin/aqbudgets file so that the page title displays correctly. To test: 1) Go to staff client 2) Go to admins module 3) Go to aqbudgets page 4) Check that the page title is "Funds > Administration > Koha" 5) Check that when modifying a fund the page title is "Modify Fund > Funds > Administration > Koha" or "Modify Fund [Fund Name] > Funds > Administration > Koha" 6) Check that when adding a fund the page title is "Add Fund > Funds > Administration > Koha" Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Henry Bolshaw changed: What|Removed |Added Attachment #119824|0 |1 is obsolete|| --- Comment #123 from Henry Bolshaw --- Created attachment 119894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119894&action=edit Bug 26703: (follow-up) corrected currencies title Corrected the page title in the admin/currency file. To test: 1) Go to staff client 2) Go to admin/currency 3) Check that the page title is "Currencies > Currencies & Exchange rates > Administration > Koha" 4) Check that when adding a currency, the page title is "New currency > Currencies & Exchange rates > Administration > Koha" 5) Check that when modifying a currency, the page title is "Modify currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" 6) Check that when deleting a currency, the page title is "Confirm deletion of currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 --- Comment #6 from Thomas Klausner --- Anything I can do to make sure this fix gets in the next release? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #124 from Henry Bolshaw --- Created attachment 119895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119895&action=edit Bug 26703: (follow-up) remove starting separator from csv profiles title Rearranged the separators in the csv profiles page title to match other page title formats. To test: 1) Go to the staff client 2) Go to the CSV profiles page in the Tools module 3) Check that the page title is "CSV export profiles › Tools › Koha" 4) Check that the page title when adding a new profile is "New CSV profile › CSV export profiles › Tools › Koha" 5) Check that the page title when editing a profile is "Modify a CSV profile › CSV export profiles › Tools › Koha" Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Peter Vashchuk changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 Peter Vashchuk changed: What|Removed |Added Attachment #119869|0 |1 is obsolete|| --- Comment #2 from Peter Vashchuk --- Created attachment 119896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119896&action=edit Bug 28171: Serial enumeration / chronology sorting is broken in biblio page This patch updates the bibliographic detail page so that the "Serial enumeration/chronology" column is sorted by published date only if a published date is present. To test, apply the patch and locate a bibliograhpic record for a subscription that has multiple items. On the bibliographic detail page, confirm that the "Serial enumeration/chronology" column sorts correctly. Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #125 from Henry Bolshaw --- Hi Wainui and Martin, I've signed off all of the patches now. (Great work Wainui! The testing took a long time so I can only imagine how long it took to fix everything!) I noticed that there was an extra '›' at the start of the CSV profiles page title so I've added a trivial follow up patch to fix that. I've left the status at needs signoff because that patch hasn't been checked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #119895|0 |1 is obsolete|| --- Comment #126 from wainuiwitikap...@catalyst.net.nz --- Created attachment 119897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119897&action=edit Bug 26703: (follow-up) remove starting separator from csv profiles title Rearranged the separators in the csv profiles page title to match other page title formats. To test: 1) Go to the staff client 2) Go to the CSV profiles page in the Tools module 3) Check that the page title is "CSV export profiles › Tools › Koha" 4) Check that the page title when adding a new profile is "New CSV profile › CSV export profiles › Tools › Koha" 5) Check that the page title when editing a profile is "Modify a CSV profile › CSV export profiles › Tools › Koha" Signed-off-by: Henry Bolshaw Signed-off-by: Wainui Witika-Park -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #127 from wainuiwitikap...@catalyst.net.nz --- (In reply to Henry Bolshaw from comment #125) > Hi Wainui and Martin, I've signed off all of the patches now. (Great work > Wainui! The testing took a long time so I can only imagine how long it took > to fix everything!) > > I noticed that there was an extra '›' at the start of the CSV profiles page > title so I've added a trivial follow up patch to fix that. I've left the > status at needs signoff because that patch hasn't been checked. Hi Henry! Thanks so much, that's awesome! I've signed off your patch, thanks heaps for that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #15 from Martin Renvoize --- Created attachment 119898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119898&action=edit Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling ModItemTransfer is still used, sparingly. It force cancels transfers regardles of whether they are already marked as in_transit. We do not, however, want to enqueue a return transfer in this case as ModItemTransfer is itself an enqueue function. This patch updates the internal logic of ModItemTransfer to enqueue the passed transfer prior to cancelling the pre-existing one.. in this way the result is one cancelled transfer and one new transfer and not three transfers. Test plan 1/ Run t/db_dependant/Items.t and verify it fails prior to applying this patch 2/ Apply patch and run the test again, verifying it now passes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28174] New: Add ability to limit item modification to current library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28174 Bug ID: 28174 Summary: Add ability to limit item modification to current library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Before we can deprecate IndependantBranches and use Library Groups as a replacement, we need the ability to limit item modifications to only those items belonging to the branch/branches the librarian has permissions/access to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28174] Add ability to limit item modification to current library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28174 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28174] Add ability to limit item modification to current library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28174 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize changed: What|Removed |Added Attachment #119762|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 119899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119899&action=edit Bug 12362: Add 'TransferCancellation' as a transfer reason This patch adds the database update to add 'TransferCancellation' as a reason for transfer. Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize changed: What|Removed |Added Attachment #119763|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 119900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119900&action=edit Bug 12362: Reverse transfer upon cancellation This patch adds a reverse transfer if a transfer is cancelled whilst it is in transit. This makes sure the item returns to it's original location. Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize changed: What|Removed |Added Attachment #119764|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 119901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119901&action=edit Bug 12362: Cancel transfer with hold cancelation This patch adds a transfer cancellation when a hold is cancelled. Test plan 1/ Check an item out from it's homebranch 2/ Place a hold on that item for another user at a different branch 3/ Check the item in at it's homebranch and accept the transfer 4/ Cancel the hold 5/ Change to the second branch and check the item in 6/ Note that a transfer is triggered with the reason 'Transfer was cancelled whilst in transit' Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize changed: What|Removed |Added Attachment #119898|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 119902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119902&action=edit Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling ModItemTransfer is still used, sparingly. It force cancels transfers regardles of whether they are already marked as in_transit. We do not, however, want to enqueue a return transfer in this case as ModItemTransfer is itself an enqueue function. This patch updates the internal logic of ModItemTransfer to enqueue the passed transfer prior to cancelling the pre-existing one.. in this way the result is one cancelled transfer and one new transfer and not three transfers. Test plan 1/ Run t/db_dependant/Items.t and verify it fails prior to applying this patch 2/ Apply patch and run the test again, verifying it now passes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #20 from Martin Renvoize --- Minor rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 --- Comment #9 from Rudolf Byker --- Do you mean that they are only stripped out when displayed in the browser? In that case, all is well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
Bohdan changed:
What|Removed |Added
CC||b.paster...@gmail.com
--- Comment #36 from Bohdan ---
Hello. I've installed Koha 20.11.04 on latest Debian 10 and the API is broken.
I cannot get the list of available branches as it uses API.
Got the following in api error logs:
[ERROR] Warning: Could not load REST API spec bundle: Can't use string
("parameters.json") as a HASH ref while "strict refs" in use at
/usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 272.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 --- Comment #7 from Martin Renvoize --- Created attachment 119903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119903&action=edit Bug 28022: Only show subfield "9" if subfield "a" is visible Amend the workaround (from but 2206) to only show subfield "9" in editor if subfield "a" has the editor-visibility bit set. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Martin Renvoize changed: What|Removed |Added Attachment #119123|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28022] MARC subfield 9 not honoring visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Thanks for your submission Thomas, my apologies it took me a little while to come around to testing it... so many things on the list. Signing off as it works as described and I can't see any obvious regressions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #129 from Martin Renvoize --- (In reply to Joonas Kylmälä from comment #128) > (In reply to Joonas Kylmälä from comment #127) > > It will work, it supports both, the 003 will be used only for further > > disambiguation in case the records have it. See also bug 27507. > > Also to further elaborate, the adding of 003 is to fully support the marc > format, see https://www.loc.gov/marc/bibliographic/bd773.html for examples > of 773$w. I've wanted to add the use of 003 for ages but never got around to it.. Nice one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #130 from Martin Renvoize --- As an asside, once we push this, it would be great to have another look at the relevant wiki pages an make sure they reflect these updates: https://wiki.koha-community.org/wiki/Multipart_Bibliographics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What|Removed |Added Attachment #115528|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 119904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119904&action=edit Bug 27507: Specify organization code when searching host record This allows now importing records to Koha database from multiple different organizations and keeps the "In: XXX" links in the catalogue/detail.pl page unique. To test: 1) Add host record with 001 and 003 values of "1234" and "TEST" 2) Add host record with 001 and 003 values of "1234" and "TEST2" 2) Add component record with 773w value of (TEST)1234 3) Notice the link in the component record goes to search page with two results 4) Apply patch 5) Notice the link in the component record goes directly to the first host record created with 001 = 1234 and 003 = TEST 6) Test also that if you modify the 773w link with just the value of "1234" the search will still work and give you two results Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- This works as described and is something I've wanted to do for a while myself since first deep-diving into multi-part bibliographies. Caveat, I wrote a lot of the details on the wiki around this area of functionality many years ago and most of that detail has since left my brain.. I'm not a cataloguer so can't really comment as to how correct this is vs how much of this goes on in the real world.. how backwards compatible it is. I'd love to see a more library focused QA person get to grips with that side.. the dev side of me loves this refinement. Wiki pages: https://wiki.koha-community.org/wiki/Multipart_Bibliographics -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28170] Downloading some files via Tools - Upload is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28170] Downloading some files via Tools - Upload is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Owen Leonard changed: What|Removed |Added Attachment #119865|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 119905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119905&action=edit Bug 28170: Fix upload.tt search result buttons for page two onwards From https://datatables.net/faqs/index "When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 --- Comment #128 from Martin Renvoize --- I've given the whole patchset another run-through and am happy to call PQA on it.. Great teamwork at the end there fixing up the last few minor points. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #18 from Owen Leonard --- I was hoping to test this last followup on a sandbox, but the PTFS-E sandboxes don't appear to accept uploads, and the ByWater sandboxes have been down for ages. I don't know how else to test this in an environment that isn't considered by the browser to be secure for the purposes of copy and paste operations (as local addresses are). If anyone is able to test this I'd appreciate it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #19 from Owen Leonard --- (In reply to Owen Leonard from comment #18) > If anyone is able to test this I'd appreciate it. Never mind, something is still broken... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Attachment #119398|0 |1 is obsolete|| --- Comment #20 from Owen Leonard --- Created attachment 119906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119906&action=edit Bug 27594: (follow-up) Check for secure context -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] New: Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Bug ID: 28175 Summary: Usability improvements to uploads page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 28170 I propose a few changes to the uploads page to make it easier to work with: - Add a toolbar with an "Upload" button so that it can be accessed from the upload results or search results views - On views other than the "main" view, add search forms to the sidebar - Show the upload category description instead of the code - Link the upload category in search results to a search for that category Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 [Bug 28170] Downloading some files via Tools - Upload is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28170] Downloading some files via Tools - Upload is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28170 Owen Leonard changed: What|Removed |Added Blocks||28175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 [Bug 28175] Usability improvements to uploads page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
--- Comment #37 from Mason James ---
(In reply to Bohdan from comment #36)
> Hello. I've installed Koha 20.11.04 on latest Debian 10 and the API is
> broken. I cannot get the list of available branches as it uses API.
>
> Got the following in api error logs:
> [ERROR] Warning: Could not load REST API spec bundle: Can't use string
> ("parameters.json") as a HASH ref while "strict refs" in use at
> /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 272.
hi Bohdan,
are you using 64-bit debian? it is recommended
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 --- Comment #1 from Owen Leonard --- Created attachment 119907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119907&action=edit Bug 28175: Usability improvements to uploads page This patch makes a variety of changes to the uploads page in order to improve usability: - Add a toolbar with an "Upload" button so that it can be accessed from the upload results or search results views - On views other than the "main" view, add search forms to the sidebar - The search form markup has been modified somewhat in order to make it work well in both the sidebar and the main body of the page. - Show the upload category description instead of the code - Link the upload category in search results to a search for that category The "enctype" attribute has been removed from the search forms because it is unnecessary and causes form resubmission errors in some browsers (Firefox at least). To test, apply the patch and make sure you have at least one entry under Authorized values for the category UPLOAD. - Go to Tools -> Upload. - Upload a file, adding a category as you do so. - On the upload results page, test that the "Upload file" button returns you to the main upload page. - On the upload results or search results view, confirm that the "Search uploads by category" and "Search uploads by name" forms work correctly. - When viewing upload or search results, confirm that the category discription is shown instead of the code. Confirm that the category is a link to a search for other files in that category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] New: Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Bug ID: 28176 Summary: Transfer not created for items returning home if confirmed with "Yes, print slip" button Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If an items is to be transferred home after being checked out at a different branch, the "Yes, print slip" button does not generate the transfer, but the "Yes" button does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 --- Comment #1 from Kyle M Hall --- Created attachment 119908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119908&action=edit Bug 28176: Transfer not created for items returning home if confirmed with "Yes, print slip" button If an items is to be transferred home after being checked out at a different branch, the "Yes, print slip" button does not generate the transfer, but the "Yes" button does. Test Plan: 1) Set AutomaticItemReturn to "Don't" 2) Place a hold for pickup at a different branch 3) Check in the item, confirm the hold and transfer 4) Check in the item at the pickup branch 5) Check the item out to the patron 6) Check the item in at the pickup branch 7) Confirm the transfer back to the home library with the "Yes, print slip" button 8) Check the branchtransfers table, not there is not open transfer 9) Apply this patch, repeat steps 1-8 10) Note the branch transfer was created! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28177] New: Add date column and column configuration to uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Bug ID: 28177 Summary: Add date column and column configuration to uploads Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 28175 I think it would be useful to add a date column to the table showing uploaded files. Adding column configuration at the same time will let us hide the column by default. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 [Bug 28175] Usability improvements to uploads page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28175] Usability improvements to uploads page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28175 Owen Leonard changed: What|Removed |Added Blocks||28177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 [Bug 28177] Add date column and column configuration to uploads -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #9 from Martin Renvoize --- Looking into this... Moving to the circulation rules adds an additional question.. Whilst I can understand the want to add rules at itemtype and patron category levels.. would there also be a need to do this at a branch level too... and if that is the case.. which branch would govern the looking.. the pickup location, the items home library, the items current holding library?.. it opens a bit of a can of worms ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 --- Comment #2 from Owen Leonard --- I think this is a duplicate of Bug 28064 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28176] Transfer not created for items returning home if confirmed with "Yes, print slip" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28176 Kyle M Hall changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 28064 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28064] Transits are not created at check in despite user responding 'Yes, print slip' to the prompt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28064 --- Comment #15 from Kyle M Hall --- *** Bug 28176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #10 from Martin Renvoize --- Aha, GetReservesControlBranch deals with this for us already.. so it's a non-issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26116] Allow multiple suppression values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26116 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #2 from Sarah Cornell --- +1! In order to make it easier for staff to assign the suppression value, I redefined 1 to "Suppressed in OPAC" but now the line "Suppressed in OPAC" doesn't display on search results or detail pages. More flexibility in defining suppression values, please! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #11 from Martin Renvoize --- (In reply to Martin Renvoize from comment #10) > Aha, GetReservesControlBranch deals with this for us already.. so it's a > non-issue. Humm.. actually, it doesn't. `GetReservesControlBranch` requires an item (for the case where `ReservesControlBranch` is set to 'ItemHomeLibrary'). However, at the time of reserve we don't always have that information yet (Bib level holds).. so for the case where we charge at the point of placing a hold and we allow biblio level holds.. we would explode. Rethink needed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #3 from Joonas Kylmälä --- Hmm, the proposed solution here is not like it was before bug 27980. Before we sorted either with publisheddate alone if one of the items had it at least, but now with this we would sort both of the values. This seems okay because how this seems to work now is that the ones with the data-order attribute set (so publisheddate) are sorted as one group and then the ones without data-order are sorted as another group. So both get sorted, but separately. Owen, do you think this change in sorting order is okay? Previously the ones without publisheddate didn't get sorted so this might actually be improvement but want to hear your opinion as well. Also I didn't find any documentation for this in DataTables manual so we might also want to consider if we should depend on this and whether the sorting order will possibly change in future if DataTables changes some code because it seems undocumented feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #12 from Martin Renvoize --- Created attachment 119909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119909&action=edit Bug 3492: Begginings of moving holds_fee rule to circulation rules -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3492] Set hold fees by item type and charge when hold placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #13 from Martin Renvoize --- This is just a starting point so far.. not complete yet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] New: Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Bug ID: 28178 Summary: Image viewer does not select the correct image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 --- Comment #1 from Jonathan Druart --- Created attachment 119910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119910&action=edit Bug 28178: Display the correct image in the image viewer When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. Test plan: 0. Turn on LocalCoverImages and AllowMultipleCovers 1. Attach at least two images to a bibliographic record 2. Go to the detail page, click the "Images" tab and click the second image. => With this patch applied you should see the image you selected Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] New: Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Bug ID: 28179 Summary: Use a lightbox gallery to display the images - detail page, staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 28178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 [Bug 28178] Image viewer does not select the correct image -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28178] Image viewer does not select the correct image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28178 Jonathan Druart changed: What|Removed |Added Blocks||28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] New: Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Bug ID: 28180 Summary: Use a lightbox gallery to display the images - detail page, OPAC interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 28179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Jonathan Druart changed: What|Removed |Added Blocks||28180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
Martin Renvoize changed:
What|Removed |Added
Attachment #119851|0 |1
is obsolete||
--- Comment #17 from Martin Renvoize ---
Created attachment 119911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119911&action=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules
Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge
in circulation rules per specific items/patron categories.
When value not found in circulation rules it uses global
ExpireReservesMaxPickUpDelayCharge, as it was before this smart-rules
feature was introduced.
To check the feature after applying the patch:
1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added "Expire reserve charge" row.
2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
3) Prepare an item for our next step, pick a biblio that has item
with the same item type you altered in smart rules and check it out.
3) Place a hold on that item and set the expiration date as the
next day.
4) Check in it after that.
5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE
`reserve_id`=329;"
Or alternatively:
5) Wait for tomorrow, change server time or invent a time machine.
6) Run cancel_expired_holds.pl cron job.
7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount
of fee you assigned in that rule
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
8) You can repeat this with other rules and different
numbers/biblio/item types to check that different fees apply according
to smart rules.
9) If there's no matching smart rule or smart rule have an empty
string as a fee - global ExpireReservesMaxPickUpDelayCharge variable
value will be used.
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
IMPORTANT:
Smart-rules filters only applied to item-level holds when item-type
for items is known. If there's biblio-level hold, in that case global
ExpireReservesMaxPickUpDelayCharge value will be used).
Mentored-by: Andrew Nugged
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #18 from Martin Renvoize --- Created attachment 119912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119912&action=edit Bug 25711: (QA follow-up) Refactor to clarify logic At the point where 'ExpireReservesMaxPickUpDelayCharge' can/should kick in, we should already have an item waiting (else what's triggered a pickup delay). As such we can drop the fall through default of using the syspref when we don't yet have an item. We can also save us some calculations and database hits by only calculating the charge value when we've actually been asked to charge. So we also move the block inside the 'charge_cancel_fee' block. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #19 from Martin Renvoize --- I believe this works as described.. I did a little followup to clean up the code a little whilst I was wrapping my head around the various failure clauses. Signing off so Joonas can move on to QA ;).. He's certainly the expert in these parts at the moment and looks to be progressing nicely with a code review.. so I'll encourage him to continue :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171 --- Comment #4 from Owen Leonard --- I'm glad to have your detailed feedback, because I don't have good serials data to test with and I wasn't sure I was mocking it up correctly. I don't know the answer to whether the grouped sorting is better, so I defer to your opinion. What feature do you mean when you say it isn't documented? The data-order sorting option is documented here: https://datatables.net/examples/advanced_init/html5-data-attributes.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
