[Koha-bugs] [Bug 14239] Bibframe support in Koha

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239

--- Comment #4 from David Cook  ---
(In reply to Magnus Enger from comment #3)
> Almost 6 years has gone by. What do we think about BIBFRAME today?

The only time I ever hear about BIBFRAME is in the context of Ex Libris Alma
and it looks like they just map their internal format into BIBFRAME for
export/display:
https://developers.exlibrisgroup.com/alma/integrations/linked_data/bibframe/

I haven't heard anything about it in years really. Its name gets mentioned here
or there in some professional librarian circles but nothing significant that
I've noticed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25950] REMOTE_ADDR set to null if client_ip in X-Forwarded-For matches a koha_trusted_proxies value

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25950

--- Comment #17 from David Cook  ---
(In reply to Jonathan Druart from comment #16)
> Maybe not random, it failed once again on D11 (run 266)

Is it happening every time?

If so, what version of Net::Netmask is installed on D11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979

--- Comment #16 from David Cook  ---
(In reply to Joonas Kylmälä from comment #14)
> It would probably make sense to split this to two functions: one for title
> search and another for isbn? Makes also unit tests easier, less cases to
> iterate.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

--- Comment #135 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Jonathan Druart from comment #130)
> What about those ones?
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt:Koha
>  Administration  Library checkin and transfer policy
> 
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:Koha 
> 
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfers_to_send.tt:
> Koha  Circulation  Transfers to send

Hi Jonathan! Thanks so much for pointing these out, not sure how these were
missed.

I have added a follow-up patch to amend these.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

--- Comment #134 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119982=edit
Bug 26703: (follow-up) fixed some page titles in files

Swapped the order of the page titles to have the unique information
first, i.e. the name of the specific page displays first, and the name
of the website (e.g. Koha) displays at the end.

To test:
1) Apply patch
2) Esnure each othe files auth.tt, admin/transfer_limits.tt and
circ/transfers_to_send.tt have page titles that are swapped around to
display the most unique information first, and the wensite name is at
the end
3) Esnure the pages displayed on the Staff Client that correspond to
these files also display the changes

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 Attachment #119958|0   |1
is obsolete||

--- Comment #34 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 119981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119981=edit
Bug 27740: (follow-up) changed "User summary" css

Changed user summary CSS to style H2 not H3 heading

To test:
1) Go to OPAC homepage
2) Login as a user with at least one loan
3) See that the "User summary" heading is not styled
4) Apply patch
5) Run yarn build --view OPAC
6) Confirm the heading is now styled with grey background

Signed-off-by: Wainui Witika-Park 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch.

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428

Ivan Dziuba  changed:

   What|Removed |Added

 Attachment #117950|0   |1
is obsolete||

--- Comment #10 from Ivan Dziuba  ---
Created attachment 119980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119980=edit
Bug 27428: Show the number of records in the bibliographic record detail page
with ElasticSearch.

Tests:
1. Apply this patch;
2. In the Preference system - OPACDisplayRecordCount -> Show;
3. We can see the number of records next to search links in the bibliographic
record detail page in the OPAC.

Bug 27113: ElasticSearch: Autocomplete in input search. Use Unicode::Normalize
instead Text::Unaccent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Ivan Dziuba  changed:

   What|Removed |Added

 Attachment #116293|0   |1
is obsolete||

--- Comment #13 from Ivan Dziuba  ---
Created attachment 119979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119979=edit
Bug 27113: ElasticSearch: Autocomplete in input search

Bug 27113: ElasticSearch: Autocomplete in input search. Fix bugs.

Bug 27113: ElasticSearch: Autocomplete in input search. Use Unicode::Normalize
instead Text::Unaccent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25395] Enumchron needs to sort numerically

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25395

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371

--- Comment #18 from David Nind  ---
I'm not a cataloguer, and don't understand all the nuances here, so it may pay
for someone familiar with this to review as well.

Testing notes:
- Followed the test plan
- Added the cutter plugin to 050$a (most likely this isn't technically correct,
but it shows the code being generated by cutter.pl)
- Used koha-testing-docker and the sample data, tested with a couple of records
- Programming Perl / Tom Christiansen, Brian D. Foy & Larry Wall. (Record
number 262) 
  . classification code generated: C555p (C = first letter of author; 555 =
from table in source code from surname; p = first letter of the title)
  . changed indicator 2 for 245 to 4: code generated = C555r (next character in
the title after 4 characters, that is, the 5th character)
- Perl Better Practices (Record number 191):
  . added corporate author to 110$a (1151 Academia Sinica, Nanking. Inst. of
Soil Science)
  . classification code generated: A168p (A = first letter of author; 168 =
from table in source code for aca; p = first letter of the title)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371

David Nind  changed:

   What|Removed |Added

 Attachment #119796|0   |1
is obsolete||

--- Comment #17 from David Nind  ---
Created attachment 119978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119978=edit
Bug 22371: Add MARC21 cataloguing plugin to generate Cutter-Sanborn

To associate the plugin with the cutter field, you must set the 'cutter.pl'
plugin in your MARC framework. this can be done through the following steps:

1. Navigate to More > Administration > MARC bibliographic framework;
2. On the framework which you want to use de plugin, click on Action > MARC
Structure;
3. On the field to be associated with the plugin, click on Actions > Subfields;
4. Select the tab corresponding to the cutter subfield;
5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin"
dropdown menu, and save changes.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371

--- Comment #16 from David Nind  ---
(In reply to Katrin Fischer from comment #15)
> I've turned this into a patch file, but haven't tested it. Please try it out!

Thanks Katrin! The patch applies, and I will have a go at testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017

--- Comment #26 from Victor Grousset/tuxayo  ---
Thanks all. I got help to understand some of the stuff but far from all of it.
Also my call for help in the french mailing list didn't yield results ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564

--- Comment #9 from Victor Grousset/tuxayo  ---
I don't get how to pay a fee via SIP:
https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup#Koha_SIP_CLI_emulator

Is that the Fee Paid thing in page 5 of SIP spec?
https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup

> The cases that can throw the issue here are
> 
> 1. Deleted item for a fine on a patrons account when the fee is paid via sip

What does deleting something for a fine means?
I got some hints in the chat. Create a lost fine tied to an item and then
delete the lost fine. Is that correct? At which moment should the fee be payed?

> 3. Disabled 'RenewAccruingItemWhenPaid' preference

Given that syspref set, which operation would trigger the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27240] Export basket: remove spaces and don't export links

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240

--- Comment #9 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #8)
> No, it's correct - we only want to add the link here, not the column!

add should read 'hide'!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27240] Export basket: remove spaces and don't export links

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #8 from Katrin Fischer  ---
No, it's correct - we only want to add the link here, not the column!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #43 from Michal Denar  ---
Created attachment 119977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119977=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #42 from Michal Denar  ---
Created attachment 119976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119976=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 Attachment #119968|0   |1
is obsolete||
 Attachment #119969|0   |1
is obsolete||
 Attachment #119970|0   |1
is obsolete||
 Attachment #119972|0   |1
is obsolete||

--- Comment #40 from Michal Denar  ---
Created attachment 119974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119974=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #41 from Michal Denar  ---
Created attachment 119975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119975=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27924] Display number of holds awaiting pickup on check out screens

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27924

--- Comment #6 from Katrin Fischer  ---
Thx, Owen!

Wondering, would "... (4):" or "...: 4" be better in this case?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26517] Avoid deleting patrons with permission

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||28191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191
[Bug 28191] Update wording on batch patron deletion to reflect changes from bug
26517
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||26517


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517
[Bug 26517] Avoid deleting patrons with permission
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on|26517   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517
[Bug 26517] Avoid deleting patrons with permission
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26517] Avoid deleting patrons with permission

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.05   |21.05.00,20.11.05,20.05.11
released in||
 Blocks|28191   |
 CC||and...@bywatersolutions.com
 Status|Pushed to stable|Pushed to oldstable

--- Comment #20 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.11


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191
[Bug 28191] Update wording on batch patron deletion to reflect changes from bug
26517
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28155] Guided report save goes to 403

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28155

--- Comment #4 from Katrin Fischer  ---
A file permission error is not so likely, as we are storing into the database,
not into a file system. 

Are you able to check from a different system without the latest WAF change to
compare?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 119973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119973=edit
Bug 23207: (QA follow-up) Add to cron files

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #119971|0   |1
is obsolete||

--- Comment #39 from Lari Taskula  ---
Created attachment 119972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119972=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

Response is an array that contains "_per_page" amount of objects, each
with the following format:

{
  "data": {the object, e.g. patron}
  "type": DBIx source name, e.g. "Borrower"
}

Example response:

[
  {
"data":{
  "address":null,
  ...,
  "patron_id":1,
  ...
},
"type":"Borrower"
  },
  {
"data":{
  "borrower_message_preference_id":24,
  "borrowernumber":1,
  ...,
  "wants_digest":1
},
"type":"BorrowerMessagePreference"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":97,
  "due_date":"2021-02-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"Issue"
  },
  {
"data":{
  "auto_renew":false,
  ...,
  "checkout_id":42,
  "due_date":"2021-01-19T23:59:00+00:00",
  ...,
  "patron_id":1,
  ...
},
"type":"OldIssue"
  }
]

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28119] Use full description in layout type selection

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the display of the drop
   ||down list when adding and
   ||editing label layouts
   ||(Tools > Label creator >
   ||Layouts) so that a full
   ||description of label types
   ||is shown instead of brief
   ||names. For example: "Only
   ||the barcode is printed"
   ||instead of "BAR".
   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117109|0   |1
is obsolete||

--- Comment #38 from Lari Taskula  ---
Created attachment 119971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119971=edit
Bug 20028: Add Patron Export REST controller

This patch adds a REST controller for patron data exporting.

GET /api/v1/patrons/51/export
GET /api/v1/public/patrons/51/export

Supports pagination parameters "_per_page" and "_page".

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117108|0   |1
is obsolete||

--- Comment #37 from Lari Taskula  ---
Created attachment 119970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119970=edit
Bug 20028: Add OpenAPI spec

Includes a test that validates the existence of all related properties.

To test:
1. prove t/db_dependent/api/v1/patrons_export.t

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117107|0   |1
is obsolete||

--- Comment #36 from Lari Taskula  ---
Created attachment 119969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119969=edit
Bug 20028: Add a system preference for patron data export

Add a system preference to determine whether patron data export is permitted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

Lari Taskula  changed:

   What|Removed |Added

 Attachment #117106|0   |1
is obsolete||

--- Comment #35 from Lari Taskula  ---
Created attachment 119968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119968=edit
Bug 20028: Add Koha::Patron->export

The logic behind gathering related data relies on DBIx relationships to
Borrower
source.

This patch does not care about object name terminology - it returns related
data
in a hashref containing keys of DBIx source class names, such as Borrower.

Return example:

{
"Borrower" => Koha::Patron,
"BorrowerMessagePreference" => DBIx::Class::ResultSet,
"ReturnClaim" => Koha::Checkouts::ReturnClaims
}

This has the benefit of giving caller the ability to format response as they
want. For example, you can then easily use the "unblessed" or "to_api"
representation of the object.

To test:
1. prove t/db_dependent/Koha/Patron.t
2. Observe success

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] New: Update wording on batch patron deletion to reflect changes from bug 26517

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Bug ID: 28191
   Summary: Update wording on batch patron deletion to reflect
changes from bug 26517
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 26517

Bug 26517 changed the logic used to prevent patron batch deletion to prevent
the deletion of any patron with permissions. The batch patron deletion page
lists the reasons a patron will be retained and should up updated to reflect
this change. Right now it says:

Patrons will not be deleted if they meet one or more of the following
conditions:

They have items currently checked out.
They have a non-zero account balance.
They are the guarantor to another patron.
They are in a patron category of type staff.

We should add a line of:
They have staff permissions.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517
[Bug 26517] Avoid deleting patrons with permission
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26517] Avoid deleting patrons with permission

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||28191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191
[Bug 28191] Update wording on batch patron deletion to reflect changes from bug
26517
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28119] Use full description in layout type selection

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119

--- Comment #11 from David Nind  ---
(In reply to Katrin Fischer from comment #6)
> Should it be proceeds or not maybe preceeds?

Nice catch Katrin! It should be "preceeds"..

"before" is also an alternative.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 119967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119967=edit
Bug 23207: (QA follow-up) Add new column on item types UI table

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 119966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119966=edit
Bug 23207: (QA follow-up) Add COMMENT to new column

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207
[Bug 23207] Allow automatic checkin/return at end of circulation period
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||28190
 Status|Failed QA   |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190
[Bug 28190] Library limitation column not toggable on itemtypes table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Owen Leonard  changed:

   What|Removed |Added

 Attachment #119964|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 119965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119965=edit
Bug 28190: Fix columns_settings.yml itemtypes entry

The parent_code column is missing on the columns_settings.yml file, so
columns are shifted and thus 'Library limitations' is not toggable.

To test:
1. Verify you are not offered the chance to hide the column
2. Apply this patch, restart all the things
=> SUCCESS: You can toggle the column
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the OPAC maintenance page*
   ||so that it uses the email
   ||address from the
   ||ReplyToDefault system
   ||preference, if it is set,
   ||for the "please contact the
   ||site administrator" email
   ||link.
   ||
   ||If ReplyToDefault is
   ||not set, it will use
   ||KohaAdminEmailAddress.
   ||
   ||If
   ||both ReplytoDefault and
   ||KohaAdminEmailAddress are
   ||not set, no link is shown.
   ||
   ||* Displays when the
   ||OpacMaintenance system
   ||preference is set to
   ||"Show".
   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28181] Archived debit type still shows as available in Point of Sale

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 119964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119964=edit
Bug 28190: Fix columns_settings.yml itemtypes entry

The parent_code column is missing on the columns_settings.yml file, so
columns are shifted and thus 'Library limitations' is not toggable.

To test:
1. Verify you are not offered the chance to hide the column
2. Apply this patch, restart all the things
=> SUCCESS: You can toggle the column
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org
 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28190] New: Library limitation column not toggable on itemtypes table

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

Bug ID: 28190
   Summary: Library limitation column not toggable on itemtypes
table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The columns_settings.yml section for itemtypes is missing an entry for the
'Parent code' column, and thus some columns are shifted, and it has the effect
of preventing the 'Library limitations' column being toggable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17787] Hidden items included in count of search results

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787

Gérard Simon Voyer  changed:

   What|Removed |Added

 CC||simon.vo...@collecto.ca

--- Comment #4 from Gérard Simon Voyer  ---
Bonjour everyone!

I've had my shot at this and broke my logic circuits hard.
At first, I tried complex matching rules to try while opening loops done over
@newresults (from opac/opac-search.pl) to get something. That's when I realized
nothing ever matched. Then I realized that @newresults was already filtered,
which is why I had no match.

So in the end :

my $results_count = scalar @newresults;
...
...
 if ($results_hashref->{$server}->{"hits"}){
$total = $results_count;
 }
...
...
$template->param(total => $total);

gave me the right count...

I'll have to go document myself on how to propose a fix on this issue, but I
think the explanation above can give anyone looking for an answer the missing
piece.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Nick Clemens  changed:

   What|Removed |Added

 Blocks||26374


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374
[Bug 26374] Update for 19974 is not idempotent
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26374] Update for 19974 is not idempotent

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19974

--- Comment #5 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #4)
> Does this depend on Bug 19974? Can you please provide a test plan?

It does depend on 19974

Essentially run the update statement, set some values, run it again, they are
deleted.

I believe this was noticed because of internal backports, filing here because
it could happen to others


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974
[Bug 19974] Marking an item as 'lost' will not actually modify the current item
(cataloguing/additem.pl)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127

Lucas Gass  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28189] Move the base swagger file to YAML

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28189] Move the base swagger file to YAML

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 119963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119963=edit
Bug 28189: Move swagger file to YAML format

This patch changes the base OpenAPI file (swagger.json) into YAML. The
motivation for this, is adding more documentation, in Markdown.

JSON doesn't accept multiline strings, so this seems like a good move
for readability.

To test:
1. Verify your API is functional
2. Apply this patch
3. Repeat 1
=> SUCCESS: No changes, really
4. Point your browser to /api/v1/.html
=> SUCCESS: Some nicely formatted description of the API can be seen. It
includes information about x-koha-library.
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

Christofer Zorn  changed:

   What|Removed |Added

 CC||christofer.zorn@ajaxlibrary
   ||.ca

--- Comment #14 from Christofer Zorn  ---
We experienced the same issue ... could we either add an option to the one
system pref similar to the "follow or ignore the calendar"? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #119959|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28189] Move the base swagger file to YAML

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28189] Move the base swagger file to YAML

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||katrin.fisc...@bsz-bw.de,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com
 Depends on||28157

--- Comment #1 from Tomás Cohen Arazi  ---
I decided to make this dependent on bug 28157, which would really benefit from
adding some documentation like this. So it is a good first addition.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157
[Bug 28157] Add the ability to set a library from which an API request pretends
to come from
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189
[Bug 28189] Move the base swagger file to YAML
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28189] New: Move the base swagger file to YAML

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189

Bug ID: 28189
   Summary: Move the base swagger file to YAML
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

In order to be able to add better documentation on the API, we should move the
base file to YAML, so we can add multi-line Markdown in it. It renders
correctly with tools like Redoc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27924] Display number of holds awaiting pickup on check out screens

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27924

--- Comment #5 from Barbara Johnson  ---
That's perfect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8074] Define default library for holds to pull report

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #11 from Joonas Kylmälä  ---
Attached solution that should restore exactly the previous behaviour. Let me
know what you think.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27924] Display number of holds awaiting pickup on check out screens

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27924

--- Comment #4 from Owen Leonard  ---
Created attachment 119962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119962=edit
Screenshot of a proposed change

What do y'all think of this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #10 from Joonas Kylmälä  ---
Created attachment 119961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119961=edit
Bug 28171: Restore previous sorting behaviour for Serial enumchron column

Before Bug 27980 the sorting was done either by item's publisheddate
if it existed in at least one item. If it didn't exist then the
sorting was done using "h - Serial Enumeration / chronology"
field. This restores this sorting functionality in catalogue/detail.pl
page.

To test:
 1. Create a serial subscription for a biblio, make sure to enable the
option "Create an item record when receiving this serial"
 2. Receive two serials, so that they have different received dates
and check that the items are now created to the biblio
 3. Add now two additional items with one having "A" and other having
"B" in the "h - Serial Enumeration / chronology" field.
 4. Try sorting and notice the items with publisheddate are being
sorted and ones without stay in the order they happened to be
 5. Remove the items with publisheddate and notice that now items with
"A" and "B" get sorted correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #119896|0   |1
is obsolete||

--- Comment #9 from Joonas Kylmälä  ---
Created attachment 119960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119960=edit
Bug 28171: Revert "Bug 27980: Remove itemdata_publisheddate from controller"

This reverts commit c7fef23763754ad65c5a59438ed370d53aeec4b6.

The code is needed back to fix broken sorting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

--- Comment #33 from Henry Bolshaw  ---
Wainui, I've signed off your patches and added a follow up to tweak the
opac.scss so that the new H2 heading is styled the same way as the old
'Welcome, user' heading.

The 'welcome, user' text still looks slightly adrift but I'm not sure how to
make it look better.

The current heading styling on the OPAC has an insufficient contrast ratio for
accessibility purposes. I've created bug 28188 to collect all of these
instances.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] New: Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Bug ID: 28188
   Summary: Accessibility: OPAC - the contrast ratio for text is
insufficient [OMNIBUS]
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: accessibility
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

This is a collector bug for cases where the contrast ratio of text is
insufficient (usually less than 4.5:1). This makes the text difficult to read
and fails to meet accessibility criteria.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28157] Add the ability to set a library from which an API request pretends to come from

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28157

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 119959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119959=edit
Bug 28157: Move swagger file to YAML format

This patch changes the base OpenAPI file (swagger.json) into YAML. The
motivation for this, is adding more documentation, in Markdown.

JSON doesn't accept multiline strings, so this seems like a good move
for readability.

To test:
1. Verify your API is functional
2. Apply this patch
3. Repeat 1
=> SUCCESS: No changes, really
4. Point your browser to /api/v1/.html
=> SUCCESS: Some nicely formatted description of the API can be seen. It
includes information about x-koha-library.
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

--- Comment #32 from Henry Bolshaw  ---
Created attachment 119958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119958=edit
Bug 27740: (follow-up) changed "User summary" css

Changed user summary CSS to style H2 not H3 heading

To test:
1) Go to OPAC homepage
2) Login as a user with at least one loan
3) See that the "User summary" heading is not styled
4) Apply patch
5) Run yarn build --view OPAC
6) Confirm the heading is now styled with grey background

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #39 from Jonathan Druart  
---
Follow-up pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #38 from Jonathan Druart  
---
Created attachment 119957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119957=edit
Bug 23271: Fix random failure from Categories.t

#   Failed test 'The branch limitation should have been stored and retrieved'
 #   at t/db_dependent/Koha/Patron/Categories.t line 57.
 # Structures begin differing at:
 #  $got->[0] = 'fm0A1a'
 # $expected->[0] = 'vNquBvCa'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #8 from Joonas Kylmälä  ---
Owen, so my recommendation would be that in this bug we restore the old
behaviour before bug 27980 and if somebody wants to modify that let's open a
new bug for this. The "Bug 27980: Remove itemdata_publisheddate from
controller" needs to be reverted to restore the old behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22513] Anonymize old ILL requests

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22513

--- Comment #2 from Magnus Enger  ---
Sounds like we need to make it an option that can be turned on or off, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #7 from Joonas Kylmälä  ---
From the DataTables website I found this:

"In order for the HTML 5 data-* attribute detection and processing to work
correctly, all cells in a column must have the same attribute available.
Without this, DataTables will give a warning."

(https://datatables.net/manual/data/orthogonal-data)

So unless I'm misunderstanding we probably shouldn't even depend on this, but
go back to the old behaviour where we had all the columns having the data-order
value set even though for some it was empty.

However, I didn't get this warning message when testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_05_candidate,
   ||RM_priority

--- Comment #31 from Jonathan Druart  
---
It would be great to have this one for 21.05, keep going :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #37 from Jonathan Druart  
---
Follow-up pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

--- Comment #36 from Jonathan Druart  
---
Created attachment 119956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119956=edit
Bug 23271: Fix Template/Plugin/Branches.t

#   Failed test 'Without selected parameter, my library should be preselected'
#   at t/db_dependent/Template/Plugin/Branches.t line 81.
#  got: '0'
# expected: '1'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #119816|0   |1
is obsolete||

--- Comment #30 from Henry Bolshaw  ---
Created attachment 119955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119955=edit
Bug 27740: (follow-up) Added User summary heading

Added a User summary 

To test:
1) Go to OPAC
2) Go to home page
3) Check that there is a  saying "User summary"

Sponsored-by: Catalyst IT

Signed-off-by: Henry Bolshaw 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #119691|0   |1
is obsolete||

--- Comment #29 from Henry Bolshaw  ---
Created attachment 119954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119954=edit
Bug 27740: (follow-up) quote of the day to 

If the quote of the day feature is enabled, a "Quote of the day" heading
is displayed. It was an  which was not proper hierarchy, so this has
been changed to an .

To test:
1) Go to staff client
2) Enable quote of the day preference
3) Go to the OPAC
4) Observe "Quote of the day" heading
5) Ensure it is an 

Sponsored-by: Catalyst IT

Signed-off-by: Henry Bolshaw 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #119690|0   |1
is obsolete||

--- Comment #28 from Henry Bolshaw  ---
Created attachment 119953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119953=edit
Bug 27740: (follow-up) changed welcome user to 

In the 'user_summary block', the "Welcome, user" was an . This has
been changed to a  as it isn't really a heading.

The styling can be changed to make it appear as it was before, or to
make it appear more significant on the page.

To test:
1) Go to the OPAC
2) Go to the home page
3) Go to the 'user_summary' block
4) Check that the part where is says "Welcome, user" is now a 

Sponsored-by: Catalyst IT

Signed-off-by: Henry Bolshaw 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

--- Comment #115 from Gérard Simon Voyer  ---
Is there any way to apply this functionnality on top of the master branch as of
now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24023] Add ability to create bundles of items

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023

--- Comment #26 from Julian Maurice  ---
(In reply to Martin Renvoize from comment #25)
> > 1. Create a biblio record with at least a title. Create an item for this
>biblio record
> 
> Can a 'bundle' record not contain multiple items?  I could envisage a
> standard 'bundle' being created for various uses and then multiple 'items'
> consisting of a bundled set of materials.?

The problem is that the bundle is linked to specific items, so once the bundle
is checked out, those specific items are not available anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #6 from Joonas Kylmälä  ---
In the previous message with "order-by" I wanted to say instead "data-order"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] Restore "Additional fields" link on serials navigation menu

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

--- Comment #12 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #11)
> (In reply to Fridolin Somers from comment #10)
> > Small useful enhancement, I choose to backport.
> > 
> > Pushed to 20.11.x for 20.11.05
> 
> Hi Frido, aren't we already in string freeze?... could we hold this back to
> next . release? It shows in quite a prominent spot.

I realized string freeze for 20.11 was announced after this was pushed, so we
are good there, but the strings haven't shown up on translate yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28171] Serial enumeration / chronology sorting is broken in biblio page

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28171

--- Comment #5 from Joonas Kylmälä  ---
(In reply to Owen Leonard from comment #4)
> I'm glad to have your detailed feedback, because I don't have good serials
> data to test with and I wasn't sure I was mocking it up correctly. I don't
> know the answer to whether the grouped sorting is better, so I defer to your
> opinion.
> 
> What feature do you mean when you say it isn't documented? The data-order
> sorting option is documented here:
> https://datatables.net/examples/advanced_init/html5-data-attributes.html

The feature of Datatables sorting separately the rows with order-by attribute
and the ones without and then concatenating them. There is no mention of that
in the documentation so it probably could have been implemented so that it
would sort everything as one group.

I think the undocumented sorting functionality here is good but only doubt is
that if it breaks in the future and our users will expect us to fix that it
might not be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893

--- Comment #41 from Mason James  ---
(In reply to Mason James from comment #37)
> (In reply to Bohdan from comment #36)
> > Hello. I've installed Koha 20.11.04 on latest Debian 10 and the API is
> > broken. I cannot get the list of available branches as it uses API.
> > 
> > Got the following in api error logs:
> > [ERROR] Warning: Could not load REST API spec bundle: Can't use string
> > ("parameters.json") as a HASH ref while "strict refs" in use at
> > /usr/share/perl5/JSON/Validator/OpenAPI/Mojolicious.pm line 272.

hi Bohdan, 
can you give more details?

1/ what is the url that causes the error?
2/ do you have any extra cpan modules installed?
3/ what version of the libjson-validator-perl package is installed?


the t/db_dependent/api/v1/libraries.t tests are passing for deb10/20.11.04, so
it might be a problem specific to your system

https://jenkins.koha-community.org/view/20.11/job/Koha_20.11_D10/87
https://jenkins.koha-community.org/view/20.11/job/Koha_20.11_D10/87/consoleText

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27061] Double permission check in svc/mana/search

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27061

--- Comment #3 from Owen Leonard  ---
This required a rebase so please check that I didn't do it incorrectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27061] Double permission check in svc/mana/search

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27061

Owen Leonard  changed:

   What|Removed |Added

 Attachment #113866|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 119952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119952=edit
Bug 27061: Remove duplicate permission check in svc/mana/search

There is a call to check_cookie_auth then another one to get_template_and_user

Test plan:
Use mana to create new report and new subscription.
Confirm that you need the necessary permissions to use it

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27061] Double permission check in svc/mana/search

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27061

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20114] Build better $query_cgi

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

--- Comment #11 from Gérard Simon Voyer  ---
Ok, news update! It does come from our branches setup. Carry on with your
lives, I'll make sure to use Koha's stable version instead of the fixed version
we have with our «home-made» Koha branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27124] JS error "select2Width is not defined"

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >