[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #310 from David Cook --- Comment on attachment 120368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120368 Bug 15516: Database and installer updates Review of attachment 120368: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15516=120368) - ::: installer/data/mysql/kohastructure.sql @@ +4350,3 @@ >CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES > `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE, >CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES > `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE, >CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`desk_id`) REFERENCES `desks` > (`desk_id`) ON DELETE SET NULL ON UPDATE CASCADE There is a missing comma here which causes this error: Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `reserves` ( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #9 from David Cook --- If we are going to drop support for the abbreviated format, then we can update this bug to just change the unit test and maybe print a warning in the release notes or something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #309 from David Cook --- Code looks all right just looking at the diff, so I think fixing the QA test tool failures should resolve things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #308 from David Cook --- However, it's failing the QA test tools: root@kohadevbox:koha(bug_15516)$ qa testing 6 commit(s) (applied to 8fe090f 'e3 Bug 27864: (QA follow-up) Select2 ') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) OK C4/Reserves.pm FAIL Koha/Hold.pm FAIL critic # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL filters wrong_html_filter at line 181 ((part of a hold group)) missing_filter at line 181 ((part of a hold group)) OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt FAIL filters wrong_html_filter at line 185 ((part of a hold group)) missing_filter at line 185 ((part of a hold group)) OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt FAIL filters missing_filter at line 23 ( [% hold.priority %]) missing_filter at line 24 ( [% hold.reservenotes %]) FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 2) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl FAIL reserve/hold-group.pl FAIL critic Subroutine "new" called using indirect syntax at line 25, column 11. See page 349 of PBP. FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 30) OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t FAIL t/db_dependent/Reserves/HoldGroup.t FAIL file permissions File must have the exec flag Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au |y.org | --- Comment #307 from David Cook --- Rebased and works as expected with following test plan: My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml 0d. restart_all 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. (e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test) 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold (e.g. Check in 301310 ) 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118355|0 |1 is obsolete|| --- Comment #306 from David Cook --- Created attachment 120373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120373=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118354|0 |1 is obsolete|| --- Comment #305 from David Cook --- Created attachment 120372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120372=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118353|0 |1 is obsolete|| --- Comment #304 from David Cook --- Created attachment 120371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120371=edit Bug 15516: Schema updates Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118352|0 |1 is obsolete|| --- Comment #303 from David Cook --- Created attachment 120370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120370=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118351|0 |1 is obsolete|| --- Comment #302 from David Cook --- Created attachment 120369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120369=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #118350|0 |1 is obsolete|| --- Comment #301 from David Cook --- Created attachment 120368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120368=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #300 from David Cook --- The patch works as expected using the following test plan. My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml 0d. restart_all 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. (e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test) 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold (e.g. Check in 301310 ) 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #253 from David Cook --- Slightly updated test plan. Everything is working well in koha-testing-docker. Test plan: 0) git bz apply 15565 1) restart_all 2) Set the maxreserves system preference to 3 (from 50) 3) Set the following circulation rules: holds allowed (total) = 10 (from unlimited) holds allowed (daily) = 10 (from unlimited) holds per record (count) = 10 (from 2) 3) Set up a record with 4 items E.g. add 3 items to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4) Go to place a hold on this record in Staff Interface 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox is not checked. 7) Set the following circulation rules: holds allowed (total) = 2 (from 10) holds allowed (daily) = 2 (from 10) holds per record (count) = 2 (from 10) 8) Perform the same above actions on the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117133|0 |1 is obsolete|| --- Comment #252 from David Cook --- Created attachment 120367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120367=edit Bug 15565: Place multiple holds on one record on OPAC Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117132|0 |1 is obsolete|| --- Comment #251 from David Cook --- Created attachment 120366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120366=edit Bug 15565: Place multiple holds on one record on staff client Test plan: 1) Apply patch and restart services 2) Set the maxreserves system preference to 3 3) Set the following circulation rules: holds allowed (total) = 10 holds allowed (daily) = 10 holds per record (count) = 10 3) Set up a record with 4 items 4) Go to place a hold on this record 5) Notice that the items table under 'Place a hold on a specific item' now uses checkboxes instead of radio buttons 6) Check all 4 checkboxes. Confirm that when you check the 4th checkbox, an alert pops up warning the you've reached the maximum. Confirm that when you close the alert, the checkbox unchecks itself. 7) Try setting different values for the above circulation rules that are lower than the number of items on this record. Confirm the alert pops up as expected. 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Confirm that item-level holds are placed on all selected items. Sponsored-by: Catalyst IT Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #117131|0 |1 is obsolete|| --- Comment #250 from David Cook --- Created attachment 120365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120365=edit Bug 15565: Koha::Biblio->allowed_holds and tests Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277 --- Comment #2 from David Cook --- Likewise the DEFAULT framework should not have 003 as mandatory... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277 --- Comment #1 from David Cook --- It's kind of interesting seeing how many Koha libraries around the world have a 003 of OSt... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28277] MARCOrgCode has an incorrect default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277 David Cook changed: What|Removed |Added Summary|MARCOrgCode has bad default |MARCOrgCode has an |value |incorrect default value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28277] New: MARCOrgCode has bad default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28277 Bug ID: 28277 Summary: MARCOrgCode has bad default value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Apparently, for Koha's recorded history, MARCOrgCode has always defaulted to OSt. (See commit f8e9fb6445dadbdef91e13a253c9c6bcb75e0eec) I never really thought about it too much but I just took a look at https://www.loc.gov/marc/organizations/org-search.php and OSt is "Stow Public Library" in Ohio in the USA. Really we should default to an empty/blank value rather than a wrong value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28189] Move the base swagger file to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189 --- Comment #10 from Tomás Cohen Arazi --- (In reply to David Cook from comment #9) > I'm not sure I'm following the flow but I'm guessing Jonathan was referring > to th swagger.json line in the fallback section? Yes, it was a busy Friday. Will fix it tomorrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 --- Comment #8 from David Cook --- Bizarre. I'm probably not going to look at this again any time soon, so you might want to try a non-containerized Docker environment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28189] Move the base swagger file to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28189 --- Comment #9 from David Cook --- I'm not sure I'm following the flow but I'm guessing Jonathan was referring to th swagger.json line in the fallback section? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #102 from Katrin Fischer --- I am sorry, this patch set no longer applies and I can't fix it: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23260: Make borrowernumber nullable in items_last_borrower Applying: Bug 23260: Inline code to anonymise_issue_history Applying: Bug 23260: Simplify tests Applying: Bug 23260: (follow-up) Remove last_borrower updates from issues count Applying: Bug 23260: Add a new test Applying: Bug 23260: Proposed preference driven filtering Applying: Bug 23260: (follow-up) Add AnonymiseLastBorrower and AnonymiseLastBorrowerDays sysprefs Applying: Bug 23260: (follow-up) Update test error: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t). error: could not build fake ancestor Patch failed at 0001 Bug 23260: (follow-up) Update test The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23260-follow-up-Update-test-oyzp2x.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #26 from Katrin Fischer --- (In reply to Jonathan Druart from comment #20) > Can you explain this follow-up, Kyle? > What's the use case, how did you find it? > We certainly need a couple of tests to cover it. I read this as that we need 2 more unit tests that cover some more cases? Setting to failed QA to alert Kyle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Attachment #117738|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 120364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120364=edit Bug 27837: Permanent location to be empty string, check if key exists Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Attachment #117730|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 120363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120363=edit Bug 27837: Prevent the tests to fail is the field is mapped Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Attachment #117729|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 120362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120362=edit Bug 27837: Add unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Kuiper Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Attachment #117728|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 120361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120361=edit Bug 27837: Update permanent location if passed into ModItemFromMarc Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rhonda Kuiper Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #21 from Katrin Fischer --- I've tested, QA script and unit tests pass. Also the following test plan checks out: Test plan: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Edit an item, changing location to X and permanent location to Y, save 4 - confirm record shows location=x, permanent_location=y 5 - Edit item again, change location to Z, do not change permanent location, save 6 - confirm location and permanent_location both equal Z 7 - apply patch, restart 8 - repeat steps 3-5 9 - confirm location=Z, permanent location=Y 10 - prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Hi Nick, I've done some small follow-ups and some testing: Tested with: copy & retain 1) Budgets /cgi-bin/koha/admin/aqbudgetperiods.pl When I add a search term to catalog search or checkout tab, it's not copied to the other tab. 2) Cataloging /cgi-bin/koha/cataloguing/addbooks.pl This seems to work ok. But only the catalog search retains the search term, cataloging seach does not. I think this is intentional, but would probably be a good addition? 3) Circulation 4) Currencies 5) Contracts 6) Home page 7 Notices and slips 8) Patrons 9) Administration 10) Serials When I enter an ISSN or Title in the first tab, it isn't copied to the other tabs. 11) Acquisitions -> suggestions 12) Z3950 Admin 13) Then I have set "don't copy" and "don't retain". But the only tab this seem to affect is the catalog search tab? If I enter a search term in "check out", it will still be copied to checkin, renew, search patrons. Only when switching to catalog search it will be emptied. This appears a bit of strange behaviour, if it's intentional, we should change the pref description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #43 from Katrin Fischer --- I feel like this might be better as "in discussion", but it should really be discussed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #20 from Katrin Fischer --- Created attachment 120360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120360=edit Bug 26247: (QA follow-up) Move prefs from Search > Results display to Search > Search form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #19 from Katrin Fischer --- Created attachment 120359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120359=edit Bug 26247: (QA follow-up) Fix 0/1 and terminology in preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #18 from Katrin Fischer --- Created attachment 120358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120358=edit Bug 26247: (QA follow-up) Fix tab chars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Attachment #117539|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 120357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120357=edit Bug 26247: Atomic update Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Attachment #117538|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 120356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120356=edit Bug 26247: Make search terms optionally sticky This patch adds a configurable option for retaining stickiness of search terms across search tabs To test: 1 - Apply all patches except this one, enable StaffRetainSearchTerms 2 - Search in staff client from header 3 - Confirm behaviour is that term is retained, but not copied when switching header search tab 4 - Apply this patch, updatedatabase 5 - Search again 6 - Previous behaviour is restored, search terms are sticky between tabs 7 - Disable preference StaffStickySearchTerms 8 - Search again 9 - Search terms retained, but not sticky Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Attachment #117537|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 120355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120355=edit Bug 26247: Only copy header inputs if marked sticky This alters the 'keep_text' function to require 'head-searchbox' elements to be marked with class 'sticky' ti have values carry over There have been complaints about the stickiness of retained search terms, this patch attempts to mitigate that while preserving stickiness for other searches To test: 1 - Enable 'StaffRetainSearchTerms' (or don't apply previous patches) 2 - Search in staff client from header 3 - Search term is retained in the search box 4 - Click abother tab like 'checkin' 5 - Search term is copied to new tab 6 - Apply patch 7 - Reload the page 8 - Search in header 9 - Search term still retained 10 - Click on another header tab 11 - Search term is not copied Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Attachment #117536|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 120354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120354=edit Bug 26247: Consolidate search box code This cleans up the various search bar templates to use a single template for the 'Search the catalog box' To test: 1 - Apply patch 2 - Confirm the 'Search the catalog' appears and works from modules: Budgets Cataloging Circulation Currencies Contracts Home page Notices and slips Patrons Administration Serials Acquisitions -> suggestions Z3950 Admin Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Katrin Fischer changed: What|Removed |Added Attachment #117535|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 120353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120353=edit Bug 26247: Make retaining search terms in staff client optional This patch adds a new system preference 'StaffRetainSearchTerms' - if enabled header searches will be retained on the results page as current behvaiour. If disabled the search box will be empty after searching To test: 1 - Search in staff client from header 2 - Confirm search terms are retained 3 - Apply patch, update database 4 - Search again, terms still retained 5 - Disable StaffRetainSearchTerms preference 6 - Search again 7 - Search box is cleared Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #135 from Katrin Fischer --- I am really sorry, but this patch set no longer applies and I can't fix it: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13952: Import and export authority types Applying: Bug 13952: (follow-up) Fixing authority type import error: sha1 information is lacking or useless (C4/ImportExportFramework.pm). error: could not build fake ancestor Patch failed at 0001 Bug 13952: (follow-up) Fixing authority type import The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13952-follow-up-Fixing-authority-type-import-NMOJ0F.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer --- I am sorry, but tests are failing :( kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Exporter/Record.t t/db_dependent/Exporter/Record.t .. 1/6 Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 397, <$fh> chunk 7. # Failed test 'Deleted record has the correct leader value' # at t/db_dependent/Exporter/Record.t line 179. # got: '00134dam a22000617a 4500' # expected: '00136dam a22000617a 4500' # Looks like you failed 1 test of 4. # Failed test 'export xml' # at t/db_dependent/Exporter/Record.t line 180. # Failed test 'Deleted record has the correct leader value' # at t/db_dependent/Exporter/Record.t line 211. # got: '00134dam a22000617a 4500' # expected: '00136dam a22000617a 4500' # Looks like you failed 1 test of 4. # Failed test 'export iso2709' # at t/db_dependent/Exporter/Record.t line 212. # Looks like you failed 2 tests of 6. t/db_dependent/Exporter/Record.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/6 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #36 from Katrin Fischer --- > > 5). There actually is a "deleteditems" table so I guess it would be possible > to include these, even though it's hard to imagine why you would want to do > this. Since the default is to include items perhaps it would be best to > leave this as is and never include items for deleted biblios, or you will > get more data than you probably want by default. It would also increase code > complexity, probably with little benefit. If someone requests this it can be > fixed later perhaps. Will point it out in the documentation that items are > not included. I think introducing the export of deleted records and deleted items separately would be a good idea. Let's start with this well defined feature and think about the deleted items some more. While records have a flag to say "deleted", we don't have the same for items. So we could start exporting deleted items that belonged to deleted records, but what about other deleted items on existing records? How to "mark" them as deleted? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #44 from Katrin Fischer --- I am sorry, this no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold Using index info to reconstruct a base tree... M C4/Reserves.pm M Koha/Hold.pm M installer/data/mysql/mandatory/sysprefs.sql M installer/data/mysql/pl-PL/mandatory/sample_notices.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/pl-PL/mandatory/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/pl-PL/mandatory/sample_notices.sql Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Hold.pm CONFLICT (content): Merge conflict in Koha/Hold.pm Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14364---Allow-automatically-canceled-expired-w-834arw.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #270 from Katrin Fischer --- As this had been waiting so long I've tried to fix the conflict in kohastructure.sql myself, but then ran into the next one in paths.json... Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 --- Comment #1 from Julian Maurice --- Created attachment 120352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120352=edit Bug 28276: Do not fetch config ($KOHA_CONF) from memcached memcached address and namespace are in $KOHA_CONF, so it is required to read it before being able to access the cache. And after that, configuration is kept in memory forever. Storing this in memcached is useless and even counter-productive, since Koha reads both the file and the cache This patch addresses this issue by removing the cache-related code from C4::Context->new. It means that C4::Context->new will always read the configuration file, so this patch also replaces inappropriate calls to C4::Context->new->config by appropriate calls to C4::Context->config It also fixes a bug where C4::Context->new would ignore the filepath given in parameters if there was something in cache. It also removes a problematic call to Koha::Caches->get_instance. Because this call was outside of any subroutine, it would have happened before the initialization of $C4::Context::context (which happen in C4::Context::import) Test plan: 1. Do not apply the patch yet 2. Add the following line at the beginning of Koha::Config::read_from_file warn "read_from_file($file)"; This will allow you to check how many times the file is read. 3. Flush memcached and restart starman 4. Check the logs, you should see "read_from_file" a bunch of times 5. Apply the patch 6. Re-add the line from step 2 7. Flush memcached and restart starman 8. Check the logs, you should see "read_from_file" only once 9. Make sure the memcached config from $KOHA_CONF (memcached_servers, memcached_namespace) is taken into account by checking the About page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] New: Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Bug ID: 28276 Summary: Do not fetch config ($KOHA_CONF) from memcached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org memcached address and namespace are in $KOHA_CONF, so it is required to read it before being able to access the cache. And after that, configuration is kept in memory forever. Storing this in memcached is useless and even counter-productive, since Koha reads both the file and the cache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28259] Checking at branch B an item in waiting hold state at branch A kill Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259 Katrin Fischer changed: What|Removed |Added Summary|Checking at branch B an|Checking at branch B an |item in waiting hold state |item in waiting hold state |at branch A kill koha |at branch A kill Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Katrin Fischer changed: What|Removed |Added Summary|Order unitprice is not set |Order unitprice is not set |anymore and totals are 0. |anymore and totals are 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28086] Email address shown on OpacMaintenancePage should use ReplytoDefault if set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28086 --- Comment #16 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #15) > I think we should have a new configuration for this particular use case > (email address to be displayed in OPAC when some error needs to be reported). > > If I was to pick one, I would say the admin address is the right one, and > libraries should set different values for each branch. But I see Katrin's > point/need. It's not only my need actually. I think as the reply-to address is used when you reply to emails, it makes a lot of sense to use it first. If you don't want to use it, you don't have to set it at all. I believe this is all the configuration we need here. It's optional and probably will only be set when you have a use case that requires it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
