[Koha-bugs] [Bug 28280] New: itemtypes page defaultreplacecost and processfee aren't using Price filter.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Bug ID: 28280 Summary: itemtypes page defaultreplacecost and processfee aren't using Price filter. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: didier.gauthe...@biblibre.com QA Contact: testo...@bugs.koha-community.org I don't know if it's an oversight or because they couldn't be NULL anymore if $Price is used but in /cgi-bin/koha/admin/itemtypes.pl page detail defaultreplacecost and processfee aren't formatted unlike To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28280] itemtypes page defaultreplacecost and processfee aren't using Price filter.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Didier Gautheron changed: What|Removed |Added Assignee|oleon...@myacpl.org |didier.gautheron@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28280] itemtypes page defaultreplacecost and processfee aren't using Price filter.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 Didier Gautheron changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28280] itemtypes page defaultreplacecost and processfee aren't using Price filter.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280 --- Comment #1 from Didier Gautheron --- Created attachment 120427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120427&action=edit Bug 28280: itemtype page, add price formatting To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #15 from Joonas Kylmälä --- Victor what were the exact steps you used, I still get the error, I even deleted koha-testing-docker (Debian GNU/Linux 9 version) completely and re-created it from scratch and I still get the error after: $ koha-mysql kohadev < installer/data/mysql/kohastructure.sql $ restart_all $ ./translate update pl-PL $ ./translate install pl-PL $ restart_all --> Go to installer page and select pl-PL as installer language, click through it and notice it gives error: > Cannot decode string with wide characters at > /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202 in the MARC21 step. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] New: Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Bug ID: 28281 Summary: Installer doesn't work on some languages (pl-PL) because it double decodes installer data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Blocks: 27623 If trying to install Koha with pl-PL language it doesn't work due to double encoding error in C4/Installer.pm: $ koha-mysql kohadev < installer/data/mysql/kohastructure.sql $ restart_all $ ./translate update pl-PL $ ./translate install pl-PL $ restart_all --> Go to installer page and select pl-PL as installer language, click through it and notice it gives error: > Cannot decode string with wide characters at > /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202 In installer the output of two calls YAML::XS::LoadFile is still decoded another time even though according to YAML::XS documentation the call to Load already decodes it. This causes the above error to happen in the MARC21 installation step. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 [Bug 27623] Remove pl-PL installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Joonas Kylmälä changed: What|Removed |Added Depends on||28281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27623] Remove pl-PL installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 --- Comment #16 from Joonas Kylmälä --- I found the cause and opened bug 28281. I will work on a fix (or I already have but missing test). -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27951 CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27951] Allow Per Branch customization for self registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27951 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25100 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28221] process_message_queue.pl missing `use Try::Tiny`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28221 Martin Renvoize changed: What|Removed |Added Summary|Script |process_message_queue.pl |process_message_queue.pl|missing `use Try::Tiny` |uses Try::Tiny but doesn't | |'use' it| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Joonas Kylmälä changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |joonas.kylm...@helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28282] New: Make labels for self registration form mappable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28282 Bug ID: 28282 Summary: Make labels for self registration form mappable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org Every now and then I get a request to change the label of one or more fields in the patron self registration form. This could be because a field has been re-purposed, or because local usage differs from the translation. I imagine we could have a map from the database column names, to the labels that are shown to the patrons: address: Department phone: Internal phone number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28282] Make labels for self registration form mappable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28282 --- Comment #1 from Katrin Fischer --- I think we are getting more and more reports like this for making things "renameable". The issue is always multi-language instances. Could be reusing the itemtype translation system an option? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276
--- Comment #4 from Martin Renvoize ---
Comment on attachment 120352
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120352
Bug 28276: Do not fetch config ($KOHA_CONF) from memcached
Review of attachment 120352:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28276&attachment=120352)
-
::: Koha/Database.pm
@@ +49,4 @@
>
> require Koha::Schema;
>
> +my $db_driver =
> C4::Context::db_scheme2dbi(C4::Context->config('db_scheme'));;
This change looks reasonable to me, but is worth highlighting to whoever does
QA as worth digging into.. I'm not 100% sure if there's some background reason
this used to call $context->{db_driver} instead of passing db_scheme into
db_scheme2dbi.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Martin Renvoize changed: What|Removed |Added Attachment #120352|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 120428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120428&action=edit Bug 28276: Do not fetch config ($KOHA_CONF) from memcached memcached address and namespace are in $KOHA_CONF, so it is required to read it before being able to access the cache. And after that, configuration is kept in memory forever. Storing this in memcached is useless and even counter-productive, since Koha reads both the file and the cache This patch addresses this issue by removing the cache-related code from C4::Context->new. It means that C4::Context->new will always read the configuration file, so this patch also replaces inappropriate calls to C4::Context->new->config by appropriate calls to C4::Context->config It also fixes a bug where C4::Context->new would ignore the filepath given in parameters if there was something in cache. It also removes a problematic call to Koha::Caches->get_instance. Because this call was outside of any subroutine, it would have happened before the initialization of $C4::Context::context (which happen in C4::Context::import) Test plan: 1. Do not apply the patch yet 2. Add the following line at the beginning of Koha::Config::read_from_file warn "read_from_file($file)"; This will allow you to check how many times the file is read. 3. Flush memcached and restart starman 4. Check the logs, you should see "read_from_file" a bunch of times 5. Apply the patch 6. Re-add the line from step 2 7. Flush memcached and restart starman 8. Check the logs, you should see "read_from_file" only once 9. Make sure the memcached config from $KOHA_CONF (memcached_servers, memcached_namespace) is taken into account by checking the About page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- This achieves the desired effect for me.. works well and is a nice bit of cleanup. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 --- Comment #6 from Jonathan Druart --- How much is the gain then? 2.5s for 1 runs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 --- Comment #7 from Julian Maurice --- (In reply to Jonathan Druart from comment #6) > How much is the gain then? 2.5s for 1 runs? It's for 1000 runs, so in the end I should gain something like 2.5ms at startup. It's not much, but still better, right ? :) Note that this was tested on my laptop with a i5-6440HQ CPU @ 2.60GHz The gain should be greater on slower hardware (just a guess; please test it on different hardware) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|NEW |ASSIGNED Depends on||22824 --- Comment #1 from Jonathan Druart --- Caused by bug 22824 I assume. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 [Bug 22824] Replace YAML::Syck with YAML::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart changed: What|Removed |Added Blocks||28281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28154 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28154] Translate script faces encoding issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28154 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28281 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23215] Remove PayPal logic from Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23215 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 --- Comment #8 from Jonathan Druart --- Right, the "10 runs" confused me, but ofc it's an average. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 --- Comment #9 from Jonathan Druart --- Without patch: Time (mean ± σ): 6.293 s ± 0.243 s[User: 6.181 s, System: 0.090 s] Range (min … max):6.012 s … 6.852 s10 runs With patch: Time (mean ± σ): 2.006 s ± 0.050 s[User: 1.937 s, System: 0.058 s] Range (min … max):1.939 s … 2.092 s10 runs i5-6200U CPU @ 2.30GHz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] New: `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Bug ID: 28283 Summary: `Quantity received` should have inputmode="numeric" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org ACC2 suggests 'inputmode="numeric"' for numeric inputs. This is missing on the acquisitions item receipt page for the 'Quantity received' input. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added Blocks||26926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Omnibus: Update all occurrences of to apply ACC2 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26926] Omnibus: Update all occurrences of to apply ACC2 coding guideline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize changed: What|Removed |Added Depends on||28283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 [Bug 28283] `Quantity received` should have inputmode="numeric" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 --- Comment #1 from Martin Renvoize --- Created attachment 120430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120430&action=edit Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive This patch adds an inputmode to the quantity field on the order receive page in acquisitions. Test plan 1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Receive. 2. Note that the 'Quantity received' input has an inputmode now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #33 from Jonathan Druart --- Created attachment 120431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120431&action=edit But 18989: Restore hidding items on detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart changed: What|Removed |Added Attachment #120431|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 120432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120432&action=edit Bug 18989: Restore hidding items on detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added Attachment #120430|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 120433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120433&action=edit Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive This patch adds an inputmode to the quantity field on the order receive page in acquisitions. Test plan 1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Receive. 2. Note that the 'Quantity received' input has an inputmode now. 3. Note that the 'Quantity received' input also has a pattern attribute. 4. Note that you should not be able to enter non-integer values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org, ||wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28135] Replace use of input type number in additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135 Martin Renvoize changed: What|Removed |Added Attachment #119450|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 120434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120434&action=edit Bug 28135: Replace use of input type number in additem.js This patch corrects in instance where JavaScript is creating an input tag with type "number." To test, apply the patch and make sure the AcqCreateItem system preference is set to "when receiving." - Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Receive. - On the page for receiving items you should see an add item form. - Click the "Add multiple items" button at the bottom of the form. - Test the "Number of items to add" field. It should not accept any input except numbers. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28135] Replace use of input type number in additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Failed QA |Signed Off --- Comment #4 from Martin Renvoize --- This one seems to work for me.. what browser were you using to test Severine? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com, ||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28134] Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize changed: What|Removed |Added Attachment #119451|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 120435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120435&action=edit Bug 28134: Replace use of input type number in onboarding templates This patch changes the instances of input of type="number" to input type="text" with attributes inputmode="numeric" and pattern="[0-9]*" To test, apply the patch and run through the process of installing Koha. When you reach onboarding step 2, "Create a patron category," check the enrollment period -> "In months" field. The field should not accept any input except numbers. Continue onboarding until step 5, "Create a new circulation rule." On this page, check that these fields accept only numbers: - Current checkouts allowed - Loan period - Renewals allowed - Renewals period - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28134] Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Catches all cases and works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246 Martin Renvoize changed: What|Removed |Added Attachment #120346|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 120436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120436&action=edit Bug 27246: Remove obsolete BEGIN code from C4::Context We don't longer enter the HTTP_USER_AGENT conditional in the BEGIN block of C4::Context. It was used when apache only was used. I am suggesting to remove it but keep the $CGI::VERSION < 4.08 condition to keep support of all version (not sure it's needed but won't hurt). I have not found a lot of occurrences of KOHA_BACKTRACES and I am assuming not much people are using it, we should prefer the dev_install flag instead (to set environment="development" when plack is started and enabled the starman trace) Test plan: Regression test what you think is useful Confirm the above statements Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Nice bit of cleanup, no regressions spotted and I agree with David's conclusion that I don't think it's been used for quite some time. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28134] Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- I think we can safely use my SO as a PQA. This is a trivial fix on a set of integer inputs so no ambiguity around decimal handling. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119687|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 120437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120437&action=edit Bug 27740: Corrected tags & hierarchy of headings Bug 27610 corrected the tags in each of the OPAC files. This patch corrects the hierarchy of the rest of the headings on each of the pages. To test: 1) Go to the OPAC 2) Apply Bug 27610 patch 3) Apply patch (Bug 27740) 4) Go to each of the pages and check that the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119688|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 120438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120438&action=edit Bug 27740: (QA follow-up) Fix 'Payment method' The 'Payment method' heading now needs to be moved to the second level to ensure consistent header heirarchy. Test plan 1/ Add some debts to a patrons account 2/ Enable online payments (Paypal is a good example) 3/ Login to the OPAC and navigate to the 'Charges' page 4/ Note the header hierarchy has no gaps... (h1 -> h2, not h1 -> h3) Signed-off-by: Martin Renvoize Signed-off-by: Wainui Witika-Park Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119689|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 120439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120439&action=edit Bug 27740: (QA follow-up) Fix 'Your purchase suggestions' On the purchase suggestions page you could end up with two "Your purchase suggestions" headings, one as an h1 and one as an h2.. Test plan 1/ Add at least one purchage suggestion to a patron 2/ Navigate to 'Purchase suggestions' 3/ Note that just one 'Your purchase suggestsions' heading appears with a top level '1'. Signed-off-by: Martin Renvoize Signed-off-by: Wainui Witika-Park Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119953|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 120440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120440&action=edit Bug 27740: (follow-up) changed welcome user to In the 'user_summary block', the "Welcome, user" was an . This has been changed to a as it isn't really a heading. The styling can be changed to make it appear as it was before, or to make it appear more significant on the page. To test: 1) Go to the OPAC 2) Go to the home page 3) Go to the 'user_summary' block 4) Check that the part where is says "Welcome, user" is now a Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119954|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 120441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120441&action=edit Bug 27740: (follow-up) quote of the day to If the quote of the day feature is enabled, a "Quote of the day" heading is displayed. It was an which was not proper hierarchy, so this has been changed to an . To test: 1) Go to staff client 2) Enable quote of the day preference 3) Go to the OPAC 4) Observe "Quote of the day" heading 5) Ensure it is an Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119955|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 120442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120442&action=edit Bug 27740: (follow-up) Added User summary heading Added a User summary To test: 1) Go to OPAC 2) Go to home page 3) Check that there is a saying "User summary" Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Attachment #119981|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize --- Created attachment 120443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120443&action=edit Bug 27740: (follow-up) changed "User summary" css Changed user summary CSS to style H2 not H3 heading To test: 1) Go to OPAC homepage 2) Login as a user with at least one loan 3) See that the "User summary" heading is not styled 4) Apply patch 5) Run yarn build --view OPAC 6) Confirm the heading is now styled with grey background Signed-off-by: Wainui Witika-Park Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #42 from Martin Renvoize --- Great work team! I can't spot any further issues, but with Koha as "optional" as it is with various preferences and options changing what's displayed on the page I wouldn't be at all surprised if between us we've missed an occurrence somewhere with a specific setup. However, I think this is a great foundation and should be pushed as is.. we should just keep an eye out for bugs going forward. So.. with that said.. PQA! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- Good call Henry.. I look forward to seeing some work happen on this during the next cycle :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #3 from Owen Leonard --- (In reply to David Cook from comment #2) > I feel like the non-XSLT view was deprecated just not removed? I don't understand what you're saying. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28284] New: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28284 Bug ID: 28284 Summary: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This was previously resolved in bug 25877 - reintroduced by bug 28118 To recreate: 1 - Make a branch not a pickup location 2 - Sign in to staff client as that branch 3 - Attempt to place hold on item from another branch for a patron at the branch this is not a pickup location 4 - No items available - libraryNotPickupLocation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28284] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28284 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119918|0 |1 is obsolete|| --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 120444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120444&action=edit Bug 28180: Add Chocolat to OPAC See Bug 28179: Add the Chocolat gallery lightbox JS library Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #119919|0 |1
is obsolete||
--- Comment #9 from PTFS Europe Sandboxes ---
Created attachment 120445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120445&action=edit
Bug 28180: Add a lightbox gallery to display cover images - detail page, OPAC
interface
This patch is the OPAC version of
Bug 28179: Add a lightbox gallery to display cover images - detail page,
staff interface
But there were several difficulties as the staff and OPAC code diverged
a lot.
First we are going to apply the different enhancements that have been
made staff-side:
- Display all the local cover image on the bibliographic detail pages
(before this patch only the first one was displayed)
- The slider functionality added by bug 25031
Test plan:
All the cover images are affected, all the different sources will be
tested.
All the steps will be done on the same bibliographic record.
1. Local cover images
a. Turn on OPACLocalCoverImages and AllowMultipleCover
b. Add several local cover images to a bibliographic record
c. Add several local cover images to an item
d. Click on an image and confirm that it is displayed in a gallery and
you can navigate see all the images attached to the bibliographic
record
e. Same for items
2. Adlibris
a. Turn on AdlibrisCoversEnabled
b. Edit the biliographic record and add an ISBN that will return a
cover image for this service (9780670026623 for instance)
c. Display the cover images in the gallery
d. Note the link to the adlibris.com website at the bottom
3. Amazon
a. Turn on OPACAmazonCoverImages
b. Display the cover images in the gallery
4. Coce
a. Turn on OpacCoce, set CoceHost to "http://coce.tamil.fr:8080";
and select some values for CoceProviders.
b. Display the cover images in the gallery
5. Custom cover images
a. Turn on OPACCustomCoverImages and set CustomCoverImagesURL to
https://covers.openlibrary.org/b/isbn/{isbn}-M.jpg
of anything else meaningful
b. Display the cover images in the gallery
QA Note: Other sources have been removed by this patch but will be
re-added by follow-ups
Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at,
presseshop.ch)
Signed-off-by: joubu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119920|0 |1 is obsolete|| --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 120446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120446&action=edit Bug 28180: Reintroduce and adjust Syndetics Test plan: 1. Enable SyndeticsEnabled and SyndeticsCoverImages 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119921|0 |1 is obsolete|| --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 120447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120447&action=edit Bug 28180: Reintroduce and adjust Google Jackets Test plan: 1. Turn on GoogleJackets 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119922|0 |1 is obsolete|| --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 120448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120448&action=edit Bug 28180: Reintroduce and adjust OpenLibrary 1. Turn on OpenLibraryCovers 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119923|0 |1 is obsolete|| --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 120449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120449&action=edit Bug 28180: Reintroduce and adjust Baker and Taylor Test plan: 1. Turn on BakerTaylorEnabled and fill BakerTaylorUsername/BakerTaylorPassword (if you don't have, ask me) 2. Display the cover images in the gallery Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #119924|0 |1 is obsolete|| --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 120450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120450&action=edit Bug 28180: Bug fix - cannot select cover-nav button when on top of the .contentblock Found a bug and ended up with this solution, suggestions welcomed! example with OpenLibrary with isbn=9780670026623, the image is a bit higher than others and then the cover-nav buttons are on top of .contentblock and cannot be clicked Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28182] Elastic search exact authorities search includes punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182 jmbroust changed: What|Removed |Added CC||jean-manuel.broust@univ-lyo ||n2.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #7 from Martin Renvoize --- +1 for moving Koha config out of zebra config file +1 for not using XML As for the TOML vs YAML debate, I don't really have a horse in the race. The YAML support in Perl seems to have reached a suitable level of maturity so I feel it's a fairly safe bet really.. but I can understand some of the issues Julian presents. TOML is certainly a bit simpler in scope, and we shouldn't really be using the full scope of YAML in our configs anyway really so I'd suggest we shouldn't really be falling into many of the traps it presents.. How mature is the TOML support in perl... I note David looked at the TOML module (which is pure perl) and hasn't been updated since 2016.. does that mean it's perfect or it's just not maintained? There's also a recent TOML::XS module on cpan.. but will this get packaged and is it likely to be around for a while and maintained. Either way.. I think the splitting out of Zebra config from the config file is a great first step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Martin Renvoize changed: What|Removed |Added Attachment #120399|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 120451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120451&action=edit Bug 26995: Drop column relationship from borrowers, deletedborrowers and borrower_modifications tables Bug 14570 added a borrower_relationships table but it didn't remove the relationship column from the following tables: - deletedborrowers - borrowers - borrower_modifications Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Martin Renvoize changed: What|Removed |Added Attachment #120400|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 120452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120452&action=edit Bug 26995: Remove references to relationship column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 --- Comment #12 from Martin Renvoize --- Created attachment 120453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120453&action=edit Bug 26995: (QA follow-up) Fix logic in database update The logic was reversed.. if the column exists we want to delete it ;) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- Not sure what happened with this one.. there are patches uploaded by Jonathan but no signoff lines from him and the author suggests Kyle. Either way, it works as expected with my follow-up. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26790 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28278 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Agustín Moyano changed: What|Removed |Added Attachment #119022|0 |1 is obsolete|| --- Comment #5 from Agustín Moyano --- Hi Marcel, I'll reply between lines (In reply to Marcel de Rooy from comment #4) > Hi Augustin, > > I have some questions here: > > The tab is called Requested, but since all entries are requests, wouldnt it > be more logical to call it New ? I'll change it right away. For me "new" sounded like it was recently created, but I thought you may have old unprocessed requests, so in that context it seemed reasonable to call it "requested". > > If I pick a request to process, it would be handy to move it to Processing > immediately from the New tab? Instead of an additional move thru Pending. I wasn't told that was allowed, but it can be added. > > Can you explain the mail for a move to Pending? Since the patron gets an > email when he submitted the request and will have an email when we hit > Processing, does this mail saying 'We are doing nothing yet' make him happy > :) ? > I believe it's better to give as much feedback to patrons as we can.. Even if that message means "Your request was moved from the drawer of the left, to the drawer on the right". It might save the librarian a call like "what happend with my request" > Please run qa tools. I see this failure: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >FAIL valid_template > Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. > Compilation failed in require at > /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206. > => Is this related to biblio-view-menu.inc ? I believe it's a bug in qa tools, but I really got no idea why this error appears. I'll check it out once more --- Comment #6 from Agustín Moyano --- Created attachment 120454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120454&action=edit Bug 27944: Add "requested" stage in article request process This patch adds the stage "requested" in article request process, which is previous to pending stage. To test: 1. apply this patch 2. updatedatabase 3. enable ArticleRequests syspref 4. from staff inteface and from opac search for a record and place an article request 5. koha-mysql kohadev 6. query: select subject, content, letter_code from message_queue; CHECK => There is a message for each article request with code AR_REQUESTED => In opac-user.pl, in "Article requests" tab you should see a row in the table with "Requested" status 5. in staff go to Circulation -> Article Requests SUCCESS => You should see 3 tabs, one for Requested stage (with two requests), one for Pending stage and one for Processing stage. 6. play with actions buttons CHECK => you should see a new action called "Set request as pending" SUCCESS => All action buttons behave as expected, and tab counts updates correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 --- Comment #10 from Martin Renvoize --- Without patch Time (mean ± σ): 7.349 s ± 0.268 s[User: 6.451 s, System: 0.348 s] Range (min … max):6.968 s … 7.775 s10 runs With patch Time (mean ± σ): 2.377 s ± 0.104 s[User: 1.993 s, System: 0.148 s] Range (min … max):2.266 s … 2.551 s10 runs Run on a production virtual server. I'm happy with the result and the test is thorough... no regressions found. I'd love to see the subsequent bugs to split out the zebra config and possibly move away from XML.. but for now, even putting the performance improvement aside, this is a great step in the right direction for dropping our reliance on XML::Simple. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 Martin Renvoize changed: What|Removed |Added Attachment #120414|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 120455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120455&action=edit Bug 28278: Add unit test for Koha::Config::read_from_file Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278
Martin Renvoize changed:
What|Removed |Added
Attachment #120415|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 120456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120456&action=edit
Bug 28278: Improve $KOHA_CONF parsing speed by using XML::LibXML
- Without the patch:
$ hyperfine --warmup 1 \
'perl -MKoha::Config -e "Koha::Config->read_from_file(\$ENV{KOHA_CONF}) for
(1..1000)"'
Time (mean ± σ): 3.585 s ± 0.018 s[User: 3.531 s, System: 0.049 s]
Range (min … max):3.547 s … 3.612 s10 runs
- With the patch:
$ hyperfine --warmup 1 \
'perl -MKoha::Config -e "Koha::Config->read_from_file(\$ENV{KOHA_CONF}) for
(1..1000)"'
Time (mean ± σ): 1.122 s ± 0.028 s[User: 1.104 s, System: 0.014 s]
Range (min … max):1.095 s … 1.189 s10 runs
Test plan:
1. Apply the first patch (the one with the unit tests) and make sure
tests pass: `prove t/Koha/Config.t`
2. Apply the rest of the patches and verify that tests still pass:
`prove t/Koha/Config.t`.
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28278] Improve $KOHA_CONF parsing speed by using XML::LibXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28278 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28254] Make it possible to override rules in PUT /holds/:hold_id/pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28254 --- Comment #14 from Jonathan Druart --- Created attachment 120457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120457&action=edit Bug 28254: Simplify tests This is only cosmetic, and maybe personal preferences. It seems easier to create the library object with the pickup_library we want to use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28254] Make it possible to override rules in PUT /holds/:hold_id/pickup_location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28254 --- Comment #15 from Jonathan Druart --- Created attachment 120458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120458&action=edit Bug 28254: Add missing tests for PUT and POST -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #27 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #24) > Created attachment 120416 [details] [review] > Bug 27594: (follow-up) don't display "Copy link[...]" when not possible > > Signed-off-by: Victor Grousset/tuxayo I don't understand this patch. It does hide the link, not only when the copy is not possible, but always. I was expecting to see some JS code to check navigator.clipboard and add the link if defined. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #28 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #24) > Created attachment 120416 [details] [review] [review] > Bug 27594: (follow-up) don't display "Copy link[...]" when not possible > > Signed-off-by: Victor Grousset/tuxayo I don't understand this patch. It does remove the tooltip, not only when the copy is not possible, but always. I was expecting to see some JS code to check navigator.clipboard and add the link if defined. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #23 from Martin Renvoize --- I wonder if this might be a nice one to hit the 21.11 roadmap? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27740] Accessibility: OPAC - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740 --- Comment #43 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27760] Add handling for x-koha-override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27760 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27760] Add handling for x-koha-override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27760 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27865] Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #11 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28134] Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28134] Replace use of input type number in onboarding templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
