[Koha-bugs] [Bug 28304] C4/Templates::new causes error logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 --- Comment #1 from Michael Hafen --- Created attachment 120723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120723=edit Proposed fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28304] C4/Templates::new causes error logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Michael Hafen changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28304] New: C4/Templates::new causes error logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Bug ID: 28304 Summary: C4/Templates::new causes error logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: michael.ha...@washk12.org QA Contact: testo...@bugs.koha-community.org In C4/Templates::new() there is a call to $self->activethemes(), which I presume is to initialize a class variable. There is a sub in that packaged named activethemes though, which gets called instead, and results in a few lines in the web server error log because of incorrect parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 --- Comment #1 from Michael Hafen --- Created attachment 120722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120722=edit Proposed fix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28303] New: Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303 Bug ID: 28303 Summary: Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: michael.ha...@washk12.org QA Contact: testo...@bugs.koha-community.org With multiple pluginsdir settings in koha-conf.xml, C4/Template::badtemplatecheck changes the config, causing plugins-upload to try to unpack plugins to the opac-tmpl folder which badtemplatecheck unshifts into the pluginsdir array in config. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #12 from Gérard Simon Voyer --- Created attachment 120721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120721=edit Bug 17787: Hidden items included in count of search results opac-search.pl does not consider items hidden by OpacHiddenItems in the search count. This attachment aims at fixing the count for visual harmony, since the bug lives on but is only reported in cases where the results count is greater than the value of results_per_page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #120 from Gérard Simon Voyer --- Hi Alex! I'm trying my hand at sign offs. On a koha-docker-testing CT using master branch, I seem to fall on this error upon entering the ElasticSearch mappings setup : https://pastebin.com/8Mj7LzvM Something I'm doing wrong? I remember this message being addressed in one of the obsoleted patches. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #11 from Gérard Simon Voyer --- Sorry for the wait, it's a beautiful day outside in Québec. Tests made with a fresh koha-testing-docker setup on "master" branch of the GitLab repo (https://gitlab.com/koha-community/Koha) 1 - Search for "dance" in OPAC 2 - "Your search has returned 3 results" (https://snipboard.io/TalPXj.jpg) -- good 3 - add "itype: [MU]" to the OpacHiddenItems preference 4 - "Your search has returned 3 results" (https://snipboard.io/oFKXML.jpg) -- bug in action Am I still allowed to propose my glitchy bugfix? It would be good practice for me to test how to submit a first fix, even if it's still not going to be pushed anywhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #6 from Lucas Gass --- Created attachment 120720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120720=edit Bug 18112: (follow-up) add required class to select -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added Attachment #120213|0 |1 is obsolete|| --- Comment #11 from Phil Ringnalda --- Created attachment 120719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120719=edit Bug 23406: Test for 1 or 'Yes' in record suppression In marc21 we now link the 942$n to 'YES_NO' authorised values. When displaying the details page in the staff client the authorised values in a record are translated before parsing the record with XSLT The '1' for YES_NO is translated to 'Yes' - we simply need to test for this additional value in the XSLT to ensure we display the suppression message To test: 1 - Confirm 952$n in default framework is tied ot authorised value 'YES_NO' or do so 2 - Set OpacSuppression to 'Hide' 3 - Edit a record in the default template, changing 942$n to 'Yes' 4 - Confirm the record is suppressed in opac 5 - Note there is no suppression notice in the record in staff client 6 - Apply patch 7 - Reload and confirm staff side shows suppression notice 8 - Confirm record still suppressed in OPAC 9 - Edit record, set 942$n to 'no' 10 - Confirm there is no suppression notice in staff client 11 - Confirm you can view the record in OPAC Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] Authorized Value for Suppression when added to Frameworks doesn't show Suppress in Staff Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #20 from Nick Clemens --- Created attachment 120718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120718=edit Bug 27876: changed Your tags title to caption in OPAC On the tags page, changed the "Your tags" to a to reduce heading redundancy but keep the information available. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-tags.pl 4) Ensure that there is a caption above the table that says "Your tags" and that it is not a heading tag Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 --- Comment #19 from Nick Clemens --- Created attachment 120717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120717=edit Bug 27876: took away redundant heading in OPAC full serial issues Changed to and deleted current to eliminate redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to opac-serial-issues.pl 4) Check there is only one main heading and it is Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Nick Clemens changed: What|Removed |Added Attachment #120199|0 |1 is obsolete|| Attachment #120200|0 |1 is obsolete|| Attachment #120201|0 |1 is obsolete|| --- Comment #18 from Nick Clemens --- Created attachment 120716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120716=edit Bug 27876: added sr-only to caption of table in Charges page Made the "Your charges" caption of the table in the Charges page of the OPAC hidden and for screen-readers only so that it takes out redundancy. To test: 1) Apply patch 2) Go to OPAC 3) Go to Charges page 4) Ensure that there is no visible caption above the table that says "Your charges" 5) Check that the code has the caption still with sr-only class Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27876] Accessibility: OPAC - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27876 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Lucas Gass changed: What|Removed |Added Attachment #120682|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 120715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120715=edit Bug 28229: (follow-up) Adjust for easier translation I think moving the [% IF %] out of the HTML tag makes for easier translation. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28229] Hide clubs from place a hold screen if no clubs exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28229 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28160] Values from 150$a aren't prefilled in z39.50 search form from an existing authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28160 Nick Clemens changed: What|Removed |Added Attachment #119948|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 120714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120714=edit Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record For names and uniform titles, when you do a z39.50 search from an authority record, we prefill what's in the relevant tag's subfield a in the search form, but for subjects, we don't, both because GetMandatoryFieldZ3950 thinks the param is topic when it's actually subject, and because z3950_auth_search.tt doesn't bother putting the value of into the form. Test plan: 1) Authorities - New authority - Topical Term 2) Tab 1, click on HEADING-TOPICAL TERM to expand subfields 3) In subfield a, type goats 4) Click Z39.50/SRU search and verify that the Subject heading search field has goats prefilled Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28160] Values from 150$a aren't prefilled in z39.50 search form from an existing authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28160 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28159] URI-encode existing values put into query string for z39.50 authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28159 Nick Clemens changed: What|Removed |Added Attachment #119949|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 120713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120713=edit Bug 28159: URI-encode existing values put into query string for z39.50 authority search When you trigger a z39.50 search from an existing authority record, Koha prefills the search form with the value in the record. But because that value passes through a URL, if it isn't URI-encoded characters like & or ; will cut off the value. Test plan: 1) Authorities - New authority - Corporate Name 2) Tab 1, click "HEADING-CORPORATE NAME" to expand subfields 3) Subfield a, type foo & bar ; baz 4) Click Z39.50/SRU search 5) Ensure the whole string appears in the Author (corporate) field in the popup Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28159] URI-encode existing values put into query string for z39.50 authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28159 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27855] Allow embedding extended_attributes on /patrons routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27855 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28002] Add optional extended_attributes param to POST /patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23666] Add routes for extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27853] POST /patrons doesn't enforce mandatory extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27853 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241
Nick Clemens changed:
What|Removed |Added
Attachment #120319|0 |1
is obsolete||
--- Comment #6 from Nick Clemens ---
Created attachment 120712
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120712=edit
Bug 28241: Fix regex to allow for content before and after comma
1. Set up the OPACNoResultsFound with the {QUERY_KW} placeholder.
2.Do a search with a comma that will return no results. Like "King, Martin
Luther". If the returns results add some additional characters to the search
until no results are returns.
3. Look at the #noresultsfound HTML element. Anything before (or after) the
comma is omitted. So the placeholder looks something like 'Martin Luther'
instead of 'King, Martin Luther'.
4. Apply patch
5. Try the search again, you should see the content before and after a comma
Signed-off-by: Lisette Scheer
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28241] OPACNoResultsFound {QUERY_KW} placeholder doesn't always match the search terms when commas are included in the search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28241 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28135] Replace use of input type number in additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28283 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28283] `Quantity received` should have inputmode="numeric"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28135 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28187] rowGroup headings are getting their styles overriden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28187 Nick Clemens changed: What|Removed |Added Status|Signed Off |In Discussion CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28135] Replace use of input type number in additem.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- (In reply to Martin Renvoize from comment #4) > This one seems to work for me.. what browser were you using to test Severine? I get a similar problem to Severine on Firefox - I ordered 13 copies, put 3.4 into the quantity to receive. When I typed 3 it selected three items, when I put '.4' it deselected all, but let me proceed. The quantity field in the order is correct at 10, but the quantity in the received order is 'NULL' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19037] Circulation and fine rules test tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 --- Comment #6 from Kyle M Hall --- Created attachment 120711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120711=edit Bug 28091: Only show for logged in users Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Kyle M Hall changed: What|Removed |Added Attachment #119188|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 120710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120710=edit Bug 28091: add meta content with Koha version to staff client pages TO test: -apply patch -go to the Koha staff client and inspect the page, look at the HTML -there should be a line that looks like this: Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 --- Comment #4 from Kyle M Hall --- (In reply to Kyle M Hall from comment #3) > I like this idea a lot, but I think it should be hidden on the login screen > since that would allow an unauthenticated user to know what version of Koha > is being run. That data could be used for automated attacks against Koha > server. It's unlikely I know, but it is a security best practice. I think wrapping that in [% IF logged_in_user %] [% END %] would be sufficient to fix the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall --- I like this idea a lot, but I think it should be hidden on the login screen since that would allow an unauthenticated user to know what version of Koha is being run. That data could be used for automated attacks against Koha server. It's unlikely I know, but it is a security best practice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #27 from Kyle M Hall --- Created attachment 120709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120709=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26 from Kyle M Hall --- prove t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. Warning: element has non-unique value in 'name' key attribute: F at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 36. Warning: element has non-unique value in 'name' key attribute: B at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 36. GetMarcBiblio called with undefined biblionumber at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 85. # Looks like you planned 13 tests but ran 2. t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. 1/1 # Failed test 'Templates applied using simple and advanced MARC Editor' # at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 154. Can't call method "field" on an undefined value at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 86. # Looks like your test exited with 255 just after 1. t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report --- t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Files=1, Tests=1, 4 wallclock secs ( 0.02 usr 0.00 sys + 1.79 cusr 0.27 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27583] Clarify how cash management fits together
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #22 from Kyle M Hall --- Created attachment 120708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120708=edit Bug 27498: (follow-up) Update to display logic Signed-off-by: Katrin Fischer Signed-off-by: Amit Gupta Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall changed: What|Removed |Added Attachment #118709|0 |1 is obsolete|| Attachment #118710|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 120707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120707=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. Signed-off-by: Katrin Fischer Signed-off-by: Amit Gupta Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27498] Add a link for the hold ratios to acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #37 from Kyle M Hall --- I think OPACFineNoRenewals needs to be renamed to FineNoRenewals or something along those lines to prevent confusion in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28233] Backport removal of excess opaccredits div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28233] Backport removal of excess opaccredits div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall changed: What|Removed |Added Attachment #120208|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 120706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120706=edit Bug 28233: Backport removal of excess opaccredits div Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #333 from Jonathan Druart --- (In reply to Jonathan Druart from comment #331) > I know librarians can have weird needs but, should we really offer the > "custom" preset? I am reading the tests right now and some combinations are > doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 > "action" column with the predefined ones? (not considering this question a > blocker, but I would be happy to get an answer). See the "warning"s and "fixme"s from the last patch please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate CC||m...@kohaaloha.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #332 from Jonathan Druart --- Created attachment 120705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120705=edit Bug 14957: Improve readbility of tests Not saying that they were not readable before, but I had to do some changes to compare the before/after records and it was easier that way. Feel free to obsolete if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28233] Backport removal of excess opaccredits div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28233 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19787] Adding system preferences to configure the screen messages for SIP checkout flags in Self-Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787 Kyle M Hall changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Julian Maurice changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #1 from Julian Maurice --- Created attachment 120704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120704=edit Bug 28302: Forbid CGI::Compile 0.24 CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. Test plan: 1. Reproduce the bug 2. Install CGI::Compile 0.25 and restart starman 3. Make sure the bug is gone :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24023 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24023] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24857 --- Comment #27 from Tomás Cohen Arazi --- I find the idea really interesting. Have a few questions, though: - Can we do it in Koha::Item::Bundle(s) instead? Most of the C4::Items CRUD stuffs have been moved to Koha::Item(s) and we have a bunch of handy tools there. - Bundles would probably end-up being some kind of meta-item types. I don't see anything circ-related (for setting circulation rules on bundles). So, is it going to calculate the circ/hold rules based on one of the items? which? I would go the meta-item type way to simplify things. - Bug 24857 is introducing the concept of volumes at biblio level. Which sort-of have -implicitly- a similar meta-itype: in that case you place a hold on 'any copy of DVD 2 for Lord of the Rings'. It would be interesting to think how this dev will interact with that one: we could want to place a hold on the three LOTR movies (as a bundle), which would mean instead of a specific item, the bundle could include volume members instead. - How does checkout work for bundles? You check one item out, it identifies itself as part of a bundle, and checks all out? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] New: Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Bug ID: 28302 Summary: Koha does not work with CGI::Compile 0.24 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. I suggest to just forbid CGI::Compile 0.24 in cpanfile (patch coming soon) Warning for Ubuntu Focal users: the packaged version of CGI::Compile is 0.24 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #10 from Gérard Simon Voyer --- (In reply to Tomás Cohen Arazi from comment #8) Also the smartest thing I've heard today, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #9 from Gérard Simon Voyer --- Currently setting up a fresh docker-testing box so I can sign-off on a few bugs I've commented on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #15 from Kyle M Hall --- Package install already have this type of functionality. Good to see it available for non-package installs! Only open question is that of an upgrade path. I think upgrade notes will be needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 --- Comment #14 from Kyle M Hall --- Created attachment 120703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120703=edit Bug 12169: Fix SIPconfig.xml, restore missing end tag Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Kyle M Hall changed: What|Removed |Added Attachment #119001|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 120702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120702=edit Bug 12169: Use pid file in sipserver shutdown Change sample SIPConfig to request server writes a pid file Use this pid in shutdown rather than the current open to error method. Have also added to the Config parameters to ensure that the sipserver runs as the correct user and sets its own session id. These are always useful but makes it easier for users to run up the sipserver as root at boot time similarly to apache, mysql etc Added to the sample config where to locate other server parameter documentation. Removed from the sample config the unedifying, unwanted and purely historical http example Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28286] Place hold button not displayed when biblio has only Ordered items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28286 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Passing QA, but wondering if this method is really necessary? The 'Place hold' button is the same link as the 'Holds' tab on the left hand side It checks one indicator of whether the items may be holdable or not, but we don't really know holdability until we select a patron. If the items are all not for loan, but AllowHoldPolicyOverride is set, we can place holds but don't see the button. Can we just show the button all the time and remove this single use method? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #331 from Jonathan Druart --- I know librarians can have weird needs but, should we really offer the "custom" preset? I am reading the tests right now and some combinations are doing funky stuffs. Maybe we could simplify the UI if we stick to the only 1 "action" column with the predefined ones? (not considering this question a blocker, but I would be happy to get an answer). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 --- Comment #10 from Victor Grousset/tuxayo --- (In reply to Julian Maurice from comment #8) > Yes. Each service is started in a different process and they need to read > $KOHA_CONF too. Good :) > I don't know how Selenium works, but I'm not too worried about those calls. Sorry for the confusion, during the Selenium tests, the logs of Koha didn't show a call to the function. It was just a lazy way to do things in the UI ^^ The terminal where prove -r t/db_dependent/selenium was run did. But I'm not worried about that either. > Did you test this on master ? Yes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28286] Place hold button not displayed when biblio has only Ordered items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28286 Nick Clemens changed: What|Removed |Added Attachment #120674|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 120701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120701=edit Bug 28286: show "Place hold" button if item is holdable This patch adds "filter_by_for_hold" method in "Items.pm" and uses it in "cat-toolbar.inc" instead of "filter_by_for_load". Also this patch removes "filter_by_for_loan" method. To reproduce the bug: 1) go to /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX that has item with notforloan value set as "Ordered" (-1) 2) see that button "Place hold" is not present 3) apply the patch 4) refresh the page and ensure that "Place hold" button appears even if item is "Ordered" Signed-off-by: Owen Leonard Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28286] Place hold button not displayed when biblio has only Ordered items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28286 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #27 from Kyle M Hall ---
Created attachment 120700
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120700=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility to expand authorised values when to_api
method is called.
The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following
{
column_name => Koha::AuthorisedValue->unblessed
...
}
This patch will be used in bug 8179, so please test there.
Sponsored-by: Virginia Polytechnic Institute and State University
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Kyle M Hall changed: What|Removed |Added Attachment #116592|0 |1 is obsolete|| Attachment #116593|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 120698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120698=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t and t/db_dependent/Koha/REST/Plugin/Objects.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Kyle M Hall changed: What|Removed |Added Attachment #120698|0 |1 is obsolete|| --- Comment #26 from Kyle M Hall --- Created attachment 120699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120699=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t and t/db_dependent/Koha/REST/Plugin/Objects.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27431] ES searches containing words starting with 2 hyphens or only hyphen(s) fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27431 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #3 from Nick Clemens --- Can we get a more detailed test plan and some unit tests for this one? Terms beginning with '-' are treated as negtive terms, i.e. the results shouldn't have them - this doesn't seem to affect that Is this affecting biblio search as well as auth? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28181] Archived debit type still shows as available in Point of Sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | Assignee|k...@bywatersolutions.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28181] Archived debit type still shows as available in Point of Sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|martin.renvoize@ptfs-europe |k...@bywatersolutions.com |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15869] Change framework on overlay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27968] MARC framework CSV and ODS import incomplete or corrupted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27968 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #19 from Sarah Cornell --- What are our chances of having this pushed to 20.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26471] Datatables js error on missing pdfmake.min.js.map
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26471 Nick Clemens changed: What|Removed |Added Attachment #119250|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 120695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120695=edit Bug 26471: Remove invalid Map URL There is a warning in the console: Error en el mapeo fuente: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data URL del recurso: http://kohadev-intra.mydnsname.org:8081/intranet-tmpl/lib/datatables/datatables.min_20.1200011.js URL del mapa fuente: pdfmake.min.js.map https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26471] Datatables js error on missing pdfmake.min.js.map
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26471 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #330 from Jonathan Druart --- (In reply to Martin Renvoize from comment #327) > (In reply to Jonathan Druart from comment #324) > > 5. Can you explain me what this rule means? > > > > | id | tag | module | filter | add | append | remove | delete | > > | 1 | 12 | source | batchmod | 1 | 0 | 0 | 0 | > > With 'batchmod', only add tag 12 is if exists only in the incoming record. I still don't understand, but I now see the manual stuff, will read it (haven't seen it before, sorry!) Note for myself: One another thing to check, how is working the "preview" for the batchmod. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28181] Archived debit type still shows as available in Point of Sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181 Nick Clemens changed: What|Removed |Added Attachment #120677|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 120694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120694=edit Bug 28181: Filter out archived debit types in point of sale The filter for only displaying un-archived debit types on the point of sale page had been missed. NOTE: It would be beneficial to move this to a default filter in the Koha:: objects search method for both debit_types and credit_types.. but I opted for the quick fix here to resolve the bug and will impliment default filtering in a subsequent enhancement bug. Test plan 1/ Archive a debit type that is marked as 'Can be sold' 2/ Go to the point of sale page and confirm the above debit type appears 3/ Apply the patch 4/ Confirm the debit type no longer appears in the point of sale page. Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28181] Archived debit type still shows as available in Point of Sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28181 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | --- Comment #8 from Tomás Cohen Arazi --- My opinion, is that we should add indexes for hidden things, and implicitly use them so records are not included in search results. As opposed to doing funky arithmetic calculations afterwards. This would solve many other issues like hidden records being included in facets, etc. I can commit to work on this after the 21.05 release. And would love to have help with testing, from people participating in this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- Just noting - if other subfields are ignored, then the added subfield preserves the tab in the yaml. I think this makes sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Kyle M Hall changed: What|Removed |Added Attachment #120428|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 120693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120693=edit Bug 28276: Do not fetch config ($KOHA_CONF) from memcached memcached address and namespace are in $KOHA_CONF, so it is required to read it before being able to access the cache. And after that, configuration is kept in memory forever. Storing this in memcached is useless and even counter-productive, since Koha reads both the file and the cache This patch addresses this issue by removing the cache-related code from C4::Context->new. It means that C4::Context->new will always read the configuration file, so this patch also replaces inappropriate calls to C4::Context->new->config by appropriate calls to C4::Context->config It also fixes a bug where C4::Context->new would ignore the filepath given in parameters if there was something in cache. It also removes a problematic call to Koha::Caches->get_instance. Because this call was outside of any subroutine, it would have happened before the initialization of $C4::Context::context (which happen in C4::Context::import) Test plan: 1. Do not apply the patch yet 2. Add the following line at the beginning of Koha::Config::read_from_file warn "read_from_file($file)"; This will allow you to check how many times the file is read. 3. Flush memcached and restart starman 4. Check the logs, you should see "read_from_file" a bunch of times 5. Apply the patch 6. Re-add the line from step 2 7. Flush memcached and restart starman 8. Check the logs, you should see "read_from_file" only once 9. Make sure the memcached config from $KOHA_CONF (memcached_servers, memcached_namespace) is taken into account by checking the About page Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 --- Comment #16 from Nick Clemens --- Created attachment 120692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120692=edit Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: Koha team Signed-off-by: sonia Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24564] The adding of new subfields according to IFLA updates doesn't respect existing tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24564 Nick Clemens changed: What|Removed |Added Attachment #120156|0 |1 is obsolete|| Attachment #120157|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 120691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120691=edit Bug 24564: Do not modify the tab of existing subfield in ifla/update.pl Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that you have in your default biblio MARC framework (or create one). 2. Change the tab of this subfield so that it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl --force 4. Verify that the tab of this subfield has not been changed. 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: sonia Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299
--- Comment #2 from Tomás Cohen Arazi ---
I expect to see something like:
my $items = $biblio
->items
->filter_by_visible_in_opac({ patron => $patron });
in the controller.
I see why it is written like this (buildKohaItemsNamespace makes a new query on
items filtering the hidden ones out). Should we (temporarily) add an extra
parameters $only_this_items and pass this calculated value instead?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #38 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #37) > (In reply to Jonathan Druart from comment #36) > > What about opac-shelves? > > > > Items are not hidden there... > > See bug 28299. > > Additional question: Does it really make sense to have this one part of > 21.05 with all the other OpacHiddenItems bugs we have (see bug 24403)? I think it makes total sense. Most of those bugs are cosmetic (facets that won't return results, wrong counts). The other ones shouldn't prevent this to get into master. Those need to be rewritten using Koha::Biblio->hidden_in_opac and friends, which takes into account what is introduced on this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
