[Koha-bugs] [Bug 27562] itiva notices break if record title contains quotes

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562

--- Comment #6 from Victor Grousset/tuxayo  ---
Thanks Owen :)


QA: Looks good to me. I'll try to find someone to signoff.

Test note: here are instruction to setup i-tiva
https://wiki.koha-community.org/wiki/External_Integration#i-tiva

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27623] Remove pl-PL installer data

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623

--- Comment #21 from Victor Grousset/tuxayo  ---
Retried, still works after bug 28291 and bug 28281 :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

--- Comment #18 from Victor Grousset/tuxayo  ---
Still works. Tests work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #120552|0   |1
is obsolete||

--- Comment #17 from Victor Grousset/tuxayo  ---
Created attachment 120725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120725=edit
Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set

There is code in populate_order_with_prices that is intended to use ecost over
unitprice,
it just doens't seem to be working.

Making it more explicit seems to take care of the issue.

To test:
1 - Create a basket
2 - Add an order line, don't set 'Actual cost: ', but use vendor price
and a discount.
3 - Save
4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set.
5 - Apply batch
6 - Redo 1,2, 3
7 - Display all columns, GST is calculated correctly, unitprice remains 0.

Signed-off-by: Marjorie 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #120551|0   |1
is obsolete||

--- Comment #16 from Victor Grousset/tuxayo  ---
Created attachment 120724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120724=edit
Bug 27203: Adjust unit tests

It seems the issue here is that the price passed in is a string, and not a
number, so the tax
value is not calculated when no unitprice is provided

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203

--- Comment #15 from Victor Grousset/tuxayo  ---
> unitprice remains 0.

More like 'Actual cost tax inc.' right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064

--- Comment #8 from Victor Grousset/tuxayo  ---
Seems to works as expected but I see 4 transfers in the UI (Transferred items)
And I'm not sure if the data is correct.

(tried to make the table compact, so stuff was abridged)

--++++---++---++---
id|dt_rqstd|datesent|from|darrive|dcancel |to |reason  |canc_reason
--++++---++---++---
↓↓ 6) set the hold waiting - click it   ↓
 1|18:50:39|18:50:39|CPL |8:50:48||FFL|Manual  |NULL
↓↓ Revert the hold or cancel and place a new one (NOT SURE ABOUT
THAT)↓↓↓ 
 2|18:52:43|18:52:43|CPL |   |18:53:19|FFL|Manual  |Manual  
↓ 14) Click that↓   
 3|18:53:19|18:53:19|CPL |   |18:53:24|FFL|Manual  |CancelRes  
↓ 16) choose 'cancel↓
 4|18:53:24||CPL |   |18:53:24|CPL|TransfCancel|Manual 
 5|18:53:24|18:53:24|CPL |   ||FFL|Manual  |NULL   
--++++---++---++---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28264] Transaction type is empty is cash register statistics wizard report

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238

--- Comment #2 from Koha Team University Lyon 3  ---
Test plan :

To see the output of getavailability service, run the following url in your
browser :

[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio
or this one
[OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item

where the [OPACBASEURL] is the opac url of your test instance, [BIBLIONUMBER]
and [ITEMNUMBER] a record number and itemnumber of your choice.

After applying the patch, you'll see an extra tag itemcallnumber. 
Exemple :
840.08 COR R

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

2021-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #157 from Koha Team University Lyon 3  ---
Oh ! stupid ! I did'nt get it !. I think I only checked the flat list below.
I redo the test checking the irregularities in the choice list and you are
right it-s OK : this time irregularities are kept.

I will sign off but I have 2 last suggestions :

I think all the same, the display for weeks type is little ambiguous :
The presence of 2 wordings very close can be troubling

Please check the issues that are NOT published (irregularities)
and below :
Choice the weeks in the year where the issues are not published

May be, in this case, the second is redundant. I would suggest to suppress the
second and make the first like this :
Please check in the dropdown list, the issues that are NOT published
(irregularities)

and last thing : the "Weeks(s)not_published" form is jumping when we check a
checkbox. Could you add a "return false" to "Check_permanent_irregularities"
function to prevent this ?

Olivier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/