[Koha-bugs] [Bug 28292] Searching with colon ":" in the end of query gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28020] Error responses should return a code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #5 from David Cook --- Sounds good to me. I would've liked this as a patch set to make it easier to read. It looks like there are quite a few different changes here, so I think QA will need to take time to unpick them to make sure everything is OK. Unfortunately, I don't have that time right now. But +1 to the idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27267 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28306 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #19 from David Cook --- (In reply to Julian Maurice from comment #18) > David, can you take a look at bug 28306 ? > I think you can replace your _get_dbh call by a call to Koha::Database->dbh > without using much more memory. Thanks for commenting here. I saw bug 28306 and thought it would be perfect to use here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #14 from David Cook --- I've provided an alternate patch for dropping support for the abbreviated format. I'll leave it up to QA and the RM to decide if they want to support the abbreviated format or not. It doesn't really matter to me either way, but we need to do something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #13 from David Cook --- Created attachment 120818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120818=edit Bug 28200: [Alternate] Remove unit test using abbreviated format This patch removes the unit test that uses the abbreviated format, since it's not supported in newer versions of Net::Netmask without a workaround. Test plan: 0. Set up Koha dev environment on Debian 11 1. perl t/Koha/Middleware/RealIP.t 2. Tests should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #4 from David Cook --- So... I think that it would be OK to sign this off. For Ubuntu Focal, we should package CGI::Compile 0.25. That doesn't need to happen in the Koha codebase, so it's not a blocker here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28276] Do not fetch config ($KOHA_CONF) from memcached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28276 --- Comment #12 from David Cook --- Yay! This should prevent many a headache... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Victor Grousset/tuxayo --- Lol so easy to test with a devbox :D It works! A bit out of topic: Good thing it's still there. If the question of redoing it as wrapper of koha-testing-docker come up, it needs to be kept in mind that such tests won't be as easy due to loosing systemd in the process. Likely not that often needed to be a great weight in the balance. I could have used vagrant for a Debian VM and installed Koha there. Hum, sharing the code with the host might be difficult. And maybe I would have needed this gitify thing. Hum, might be harder than expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117552|0 |1 is obsolete|| --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 120817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120817=edit Bug 27844: Launch koha-worker systemd service as koha linux user This patch adds the User directive to the koha-worker systemd unit file Test plan: 0a. DO NOT APPLY PATCH YET 0b. Start a Koha testing environment running systemd 1. koha-worker --stop kohadev 2. cp debian/templates/koha-worker@.service /etc/systemd/system/. 3. systemctl start koha-worker@kohadev.service 4. ps -efww | grep "background_jobs_worker" 5. Note koha-worker is running as root 6. APPLY THE PATCH 7. cp debian/templates/koha-worker@.service /etc/systemd/system/. 8. systemctl daemon-reload 9. systemctl restart koha-worker@kohadev.service 10. ps -efww | grep "background_jobs_worker" 11. Note that koha-worker is now running as kohadev-koha Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #27 from Victor Grousset/tuxayo --- Thanks for the test and QA :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #22 from Victor Grousset/tuxayo --- Rebased and solved conflict. > The patch needs a major rebase, since we since moved some things around like > changing the way we do the translations on this script. Does it? Test plan work on my instance. > But the problem remains. I tested with: a "test" With sample data, the test plan succeeds with «a "test"» -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #74610|0 |1 is obsolete|| --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 120816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120816=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28312] We should not assume hold pickup branch = ReservesControlBranch when checking it holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28312 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28309] Searching with hyphen doesn't work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28309 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 --- Comment #2 from Katrin Fischer --- That was pretty quick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 --- Comment #34 from Katrin Fischer --- (In reply to Jonathan Druart from comment #31) > I have noticed that as well. Actually it's not a matter of position, but it > depends on the size of the image. If the image is small you will see the > loading image in the background. > It's worth to open a new bug report. Done: bug 28314 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28179] Use a lightbox gallery to display the images - detail page, staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28179 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28314 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28179 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28314] New: Spinning icon is not always going away for local covers in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Bug ID: 28314 Summary: Spinning icon is not always going away for local covers in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Noticed while testing bug 28179 that sometimes the 'spinning icon' for local covers won't go away on the small display on the left of the detail page in the staff interface. It looks like this is related to the size of the picture. I was using cropped screenshots, so nothing too high quality. Joubu wrote: >If the image is small you will see the loading image in the background. >It's worth to open a new bug report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #28 from Katrin Fischer --- Nick, as you signed this one off, could you please also take a look at signing off the dependency bug as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Katrin Fischer changed: What|Removed |Added Attachment #120725|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 120815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120815=edit Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set There is code in populate_order_with_prices that is intended to use ecost over unitprice, it just doens't seem to be working. Making it more explicit seems to take care of the issue. To test: 1 - Create a basket 2 - Add an order line, don't set 'Actual cost: ', but use vendor price and a discount. 3 - Save 4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. 5 - Apply batch 6 - Redo 1,2, 3 7 - Display all columns, GST is calculated correctly, unitprice remains 0. Signed-off-by: Marjorie Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Katrin Fischer changed: What|Removed |Added Attachment #120724|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 120814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120814=edit Bug 27203: Adjust unit tests It seems the issue here is that the price passed in is a string, and not a number, so the tax value is not calculated when no unitprice is provided Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #24 from Katrin Fischer --- 4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. That is the line that realy confused me. I kept looking at the Actual cost columns, but you actually need to look at the GST column! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Nick, from your last comment#, should this be FQA (as in: Needs more work)? You mention an issue with multi-holds for clubs. I doesn't apply, the conflict looks simple, but setting this one step back to get confirmation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] Add street type to main address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Lucas Gass changed: What|Removed |Added Blocks||28313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 [Bug 28313] Add street type to alternate address in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Lucas Gass changed: What|Removed |Added Depends on||18112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 [Bug 18112] Add street type to main address in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 --- Comment #1 from Lucas Gass --- Created attachment 120813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120813=edit Bug 28313: Add street type to alternate address in OPAC 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure B_streettype is NOT checked 3. Go the self reg form, no alternate address street type field 4. Apply patch 5. Check the self reg form, B_streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, B_street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28290] Record matching rules with no subfields cause ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28290 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- QA script explodes a bit - missing a dependency maybe? Can you please verify/check? FAIL C4/Matcher.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling FAIL valid Can't locate Carp/Always.pm in @INC (you may need to install the Carp::Always module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #18 from Katrin Fischer --- (In reply to Koha Team University Lyon 3 from comment #17) > Hi Jonathan :) > I don't want to change the name in the yml, I just want to know if we could > translate the display in pootle to have it in French. > As you can see in the screen shot, it's sometimes difficult to know exactly > which column is which.. > https://snipboard.io/lZvsrA.jpg > > Do you think it's possible ? > > (By the way, I realize that "replacement price" and "recommended retail > price" are translated by "prix public" and that is confusing.. I can at > least change that !) Hi, we recently discussed ways to make those translatable on IRC, but concluded that the first step would be to make the English descriptions nice too, as they are more "code like" at the moment. I think it would be a great to have that. Could you please file a separate bug report for it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Passed QA --- Comment #8 from Tomás Cohen Arazi --- Sending to the RM queue. credit_sequence_number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- I am a bit worried about the added warnings from running the tests with and without this patch set: With patch: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. 2/14 Use of uninitialized value in numeric eq (==) at t/db_dependent/Items.t line 247. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. Use of uninitialized value $tag in regexp compilation at /usr/share/perl5/MARC/Record.pm line 206. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 207. t/db_dependent/Items.t .. 12/14 Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. t/db_dependent/Items.t .. ok All tests successful. Files=1, Tests=14, 11 wallclock secs ( 0.05 usr 0.01 sys + 7.52 cusr 1.11 csys = 8.69 CPU) Result: PASS Without patch: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. 2/14 Use of uninitialized value in numeric eq (==) at t/db_dependent/Items.t line 247. t/db_dependent/Items.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 120812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120812=edit Bug 28272: Fix many things... This patch could've been splitted into several. But, overall, adding additionalAttributes: false made the API fail on requests that send extra info (i.e. cases in which a dev added an attribute to the underlaying class/table and forgot to deal with it on the API (either adding it on the spec, or removing it from the response using Koha::Class::to_api_mapping). - Koha::Account::Line was missing: credit_type, interface, status, register_id and credit_number. I decided to call cash_register_id, and to remove credit_number from the response. FIXME: We need consensus on a name for the credit_number attribute, and add it to the response on the API. It deserves a separate bug. Too opinionated for a last-minute fix. - Koha::Club::Hold::add was returning bad auto-calculated values on field that (also) wasn't specified on the spec. Needs a test. - import_batch_profile had a typo: id_profile vs. profile_id. - error.json: In this case I reverted the change. This is because some routes are adding more 'info' with the error message, and I consider this should be done in a more generic approach. Time is required for us to think about this. So don't break the API in the meantime. FIXME: Implement a generic way to add a payload to error messages on the API. Maybe something to work on while on bug 28020. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/ => FAIL: Lots of tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28020] Error responses should return a code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] Add street type to main address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28313 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28313] New: Add street type to alternate address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313 Bug ID: 28313 Summary: Add street type to alternate address in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Street type needs to be added to the alternate address block in the OPAC (see bug 18112). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Show list of hits for one search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Everything works good here and I'm signing off. One thing, the QA tool doesn't like the commit message because there is no ':' after 'Bug 25885'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] Add street type to main address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] Add street type to main address in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added Summary|opac-memberentry.pl doesn't |Add street type to main |contain streettype field|address in OPAC Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Show list of hits for one search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Lucas Gass changed: What|Removed |Added Attachment #120615|0 |1 is obsolete|| --- Comment #9 from Lucas Gass --- Created attachment 120811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120811=edit Bug 25885 - Show list of hits for one search result Default behaviour in Koha, for a bibliographic search that returns one hit is to skip the result list and go straight to the detail view of that one hit. This patch makes this behaviour configurable. To test: - Make sure you can do a search that returns exactly one hit - Apply this patch - Do the search and verify the default behaviour of skipping the result list and going straight to detail view is in place - Toggle the OPACShowResultListOfOne syspref and make sure the behaviour corresponds to the setting. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Show list of hits for one search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added Attachment #120771|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 120810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120810=edit Bug 18112: (follow-up) add required class to select Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 Katrin Fischer changed: What|Removed |Added Attachment #120770|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 120809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120809=edit Bug 18112: Add street type to self reg/self mod form 1. Add some values to the ROADTYPE authorized value 2. Go to PatronSelfRegistrationBorrowerUnwantedField and make sure streettype is NOT checked 3. Go the self reg form, no street type field 4. Apply patch 5. Check the self reg form, streettype should be there with all the options defined in ROADTYPE a.v. 6. Check the self modification form, street type should be there. 7. Make sure PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField hide the field correctly. 8. Make sure PatronSelfRegistrationBorrowerMandatoryField properly makes the field required. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112 --- Comment #9 from Katrin Fischer --- I think this is a needed change and I don't want to block it. But should we not open a new bug for adding the street type to alternate address as well to match the staff side? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Katrin Fischer changed: What|Removed |Added Attachment #120804|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 120808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120808=edit Bug 23406: Don't translate suppressed authorised values We have a test in C4/XSLT/transformMARCXML4HTML which is meant to exclude the 942n, however, it doesn't work because it checks the $subfield parameter against n $subfield is an arrayref with the code and value as members we need to check $subfield->[0] To test: 1 - Apply only unit tests 2 - prove -v t/db_dependent/XSLT.t 3 - It fails 4 - Confirm 952$n in default framework is tied ot authorised value 'YES_NO' or do so 5 - Set OpacSuppression to 'Hide' 6 - Edit a record in the default template, changing 942$n to 'Yes 7 - Confirm the record is suppressed in opac 8 - Note there is no suppression notice in the record in staff client 9 - Apply second patch 10 - Reload and confirm staff side shows suppression notice 11 - Confirm record still suppressed in OPAC 12 - Edit record, set 942$n to 'no' 13 - Confirm there is no suppression notice in staff client 14 - Confirm you can view the record in OPAC 15 - prove -v t/db_dependent/XSLT.t 16 - Tests pass! Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Katrin Fischer changed: What|Removed |Added Attachment #120803|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 120807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120807=edit Bug 23406: Unit test Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 --- Comment #17 from Katrin Fischer --- Awesome! Thx for the quick alternate patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27562] itiva notices break if record title contains quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo --- Thanks Owen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Attachment #120141|0 |1 is obsolete|| --- Comment #29 from Ivan Dziuba --- Created attachment 120806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120806=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28284] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28284 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28312 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28312] New: We should not assume hold pickup branch = ReservesControlBranch when checking it holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28312 Bug ID: 28312 Summary: We should not assume hold pickup branch = ReservesControlBranch when checking it holds are allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: tomasco...@gmail.com Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To replicate: - Have branches A & B - In the Libraries setup, set A to be a pickup location, B to not be a pickup location - Set ReservesControl to Item's Home Library - Have a bib with two items, one owned by each branch - Confirm circ rules say all items on your bib are holdable by all patrons - On your bib, try to place a hold via the intranet - Confirm Koha allows a hold on the bib or on the Branch A item, but the Branch B item gives the message "libraryNotPickupLocation" As Koha checks whether each hold is allowed, it assumes a pickup branch of whatever's indicated by ReservesControl. So it assumes the Branch A item would be a hold for pickup at Branch A (allowed location) and the hold for the Branch B item would be for pickup at Branch B (un-allowed location). But that assumption is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #27 from Owen Leonard --- Created attachment 120805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120805=edit Bug 28180: (follow-up) Updates to styling of lightbox controls This patch adds style changes like the ones made in Bug 28179. It also addresses a bug with the way the verify_images() function was firing. I've moved the function outside of document.ready() and added a call to it on window load, consistent with how it works in the staff client. I've removed a redundant call to verify_images() from the footer include file, opac-bottom.inc. The cosmetic changes replace the Chocolat image icons with new SVG assets based on Bootstrap Icons (https://icons.getbootstrap.com/). The color changes I think help the controls to be more visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images - detail page, OPAC interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #13 from Victor Grousset/tuxayo --- So would the plan be: fix bug 24434 and retest this one? So, blocked by bug 24434 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added Attachment #120773|0 |1 is obsolete|| --- Comment #16 from Phil Ringnalda --- Created attachment 120804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120804=edit Bug 23406: Don't translate suppressed authorised values We have a test in C4/XSLT/transformMARCXML4HTML which is meant to exclude the 942n, however, it doesn't work because it checks the $subfield parameter against n $subfield is an arrayref with the code and value as members we need to check $subfield->[0] To test: 1 - Apply only unit tests 2 - prove -v t/db_dependent/XSLT.t 3 - It fails 4 - Confirm 952$n in default framework is tied ot authorised value 'YES_NO' or do so 5 - Set OpacSuppression to 'Hide' 6 - Edit a record in the default template, changing 942$n to 'Yes 7 - Confirm the record is suppressed in opac 8 - Note there is no suppression notice in the record in staff client 9 - Apply second patch 10 - Reload and confirm staff side shows suppression notice 11 - Confirm record still suppressed in OPAC 12 - Edit record, set 942$n to 'no' 13 - Confirm there is no suppression notice in staff client 14 - Confirm you can view the record in OPAC 15 - prove -v t/db_dependent/XSLT.t 16 - Tests pass! Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23406] When using an authorised value for suppression, record doesn't show as suppressed in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23406 Phil Ringnalda changed: What|Removed |Added Attachment #120772|0 |1 is obsolete|| --- Comment #15 from Phil Ringnalda --- Created attachment 120803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120803=edit Bug 23406: Unit test Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28177] Add date column and column configuration to uploads
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- This works great I just have one question. Do you think it would be handy to also include the time stamp along with the date? I don't use this tool a lot but it seems like it could be helpful if you were uploading many files on the same day. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28311] Holds always placed at biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28311 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27600 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28311 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28311] New: Holds always placed at biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28311 Bug ID: 28311 Summary: Holds always placed at biblio level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The SIP2 code expects an item barcode as the identifier for placing a hold, but the resulting code in do_hold converts that to a biblio only level hold.. it should be possible to place holds at either bib or item level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28310] request.pl using biblioitemnumber in biblionumber field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310 Blou changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Blou --- As Owen said, duplicate *** This bug has been marked as a duplicate of bug 28057 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com --- Comment #5 from Blou --- *** Bug 28310 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #23 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #21) > To me the table with the prices (basket summary) looks exactly the same with > and without patch...so that's why I am confused. Confusing indeed. When testing I had the new orders having GST calculated with the patch. That was the difference. comment 22: yep, that's what I had. (didn't tested receipt or edit) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28310] request.pl using biblioitemnumber in biblionumber field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310 --- Comment #2 from Owen Leonard --- Is this a duplicate of Bug 28057? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27562] itiva notices break if record title contains quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27562 Owen Leonard changed: What|Removed |Added Attachment #120688|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 120802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120802=edit Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 Tomás Cohen Arazi changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |tomasco...@gmail.com |com | Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #6 from Jonathan Druart --- Still failing: * t/db_dependent/api/v1/checkouts.t because of unseen_renewals but it's defined (?) * t/db_dependent/api/v1/acquisitions_orders.t about "conflict" that we are adding in the response. We do that in other places as well, what would be best to deal with that? And maybe others. I need a bit of help here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 --- Comment #5 from Jonathan Druart --- Created attachment 120801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120801=edit Bug 28272: Fix note_seen, desk_id, cancellation_reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28310] request.pl using biblioitemnumber in biblionumber field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310 Blou changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | CC||caroline.cyr-la-rose@inlibr ||o.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28310] request.pl using biblioitemnumber in biblionumber field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310
--- Comment #1 from Blou ---
Created attachment 120800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120800=edit
Bug 28310: request.pl using biblioitemnumber in biblionumber field
In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted
(previously ItemsAnyAvailableForHold)
is passing the biblioitemnumber as a value to a specified biblionumber.
>> ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber,
>> patron => $patron })
All you need is a Koha instance where the values of biblionumber and
biblioitemnumber are not synchronized for this to break. And break badly.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28164] Sorting on POS register details transactions table is not working right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28164 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Martin Renvoize changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28310] New: request.pl using biblioitemnumber in biblionumber field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310
Bug ID: 28310
Summary: request.pl using biblioitemnumber in biblionumber
field
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted
(previously ItemsAnyAvailableForHold) is passing the biblioitemnumber as a
value to a specified biblionumber.
ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron
=> $patron })
All you need is a Koha instance where the values of biblionumber and
biblioitemnumber being different for this to break. And break badly.
This occurs in 20.05+
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Martin Renvoize changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27621] Remove it-IT installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 Martin Renvoize changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 --- Comment #16 from Martin Renvoize --- `allow_empty_password` is a bit of an odd case.. I can see you're thoughts behind adding it to these calls but then I wonder about that being correct as a generalisation. It looks like it was written with a particular request in mind.. the 'patron_info' one... I find that a little odd actually.. that feels like a call that would more likely want to be behind a password so having to 'allow_empty_password' to get these calls working might open the 'patron_info' request to abuse without meaning to. Happy to discus, but as Kyle has looked into the spec, I've implemented his thoughts here :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Martin Renvoize changed: What|Removed |Added Attachment #120267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 --- Comment #15 from Martin Renvoize --- Created attachment 120799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120799=edit Bug 27600: Remove password check from `add_hold` As suggested in the bugzilla comments, the add_hold method also doesn't require the password checking code. Test plan 1/ Run t/db_dependent/SIP/ILS.t and watch it pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 --- Comment #14 from Martin Renvoize --- Created attachment 120798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120798=edit Bug 27600: Remove password check from `cancel_hold` As suggested in the bugzilla comments, the cancel_hold method also doesn't require the password checking code. Test plan 1/ Run t/db_dependent/SIP/ILS.t and watch it pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 --- Comment #13 from Martin Renvoize --- Created attachment 120797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120797=edit Bug 27600: Remove password check from SIP2 `renew_all` This patch removes the password check code from the renew_all method for SIP2. This is required, as many units send an empty AD field in the SIP message which can cause the transaction to fail.. but the authentication should have already taken place earlier in the session. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27600] SIP2: renew_all shouldn't perform a password check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27600 Martin Renvoize changed: What|Removed |Added Attachment #120266|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 120796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120796=edit Bug 27600: Add unit test This patch adds a basic unit test to catch the case where patron_pwd is sent to renew_all as an empty string. Test plan 1/ Run t/db_dependent/SIP/ILS.t and watch it fail 2/ Apply second patch 3/ Re-run the above test and watch it pass. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #17 from Koha Team University Lyon 3 --- Hi Jonathan :) I don't want to change the name in the yml, I just want to know if we could translate the display in pootle to have it in French. As you can see in the screen shot, it's sometimes difficult to know exactly which column is which.. https://snipboard.io/lZvsrA.jpg Do you think it's possible ? (By the way, I realize that "replacement price" and "recommended retail price" are translated by "prix public" and that is confusing.. I can at least change that !) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #9 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #8) > To everyone looking at this patches: > > (In reply to Jonathan Druart from comment #1) > > 2 things: > > * Should we hide the biblio record if OpacHiddenItemsHidesRecord is set? Yes, definitely. The records should not show up anywhere in the OPAC, if they are hidden by OpacHiddenItemsHidesRecord. > > * allow_onshelf_holds is not working like in other scripts, what's the > > expected behaviour? If hidden should we completely ignore the item? Not sure where the holds come from here :) Is this the use case? * One or more hidden items could fill a hold * Should we be able to place the hold, although all visible items cannot fill a hold. For item level holds this is easy: We don't want to see the items, so no item level holds can be placed. For the record level holds... it's harder. My feeling is that if you don't want your users to see something in the catalog, it's unlikely that you would want to count them towards holds. But maybe in that case the library should just take extra configuration steps to prevent this (like using a not-for-loan status on the items? > ^^ this questions are still valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28292] Searching with colon ":" in the end of query gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #8 from Tomás Cohen Arazi --- To everyone looking at this patches: (In reply to Jonathan Druart from comment #1) > 2 things: > * Should we hide the biblio record if OpacHiddenItemsHidesRecord is set? > * allow_onshelf_holds is not working like in other scripts, what's the > expected behaviour? If hidden should we completely ignore the item? ^^ this questions are still valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #16 from Jonathan Druart --- Hi Sonia, Non you cannot modify "columname" from the yaml, and you should not. It's how we map the settings of the table from the template with the yml, it's more an "ID" than a name. You should open an enhancement request for that, but it's not trivial to implement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |tomasco...@gmail.com |com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
