[Koha-bugs] [Bug 28489] New: CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Bug ID: 28489 Summary: CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: dc...@prosentient.com.au, dpav...@rot13.org, jonathan.druart+k...@gmail.com, julian.maur...@biblibre.com Depends on: 28317 The changes introduced in bug 28317 regarding CGI::Sessions serialization works OK with koha-testing-docker where KOHA_TESTING env and "strict_sql_modes" koha-conf.xml config is set to True. However, according to our documentation strict_sql_modes it should not be used in production environment. If it is disabled then the CGI::Session serialization encoding breaks. To reproduce: 1) Set strict_sql_modes = 1 in koha-conf.xml (depending on your test environment variables you might also just wanna uncomment the relevant code in Koha/Database.pm) 2) Create branch with a display name "Testä" and switch to that branch in intranet. 3) Go to some page in intranet and notice the branch is displayed incorrectly in the menu Alternatively this can cause major trouble if for example a branchcode contains non-ascii letters, e.g. Ä. Then for example on returns.pl we get following error (and I think lots of other things break as well): > Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28317 [Bug 28317] Remove CGI::Session::Serialize::yaml dependency by using the default serializer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28317] Remove CGI::Session::Serialize::yaml dependency by using the default serializer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28317 Joonas Kylmälä changed: What|Removed |Added Blocks||28489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28448] Record with too many items is not shown in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #4 from Bohdan --- This happens both in staff interface and in OPAC. OpacHiddenItems preference is not used in that library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28317] Remove CGI::Session::Serialize::yaml dependency by using the default serializer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28317 --- Comment #43 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #41) > On Koha-testing-docker I get randomly the following error when trying to > select a new branch on intranet (/cgi-bin/koha/circ/set-library.pl): > > CGI::Session::Driver::mysql::store(): DBI Exception: DBD::mysql::db do > failed: Incorrect string value: '\xE4iskap...' for column > `koha_kohadev`.`sessions`.`a_session` at row 1 [for Statement "INSERT INTO > sessions (id, a_session) VALUES(?, ?) ON DUPLICATE KEY UPDATE a_session = > ?"] at /usr/share/perl5/CGI/Session.pm line 251 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > > The branch I try to select has the following name: "Alkuperäiskappaleet, ei > lainata". I made another report now as bug 28489, I think these two are related. This doesn't happen when strict_sql_modes = 0, only with strict_sql_modes = 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #1 from Joonas Kylmälä --- Relating to this is another bug but it only happens with strict_sql_modes = 1, so if we come up with a fix for this we should make sure it handles this case as well. The other issue is: > CGI::Session::Driver::mysql::store(): DBI Exception: DBD::mysql::db do > failed: Incorrect string value: '\xE4iskap...' for column > `koha_kohadev`.`sessions`.`a_session` at row 1 [for Statement "INSERT INTO > sessions (id, a_session) VALUES(?, ?) ON DUPLICATE KEY UPDATE a_session = > ?"] at /usr/share/perl5/CGI/Session.pm line 251 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 This happens when trying to to set on the page /cgi-bin/koha/circ/set-library.pl the active branch another time to what is selected already AND the branch display contains an "ä" character. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #2 from Joonas Kylmälä --- The problem is fixed by enabling the Mariadb/Mysql STRICT_TRANS_TABLES mode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #3 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #2) > The problem is fixed by enabling the Mariadb/Mysql STRICT_TRANS_TABLES mode. Even though this fixes it I'm not convinved it is the right fix. Maybe we our output is not UTF8 to the database: https://metacpan.org/pod/CGI::Session#Influencing-the-encoding-of-the-program's-output Also here more on this: https://stackoverflow.com/questions/31049125/perl-cgisession-mysql-thaw-utf-8-data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #4 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #0) > 1) Set strict_sql_modes = 1 in koha-conf.xml (depending on your test > environment variables you might also just wanna uncomment the relevant code I typoed this, in fact the strict_sql_modes need to be set to 0 to reproduce this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #42 from Katrin Fischer --- (In reply to David Cook from comment #40) > (In reply to Katrin Fischer from comment #38) > > Guess that was me and I like the description of it - not sure I understand > > the problem pointed out by Jonathan. Maybe you can explain a bit more? We > > can add the switch to new installations by default and we can still > > deactivate/activate on demand. It would work like the self reg one now does > > too (point for consistency). > > I think the self-reg is a suboptimal implementation, which is why I've > opened bug 28457. > > We shouldn't require sysadmins to change crontabs in order to get cronjobs > to work using system preferences. > > It defeats the whole point of Bug 24968. Ok, I am not going to insist on the switch any longer. I've also added the topic to the dev meeting agenda a few days ago, because I think we need to reach a decision that will unlock the 2 waiting bugs and more to come for good. But... from our own experience: especially the self reg ones are quite dangerous. If you put a 'wrong' patron category type into the pref, it will delete a big chunk of your users without batting an eye (and they are delete-deleted, not moved). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #17 from Katrin Fischer --- Also made a note about this one on the road map - please add your names so we can sure this makes it into next release together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28448] Record with too many items is not shown in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #5 from Katrin Fischer --- Bohdan, you said you were using Elasticsearch in another thread, is that correct? It does sound like some sort of size limit, but I am not an Elastic expert myself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 Yolanda Marcos changed: What|Removed |Added CC||yolanda.mar...@sibadoc.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28448] Record with too many items is not shown in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 --- Comment #6 from Bohdan --- That is a different library. This one uses Zebra. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28490] New: Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Bug ID: 28490 Summary: Cannot modify patrons in some categories (e.g. Child category) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com, katrin.fisc...@bsz-bw.de, kyle.m.h...@gmail.com, k...@bywatersolutions.com, nug...@gmail.com Depends on: 26995 It is not possible to modify patrons that don't have one of the following category type: A, I, S, X. E.g. create a patron with category code that has category type Child and notice when you try to modify it gives an error, in the logs you can see: > Patron modification failed! - No property relationship for Koha::Patron at > /usr/share/koha/intranet/cgi-bin/members/memberentry.pl Workaround: Set borrowerRelationship syspref empty so the guarantor feature gets disabled. This started happening after bug 26995 was merged because the relationship column was dropped and we have no filtering in place to not try to update that non-existent column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 [Bug 26995] Drop column relationship from borrower tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26995] Drop column relationship from borrower tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Joonas Kylmälä changed: What|Removed |Added Blocks||28490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 [Bug 28490] Cannot modify patrons in some categories (e.g. Child category) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28448] Record with too many items is not shown in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448 Katrin Fischer changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||k...@bywatersolutions.com --- Comment #7 from Katrin Fischer --- In that case I'll add some of our Zebra experts that have probably dealt with big records like that :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #5 from Joonas Kylmälä --- I found another workaround: $datastr = decode_utf8(encode_utf8($datastr)); inside CGI::Session::Driver::mysql::store fixes the problem. The difference seems to be that $datastr is not marked as utf8 string. And after it is (decode_utf8 does it) the string is stored correctly to the DB. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28106] Problem with EAN13 type barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28106 Katrin Fischer changed: What|Removed |Added Component|Searching |Label/patron card printing Assignee|koha-b...@lists.koha-commun |cnighswon...@foundations.ed |ity.org |u Summary|Barcode search not working |Problem with EAN13 type ||barcodes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #6 from Joonas Kylmälä --- Data::Dumper, which the default serializer uses, seems to produce iso-latin-1 strings: https://www.perlmonks.org/?node_id=759457 Our database connection is configured for utf8mb4 so that could be the issue here. I don't know if we can fix this from koha code other than by changing the database connection to iso-latin-1 for the sessions table. Or maybe changing sessions table to iso-latin-1 could make this work automatically? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #7 from Katrin Fischer --- Hm, I think we store some things like a user name in the sessions table, so not sure if changing the table to latin-1 is an option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28491] New: field 003 not updated after import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491
Bug ID: 28491
Summary: field 003 not updated after import
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: MARC Authority data support
Assignee: koha-bugs@lists.koha-community.org
Reporter: d...@plix.at
QA Contact: testo...@bugs.koha-community.org
I import some authority data from e.g. dnb.de, which contains:
11915725X
DE-101
After the import, the local authority data looks like
35
DE-101
So 001 now contains the internal Koha id (good), but 003 still points to DE-101
(i.e. dnb.de), which I think is bad, because if I look up the ID '35' in the
linked DB DE-101, I will now get a bad result.
I assume that 003 should be set to my MARCOrgCode
Looking at the code, I find (in C4::AuthoritiesMarc, AddAuthority, 568ff)
if (!$record->field('003')) {
$record->insert_fields_ordered(
MARC::Field->new('003', $marcorgcode),
);
}
So this behavior seems intentional? If so, I still find it very unlogical and
buggy. I assume that both 001 and 003 should be overwritten with data pointing
to the current Koha instance, and the original 001/003 "archived" in 035 and/or
040
I could easily provide a patch that changes this behavior, but I'm not sure if
this would cause confusion / failing tests / etc.
Maybe add an option to allow a force-overwrite of 003?
Greeting,
Thomas
PS this seems slightly related to #25603
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 mark.jaro...@gmail.com changed: What|Removed |Added Attachment #121324|0 |1 is obsolete|| --- Comment #11 from mark.jaro...@gmail.com --- Created attachment 121513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121513&action=edit AzureAD OAuth2 implementation based on the existing implementation for Google -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 mark.jaro...@gmail.com changed: What|Removed |Added Attachment #121513|0 |1 is obsolete|| --- Comment #12 from mark.jaro...@gmail.com --- Created attachment 121514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121514&action=edit AzureAD OAuth2 implementation based on the existing implementation for Google Corrected links in opac-auth.tt at the suggestion of Sunil Kumar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #8 from Julian Maurice --- The weird thing is that it works correctly with characters like ✓ It seems like the problem is that ä in Latin-1 is the same as the unicode code point (E4) which probably confuses some encoding auto-detection mechanism -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #9 from Joonas Kylmälä --- (In reply to Julian Maurice from comment #8) > The weird thing is that it works correctly with characters like ✓ > It seems like the problem is that ä in Latin-1 is the same as the unicode > code point (E4) which probably confuses some encoding auto-detection > mechanism It only confuses the C code implementation of Data::Dumper, if we enable local $Data::Dumper::Useperl = 1; or just put in the default serializer directly the following line > $d->Useperl( 1 ); it starts working. I just don't know if we can make it a workable solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28424] POST /patrons/:patron_id/account/credits return value wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28424 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #10 from Fridolin Somers --- Does not apply on 20.11.x for t/db_dependent/api/v1/patrons_accounts.t Because of Bug 27587 it seems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28419] Page addorderiso2709.pl is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28419 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.07 released in|| --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28158] Lost items not charging when marked lost from batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28158 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.07 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #30 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28368] Error when printing receipt of point of sale
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Depends on Bug 26734 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28091] Add meta tag with Koha version number to staff interface pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28091 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.07 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin Somers --- Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121072|0 |1 is obsolete|| --- Comment #48 from Victor Grousset/tuxayo --- Created attachment 121515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121515&action=edit Bug 24434: Add 'WrongTransfer' to cancellation_reasons Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #49 from Victor Grousset/tuxayo --- Rebased a patch that had a small conflict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27899] Missing description for libraryNotPickupLocation on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27899 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.07 released in|| Status|Pushed to master|Pushed to stable --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #50 from Victor Grousset/tuxayo --- (In reply to Kyle M Hall from comment #47) > 5) Get the error "The reason parameter is mandatory at > /usr/share/perl5/Exception/Class/Base.pm line 88" I can't reproduce the error. I suspect that's because in 3) I was in the wrong library. Should I be in library B? Or another? Maybe it's about the holding library of the item. Since it has to trigger and transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.07 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28475] Searching all headings returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #15 from Fridolin Somers --- Test plan has a mistake : 1. Open the authorities section in the OPAC => It in is in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28475] Searching all headings returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28475 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.07 released in|| Status|Pushed to master|Pushed to stable --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #33 from Ivan Dziuba --- (In reply to David Nind from comment #32) > Patch no longer applies 8-(... > > Bug 27113 - ElasticSearch: Autocomplete in input search > > 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files > 120140 - Bug 27113: ElasticSearch: Autocomplete in input search > 120806 - Bug 27113: (follow-up) QA Tests > 121498 - Bug 27113: (follow-up) Correction with Session > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css). > error: could not build fake ancestor > Patch failed at 0001 Bug 27113: (follow-up) Move new CSS to main SCSS files I checked it and it works :). Do you use Koha 21.05? Thanks. Bug 27113 - ElasticSearch: Autocomplete in input search 120109 - Bug 27113: (follow-up) Move new CSS to main SCSS files 120140 - Bug 27113: ElasticSearch: Autocomplete in input search 120806 - Bug 27113: (follow-up) QA Tests 121498 - Bug 27113: (follow-up) Correction with Session Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27113: (follow-up) Move new CSS to main SCSS files Using index info to reconstruct a base tree... A koha-tmpl/intranet-tmpl/prog/css/elasticsearch/autocomplete.css M koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc A koha-tmpl/opac-tmpl/bootstrap/css/opac-elasticsearch/opac-autocomplete.css M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Applying: Bug 27113: ElasticSearch: Autocomplete in input search Applying: Bug 27113: (follow-up) QA Tests Applying: Bug 27113: (follow-up) Correction with Session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28482] Floating point math prevents items from being returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- > 16 - Item returned! Still marked as lost, is that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120852|0 |1 is obsolete|| --- Comment #129 from Victor Grousset/tuxayo --- Created attachment 121516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121516&action=edit Bug 22690: Refactor merging of records to improve performance (Elasticsearch) This patch allows merging of records with many items without the web server timing out. Test plan: Without the patch: - Create 2 records (one with e.g. 1000 items). - Do a cataloguing search that displays both records, select them and click "Merge selected". - Choose the record with many items as the one to be eliminated. - Start the merging. - After a while the web server should give you a timeout error (the merging process may still continue) With the patch: - Do the same as above - This time verify that the records are merged without timeout - Create a new biblio with an item - Add with the item: * acquisition order * hold (reserve) - Merge the biblio to another one - Verify that the item and its related data was moved - Verify that tests pass: prove -v t/db_dependent/Koha/Biblio.t prove -v t/db_dependent/Koha/Item.t prove -v t/db_dependent/Koha/SearchEngine/Indexer.t Signed-off-by: Michal Denar Rebased-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120853|0 |1 is obsolete|| --- Comment #130 from Victor Grousset/tuxayo --- Created attachment 121517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121517&action=edit Bug 22690: Add more tests - Tests for adopt_items_from_biblio - Tests for the relationship between items and acquisition orders - Tests for indexer calls in adopt_items_from_biblio Signed-off-by: Michal Denar Rebased-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121389|0 |1
is obsolete||
--- Comment #131 from Victor Grousset/tuxayo ---
Created attachment 121518
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121518&action=edit
Bug 22690: (QA follow-up) Silence manually generated warnings
In our test setup we mock the index_records() to produce warnings like
this:
Koha::Item at t/db_dependent/Koha/SearchEngine/Indexer.t line
93.
By wrapping all our item creations to warnings_are{} we can silence them.
Signed-off-by: Joonas Kylmälä
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121392|0 |1 is obsolete|| --- Comment #132 from Victor Grousset/tuxayo --- Created attachment 121519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121519&action=edit Bug 22690: (QA follow-up) Index also source biblio when calling move_to_biblio() We need to update the search index record for the old biblio where the item was moved from to keep the item info in search index up-to-date. To test: 1) $ prove t/db_dependent/Koha/SearchEngine/Indexer.t Signed-off-by: Joonas Kylmälä Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121474|0 |1 is obsolete|| --- Comment #133 from Victor Grousset/tuxayo --- Created attachment 121520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121520&action=edit Bug 22690: (QA follow-up) Make bib-level hold object actually bib-level We need to pass undef itemnumber to build_object() to actually have a hold without an item tied to it. Otherwise build_object() will create automatically an item for us (thus making it an item-level hold) To test: $ prove t/db_dependent/Koha/Item.t Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #134 from Victor Grousset/tuxayo --- Thanks for the followup, no additional warnings and the test plan still works :) --- QA tools: FAIL C4/Items.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid That looks a false positive, a function was deleted, so it's POD --- (In reply to Joonas Kylmälä from comment #127) > Please give one more look and mark this as PQA & sign-off if all looks good > to you. Code is way over my head so I can't go further than this. But at least the QAer only has the code to review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28492] New: Hyphen in branchcode gives wrong search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28492 Bug ID: 28492 Summary: Hyphen in branchcode gives wrong search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org A client noticed that when limiting by branch, some search results were wrong and after a bit of digging, I found that it happens when the branchcode contains a hyphen. I was able to recreate the situation as follows: 1) Go to Administration > Libraries and add the libraries - Fairfield (branchcode FFL) -- if you have the default database, this library should already exist - Fairfield North (branchcode FFL-N) - Fairfield South (branchcode FFLS) 2) Add an item to record A with holding branch FFL-N 3) Add an item to record B with holding branch FFLS 4) reindex if necessary 5) In Advanced search, search for record A and limit to Fairfield North library -- record is in the results - OK 6) In Advanced search, search for record A and limit to Fairfield library -- record is in the results! - NOT OK 7) In Advanced search, search for record B and limit to Fairfield South library -- record is in the results - OK 8) In Advanced search, search for record B and limit to Fairfield library -- record is not in results - OK As you can see, the search for branchcode FFL-N and for branchcode FFL give the same results. The problem was originally found by a client using 18.05.03. I was able to recreate in 20.05.08 and master (21.06.000), always with Zebra. I didn't try with ES because mine is currently broken :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28492] Hyphen in branchcode gives wrong search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28492 --- Comment #1 from Katrin Fischer --- Hi Caroline, that's a known issue. The search by library and others are keyword searches. hyphens are treated as spaces, so FFL-N is "FFL S" and a search for FFL will find it. Same is true for locations, collections etc. I don't think changing the hyphen behavior in general would be a good idea as we want that for normal search. Using "ext" (exact field search) was problematic in the past - it didn't work for libraries using ICU. Not sure if it does now. Safest option might be to avoid hyphens in the codes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28492] Hyphen in branchcode gives wrong search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28492 --- Comment #2 from Caroline Cyr La Rose --- To add in the manual, no hyphens in branchodes, loc, CCODE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28492] Hyphen in branchcode gives wrong search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28492 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #26 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121521&action=edit Bug 27741: serials folder Bug 27631 corrected the tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #13 from David Cook --- Thanks for posting this, Mark. I have a few comments at a glance. As a contributor, you don't make changes to updatedatabase.pl or $Koha::VERSION directly. The release manager takes care of those. You need to create your database update as per https://wiki.koha-community.org/wiki/Database_updates. I'll put in some comments against opac/svc/auth/azureadopenidconnect using Bugzilla's tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420
--- Comment #14 from David Cook ---
Comment on attachment 121514
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121514
AzureAD OAuth2 implementation based on the existing implementation for Google
Review of attachment 121514:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28420&attachment=121514)
-
Technically, a lot of this code should be put into a module rather than a
script, but I know that you were basing your work on Nicholas's and his made it
into Koha, so I don't think we can require you to put it into a module with
unit tests.
::: opac/svc/auth/azureadopenidconnect
@@ +48,5 @@
> +
> +my $tenantID = C4::Context->preference('AzureADOAuth2TenantID');
> +my $authority= "https://login.microsoftonline.com/${tenantID}/v2.0";;
> +my $discoveryDocURL = "${authority}/.well-known/openid-configuration";
> +warn $discoveryDocURL;
This debugging code needs to be removed.
@@ +253,5 @@
> +my $prompt = $query->param('reauthenticate') // q{};
> +if ( $authendpoint eq q{} ) {
> +loginfailed( $query, 'Unable to discover authorisation endpoint.' );
> +}
> +my $authorisationurl =
This isn't a blocker, but I'd suggest using the URI Perl module for creating
this URL. I find it a lot nicer to work with than trying to concatenate
together a big URL string. https://metacpan.org/pod/URI
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #15 from David Cook --- When you're ready for others to test your code, provide a test plan that they can use for testing it, and change the status to "Needs Signoff". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #16 from David Cook --- Actually, after reviewing the code again, I'm not sure that this has to be Azure-specific. The only thing I notice at a glance that is Azure specific is the $tenantID and $authority variables. I'd like to see this made more generic, so that users can provide their own $discoveryDocURL via a system preference. With the system preference, you could provide a hint like "For AzureAD, use https://login.microsoftonline.com//v2.0/.well-known/openid-configuration". If you make this more generic, I'd be happy to test it against Keycloak. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #43 from David Cook --- (In reply to Katrin Fischer from comment #42) > But... from our own experience: especially the self reg ones are quite > dangerous. If you put a 'wrong' patron category type into the pref, it will > delete a big chunk of your users without batting an eye (and they are > delete-deleted, not moved). I think the "Delete unverified self registrations older than DAYS" should be safe either way? But "Delete expired self registration accounts" does sound dangerous as you describe. Personally, I don't see the merit of having that in cleanup_database.pl at all. Even with a sysadmin adding that flag, you can't control the behaviour of library staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #331 from David Cook --- Comment on attachment 120645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120645 Bug 15516: Allow to reserve first available item from a group of titles Review of attachment 120645: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15516&attachment=120645) - ::: reserve/hold-group.pl @@ +1,1 @@ > +#!/usr/bin/env perl This has the wrong shebang. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #42 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121522&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #332 from David Cook --- I thought that I'd run the QA tools again, as I just noticed that there is a follow-up for the QA tools. My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. qa testing 8 commit(s) (applied to 949f0aa '68 Koha 21.05.00 is here!') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t OK t/db_dependent/Reserves/HoldGroup.t Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #333 from David Cook --- Created attachment 121523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121523&action=edit Bug 15516: Fix shebang in hold-group.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #334 from David Cook --- (In reply to Aleisha Amohia from comment #326) > Ah I remember now - yes, a hold group is supposed to be treated as one hold > because when one item from that group is confirmed to fill the hold, the > rest of the group is deleted. > > I'll fix this up. After reading through the code and further testing and thinking, I don't think that's feasible. It would require much more refactoring to achieve that, and I'm not sure that it's worth it. So I think if we pull out the count_grouped() code, then this could actually pass QA, so long as the intention is to create a group of holds, and that fulfilling one hold will clear the other holds. That works well. The counting of the hold group as 1 hold does not work at all though, so perhaps that concept should be abandoned (for now at least). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--- Comment #335 from David Cook ---
Test plan setup:
0a. Apply the patch
0b. perl ./installer/data/mysql/updatedatabase.pl
0c. perl misc/devel/update_dbix_class_files.pl --koha-conf
/etc/koha/sites/kohadev/koha-conf.xml
0d. restart_all
Test: Create a hold group from a group of items
1. Go to intranet search, display some results, click on the first 2 checkboxes
and click on 'Place hold' button at the top of the results.
(e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test)
2. Search for the "koha" patron (cardnumber 42)
3a. Check the 'Treat as hold group' checkbox
3b. Set pickup location for each item
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
Result: PASS
Test: Hold groups count as 1 hold (maxreserves)
1. Change maxreserves to 2
2. Go to
http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134
3. Note that it says "koha can only place a maximum of 2 total holds"
4. Change maxreserves to 50
Result: FAIL
Test: Hold groups count as 1 hold ("Holds allowed (total)")
1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl
2. Change "Holds allowed (total)" to 2
3. Go to
http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134
4. Note that it says "koha can only place a maximum of 2 total holds"
5. Change "Holds allowed (total)" to unlimited (by entering a blank value)
Result: FAIL
Test: Hold groups count as 1 hold ("Holds allowed (daily)")
1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl
2. Change "Holds allowed (daily)" to 2
3. Go to
http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=134
4. Note it says "No items are available to be placed on hold" and near the
bottom of the screen each item says "Daily hold limit reached for patron"
Result: FAIL
Test: Hold groups count as 1 hold (Patron view)
1. Go to
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51
2. Note that 2 holds are listed, although each hold is listed as "part of a
hold group" (and the links to that hold group are for the same hold group)
Result: FAIL
Test: Hold groups count as 1 hold (Circulation view)
1. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
2. Note that 2 holds are listed, although each hold is listed as "part of a
hold group" (and the links to that hold group are for the same hold group)
Result: FAIL
Test: Hold groups count as 1 hold (OPAC home page view)
1. Go to http://localhost:8080/
2. Note that the screen says "2 holds pending"
Result: FAIL
Test: Hold groups count as 1 hold (OPAC user page view)
1. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds
2. Note that the screen says "2 holds" without any indication of them being
part of the same hold group
Result: FAIL
Test: Hold groups count as 1 hold (OPAC place hold view)
1. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=134
2. Note that the screen says "There are no items that can be placed on hold"
Result: FAIL
Test: Hold groups are disbanded when 1 hold in the group is fulfilled
1. Check in an item of one of the reserved biblios and confirm the hold
(e.g. Check in 301310 )
8. The hold status is changed to Waiting, and all other holds in the hold group
are deleted.
Result: PASS
Note:
The "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #336 from David Cook --- Also, I notice that the text for the release notes say here that this is only for the staff interface, so the change for opac/opac-reserve.pl shouldn't be here at all. Since it's only for the staff interface, the concept of a hold group counting as 1 hold also doesn't make sense, since it would require complicated hold calculations that would vary depending on the interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 15516 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #337 from David Cook --- *** Bug 27300 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
