[Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #27 from Joonas Kylmälä --- The atomicupdate incorrectly appended the relationship column to end of the tables instead of after borrowernotes column like it was originally. Fixed that now. Ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 --- Comment #26 from Joonas Kylmälä --- Created attachment 121656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121656=edit [DO NOT PUSH] Bug 28490: Add DBIx schema changes for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What|Removed |Added Attachment #121601|0 |1 is obsolete|| Attachment #121602|0 |1 is obsolete|| --- Comment #25 from Joonas Kylmälä --- Created attachment 121655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121655=edit Bug 28490: Bring back accidentally deleted relationship columns These were in active use before and were accidentally deleted in Bug 26995. This restores those deleted relationship columns. To test: 1) verify the borrower_modifications, borrowers, deletedborrowers contain the column exactly like it was before after applying these patches by comparing to the old kohastructure.sql version -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28490] Cannot modify patrons in some categories (e.g. Child category)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28490 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #12) > The test plan works ok on current master for me, but I assume this is > because the kohadevbox is using ICU by default. I am not sure how to > activate ICU there. I think you mean using CHR by default. I wonder if we should change to ICU default some time. It involves updating /etc/koha/zebradb/etc/default.idx and then re-indexing Zebra. Although I didn't have that in my test plan I wonder why... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #9 from David Cook --- Hmm interesting. Happy for you to mark this as Failed QA. I'm probably not going to review it any time soon, to be honest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #68 from David Cook --- I don't like the hack of putting CGI::Session::Serialize::yamlxs, but signing off anyway - with the assumption that we'll also push Bug 28519 before doing a stable release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121640|0 |1 is obsolete|| --- Comment #67 from David Cook --- Created attachment 121654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121654=edit Bug 28489: Don't deal with encoding during the serialization Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121639|0 |1 is obsolete|| --- Comment #66 from David Cook --- Created attachment 121653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121653=edit Bug 28489: POD - CGI::Session::Serialize::yamlxs for CGI::Session Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121638|0 |1 is obsolete|| --- Comment #65 from David Cook --- Created attachment 121652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121652=edit Bug 28489: Add selenium tests Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121585|0 |1 is obsolete|| --- Comment #64 from David Cook --- Created attachment 121651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121651=edit Bug 28489: Modify sessions.a_session from longtext to longblob (kohastructure.sql) Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121584|0 |1 is obsolete|| --- Comment #63 from David Cook --- Created attachment 121650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121650=edit Bug 28489: Modify sessions.a_session from longtext to longblob This column contains serialized data, it should be a blob. And it fixes encoding issues. Test plan: 1. Apply patch and run updatedatabase 2. In $KOHA_CONF make sure that you have 0 3. Create 2 libraries: a. TESTÄ/Testä b. TEST✓/Test✓ 4. Go to the staff interface, change your library to Testä, then navigate to a few other pages, make sure there is no encoding problem with the library name in the top right corner 5. Do the same with Test✓ Signed-off-by: Petro Vashchuk Signed-off-by: Andrew Nugged Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #2 from David Cook --- Dev test plan: 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Change "SetEnv PERL5LIB "/kohadevbox/koha" to SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 2b. service apache2 reload 3. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh 4. koha-plack --restart kohadev 5. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl 6. Go to CGI script http://localhost:8081/cgi-bin/koha/tools/export.pl (Note that this is still run in CGI even when using Plack) NOTE: We'll need to update koha-gitify (https://gitlab.com/koha-community/koha-gitify) to get that Apache configuration. There's no harm in updating it, since this is a backwards compatible change. See https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2. -- Deploy test plan: Dev: 1. perl Makefile.PL 1a. Installation mode: dev 1b. Configuration directory: /opt/koha-dev 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha-dev/etc/koha-conf.xml export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 6a. vi /opt/koha-dev/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 7a. vi /opt/koha-dev/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 8a. vi /opt/koha-dev/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/kohadevbox/koha:/kohadevbox/koha/lib" 9a. vi /opt/koha-dev/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/kohadevbox/koha/lib PERL5LIB_DIRS=/kohadevbox/koha:/kohadevbox/koha/lib 6. rm -rf /opt/koha-dev 7. make clean Single: 1. perl Makefile.PL 1a. Installation mode: single 1b. Please specify the directory in which to install Koha: /opt/koha 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha/etc/koha-conf.xml export PERL5LIB=/opt/koha/lib 6a. vi /opt/koha/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/opt/koha/lib" 7a. vi /opt/koha/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/opt/koha/lib 8a. vi /opt/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/opt/koha/lib" 9a. vi /opt/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/opt/koha/lib PERL5LIB_DIRS=/opt/koha/lib 10. ls /opt/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. rm -rf /opt/koha 13. make clean Standard: 1. perl Makefile.PL 1a. accept all the defaults 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note there is a set_koha_ownership failure because of a missing "koha" user, but that's OK since this is an overly intensive process within koha-testing-docker anyway, and the install has already succeeded at this point. 6a. vi /etc/koha/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/usr/share/koha/lib" 7a. vi /etc/koha/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/usr/share/koha/lib 8a. vi /usr/share/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/usr/share/koha/lib" 9a. vi /usr/share/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/usr/share/koha/lib PERL5LIB_DIRS=/usr/share/koha/lib 10. ls /usr/share/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. make clean -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #1 from David Cook --- Created attachment 121649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121649=edit Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Attachment #121648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Blocks||28519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Depends on||28489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] New: Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Bug ID: 28519 Summary: Add a 2nd directory for Perl modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to hack it into C4::Auth. I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib only exists in a deployed Koha. There is no "lib" directory in the source tree. But we can fix that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #62 from David Cook --- I really dislike this whole session mess but... I'll move my follow-up to a separate ticket, as it is blowing out a bit... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #61 from David Cook --- An alternative to my patch would be to create a "PERL_MODULE_LOCAL_DIR" target/dirmap entry/token, and we could use "local_lib" or something like that. Another idea would be to keep PERL_MODULE_DIR as a target/dirmap, but change the token used in etc/misc files to something like "__PERL5LIB_DIRS__". I think that would be more labour intensive though. That said... it looks like "backend_directory" will be broken in etc/koha-conf.xml and misc/bin/sip_run.sh will be broken with my proposed dev install atm... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #60 from David Cook --- Dev test plan: 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Change "SetEnv PERL5LIB "/kohadevbox/koha" to SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 2b. service apache2 reload 3. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh 4. koha-plack --restart kohadev 5. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl 6. Go to CGI script http://localhost:8081/cgi-bin/koha/tools/export.pl (Note that this is still run in CGI even when using Plack) NOTE: We'll need to update koha-gitify (https://gitlab.com/koha-community/koha-gitify) to get that Apache configuration. There's no harm in updating it, since this is a backwards compatible change. See https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2. -- Deploy test plan: Dev: 1. perl Makefile.PL 1a. Installation mode: dev 1b. Configuration directory: /opt/koha-dev 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha-dev/etc/koha-conf.xml export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 6. vi /opt/koha-dev/etc/koha-httpd.conf 7. Note the following: SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 6. rm -rf /opt/koha-dev 7. make clean Single: 1. perl Makefile.PL 1a. Installation mode: single 1b. Please specify the directory in which to install Koha: /opt/koha 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha/etc/koha-conf.xml export PERL5LIB=/opt/koha/lib 6. ls /opt/koha/lib 7. Note the following: C4 CGI cpanfile Koha Koha.pm 8. vi /opt/koha/etc/koha-httpd.conf 9. Note the following: SetEnv PERL5LIB "/opt/koha/lib" 10. rm -rf /opt/koha 11. make clean Standard: 1. perl Makefile.PL 1a. accept all the defaults 2. make 3. ls blib/PERL_MODULE_DIR/ 4. Note the following: C4 CGI cpanfile Koha Koha.pm 5. make install 5b. Note there is a set_koha_ownership failure because of a missing "koha" user, but that's OK since this is an overly intensive process within koha-testing-docker anyway, and the install has already succeeded at this point. 6. ls /usr/share/koha/lib 7. Note the following: C4 CGI cpanfile Koha Koha.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #59 from David Cook --- Created attachment 121648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121648=edit Bug 28489: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #58 from David Cook --- (In reply to David Cook from comment #57) > The database upgrade patch breaks the web installer. Actually, maybe something else is going on. I'll see what's up... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #57 from David Cook --- The database upgrade patch breaks the web installer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50/SRU servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #10 from David Cook --- I've heard back from Adam Dickmeiss at Indexdata, and he said "you should be able to use [the connect syntax] for most client software of YAZ". So that's interesting! I'm tempted to do some testing, and build this functionality into Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 --- Comment #56 from David Cook --- (In reply to Andrew Nugged from comment #51) > We discussed with Jonathan about "where better to place the file" but we > both agreed (JD, you say) so for a moment we can keep the package in C4/Atuh > as additional one for quick-est fix so we can provide working solution for > backporting, > > but the question still open to decide for later (let's create a separate > ticket after we accept this for not to forget, like TODO?): of course it's > better to keep CGI::Session::Serialize::yamlxs in own file/path, > .../CGI/Session/Serialize/yamlxs.pm > but that pollutes Koha lib folder - Jonathan said he keeps in mind to create > something separate, but that for later discussion. Please no. This is how we get into trouble in Koha. We don't need more technical debt. The quickest fix is to revert Bug 28317, and to do this right. But I'll look at putting together a patch so that we can avoid this horror. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #13 from David Nind --- Hi Rudolf. Could you write up a test plan so that I could test? This should be a step by step list of things to do, for example: Test plan: 1. [Steps to replicate the issue] 2. Apply the patch 3. [Steps that indicate the issue is fixed, such as repeating steps in 1 and the result expected] Here is a good example: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408#c3 And also: https://wiki.koha-community.org/wiki/Commit_messages#Test_plan Bearing in mind that those testing (like me) may not be developers or familiar with this area of Koha. David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- Hi David. I had a go at testing. Test plan: 1. yaz-client unix:/var/run/koha/kohadev/authoritysocket 2. Enter these commands (see comment #1): . base authorities . format xml . elements zebra::snippet . find e . show 1 3. Result = diagnostic message: Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo 'zebra::snippet' 4. Apply the patch 5. Stop and restart zebra (no need to rebuild the Zebra index): . koha-zebra --stop kohadev . pkill zebrasrv . koha-zebra --start kohadev 6. Repeat commands in step 2. 7. Result from show 1 = XML output: Sent presentRequest (1+1). Records: 1 Record type: XML http://www.indexdata.com/zebra/;> Gontarski, S. E nextResultSetPosition = 2 Elapsed: 0.013929 I still get the results as per step 3. The only thing I noticed is that the version information is different when you connect - 2.0.59 instead of 4.2.30: root@kohadevbox:koha(bz27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 2.0.59/5.27.1 872b6f92a024bb53bc1c11dfeccd47f065f98238 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.002171 Z> I am using koha-testing-docker. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 David Nind changed: What|Removed |Added Attachment #121641|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 121647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121647=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #61 from Victor Grousset/tuxayo --- > 3/ Compare before patch and after for the Details page. IIUC, I should compare between - same as master: before "Update accountline-details page to show all history" - alt 1 at "Update accountline-details page to show all history" - alt 2 at "Further refinements to account-details table" - alt 3 at "Alternative Three - Account Details" Which are all "data compatible" so I can do step 1/ once and switch between the four code-states to be compared. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #34 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121646=edit Bug 27741: main page Bug 27631 corrected the tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to the main page of the staff client and check the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #33 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121645=edit Bug 27741: about.tt Bug 27631 corrected the tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
