[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

--- Comment #5 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 121896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121896=edit
Bug 28243: authorities folder

Added captions to tables for accessibility purposes, some of these
include class="sr-only" so that they are not visible, but they are still
present for those who use screen-readers.

To test:
1) Apply patch and dependencies
2) Go to Staff Client
3) Go to Authorities
4) Go to each of the pages/files and check if they have tables
5) Check that each of the tables have captions to describe them (unless they
have special heading tags instead) - some of these will be visible on the page
and some will be hidden with "sr-only"

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243

--- Comment #4 from wainuiwitikap...@catalyst.net.nz ---
Created attachment 121895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121895=edit
Bug 28243: admin folder

Added captions to tables for accessibility purposes, some of these
include class="sr-only" so that they are not visible, but they are still
present for those who use screen-readers.

To test:
1) Apply patch and dependencies
2) Go to Staff Client
3) Go to Koha Administration
4) Go to each of the pages/files and check if they have tables
5) Check that each of the tables have captions to describe them (unless
they have special heading tags instead) - some of these will be
visible on the page and some will be hidden with "sr-only"

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

--- Comment #5 from wainuiwitikap...@catalyst.net.nz ---
(In reply to Tomás Cohen Arazi from comment #4)
> I'm not familiar with accessibility guidelines, but understand this changes.
> I would like to know if this is on purpose. In this case, the  tag is
> removed in the resulting caption:
> 
> - Credits
> +   
> 
> +   Credits
> 
> but in some others it is kept:
> 
> -   Results
> 
> + Results
> 
> Maybe there's a reason, but I would like it commented on the commit message,
> unless it needs to be fixed for consistency.
> 
> Great work BTW!

Hi Tomás,

Thank you for your comment!

Yes I understand this is quite confusing.

Basically Koha is set up without a lot of accessibility in mind and there is a
lot of inconsistency. Therefore, I sort of just chose to do things on a case by
case basis and sometimes it is unnecessary to have headings, and sometimes it
makes sense to have both captions and headings.

I will make a point to try and document these decisions more.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

David Nind  changed:

   What|Removed |Added

  Text to go in the||This removes "..Use of
  release notes||uninitialized value in
   ||concatenation (.) or string
   ||at.." warning messages from
   ||the plack-opac-error.log
   ||when accessing the MARC
   ||view page for a record in
   ||the OPAC.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

David Nind  changed:

   What|Removed |Added

 Attachment #121810|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 121894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121894=edit
Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313

Test plan:
You do not even need a NULL value in a authorised value controlled
item field, a zero in damaged or withdrawn is enough to trigger the
warnings. (Because only the 1 is linked to an authvalue.)

Check your plack-opac-error.log before and after applying this change.

Signed-off-by: Marcel de Rooy 
Without the patch I had at least four warnings per item: withdrawn,
lost, damaged and notforloan.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383

David Nind  changed:

   What|Removed |Added

  Text to go in the||When trying to access the
  release notes||item search form in the
   ||staff interface
   ||(/cgi-bin/koha/catalogue/it
   ||emsearch.pl) when not
   ||logged in, an internal
   ||server error (error code
   ||500) is received after
   ||entering your login
   ||details. This fixes the
   ||problem so that the item
   ||search form is displayed as
   ||expected.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383

David Nind  changed:

   What|Removed |Added

 Attachment #121819|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 121893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121893=edit
Bug 28383: Fix itemsearch when accessed from the login form

There are params here (credentials), we need to test for the existence of
$format.

Test plan:
logout
access /cgi-bin/koha/catalogue/itemsearch.pl
Login
=> Without this patch you get a 500 (because we hit the exit statement)
=> With this patch you see the items search form.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28554] In itemsearch sort filters by description

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

David Nind  changed:

   What|Removed |Added

  Text to go in the||For item search in the
  release notes||staff interface the
   ||shelving location and item
   ||type values are now sorted
   ||by the description, rather
   ||than the authorized value
   ||code.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28554] In itemsearch sort filters by description

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

David Nind  changed:

   What|Removed |Added

 Attachment #121821|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 121892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121892=edit
Bug 28554: In itemsearch sort item types filter by description

In itemsearch form, the item types filter should be sorted by description.

Test plan :
1) Create several values and descriptions in item types
2) Go to itemsearch
3) See filter by item types sorts on description and not on value

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28554] In itemsearch sort filters by description

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

David Nind  changed:

   What|Removed |Added

 Attachment #121820|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 121891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121891=edit
Bug 28554: In Koha::AuthorisedValues sort by description

In itemsearch form, there are several filters build with authorized values.
There values should be sorted by description.

Test plan :
1) Create several values and descriptions in authorized values LOC
2) Go to itemsearch
3) See filter by location sorts on description and not on value

Seems change in search_by_marc_field can not be tested in interface

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28554] In itemsearch sort filters by description

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28557] Translation issue in MARC modification templates

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28557

Katrin Fischer  changed:

   What|Removed |Added

Version|20.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28557] New: Translation issue in MARC modification templates

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28557

Bug ID: 28557
   Summary: Translation issue in MARC modification templates
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt:

No MARC modification template is defined. You have to create at
least one template for using this tool.

Because of the link on "to create" the sentence is broken up into 3 separate
strings in the po file:

No MARC modification template is defined. You have
to create
at least one template for using this tools

For de-DE (German):
https://translate.koha-community.org/de/21.05/translate/#search=%20No%20MARC%20modification%20template=source,target=exact,case

https://translate.koha-community.org/de/21.05/translate/#search=to%20create=source,target=exact,case=17330278=20

https://translate.koha-community.org/de/21.05/translate/#search=at%20least%20one%20template%20for=source,target=exact,case

This makes it impossible to translate it well, because it's hard to see how
things to together and because it's not possible to move the linked words to
the end of the sentence as it would be necessary in some languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 121890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121890=edit
Bug 15788: Make the API require the new permission

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 121889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121889=edit
Bug 15788: (QA follow-up) Simplify query in update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 121888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121888=edit
Bug 15788: Use delete_borrowers permission

Link the new delete_borrowers sub-permission to the delete actions.

Test plan
1/ Remove the delete_borrowers permission from a staff user
2/ Check that the user cannot use the 'Delete' option from the members
menu.

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 121887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121887=edit
Bug 15788: Add delete_borrowers permission

Signed-off-by: David Nind 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #118875|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #118874|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #121885|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 121886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121886=edit
Bug 27920: Add ability to update patron expiration dates when importing patrons

Some libraries need to recalculate a patron's expiration date any time they are
updated via a patron import from file.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Patrons/Import.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15788] Split borrowers permission into create/edit and delete

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
I'm not familiar with accessibility guidelines, but understand this changes. I
would like to know if this is on purpose. In this case, the  tag is removed
in the resulting caption:

- Credits
+   

+   Credits

but in some others it is kept:

-   Results

+ Results

Maybe there's a reason, but I would like it commented on the commit message,
unless it needs to be fixed for consistency.

Great work BTW!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #120951|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 121885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121885=edit
Bug 27920: Add ability to update patron expiration dates when importing patrons

Some libraries need to recalculate a patron's expiration date any time they are
updated via a patron import from file.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Koha/Patrons/Import.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883

--- Comment #17 from Kyle M Hall  ---
Created attachment 121884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121884=edit
Bug 27883: (follow-up) Make label match input id

This change alters the list of columns under "Preserve existing values,"
changing the label for each checkbox can be clicked to trigger the
checkbox change.

To test, apply the patch and refresh the patron import page. Expand the
"Preserve existing values" section and click any label in the list. The
corresponding checkbox should be checked.

Signed-off-by: Kyle M Hall 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import

2021-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #119436|0   |1
is obsolete||
 Attachment #119437|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 121883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121883=edit
Bug 27883: Add ability to preserve patron field from being overwritten by
import

Some libraries would like to be able to preserve particular fields for
existing patrons when overwriting them via the patron import tool.
Effectively, this means the specified columns of the CSV are used for
new patrons, but ignored for existing patrons.

Test Plan:
1) Create a patron CSV with one new patron, make the surname and
   firstname "Test1". Add a cardnumber so we can upload it again later.
2) Import the file
3) Change the firstname and surname in the CSV to "Test2"
4) Return to the patron import tool, choose to match on cardnumber,
   overwrite existing patrons, and preserve exiting firstnames
5) Import the file with these settings
6) Referesh the patron details for this patron, the patron's surname
   should still be "Test" while the firstname should now be "Test2"

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/