[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #31 from wainuiwitikap...@catalyst.net.nz --- Created attachment 122021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122021=edit Bug 28243: about.tt Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to About Koha 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #30 from wainuiwitikap...@catalyst.net.nz --- Created attachment 122020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122020=edit Bug 28243: virtualshelves folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to the virtualshelves/shelves page 4) Check that the page has tables 5) Check that the tables have captions to describe them and that they are hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #29 from wainuiwitikap...@catalyst.net.nz --- Created attachment 122019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122019=edit Bug 28243: tools folder Added captions to tables for accessibility purposes, some of these include class="sr-only" so that they are not visible, but they are still present for those who use screen-readers. To test: 1) Apply patch and dependencies 2) Go to Staff Client 3) Go to tools 4) Go to each of the pages/files and check if they have tables 5) Check that each of the tables have captions to describe them (unless they have special heading tags instead) - some of these will be visible on the page and some will be hidden with "sr-only" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #11 from David Cook --- (In reply to Julian Maurice from comment #10) > Just a little suggestion: you can use uniq from List::MoreUtils to make the > code smaller and easier to read I don't see how using uniq would make it smaller or easier to read. I also don't like the idea of adding a non-core dependency to Makefile.PL for such a simple task. Further, I don't like List::MoreUtils. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #121560|0 |1 is obsolete|| --- Comment #38 from wainuiwitikap...@catalyst.net.nz --- Created attachment 122018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122018=edit Bug 27741: circ folder Bug 27631 corrected the tags in each of the pages in the staff client. This bug deals with correcting the hierarchy of each of the other headings. To test: 1) Apply patch and dependencies 2) Go to each of the pages and check the headings under are in the correct order and hierarchy Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Victor Grousset/tuxayo --- It works :) Amended test plan to show the interaction with bug 22435 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] When refunding lost fees we should not include voided payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121317|0 |1 is obsolete|| --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 122017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122017=edit Bug 28421: Unit Tests This patch adds test test cases for both a Voided Payment and Voided Writeoff. These cases need special handling in the refund process. Test plan 0/ Don't apply 1/ Run t/db_dependent/Koha/Items.t 2/ Prior to this commit the test should pass 3/ Apply this commit but not the dependency(bug 22435) 3/ The test should fail 4/ Bug 22435 should make the test pass again. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #154 from David Nind --- Tests fail 8-(.. root@kohadevbox:koha(bz12446)$ prove t/db_dependent/Patrons.t t/db_dependent/Patrons.t .. 1/18 # Looks like you planned 26 tests but ran 20. t/db_dependent/Patrons.t .. 18/18 # Failed test 'Update patron categories' # at t/db_dependent/Patrons.t line 215. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Patrons.t line 207. # Looks like your test exited with 11 just after 18. t/db_dependent/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/18 subtests Test Summary Report --- t/db_dependent/Patrons.t (Wstat: 2816 Tests: 18 Failed: 1) Failed test: 18 Non-zero exit status: 11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #31 from wainuiwitikap...@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Does this need to backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #9 from Katrin Fischer --- In Koha the host items shown on the child records is just a "view" feature, we store the data differently. The item is actually still only attached to one record. For me Z39.50 is more a "data" than a "view" thing, so I think that's where I was coming from. But of course I can see use cases for this too. If I understand correctly, you will have multiple records with completely the same items (including itemnumber, barcode etc.) after the patch. Depending on what you use Z39.50 for, I wonder if this could cause issues in other systems. I feel an urge to make this at least a configuration switch maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #6 from Katrin Fischer --- If we can confirm that there is equal functionality for the XSLT view - I think that would be consequential. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #3 from Barbara Johnson --- I tested in a sandbox. For Acquisitions -> Vendor -> Basket I'm getting a "Template process failed" error. For all other pages I'm not seeing the additional info from the 245$b, 245$h, 245$n or 245$p subfields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #70 from Donna --- This is definitely an ongoing issue - users have no way of telling what was cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #8 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > I feel like this would classify more like an enhancement. The feature as is > exists for many years now and while this is understandable request, I > believe it's not a bug. I feel this is a bug, because the view in the catalog, and the view in Z39 are different, as well as the OPAC showing host item on details page and not the results page, but I can see the view of this as an enhancement. > The linking 773 entry is exported? I don't understand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400
--- Comment #82 from Katrin Fischer ---
(In reply to Agnes Rivers-Moore from comment #81)
> Need a way to turn this off! This patch seems to have been added without any
> way to suppress the display of patron age or date of birth, and it is all
> over Koha. This library does not want people's age displayed every time we
> check out. That is sensitive personal information. Actually we do not
> collect it, so Koha now wastes screen space showing "No date of birth
> stored" in multiple places. Please add a preference to suppress this if
> required by each library. Thank you. ;-)
Hi Agnes, actually this has a way to turn it off. See here:
class='age_years'
So all you need to do is add this line to your IntranetUserCSS:
.age_years { display:none; }
Let me know if that works in all places you need it to and if somewhere is
missing, I am sure we can figure it out.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Text to go in the||This enhancement simplifies release notes||the way new system ||preferences are added to ||Hea for statistical ||reporting. Before this ||enhancement the tests ||(t/db_dependent/UsageStats. ||t) required adjusting every ||time a new system ||preference was added. Now ||when a new system ||preference is added to Hea ||they are automatically ||picked up for the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Andrew Fuerste-Henry changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #5 from Andrew Fuerste-Henry --- *** Bug 27083 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27083] Create ability to record circulation for every item in kits or sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27083 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |DUPLICATE CC||and...@bywatersolutions.com Status|NEW |RESOLVED --- Comment #1 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 24686 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #81 from Agnes Rivers-Moore --- Need a way to turn this off! This patch seems to have been added without any way to suppress the display of patron age or date of birth, and it is all over Koha. This library does not want people's age displayed every time we check out. That is sensitive personal information. Actually we do not collect it, so Koha now wastes screen space showing "No date of birth stored" in multiple places. Please add a preference to suppress this if required by each library. Thank you. ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Andrew Fuerste-Henry changed: What|Removed |Added Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #10 from Andrew Fuerste-Henry --- I get a big angry error when trying to go to the cataloging module with Nick's patch applied: Could not compile /kohadevbox/koha/cataloguing/addbooks.pl: Global symbol "$marc_records" requires explicit package name (did you forget to declare "my $marc_records"?) at /kohadevbox/koha/C4/ImportBatch.pm line 455. Global symbol "$num_matched_control_number" requires explicit package name (did you forget to declare "my $num_matched_control_number"?) at /kohadevbox/koha/C4/ImportBatch.pm line 479. Global symbol "$num_matched_control_number" requires explicit package name (did you forget to declare "my $num_matched_control_number"?) at /kohadevbox/koha/C4/ImportBatch.pm line 516. Compilation failed in require at /kohadevbox/koha/C4/Breeding.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Breeding.pm line 29. Compilation failed in require at /kohadevbox/koha/cataloguing/addbooks.pl line 33. BEGIN failed--compilation aborted at /kohadevbox/koha/cataloguing/addbooks.pl line 33. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 --- Comment #1 from Katrin Fischer --- Spotted in 20.11.06 - haven't confirmed in master yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Nick Clemens changed: What|Removed |Added Attachment #86387|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] New: Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Bug ID: 28567 Summary: Pick-up location is not saved correctly when creating a new library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding a new library the pick-up location will always saves as "Yes", even when no was selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 --- Comment #5 from Tomás Cohen Arazi --- This looks nice, and I'm glad the messages do the job! Can you give us a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28566] New: Rename / Relabel StoreLastBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28566 Bug ID: 28566 Summary: Rename / Relabel StoreLastBorrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We've created a confusing situation with how we label previous borrower data on moredetail.pl. The regular circ history pulled from the issues table is labeled "Last borrower" for the most recent patron to have had and returned the item and "Previous borrower" for the patron before them. This data is wholly unconnected to the StoreLastBorrower system preference. If the StoreLastBorrower system preference is turned on, then moredetail.pl will also include data from the items_last_borrower table. This data is labeled as "Last returned by." It is needlessly confusing that we're using the phrase "last borrower" to refer to two different bits of data. We should *either* rename the syspref *or* switch the labels on moredetail.pl. The former seems like more work to patch but less confusing for users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #54 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #52) > Created attachment 121981 [details] [review] > Bug 27064: Correct transferbook.t tests to reflect new behaviour of > transferbook() Patch pushed to master, thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #46 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28467] Add wording to TrackLastPatronActivity description to tell users that it records SIP authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28467 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28383] Log in via the itemsearch URL leads to Internal Server Error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28383 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #69 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #43 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #66 from Jonathan Druart --- Wasn't this a "have to" for 20.11.01?... Looks like we completely forgot about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize --- This all appears to work as expected, so signing off.. Must admit though.. allot of the knowledge of how this stuff all fits together has now left my brain, so it would be good to get a QA from someone more familiar ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Martin Renvoize changed: What|Removed |Added Attachment #121822|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 122009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122009=edit Bug 8280: Add koha set and item fields to pqf.properties This patch adds a 'koha' set to the pqf properties and maps some basic koha fields to all for searchign To test: 1 - Apply patch 2 - cp etc/z3950/pqf.properties /etc/koha/sites/kohadev/z3950/pqf.properties 3 - sudo koha-z3950-responder --restart kohadev 4 - Test a search: curl -XGET "http://localhost:2100/biblios?version=1.1=searchRetrieve=koha.itemtype=BK=60=marcxml; 5 - Test other fields added: koha.withdrawn koha.lost koha.classification-source koha.materials-specified koha.damaged koha.restricted koha.cn-sort koha.notforloan koha.ccode koha.itemnumber koha.homebranch koha.holdingbranch koha.location koha.barcode koha.onloan koha.itemtype Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What|Removed |Added Depends on||28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28544] Add API's for account transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059 Martin Renvoize changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #65 from Martin Renvoize --- Kyle.. do you think you might have a chance to get back to this.. I'm not sure I will any time soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 --- Comment #5 from Jonathan Druart --- Added missing signed-off-by line from QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 Jonathan Druart changed: What|Removed |Added Attachment #121866|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 122008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122008=edit Bug 28518: Display missing inputs for "Return to the last advanced search" When more than 3 search terms are passed on the advanced search form, the "Return to the last advanced search" feature does not display them. Test plan: Perform an adv search at the OPAC, enter more than 3 terms, launch the search, click the "Return to the last advanced search" link and confirm that all the entries are there. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Jonathan Druart changed: What|Removed |Added Attachment #121804|Bug 24434: (QA follow-up) |Bug 24434: (QA follow-up) description|Remove tab character|Remove tab character ||[squashed] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 Jonathan Druart changed: What|Removed |Added Attachment #121993|Bug 28503: Clarify what |Bug 28503: Clarify what description|ReservesControlBranch |ReservesControlBranch |controls|controls [squashed] --- Comment #14 from Jonathan Druart --- Comment on attachment 121993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121993 Bug 28503: Clarify what ReservesControlBranch controls [squashed] Patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #68 from Jonathan Druart --- (In reply to Kyle M Hall from comment #65) > Created attachment 121804 [details] [review] > Bug 24434: (QA follow-up) Remove tab character > > Signed-off-by: Kyle M Hall Patch will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #45 from Jonathan Druart --- I've decided to restore the sub from the patch (patch amended). It makes sense to have from_library if we have to_library. Even if not used yet we are certainly going to need it soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26978] Add item type criteria to batch extend due date tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26978 --- Comment #2 from Fiona Borthwick --- Adding an item type filter would be hugely beneficial, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26978] Add item type criteria to batch extend due date tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26978 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #44 from Jonathan Druart --- Created attachment 122007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122007=edit Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit This fixes regression caused by "Bug 12362: Cancel transfer with hold cancelation" where cancelled hold's transfer didn't show up in intranet and opac because it create a new transfer that was not yet put in in-transit state. The original idea of bug 12362 was to be able to trigger transfer back home if a hold was cancelled (a regression caused by bug 26078). However, we can do it more simply by setting the $validTransfer variable true in the item check-in code when we are dealing with Reserve transfers. More down in the AddReturn() code there is also a check "and !$resfound" to make sure we only try to trigger the transfer back home automatically if there is no hold waiting at the current location the item arrived in. It should be noted however that now we only display generic message for the automatic transfer reason. Bug 12362 made the return display as the reason "Transfer was cancelled whilst in transit". However, since this fixes the original regressions caused by bug 26078 and restores similar behaviour to that I think giving a more descriptive message for example regarding a hold being cancelled can be considered a further enhancement. To test: 1) Apply patch 1) Have biblio with item in branch A 2) Create a new hold with a pickup library to branch B 3) Check-in the item at branch A and confirm the hold and transfer 4) Cancel the hold 5) Check-in the hold at branch B and notice it prompt to return it to branch A Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #43 from Jonathan Druart --- Created attachment 122006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122006=edit Bug 28520: Bring back TransferCancellation reason handling from reverted Bug 12362 The code from Bug 12362 was reverted but there might be still in database transfers with the reason 'TransferCancellation' so we need to restore the code to handle displaying that information. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What|Removed |Added Attachment #121953|0 |1 is obsolete|| Attachment #121954|0 |1 is obsolete|| Attachment #121955|0 |1 is obsolete|| Attachment #121985|0 |1 is obsolete|| --- Comment #42 from Jonathan Druart --- Created attachment 122005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122005=edit Bug 28520: Revert "Bug 12362: Reverse transfer upon cancellation" This reverts commit d0407686eb070c5bdf0302147a198027abea5ac0. This commit was part of a series adding adding reverse transfers, i.e. transfers that were created for transfers that were cancelled and we wanted the item to return back to its sending library. This however hid the information about transfer happening and we need another approach to the problem. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #4) > I think a goal is to remove the non-XSLT display this release - so I think > better to work towards that. So then we simply remove this preference? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27879] Koha::Hold::is_at_destination function should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27879 --- Comment #5 from Martin Renvoize --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|k...@bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 --- Comment #4 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Martin Renvoize changed: What|Removed |Added Attachment #118548|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 122004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122004=edit Bug 26704: Update Koha::Item to use Koha::Object::Messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #9 from Nick Clemens --- Attempted to rebase and remove dependencies, untested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 --- Comment #8 from Nick Clemens --- Created attachment 122003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122003=edit Bug 19266: Allow 001 checking on save to batch and 005 update on import of records To test: 1 - Export a set of records with control numbers from your system 2 - Stage those records 3 - Note during staging a new option to update the 005 4 - Check records after staging 5 - Note 005 is updated or not as the option is selected 6 - Open the advanced cataloging editor 7 - Under settings choose Import Batches 8 - Set the batch you just imported as a save target 9 - Select that batch only as save target 10 - Create a new record, give it the control number of a record in the batch 11 - Attempt to save to the batch 12 - You get an error 13 - Save overriding warnings 14 - The record is then added to the batch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121735|0 |1 is obsolete|| --- Comment #54 from Andrew Isherwood --- Created attachment 122002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122002=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121734|0 |1 is obsolete|| --- Comment #53 from Andrew Isherwood --- Created attachment 122001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122001=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121733|0 |1 is obsolete|| --- Comment #52 from Andrew Isherwood --- Created attachment 122000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122000=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121732|0 |1 is obsolete|| --- Comment #51 from Andrew Isherwood --- Created attachment 121999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121999=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121731|0 |1 is obsolete|| --- Comment #50 from Andrew Isherwood --- Created attachment 121998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121998=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121730|0 |1 is obsolete|| --- Comment #49 from Andrew Isherwood --- Created attachment 121997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121997=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121729|0 |1 is obsolete|| --- Comment #48 from Andrew Isherwood --- Created attachment 121996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121996=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #121728|0 |1 is obsolete|| --- Comment #47 from Andrew Isherwood --- Created attachment 121995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121995=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Tomas, this is missing your signed-off-by patches! Oops :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 121994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121994=edit Bug 28503: (follow-up) Get rid of tests warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 121993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121993=edit Bug 28503: Clarify what ReservesControlBranch controls Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 121992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121992=edit Bug 28503: Compare item homebranch to patron branch when hold policy set to 'from_home_library' This fixes an issue in the way we calculate the check for hold policy 'from_home_library' Currently we change the comparison based on ReservesControlBranch, however, that should only control the rule we fetch, not how we compare When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to the patron's branch, this is useless and means we pass the check for all branches all of the time We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch To test: 1 - Have a record with an item from library A and library B 2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries and ensure you have no branch specific/itemtype specific rules set 3 - Attempt to place a hold on the record for a patron from library B 4 - Note that only the library B item is holdable - place a title level hold (do not choose an item) 5 - Check in the item from library A 6 - It fills the hold - This is incorrect - ignore the hold 7 - Apply patch 8 - Restart all the things 9 - Check in the item from library A 10 - No hold found 11 - Check in the item from library B 12 - Hold found, correctly Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 121991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121991=edit Bug 28503: Unit tests Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121988|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 121990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121990=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #4 from Katrin Fischer --- I think a goal is to remove the non-XSLT display this release - so I think better to work towards that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121988|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121989|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121988|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 121989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121989=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27734] OpacHiddenItems produces a 404 from borrower holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 Nick Clemens changed: What|Removed |Added Attachment #121797|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 121988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121988=edit Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- +1 on this. This would be a handy feature. I prefer Daniel's idea of a number stored in the item record so that it's easy to deal with the fact that items are likely to all have different numbers of items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Joonas Kylmälä changed: What|Removed |Added QA Contact|joonas.kylm...@helsinki.fi |testo...@bugs.koha-communit ||y.org --- Comment #21 from Joonas Kylmälä --- Unsetting myself from QA contact, I don't think I am able to find time reviewing this any time soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Attachment #121939|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 121987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121987=edit Bug 28565: Simplify tests This patch makes the tests for UsageStats. This way the tests don't need to be adjusted everytime a syspref is added. To test: 1. Apply the first patch 2. Add some random syspref to C4::UsageStats 3. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => FAIL: Things explode 4. Apply this patch 5. Repeat 3 => SUCCESS: It doesn't explode anymore! 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Attachment #121938|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 121986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121986=edit Bug 28565: Move the sysprefs to a reusable sub This patch moves the big sysprefs list to a sub. Behavior shouldn't change. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Things work as expected, no changes. 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Status|NEW |Needs Signoff CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@helsinki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
