[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Blocks||28532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 [Bug 28532] Accessibility: Staff Client - add legends to forms -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28532] Accessibility: Staff Client - add legends to forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28532 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Depends on||28243 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 [Bug 28243] Accessibility: Staff Client - add captions to tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #33 from wainuiwitikap...@catalyst.net.nz --- Not backported to 19.11.x Please see Victor's comment above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 --- Comment #10 from wainuiwitikap...@catalyst.net.nz --- Backported to 19.11.x for 19.11.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28364] koha-z3950-responder breaks because of log4perl.conf permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28364 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|21.05.00,20.11.07,20.05.13 |21.05.00,20.11.07,20.05.13, released in||19.11.19 Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #11 from David Cook --- Of course, some characters also have special significance in the CCL query language as well, so even getting them to Zebra would be part of the first step. Not a simple problem by any stretch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729
--- Comment #10 from David Cook ---
Oh I've had some fun playing with ICU...
chain.xml:
echo -n '.NET. test' | yaz-icu -c chain.xml
1 1 '.net'' '.NET''
2 1 'test' 'test'
--
Here we tokenize based on the line break (ie space), and then we perform our
transliteerate and transform rules as per
http://userguide.icu-project.org/transforms/general.
With the transliterate, we can use the following syntax:
"before_context { text_to_replace } after_context > completed_result |
result_to_revisit ;"
So here the "text_to_replace" is the [:Punctuation:] and the "after_context" is
[:WhiteSpace:], and the completed result is transliterating the punctuation
into nothing.
So we trim the "." from the end of NET but we don't trim the "." from the
start.
Of course, that doesn't really work in practice, because it misses sooo many
other scenarios:
echo -n 'Was that a good idea?' | yaz-icu -c chain.xml
1 1 'was' 'Was'
2 1 'that' 'that'
3 1 'a' 'a'
4 1 'good' 'good'
5 1 'idea?' 'idea?'
I'm not really sure how to solve this problem in an efficient way. We could
just map "C#", "C++", and ".NET" to "csharp", "cplusplus', and 'dotnet', but
that's not a very scalable or comprehensive solution for all Koha users.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #3) > Would be interesting to test with Elasticsearch. I agree. It looks like a bit of a known issue: https://stackoverflow.com/questions/63477160/elastic-analyzer-to-enable-matching-searches-such-as-c-c-a https://discuss.elastic.co/t/searching-and-indexing-of-c-c-net-asp-net-doesnt-work/4070/3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #8 from David Cook --- (In reply to David Cook from comment #5) > With words in ICU, it > looks like we might only be removing punctuation that is preceded by > whitespace (which seems to imitate the example chain.xml from > https://software.indexdata.com/yaz/doc/yaz.pdf). Ooops. I misread that. Actually, it just strips both whitespace and punctuation regardless of position. Yeah, I don't think this will work with Zebra, since both the word and phrase index registers are supposed to be normalized. I am curious how Google does it. Historically, Google used to normalize its queries and strip out symbols, but the past few years it seems to be more intelligent (it will even convert "+" into "plus" so there is some good AI at work there I reckon). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #7 from David Cook --- After some experimenting, it seems YAZ ICU will tokenize based on the "+" without any normalization when using the "line" tokenize rule: echo -n "C++" | yaz-icu -c chain.xml 1 1 'c+' 'C+' 2 1 '+' '+' echo -n "C#" | yaz-icu -c chain.xml 1 1 'c#' 'C#' echo -n ".NET" | yaz-icu -c chain.xml 1 1 '.net' '.NET' I wonder if that's a bug in YAZ because it doesn't do that for all punctuation/symbols... echo -n 'C--' | yaz-icu -c chain.xml 1 1 'c--' 'C--' echo -n 'C???' | yaz-icu -c chain.xml 1 1 'c???' 'C???' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #16 from Victor Grousset/tuxayo --- Thanks for the explanations :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #6 from David Cook --- Hmm nope... echo "C++" | yaz-icu -c words-icu.xml 1 1 'c+' 'C+' 2 1 '+' '+' echo "C#" | yaz-icu -c words-icu.xml 1 1 'c' 'C' echo ".NET" | yaz-icu -c words-icu.xml 1 1 'net' 'NET' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Marjorie Barry-Vila from comment #4) > Still valid with Zebra and ElasticSearch in 20.05 > > Marjorie It would be interesting to know if it's CHR or ICU indexing for Zebra. These symbols get stripped out in the normalization process. With phrases in ICU, I see we're arbitrarily removing all punctuation. With words in ICU, it looks like we might only be removing punctuation that is preceded by whitespace (which seems to imitate the example chain.xml from https://software.indexdata.com/yaz/doc/yaz.pdf). So that might be OK. In fact I should be able to test that... With CHR indexing, symbols get converted into spaces, so it won't work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #15 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #14) > (In reply to David Cook from comment #9) > > (In reply to Jonathan Druart from comment #6) > > > The main question to me is: is it safe enough for backport into 21.05.01? > > > > I would say yes especially for Debian package installations. > > > > Dev environments are the ones that will experience the most changes, but we > > can deal with any pain there. > > > > Once this change is in place, Koha will be much more powerful. > > There are more than 200 production instances based on git, which changes > will they experience? It depends on how they do their deployments. If they use symlinks for things like their Apache configuration, then it should be automagical after a "make upgrade". But if they don't, then they'll need to manually update their Apache configuration. (Changes to koha-worker.service and koha-index-daemon-ctl.sh would matter less in the short-term but they would need updates too.) People not using Debian packages are always going to be vulnerable to Apache configuration changes though. I'll note that my PR for koha-gitify needs to be merged in too for users of koha-gitify (like koha-testing-docker): https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #9) > (In reply to Jonathan Druart from comment #6) > > The main question to me is: is it safe enough for backport into 21.05.01? > > I would say yes especially for Debian package installations. > > Dev environments are the ones that will experience the most changes, but we > can deal with any pain there. > > Once this change is in place, Koha will be much more powerful. There are more than 200 production instances based on git, which changes will they experience? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #32 from Victor Grousset/tuxayo --- It doesn't change how Koha works. It fixes the tests on Debian 11 but for 19.11.x, the CI doesn't use Debian 11 so it won't do anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #164 from Victor Grousset/tuxayo --- IIUC, this needs a rebase and the continuation of comparing the two alternatives. No other blocker than playing with both and getting feedback right? (which is already quite some work ^^) There isn't yet one that has been chosen right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Katrin Fischer changed: What|Removed |Added Text to go in the|This enhancement lets you |This enhancement lets you release notes|include text that patrons |include text that patrons |need to accept before they |need to accept before they |can place an article|can place an article |request (similar to the |request (similar to the |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance |system preference). |system preference). | | |Add |Add |the text required to the|the text required to the |new system preference |new |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe |xt. If there is no text in |xt entry in the news tool. |the system preference, then | |no message is displayed.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Attachment #121505|0 |1 is obsolete|| Attachment #121506|0 |1 is obsolete|| Attachment #121507|0 |1 is obsolete|| --- Comment #8 from Agustín Moyano --- Created attachment 122053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122053=edit Bug 27948: Add disclaimer to article request If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear before an article request can be made To test: 1. apply patches 2. enable ArticleRequest syspref 3. in OPAC place an article request for a patron CHECK => No disclaimer text should appear before placing article request 4. add a text in ArticleRequestsDisclaimerText news 5. repeat step 3 SUCCESS => A disclaimer text is shown before you can place an article request Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #4 from Marjorie Barry-Vila --- Still valid with Zebra and ElasticSearch in 20.05 Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #11) > Solved minor conflict on the test patch. > > However tests pass even with the patch «Make buildKohaItemsNamespace accept > Koha::Items» > reverted and even with the other one reverted. > > So that means they don't test the change. Sorry for that. The tests only tested the trivial case in which all items for the biblio are passed in the resultset. I now added one more item, that is excluded from the resultset, to better highlight the interaction between both params. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 122052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122052=edit Bug 28299: Make buildKohaItemsNamespace accept Koha::Items This patch makes buildKohaItemsNamespace (and its only caller, XSLTParse4Display) accept a an optional Koha::Items resultset. This way we don't need to calculate (from the DB) the list of hidden itemnumbers, but solve it in one query. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 122051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122051=edit Bug 28299: Take OpacHiddenItems into account on opac-shelves hidden_items was not passed to XSLTParse4Display 2 things: * Should we hide the biblio record if OpacHiddenItemsHidesRecord is set? * allow_onshelf_holds is not working like in other scripts, what's the expected behaviour? If hidden should we completely ignore the item? Test plan: 1. Without the patch 2. fill OpacHiddenItems with «damaged: [1]» 3. find a record with several item 4. mark one of them as damaged 5. OPAC: go to the record, you shouldn't see the damaged item 6. add the record to a list 7. see the list 8. in Availability you see the damaged item mentioned, this is the issue 9. apply the patches and restart the services 10. the list should not mention the damaged item :D Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 122050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122050=edit Bug 28299: Unit tests for buildKohaItemsNamespace Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121023|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121022|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What|Removed |Added Attachment #121021|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28299] OpacHiddenItems not working on opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28577] New: Add column for copynumber on overdue report (overdue.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28577 Bug ID: 28577 Summary: Add column for copynumber on overdue report (overdue.pl) Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@collecto.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi, It would be fine to see field copynumber from items on overdue circulation report (/cgi-bin/koha/circ/overdue.pl) and in columns_settings on circ-overdues Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #87 from Agnes Rivers-Moore --- There are two or three fields we need to suppress. One is the date of birth, one is the age in years, and the third is the message that displays if there is nothing to display. Born: 03/29/1951 (70 years) or No date of birth stored. We tried the CSS that Katrin suggested, and it does not cover all those cases. It would need to hide DOB and Age. Also as we do not collect DOB, we need to hide whatever generates the message if DOB is empty. That would likely be useful for libraries that collect DOB only for children, not adults. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #86 from Agnes Rivers-Moore --- (In reply to Jonathan Druart from comment #83) > I also expressed a couple of times that I didn't like the feature. Maybe we > should turn it off by default? Thank you Jonathan! I don't know any reason public libraries would want to see this in day-to-day operations. Some use age to set child or adult patron type, and sending a birthday message might be cute (I find it creepy). None of that is reason to see it daily, but libraries in another country might. (I have worked libraries in England, South Africa and Canada.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|alex.arn...@biblibre.com|n...@bywatersolutions.com Status|Failed QA |ASSIGNED --- Comment #9 from Nick Clemens --- Stealing this one unless Alex or Julian object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What|Removed |Added Attachment #35885|0 |1 is obsolete|| Attachment #40069|0 |1 is obsolete|| Attachment #121920|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 122049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122049=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. Script is in misc/maintenance/ It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query using the 'search_form' for the heading 2.2) run the query, retrieve the results 2.3) among duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) delete the merged authorities Use --help for more informations on options To be done: 1 - Move to module and cover with tests 2 - Add option to only merge unused authorities 3 - Expand 'ppn' option to be 'control-number' option and allow specifying field 4 - More? 1 & 2 I will attempt - 3 & 4 may be future enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Salman Ali changed: What|Removed |Added Status|NEW |Needs Signoff CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 --- Comment #1 from Salman Ali --- Created attachment 122048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122048=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] New: Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Bug ID: 28576 Summary: Add patron image in patron detail section does not specify image size limit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: salman@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27879] Koha::Hold::is_at_destination function should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27879 --- Comment #6 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #5) > Is this ready for testing? Hmm, seems like the patch "Bug 27879: Don't allow set holds to be waiting if not at pickup location" misses unit tests, so those need to be added. I won't be able to spend any time on it now so feel free to add yourself as Co-author in the patches if you will work on this. But besides missing the tests it seems like the patches are OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Fridolin Somers --- Mmm does not work : $ ./src/installer/data/mysql/updatedatabase.pl Use of uninitialized value $start_time in integer subtraction (-) at ./src/installer/data/mysql/updatedatabase.pl line 24474. Upgrade to 20.12.00.045 done [17:22:25 (451071h:22m:25s)]: Bug 21249 - Adding new system preference SearchLimitLibrary Upgrade to 20.12.00.046 done [17:22:25 (00h:00m:00s)]: Bug 14723 - Additional delivery notes to messages Upgrade to 20.12.00.047 done [17:22:25 (00h:00m:00s)]: Bug 23215 - Remove core PayPal support in favor of the use of plugins Upgrade to 20.12.00.048 done [17:22:25 (00h:00m:00s)]: Bug 26995 - [SKIP] Drop column relationship from borrower tables [not executed] Upgrade to 20.12.00.049 done [17:22:25 (00h:00m:00s)]: Bug 28108 - Move action logs 'SERIAL CLAIM' and 'ACQUISITION CLAIM' to a new 'CLAIMS' module Upgrade to 20.12.00.050 done [17:22:25 (00h:00m:00s)]: Bug 28108 - Add new systempreference OpacHiddenItemsHidesRecord -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28575 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20815 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 --- Comment #4 from Fridolin Somers --- (In reply to Jonathan Druart from comment #2) > Please remember: > - The title of the bug report describes shortly what the *problem is* > - The title of the patch describes shortly what the *patch does* > > https://wiki.koha-community.org/wiki/Commit_messages Arf indeed, i'll try to do better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28575] New: Add ability to choose if lost fee is refunded based on when lost fee was paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575 Bug ID: 28575 Summary: Add ability to choose if lost fee is refunded based on when lost fee was paid off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In bug 20815 we added the NoRefundOnLostReturnedItemsAge system preference to block lost item refunds if the item was lost more than X daya ago. Many libraries would like a comparable system to block refund if the lost item fee has been paid in full more than X days ago. Further, even more libraries have asked for the ability to simply not refund paid lost items at all (they only want to refund/forgive lost fees that are not yet paid). Enabling this new syspref to block refunds on lost items paid off more than 0 days ago would support this behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28574] New: Double id in source code member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28574 Bug ID: 28574 Summary: Double id in source code member.pl Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: pierre.ge...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hi all, The member.pl page (results from patrons search) has two div with the same id : searchheader (checked on 19.11 and 20.11). Is this a problem ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk Keywords||accessibility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Agustín Moyano changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #715 from Nick Clemens --- Notices and DB update conflicts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28573] New: Replace authority record with Z39.50/SRU creates new authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Bug ID: 28573 Summary: Replace authority record with Z39.50/SRU creates new authority record Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: sebastian.kr...@tuz-eisenach.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When replacing an authority record with Z39.50/SRU you get a new record and no update of the upgrading record. Test instance: Catalyst IT Ltd. (New Zealand) (https://koha-community.org/demo/) example record: #13 (name: Plato) Steps to reproduce: 1. Menu "Home > Authorities > Details for authority #13 (Personal Name)" 2. Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 3. Menu "Edit > Replace record via Z39.50/SRU" 4. Field "Name(any)": Homer >> Click "search" 5. choose the second entry "Aschmann, Homer, 1920-" >> click "import" Expected solution: - replace the record #13 with the search data "Aschmann, Homer, 1920-" - Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 Error: - Menu "Home > Authorities > Adding authority Personal Name" - form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/authorities.pl?breedingid=58824=PERSO_NAME= - Save the record as Record #14 - Menu "Home > Authorities > Details for authority #14 (Personal Name)" Note: I found this error in release 21.05., I use a instance 20.11. to reproduce the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 122047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122047=edit Proposed wording I've attached a screenshot of the resolution interface. The item in question is currently set to the lost status cr. When resolving the claim, I'd like to see it default to maintaining the existing value. Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116152|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Jonathan Druart changed: What|Removed |Added CC||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28572] New: Replace C4::Debug with Koha::Logger->debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Bug ID: 28572 Summary: Replace C4::Debug with Koha::Logger->debug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Should not we replace C4::Debug (and all "$debug && warn" statements) with Koha::Logger->debug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #55 from Andrew Isherwood --- Created attachment 122045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122045=edit Bug 24190: (Follow-up) Rename AcqLog As requested in comment #49, renamed uses of AcqLog to AcquisitionLog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116153|0 |1 is obsolete|| --- Comment #54 from Andrew Isherwood --- Created attachment 122044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122044=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116151|0 |1 is obsolete|| --- Comment #53 from Andrew Isherwood --- Created attachment 122043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122043=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have now added additional tests for the methods in C4/Budgets.pm that do logging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116150|0 |1 is obsolete|| --- Comment #52 from Andrew Isherwood --- Created attachment 122042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122042=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response to Jonathan's feedback in comment - Moved from using zero padded strings to store log data to a JSON object - Stopped storing formatted dates in logged data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116149|0 |1 is obsolete|| --- Comment #51 from Andrew Isherwood --- Created attachment 122041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122041=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the associated bib / items are unable to be removed, we go into error handling. We still need to log the cancellation though. So this fix moves the logging to just after the cancellation, so it will be logged regardless of the outcome with associated things. Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What|Removed |Added Attachment #116148|0 |1 is obsolete|| --- Comment #50 from Andrew Isherwood --- Created attachment 122040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122040=edit Bug 24190: Add acquisition logging Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 --- Comment #1 from Jonathan Druart --- Created attachment 122039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122039=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] New: C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Bug ID: 28571 Summary: C4::Auth::_session_log is not used and must be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org it's logging in a /tmp file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 --- Comment #1 from Jonathan Druart --- Created attachment 122038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122038=edit Bug 28570: Remove log to /tmp file from bor_issues_top.pl This is unusual and must not be done. Removing it. Test plan: Use the "Home > Reports > Patrons with the most checkouts" report and confirm that it is working correctly after you applied this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28570] bor_issues_top.pl using a /tmp file to log debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28570] New: bor_issues_top.pl using a /tmp file to log debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28570 Bug ID: 28570 Summary: bor_issues_top.pl using a /tmp file to log debug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org $debug and open my $debugfh, '>', '/tmp/bor_issues_top.debug.log'; This must be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28271] Add the ability to set a new lost status when a claim is resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #7 from Jonathan Druart --- Andrew, are you happy with this patchset? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 --- Comment #1 from Jonathan Druart --- Created attachment 122037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122037=edit Bug 28523: Escape 'rank' in bor_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Patrons with the most checkouts Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL s erver version for the right syntax to use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues` With this patch applied you see the report result view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 --- Comment #1 from Jonathan Druart --- Created attachment 122036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122036=edit Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added Text to go in the|This bug fixes the "On |This bug fixes the "On release notes|shelf holds allowed" rules |shelf holds allowed" rules |so that they work correctly |so that they work correctly |when using ILS-DI to place |when using ILS-DI to place |holds. |holds. | | |The expected|The expected |behaviour for "On shelf |behaviour for "On shelf |holds allowed" settings for |holds allowed" settings for |the circulation rules (Koha |the circulation rules (Koha |administration > Patrons|administration > Patrons |and circulation > |and circulation > |Circulation and fines |Circulation and fines |rules) are: |rules) are: |- If set to |- If set to |"Yes", patrons can place|"Yes", patrons can place |holds on items currently|holds on items currently |checked in. |checked in. |- If set to "If |- If set to "If |any unavailable", patrons |any unavailable", patrons |can only place holds on |can only place holds on |items that are not |items that are not |unavailable. |unavailable. |- If set to |- If set to |"If all unavailable", |"If all unavailable", |patrons can only place |patrons can only place |holds on items where *all* |holds on items where *all* |items on the record are |items on the record are |unavailable.|unavailable. || ||RMNOTE: ||Reverted! Status|Pushed to master|ASSIGNED Version(s)|21.11.00| released in|| --- Comment #46 from Jonathan Druart --- Patches reverted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #11 from Nick Clemens --- (In reply to Katrin Fischer from comment #9) > In Koha the host items shown on the child records is just a "view" feature, > we store the data differently. The item is actually still only attached to > one record. For me Z39.50 is more a "data" than a "view" thing, so I think > that's where I was coming from. > > But of course I can see use cases for this too. > > If I understand correctly, you will have multiple records with completely > the same items (including itemnumber, barcode etc.) after the patch. > Depending on what you use Z39.50 for, I wonder if this could cause issues in > other systems. > > I feel an urge to make this at least a configuration switch maybe? I added a syspref EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #10 from Nick Clemens --- Created attachment 122035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122035=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20718 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26346 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Bug 26346 has an alternate approach for this, adding a new option of "staff only" for editing so a public list can be set to be editable by just the owner, just staff, or everyone. I prefer that more granular control. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #121512|0 |1 is obsolete|| --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 122034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122034=edit Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch 'owner only' public lists (which they're not the owners of) to 'staff only' lists The first patch on bug 26346 only allowed owners of existing 'owner only' public lists switch those lists to be 'Staff only'. This patch will allow other patrons with the 'edit_public_lists' sub-permission to also make this change. Test plan: 1. Apply the first 26346 patch and follow it's test plan 2. Apply this patch 3. Apply database changes: cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 4. Restart memcached and plack 5. Login to the staff client. Create an 'owner only' public list 6. Create another patron record. Tick the following two permissions: * "Staff access, allows viewing of catalogue in staff interface (catalogue) Required for staff login." permission * Lists > "Edit public lists (edit_public_lists)" sub-permission 7. Logout of the staff client, and login as the user from step #6 8. Navigate to the Lists module, click 'Edit' on the 'owner only' list 9. Confirm you can change the 'Allow changes to contents from:' option to 'Staff only' 10. Confirm you can now add items to this 'staff only' list 11. Login to the OPAC as the patron from step #5 12. Create a 'owner only' public list 13. Logout of OPAC, and login as the patron from step #6 14. Navigate to public lists in the OPAC and edit the OPAC created 'owner only' public list from step # 15. Confirm you can change the 'Allow changes to contents from:" option to 'Staff only' 16. Confirm you can now add items to this 'staff only' list 17. Run Virtualshelves.t unit test: sudo koha-shell prove t/db_dependent/Virtualshelves.t Sponsored-by: Catalyst IT Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #120954|0 |1 is obsolete|| --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 122033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122033=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply patch and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 5. Log out of the staff client and log back in as a different user with the 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. 6. Navigate to the Lists module, and click on the name of the list you created in #5 7. Select 'Add items' and enter an item barcode and submit 8. Notice the item has been added to the list 9. Search the catalogue in the staff client. Confirm you can add to the list you created in #5 from both the search result page and biblio record detail page 10. Confirm you can remove items from the list in the OPAC and staff client 11. Login to the OPAC as the same user as #5 12. Perform an OPAC search, Select 'Save to lists' under a biblio record, choose the list from #4 in 'Select a list' and save 13. Confirm in the staff client that the record from #11 has been added to the list 14. Logout of OPAC and login again as a user which does not have 'Staff access, allows viewing of catalogue in staff interface (catalogue)' or superlibrarian enabled 15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the record to the list from #4 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t 17. Login to the staff client as the same user as #5 18. Create a new list in the staff client, select 'Category'='Private', 'Allow changes to contents from'='Staff only' 19. Notice 'The Staff only permission has no actual effect while this list is strictly private' message hint is displayed 20. Change 'Category'='Public' and notice the hint is removed 21. Switch back to 'Category'='Private' and 'Allow changes to contents from'='Anyone' 22. Notice the 'The Anyone permission has no actual effect while this list is strictly private.' is displayed 23. Repeat steps 18-22 in the OPAC 24. Create a 'staff only' list in the OPAC and then login as a different user with 'Staff access, allows viewing of catalogue in staff interface (catalogue)' permission enabled. Confirm you are able to add items to this new 'staff only' list. 25. Confirm that the 'Staff only' option is not available to patrons with no special permissions when creating lists in the OPAC Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 jmbroust changed: What|Removed |Added CC||jean-manuel.broust@univ-lyo ||n2.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 David Nind changed: What|Removed |Added Attachment #122022|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 122032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122032=edit Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #85 from Josef Moravec --- (In reply to Katrin Fischer from comment #84) > I think for off by default we should add an actual preference instead of > using CSS. But the CSS will hopefully help for now :) > > We had no comments this or that way from our mostly academic/special > libraries. I imagine the feature might be interesting mostly for publics? As I remember, the request for this development really came from public library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #84 from Katrin Fischer --- I think for off by default we should add an actual preference instead of using CSS. But the CSS will hopefully help for now :) We had no comments this or that way from our mostly academic/special libraries. I imagine the feature might be interesting mostly for publics? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498
--- Comment #30 from Tadas ---
Comment on attachment 114663
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114663
Bug 26498: Set default expiration date for holds
>From 9fcb4bc1baf12a5471bec6997af4ac41da9a3db7 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen
>Date: Thu, 26 Nov 2020 14:59:42 +0200
>Subject: [PATCH] Bug 26498: Set default expiration date for holds
>
>Koha doesn't automatically set expiration date for holds
>so they can live in the system forever. This patch adds
>new sysprefs to control setting of default expiration
>date for holds. Note that expiration date is only set
>if input field for it is left blank.
>
>To test:
>1. Apply patch and update database.
>2. Enable syspref "DefaultHoldExpirationdate" and set some values
>to "DefaultHoldExpirationdatePeriod" and
>"DefaultHoldExpirationdateUnitOfTime".
>3. Add some holds for patron from staff client or OPAC and leave
>expiration date input field blank.
>=> Holds expiration date should be set according your settings
>4. Disable "DefaultHoldExpirationdate" and repeat step 3.
>=> Expiration date shouldn't be set.
>
>Also prove prove t/db_dependent/Hold.t
>
>Sponsored-by: Koha-Suomi Oy
>
>Signed-off-by: Andrew Isherwood
>---
> Koha/Hold.pm | 15
> ...Set_default_expiration_date_for_holds.perl | 12 ++
> installer/data/mysql/mandatory/sysprefs.sql | 3 +++
> .../admin/preferences/circulation.pref| 18 +++
> t/db_dependent/Hold.t | 23 ++-
> 5 files changed, 70 insertions(+), 1 deletion(-)
> create mode 100644
> installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 7754691238..33f474cfba 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -505,6 +505,21 @@ sub cancel {
> return $self;
> }
>
>+sub store {
>+my ($self) = @_;
>+
>+if ( C4::Context->preference('DefaultHoldExpirationdate')
>+and ( not defined $self->expirationdate or $self->expirationdate eq
>'' ) ){
>+
>+my $period =
>C4::Context->preference('DefaultHoldExpirationdatePeriod');
>+my $timeunit =
>C4::Context->preference('DefaultHoldExpirationdateUnitOfTime');
>+
>+$self->expirationdate( dt_from_string( $self->reservedate )->add(
>$timeunit => $period ) );
>+}
>+
>+$self = $self->SUPER::store;
>+}
>+
> =head3 _move_to_old
>
> my $is_moved = $hold->_move_to_old;
>diff --git
>a/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl
>
>b/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl
>new file mode 100644
>index 00..0fc61b50e4
>--- /dev/null
>+++
>b/installer/data/mysql/atomicupdate/Bug-26498-Set_default_expiration_date_for_holds.perl
>@@ -0,0 +1,12 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+# you can use $dbh here like:
>+# $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" );
>+
>+$dbh->do(q{INSERT IGNORE INTO systempreferences
>(variable,value,options,explanation,type) VALUES
>('DefaultHoldExpirationdate','0','','Automatically set default expiration date
>for holds','YesNo') });
>+$dbh->do(q{INSERT IGNORE INTO systempreferences
>(variable,value,options,explanation,type) VALUES
>('DefaultHoldExpirationdatePeriod','0','','How long into the future default
>expiration date is set to be.','integer') });
>+$dbh->do(q{INSERT IGNORE INTO systempreferences
>(variable,value,options,explanation,type) VALUES
>('DefaultHoldExpirationdateUnitOfTime','days','days|months|years','Which unit
>of time is used when settimg default expiration date. ','choice') });
>+
>+# Always end with this (adjust the bug info)
>+NewVersion( $DBversion, 26498, "Bug 26498 - Add option to set a default
>expire date for holds at reservation time");
>+}
>\ No newline at end of file
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql
>b/installer/data/mysql/mandatory/sysprefs.sql
>index 2ea427bdd2..5b6587ee05 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -151,6 +151,9 @@ INSERT INTO systempreferences ( `variable`, `value`,
>`options`, `explanation`, `
> ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum
> number of holds needed to trigger a reduction in loan duration (used with
> decreaseLoanHighHolds)','Integer'),
> ('DefaultClassificationSource','ddc',NULL,'Default classification scheme used
> by the collection. E.g., Dewey, LCC, etc.','ClassSources'),
> ('DefaultCountryField008','','','Fill in the default country code for field
> 008 Range 15-17 of MARC21 - Place of publication, production, or execution.
> See http://www.loc.gov/marc/countries/countries_code.html\;>MARC
> Code List for Countries','Free'),
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #26 from Henry Bolshaw --- Sorry Alex, I've not had a chance to look yet but I'll try and do some testing this week. The new functionality sound great though! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #25 from Alex Buckley --- Hi Henry and Andrew, Just wondering if either of you have had time to re-test the patchset with the follow-up patch in place now? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Please remember: - The title of the bug report describes shortly what the *problem is* - The title of the patch describes shortly what the *patch does* https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #45 from Arthur Suzuki --- Joubu, can you revert? otherwise I cannot apply to master (conflicts) + if solving the problem in master i'm afraid to run into issues applying the patch afterward (fake ancestor). Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #13 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > I would love to move all libs to a libs/ dir, but lets do it on a separate > bug, and discuss the tradeoffs there (my butt has been kicked a couple times > when I proposed it, because of all bugzilla patches not applying if we did > that). Quick remark: this is not true. Git handles that (ie. if a file has been "git mv", a "git am" will follow the move). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl preselect user library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 --- Comment #1 from Fridolin Somers --- Created attachment 122022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122022=edit Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
