[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #110886|0 |1 is obsolete|| --- Comment #22 from Emmi Takkinen --- Created attachment 122355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122355=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #3 from Magnus Enger --- This is an awesome idea! We have the data, we just need to figure out how to display it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28442] Release team 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #20 from wainuiwitikap...@catalyst.net.nz --- Will backport for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #85 from Tomás Cohen Arazi --- (In reply to wainuiwitikapark from comment #84) > (In reply to Jonathan Druart from comment #83) > > Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin > > injecting REST API route to test the patches before you push them. > > Thanks Jonathan. They applied cleanly to my branch, but I won't test and > push them up until the next release (19.11.20). I can test in the morning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 --- Comment #11 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? If so, this would be for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #48 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20 (next release in July)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #25 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.20 (next release in July)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #84 from wainuiwitikap...@catalyst.net.nz --- (In reply to Jonathan Druart from comment #83) > Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin > injecting REST API route to test the patches before you push them. Thanks Jonathan. They applied cleanly to my branch, but I won't test and push them up until the next release (19.11.20). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28538] Regression - Date of birth entered without correct format causes internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28538 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28487] Overdue_notices does not fall back to default language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28487 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #17 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28482] Floating point math prevents items from being returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28482 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #15 from wainuiwitikap...@catalyst.net.nz --- Should this be backported to 19.11.x? For 19.11.19? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #0) > This script is used by command line scripts to load the Koha lib. > Should not we rely on PERL5LIB instead? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383
--- Comment #6 from David Cook ---
(In reply to Jonathan Druart from comment #3)
> I am not convinced here, we may want to replace it from .pl but keep
> C4::Context->IsSuperLibrarian for modules. Then we are not able to remove it
> and still use the code in two places.
>
> Any suggestions?
Another option could be something like this:
my $is_superlibrarian = Koha::Auth->is_superlibrarian({
borrowernumber => $borrowernumber,
});
my $is_superlibrarian = Koha::Auth->is_superlibrarian({
patron => $patron,
});
The only downside of that would be needing to add "use Koha::Auth", although I
suppose we could add that into C4::Auth, which is called in the .pl scripts
because they need the "get_template_and_user" function.
Alternatively, you could write Koha::Patron->is_superlibrarian to be used as
either a class method or an object method. You just check whether $self is a
string or a reference to an object. If it's a class method (ie $self is a
string), you could require a "patron" or "borrowernumber" parameter.
That way you're keeping the code in one place but you're allowing for 2
different ways of calling it.
There's some ideas :D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383
--- Comment #5 from David Cook ---
Comment on attachment 122341
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341
Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with
Koha::Patron->is_superlibrarian
Review of attachment 122341:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=26383=122341)
-
::: C4/Circulation.pm
@@ +1073,5 @@
> +
> +my $userenv = C4::Context->userenv;
> +if ( C4::Context->preference("IndependentBranches") && $userenv ) {
> +my $logged_in_user = Koha::Patrons->find($userenv->{number});
> +unless ( $logged_in_user->is_superlibrarian ) {
I suppose a more optimal design would be to pass the issuer to CanBookBeIssued
via a parameter, but that would probably be too dramatic a refactor for us to
do at this point...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383
--- Comment #4 from David Cook ---
Comment on attachment 122341
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341
Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with
Koha::Patron->is_superlibrarian
Review of attachment 122341:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=26383=122341)
-
::: C4/Circulation.pm
@@ +1073,5 @@
> +
> +my $userenv = C4::Context->userenv;
> +if ( C4::Context->preference("IndependentBranches") && $userenv ) {
> +my $logged_in_user = Koha::Patrons->find($userenv->{number});
> +unless ( $logged_in_user->is_superlibrarian ) {
Technically, the session stores the flags value, so we could just do the
calculation off the session data. The only downside of doing that is that we
probably only set the flags session data at login time, so if someone's
permissions change while they're logged in, it won't be detected until they've
logged out and logged back in. But... it would mean fewer database calls.
If we're doing a multi-checkout, the number of database calls would increase by
that factor...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from David Cook --- I should've actually marked this as Failed QA previously. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Attachment #122289|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 122354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122354=edit Bug 28565: Refactor tests Tests were too complex with no gain. They even deleted the whole DB to run (inside a transaction). I refactored to test the same thing, and make it rely (mostly) on existing data. _count behavior is tested implicitly by comparing with Koha::*->count. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28565] Adding a new syspref for sharing through HEA should be simpler
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28565 David Nind changed: What|Removed |Added Attachment #121986|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 122353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122353=edit Bug 28565: Move the sysprefs to a reusable sub This patch moves the big sysprefs list to a sub. Behavior shouldn't change. To test: 1. Run: $ kshell k$ prove t/db_dependent/UsageStats.t => SUCCESS: Things work as expected, no changes. 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Lucas Gass changed: What|Removed |Added Attachment #120027|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 122352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122352=edit Bug 28196: make sure URL hash is appended last TO test: 1 Do a search within the staff client 2 Click on any results and go to the detail page 3 Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem=55=117#edititem=scs_1619109565224' 4 Apply patch 5 Do steps 1 & 2 again Click the edit button on any item in that record, it should take you to a URL like this: '/cgi-bin/koha/cataloguing/additem.pl?op=edititem=55 ber=117=scs_1619109565224#edititem' 6. If they URL hash is last the anchor should work and you'll be placed on the h2 element with and ID of edititem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 --- Comment #2 from Katrin Fischer --- Yes, one of our libraries suggested this today - so not mine, but I got to file it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28621] Make circulation conditions visible for patrons in patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Do you mean, like, a place in the patron account section of the OPAC where a patron could see how the circ rules apply to them for various item types? That sounds really cool! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28442] Release team 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in|| --- Comment #10 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|21.05.00,20.11.07 |21.05.00,20.11.07,20.05.13 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #47 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.13 After around 130 conflicts! (How did Frido, Kyle and Nick dealt with this?) Hint in case Wainui gets the same thing: Solve the individual conflicts as usual. When getting a 60 conflicts pack, just rapidly skim through then without solving to confirm that it will be safe to do `git checkout --theirs MY_FILE` It was safe in my case (noticed after manually solving the 60 ones...) There is another 60 conflicts pack, do the same as above. The timeline in the about page isn't broken, so that seems to work ^^ and Jonathan told me that we should keep the commit numbers from upstream, not the one from our branch. And it's not used anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 Hakam Almotlak changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #19 from Hakam Almotlak --- thanks for the explaining i tested it and it works perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 Hakam Almotlak changed: What|Removed |Added Attachment #109369|0 |1 is obsolete|| --- Comment #18 from Hakam Almotlak --- Created attachment 122351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122351=edit Bug 20206: Find barcodes with more or less leading zeroes Test plan: Pick an item, change barcode to e.g. 0123456 Create a barcode file with 123456. Run inventory with it. Should be found and modified. Change barcode file by modifying 123456 to 00123456. Same result. Change barcode of another item to 000123456. Run inventory again on same barcode file: 0 modified, warn on duplicates? Signed-off-by: Marcel de Rooy Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #17 from Hakam Almotlak --- thanks for the explaining i tested it and it works perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26614] Diacritics taken into account in facet sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26614 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Hakam Almotlak --- patch does not apply. Using index info to reconstruct a base tree... M C4/Search.pm Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 26614 - Diacritics taken into account in facet sorting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28623] Fails to connect to server do not get response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623 --- Comment #1 from Humberto Blanco --- I try to connect from console with yaz-client but get the same error /etc/koha/sites/catalog# yaz-client tcp:localhost:2200 Connecting...OK. Sent initrequest. Target closed connection I believe that maybe need another conf in koha-conf.xml or z3950/config.xml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #21 from Tomás Cohen Arazi --- Please fix the test name while rebasing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #20 from Hakam Almotlak --- patch does not apply on master Applying: Bug 15156: Get all patrons with owings Using index info to reconstruct a base tree... M Koha/Patrons.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patrons.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15156: Get all patrons with owings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Hakam Almotlak changed: What|Removed |Added Attachment #114376|0 |1 is obsolete|| --- Comment #7 from Hakam Almotlak --- Created attachment 122350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122350=edit Bug 22038: Fix excel export if CurrencyFormat is FR DataTables excel export is broken if number decimal separator is a comma. Test plan: 1 - Set syspref CurrencyFormat to US 2 - Export as excel a table with decimal numbers, patrons list with fines for example. 3 - Open in libreoffice or excel, numbers are ok. 4 - Set syspref CurrencyFormat to FR 5 - Export and open again, number are wrong 25,10 is imported as 2510 6 - Apply patch 7 - Redo 1 to 4 8 - Excel export, number is 25,10 Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #4 from Hakam Almotlak --- hey i applied the patch and it did`t work i still get the last bar code number plus one and without the zeros at the begging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #7 from Hakam Almotlak --- without the patch the problem exist when you try to search within the catalogues but it does not exist when you search for a catalogue then you try to edit an item from the same catalogue. after the patch it does not fix the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28623] New: Fails to connect to server do not get response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623 Bug ID: 28623 Summary: Fails to connect to server do not get response Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: hblanc...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I'm trying to connect to koha through a z3950 client, when I telnet to port 2200 it works ok, but if I connect from a software like marcedit I get a "connection lost" error and I can't recover any records I try doing tcpdump about conection and found that only incoming but not outgoing traffic found #tcpdump port 2200 | grep 10.212.134.96 10:32:29.617092 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [S], seq 4015169908, win 64896, options [mss 1352,nop,wscale 8,nop,nop,sackOK], length 0 10:32:29.617106 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [S.], seq 2610785618, ack 4015169909, win 64240, options [mss 1460,nop,nop,sackOK,nop,wscale 7], length 0 10:32:29.628422 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [.], ack 1, win 6147, length 0 10:32:29.628528 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [P.], seq 1:89, ack 1, win 6147, length 88 10:32:29.628534 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [.], ack 89, win 502, length 0 10:32:29.698466 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [F.], seq 1, ack 89, win 502, length 0 10:32:29.703413 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [.], ack 2, win 6147, length 0 10:32:29.703477 IP 10.212.134.96.60735 > srvkoha.urosario.edu.2200: Flags [F.], seq 89, ack 2, win 6147, length 0 10:32:29.703486 IP srvkoha.urosario.edu.2200 > 10.212.134.96.60735: Flags [.], ack 90, win 502, length 0 Any idea? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28211] Replace use of call_recursive() with call()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 --- Comment #7 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #6) > I would recommend to merge this report with the call_recursive report. Both > are signed off. We could eliminate the code we actually do not want to push. > > The call_recursive name was a bit misleading too btw. The two bugs are on the other sides of 26351 and 26352. Merging them would require modifying the patches for those bugs, both of which have passed qa. I think we should simply push the four bugs as a unit rather than risk introducing regressions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 --- Comment #14 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #13) > Please merge with the other one I'm not sure what bug you are referring too, but this is a series of 4 bugs now, so I don't think that would be practical. It would require modifying two bugs that are already passed qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Attachment #107485|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 122349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122349=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Attachment #107484|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 122348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122348=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Attachment #107483|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 122347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122347=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #19 from Martin Renvoize --- Oh, totally forgot about this one, I'm really sorry Emmi. I actually introduced a similar method in bug 11983 though.. so perhaps worth comparing. I'll try to bring that one back up to date, updating tests etc.. it's been on my list for a long time :S -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #3 from Marcel de Rooy ---
When seeing this, I wonder right away why not the other one?
-my $query= $operands[0];
+my $query= $operands[0] // "";
my $simple_query = $operands[0];
And looking a bit later, I see:
for ($query_cgi,$simple_query) {
s/"//g;
}
Shouldnt this trigger a warn too when undefined?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356
Hakam Almotlak changed:
What|Removed |Added
Attachment #122345|0 |1
is obsolete||
--- Comment #4 from Hakam Almotlak ---
Created attachment 122346
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122346=edit
Bug 28356: Consolidate catalogue search box code
To test:
1 - Apply patch
2 - Confirm searchign the catalog works from:
Administration->Budgets
Cataloging
Circulation->Check in
Administration->Cities and towns
Acquisitions->{Vendor}->Contracts
Administration->Currencies
Administration->Circulation desks (requires UseCirculationDesks
preference)
Home
Tools->Notices and slips
Patrons
Adminstration
Serials
Acquisitions->Suggestions
Administration->Z39.50/SRU servers
Signed-off-by: hakam
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356
Hakam Almotlak changed:
What|Removed |Added
Attachment #120978|0 |1
is obsolete||
--- Comment #3 from Hakam Almotlak ---
Created attachment 122345
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122345=edit
Bug 28356: Consolidate catalogue search box code
To test:
1 - Apply patch
2 - Confirm searchign the catalog works from:
Administration->Budgets
Cataloging
Circulation->Check in
Administration->Cities and towns
Acquisitions->{Vendor}->Contracts
Administration->Currencies
Administration->Circulation desks (requires UseCirculationDesks
preference)
Home
Tools->Notices and slips
Patrons
Adminstration
Serials
Acquisitions->Suggestions
Administration->Z39.50/SRU servers
Signed-off-by: hakam
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 --- Comment #4 from Marcel de Rooy --- uri_escape_utf8( $string, $unsafe ) Works like uri_escape(), but will encode chars as UTF-8 before escaping them. This makes this function able to deal with characters with code above 255 in $string. Note that chars in the 128 .. 255 range will be escaped differently by this function compared to what uri_escape() would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28603] check-url-quick.pl does not encode spaces in urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28603 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- $url = encode_utf8($url); +$url = uri_escape( $url, " " ); Normally we escape with uri_escape_utf8. This appears to be not exactly the same. Please explain why we should do so? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #32 from Nick Clemens --- (In reply to Marcel de Rooy from comment #30) > Please cleanup your patches! > Please amend the first patch where you delete the buggy lines too ;) Patches squashed, back to NSO (In reply to Marcel de Rooy from comment #29) > # found warning: Use of uninitialized value in string eq at > /usr/share/koha/C4/Biblio.pm line 2632. > # found warning: My biblionumber is 130 and my frameworkcode is at > t/db_dependent/Biblio.t line 78. > # expected to find warning: (?^u:My biblionumber is \d+ and my > frameworkcode is ) > # Looks like you failed 5 tests of 5. > not ok 2 - AddBiblio I get the extra warning if i run the test before the DB update, but all is good after -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Attachment #119704|0 |1 is obsolete|| Attachment #121805|0 |1 is obsolete|| Attachment #122301|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 122344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122344=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set A 'duplication' option is add to svc/bib and rancor passes the parameter, the basic editor simply removes the field To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To testi duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What|Removed |Added Attachment #122172|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 122343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122343=edit Bug 28601: Fix 'Home' breadcrumd on circulation-home.pl To test: 1 - Got to 'Circulation' 2 - Click 'Home' in breadcrumbs 3 - You are still in circulation home 4 - Apply patch 5 - reload page 6 - Click 'Home' 7 - Success! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What|Removed |Added Attachment #122173|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 122342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122342=edit Bug 28571: Remove C4::Auth::_session_log It's not used and must be removed Test plan: % git grep _session_log must not return any result. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #3 from Jonathan Druart --- I am not convinced here, we may want to replace it from .pl but keep C4::Context->IsSuperLibrarian for modules. Then we are not able to remove it and still use the code in two places. Any suggestions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383 --- Comment #2 from Jonathan Druart --- Created attachment 122341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122341=edit Bug 26383: WIP Replace C4::Context->IsSuperLibrarian with Koha::Patron->is_superlibrarian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens changed: What|Removed |Added Attachment #122337|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 122340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122340=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26383] Koha::Patron->is_superlibrarian is not optimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26383
--- Comment #1 from Jonathan Druart ---
Just had another look at this one. The problem is that we are calling it from
modules, and have to Koha::Patrons->find($userenv->{number}) when, before, we
had just to return $flags % 2
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #4 from Hakam Almotlak --- patch does not apply error: sha1 information is lacking or useless (Koha/BackgroundJob.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26080: Use the task queue for batch delete biblios hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26080-Use-the-task-queue-for-batch-delete-bibl-KTCIJD.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Jonathan Druart changed: What|Removed |Added Summary|selected branchcode not |Selected branchcode not |passed to adv search|passed to adv search? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28600] Variable "$patron" is not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28622] selected branchcode not passed to adv search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
--- Comment #1 from Jonathan Druart ---
Created attachment 122339
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122339=edit
Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv
search
From
commit df97814f3034a3d5015546c4eca21f08ae951e37
Bug 15758: Koha::Libraries - Remove GetBranches
+selected_branchcode => ( C4::Context->IsSuperLibrarian ?
C4::Context->userenv : '' ),
And
-[% PROCESS options_for_libraries libraries => Branches.all() %]
+[%# FIXME Should not we filter the libraries displayed? %]
+[% PROCESS options_for_libraries libraries => Branches.all( selected
=> selected_branchcode, unfiltered => 1 ) %]
The change in the pl is wrong as it should pass C4::Context->userenv->{branch},
but prior to this commit it seems that we didn't select the logged in
library anyway.
Looks like we should remove this code.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28622] selected branchcode not passed to adv search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28600] Variable "$patron" is not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What|Removed |Added Attachment #122207|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 122338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122338=edit Bug 28600: Resolve variable scope issue This patch fixes a scope issue. Originally, a variable declared as our $borcat was replaced by my $patron This patch makes the method not rely on global variables, but have a parameter for the patron, and thus things are clearer. To test: 1. Open the OPAC detail page for a record => FAIL: The logs show some errors about the $patron variable not available in the scope 2. Apply this patch 3. Repeat 1 => SUCCESS: No errors 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28600] Variable "$patron" is not available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #6 from Hakam Almotlak --- the button works and everything but when i try to search something or click on anything in the search bar, the search bar disappear even if i press on the options in the search bar like check in and check out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28026] Add a 'call_recursive' method to Koha::Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- Please merge with the other one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28211] Replace use of call_recursive() with call()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- I would recommend to merge this report with the call_recursive report. Both are signed off. We could eliminate the code we actually do not want to push. The call_recursive name was a bit misleading too btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What|Removed |Added Attachment #122336|0 |1 is obsolete|| --- Comment #5 from Hakam Almotlak --- Created attachment 122337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122337=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak changed: What|Removed |Added Attachment #121421|0 |1 is obsolete|| --- Comment #4 from Hakam Almotlak --- Created attachment 122336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122336=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected Signed-off-by: hakam -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What|Removed |Added Blocks||28622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622 [Bug 28622] selected branchcode not passed to adv search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28622] New: selected branchcode not passed to adv search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622
Bug ID: 28622
Summary: selected branchcode not passed to adv search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+k...@gmail.com
Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 15758
From
commit df97814f3034a3d5015546c4eca21f08ae951e37
Bug 15758: Koha::Libraries - Remove GetBranches
selected_branchcode => ( C4::Context->IsSuperLibrarian ?
C4::Context->userenv : '' ),
We must pass C4::Context->userenv->{branch}
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #62 from Hakam Almotlak --- patch does not apply Applying: Bug 14367: Add MARC record history Using index info to reconstruct a base tree... M C4/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14367-Add-MARC-record-history-1fUpWI.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28621] New: Make circulation conditions visible for patrons in patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28621 Bug ID: 28621 Summary: Make circulation conditions visible for patrons in patron account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org It would be a nice feature if it was possible to display the circulation conditions, like loan periods, number of possible renewals etc. for a patron in the patron account. The display should take the home library and patron category into account, so it doesn't have to be maintained manually and is as specific as possible, leaving anything out that doesn't apply to the patron looking at it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27151] SIP2 server doesn't handle broken connections which then kills SIP2 server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #16 from Marcel de Rooy --- (In reply to Hakam Almotlak from comment #15) > Hey i applied the patch and created an item with 0123456 then another item > with 00123456 and i tried to check in with the code 123456 and it says no > item with this code. > i checked the database and the code 0123456 and 00123456 exist in the > database, but i can`t find it when i check in it does not exclude the zeros > at the begging of the code. Hi Hakam, Thx for testing. This patch only deals with the Tools/Inventory program. So it does not include the regular checkin. Please try the barcodes you created in the test plan of this patch with the tools/inventory script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28587] ldap auth fails unless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28587 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Version|21.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615 --- Comment #16 from Jonathan Druart --- There is Test::Log4perl, but we will need to adjust all our test files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #83 from Jonathan Druart --- Wainui, I rebased the patches for 19.11.x but I'd like someone with a plugin injecting REST API route to test the patches before you push them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #82 from Jonathan Druart ---
Created attachment 122335
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122335=edit
Bug 23653: [19.11] Add license information in about.pl
Signed-off-by: Tomas Cohen Arazi
JD Amended patch
The included https://github.com/OAI/OpenAPI-Specification/blob/master/schemas/v2.0/schema.json;>api/swagger-v2-schema.json
file is licensed under the[-the-] https://github.com/OAI/OpenAPI-Specification/tree/master/schemas/v2.0;>Apache
License, Version 2.0, by the https://www.openapis.org/about;>OpenAPI Initiative
[-(OAI)-]{+(OAI).+}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #81 from Jonathan Druart --- Created attachment 122334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122334=edit Bug 23653: [19.11] Remove uneeded cond test rel_file returns the path anyway Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #80 from Jonathan Druart --- Created attachment 122333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122333=edit Bug 23653: [19.11] use local copy of swagger v2 schema By default, JSON::Validator::OpenAPI tries to fetch the swagger v2 schema from http://swagger.io/v2/schema.json. If you've installed from CPAN, JSON::Validator::OpenAPI will come with a cached copy, so it won't try to fetch it over HTTP. However, if you've installed from libjson-validator-perl from Debian/Ubuntu, the Debian package excludes the cached copy, so JSON::Validator::OpenAPI tries to fetch it over HTTP. Unfortunately, today and other days in the past, the file at http://swagger.io/v2/schema.json has been unavailable, and this causes Koha to crash in a perpetual loop. This patch includes a copy of the swagger v2 schema, and it loads it locally rather than fetching over HTTP. The changes to Koha/REST/Plugin/PluginRoutes.pm are not required, since the validator isn't currently called there, but I've added a patch to future proof it. To Test: 0a) Remove /usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df if it exists 0b) Block external access to http://swagger.io/v2/schema.json or test during an outage when it's unavailable 0c) Do not apply patch 1) koha-plack --restart kohadev 2) Note that it crashes in a loop and is unavailable in web browser 3) Apply patch 4) koha-plack --restart kohadev 5) Note that Koha comes up and there are no errors in the Plack logs Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Jonathan Druart changed: What|Removed |Added Attachment #121875|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 122332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122332=edit Bug 28480: (QA follow-up) Add unit test Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Fixed bug number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #36 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28581] Patron's queue_notice uses inbound_email_address incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28516] Koha/Patrons/Import.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28516 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28480] GET /patrons missing q parameters on the spec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28480 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
